[00:14:44] Hi! [00:15:36] I've moved the downloaded mediawiki-1.19.1-dir to /var/www/mediawiki, but what's next to start setting it up? [00:15:47] I tried typing localhost..........that didn't help. [00:15:50] Brooke: No it doesn't [00:16:00] I have installed all the needed stuff AFAIK. [00:16:16] I use Apache & phpmyadmin. [00:16:26] Should I just load phpmyadmin in Terminal? [00:16:28] Krenair: I was waiting for Jenkins but I didn't notice it was an extension, sorry [00:17:15] Umeaboy, browse to localhost/mediawiki [00:17:43] localhost/ is basically /var/www/, so the next logical step is localhost/mediawiki [00:21:11] Hmmmmmmmmmmm. /usr/share/mediawiki seems to be my dir to put the folder in. [00:21:13] Weird. [00:21:27] I'm used to use /var/www/mediawiki [00:21:32] Anyone here have contact with a google developer who could fix this? https://www.mediawiki.org/wiki/Thread:Project:Support_desk/Google_spreadhseets%27_ImportXML_not_allowed._Is_Google%27s_user-agent_blacklisted%3F [00:21:39] RoanKattouw: It seems kind of strange that editing is still done client-side. [00:23:41] For some things. [00:23:53] Does any Git frontend have editing capability? [00:24:21] I think github does to some degree? [00:24:31] I think so too. [00:25:08] It's strange to look at the evolution of wikis and how they mirror code review development tools (and their evolution). [00:26:59] Yes, github definitely does [00:27:53] It lets you edit a file and commit it straight into the repo [00:31:43] 03(mod) Login should only be required when uploading photos - 10https://bugzilla.wikimedia.org/39711 +comment (10Phil Chang) [00:32:01] hey folks, anyone here played with the python-mwclient [00:33:56] I want to use a python script to update some wiki pages. However, I need to post some URLs, which requires some captcha solving. [00:34:14] Is there a way I can retrieve the captcha, and send the answer back using the script? [00:38:42] Krenair: I installed task-lamp & did the secure installation of mysql, but still can't access the wiki. [00:39:09] Umeaboy, what do you mean can't access it? [00:40:16] Krenair: Nothing happens when I try to start myphpadmin from KDE-menu. Am I doing it the wrong way? [00:41:37] Umeaboy, you shouldn't need phpmyadmin to use mediawiki [00:42:33] OK, but how am I supposed to set it up then? [00:44:48] All you need to do with MySQL is create the database [00:44:49] the MW installer can handle the rest [00:44:49] log into mysql and run CREATE DATABASE [00:45:12] I see that mysqld is running. [00:45:12] 03(NEW) Default file uploader seems to be broken on the English Wikipedia - 10https://bugzilla.wikimedia.org/39779 major; Wikimedia: General/Unknown; (b) [00:45:15] So far so good. [00:45:34] 03(mod) Default file uploader is broken on the English Wikipedia - 10https://bugzilla.wikimedia.org/39779 summary (10MZMcBride) [00:45:46] 03(mod) Default file uploader is broken on the English Wikipedia - 10https://bugzilla.wikimedia.org/39779 (10MZMcBride) [00:47:17] 14(INVALID) Default file uploader is broken on the English Wikipedia - 10https://bugzilla.wikimedia.org/39779 +comment (10Krenair) [00:48:42] Krenair: How do I login to mysql then? [00:48:58] 04(REOPENED) Default file uploader is broken on the English Wikipedia - 10https://bugzilla.wikimedia.org/39779 +comment (10MZMcBride) [00:49:52] Umeaboy, mysql -u username -p [00:50:04] if you don't know the username it's probably root [00:50:56] 14(INVALID) Default file uploader is broken on the English Wikipedia - 10https://bugzilla.wikimedia.org/39779 +comment (10Krenair) [00:51:03] Krenair: ERROR 1045 (28000): Access denied for user 'root'@'localhost' (using password: NO) [00:51:19] Did you use -p? [00:51:49] And specify a password when asked for one? [00:51:55] Hmmmmmmmmmm. No database found. [00:52:06] where do you see that? [00:52:08] I did mysql_secure installation. [00:52:43] http://pastebin.ca/2199251 [00:53:03] 04(REOPENED) Default file uploader is broken on the English Wikipedia - 10https://bugzilla.wikimedia.org/39779 +comment (10MZMcBride) [00:53:10] Krenair: Honest-to-God. [00:53:25] You're really going to sit here and bugwar with me over a valid bug? [00:53:40] There is an issue, but it is not valid in bugzilla [00:53:50] Why on Earth do you think that? [00:54:08] It's caused purely by a broken script set up by the wiki admins [00:54:16] Krenair: Says who? [00:54:18] Their problem, not the developers' [00:54:22] Well, no. [00:54:32] Says the error message you pasted [00:54:40] Wikimedia uses Bugzilla to track technical problems with the wiki. [00:54:52] If users on a Wikimedia wiki can't upload using the default uploader, that's a bug. [00:54:56] Anyway, [00:55:04] Brooke, why do you need built-in edit? [00:55:05] I have to go. [00:55:20] Dantman: I don't need it, but it seems kind of silly that the feature is missing. [00:55:28] Meh [00:55:28] Doc comments, e.g. [00:55:41] 03(mod) coords 0, 0 used for monuments without coordinates - 10https://bugzilla.wikimedia.org/39476 +comment (10Jon) [00:55:51] They can use the default uploader in the software, just not this special (broken) one created by the wiki's community [00:56:05] All it really needs is access to quick-open/open [00:56:12] Preaching to the choir on this one, Krenair. [00:56:14] Double click and edit [00:56:21] I agree with you that they shouldn't be using this monster. [00:56:24] But they are anyway. [00:56:27] Krenair: What else do I need to do? [00:56:33] So someone has to support it. [00:57:04] No one except the wiki's community need to support it [00:57:05] 03(FIXED) WLMMobile: rounding errors on border around progress bar on hdpi device - 10https://bugzilla.wikimedia.org/38507 (10Jon) [00:57:17] Umeaboy, it's mysql -u root -p [00:57:44] [kristoffer@localhost ~]$ mysql -u root [00:57:44] ERROR 1045 (28000): Access denied for user 'root'@'localhost' (using password: NO) [00:57:47] So wrong. [00:58:00] Krenair: You saw that the MediaWiki page hasn't been edited since July 2012? [00:58:13] I created a password for root yes. [00:58:29] mysql -u root password ? [00:58:29] Umeaboy, mysql -u root -p [00:58:30] Not mysql -u root [00:58:36] NO [00:58:39] OK. [00:58:42] MYSQL -U ROOT -P [00:58:59] I don't understand how I can possibly make it more clear [00:59:01] -p [00:59:24] Where's a good place to put your own maintenance script? [00:59:25] Brooke, what page? [00:59:27] The script? [00:59:32] Krenair: Yes. [00:59:37] i10neorg, I would suggest the maintenance directory [00:59:40] Yes I saw that [00:59:41] Though it's now been edited by a few developers. ;-) [00:59:42] That's the problem script [00:59:45] Yes. [00:59:48] Krenair: http://pastebin.ca/2199256 [00:59:50] Now what? [00:59:54] Well, it wasn't a problem before today. [00:59:57] In theory. [01:00:45] 03(NEW) Global blocks message issues - 10https://bugzilla.wikimedia.org/39780 normal; MediaWiki extensions: GlobalBlocking; (jasper) [01:01:06] Krenair: Thanks. I was just worried it might get stomped during upgrades if it's somewhere the original install had in place. [01:01:45] I'm coming from drupal where there are certain appropriate places for custom files. [01:02:03] Brooke, the problem might be that it's not compatible with the new version of jQuery deployed today [01:02:27] In which case the bug STILL is not valid [01:03:01] Umeaboy, CREATE DATABASE [01:03:28] And a semi-colon I think [01:03:30] Krenair: It's fixed now anyawy [01:03:47] 03(FIXED) Default file uploader is broken on the English Wikipedia - 10https://bugzilla.wikimedia.org/39779 +comment (10MZMcBride) [01:03:47] Krenair: They had a syntax error in a selector, and apparently 1.8 throws nastier errors for those [01:09:30] Krenair: Query OK, 1 row affected (0.00 sec) [01:09:32] Now what? [01:09:56] So now you should be able to browse to your wiki installer and follow the instructions there [01:12:22] so hewiki was upgraded to wmf10, and there is some breakage in JS, and more specifically in jQuery (upgraded to 1.8.0) [01:12:34] Krenair: Nope. [01:12:52] http://localhost/mediawiki doesn't exist according to Chrome. [01:12:57] kipod_, okay, so enwiki just had a similar problem. can you give some details? [01:13:01] what does it mean when mysql says 5 rows in set, 1 warning (in regards to the warning?_ [01:13:07] the problem has to do with (somewhat) comples selectors. same issue exists in enwiki too, i believe. [01:13:10] Umeaboy, okay, so where did you install mediawiki? [01:13:38] I thought you said /var/www/mediawiki/ ? [01:14:12] Krenair_, the problem seems to come from function tokenize() in the new sizzle. [01:14:45] do you have some sort of error I can see? [01:15:19] Krenair_: here is an example to a selector that breaks: go to page history (any page). we want to get all the radio buttons, so we use $('input:[type=radio]') [01:16:14] Krenair_: used to work beautifully with previous jquery. same selector actually _does_ work on the jquery site, but it breaks in hewiki and enwiki. [01:17:07] kipod_: Well that's not actually a valid selector [01:17:12] You want $('input[type=radio]') [01:17:23] So just get rid of the : [01:17:24] The colon doesn't belong there [01:17:35] oh, roan beat me to it >_> [01:17:42] The actual bugs in the code were stray dots, actually, like $('#formname .[type=foo]') [01:18:02] yes, i forgot it here, but not on hewiki and enwiki. the selector that throws exception is really (('input:[type=radio]') [01:18:52] TimStarling: "so many things to do"? :) [01:19:11] is your job queue backing up? [01:19:16] how do you mean? the jquery documentation shows $('input:type=radio]'), and it used to work in jquery 1.7.2 [01:19:37] kipod_: Oh, sorry, I was talking about a different bug in a different script then, they were using '#form .[type=file]' [01:19:48] kipod_: Where does the jQuery documentation show that? [01:19:49] Krenair: Can we talk in PM? [01:19:53] yes [01:19:57] OK. [01:20:00] I would be /extremely/ surprised if the jQuery docs had that as an example, that would be bad [01:20:09] betch their selector failed also. tokenize() is butched. [01:20:43] A : immediately followed by a [ is invalid. Maybe it shouldn't die as hard as it does now in 1.8 but it's still invalid [01:21:09] 03(mod) Default file uploader is broken on the English Wikipedia - 10https://bugzilla.wikimedia.org/39779 +comment (10Thehelpfulone) [01:23:37] well, you guys are correct - the : does not appear in the documentation, and without it the selector works. the mystery now is double: why did i put it there in the first place (i think it was in previous docs or example), and how come it did work with 1.7.2 ? [01:23:54] 1.7 was probably more tolerant of that kind of stuff than 1.8 I guess [01:24:04] enwiki's upload wizard thingy also broke because of bad selectors [01:24:55] possible, but i still find it hard to accept that i made up the idea that a colon was needed.... well, live and learn, i guess. peace. [01:29:08] Thanks, guys. was a great help. peace. [01:32:20] 03(NEW) Add a new openstack network in pmtpa - 10https://bugzilla.wikimedia.org/39781 normal; Wikimedia Labs: General; (rlane32) [01:38:16] 03(NEW) Switch instances to use virtio network adapters - 10https://bugzilla.wikimedia.org/39782 normal; Wikimedia Labs: General; (faidon) [01:42:01] 03(NEW) Move from nfs instance to project storage (the home share) for home directories - 10https://bugzilla.wikimedia.org/39783 normal; Wikimedia Labs: General; (rlane32) [01:45:43] 03(NEW) Create a labs SMTP smarthost - 10https://bugzilla.wikimedia.org/39785 normal; Wikimedia Labs: General; (faidon) [01:46:38] 03(NEW) Change the mount point for homedirs from user directories to all of /home and use pam_mkhomedir - 10https://bugzilla.wikimedia.org/39786 normal; Wikimedia Labs: General; (rlane32) [01:46:43] 03(mod) Labs infrastructure work (tracking) - 10https://bugzilla.wikimedia.org/39784 (10Faidon Liambotis) [01:46:43] 03(mod) Enable ipv6 on labs - 10https://bugzilla.wikimedia.org/35947 (10Faidon Liambotis) [01:46:45] 03(mod) Add a new openstack network in pmtpa - 10https://bugzilla.wikimedia.org/39781 (10Faidon Liambotis) [01:46:46] 03(mod) Switch instances to use virtio network adapters - 10https://bugzilla.wikimedia.org/39782 (10Faidon Liambotis) [01:46:46] 03(mod) Create a labs SMTP smarthost - 10https://bugzilla.wikimedia.org/39785 (10Faidon Liambotis) [01:47:07] 03(mod) Change the mount point for homedirs from user directories to all of /home and use pam_mkhomedir - 10https://bugzilla.wikimedia.org/39786 (10Ryan Lane) [01:47:07] 03(mod) Move from nfs instance to project storage (the home share) for home directories - 10https://bugzilla.wikimedia.org/39783 (10Ryan Lane) [01:49:06] 03(mod) Move from nfs instance to project storage (the home share) for home directories - 10https://bugzilla.wikimedia.org/39783 (10Ryan Lane) [01:49:06] 03(mod) Labs infrastructure work (tracking) - 10https://bugzilla.wikimedia.org/39784 (10Ryan Lane) [01:51:12] 03(NEW) Add more network nodes - 10https://bugzilla.wikimedia.org/39787 normal; Wikimedia Labs: General; (faidon) [01:51:37] 03(mod) Labs infrastructure work (tracking) - 10https://bugzilla.wikimedia.org/39784 (10Faidon Liambotis) [01:51:39] 03(mod) Add more network nodes - 10https://bugzilla.wikimedia.org/39787 (10Faidon Liambotis) [01:51:56] 03(NEW) Enable passwordless sudo for instances - 10https://bugzilla.wikimedia.org/39788 normal; Wikimedia Labs: General; (rlane32) [01:51:58] 03(mod) Labs infrastructure work (tracking) - 10https://bugzilla.wikimedia.org/39784 (10Ryan Lane) [01:52:33] 03(FIXED) Initial duplicate check is broken in Firefox, Chrome (not Opera) - 10https://bugzilla.wikimedia.org/37108 +comment (10Ryan Kaldari) [01:54:12] 03(NEW) Add eqiad as a production region - 10https://bugzilla.wikimedia.org/39789 normal; Wikimedia Labs: General; (faidon) [01:54:34] 03(NEW) Sudo policy should use the project group, rather than ALL for users - 10https://bugzilla.wikimedia.org/39790 normal; MediaWiki extensions: OpenStackManager; (rlane32) [01:54:35] 03(mod) Labs infrastructure work (tracking) - 10https://bugzilla.wikimedia.org/39784 (10Faidon Liambotis) [01:54:37] 03(mod) Add eqiad as a production region - 10https://bugzilla.wikimedia.org/39789 (10Faidon Liambotis) [01:55:10] 03(mod) Sudo policy should use the project group, rather than ALL for users - 10https://bugzilla.wikimedia.org/39790 (10Ryan Lane) [01:55:10] 03(mod) Enable passwordless sudo for instances - 10https://bugzilla.wikimedia.org/39788 (10Ryan Lane) [01:59:31] 03(mod) Add eqiad as a production region - 10https://bugzilla.wikimedia.org/39789 +comment (10Ryan Lane) [02:06:24] 03(FIXED) OpenStackManager extension should also support the OpenStack API - 10https://bugzilla.wikimedia.org/26583 +comment (10Ryan Lane) [02:06:32] 03(FIXED) Remove use of nova admin credentials where possible - 10https://bugzilla.wikimedia.org/26678 +comment (10Ryan Lane) [02:06:45] is your job queue backing up? [02:07:04] 03(FIXED) Project creation should be limited to wiki admin rather than cloudadmin - 10https://bugzilla.wikimedia.org/35655 +comment (10Ryan Lane) [02:07:41] 03(mod) Remove use of nova admin credentials where possible - 10https://bugzilla.wikimedia.org/26678 +comment (10Ryan Lane) [02:07:58] 03(mod) OpenStackManager extension should also support the OpenStack API - 10https://bugzilla.wikimedia.org/26583 +comment (10Ryan Lane) [02:08:14] 03(FIXED) Add keystone support - 10https://bugzilla.wikimedia.org/35271 +comment (10Ryan Lane) [02:11:59] my job queue is having some lock contention on insert [02:17:01] 03(mod) Initial duplicate check is broken in Firefox, Chrome (not Opera) - 10https://bugzilla.wikimedia.org/37108 +comment (10Erik Moeller) [02:18:48] 03(FIXED) When a single file in a batch is invalid, only that file should be rejected - 10https://bugzilla.wikimedia.org/39608 +comment (10Erik Moeller) [02:19:39] 03(NEW) HTTP 500 when trying to configure instance - 10https://bugzilla.wikimedia.org/39791 normal; Wikimedia Labs: (other); (ori) [02:46:54] 03(FIXED) Need a way back when trying to upload a file in UploadWizard that already exists - 10https://bugzilla.wikimedia.org/29594 +comment (10Robin Pepermans (SPQRobin)) [02:52:26] 03(mod) Add step-backwards from "thanks" with file errors to "describe" to allow changes if necessary - 10https://bugzilla.wikimedia.org/37468 +comment (10Robin Pepermans (SPQRobin)) [02:59:54] 14(INVALID) Labs infrastructure work (tracking) - 10https://bugzilla.wikimedia.org/39784 +comment (10Jasper Deng) [03:00:02] 04(REOPENED) Labs infrastructure work (tracking) - 10https://bugzilla.wikimedia.org/39784 (10Jasper Deng) [03:00:06] ugh I should slap myself in the face [03:00:21] Go on. [03:00:59] * Jasper_Deng_sick would've slapped himself 3 times if he wasn' [03:01:01] t sick [03:01:46] * Jasper_Deng_sick wonders why a full revert cannot be done on Bugzilla [03:06:51] * Aaron|home is surprised to hear tim say something "looks awesome" [03:10:46] > For the Beatles test case, my laptop seems to be about 3 times faster than test2, and it's not a fast laptop. So something funny is going on there. Maybe something was compiled with the wrong optimisation settings. -- Tim Starling (talk) 23:49, 29 August 2012 (UTC) [03:10:50] Interesting. [03:12:37] * Aaron|home will be upgrading his big laptop soon [03:13:13] * Aaron|home will watch his SSD do battle with Netbeans [03:30:07] 03(mod) Labs infrastructure work (tracking) - 10https://bugzilla.wikimedia.org/39784 +comment (10Jasper Deng) [03:42:16] 03(mod) jquery.articleFeedbackv5.special styles loaded incorrectly in RTL languages - 10https://bugzilla.wikimedia.org/38294 +comment (10Tim Starling) [04:08:34] 03(mod) Inconsistent state within the internal storage backends - 10https://bugzilla.wikimedia.org/39221 +comment (10Yann Forget) [04:09:14] 03(mod) Inconsistent state within the internal storage backends - 10https://bugzilla.wikimedia.org/39221 +comment (10Aaron Schulz) [04:09:47] 03(mod) Inconsistent state within the internal storage backends - 10https://bugzilla.wikimedia.org/39221 +comment (10Yann Forget) [04:11:05] there's a profiler for Lua written in C++ [04:11:30] with output to either text or an overlay surface of a 3D game engine [04:12:10] Well maybe if we make a 3D interface for wikipedia we can use the overlay [04:58:23] johnduhart2, WebGL!!! [04:58:35] ...WikiGL!!! [05:03:13] 03(FIXED) Special:ListGlobalUsers/group should note when rights apply to the current wiki / when the wiki is in the relevant wiki set - 10https://bugzilla.wikimedia.org/16545 +comment (10Nemo_bis) [05:04:02] 03(ASSIGNED) WLMMobile: HTML injection in HTML templating system - 10https://bugzilla.wikimedia.org/39735 (10Brion Vibber) [05:15:58] 03(mod) Fix English Wikipedia's upload system - 10https://bugzilla.wikimedia.org/37320 (10Nemo_bis) [05:15:58] 03(mod) Make UploadWizard compatible with fair use - 10https://bugzilla.wikimedia.org/29955 (10Nemo_bis) [05:15:59] 03(mod) Default file uploader is broken on the English Wikipedia - 10https://bugzilla.wikimedia.org/39779 (10Nemo_bis) [05:16:13] 2012-08-29 17:12:57 srv194 mediawikiwiki: [5dc3510a] /w/index.php?title=User:Tpt/lua&action=submit Exception from line 24 of /usr/local/apache/common-local/php-1.20wmf10/extensions/Scribunto/engines/LuaSandbox/Engine.php: The luasandbox extension is not present, this engine cannot be used. [05:16:27] there sure is a lot random of error log cruft [05:16:49] 03(mod) jquery.articleFeedbackv5.special styles loaded incorrectly in RTL languages - 10https://bugzilla.wikimedia.org/38294 +comment (10Roan Kattouw) [05:17:05] * Aaron|home wonders if Reedy would like to run through it ;) [05:19:32] 03(mod) Default file uploader is broken on the English Wikipedia - 10https://bugzilla.wikimedia.org/39779 +comment (10Nemo_bis) [05:30:33] srv194 is in rotation as an apache [05:31:47] but the peter duplicated the puppet configuration of the appservers so that anything you do to the rest of the cluster won't affect srv194 [05:32:00] s/the// [05:59:42] or s/the/then [06:24:55] filed RT 3497 [06:39:00] 03(mod) Preserve tab selection after submit in [[Special:Preferences]] - 10https://bugzilla.wikimedia.org/27559 +comment (10Fomafix) [06:39:54] i have added class="wikitable sortable" to my table, but it is still not sortable. MediaWiki 1.19. any idea what's wrong? [06:50:29] One of these days I should go back to attempting to create a space optimized dump format of text tables [07:14:56] lo [07:20:50] oskie: you probably are not using ! to indicate the cells that are the header of the table. [07:23:03] thedj[work]: I tried copying an example table from wikipedia, but same thing. strange. [07:25:02] 03(mod) Make UploadWizard compatible with fair use - 10https://bugzilla.wikimedia.org/29955 +comment (10Derk-Jan Hartman) [07:36:05] 03(mod) Make UploadWizard compatible with fair use - 10https://bugzilla.wikimedia.org/29955 (10Nemo_bis) [08:02:55] huh ? [08:04:16] ah, it's the powernap of my air... [08:05:40] Today's new term definition absorbed into my brain... "Bloom Filter" [08:07:06] Dantman: now write includes/lib/BloomFilter.php and find us a use case :-))) [08:07:16] lol [08:07:55] Dantman: while you are still around, would you mind giving some love to the patches you sent to Gerrit? https://gerrit.wikimedia.org/r/#/dashboard/30 [08:08:13] there are several of them with -1 , I guess they are pending input / patchset from you :) [08:09:04] ^_^ I dealt with some of them [08:35:55] 03(mod) Allow global renaming of global users - 10https://bugzilla.wikimedia.org/14862 +comment (10Erik Moeller) [08:46:47] 03(ASSIGNED) Sudo policy should use the project group, rather than ALL for users - 10https://bugzilla.wikimedia.org/39790 (10Dereckson) [08:52:12] 03(NEW) Labsconsole session is omnipresent - 10https://bugzilla.wikimedia.org/39792 normal; Wikimedia Labs: General; (damian) [09:06:28] 03(mod) [[Special:NovaInstance]] links send a 500 error when instanceid uses i-..... syntax instead GUID one. - 10https://bugzilla.wikimedia.org/39791 summary; +comment (10Dereckson) [09:07:55] ori-l: I think your issue is an extension one, and not a Wikimedia Labs one [09:08:37] ori-l: if you wish a temporary workaround, I'll get you an URL in few instant [09:09:45] ori-l: no I can't have the URL, as I'm a project member ; go to https://labsconsole.wikimedia.org/wiki/Special:NovaInstance and use the Configure link from this array, that one works. [09:10:25] It seems Configure expects instanceid to be a GUID and not the instance ID [09:20:11] I have a problem on this page: http://info.ici-paris.de/ahlenwiki/index.php?title=Damaschkestraße the map pn the right its shifted but I can't find the mistake in the css or the script. Maybe someone can help me? [09:25:20] Thanks but where was the mistake? [09:27:47] Ok problem not solved! It is a difficult thing for me. On reload the map displays correct [09:30:56] hashar, The thing currently spinning around in my head is an idea how to write an algorithm that does efficient storage of text table/externalstore dumps. [09:31:00] Nikerabbit: hi! please have a look at my response re I1eff1293. I only see cosmetic issues. [09:31:18] but before i submit a new patch set, it wopuld be nice to know whether you think there's anything else wrong. [09:35:57] so apparently we can't create an input of type="color" :-( [09:38:36] is "facultative" or "optional" the most easy to understand word for a non mandatory parameter? [09:39:16] Hello mbockholt. [09:40:03] mbockholt: http://info.ici-paris.de/ahlenwiki/index.php?title=Vorlage:Stra%C3%9Fen&action=edit contains style implying a 250px width picture [09:40:23] mbockholt: maybe should you try to set also a 250px (or a little more) width for the table [09:41:02] you can edit hintergrundfarbe6 css or to quickly test add style="width: 280px;" [09:41:46] mbockholt: next step will be to understand why there is a left border [09:42:38] I would try to add "margin-left: 0 !important;" in your
declaration. [09:43:45] DanielK_away: mFoo okay [09:44:08] DanielK_away: substituted... I don't fully understand why one would expect call to params() [09:44:11] Hi, I am not a very bright candle today: What does $wgDefaultUserOptions['watchlistdays'] = 3.0; is trying to say to me. 3 or 30 days? O_o [09:44:41] DanielK_away: clone... someone could do getNativeData()->params() which makes it kind of immutable [09:44:48] all these typos :( [09:45:10] Dereckson: I would use "optional" [09:45:15] DanielK_away: indentation: or use spaces, as long as not so many tabs :) [09:45:31] Nikerabbit: you mean if the message does have params, but no params where supplied to the constructor? hm... i guess... [09:45:50] Nikerabbit: frankly, I severly dislike the fact that Message objects are mutable. oh, well. [09:45:56] sorry, not params() but param() [09:45:56] i guess i'll clone just to be safe. [09:46:13] so I'd perhaps return clone in getNativeData [09:46:40] Thanks hashar. [09:47:13] Nikerabbit: hm... returning a clone in getNativeData makes the Content object imutable. A bit nicer than cloning the content object in copy() [09:47:18] yea, i guess i'll do that [09:47:21] thanks for your input [09:50:10] DanielK_away: far far away? [09:52:53] Tim-away: Time to make scribunto.wmflabs.org read only? http://scribunto.wmflabs.org/index.php/Special:RecentChanges [09:53:24] The reason why I am asking is. I set $wgDefaultUserOptions['watchlistdays'] = 30; in my wiki. This caused the maximum of settable days to be 7 instead of 91 and consequently creating an Internal error - Global default '30' is invalid for field watchlistdays [09:54:00] jarry1250: speaking about scribunto, what do you think about the idea to use fr.wikisource.org as "real world" betatest (by opposite to the MediaWiki more technical-oriented one)? [09:55:33] Dereckson: What do I think? Well, IMHO, it's good to have any community that actively wants to guineapig something, and Wikisource is really the project least well served by MediaWiki at the moment, so I think it would be a good test deployment, other things being equal. [09:55:41] 03(NEW) placeholder text color in search bar in Firefox 15 is black instead of gray - 10https://bugzilla.wikimedia.org/39793 trivial; MediaWiki: Skin: Vector; (fomafix) [09:56:10] Nikerabbit: ok, pushed a new change set. btw - do you have merge rights on the Wikidata branch? I'm a bit confused about how this is set up on gerrit [09:56:11] jarry1250: you can comment https://bugzilla.wikimedia.org/show_bug.cgi?id=39744 [09:57:01] Dereckson: Of course. Thanks for your code review prodding, btw, and sorry it was such a stupid error by me :/ [09:57:16] DanielK_away: looks like I do [10:04:17] No problem. [10:16:36] 03(mod) Install Scribunto on fr.wikisource - 10https://bugzilla.wikimedia.org/39744 +comment (10Jarry1250) [10:16:49] 03(NEW) processMessageChanges.php rebuilds caches for SingleFileBasedMessageGroup/PythonSingleFFS each run - 10https://bugzilla.wikimedia.org/39794 trivial; MediaWiki extensions: Translate; (s.mazeland) [10:16:56] 03(mod) processMessageChanges.php rebuilds caches for SingleFileBasedMessageGroup/PythonSingleFFS each run - 10https://bugzilla.wikimedia.org/39794 (10Siebrand) [10:21:15] an easy review for anyone still around: https://gerrit.wikimedia.org/r/21999 [10:26:29] hashar: still? [10:27:42] Nikerabbit: in case everyone is out for lunch :) [10:29:09] looks like gerrit-wm is dead isn't it ? [10:29:21] hashar: just laggy [10:30:37] 03(NEW) More specific CSS classes for Special:Contributions - 10https://bugzilla.wikimedia.org/39795 enhancement; MediaWiki: Special pages; (earle) [10:32:09] 03(NEW) Special:ManageMessageGroups indicated imports but does not display them - 10https://bugzilla.wikimedia.org/39796 normal; MediaWiki extensions: Translate; (s.mazeland) [10:32:20] 03(mod) Special:ManageMessageGroups indicated imports but does not display them - 10https://bugzilla.wikimedia.org/39796 normal->major (10Siebrand) [10:51:33] Nikerabbit: well gerrit-wm hasn't send anything for the last 2 hours or so :/ [10:51:36] I guess the irc bot died [10:52:11] can be [10:53:42] 03(NEW) gerrit-wm no more notify on comment or merge - 10https://bugzilla.wikimedia.org/39797 normal; Wikimedia: IRC; (hashar) [10:54:03] bug opened :) [10:54:06] will poke ops [11:18:34] aude: Hallo. Is there a website that shows OSM maps with Wikipedia markers, like in the official Wikipedia mobile app? [11:24:43] hello [11:26:15] i set the timezone in localsettings.php to Eruope/Berlin, the local time is 1:25 pm, the time of the debian machine (where the wiki runs on) is 1:25pm. but wiki says, the servertime is 11:25 am [11:26:24] why is that so and how I resolve that? [11:28:29] php.ini setting is also europe/berlin [11:32:00] 03(mod) coords 0, 0 used for monuments without coordinates - 10https://bugzilla.wikimedia.org/39476 +comment (10Maarten Dammers) [11:41:56] 04(REOPENED) Location where the photo was taken should be added to the upload if the location is made available - 10https://bugzilla.wikimedia.org/39745 normal->15enhancement; summary; +comment (10Maarten Dammers) [11:45:23] 03(mod) Set log_page to the page_id of its description page for upload actions - 10https://bugzilla.wikimedia.org/38606 +comment (10Maarten Dammers) [11:48:37] 03(mod) Set log_page to the page_id of its description page for upload actions - 10https://bugzilla.wikimedia.org/38606 +comment (10Krenair) [11:51:00] DanielK_away: On https://gerrit.wikimedia.org/r/#/c/21996/: Can we use parse() instead of escaped()? [11:52:04] siebrand: no. the message is not wqikitext but html. it actually contains "*" and "**" at the beginning of lines, which are intended to stay that way, not be turned into a list by the wikitext parser [11:52:20] we can use ->plain, if you like [11:52:35] or change it to be wikitext. but then all translkations need to be updated [11:52:37] 04(REOPENED) Set log_page to the page_id of its description page for upload actions - 10https://bugzilla.wikimedia.org/38606 +comment (10Maarten Dammers) [11:55:46] DanielK_WMDE: The problem is basically that unescaped text that users have created goes to the browser; we want to avoid that. [11:55:56] (you know that of course) [11:56:26] This is the current text: [11:56:27] 'contactpage-formfootnotes' => '* optional
[11:56:28] ** optional but needed if you want an answer', [11:57:17] Only roughly 182 translations.. [11:57:39] s/182/91/ [11:58:22] so, no help? [11:58:41] DanielK_WMDE: I'll update the patch with a proposed solution. [12:03:18] 03(mod) Set log_page to the page_id of its description page for upload actions - 10https://bugzilla.wikimedia.org/38606 +comment (10Krenair) [12:11:09] siebrand: thanks [12:21:25] 03(FIXED) Install Free Hebrew fonts, so that they will be available for SVG rendering - 10https://bugzilla.wikimedia.org/38946 +comment (10Antoine "hashar" Musso) [12:23:05] 03(FIXED) Installation of Computer Modern Unicode font family for SVG rendering - 10https://bugzilla.wikimedia.org/38299 +comment (10Antoine "hashar" Musso) [12:32:07] 03(mod) Semantic Maps does not export coordinates in RDF - 10https://bugzilla.wikimedia.org/33504 +comment (10Chris Davis) [12:40:20] How can I get the size of an article from another language's wiki? [12:41:15] example: {{sizeofarticle|fr|France}} to output the size of article France from the french Wikipedia [12:53:48] Does MediaWiki:Common.js need a cache purge, somehow? I've tried bypassing browser cache and ?action=purge, nothing seems to make the JS update... =| [12:54:21] SAL9000: i think the cache will purge by itself in a few minutes [12:54:35] five to ten, i'd say, based on experience [12:54:40] what wiki are we talking about? [12:54:49] a farmer wiki on wikkii.com [12:55:13] 03(mod) Category page listings have unbalanced columns - 10https://bugzilla.wikimedia.org/900 (10contrafibularity) [13:10:12] 03(NEW) Files with future visibility date - 10https://bugzilla.wikimedia.org/39798 enhancement; MediaWiki: File management; (crangasi2001) [13:31:32] 03(mod) [[Special:NovaInstance]] links send a 500 error when instanceid uses i-..... syntax instead GUID one. - 10https://bugzilla.wikimedia.org/39791 +comment (10Dereckson) [13:35:12] 03(mod) WLMMobile: HTML injection in HTML templating system - 10https://bugzilla.wikimedia.org/39735 +comment (10Brion Vibber) [13:44:57] 03(mod) WLMMobile: HTML injection in HTML templating system - 10https://bugzilla.wikimedia.org/39735 +comment (10Brion Vibber) [13:49:01] 03(mod) [ReplaceText] Incorrect error: You must select at least one namespace. - 10https://bugzilla.wikimedia.org/38170 (10antony.seedhouse) [14:00:06] 03(NEW) Some Catalan monuments missing - 10https://bugzilla.wikimedia.org/39799 normal; WikiLoves Monuments Mobile: General; (joan.creus.c) [14:09:39] hashar: need review -- https://gerrit.wikimedia.org/r/#/c/22028/ [14:11:09] chughakshay16: well I have zero knowledge about that ext :) [14:11:28] chughakshay16: make sure that the tests were actually broken, not some code! ;-D [14:11:37] cause sometime the test are right but fail because the code is wrong [14:12:04] hashar: I just ran these tests on my local copy.. and it worked just fine :) [14:12:51] hashar: and yes they were actually broken before.. [14:15:19] hashar: i just wanted your general opinion reg those tests :) [14:16:13] looking looking :) [14:17:59] oh btw hashar [14:18:24] chughakshay16: I love the chaining of tests :-D [14:18:56] hashar: can you recheck https://gerrit.wikimedia.org/r/#/c/11829/ [14:22:56] hashar: since this was my first time with php unit tests.. i just needed a heads up on what basic things i may have done wrong [14:24:51] New review: Hashar; "Some tips and hints :)" [mediawiki/extensions/ConventionExtension] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/22028 [14:24:54] chughakshay16: reviewed [14:26:09] 03(FIXED) gerrit-wm no more notify on comment or merge - 10https://bugzilla.wikimedia.org/39797 +comment (10Antoine "hashar" Musso) [14:26:34] Nikerabbit: looking [14:26:38] hashar: thanks [14:26:56] chughakshay16: User::newFromId( 1 ); , I guess you could craft a new user ;) [14:27:20] Nikerabbit: I am still wondering why we want to ship all iso 639 code [14:34:08] hashar: because that increases our language coverage by quite a notch [14:37:29] 03(mod) Some Catalan monuments missing - 10https://bugzilla.wikimedia.org/39799 +comment (10Platonides) [14:45:31] 03(ASSIGNED) More specific CSS classes for Special:Contributions - 10https://bugzilla.wikimedia.org/39795 +comment (10Dereckson) [14:45:39] Nikerabbit: still reviewing [14:50:25] grrr [14:50:33] why does PHP lacks polymorphism ? :-( [14:51:26] hashar, you have that other thing now [14:51:39] I don't remember the name... [14:52:08] Platonides: traits [14:52:23] right [14:53:15] Nikerabbit, can you make Benoit_Rochon a translator at TWN? https://translatewiki.net/wiki/Thread:Project:Translator/_fr_fran%C3%A7ais_%E2%80%93_fran%C3%A7ais_%2815%29 [14:54:26] 03(mod) HTML escaping on the planet - 10https://bugzilla.wikimedia.org/39725 (10shi zhao) [14:57:04] 03(mod) https://planet.wikimedia.org goes to civiCRM instance. - 10https://bugzilla.wikimedia.org/39678 +comment (10shi zhao) [14:57:57] grr https [15:02:21] I prepared a code change to add two CSS classes in [[Special:Contributions]]. Who to contact for a review and to see if it were a good idea? [15:07:26] Dereckson: MatmaRex and thedj[work] both do CSS IIRC, but you might want to ask sumana when she gets on [15:10:41] Nikerabbit: I have reviewed https://gerrit.wikimedia.org/r/#/c/11829/ (19 inline comments) [15:10:43] somebody called me? [15:11:13] MatmaRex: Dereckson made a CSS change, wanted review. Up for it? [15:11:14] * MatmaRex is just a new MW developer [15:11:21] sure [15:11:29] Dereckson: Where is the patch? [15:11:39] as long as it's not PHP, i'm happy to look at it :P [15:11:50] (be right back, 10 minutes) [15:14:30] Dereckson: Tell MatmaRex where the patch is, I have to go to work (be back in ~30) [15:17:00] Okay. [15:17:09] 03(mod) [ReplaceText] Incorrect error: You must select at least one namespace. - 10https://bugzilla.wikimedia.org/38170 +comment (10Jerry Pank) [15:17:43] MatmaRex > https://gerrit.wikimedia.org/r/#/c/22030/1 [15:17:54] Thank you marktraceur. [15:22:43] 03(mod) Article Feedback Shows CTA5 to readers too frequently - 10https://bugzilla.wikimedia.org/39768 +comment (10Matthias Mullie) [15:23:03] 03(mod) Inconsistent state within the internal storage backends - 10https://bugzilla.wikimedia.org/39221 +comment (10Túrelio) [15:24:37] i'll look at it later [15:27:22] 03(mod) [ReplaceText] Incorrect error: You must select at least one namespace. - 10https://bugzilla.wikimedia.org/38170 (10antony.seedhouse) [15:30:28] New patchset: Reedy; "(bug 38249) No PCRE unicode causes installer to spew giberish" [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/22033 [15:34:06] New patchset: Nikerabbit; "I18n#1473: Use preferred language for anonymous users" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/22034 [15:34:42] hashar: I doubt that every request is going to need all names in English [15:35:23] New patchset: Siebrand; "Maintenance for timeline extension." [mediawiki/extensions/timeline] (master) - https://gerrit.wikimedia.org/r/22035 [15:36:04] hey Krenair, how's it going? [15:36:06] 03(mod) FileBackend.php has 1 GB limit, despite $wgMaxUploadSize - 10https://bugzilla.wikimedia.org/38719 +comment (10Sumana Harihareswara) [15:36:11] hi sumanah [15:37:48] hi petan, how is it going? I have a question for you re OnlineStatusBar, and then another about whether you have room for another project in your life :-) [15:37:56] hashar: thanks for the review though [15:38:03] sumanah hi [15:38:28] I am actually very busy, so busy that I don't even have a time for most of current wiki projects I was working on, but what is that? [15:39:05] nuff ... time to go for a run ... 14.10 is getting closer [15:39:06] oh ok petan ... wanted to ping you, first, re https://bugzilla.wikimedia.org/show_bug.cgi?id=37132 [15:39:14] + I am lazy [15:39:15] :D [15:39:21] the design issue that's blocking deployment, if I understand correctly [15:39:37] Nikerabbit: the issue is that fetchLanguageNames( 'en' ), will return 'all' language when the docblock says it will returns the 'mw' one by default ;) [15:39:39] petan: I think it was Larry Wall who said that a kind of laziness is one of a programmer's 3 virtues? :) [15:39:59] I know there is something OSB related waiting for me, I will try to get to that soon, but it's been so long I was last working on that, I don't even remember the source code, I will have to read it again and understand what I once made :D [15:40:07] we can see the end result of laziness : the perl language :-] [15:40:22] laziness, hubris, and impatience iirc [15:40:30] if we weren't lazy we wouldn't need to create programs and computers which work for us [15:40:31] Krenair: if you have a moment to do a little patch shuffling :-) https://bugzilla.wikimedia.org/show_bug.cgi?id=38719 needs moving into Gerrit - could I ask you to do that? [15:41:08] aha design issue [15:41:10] yes [15:41:20] that's a problem because I am very bad in designing stuff [15:41:31] petan: you could write to the design list and ask for help? [15:41:31] I only know php, no css and such [15:41:37] sumanah, yep [15:41:38] we have that? wow [15:41:43] Change merged: Reedy; [mediawiki/extensions/OAI] (master) - https://gerrit.wikimedia.org/r/22020 [15:41:55] petan: I sent a note to the dev list on Friday listing some lists you might want to know about [15:41:59] petan: "design" is one of them [15:42:03] ok [15:42:37] petan: also, MatmaRex is interested in frontend stuff, and specifically is interested in reviewing css/js/html code [15:43:17] sumanah cool, wherever he is, tell them they can do whatever they like regarding that [15:43:32] they can even contribute on code [15:43:40] MatmaRex: ^^ :-) re the OnlineStatusBar extension, which petan is hoping to get deployed on WMF servers. [15:44:00] !b 38719 | MatmaRex [15:44:00] MatmaRex: https://bugzilla.wikimedia.org/show_bug.cgi?id=38719 [15:44:35] yes? [15:44:39] hashar: isn't that filtered further down? [15:45:02] petan: I know that a while back you were unhappy because you were waiting for review/response on some stuff, so now I just want to make sure that there are no accidental deadlocks, where people don't realize someone's waiting on them! [15:45:23] MatmaRex: petan would welcome your help in fixing a design/frontend issue in that bug [15:45:50] petan: ok, the other thing is, if you WANTED and HAD TIME FOR another project, I'd ask you to look into https://wikitech.wikimedia.org/view/Pentaho but since I know you are busy, I won't:) [15:45:58] Nikerabbit: well it calls getISO639Names() which reads the cdb and then all of that is filtered [15:46:07] Nikerabbit: we can just skip reading from the cdb file [15:46:19] that's all, petan [15:46:30] hashar: but that is against the caching you were suggesting [15:46:37] Dereckson: My pleasure! You should probably add MatmaRex to the reviewer list if you haven't already. [15:47:00] sumanah who should I contact regarding that [15:47:16] this is actually something I used to work on [15:47:21] sumanah: are you sure you got that bug number right? :) this one is related to file upload? [15:47:22] petan: regarding the Pentaho stuff? you mean, to get more specifications and stuff? [15:47:28] yes [15:47:38] Nikerabbit: I guess there is no point in caching data we are not going to use [15:47:46] MatmaRex: argh, sorry, I mean https://bugzilla.wikimedia.org/show_bug.cgi?id=37132 [15:47:50] Nikerabbit: let the cache be done on a later call that actually need the data [15:48:06] Nikerabbit: the aim is to avoid reading from the cdb file when its data are unneeded [15:48:46] petan: I think just ask wikitech-l .... I would be one of the "customers" but also RobLa, Erik Moeller, Tomasz Finc, our upcoming Bug Wrangler & volunteer engineering coordinator would be customers as well [15:49:07] petan: you used to work on Pentaho-related stuff? or metrics/stats/analytics in general? [15:49:18] petan: so I think you would cc the analytics mailing list as well :) [15:49:19] the second [15:49:27] 03(mod) More specific CSS classes for Special:Contributions - 10https://bugzilla.wikimedia.org/39795 +design +patch-in-gerrit; +comment (10Dereckson) [15:50:32] 03(mod) FileBackend.php has 1 GB limit, despite $wgMaxUploadSize - 10https://bugzilla.wikimedia.org/38719 +comment (10Krenair) [15:51:16] New patchset: Alex Monk; "(bug 38719) Make maxFileSizeInternal use wgMaxUploadSize" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22038 [15:51:16] New patchset: Reedy; "Fix max(-1) is smaller than min(0) warning" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/22039 [15:52:14] 03(mod) FileBackend.php has 1 GB limit, despite $wgMaxUploadSize - 10https://bugzilla.wikimedia.org/38719 +patch-in-gerrit; +comment (10Sumana Harihareswara) [15:52:22] oh, gerrit-wm is back [15:52:26] Reedy: hi, how's your internet? :) [15:52:50] New patchset: Jens Ohlig; "Special:ItemDisambiguation language autocompletion" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22009 [15:52:55] Magical, apparently [15:53:15] Reedy: did you finally propitiate the gods of the last mile? :) [15:53:33] sumanah: i'll look [15:53:40] thanks MatmaRex and thanks Krenair [15:55:26] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22012 [15:55:41] Reedy: I'm waiting for you re SubpageSortKey https://bugzilla.wikimedia.org/show_bug.cgi?id=22911 [15:56:03] sumanah: is there a wiki online somewhere that uses it, or do i have to set up my own to test? :) [15:56:26] MatmaRex: Krinkle|detached & petan know far more about it than I do, sorry. Maybe petan has a Labs instance set up? [15:57:02] MatmaRex yes there used to be bunch of them... right now there is huggle wiki using it [15:57:08] hashar & chrismcmahon: TimedMediaHandler. I'm updating some statuses.... do you have any thoughts on when we think it'll be tested enough? :) [15:57:26] which doesn't work [15:57:37] New patchset: Jens Ohlig; "Special:ItemDisambiguation language autocompletion" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22009 [15:57:42] petan: can i have alink? [15:57:57] 03(UNCONFIRMED) Files with future visibility date - 10https://bugzilla.wikimedia.org/39798 +comment (10Dereckson) [15:58:10] petan: http://huggle.wmflabs.org/ ? it seems down... [15:58:11] sumanah: no idea sorry :/ [15:58:21] sumanah: I think it is on test2 / preproduction nowadays [15:58:36] hashar see -labs [15:59:47] 03(mod) Review and deploy Drafts extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/37992 +comment (10Sumana Harihareswara) [16:00:20] 03(ASSIGNED) Some Catalan monuments missing - 10https://bugzilla.wikimedia.org/39799 +comment (10Dereckson) [16:05:47] New review: MarkTraceur; "See inline, it's a minor fix." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/22038 [16:06:55] 03(mod) FileBackend.php has 1 GB limit, despite $wgMaxUploadSize - 10https://bugzilla.wikimedia.org/38719 +comment (10Sumana Harihareswara) [16:06:59] sumanah: I think Chris Steipp was looking at TMH last, istr some issues there [16:07:37] csteipp: ok, if you've found issues in TMH, can I add those as blockers to https://bugzilla.wikimedia.org/show_bug.cgi?id=27699 ? [16:08:57] sumanah: You can... I think both issues I brought up were addressed [16:09:18] sumanah: You're quick! [16:09:18] But it would probably be good to track them, and them make sure they were crossed off :) [16:09:32] csteipp: oh ok, so can you link to them or mark them as blockers? not sure what they are [16:09:52] I will do that! [16:10:01] thanks [16:10:32] csteipp: as you can see from https://bugzilla.wikimedia.org/show_bug.cgi?id=27699 people do want to know more about progress :-) and about when TMH will be up.... [16:13:04] New patchset: Siebrand; "Maintenance for ImageMap extension." [mediawiki/extensions/ImageMap] (master) - https://gerrit.wikimedia.org/r/22040 [16:13:08] New review: Nullspoon; "Thanks for the feedback Brian. I like the idea of giving the end user more control of how their medi..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/11137 [16:16:19] so, ever since running maintenance/update.php, my LocalSettings.php in /etc/mediawiki keeps reverting to an older version… no changes that I make to it will stay for more than a few hours... [16:18:04] hi hushedfeet, that sounds frustrating :/ .... is there some kind of filesystem logger whose logs you can look at to see what process it is that's changing that file? [16:20:48] New review: Nullspoon; "Oh, one more thing." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/11137 [16:20:52] New patchset: Daniel Kinzler; "handle bad content model in SpecialBooksources" [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/22041 [16:21:05] petan: i'm setting up a test wiki now and i'll look at the OnlineStatusBar thing [16:21:09] sumanah: ^ [16:21:36] thank you MatmaRex! Appreciated. I know the Editor Engagement Experiments team is interested in this as well :) [16:23:33] New patchset: Siebrand; "Maintenance for InputBox extension." [mediawiki/extensions/InputBox] (master) - https://gerrit.wikimedia.org/r/22042 [16:24:41] New review: Alex Monk; "This doesn't apply cleanly at all any more, please rebase." [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/15959 [16:25:55] New patchset: Santhosh; "Fix the LanguageNameSearch::search call used in phpunit test" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/22043 [16:26:59] guillom: if you have a moment, I'd like you to join us in #wikimedia-labs where Damianz and I are talking about engineering documentation/process & what is unclear to him/her [16:27:16] Change merged: Siebrand; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/22043 [16:27:20] ok [16:27:28] I need you because I get all defensive and you don't :-) [16:27:34] 03(mod) Query for URL of image (prop=imageinfo&iiprop=url) fails with "Uri::setUri: $uri is not of a valid type." - 10https://bugzilla.wikimedia.org/39670 +comment (10Rainer@Rillke.eu) [16:27:41] sumanah : well, it wasn't happening before I ran php maintenance/update.php [16:27:44] 03(FIXED) Query for URL of image (prop=imageinfo&iiprop=url) fails with "Uri::setUri: $uri is not of a valid type." - 10https://bugzilla.wikimedia.org/39670 (10Rainer@Rillke.eu) [16:27:54] but no, I will add such a monitor [16:28:05] Change merged: Siebrand; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/22029 [16:28:13] hushedfeet: I don't know enough to help, sorry, just to suggest logs to look at :/ [16:29:18] sumanah: still a good idea [16:29:26] :) [16:29:58] 03(FIXED) WLMMobile: HTML injection in HTML templating system - 10https://bugzilla.wikimedia.org/39735 (10Jon) [16:30:59] oh I guess I also added the ConfirmAccount extension, which was why I ran update [16:31:11] 03(mod) Selecting photo from picasa in my gallery causes app to crash - 10https://bugzilla.wikimedia.org/39604 +comment (10Jon) [16:32:00] 03(FIXED) Admin levels empty due to no campaign information (e.g. license) - 10https://bugzilla.wikimedia.org/39568 (10Jon) [16:32:27] 03(FIXED) coords 0, 0 used for monuments without coordinates - 10https://bugzilla.wikimedia.org/39476 +comment (10Jon) [16:33:09] hushedfeet: I don't think the ConfirmAccount ext is the culprit, though I could be wrong [16:33:23] I've never heard of this sort of rubber band effect with a config file being due to a MW extension [16:33:30] 03(mod) coords 0, 0 used for monuments without coordinates - 10https://bugzilla.wikimedia.org/39476 +comment (10Jon) [16:33:56] hushedfeet: has anything changed *on your system* regarding, like, autosaves, filesystem settings/config, backup strategy, in the last few months? [16:34:47] nope [16:35:42] though I suppose there is an outside chance it is a puppet thing, my money is against it. I can double check, but I'm pretty sure I rolled my latest conf into puppet [16:41:32] so, I'm going to go home now. seems like puppet was stomping it. I _swear_ i rolled the new LocalSettings into puppet, but guess not [16:42:12] hushedfeet1: blergh! bug in Puppet, you think? [16:43:36] no, stupid mistake. [16:44:33] New patchset: Amire80; "Filtering out languages that the ULS doesn't recognize" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/22044 [16:45:09] 03(mod) WLMMobile: should show spinner while doing GPS lookup - 10https://bugzilla.wikimedia.org/39248 +comment (10Jon) [16:45:23] sumanah: I failed to switch which git branch of the puppet conf my mediawiki was deploying from [16:45:25] New patchset: Nullspoon; "Added $wgWhitelistReadRegexp for regex whitelisting" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/11137 [16:45:27] New patchset: Jeroen De Dauw; "Add support for geocoords in the exporter" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/22045 [16:45:40] 03(FIXED) Show current user location on map - 10https://bugzilla.wikimedia.org/38921 (10Jon) [16:45:41] sumanah: so yeah, all my fault. [16:47:23] 03(NEW) Tooltip of ULS search results should be in current UI language - 10https://bugzilla.wikimedia.org/39800 normal; MediaWiki extensions: UniversalLanguageSelector; (srik.lak) [16:47:36] 03(FIXED) Semantic Maps does not export coordinates in RDF - 10https://bugzilla.wikimedia.org/33504 +comment (10Jeroen De Dauw) [16:52:42] New patchset: Santhosh; "Fix Bug 39800 Tooltip of ULS search results should be in current UI language" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/22046 [16:52:48] Change merged: Kaldari; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/21975 [16:53:59] 03(ASSIGNED) Tooltip of ULS search results should be in current UI language - 10https://bugzilla.wikimedia.org/39800 +comment (10Santhosh Thottingal) [16:57:45] 03(mod) [ReplaceText] Incorrect error: You must select at least one namespace. - 10https://bugzilla.wikimedia.org/38170 +comment (10Yaron Koren) [16:58:03] 03(mod) Chunked upload fails with internal_api_error_UploadStashFileNotFoundException - 10https://bugzilla.wikimedia.org/36587 (10Rob Lanphier) [17:01:52] New patchset: MarkTraceur; "(bug 37302) Only fire startUploads once, after all files are ready" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/22047 [17:08:19] Change merged: GWicke; [mediawiki/extensions/Parsoid] (master) - https://gerrit.wikimedia.org/r/21985 [17:11:00] New patchset: Aaron Schulz; "[FileBackend] Reduce backend sync errors a bit by aborting operations more." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22048 [17:12:57] New review: Kaldari; "The Information template requires that the date and time be in the format YYYY-MM-DD HH:MM:SS." [mediawiki/extensions/UploadWizard] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/9654 [17:16:33] New review: Aaron Schulz; "I noticed this test failing locally." [mediawiki/core] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/21870 [17:16:34] Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21870 [17:16:58] New patchset: Nullspoon; "Added $wgWhitelistReadRegexp for regex whitelisting" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/11137 [17:17:18] New patchset: MarkTraceur; "(bug 29470) Adds in time detection based on EXIF data" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/9654 [17:17:58] New patchset: Daniel Kinzler; "Make userWasLastToEdit reusable." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22049 [17:18:06] 03(NEW) Run JUnit tests also in other locales than English - 10https://bugzilla.wikimedia.org/39801 normal; Wikimedia: Testing Infrastructure; (s.mazeland) [17:18:13] New patchset: Parent5446; "New hook ApiCheckCanExecute." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20905 [17:20:29] Change abandoned: Parent5446; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/18095 [17:20:50] Change abandoned: Parent5446; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/18489 [17:22:37] !lists [17:22:37] mediawiki-l and wikitech-l are the primary mailing lists for MediaWiki-related issues. See https://www.mediawiki.org/wiki/Mailing_lists for details. [17:27:08] New patchset: Nullspoon; "Added $wgWhitelistReadRegexp for regex whitelisting" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/11137 [17:29:15] 03(mod) Review and deploy SVGEdit extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/38271 +comment (10Sumana Harihareswara) [17:29:16] hi sumanah [17:29:25] hi liangent, how are you? [17:29:35] regarding your mail when should I +1 in gerrit? [17:30:04] New patchset: Aaron Schulz; "[FileBackend] Made getLocalCopy() handle long file names better." [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/22051 [17:30:09] liangent: in order to talk about that I will have to ask a few questions to gauge what to explain :-) [17:30:31] liangent: first: have you already read the coding conventions document? https://www.mediawiki.org/wiki/Manual:Coding_conventions [17:30:34] Change merged: Aaron Schulz; [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/22051 [17:31:32] liangent: second: have you read the code review guide? https://www.mediawiki.org/wiki/Code_review_guide [17:32:26] Platonides: RoanKattouw: I just realized, again, that it would be really nice to be able to point to specific code reviews and say "this was a good code review" and "this was not a good code review". If any recent ones spring to mind, please give me links [17:32:45] sumanah: already seen them but can't remember all details [17:33:27] liangent: so, the first time you want to do a little code review, it might be a good idea to have those tabs open, and to check each of those checklist items as you look at the diff. [17:34:27] the basic question I want to ask is, when I find something wrong, I use -1. When I didn't find something wrong and it looks fine, but I didn't try to run every statement to test it, what should I do [17:34:51] 03(mod) Review and deploy TimedMediaHandler extension (timed media handler) to Wikimedia wikis - 10https://bugzilla.wikimedia.org/27699 +comment (10Sumana Harihareswara) [17:35:16] New review: MarkTraceur; "See inline" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/11137 [17:35:41] Nikerabbit: RoanKattouw - my instinct, regarding liangent's question just above, is that you would use "+1" in that circumstance. Am I right? [17:36:17] Yeah C+1 sounds fine in that case [17:36:29] liangent: Yes, use +1 :-) [17:36:41] Also, you can leave comments when you review, so if you want to say "looks fine but I didn't test X", you can put that in the comment box [17:36:54] liangent: and then if someone else in the future has a -1 or -2 criticism, then you can watch and learn from that and then be a stricter reviewer in the future :-) [17:38:06] Change merged: GWicke; [mediawiki/extensions/Parsoid] (master) - https://gerrit.wikimedia.org/r/21987 [17:39:29] so +/-1 is just for appearance and it's the responsibility for whoever does +(-?)2 to really test it? [17:39:43] Change merged: GWicke; [mediawiki/extensions/Parsoid] (master) - https://gerrit.wikimedia.org/r/21988 [17:39:59] liangent: I think "just for appearance" is a bad way to think about it [17:40:39] sumanah: I mean, just checked by reading instead of running it [17:40:56] liangent: +1 and -1 are not binding. It's better if you can run the code and test it, but it's also ok for you to read the code to inspect it visually [17:41:34] liangent: yes, it is definitely the responsibility of a project owner to have a high standard, including testing if necessary, before giving +2 or -2 [17:42:13] liangent: https://www.mediawiki.org/wiki/Code_review_guide#Review_Guidelines has a list of what it means to give a +2 [17:43:27] Oh man how have I not read this page [17:44:02] 03(mod) Install Scribunto on fr.wikisource - 10https://bugzilla.wikimedia.org/39744 +comment (10Tpt) [17:44:08] marktraceur: I don't know ... did you ever read https://www.mediawiki.org/wiki/Developer_hub ? [17:44:26] Apparently not thoroughly [17:44:29] * marktraceur reads [17:45:12] and when -1 for a trivial problem? [17:45:22] for example for a new commit https://gerrit.wikimedia.org/r/#/c/22049/1/includes/Revision.php [17:45:24] liangent: btw, if you can view Vimeo, you may want to watch this presentation http://vimeo.com/44856793 and read https://www.mediawiki.org/wiki/Secure_coding_and_code_review_for_MediaWiki/Tutorial [17:45:38] 03(mod) More specific CSS classes for Special:Contributions - 10https://bugzilla.wikimedia.org/39795 +comment (10Earle Martin) [17:45:39] New patchset: Aaron Schulz; "[FileBackend] Made Swift clear the auth cache on certain HTTP errors." [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/22052 [17:45:41] I want to let someone else answer that question..... [17:45:55] I see there's a trailing newline and I wouldn't write it if I'm doing this change. [17:46:05] should I -1 just for that? [17:46:31] Change merged: Aaron Schulz; [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/22052 [17:46:36] New review: Demon; "Were any extensions subclassing EditPage using this function? I can't imagine so." [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/22049 [17:46:40] liangent: If there's anything at all that would make you say "we shouldn't merge this as-is", -1 [17:47:10] sumanah: I remember I watched that video some time [17:47:14] We changed the message for -1 to say "there is a problem with this change, please improve". So it means "I looked at this and you should fix X" as opposed to YOU ARE AN IDIOT GO AWAY [17:47:34] New patchset: Kaldari; "Implement uploading images from Flickr" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/12269 [17:47:42] liangent: so, yes, -1 even if it is trivial [17:49:34] thanks for reviewing, liangent. [17:49:57] Change merged: Catrope; [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/22033 [17:50:56] Change merged: Catrope; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22048 [17:51:43] and what if I find some problem in a merged commit? [17:52:03] try to fix it or create a new changeset to revert it first? [17:52:18] New review: MarkTraceur; "More minor stuff." [mediawiki/extensions/UploadWizard] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12269 [17:52:52] Depends on how serious it is [17:53:01] If it breaks something, revert it [17:53:14] The revert won't take effect immediately anyway, it'll also go through review [17:53:32] But if you're like "oh we can just fix this by doing X", go ahead and do X [17:53:35] * AaronSchulz watches the output of his file sync script [17:53:42] yeah but a revert may be reviewed faster because it doesn't introduce something new [17:53:42] It depends on how badly things are broken and how easy they are to fix [17:53:43] "mwstore://local-NFS/local-public/1/1f/Sexualanal.jpg" [17:53:45] ... [17:53:57] oh commons :) [17:55:08] 03(FIXED) Categories should be hierarchical and hidden - 10https://bugzilla.wikimedia.org/39721 +comment (10Arthur Richards) [17:59:52] 14(INVALID) Enable Extension:Sort on Hindi Wikipedia - 10https://bugzilla.wikimedia.org/29829 +i18n; +comment (10Sumana Harihareswara) [18:03:58] New review: GWicke; "See the inline niggles ;)" [mediawiki/extensions/Parsoid] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21992 [18:03:58] New review: Krinkle; "Javascript looks good. I've put a few stylistic comments inline." [mediawiki/extensions/CentralNotice] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/17975 [18:04:03] 03(NEW) Upload Wizard licensing tutorial could use an overhaul - 10https://bugzilla.wikimedia.org/39802 minor; MediaWiki extensions: UploadWizard; (erik) [18:04:28] New patchset: Amire80; "Fix tests after regions renumbering" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/22053 [18:06:10] New patchset: Aaron Schulz; "[FileBackend] Made TempFSFile use wfRandomString() and be more random." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22054 [18:06:41] RoanKattouw: sorry for the spam :) [18:08:08] AaronSchulz: btw if you had thoughts on the accuracy, unfortunate side effects, etc of https://www.mediawiki.org/wiki/Git/Code_review/Getting_reviews I'd want to know them [18:08:36] Change merged: Santhosh; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/22053 [18:08:39] aka "5 quick tips to faster, happier reviews!" [18:08:44] "the secrets Gerrit won't tell you" [18:08:56] "inside: how David Duchovny reviews code (and you can too)" [18:08:59] I'd wouldn't recommend having random people -1 stuff a lot [18:09:21] "Ways to get code into MediaWiki with minimal government interference" [18:09:28] people sometimes do so in error and it can slow down review of a commit because people skip it since it has -1 [18:09:34] AaronSchulz: the tradeoff, though, is that we have to have some way for people to learn how to review, and they're going to make mistakes as they do [18:09:46] my core CR bookmarked url is set to filter stuff with -1 out [18:10:01] sumanah: making comments is just as good [18:10:59] sometimes Tim does that (and sometimes I do)...just leave comments [18:12:43] ok, AaronSchulz, I've changed the suggestion to "Read Code review guide and help out with comments. Those are nonbinding, won't cause merges or rejections, and have no formal effect on the code review." in the wiki page [18:13:20] hmm, need to reword "help out with comments" because that implies "add code comments to the diffs" or something [18:13:41] "comment with criticism or praise"? [18:13:47] Change merged: Catrope; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22054 [18:13:55] Hi everyone. Is there anyone around who's comfortable with JavaScript on an older MW 1.14 installation? (We've had trouble with a 1.19 upgrade.) I'm having some intermittent issues, but my JS skills aren't up to figuring out what's going on. [18:15:44] * sumanah shines the JS Batman signal at MatmaRex ;-) [18:15:54] LOL...thanks. :) [18:16:08] santhosh: Hi, I'm not sure if someone else already told you, but it appears UniversalLanguageSelector is missing some dependencies causing it to fail randomly on slow clients. mediawiki.api and mediawiki.api.* are missing from the module definition. [18:16:27] RobinHood70: btw if you email the mediawiki-l list those folks are good at helping with big upgrades [18:16:30] !lists | RobinHood70 [18:16:30] RobinHood70: mediawiki-l and wikitech-l are the primary mailing lists for MediaWiki-related issues. See https://www.mediawiki.org/wiki/Mailing_lists for details. [18:16:55] sumanah: I think the site owner may have already done that, but I'll pass the info along. [18:16:59] ok :) [18:17:22] Krinkle: thanks, did not notice that yet. Will fix [18:17:30] great [18:20:36] 03(mod) Provide metadata support on Wikimedia Commons - 10https://bugzilla.wikimedia.org/17503 summary; +comment (10Sumana Harihareswara) [18:24:40] 03(ASSIGNED) @import styles broken in .css in user and site modules - 10https://bugzilla.wikimedia.org/35562 (10Krinkle) [18:24:42] New patchset: Santhosh; "ext.uls.preferences need mediawiki.api" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/22056 [18:25:28] 03(mod) Selecting photo from picasa in my gallery causes app to crash - 10https://bugzilla.wikimedia.org/39604 +comment (10Brion Vibber) [18:25:31] RobinHood70: Krinkle is also one of our JavaScript wizards but I know he's always hella busy [18:26:04] I'm actually just writing Matma a description on his pl.wikipedia.org page...at least assuming it's the same person. :) [18:26:16] today and tomorrow I'm packed [18:26:24] (with work) [18:26:38] RobinHood70: I also presume this :) [18:26:47] 03(mod) Provide metadata support on Wikimedia Commons - 10https://bugzilla.wikimedia.org/17503 +comment (10Lydia Pintscher) [18:27:00] Krinkle: There's no great rush. If you're able to help, great, if not, no worries. The post will be up at http://pl.wikipedia.org/w/index.php?title=Dyskusja_wikipedysty:Matma_Rex in a minue. [18:27:03] *minute [18:28:01] New patchset: Hoo man; "dd JavaScript var wgCurRevisionTime with the last edit time" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22057 [18:29:15] New patchset: Hoo man; "Add JavaScript var wgCurRevisionTime with the last edit time" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22057 [18:29:21] sumanah: Okay, problem is posted. I'll see if that gets any replies from him or anyone else. Thanks for pointing me to a couple of people! [18:29:36] thank you for using MediaWiki, RobinHood70 [18:29:40] :D [18:29:40] do you like it, mostly? [18:29:45] 03(mod) @import styles broken in .css in modules that combine multiple stylesheets - 10https://bugzilla.wikimedia.org/35562 summary; +comment (10Krinkle) [18:29:55] 03(mod) Gadgets with CSS+JS should not have their stylesheet ripped out of context into the only=styles - 10https://bugzilla.wikimedia.org/35471 (10Krinkle) [18:29:57] 03(mod) @import styles broken in .css in modules that combine multiple stylesheets - 10https://bugzilla.wikimedia.org/35562 (10Krinkle) [18:29:58] Oh yeah, I love how MW works. [18:30:28] 03(mod) @import styles broken in modules that combine multiple stylesheets - 10https://bugzilla.wikimedia.org/35562 summary (10Krinkle) [18:30:38] Okay, I'm off. Thanks again, sumanah! [18:31:57] 03(mod) CAPTCHA that feeds to Wikisource - 10https://bugzilla.wikimedia.org/32695 +comment (10Sumana Harihareswara) [18:32:18] 03(FIXED) WLMMobile: should show spinner while doing GPS lookup - 10https://bugzilla.wikimedia.org/39248 (10Arthur Richards) [18:33:44] 03(mod) Login should only be required when uploading photos - 10https://bugzilla.wikimedia.org/39711 normal->04BLOCKER (10Arthur Richards) [18:36:23] Dantman: https://www.mediawiki.org/wiki/Annoying_large_bugs in case you could update that with links to your specs, code ideas thread posts, etc [18:37:43] 03(ASSIGNED) Selecting photo from picasa in my gallery causes app to crash - 10https://bugzilla.wikimedia.org/39604 +comment (10Brion Vibber) [18:38:08] New patchset: John Erling Blad; "(Bug 37685) Initial commit for checking edit conflicts" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20679 [18:40:46] New patchset: Kaldari; "Preventing error on upload success." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/22058 [18:45:12] New patchset: Daniel Werner; "Changed the way the 'eachchange' detection works (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22059 [18:46:19] 03(FIXED) Selecting photo from picasa in my gallery causes app to crash - 10https://bugzilla.wikimedia.org/39604 +comment (10Arthur Richards) [18:54:54] anybody here willing to merge a small core JS commit i'd very much like to see in wmf11? https://gerrit.wikimedia.org/r/#/c/21296/ [18:56:22] Looking [18:57:35] Change merged: Catrope; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21296 [18:58:27] hey, that was quick :D thanks a lot [18:58:51] how about another one? this one is a tiny big larger and not as important, though; https://gerrit.wikimedia.org/r/#/c/18234/ [18:58:58] tiny bit* [19:01:47] New patchset: Daniel Werner; "Changed the way the 'eachchange' detection works (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22059 [19:03:41] 03(NEW) Talkpage link not appearing - 10https://bugzilla.wikimedia.org/39803 normal; MediaWiki extensions: ArticleFeedbackv5; (okeyes) [19:05:40] New review: Daniel Werner; "Not sure, this is really faster, should be though. The advantage is that we don't register all the e..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/22059 [19:07:41] New patchset: Subramanya Sastry; "Experimental ref-tag support (for demoing purposes)." [mediawiki/extensions/Parsoid] (master) - https://gerrit.wikimedia.org/r/21992 [19:11:11] New patchset: Daniel Werner; "Changed the way the 'eachchange' detection works (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22059 [19:12:22] New patchset: Aaron Schulz; "Added NoSuchObjectException usage in object stream() function." [mediawiki/extensions/SwiftCloudFiles] (master) - https://gerrit.wikimedia.org/r/22061 [19:12:42] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/22061/ :) [19:15:00] Change merged: Catrope; [mediawiki/extensions/SwiftCloudFiles] (master) - https://gerrit.wikimedia.org/r/22061 [19:17:49] New patchset: Aaron Schulz; "[FileBackend] Improved getLocalCopy() performance for Swift." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22063 [19:18:04] New review: Aaron Schulz; "Uses https://gerrit.wikimedia.org/r/#/c/22061/" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/22063 [19:18:27] Warning: unlink(/Users/krinkle/Development/wm-git/mediawiki/core/images/thumb/8/84/Example.svg/123px-Example.svg.png) [function.unlink]: No such file or directory in /Users/krinkle/Development/wm-git/mediawiki/core/includes/filerepo/backend/FSFileBackend.php on line 418
[19:18:38] AaronSchulz: Maybe know know something about that? [19:18:44] I recall some recent changes to that area of code [19:18:51] I just got that on a bunch of pages on my localhost [19:19:13] (the image in question is from commons, the page itself hasn't been changed in weeks) [19:19:28] are you using instant commons? [19:19:33] I don't recall getting those [19:19:38] yes [19:20:32] * AaronSchulz wishes IC wasn't so garbagy [19:20:34] New patchset: Mtyeh411; "jQuery DataTables" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/22064 [19:20:45] or is that "garbagey"? :) [19:21:07] RoanKattouw: thanks, now https://gerrit.wikimedia.org/r/#/c/22063/ can be merged [19:21:50] 03(mod) Allow global renaming of global users - 10https://bugzilla.wikimedia.org/14862 +comment (10Rob Lanphier) [19:22:07] New patchset: Daniel Friesen; "Add getRootText, getRootTitle, getBaseTitle, and getSubpage methods to Title." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20478 [19:22:39] New review: Daniel Friesen; "PS2 Rebased" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/20478 [19:23:35] 03(mod) Allow global renaming of global users - 10https://bugzilla.wikimedia.org/14862 (10Aaron Schulz) [19:23:36] 03(mod) Fix use of DB schema so RenameUser is trivial - 10https://bugzilla.wikimedia.org/31863 (10Aaron Schulz) [19:24:48] ^demon: can you cr https://gerrit.wikimedia.org/r/#/c/22063/1 ? [19:25:23] 03(NEW) Rollback after on restore - 10https://bugzilla.wikimedia.org/39804 normal; MediaWiki extensions: WikidataRepo; (jeblad) [19:26:04] Change merged: Demon; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22063 [19:26:59] yay [19:27:23] 03(mod) Labs infrastructure work (tracking) - 10https://bugzilla.wikimedia.org/39784 +tracking (10Sam Reed (reedy)) [19:27:23] 03(mod) Tracking bug (tracking) - 10https://bugzilla.wikimedia.org/2007 (10Sam Reed (reedy)) [19:27:40] 03(mod) Add a new openstack network in pmtpa - 10https://bugzilla.wikimedia.org/39781 normal->15enhancement (10Sam Reed (reedy)) [19:27:41] 03(mod) Enable passwordless sudo for instances - 10https://bugzilla.wikimedia.org/39788 normal->15enhancement (10Sam Reed (reedy)) [19:27:44] 03(mod) Add eqiad as a production region - 10https://bugzilla.wikimedia.org/39789 normal->15enhancement (10Sam Reed (reedy)) [19:27:45] 03(mod) Add more network nodes - 10https://bugzilla.wikimedia.org/39787 normal->15enhancement (10Sam Reed (reedy)) [19:27:45] 03(mod) Create a labs SMTP smarthost - 10https://bugzilla.wikimedia.org/39785 normal->15enhancement (10Sam Reed (reedy)) [19:28:55] 03(mod) Run JUnit tests also in other locales than English - 10https://bugzilla.wikimedia.org/39801 normal->15enhancement (10Sam Reed (reedy)) [19:28:56] 03(NEW) [Regression] Warning: No such file or directory in /mw/includes/filerepo/backend/FSFileBackend.php on line 418 - 10https://bugzilla.wikimedia.org/39805 normal; MediaWiki: File management; (krinklemail) [19:30:17] * RoanKattouw embarks on an epic rebase [19:34:03] Change merged: Kaldari; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/22058 [19:35:11] hashar: ping [19:35:35] New patchset: Krinkle; "(bug 36329) Fix accesskey tooltip for Firefox 14 on Mac" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/17689 [19:35:42] chughakshay16: yup [19:36:07] 03(FIXED) Accesskey tooltips for Firefox 14 on Mac should use "ctrl-option-" prefix - 10https://bugzilla.wikimedia.org/36329 summary (10Krinkle) [19:36:16] Change merged: Krinkle; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/17689 [19:36:16] hashar: please see my comment -- https://gerrit.wikimedia.org/r/#/c/22028/ [19:36:32] 03(mod) Accesskey tooltips for Firefox 14 on Mac should use "ctrl-option-" prefix - 10https://bugzilla.wikimedia.org/36329 (10Krinkle) [19:37:52] New patchset: Kaldari; "Update UploadWizard to master" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/22065 [19:39:06] Change merged: Kaldari; [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/22008 [19:39:29] Change merged: Kaldari; [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/22065 [19:41:40] chughakshay16: well you could create a user :-D [19:42:25] chughakshay16: apparently we already have two testing users which you could reuse [19:43:07] chughakshay16: we get UTSysop by default apparently [19:45:12] hashar: how does one create those objects , any docs ? [19:46:19] well in your code you seem to need a user [19:46:21] so you could reuse the UTSysop user with: [19:46:34] $user = User::newFromName( 'UTSysop' ); [19:48:41] ...I just had an interesting idea for Gareth [19:48:55] ...OK [19:50:47] Usage of a STOMP server [19:51:55] Using a PUBLISH/SUBSCRIBE model Gareth publishes a message on every new review, update, fetch, etc... [19:53:00] A set of code dedicated to WebSocket handling subscribes to a portion of these and relays them to clients that ask for specific ones (provided they have permission) [19:54:25] This would power the fetch progress bar, a live "Most recent review branches" list on the frontage, etc... [19:56:44] Internally Gareth would actually subscribe to the STOMP server inside of a thread/process dedicated to email notifications. Instead of doing it right away. [19:57:03] 03(FIXED) Some Catalan monuments missing - 10https://bugzilla.wikimedia.org/39799 +comment (10Platonides) [19:58:20] For with a digest preference it would actually queue things up and wait for a timer to finish. Allowing messages to be grouped together. [19:59:10] Similarly IRC notifications would be handled by a thread/process dedicated to IRC that has subscribed to certain types of STOMP messages. [20:00:07] 03(mod) Some Catalan monuments missing - 10https://bugzilla.wikimedia.org/39799 +comment (10Platonides) [20:03:31] 03(NEW) Tap area for checkbox on incomplete uploads to small - 10https://bugzilla.wikimedia.org/39806 normal; WikiLoves Monuments Mobile: Upload; (arichards) [20:04:56] New patchset: Trevor Parscal; "Improved icons" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/22113 [20:05:04] 03(mod) Location where the photo was taken should be added to the upload if the location is made available - 10https://bugzilla.wikimedia.org/39745 +comment (10Jon) [20:05:17] hi [20:05:20] hi emijrp [20:05:28] how can i get the number of category members with API? [20:06:14] New patchset: Daniel Friesen; "Use hasSubjectNamespace in Skin.php instead of namespace tests." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22114 [20:06:37] New patchset: Daniel Friesen; "Add getRootText, getRootTitle, getBaseTitle, and getSubpage methods to Title." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20478 [20:06:55] Change merged: Nikerabbit; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/22056 [20:07:17] New review: Daniel Friesen; "PS3 Doc comments and split commit." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/20478 [20:08:13] New review: Daniel Friesen; "@Hashar" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20478 [20:08:26] \O/ [20:08:57] New review: Daniel Friesen; "Split from I4f7230c1." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/22114 [20:09:07] Dantman: you rocks :) [20:09:31] * Dantman has no work to do [20:09:55] I've been waiting for days for my boss to sign up for AWS and I've run out of things to work on. [20:09:55] Dantman: https://www.mediawiki.org/wiki/Annoying_large_bugs in case you could update that with links to your specs, code ideas thread posts, etc :) [20:09:59] you could help the i18n teams and their 119 bugs related to faulty message [20:10:10] there a a few extensions that could use PLURAL support for example [20:10:14] No no... [20:10:21] ohh at your real job [20:10:46] well what about having your company doing an inkind donation to the WMF by lending some of your time to WMF ? :-D [20:11:06] would be a nice tax evasion scheme [20:11:39] oh I remember what I Forgot to ask, to get tests on change 20478 :D [20:11:51] New review: Nikerabbit; "Works but that JS looks scary :)" [mediawiki/extensions/UniversalLanguageSelector] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/22044 [20:12:23] T_T Noo... noooooooooooo [20:12:35] Dantman: all okay? [20:12:45] I wanted to move on to one of the other commits that need followup [20:13:01] Dantman: getRootText I am not sure we need it [20:13:18] getRootTitle gives back a Title object which has a __tostr magic call [20:13:36] hashar, Eventually we're going to have {{ROOTPAGENAME}} [20:14:00] Change merged: Demon; [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/22041 [20:14:20] {{BASEPAGENAME}} is basically just $title->getBaseText() [20:14:48] It's actually fairly useful [20:15:26] getBaseTitle() use the same comment as getRootTitle() ;-D [20:15:26] if ( $title->hasSubjectNamespace( NS_USER ) ) { $user = User::newFromName( $title->getRootText(), false ); } [20:16:09] ? [20:16:18] "Get the base page name title, i.e. the leftmost part before any slashes" [20:16:27] used by both getBaseTitle and getRootTitle :-) [20:16:57] No no... ;) there is a very small difference between them [20:17:04] "Get the base page name title, i.e. the leftmost part before any slashes" [20:17:13] "Get the root page name title, i.e. the leftmost part before any slashes" [20:17:22] ...ok, small mistake [20:17:29] ;) but they're still not the same [20:17:31] and add @since 1.20 to all [20:17:35] while you are at it :) [20:18:09] New review: Hashar; "Could use some @since 1.20 on all new methods. That is a regular request from third parties." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/20478 [20:18:21] a few tests would be great if you have time to do them [20:19:02] still wondering if we should keep the term "Base" or migrate to something else [20:20:28] Add in twenty functions with different, but synonomous names [20:20:44] Make them all call the first function [20:20:49] Better yet, daisy-chain them [20:21:01] Change merged: Demon; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/12223 [20:21:22] getUnmodifiedName() -> getNormalName() -> getSimpleName() -> getBaseName() [20:26:35] New review: Mwjames; "In general I haven't tested the format yet but we might want to care for the naming since the plugin..." [mediawiki/extensions/SemanticResultFormats] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/22064 [20:29:16] New patchset: Daniel Friesen; "Add getRootText, getRootTitle, getBaseTitle, and getSubpage methods to Title." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20478 [20:30:20] New review: Daniel Friesen; "PS4 Fix doc comment, add @since, and add tests." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/20478 [20:32:19] 03(mod) API: Allow edit conflict detection based on revid - 10https://bugzilla.wikimedia.org/32037 +comment (10Krinkle) [20:32:29] New review: Mwjames; "In regards to the resource file naming see [1]" [mediawiki/extensions/SemanticResultFormats] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/22064 [20:33:34] 03(ASSIGNED) deploy MediaWiki + ext automatically on beta labs - 10https://bugzilla.wikimedia.org/39701 summary; +comment (10Antoine "hashar" Musso) [20:34:29] ...PHP is really lame... Python has the same key restriction on retrieving a value from a dict (No actually it's worse, they actually throw an error instead of just warning you). But PHP doesn't have something to match Python's d.get('key'( [20:35:01] New patchset: Bsitu; "Update maintenance and deletion tag" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/22115 [20:35:06] Almost tempted to add wfArrayGet [20:36:25] ?? [20:38:19] New review: Daniel Friesen; "@Hashar" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/17793 [20:41:53] PHP: $asdf = isset( $input['asdf'] ) ? $input['asdf'] : null; [20:42:08] Python: asdf = input.get('asdf') [20:42:31] wfArrayGet: $asdf = wfArrayGet( $input, 'asdf' ); [20:42:37] Nikerabbit, ^ [20:42:57] cute [20:44:24] asdf = input.asdf || null; [20:44:25] asdf = input.get('asdf') [20:44:32] JS and Python are pretty close [20:44:47] I suppose if undefined was an acceptable result instead of null, JS would win [20:44:55] Dantman: ^ [20:44:58] ... [20:45:05] * Dantman kicks marktraceur  [20:45:10] New patchset: Krinkle; "Addressing problems with jquery.badge mentioned at I0f5e7541" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20224 [20:45:11] asdf = input.asdf; [20:45:18] undefined IS acceptible. [20:45:22] null is not. [20:45:34] Dantman: Fair enough! [20:45:37] undefined is JS version of null. [20:45:45] Dantman: So what's null? :P [20:45:47] null is JS's version of null :) [20:45:51] yes, avoid usage of null in javascript, it is annoying and cripple [20:45:56] Hi everybody [20:46:03] undefined is like null is in python and php. [20:46:06] conG: Hi!! [20:46:28] null is partially a mistake, partially useful if you're doing really low level stuff where you actually do have a reason for undefined and null to mean two different things. [20:46:49] Or are working with a broken DOM interface that won't accept undefined (I think there might be one or two old ones) [20:46:55] Can someone help me ? I would like to make a scroll page like this (http://fr.wikipedia.org/wiki/Aide:Boussole) on a mediawiki website, but it doesn't work with mediawiki ... [20:46:58] Besides that null should be avoided like the plague. [20:47:03] undefined - it doesn't exist and never did; null - it used to exist but doesn't anymore ? :) [20:47:24] No [20:47:38] New review: Krinkle; "* A few code style changes" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20224 [20:47:51] New review: Jeroen De Dauw; "Great work! :) Need to take care of james inline comments though :)" [mediawiki/extensions/SemanticResultFormats] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/22064 [20:47:53] New patchset: Krinkle; "Addressing problems with jquery.badge mentioned at I0f5e7541" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20224 [20:48:03] New review: Krinkle; "* Rebased" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20224 [20:48:04] More like if you're parsing and want undefined = Haven't done this yet. null = Done it and it doesn't exist. [20:48:19] *nod* sounds good [20:48:31] And the key in question is a boolean so you can't set it to false. [20:49:08] Besides that if you use null you will fall victim to one of JS' biggest mistakes. [20:49:20] typeof null === 'object' [20:49:25] Hehe, true [20:49:31] hi [20:49:34] But === null would still work [20:49:37] koosha: Hi!! [20:49:56] conG: I'd imagine there's either some magic extension or a template that you need to have [20:49:57] var a = null; if ( typeof a === 'object' ) { a.foo = 'bar'; } [20:50:08] > Fatal error. [20:50:28] Dantman: var a = null; if ( a !== null ) [20:50:30] 03(FIXED) Set log_page to the page_id of its description page for upload actions - 10https://bugzilla.wikimedia.org/38606 +comment (10Krenair) [20:50:45] Dantman: typeof is such a hack [20:50:56] * marktraceur feel greasy every time he uses it [20:51:17] marktraceur, Actually `if ( typeof a === 'object' && a !== null ) { a.foo = 'bar'; }` [20:51:21] New patchset: Aaron Schulz; "[FileBackend] Improved stat caching by reducing cache salting." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22118 [20:51:22] Functions? First class objects. Types? Fuck those guys, they can be strings. [20:51:33] ^demon: another one https://gerrit.wikimedia.org/r/#/c/22118/ [20:51:53] New patchset: Krinkle; "Add and update some missing release notes for rl modules." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22119 [20:51:57] Change merged: Krinkle; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20224 [20:52:25] marktraceur, You'll want typeof in a lot of places to differentiate object input from strings, etc... that have a different meaning. [20:52:36] 03(mod) deploy MediaWiki + ext automatically on beta labs - 10https://bugzilla.wikimedia.org/39701 +comment (10Antoine "hashar" Musso) [20:52:53] Dantman: marktraceur I recommend using Object( x ) !== x as the way to check if something is an object instead of a primitive value [20:52:55] Dantman: I'm sure there are uses for it, but that doesn't make me feel any less greasy. [20:53:03] also guards against other quirks that way [20:53:05] including null [20:53:06] See, that's a great thing. [20:53:44] * marktraceur is so happy with the output of Object( null ) [20:54:34] * marktraceur is so unhappy with the output of Object( [1,2,3] ) [20:57:45] Array is an object ;) get used to it [20:58:08] Change merged: Demon; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22118 [20:59:27] New patchset: Chughakshay16; "Php unit tests fixed" [mediawiki/extensions/ConventionExtension] (master) - https://gerrit.wikimedia.org/r/22028 [20:59:59] 03(mod) Image alt value '0' should not be removed - 10https://bugzilla.wikimedia.org/38910 (10Koosha Khajeh Moogahi [:koosha]) [21:02:24] New patchset: Ori.livneh; "Disable CT for community portal and account creation" [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/22120 [21:02:44] Help : I would like to remove or change some of the page protection levels on my wiki, I currently have, all users, new and unregistered users, admin's 'crats, dev's and founder. I would like to remove 'crats, dev's and founder. My concern is will I have access to the pages that are set to the levels I remove ? [21:03:00] Change merged: Ori.livneh; [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/22120 [21:04:03] New patchset: Reedy; "Make functions match definitions in Preprocessor interface" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22121 [21:04:26] using "$wgRestrictionLevels" I presume [21:05:04] Which none of ,y wiki's have set in LS.php [21:05:06] Mlpearc: you could always go thru [[Special:ProtectedPages]] and change protection levels first? [21:05:19] VG :P [21:05:27] TY [21:05:30] (you can choose restriction level in the form there) [21:05:35] should of looked first :P [21:05:43] New patchset: Yaron Koren; "Fix for b9af052686f928bc107eb89a6d1d8fa7703df9fd - a call to hideDiv() needed updating" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/22122 [21:06:15] Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21578 [21:06:22] MatmaRex: Thanx for your help :) [21:06:41] Change merged: Yaron Koren; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/22122 [21:06:47] :) [21:09:44] Change merged: Catrope; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22119 [21:10:09] New patchset: Ori.livneh; "Update extension E3Experiments to master" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/22123 [21:10:34] Change merged: Ori.livneh; [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/22123 [21:11:31] 03(FIXED) Radiobuttons not working properly when using show on select - 10https://bugzilla.wikimedia.org/39098 +comment (10Yaron Koren) [21:12:29] 03(NEW) Inconsistent photo upload comments - 10https://bugzilla.wikimedia.org/39807 normal; WikiLoves Monuments Mobile: Upload; (arichards) [21:13:31] 03(NEW) After uploading saved photos, back button displays upload progress screen - 10https://bugzilla.wikimedia.org/39808 normal; WikiLoves Monuments Mobile: Upload; (arichards) [21:14:51] New patchset: MaxSem; "New hook ApiMain::onException" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/22124 [21:16:04] Dantman: I guess my thought was, "oh, it'll make a new object like {1: 1, 2: 2, 3: 3}" but apparently it also magic-transfers the bits that make it an Array [21:16:47] marktraceur, Well no... if Object() see's an object it just returns the exact same object that was passed into it. [21:17:03] So `var a = [1]; Object( a ) === a;` [21:17:17] ...MediaTemple really looks like a bad host. [21:17:22] Krinkle (and anyone else): Long story short: I need to know whether the user got the delete right on many page views (I really have to know (s)he got that right, I can't work with groups etc.). Right now I'm askin the API for the list of rights on every of those page views. [21:17:38] Wait....but why doesn't it return null for Object( null )? It's just smart enough to exclude it? [21:17:40] But that's a performance nightmare [21:17:44] hoo: mw.user.getRights() [21:18:03] marktraceur, ;) it's not actually an object [21:18:05] marktraceur: Noo, its not "smart" it just makes sense [21:18:32] Dantman: null is not an object, so Object(null) creates an empty object, and since null has no properties it stays empty object [21:18:45] Krinkle: But that function reloads the data from the API on every page view [21:18:56] hoo: Yep [21:19:11] I mean, clearly it's more than if ( typeof initial === 'object' ) return initial; [21:19:14] Don't care about that, if it needs optimization, it'll be optimized with localStorage or something [21:19:26] just use it, it is already cached within each page view, and the request is cached in the API as well [21:19:29] Krinkle: That's one of the reasons I added jStorage [21:19:44] marktraceur: Object() converts non-objects to objects and leaves objects as-is [21:19:51] marktraceur, null is not an object, never has been. The issue is that there was a mistake in the initial implementation of typeof that returned 'object' instead of something like 'null' for null. And it got codified into the spec. [21:19:52] The API sets Cache-Control private, so it doesn't cache [21:20:02] New patchset: Nullspoon; "Added $wgWhitelistReadRegexp for regex whitelisting" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/11137 [21:20:22] Change merged: Bsitu; [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/21703 [21:20:26] 03(NEW) Windows 8 app: include higher-resolution application tile images - 10https://bugzilla.wikimedia.org/39809 normal; Wikipedia App: Generic; (brion) [21:20:32] marktraceur: typeof is an operator, not a magic tool that yields the real type. typeof is specified to return 'object' for null. It is not a bug, it is specified that way in the language for historical reasons. [21:20:32] All implementations know what is and isn't an object, typeof doesn't use that. [21:21:13] hoo: it is cached server side to some degree, but just let it be. don't worry about performance too much. [21:21:21] Huh. [21:21:30] If the servers melt down, we know where to find you :P [21:21:51] typeof returns 'object' and it's not an object....seems like a bug to me, but I guess that's why we don't use null, and why avoiding typeof is good. [21:21:58] 03(mod) Windows 8 app: include higher-resolution application tile images - 10https://bugzilla.wikimedia.org/39809 +comment (10Brion Vibber) [21:22:38] [MediaTemple] Performance issues from some of our clients. They can't keep their mime type list up to date. And when a customer asks about it they link to information on .htaccess files and say that those kind of questions are not within their level of support. [21:22:39] marktraceur: It is a bug in a way, but it can't be fixed because the web is huge, bigger than any other platform. and changing it breaks stuff in unimaginable ways. [21:22:41] Krinkle: I plan to make action=query&list=users actually return the real rights anyway (that one caches) [21:22:50] New patchset: Dereckson; "(bug 39795) Add CSS classes to identify contributions items" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22030 [21:23:00] It is all thanks to microsoft who took great care to copy all the bugs when they reverse engineered Netscape's LiveScript into their MS JScript [21:23:22] and then when they went to ECMA to specify it ("EcmaScript") microsft demand they specified the bugs so everything was compatible [21:23:32] (okay, that is somewhat harmonized and simplified) [21:23:56] New patchset: Aaron Schulz; "[FileBackend] Reduced CDN purging when CDN is enabled." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22125 [21:24:30] New patchset: AABoyles; "Possible fix for the ShowAnons only current breadcrumb bug" [mediawiki/extensions/BreadCrumbs] (master) - https://gerrit.wikimedia.org/r/22126 [21:24:49] 03(NEW) Windows 8 app: include higher-resolution "W" generic background icon - 10https://bugzilla.wikimedia.org/39810 normal; Wikipedia App: Generic; (brion) [21:25:06] Noooooooooooooooooooo... [21:25:29] New review: Dereckson; "Adding mw-contributions-separator (matching the dots, ". ."), per bug 39795, comment 3." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/22030 [21:26:00] T_T They removed typeof null === 'null' from es-harmony because it broke too many websites when Chrome tried to implement it. [21:26:17] there may be hope in ES6 [21:26:38] ...Harmony=ES6 last I checked [21:26:43] 03(mod) More specific CSS classes for Special:Contributions - 10https://bugzilla.wikimedia.org/39795 +comment (10Dereckson) [21:26:48] Meh, in a way [21:26:58] though ES-harmony died-ish in place of ES5 [21:27:16] then ES6 started, hopefully not where Es-harmony left off, but certainly inspired by it [21:27:58] 03(NEW) Windows 8 app: load tile photos at native resolution - 10https://bugzilla.wikimedia.org/39811 normal; Wikipedia App: Generic; (brion) [21:28:45] New patchset: Nullspoon; "Added $wgWhitelistReadRegexp for regex whitelisting" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/11137 [21:29:48] 03(NEW) Windows 8 app: back button should use native WinJS button with stock icon - 10https://bugzilla.wikimedia.org/39812 normal; Wikipedia App: Generic; (brion) [21:30:01] New review: Aaron Schulz; "Passes swift test; note WMF doesn't use CDN." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/22125 [21:30:20] 03(NEW) Implement immutable object constructors with caching for mw.User, mw.Title, mw.Page (tracking) - 10https://bugzilla.wikimedia.org/39813 enhancement; MediaWiki: JavaScript; (krinklemail) [21:30:22] hoo: ^ [21:30:52] :) [21:32:05] New patchset: Kaldari; "Fixing case where only upload is a duplicate-archive... and user chooses to override in UploadWizard" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/22127 [21:32:38] Dantman: btw, did you know jQuery data uses dots as separates so mw.notification is internally stored in an mw property (this is a good thing) [21:32:52] Change merged: Kaldari; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/22127 [21:32:55] Heh [21:33:10] oh, not anymore apparently [21:33:15] lol [21:33:18] $('
').data('mw.foo', 1).data() [21:33:59] Dantman: hm.. the other way around works ish [21:34:00] $('
').data('mw', { foo: 1 }).data('mw.foo.bar') [21:34:12] it just returns the highest available object by that name separated by dot [21:34:14] it returns mw [21:34:17] weird [21:35:27] Dantman: I do know that a-z is converted to aZ internally [21:35:42] so that javascript access can go through propertyNames and set in html as data-property-names [21:35:45] which makes sense [21:35:50] New patchset: Kaldari; "Update UploadWizard to master" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/22128 [21:35:57] Change merged: Kaldari; [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/22128 [21:36:05] e.g. $a.data().propertyNames [21:36:23] New patchset: Bsitu; "Fix title object initialization in javascript" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/22129 [21:36:48] New patchset: Jeroen De Dauw; "Added missing message" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/22130 [21:38:57] New patchset: Daniel Werner; "Simple speed optimization of input auto expansion" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22131 [21:39:25] Krinkle: I'll abandon the change then, I guess?! [21:39:38] revtime ? [21:39:40] New patchset: Reedy; "Add .gitreview" [mediawiki/extensions/GlobalNotice] (master) - https://gerrit.wikimedia.org/r/22132 [21:39:43] yeah [21:39:47] Yes ;) [21:40:12] * AaronSchulz pings reedy about execption.log cruft [21:40:38] Change merged: Krinkle; [mediawiki/extensions/GlobalNotice] (master) - https://gerrit.wikimedia.org/r/22132 [21:40:43] New review: GWicke; "Would be great to match any mw:Object- see inline comments." [mediawiki/extensions/Parsoid] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21992 [21:40:45] Change abandoned: Hoo man; "Per discussion with Krinkle: We don't want to send even more stuff with the request on page load. Se..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22057 [21:41:15] Krinkle: But what about the API edit conflic detection with IDs, is it worth implenting? [21:41:30] New patchset: Reedy; "Add .gitreview" [mediawiki/extensions/InterwikiMagic] (master) - https://gerrit.wikimedia.org/r/22133 [21:41:42] I don't know, file a bug and/or assign it to Roan or Reedy who can tell more about it [21:41:57] I don't think it is useful / needed / improving, but maybe they know more a bout it [21:42:05] I think it is incorrect play [21:42:06] I'll ask Roan, I guess... or if it's not to much work, I'll just give it a shot [21:42:25] * hoo starts to like Gerrit :D [21:42:34] New patchset: Reedy; "Add .gitreview" [mediawiki/extensions/LinkFilter] (master) - https://gerrit.wikimedia.org/r/22134 [21:42:39] because the only reason is because that's what mw.config gives, which is a rather odd justification [21:42:40] because it is not part of the api [21:42:40] the api gives both, so wherever there is an id there is a timestamp as well. [21:43:10] Yes, but you have to agree, that it both makes some sense [21:43:17] using the id has no downsides [21:43:32] 03(mod) More specific CSS classes for Special:Contributions - 10https://bugzilla.wikimedia.org/39795 -design ; +comment (10Krinkle) [21:43:47] 14(WFM) Can't pin articles to Windows 8 start page - 10https://bugzilla.wikimedia.org/37396 +comment (10Brion Vibber) [21:43:51] New patchset: Reedy; "Add .gitreview" [mediawiki/extensions/NewSignupPage] (master) - https://gerrit.wikimedia.org/r/22135 [21:44:14] New patchset: Trevor Parscal; "Improved icons" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/22113 [21:44:21] Krinkle, hoo: It's because it's what EditPage uses, and we wrap around EditPage [21:44:42] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticWatchlist] (master) - https://gerrit.wikimedia.org/r/21769 [21:44:48] New patchset: Reedy; "Add .gitreview" [mediawiki/extensions/ShoutBox] (master) - https://gerrit.wikimedia.org/r/22136 [21:44:52] RoanKattouw: So, do you think it's worth implementing or would just clutter up the code [21:45:08] 04(REOPENED) Semantic Maps does not export coordinates in RDF - 10https://bugzilla.wikimedia.org/33504 +comment (10Jeroen De Dauw) [21:45:24] New patchset: Reedy; "Add .gitreview" [mediawiki/extensions/URNames] (master) - https://gerrit.wikimedia.org/r/22137 [21:45:26] New patchset: Daniel Friesen; "[mw.notification] Introduce a full fledged notification system into core replacing jsMessage." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/19199 [21:45:26] New patchset: Daniel Friesen; "Fix up the preferred way to specify mw.util.$content" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/19008 [21:45:49] I would probably fetch the timestamp of that id from the DB and then fire as normal [21:45:50] New review: Daniel Friesen; "PS8 Rebased." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/19199 [21:45:51] New review: Jeroen De Dauw; "The fix is not working as far as I can tell. It's broken before applying it, and it's equally broken..." [mediawiki/extensions/SemanticMediaWiki] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/22045 [21:46:02] hoo: What exactly is or isn't worth implementing? Sorry I keep dropping off the wifi so I haven't been following along [21:46:28] RoanKattouw: api edits with id as edit conflict protector [21:46:37] "hoo: I would probably fetch the timestamp of that id from the DB and then fire as normal" [21:46:49] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/22130 [21:46:49] New review: Daniel Friesen; "PS8 Rebased." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/19008 [21:46:50] New patchset: Reedy; "Add .gitreview" [mediawiki/extensions/Video] (master) - https://gerrit.wikimedia.org/r/22138 [21:47:15] hoo: Yeah so what's the reasoning behind adding that feature? [21:47:42] RoanKattouw: The only I see is that we got wgCurRevisionId in JS on page loads and wouldn't need to fetch it using http then [21:48:00] Ah, Ok [21:48:08] So the reason is "I don't have the right piece of data in JS" [21:48:20] Change merged: Reedy; [mediawiki/extensions/InterwikiMagic] (master) - https://gerrit.wikimedia.org/r/22133 [21:48:21] Yep, but Krinkle's on that :P [21:48:33] How do you have the right wikitext to edit when you don't have the timestamp? [21:48:36] Change merged: Reedy; [mediawiki/extensions/LinkFilter] (master) - https://gerrit.wikimedia.org/r/22134 [21:48:38] I today tried to introduce wgCurRevisionTime, but already abondoned [21:48:43] Change merged: Reedy; [mediawiki/extensions/NewSignupPage] (master) - https://gerrit.wikimedia.org/r/22135 [21:48:50] Change merged: Reedy; [mediawiki/extensions/ShoutBox] (master) - https://gerrit.wikimedia.org/r/22136 [21:48:51] Dantman: appendtext/ prependtext ;) [21:48:55] New patchset: Yaron Koren; "New version: 2.5" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/22139 [21:48:59] Change merged: Reedy; [mediawiki/extensions/URNames] (master) - https://gerrit.wikimedia.org/r/22137 [21:49:06] Change merged: Reedy; [mediawiki/extensions/Video] (master) - https://gerrit.wikimedia.org/r/22138 [21:49:36] Ok... I guess there are cases you might want that to editconflict. [21:49:51] Dantman: Exactly [21:49:52] New review: Krinkle; "It may be wise to use a more generic classname and implement it in other changes lists as well (Hist..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/22030 [21:50:09] Change merged: Yaron Koren; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/22139 [21:50:24] Though `mw.revision.timestamp` sounds much nicer. [21:51:11] Well... ;) adding both would be ideal [21:51:40] Dantman: Well, see https://gerrit.wikimedia.org/r/#/c/22057/ fro wgCureRevisionTime [21:51:56] and I didn't yet give the API change a shot (and probably wont) [21:52:47] 03(mod) Update GeSHi library when a new version is available - 10https://bugzilla.wikimedia.org/37585 +comment (10Dereckson) [21:52:48] 03(mod) a lone "0" in a tag disappears - 10https://bugzilla.wikimedia.org/39643 (10Dereckson) [21:53:05] 03(mod) Update GeSHi library when a new version is available - 10https://bugzilla.wikimedia.org/37585 (10Dereckson) [21:53:05] 03(mod) a lone "0" in a tag disappears - 10https://bugzilla.wikimedia.org/39643 (10Dereckson) [21:54:06] Wow... how /polite/ of you Gerrit. [21:54:19] 03(NEW) Maintenance script needed for updating instance pages - 10https://bugzilla.wikimedia.org/39814 normal; MediaWiki extensions: OpenStackManager; (rlane32) [21:55:13] A dependency gets desynced due to a new patch set... so you go and remove the "Needed by" reference making it harder to find the commit that needs rebasing. [21:58:22] New review: Hashar; "Well done! ;-]" [mediawiki/extensions/ConventionExtension] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/22028 [22:01:34] 03(mod) Windows 8 Metro port of PhoneGap app - 10https://bugzilla.wikimedia.org/32279 +comment (10Brion Vibber) [22:02:06] New patchset: Reedy; "Add .gitignore" [mediawiki/extensions/GlobalNotice] (master) - https://gerrit.wikimedia.org/r/22140 [22:02:14] New patchset: Reedy; "Add .gitignore" [mediawiki/extensions/InterwikiMagic] (master) - https://gerrit.wikimedia.org/r/22141 [22:02:21] 03(mod) Inconsistent photo upload comments - 10https://bugzilla.wikimedia.org/39807 +comment (10Brion Vibber) [22:02:21] New patchset: Reedy; "Add .gitignore" [mediawiki/extensions/LinkFilter] (master) - https://gerrit.wikimedia.org/r/22142 [22:02:29] New patchset: Reedy; "Add .gitignore" [mediawiki/extensions/NewSignupPage] (master) - https://gerrit.wikimedia.org/r/22143 [22:02:36] New patchset: Reedy; "Add .gitignore" [mediawiki/extensions/ShoutBox] (master) - https://gerrit.wikimedia.org/r/22144 [22:02:44] New patchset: Reedy; "Add .gitignore" [mediawiki/extensions/URNames] (master) - https://gerrit.wikimedia.org/r/22145 [22:02:51] New patchset: Reedy; "Add .gitignore" [mediawiki/extensions/Video] (master) - https://gerrit.wikimedia.org/r/22146 [22:03:02] /silence Reedy [22:04:03] 03(mod) Tap area for checkbox on incomplete uploads to small - 10https://bugzilla.wikimedia.org/39806 +comment (10Brion Vibber) [22:07:55] New patchset: Reedy; "Add .gitignore and .gitreview" [mediawiki/extensions/ProxyListDb] (master) - https://gerrit.wikimedia.org/r/22147 [22:08:02] New patchset: Daniel Friesen; "Add support for HTML5/Microdata ,