[00:00:04] exbe, an impressively long article history, but what's your point? [00:00:17] 03(NEW) Region needs to be defined in the instances pages - 10https://bugzilla.wikimedia.org/39820 normal; MediaWiki extensions: OpenStackManager; (rlane32) [00:00:23] there's nothing really special about the fact that some of these revisions were made in 2001 [00:00:52] 03(mod) Labs infrastructure work (tracking) - 10https://bugzilla.wikimedia.org/39784 (10Ryan Lane) [00:00:53] 03(mod) Set project group as default gid for instances in a project - 10https://bugzilla.wikimedia.org/39819 (10Ryan Lane) [00:01:48] New patchset: MarkAHershberger; "Bug 35623 - createAndPromote.php: Change to allow promotion only" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22157 [00:01:50] just intresting in tech details, since in my understanding it really huge operation for database [00:02:05] 03(mod) createAndPromote.php: Change to allow promotion only - 10https://bugzilla.wikimedia.org/35623 summary (10Mark A. Hershberger) [00:02:15] exbe: The revisions are indexed by timestamp, so really it's not [00:02:47] Index lookups are fast even in a table that has half a billion rows [00:03:12] New patchset: Kaldari; "Revert "Setting up a way to have uploading by URL, but not on Special:Upload"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22160 [00:04:05] so there is not a kinfd of magic... I though load balancer redirects my request to some specify server with all of data [00:04:08] 03(NEW) Add configuration option to force OATH for specific groups - 10https://bugzilla.wikimedia.org/39821 normal; MediaWiki extensions: OATHAuth; (rlane32) [00:05:14] regular view doesn't require any history pages, but I need to search in very large table to find my last rev id [00:05:51] Change abandoned: Kaldari; "replaced by https://gerrit.wikimedia.org/r/#/c/22160/1" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22159 [00:06:35] Change merged: Kaldari; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22160 [00:07:07] hello. im on mediawiki 1.16.0 and i cant seem to disable edit links via localsettings using:$wgDefaultUserOptions['editsection']=0; [00:07:14] so a solution with light database with pages with one or dozen revisions are looked very natural for me. seems I was wrong: -) will perform some tests on huge db [00:08:00] RoanKattouw, Krenair thanks a lot for answers [00:09:29] New patchset: Catrope; "Also copy cloneable objects in ve.copyArray()" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/22161 [00:09:40] 03(mod) createAndPromote.php: Change to allow promotion only - 10https://bugzilla.wikimedia.org/35623 +comment (10MZMcBride) [00:09:46] New patchset: Catrope; "Manage annotations in ve.AnnotationSet object" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/22162 [00:10:27] Change merged: Trevor Parscal; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/22161 [00:10:57] 03(mod) Creation of a new mailing list for Wikimedia Indigenous Languages, languages@ - 10https://bugzilla.wikimedia.org/39656 +comment (10Amqui) [00:11:38] would really appreciate some help. ive looked at several sites and nothing has worked yet. [00:13:36] cinvoke: What's your end goal? [00:13:55] cinvoke, do you have any installed plugins? [00:13:57] cinvoke: Are you trying to hide the links? [00:14:06] Or are you trying to disable-section editing? [00:14:12] Are you trying to hide the links only on a particular page? [00:14:33] Brooke, i want to hide the section edit links for anyone not logged in [00:14:54] cinvoke: If you take away their edit permission, the edit section links should just disappear automatically. :-) [00:15:00] At least in the recent versions of MediaWiki. [00:15:09] And the "edit" tab turns into "view source" or somethign similarly confusing. [00:15:46] Oh, do you want to retain editing, but just hide the links for anons (people not logged in)? [00:15:58] $wgDefaultUserOptions ['editsection'] = 0; <-- should work [00:16:02] Brooke, anons hidden [00:16:13] Brooke, they are still there [00:16:29] I'm asking what behavior you're after. [00:16:34] Not what behavior you're getting. [00:16:39] hiding the links [00:16:42] for anons [00:16:50] But you want the anons to still be able to edit? [00:17:00] Hiding the links alone doesn't disable editing, you realize? [00:17:10] no [00:17:15] no anon editing [00:17:19] Right-o. [00:17:23] Then you need to disable editing. [00:17:30] !access [00:17:30] For information on customizing user access, see . For common examples of restricting access using both rights and extensions, see . [00:17:41] https://www.mediawiki.org/wiki/Manual:Preventing_access#Restrict_anonymous_editing [00:17:44] That one. [00:18:01] The user preference is mostly tangential. It's about the actual display of [edit] links. [00:18:11] Not about the ability to edit. [00:18:13] :-) [00:18:17] Brooke, i wonder why "$wgDefaultUserOptions ['editsection'] = 0; " didnt work [00:18:26] cinvoke: Did you enable the user preference yourself? [00:18:41] no [00:18:43] That configuration variable sets the default. But if you've changed your preferences, you'll not have the default, you'll have an explicitvalue. [00:18:46] explicit value [00:18:47] Oh. [00:19:03] I'm not even sure why that option exists on a per-user basis. [00:19:09] I think it's an old user preference. [00:19:54] Brooke, thanks. ill see if i can find out what happened. i didnt know a user pref could override the $wgDefaultUserOptions ['editsection'] = 0; [00:20:24] anon doesn't have settings, so it should work for them [00:20:59] Right. [00:21:12] I think it's maybe just a html cache or you are not an anon user at this time [00:21:24] Or you put the variable above the DefaultSettings.php line. [00:22:10] yep [00:22:54] i put the editsection= 0 after the grouppermissions [00:23:13] at the end of LocalSettings? [00:23:16] cinvoke: And you tested with a logged out account? [00:23:17] no [00:23:25] no [00:23:28] Heh. [00:23:35] no i mean im logged out [00:23:52] And you still see the edit section links? [00:23:53] okay, hit action=purge just in case [00:24:07] ok 1 sec [00:24:10] and ctrl+f5 for purge your browser cache [00:24:57] did both [00:25:08] no result? [00:25:12] no [00:25:22] 03(mod) placeholder text color in search bar in Firefox 15 is black instead of gray - 10https://bugzilla.wikimedia.org/39793 +comment (10Krinkle) [00:25:22] okay, what do you see in the headline [00:25:40] did you see IP or something? [00:25:54] no its an internal site [00:26:04] but no [00:26:19] Did the links go away when you disabled anonymous editing? [00:26:22] does it have custom view? [00:26:42] by disable anon editing, you mean this? [00:26:43] $wgDefaultUserOptions ['editsection'] = 0; [00:26:47] No. [00:27:14] $wgGroupPermissions['*']['edit'] = false; [00:27:23] haha [00:27:45] that was already in the file :) [00:28:03] And you still have section edit links? [00:28:04] user, bot and sysop edit = true though [00:28:08] yes [00:28:12] When logged out? [00:28:16] yes [00:28:22] Hmm. Strange. [00:28:33] Can youe dit? [00:28:35] you edit [00:28:41] Does anonymous editing work? [00:28:41] let me check [00:28:47] Did you change related LS? [00:28:55] LS? [00:29:06] LocalSettings [00:29:09] says i dont have perm to edit [00:29:26] i think its the only localsetting i could find... [00:29:41] Previous versions of MediaWiki had a bug where [edit] links disappear when you didn't have appropriate permissions. [00:29:48] It's fixed in newer versions of MediaWiki. [00:30:19] so i created a syntax error in the LS to make sure it was using that one [00:30:34] i didnt know how else to make sure i was editing the right file [00:30:55] That's the right way. [00:31:01] :) [00:31:13] even on public wikies :-) [00:31:17] ha [00:31:20] https://bugzilla.wikimedia.org/show_bug.cgi?id=29123 [00:31:30] who doesnt test their code on production? [00:31:37] Hmm. [00:32:05] the bug you mentioned made the link go away? [00:32:10] New review: Brion VIBBER; "Quick inline note about that fixme, best to go ahead and clean it up and make the code more readable..." [mediawiki/extensions/Math] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/22156 [00:32:16] Oh, her ewe are: https://bugzilla.wikimedia.org/show_bug.cgi?id=30331 [00:32:18] cinvoke: ^ [00:32:21] 03(FIXED) Please reset list admin password for wikimediail-board - 10https://bugzilla.wikimedia.org/39454 +comment (10Philippe Beaudette) [00:32:24] Oh, closed WORKSFORME. [00:32:25] Herm. [00:33:01] cinvoke: Yeah, just upgrade MediaWiki. :-) [00:33:24] New patchset: Catrope; "Preserve the leading ./ and ../ in internal link hrefs" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/22163 [00:33:59] Brooke, ive suggested that, but no dice. Any other slightly painful or less way? [00:35:17] Dunno. Not inclined to debug years-old software that's already been fixed. :-) [00:35:28] Only so many hours in the day. [00:35:36] Live with the [edit] section links or upgrade your wiki. :-) [00:35:40] You can disable them on a per-page basis. [00:35:44] With __NOEDITSECTION__ or something. [00:35:48] NOSECTIONEDIT? [00:35:50] One of those. [00:35:54] That disables them for everyone. [00:36:11] eww [00:36:16] o well [00:36:38] i guess ill keep pushing for updating [00:36:58] maybe you have templates inside articles [00:37:09] so you can just put it into one of them [00:37:27] exbe, ill check that out [00:38:02] thank exbe, Brooke. i was getting no where googling the same solution :) [00:38:04] New patchset: Robmoen; "Repurpose broken code in fooerCleanup modules for Footer improvement." [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/22164 [00:38:35] 03(mod) Creation of a new mailing list for Wikimedia Indigenous Languages, languages@ - 10https://bugzilla.wikimedia.org/39656 +comment (10Thehelpfulone) [00:39:40] New review: Krinkle; "Mostly fine except for two minor points:" [mediawiki/extensions/VisualEditor] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/22113 [00:43:33] New review: Krinkle; "Also, the old ones were a bit off-black (which was nice) whereas the new ones are much more black (a..." [mediawiki/extensions/VisualEditor] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/22113 [00:44:44] !dumps [00:44:45] For information on how to get dumps from Wikimedia Wikis, see http://meta.wikimedia.org/wiki/Data_dumps [00:44:49] New patchset: Parent5446; "Added PHP complement for mw.Time." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/17107 [00:45:02] New review: Parent5446; "Rebased on master b/c of comments." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/17107 [00:47:54] 03(mod) Creation of a new mailing list for Wikimedia Indigenous Languages, languages@ - 10https://bugzilla.wikimedia.org/39656 +comment (10Étienne Beaulé) [00:49:48] !moving [00:49:48] For help about moving pages, see . For help about moving wikis, see . [00:50:09] Yeah, I use the bots for my own benefit [00:50:16] So what? Wanna fight about it? [00:50:42] 03(NEW) Special:Version should link to mediawiki.org release notes in most cases - 10https://bugzilla.wikimedia.org/39822 normal; MediaWiki: Special pages; (robla) [00:51:01] 03(mod) Special:Version should link to mediawiki.org release notes in most cases - 10https://bugzilla.wikimedia.org/39822 (10Rob Lanphier) [00:57:38] Hi, can I file a bug report? MediaWiki 1.8.x's createAndPromote.php is broken, the password isn't actually set [00:57:47] it also has a redundant call to setToken() and forgets to call saveSettings() [00:58:21] (I just created an account for myself on docs.jquery.com - yes it runs 1.8) [00:59:33] Krinkle: I'm not sure that anyone will care about that, uh [00:59:55] anyway, eval.php works too :) [01:00:01] fortunately it existed back then [01:01:48] this is almost adorable: http://docs.jquery.com/Special:Version [01:02:01] even better: http://docs.jquery.com/Special:Version?useskin=standard [01:04:50] even bettered http://docs.jquery.com/Special:Version?useskin=nostalgia [01:04:57] hey the Special page drop down is actually quite nice [01:06:09] Ha, I love it [01:14:29] marktraceur: https://nostalgia.wikipedia.org/wiki/HomePage [01:14:48] "already have over 19,000 articles. We want to make over 100,000, so let's get to work" [01:15:02] love that! [01:15:21] "links appear automatically on CamelCase words." <3 [01:16:00] the only wiki more ancient I know is the wiki wiki http://c2.com/cgi/wiki [01:16:00] 03(mod) Chunked upload fails with internal_api_error_UploadStashFileNotFoundException - 10https://bugzilla.wikimedia.org/36587 +comment (10Fastily) [01:16:19] that software is what ran Wikipedia earlier [01:16:35] but you can see that the nostalgia skin is based on that [01:16:49] that is, the little skin there is :P [01:17:47] no CamelCase words on nostalgia wiki though [01:17:47] t [01:17:54] that was never in mediawiki afaik [01:20:05] 03(mod) Creation of a new mailing list for Wikimedia Indigenous Languages, languages@ - 10https://bugzilla.wikimedia.org/39656 +comment (10Amqui) [01:21:21] I love it, Krinkle [01:24:15] 03(mod) Drafts needs ResourceLoader-ifying - 10https://bugzilla.wikimedia.org/37999 +comment (10Ori Livneh) [01:25:26] 03(mod) Creation of a new mailing list for Wikimedia Indigenous Languages, languages@ - 10https://bugzilla.wikimedia.org/39656 +comment (10Amqui) [01:28:50] 03(mod) Creation of a new mailing list for Wikimedia Indigenous Languages, languages@ - 10https://bugzilla.wikimedia.org/39656 +comment (10Robin Pepermans (SPQRobin)) [01:29:39] why does javascript/jquery expression $('a:first') throws an exception on hewiki and enwiki? [01:37:48] kipod works fine here [01:37:52] $('a:first') [01:38:01] > [ ​​ ] [01:38:20] he.wikipedia.org [01:42:25] New patchset: Parent5446; "Changed how Pager adds limit to pager queries." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22166 [01:45:43] New patchset: Parent5446; "Revert "Revert Uri class due to bug 39710"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22167 [01:55:10] Is it possible to restore a MediaWiki installation from only a MySQL database backup? [01:56:01] not completely [01:56:11] at least you have the content [01:56:48] how close can I get? All I really want to do it get it back so the new MediaWiki installation can display all of the data from the database. [01:57:56] I do not care about images or the like, just the pages and their content [01:58:40] then I think database is all you need, but I don't know about how to go around doing so [01:59:27] I've restored the database and updated the default LocalSettings.php to what I remember it use to be. Then I have run the rebuildall.php maintenance script. So far that has not worked. [02:00:25] did you run maintenance/update.php? [02:00:39] yea I ran that one too [02:01:17] so what's wrong? [02:01:25] still no content [02:01:32] even when I manually browse to a page [02:01:42] it thinks all the pages do not exist [02:01:50] hhm.... [02:01:58] * Jasper_Deng_sick can't do anything [02:06:01] hmm [02:52:29] New review: SPQRobin; "Whoops, meant -1" [mediawiki/extensions/Babel] (master) C: -1; - https://gerrit.wikimedia.org/r/22025 [03:07:43] 03(mod) Specify default language on a per-page basis - 10https://bugzilla.wikimedia.org/9360 +comment (10Robin Pepermans (SPQRobin)) [03:17:55] New patchset: MarkAHershberger; "Bug 35623 - createAndPromote.php: Change to allow promotion only" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22157 [03:24:56] New review: SPQRobin; "Sure, I know it's not supported yet in all browsers, but I don't really think it's worth adding fall..." [mediawiki/extensions/WikimediaIncubator] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20668 [03:39:17] 03(mod) Requesting a user-centred rethink of how watchlists work - 10https://bugzilla.wikimedia.org/33888 +comment (10zlight) [03:42:51] hmm, what format are the doc-comments in the mediawiki code written in? (Looking for the appropriate doc-generator) [03:46:03] New patchset: CSteipp; "(bug 39180) Set x-frame-options='DENY' for api" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/22168 [03:46:03] New patchset: CSteipp; "(bug 35839) Check permisions for revdel blocks" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/22169 [03:46:03] New patchset: CSteipp; "(bug 39184) LDAP password leakage" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/22170 [03:46:03] New patchset: CSteipp; "(bug 39700) html injection fix" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/22171 [03:47:47] Change merged: Tim Starling; [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/22168 [03:48:11] Change merged: Tim Starling; [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/22169 [03:48:34] Change merged: Tim Starling; [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/22170 [03:49:23] Change merged: Tim Starling; [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/22171 [04:04:45] csteipp, TimStarling: To deal with these cases where we may want input to be HTML yet we also may expect people to input text perhaps it's time to introduce a html wrapper class. [04:05:32] makeBrokenLinkObj( $title, new RawHtml( '...' ) ); if you actually need to nest markup. [04:06:08] there are no callers of makeBrokenImageLinkObj() aside from Linker.php itself [04:06:16] and it doesn't need HTML [04:06:24] so I think that would be premature [04:14:43] New review: Parent5446; "Yeah, but in this commit you also change strtok to use getRootText(), which is introduced in the oth..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/22114 [04:26:48] http://en.wikipedia.org/wiki/Special:ZeroRatedMobileAccess [04:27:19] It's as if the mobile team has never heard of the unlisted special page property [04:33:44] 03(mod) Windows 8 app: include higher-resolution application tile images - 10https://bugzilla.wikimedia.org/39809 +comment (10Brion Vibber) [04:35:35] NOTE: providing links to bugs in a security release announcement that the audience cannot actually view is probably counterporductive. [04:35:49] New review: Daniel Friesen; "I'll fix up the code later." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/19199 [04:40:57] New review: Parent5446; "Some inline comments. Also, it wouldn't hurt to add some comments explaining the code more." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/22157 [04:43:15] 03(mod) Windows 8 app: load tile photos at native resolution - 10https://bugzilla.wikimedia.org/39811 +comment (10Brion Vibber) [04:47:06] TimStarling: Did you have a chance to debug test2 for slowness? I saw your note at WP:VPT. [04:48:20] not really, I'm writing a profiler [04:48:54] 03(FIXED) Account creation allowed despite IP blocked with the GlobalBlocking extension - 10https://bugzilla.wikimedia.org/39824 (10Chris Steipp) [04:50:14] 03(FIXED) A File: link to a non-existing image can inject html - 10https://bugzilla.wikimedia.org/39700 (10Chris Steipp) [04:51:17] 03(mod) character filter for uselang - 10https://bugzilla.wikimedia.org/37587 (10Chris Steipp) [04:51:51] 03(FIXED) Edit tokens shown in frames using api - 10https://bugzilla.wikimedia.org/39180 (10Chris Steipp) [04:53:26] 03(FIXED) Password data leakage when using external authentication - 10https://bugzilla.wikimedia.org/39184 (10Chris Steipp) [04:53:47] New patchset: Santhosh; "Fix Bug 39800 Tooltip of ULS search results should be in current UI language" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/22046 [05:00:52] 03(FIXED) If a block log reason was rev-deleted, it is still visible for all admins in [[Special:Block]] - 10https://bugzilla.wikimedia.org/39823 (10Chris Steipp) [05:07:28] I assume https://bugzilla.wikimedia.org/show_bug.cgi?id=39762 can be unmarked as secret now? [05:10:12] Hmm, and https://bugzilla.wikimedia.org/show_bug.cgi?id=38333 [05:12:36] Already mentioned it above, Brooke. [05:13:01] 38333 has private data in it, it can't be made public [05:13:07] that's why I duped it to 39824 [05:13:55] 39762 can be made public [05:14:11] Amgine: Oh, these weren't in the e-mail, that I saw. Just mentioned in the bugs. [05:14:14] As dupes. [05:14:32] 38333 is marked as security... right?! [05:14:40] 03(FIXED) Make jsMessage nicer and more flexible - 10https://bugzilla.wikimedia.org/26888 +comment (10Krinkle) [05:14:45] 03(mod) XSS issue in image syntax - 10https://bugzilla.wikimedia.org/39762 (10Tim Starling) [05:15:05] * Aaron|home wonders how bug 39823 was fixed [05:15:15] 03(mod) Refactor jsMessage into mw.notification framework - 10https://bugzilla.wikimedia.org/26888 summary (10Krinkle) [05:15:22] yeah, 38333 is security, but I think you mentioned the bug number in the patch [05:16:15] Aaron|home: http://bug-attachment.wikimedia.org/attachment.cgi?id=11042 [05:16:43] seems pretty stupid to have to do that, but that's what the users were asking for, more or less [05:16:47] so the draft I see on my dashboard for that is redundant? [05:16:59] I guess [05:17:13] then maybe csteipp can abandon it [05:17:19] 14(WFM) Slide-down for popup message (jsMessage) on AJAX watch/unwatch horribly garbled on IE 7 - 10https://bugzilla.wikimedia.org/27231 +comment (10Krinkle) [05:17:34] Hm... I cherry-picked it out.. I think it needs to be merged now? [05:25:40] * Aaron|home reads http://www.humantransit.org/2010/12/is-sim-city-4-still-making-us-stupid.html [05:30:18] New patchset: Amire80; "Filtering out languages that the ULS doesn't recognize" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/22044 [05:31:44] morning [05:32:27] 03(NEW) Special:Version can warn about '#' comments in .git/config - 10https://bugzilla.wikimedia.org/39825 minor; MediaWiki: Special pages; (spage) [05:34:29] 03(NEW) Namespace link broken for Main page - 10https://bugzilla.wikimedia.org/39826 normal; Wikimedia: Site configuration; (sundarbecse) [05:35:36] 03(mod) Namespace link broken for Main page - 10https://bugzilla.wikimedia.org/39826 (10Sundar) [05:39:00] 03(NEW) WikiBook page/chapter configuration tools/API not working on Mac - 10https://bugzilla.wikimedia.org/39827 major; MediaWiki: API; (cs) [05:47:03] New patchset: Krinkle; "[mw.notification] Introduce a full fledged notification system into core replacing jsMessage." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/19199 [05:55:13] 03(mod) Prevent self-moderation of ArticleFeedback posts - 10https://bugzilla.wikimedia.org/39818 +comment (10Matthias Mullie) [05:57:20] New patchset: Krinkle; "[mw.notification] Introduce a full fledged notification system into core replacing jsMessage." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/19199 [05:57:51] New review: Krinkle; "* Address inline comments in PS8" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/19199 [05:58:12] New review: Krinkle; "* Remove unneeded conditional" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/19199 [06:11:29] Hello [06:25:17] 03(NEW) Sandbox for MediaWiki-style internal links within Bugzilla comments - 10https://bugzilla.wikimedia.org/39828 normal; MediaWiki: General/Unknown; (zedlightman) [06:28:42] 03(mod) Sandbox for MediaWiki-style internal links within Bugzilla comments - 10https://bugzilla.wikimedia.org/39828 +comment (10Timeshifter) [06:42:17] 03(mod) Semantic Maps does not export coordinates in RDF - 10https://bugzilla.wikimedia.org/33504 +comment (10Chris Davis) [06:51:15] 03(mod) Sandbox for MediaWiki-style internal links within Bugzilla comments - 10https://bugzilla.wikimedia.org/39828 +comment (10Timeshifter) [06:53:53] Change merged: Freakolowsky; [mediawiki/extensions/ConventionExtension] (master) - https://gerrit.wikimedia.org/r/22028 [07:05:12] 03(NEW) Language Selection does not work while using Language Code, Enter - 10https://bugzilla.wikimedia.org/39829 normal; MediaWiki extensions: UniversalLanguageSelector; (srik.lak) [07:05:26] Reedy: can you help me to understand something in mw api? [07:17:58] 14(INVALID) Sandbox for MediaWiki-style internal links within Bugzilla comments - 10https://bugzilla.wikimedia.org/39828 +comment (10Nemo_bis) [07:22:51] New patchset: Siebrand; "More Babel extension maintenance" [mediawiki/extensions/Babel] (master) - https://gerrit.wikimedia.org/r/22025 [07:23:05] New review: Siebrand; "Next PS fixes comments. Thanks for the review, Robin." [mediawiki/extensions/Babel] (master) - https://gerrit.wikimedia.org/r/22025 [07:27:18] New review: Siebrand; "Thanks for the review, Brion." [mediawiki/extensions/Math] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/22156 [07:28:58] 03(NEW) Insufficient param validation - 10https://bugzilla.wikimedia.org/39830 normal; MediaWiki: API; (niklas.laxstrom) [07:28:59] 03(mod) Make invalid type parameter in ApiFeedLQTThreads fail more gracefully - 10https://bugzilla.wikimedia.org/22510 (10Niklas Laxström) [07:31:52] hi I need someone who understand git [07:32:01] I was told in #git that I am missing some hook [07:32:13] I can't commit to mediawiki-config [07:32:17] (push) [07:37:26] 03(mod) Attempt to get the latitude of an invalid location - 10https://bugzilla.wikimedia.org/38632 +comment (10Siebrand) [07:39:17] New patchset: Tobias Gritschacher; "introduced a base for frontend representing constructors" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21840 [07:43:09] ok nvm [07:46:37] New patchset: Tobias Gritschacher; "introduced a base for frontend representing constructors" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21840 [07:57:17] Hi everybody! Is it possible to use the Http class (includes/HttpFunctions.php) to upload files to a remote destination? I already browsed through the code but didn't find any hint. I need this fnctionality within an MediaWiki extension. Would you suggest to extend the MWHttpRequest class or better use some WebClient implementation available from the web? [07:58:30] 03(NEW) Ghost page 'Semantic Forms permissions test' - 10https://bugzilla.wikimedia.org/39831 normal; MediaWiki extensions: SemanticForms; (ad.strackvanschijndel) [08:06:18] 03(mod) Ghost page 'Semantic Forms permissions test' - 10https://bugzilla.wikimedia.org/39831 +comment (10Ad Strack van Schijndel) [08:29:43] 03(mod) Password data leakage when using external authentication - 10https://bugzilla.wikimedia.org/39184 +comment (10Antoine "hashar" Musso) [08:31:04] New patchset: Nikerabbit; "Update to new wiki paths" [translatewiki] (master) - https://gerrit.wikimedia.org/r/22173 [08:32:02] Heiya, could somebody update the release notes on gerrit for 1.18.5 and 1.19.2? Would be cool. [08:38:06] Anybody here? [08:55:55] !gfi is https://www.mediawiki.org/wiki/User:Petrb/Git_for_idiots [08:55:56] Key was added [09:07:27] 03(mod) placeholder text color in search bar in Firefox 15 is black instead of gray - 10https://bugzilla.wikimedia.org/39793 +comment (10Fomafix) [09:07:29] Change merged: Siebrand; [translatewiki] (master) - https://gerrit.wikimedia.org/r/22173 [09:19:16] 03(NEW) Cancel / Apply button on Display settings - 10https://bugzilla.wikimedia.org/39832 normal; MediaWiki extensions: UniversalLanguageSelector; (srik.lak) [09:30:48] 03(mod) placeholder text color in search bar in Firefox 15 is black instead of gray - 10https://bugzilla.wikimedia.org/39793 +comment (10Michael M.) [09:37:12] hm... when i clone ssh://daniel@gerrit.wikimedia.org:29418/mediawiki/extensions.git i get a bunch of empty directories [09:37:16] how do i get all the extensions? [09:40:10] after review -d #####, how can I pull from that branch in case someone else added a patchset? Why doesn't Gerrit warn me if someone else has commited to that patch-set in the meantime? I just overwrite their changes without even noticing it... [09:43:35] DanielW_WMDE: just do review -d ##### again to get the latest version [09:44:09] as to overwriting... yea, i guess that can happen if multiple people work on the same change [09:44:12] DanielK_away: are you sure? I think when I do that, it just says there is a branch already, switch to that one and won't pull again.... I have to delete the branch first, then it works [09:44:15] i'd try to avoid that :) [09:44:26] DanielW_WMDE: works for me [09:44:54] to answer my own question about extensions: [09:45:21] cd extensions; git submodule init; git submodule update [09:51:07] New patchset: Jens Ohlig; "Special:ItemDisambiguation language autocompletion" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22009 [09:53:09] New review: Daniel Kinzler; "self-approving for merge into dev branch" [mediawiki/core] (Wikidata); V: 0 C: 2; - https://gerrit.wikimedia.org/r/21898 [09:53:09] Change merged: Daniel Kinzler; [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21898 [09:54:05] New review: Daniel Kinzler; "self-approve for merge into dev branch" [mediawiki/core] (Wikidata); V: 1 C: 2; - https://gerrit.wikimedia.org/r/22013 [09:54:08] Change merged: Daniel Kinzler; [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/22013 [09:55:43] New review: Daniel Kinzler; "@Liangent you -1 a change because of a trailing newline?..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/22049 [09:57:39] New review: Liangent; "@Daniel Kinzler: Roan said I should do this..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/22049 [09:57:45] Change merged: Nikerabbit; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/22046 [10:00:39] New review: John Erling Blad; "Passes present phpunittests and seleniumtests." [mediawiki/extensions/Wikibase] (master); V: 1 C: 0; - https://gerrit.wikimedia.org/r/20679 [10:01:39] New review: Daniel Kinzler; "@demon: grep doesn't find any reference to userWasLastToEdit in any extension in git. feel like merg..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/22049 [10:02:48] 03(mod) WikiBook page/chapter configuration tools/API not working on Mac - 10https://bugzilla.wikimedia.org/39827 (10Sam Reed (reedy)) [10:09:03] Reedy: no more connection issues? [10:12:57] New patchset: Daniel Werner; "introduced a base for frontend representing constructors" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21840 [10:13:23] 04(REOPENED) "You cannot post a blank message" error on every summary edit - 10https://bugzilla.wikimedia.org/39773 +comment (10Nemo_bis) [10:17:21] 03(UNCONFIRMED) html tags in the block log entry at Special:CentralAuth for all languages except English - 10https://bugzilla.wikimedia.org/35411 +testme; +comment (10Nemo_bis) [10:19:14] 03(NEW) Language Code search on ULS is case sensitive - 10https://bugzilla.wikimedia.org/39833 normal; MediaWiki extensions: UniversalLanguageSelector; (srik.lak) [10:22:18] New patchset: Pginer; "Fix to allow using the ULS when it is bigger than the viewport" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/22174 [10:22:29] 03(NEW) Special:Block shows HTML entity in blockip-legend - 10https://bugzilla.wikimedia.org/39834 normal; MediaWiki: User blocking; (federicoleva) [10:23:03] 03(FIXED) Special:Block shows HTML entity in blockip-legend - 10https://bugzilla.wikimedia.org/39834 (10Nemo_bis) [10:23:46] 03(mod) Special:Block shows HTML entity in blockip-legend - 10https://bugzilla.wikimedia.org/39834 (10Nemo_bis) [10:23:59] 04(REOPENED) Add India to the monuments database - 10https://bugzilla.wikimedia.org/38323 +comment (10Effeietsanders) [10:25:00] 03(mod) Add South Africa to the monuments database - 10https://bugzilla.wikimedia.org/38330 +comment (10Effeietsanders) [10:25:16] 03(mod) Add South Africa to the monuments database - 10https://bugzilla.wikimedia.org/38330 (10Effeietsanders) [10:28:11] 03(mod) Cannot move ULS pop-up around - 10https://bugzilla.wikimedia.org/39414 +comment (10Pau Giner) [10:28:17] 03(mod) Rollback after on restore - 10https://bugzilla.wikimedia.org/39804 (10jeblad) [10:31:12] New patchset: Santhosh; "I18n#1473: Use preferred language for anonymous users" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/22034 [10:31:44] Change merged: Santhosh; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/22034 [10:35:27] 03(NEW) Remove "�" from link trail in Ukrainian Wikipedia - 10https://bugzilla.wikimedia.org/39835 normal; Wikimedia: Site configuration; (Pustomytnyk) [10:38:29] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21840 [10:40:34] 03(mod) Remove "�" from link trail in Ukrainian Wikipedia - 10https://bugzilla.wikimedia.org/39835 +comment (10Liangent) [10:41:52] New patchset: Nikerabbit; "Provide list of all ISO 639 languages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/11829 [10:49:47] New patchset: Tobias Gritschacher; "selenium tests for undelete" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22175 [10:49:56] Change merged: Nikerabbit; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/22044 [10:50:54] New patchset: Daniel Werner; "Special:ItemDisambiguation language autocompletion" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22009 [10:54:29] Hello everyone ;) [10:55:51] New patchset: John Erling Blad; "(Bug 37685) Initial commit for checking edit conflicts" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20679 [10:58:02] One person be available to help me on the use of infobox ? [11:03:10] Change merged: Santhosh; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/22174 [11:05:15] New review: Daniel Werner; "I just noticed that you use the list of sites here, not the list of languages to fill the drop-down ..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/22009 [11:15:57] New review: Dereckson; "Thank you for this X-Frame-Options idea." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/20472 [11:19:12] hello. do we have any rules/guidelines related to removing/deprecating CSS classes? i'd like to clean up the mess that .mw-ajax-loader is [11:28:02] 03(mod) Files with future visibility date - 10https://bugzilla.wikimedia.org/39798 +comment (10Strainu) [11:32:00] New patchset: Ori.livneh; "Re-architect PEF ahead of redeployment" [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/22177 [11:37:56] New patchset: Tobias Gritschacher; "selenium tests for undelete" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22175 [11:42:12] New patchset: Tobias Gritschacher; "Fixed bug where aliases would be broader than grid layout" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22153 [11:42:32] 03(mod) Tracking Wikimedia Commons new feature requests - 10https://bugzilla.wikimedia.org/37883 (10Dereckson) [11:42:33] 03(mod) Image rotation issues (tracking) - 10https://bugzilla.wikimedia.org/31504 (10Dereckson) [11:43:22] 03(mod) Files with future visibility date - 10https://bugzilla.wikimedia.org/39798 (10Dereckson) [11:43:23] 03(mod) Tracking Wikimedia Commons new feature requests - 10https://bugzilla.wikimedia.org/37883 (10Dereckson) [11:54:23] 03(mod) Files with future visibility date - 10https://bugzilla.wikimedia.org/39798 (10Nemo_bis) [11:56:21] whoops. i just did what i though would be a simple rebase, and now git is spewing hundreds of lines of output [11:56:53] 03(mod) Bug and feature requests related to Wikimedia Commons (tracking) - 10https://bugzilla.wikimedia.org/37883 summary; +comment (10Nemo_bis) [11:57:40] 03(mod) Ghost page 'Semantic Forms permissions test' - 10https://bugzilla.wikimedia.org/39831 +comment (10Yaron Koren) [11:57:47] MatmaRex hey [11:57:59] hi petan [11:58:08] you got my messages yesterday? [11:58:26] yesterday you asked something regarding OSB, keep in mind that I know nothing about CSS and JS, so if there is anything you would like to change, feel free to do that [11:58:32] all JS was written by Brion Vibber [11:58:37] not me [11:58:52] okay. then one question [11:59:17] do you guys really need the status bar to be displayed where it is displayed? [11:59:32] IMO this isnt the best place, and there are two that could be better: [11:59:42] 1. just floated to the side, like the boxes from FlaggedRevs [11:59:50] no, if there is a better place, go ahead and fix it [11:59:57] 2. integrated somewhere in the UI, like the wikilove icon on enwiki [12:00:26] the reason is that it was simplest for me to place it here, I don't know CSS to make a better position [12:00:48] yeah, but i'm not talking implementation now, but design ;) [12:00:53] (but i'm no designer) [12:00:58] in fact, i think that the best place would be in the first heading [12:01:05] just after the page title [12:01:07] btw the OSB is now deployed to beta site, en.wikipedia.beta.wmflabs.org/wiki/ feel free to test it there [12:01:12] just the icon and shor text [12:01:21] e.g. "User: Matma Rex (* online)" [12:01:21] ok [12:01:29] oh, cool, i'll look [12:02:50] but it seems not to work properly as many other stuff there [12:03:27] i've been playing with it on my own testwiki [12:03:36] (sent you the link on priv) [12:03:58] feel free to make an account and poke around [12:04:34] i'll try to implement what i've suggested in a couple minutes :) [12:05:34] New patchset: Daniel Werner; "Fixed bug where aliases would be broader than grid layout" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22153 [12:09:03] New patchset: Matmarex; "rewrite and deprecate two ajax throbber related CSS classes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22178 [12:09:29] New patchset: Jens Ohlig; "Special:ItemDisambiguation language autocompletion" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22009 [12:09:32] New patchset: Daniel Werner; "Fixed bug where aliases would be broader than grid layout" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22153 [12:12:58] New patchset: Jens Ohlig; "Special:ItemDisambiguation language autocompletion" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22009 [12:16:21] New patchset: Daniel Kinzler; "(Bug 37685) Initial commit for checking edit conflicts" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20679 [12:18:53] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22153 [12:20:06] 03(mod) Inconsistent state within the internal storage backends - 10https://bugzilla.wikimedia.org/39221 +comment (10Yann Forget) [12:33:49] New patchset: Hashar; "Use hasSubjectNamespace in Skin.php instead of namespace tests." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22114 [12:34:05] New review: Hashar; "Rebased to mark the dependency." [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/22114 [12:37:00] hi, it looks like mediawiki-1.19.2 has not been tagged in the git repository. Can anyone please check that? [12:38:52] New review: John Erling Blad; "I would really like to see this or something similar merged!" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/20472 [12:41:01] New review: Dereckson; "Yes, I agree, it will be an useful addition." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/20472 [12:48:49] ao2: it will take some time before SF wakes up [12:48:54] I already complained [12:50:50] Nikerabbit, that's fine, thanks. Just wanted to check that people are aware of the issue. fetch+checkout is so handy to update the code. [12:56:31] New patchset: Matthias Mullie; "Bug 39818 - Prevent self-moderation of ArticleFeedback posts" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/22179 [13:04:48] 03(mod) SMW::updateDatasmw_atts2 error - 10https://bugzilla.wikimedia.org/35375 +comment (10Bernhard Zelazny) [13:05:35] New patchset: Matthias Mullie; "Bug 39818 - Prevent self-moderation of ArticleFeedback posts" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/22179 [13:10:00] im running mediawiki 1.16.5, will there be any issues upgrading to 1.19.2? [13:11:36] Moodles: i think recently someone here upgraded from 1.4 to 1.19 [13:11:46] you'll probably be fine, but do make a backup [13:11:50] (also, i'm no developer) [13:12:03] (and i wont be able to help if it breaks) :) [13:12:38] 03(mod) Prevent self-moderation of ArticleFeedback posts - 10https://bugzilla.wikimedia.org/39818 +comment (10Matthias Mullie) [13:13:01] New patchset: Matmarex; "replace the status bar with an icon to be less problem-prone and neater" [mediawiki/extensions/OnlineStatusBar] (master) - https://gerrit.wikimedia.org/r/22180 [13:14:58] New review: Matmarex; "You can see this change live at http://users.v-lo.krakow.pl/~matmarex/testwiki/index.php?title=User:..." [mediawiki/extensions/OnlineStatusBar] (master) C: 0; - https://gerrit.wikimedia.org/r/22180 [13:15:46] Change merged: IAlex; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21188 [13:15:52] New patchset: Daniel Werner; "Simple speed optimization of input auto expansion (2)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22181 [13:22:32] Change abandoned: Daniel Werner; "See I48441746 which cleans up the mess Gerrit created here." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22131 [13:23:02] New patchset: Matmarex; "(bug 37132) replace the status bar with an icon to be nicer and neater" [mediawiki/extensions/OnlineStatusBar] (master) - https://gerrit.wikimedia.org/r/22180 [13:23:22] 03(mod) OnlineStatusBar indicator should not use absolute positioning. - 10https://bugzilla.wikimedia.org/37132 +comment (10Bartosz Dziewoński) [13:23:54] New review: Daniel Werner; "Tobi already wanted to merge I9e493f0d but went home, so I do the same in this clean copy of that b..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/22181 [13:23:54] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22181 [13:24:01] New review: Jens Ohlig; "Looking good." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/22175 [13:24:01] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22175 [13:32:28] New review: Daniel Kinzler; "seems to do what i should" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/20679 [13:32:29] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20679 [13:38:35] " PHP Fatal error: Class 'WebInstaller' not found in /srv/fteqw/www/htdocs/wiki/mw-config/index.php on line 23" [13:39:00] Change merged: Demon; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/17107 [13:40:18] Change merged: Demon; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22125 [13:40:59] hmm i think mv didn't overwrite it [13:41:54] 03(mod) detect edit conflicts on entities (13) - 10https://bugzilla.wikimedia.org/37685 (10jeblad) [13:42:10] Change merged: Demon; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22155 [13:42:56] New patchset: Nikerabbit; "Fix nbwWarn" [translatewiki] (master) - https://gerrit.wikimedia.org/r/22182 [13:44:18] yep my fault, mv doesn't recurse [13:47:18] New patchset: CSteipp; "(bug 38333) Check global blocks on account create" [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/22183 [13:47:19] New patchset: CSteipp; "(bug 37587) Enforce language codes to be html safe" [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/22184 [13:47:19] New patchset: CSteipp; "(bug 39180) Set x-frame-options='DENY' for api" [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/22185 [13:47:19] New patchset: CSteipp; "(bug 39184) LDAP password leakage" [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/22186 [13:47:20] New patchset: CSteipp; "(bug 35839) Check permisions for revdel blocks" [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/22187 [13:47:20] New patchset: CSteipp; "(Bug 39700) Fix for html injection" [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/22188 [13:49:48] 03(NEW) Patching after edit conflicts - 10https://bugzilla.wikimedia.org/39836 normal; MediaWiki extensions: WikidataRepo; (jeblad) [13:49:52] 03(NEW) Notice of pics doesen't show up - 10https://bugzilla.wikimedia.org/39837 normal; Wikimedia: Media storage; (augustiny.s) [13:54:33] New patchset: Jens Ohlig; "Special:ItemDisambiguation language autocompletion" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22009 [13:56:00] New patchset: Jens Ohlig; "Special:ItemDisambiguation language autocompletion" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22009 [13:56:16] 03(mod) Add Javanese font to WebFonts - 10https://bugzilla.wikimedia.org/39381 +comment (10bennylin) [13:57:31] 03(NEW) Jenkins: remove fingerprinting from mw extension job - 10https://bugzilla.wikimedia.org/39838 normal; Wikimedia: Testing Infrastructure; (hashar) [14:01:37] marktraceur: ping? [14:02:11] 03(mod) Create the My best KB layout for Gurumukhi Punjabi in Narayam - 10https://bugzilla.wikimedia.org/39218 +comment (10Shiju Alex) [14:02:32] New patchset: CSteipp; "(bug 38333) Check global blocks on account create" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22189 [14:02:33] New patchset: CSteipp; "(bug 37587) Enforce language codes to be html safe" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22190 [14:02:33] New patchset: CSteipp; "(bug 39180) Set x-frame-options='DENY' for api" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22191 [14:02:34] New patchset: CSteipp; "(bug 39184) LDAP password leakage" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22192 [14:02:34] New patchset: CSteipp; "(bug 35839) Hidden block text leaking to admins" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22193 [14:02:35] New patchset: CSteipp; "(bug 39700) Fix for html injection" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22194 [14:02:42] yeahhh [14:03:29] csteipp: what time is it in SF ? :-D [14:03:31] 03(mod) Inconsistent state within the internal storage backends - 10https://bugzilla.wikimedia.org/39221 +comment (10Yann Forget) [14:03:43] hasher: 7am [14:03:54] csteipp: don't forget you breakfast! :-))) [14:04:19] hm. who is the go-to CSS guru here? :) i'd like some help on this: https://gerrit.wikimedia.org/r/#/c/22178/ [14:04:42] Done! (thanks to my "alarm clock" baby at 6am this morning...) [14:05:07] csteipp: yeah got the same system at home :-D works pretty well [14:05:23] Nikerabbit: chris has sent the patch for the mw security releases \O/ [14:05:28] out for fresh air [14:05:38] New patchset: Daniel Kinzler; "fix html in item diff table" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22195 [14:06:12] csteipp: a friend was lookig forward to getting that "alarm clock" as nothing is able to wake him up in the morning ... the fail of the story is, his kid is a sleeper and doesn't wake up at night ... at all :S [14:06:45] freakolowsky: haha! I wouldn't mind that right now.... [14:07:38] haha, freakolowsky, he was lucky after all [14:07:52] those are hard to configure at the right hours [14:08:45] 03(mod) Add Javanese font to WebFonts - 10https://bugzilla.wikimedia.org/39381 +comment (10bennylin) [14:08:47] hello! so I just read the channel log, and the git repo still lacks the 1.19.2 tag, but what's even more worriying is that I can't find any mention of the LDAP fix in git log. maybe it's not even on master? [14:09:27] i was told i was the same ... slept 24/7 ... the doctor had to slap the crap out of me at birth because i was breathing just wouldn't cry :D [14:09:29] pas__, that would be in LDAP extension log, i guess? [14:10:03] oh. I just compared the RELEASE-NOTES-1.19 from the tarball with the one in REL1_19 [14:10:25] 03(mod) Add Javanese font to WebFonts - 10https://bugzilla.wikimedia.org/39381 +comment (10bennylin) [14:10:40] 03(mod) API: Allow edit conflict detection based on revid - 10https://bugzilla.wikimedia.org/32037 +comment (10Umherirrender) [14:11:39] New patchset: Nikerabbit; "Show translation page source on export tab" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/22197 [14:13:35] 03(mod) Rollback after on restore - 10https://bugzilla.wikimedia.org/39804 (10jeblad) [14:13:46] 03(mod) Rollback after a restore - 10https://bugzilla.wikimedia.org/39804 (10jeblad) [14:15:01] Change merged: Demon; [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/22183 [14:15:28] 03(mod) FileBackend.php has 1 GB limit, despite $wgMaxUploadSize - 10https://bugzilla.wikimedia.org/38719 +comment (10Timothy O'Keefe) [14:15:47] New patchset: Umherirrender; "add moveoverredirect to result of api move" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22198 [14:16:01] 03(mod) FileBackend.php has 1 GB limit, despite $wgMaxUploadSize - 10https://bugzilla.wikimedia.org/38719 (10Timothy O'Keefe) [14:16:23] 03(mod) FileBackend.php has 1 GB limit, despite $wgMaxUploadSize - 10https://bugzilla.wikimedia.org/38719 (10Timothy O'Keefe) [14:16:29] 03(mod) Patching after edit conflicts - 10https://bugzilla.wikimedia.org/39836 (10jeblad) [14:16:47] 03(mod) FileBackend.php has 1 GB limit, despite $wgMaxUploadSize - 10https://bugzilla.wikimedia.org/38719 +comment (10Krenair) [14:18:39] 03(NEW) Faster "userWasaLastToEdit" - 10https://bugzilla.wikimedia.org/39839 normal; MediaWiki extensions: WikidataRepo; (jeblad) [14:18:44] 03(mod) Faster "userWasaLastToEdit" - 10https://bugzilla.wikimedia.org/39839 (10jeblad) [14:18:57] 03(mod) Faster "userWasLastToEdit" - 10https://bugzilla.wikimedia.org/39839 (10jeblad) [14:22:07] 03(mod) Add Javanese font to WebFonts - 10https://bugzilla.wikimedia.org/39381 +comment (10Amir E. Aharoni) [14:27:14] New patchset: John Erling Blad; "(Bug 39839) Add a faster method for "userWasLastToEdit"" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22200 [14:28:01] New patchset: CSteipp; "Update release notes and incremented version" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22201 [14:32:20] New patchset: CSteipp; "Release notes and increment version" [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/22202 [14:35:02] New review: Matthias Mullie; "Although the patchset looks good to me, the code once was like this:" [mediawiki/extensions/Wikibase] (master) C: 0; - https://gerrit.wikimedia.org/r/22195 [14:36:12] New patchset: Hashar; "'usecheckboxes' option implemented for HTMLMultiSelectField." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/8924 [14:36:53] New review: Hashar; "* Wrapped some long lines (including in the commit message)" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/8924 [14:38:02] Change merged: CSteipp; [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/22184 [14:38:05] 03(mod) Insufficient param validation - 10https://bugzilla.wikimedia.org/39830 +comment (10Umherirrender) [14:38:15] omg ... #facepalm deluxe of the day .... client: "could you make this field there pre-filled with the correct word, so users wouldn't have to type it in by themself, as it's sometimes difficult to make out what it says on the image above it" ... pointing at the CAPTCHA [14:38:28] you have my permission to die [14:38:57] my server (a VPS) isn't sending out emails (account confirmations, password reminders etc). what should I do [14:39:31] Change merged: CSteipp; [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/22185 [14:40:01] Change merged: CSteipp; [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/22186 [14:40:25] Change merged: CSteipp; [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/22187 [14:41:12] Change merged: CSteipp; [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/22188 [14:42:14] New patchset: Jens Ohlig; "Autocompletion for Special:ItemByTitle" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22203 [14:42:41] 03(NEW) Search & Replace does not work in Opera - 10https://bugzilla.wikimedia.org/39840 normal; MediaWiki extensions: WikiEditor; (apper) [14:44:02] 03(mod) Create the My best KB layout for Gurumukhi Punjabi in Narayam - 10https://bugzilla.wikimedia.org/39218 +comment (10Srikanth Logic) [14:46:24] New review: John Erling Blad; "The links does not make sense..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/22195 [14:46:50] Change merged: Demon; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/18112 [14:47:29] Change merged: Demon; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20472 [14:47:38] Change merged: Demon; [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/22202 [14:55:34] 03(mod) MediaWiki bugs to be fixed for 1.20wmf10 deployment (tracking) - 10https://bugzilla.wikimedia.org/39515 +tracking (10Sam Reed (reedy)) [14:56:12] 03(NEW) MediaWiki bugs to be fixed for 1.20wmf11 deployment (tracking) - 10https://bugzilla.wikimedia.org/39841 blocker; Wikimedia: General/Unknown; (sam) [14:56:12] 03(mod) Tracking bug (tracking) - 10https://bugzilla.wikimedia.org/2007 (10Sam Reed (reedy)) [14:56:16] 03(mod) MediaWiki bugs to be fixed for wmf deployment (tracking tracker) - 10https://bugzilla.wikimedia.org/38865 (10Sam Reed (reedy)) [14:56:55] New patchset: Siebrand; "Maintenance for TitleBlacklist extension." [mediawiki/extensions/TitleBlacklist] (master) - https://gerrit.wikimedia.org/r/20268 [14:58:22] 03(mod) MediaWiki bugs to be fixed for 1.20wmf11 deployment (tracking) - 10https://bugzilla.wikimedia.org/39841 (10Sam Reed (reedy)) [14:58:35] 03(WONTFIX) Don't highlight trailing whitespace [patch] - 10https://bugzilla.wikimedia.org/39185 +comment (10Chad H.) [14:58:51] New review: Matthias Mullie; "It's the commit sha, Gerrit seems to have misinterpreted is as Change-id." [mediawiki/extensions/Wikibase] (master) C: 1; - https://gerrit.wikimedia.org/r/22195 [14:59:38] 03(mod) Point ku.wikipedia logo to version in Commons - 10https://bugzilla.wikimedia.org/8144 summary (10Waldir) [14:59:46] csteipp|afk: Is my observation that security issues were disclosed (in the 1.18/1.19 patch release announcements) without patches being merged to master correct? [15:04:36] 03(mod) Sandbox for MediaWiki-style internal links within Bugzilla comments - 10https://bugzilla.wikimedia.org/39828 +comment (10Timeshifter) [15:04:55] so it seems, siebrand :( [15:05:38] New review: John Erling Blad; "Seems so.. One of many.. ;/" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/22195 [15:07:19] New patchset: MarkAHershberger; "Bug 35623 - createAndPromote.php: Change to allow promotion only" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22157 [15:08:06] 03(NEW) WMF logo in wikimedia.org should be moved to the footer - 10https://bugzilla.wikimedia.org/39842 normal; Wikimedia: General/Unknown; (waldir) [15:08:31] 03(mod) "thumb" should be preselected as format in the dialog to insert an image - 10https://bugzilla.wikimedia.org/38827 +comment (10kipod) [15:09:11] hm. who is the go-to CSS guru here? :) i'd like some help on this: https://gerrit.wikimedia.org/r/#/c/22178/ [15:10:14] New review: MarkAHershberger; "Thanks for your comments! I think I've got them all + the comment that MZ left on the bug. Also ad..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22157 [15:10:48] I've got a user getting the "You have made too many recent login attempts..." message. He's learned the error of his ways, but how do I clear the message? He's been getting it since yesterday. [15:12:15] 03(mod) Sandbox for MediaWiki-style internal links within Bugzilla comments - 10https://bugzilla.wikimedia.org/39828 +comment (10Timeshifter) [15:14:26] Change merged: Nikerabbit; [mediawiki/extensions/Babel] (master) - https://gerrit.wikimedia.org/r/22025 [15:20:47] New patchset: Hashar; "'usecheckboxes' option implemented for HTMLMultiSelectField." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/8924 [15:21:25] New review: Hashar; "Added more tests, please review carefully and eventually add more :-)" [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/8924 [15:24:05] 14(DUP) Enable possibility to retrieve forgotten usernames - 10https://bugzilla.wikimedia.org/36656 +comment (10Umherirrender) [15:24:07] 03(mod) Enable e-mailing password based on e-mail address on Wikimedia wikis - 10https://bugzilla.wikimedia.org/34386 +comment (10Umherirrender) [15:32:20] 03(mod) Monospace font setting overridden - 10https://bugzilla.wikimedia.org/39560 +comment (10Mormegil) [15:33:02] New review: Hashar; "I would keep the ajax-loader.gif and spinner.gif files for back compatibility with third party exte..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/22178 [15:33:19] MatmaRex: hey, thanks for that OSB patchset. Added Krinkle|detached as a reviewer since he was one of the people reviewing OSB to get it to a deployable state. [15:33:49] (If I were more like Oscar Wilde I would make some inaccessible and irrelevant joke about a "deplorable state") [15:34:25] hi sumanah, thanks [15:34:34] Reedy: SubpageSortkey, waiting for you to move it to https://www.mediawiki.org/wiki/Deployment_queue :) [15:35:58] sumanah: I've still got 200 new emails in my WMF inbox ;) [15:36:29] k [15:37:29] New patchset: Platonides; "Hungary can't finally participate :(" [mediawiki/extensions/WikiLovesMonuments] (master) - https://gerrit.wikimedia.org/r/22204 [15:37:32] Change merged: Platonides; [mediawiki/extensions/WikiLovesMonuments] (master) - https://gerrit.wikimedia.org/r/22204 [15:39:05] New review: Parent5446; "Replied to previous inline comment and added one more. Going to add +1 since my comments are pretty ..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/22157 [15:40:02] New review: Hashar; "Please abandon this change. I guess you will be added when Wikidata branch is merged ;-)" [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/15695 [15:41:00] New review: Hashar; "Thanks for working on this :-)" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/17519 [15:43:43] hi hashar, how are you? [15:44:52] New review: John Erling Blad; "It must have been the WikiDaemon, also called "Git"!" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/22195 [15:44:52] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22195 [15:46:29] 03(mod) Don't highlight trailing whitespace [patch] - 10https://bugzilla.wikimedia.org/39185 +comment (10Aaron Schulz) [15:51:59] guillom: Hi, sorry, was sleeping, what's up? [15:52:17] 03(NEW) Set up SemanticForms on AcaWiki - 10https://bugzilla.wikimedia.org/39843 normal; Wikimedia: AcaWiki; (jodi.a.schneider) [15:53:05] marktraceur: np, thanks for the pong. I was wondering if you'd be kind enough to run your script to get the number of unique committers for August (and also for July, if it's not too much trouble) (for the monthly engineering reports) [15:53:07] New patchset: Platonides; "Provide $wgPiwikCustomJS for adding custom orders to the Piwik javascript. This is the same variable used by Piwik Integration extension." [mediawiki/extensions/WikiLovesMonuments] (master) - https://gerrit.wikimedia.org/r/22207 [15:53:10] Change merged: Platonides; [mediawiki/extensions/WikiLovesMonuments] (master) - https://gerrit.wikimedia.org/r/22207 [15:54:53] New patchset: Matmarex; "rewrite and deprecate two ajax throbber related CSS classes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22178 [15:54:56] New patchset: Hashar; "test: unwanted search namespace should not be there" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/10432 [15:55:33] New review: Matmarex; "Removed file renames from the changeset for now." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/22178 [15:55:52] New review: Hashar; "* enhanced commit message a bit" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/10432 [15:56:03] New patchset: Umherirrender; "Allow array condition for HAVING in database inferface" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22208 [15:56:51] Ooh, yes. I would. But I put it on my work laptop and have decided to work from home. [15:57:04] guillom: Let me get it from the email thread, should be there [15:57:27] marktraceur: yes, you're talking about http://www.gossamer-threads.com/lists/wiki/wikitech/283396#283396 ? [15:57:54] I believe so [15:58:17] Thank you for having released it; In the future I'll try to do it myself, but I don't have that "sane SSH setup" yet, so I thought I'd trouble you just this once. [15:59:32] Nor, sadly, do I [16:00:47] New patchset: Hashar; "test: unwanted search namespace should not be there" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/10432 [16:00:55] New review: Hashar; "rebased" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/10432 [16:01:02] marktraceur: I understand. I'll try to get it to work, then. Thanks anyway :) [16:01:51] guillom: No, I got it [16:01:58] guillom: 97 in August [16:02:35] marktraceur: Great! Thank you :) [16:03:11] And 92 in July [16:03:41] guillom: And apparently the limit on results was lifted, because I get some thousand or more results in one query [16:03:55] ok [16:04:00] I mean, the script is still good for counting unique contributions, but even so [16:04:04] Awesome, thank you for the numbers! [16:04:43] Change merged: Hashar; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/10432 [16:05:19] I guess that means we've reached somewhat of a plateau, though....92 was the same as June, and 97 is not much of a bump [16:06:23] guillom: marktraceur: I am pretty sure the analytic team could add a monthly count in their Kraken system [16:07:14] probably [16:09:11] 03(mod) Don't highlight trailing whitespace [patch] - 10https://bugzilla.wikimedia.org/39185 +comment (10Chad H.) [16:13:54] marktraceur: well, I can speculate a little on that [16:14:06] marktraceur: (a) summer vacation [16:14:53] (b) In the last couple of months I've been concentrating more on nurturing low-frequency current contributors than on reaching out to new ones [16:16:49] and there might also be kinds of contributors we are nurturing who are not showing up *in Gerrit* for various reasons [16:17:01] bug reporters, Gadget makers, bot authors, documenters [16:17:35] I don't think Git/Gerrit has gotten *harder to use* or *harder to learn* since May, so I don't think that's a cause for the slower growth you see [16:17:58] New patchset: Hashar; "(bug 38451) remove $wgAllowPageInfo" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/16235 [16:18:35] marktraceur: but also I do want us to think in terms of sustainable growth and not metastasizing :-) so if there is actually somewhat slowed growth in new code committers, that might be ok if it means that the committers are learning, getting better, teaching each other, & providing a wide, strong foundation for the community [16:18:37] New patchset: MarkAHershberger; "Bug 35623 - createAndPromote.php: Change to allow promotion only" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22157 [16:18:41] New review: Hashar; "rephrased commit message" [mediawiki/core] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/16235 [16:18:41] Change merged: Hashar; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/16235 [16:19:33] 03(mod) Edit tokens shown in frames using api - 10https://bugzilla.wikimedia.org/39180 +comment (10Bawolff) [16:21:53] 03(FIXED) WikiEditor toc module: textarea not hidden on ProofreadPage pages - 10https://bugzilla.wikimedia.org/26303 +comment (10Tpt) [16:27:16] New patchset: jan; "Create dir "api" for Api modules." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/22209 [16:27:34] sumanah: And so it would seem :) [16:27:54] I sure hope our growth is sustainable! [16:28:12] And speculation v2.0 might be "Sumana was on vacation" :) [16:28:36] sumanah: I mean, it seems like people are learning and getting better, which is awesome [16:28:36] marktraceur: :) so, the "summer vacation" hypothesis covers me and volunteers [16:28:38] yes! [16:28:41] Change abandoned: Jeroen De Dauw; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/15695 [16:28:44] *nod* true dat [16:29:08] New review: Hashar; "There are are similar issues with 'desc-query' and 'title' which also use empty(). Cant we use somet..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21897 [16:30:04] * yuvipanda considers porting https://www.mediawiki.org/wiki/Template:ApiEx to Lua [16:30:23] * yuvipanda heads to Lua docs [16:30:50] yuvipanda: cool [16:30:52] Change merged: Siebrand; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/22209 [16:35:23] New patchset: GWicke; "Start to hook up a simplistic tokenizer" [mediawiki/extensions/Parsoid] (master) - https://gerrit.wikimedia.org/r/22154 [16:36:25] 03(mod) Tap area for checkbox on incomplete uploads too small - 10https://bugzilla.wikimedia.org/39806 summary (10Phil Chang) [16:37:48] Change merged: Siebrand; [translatewiki] (master) - https://gerrit.wikimedia.org/r/22182 [16:38:13] shoudnt wikibugs say which product/component the bug belongs to? [16:39:20] 03(mod) Clicking back after a batch upload (upload progress bar) - 10https://bugzilla.wikimedia.org/39815 +comment (10Phil Chang) [16:39:20] 14(DUP) After uploading saved photos, back button displays upload progress screen - 10https://bugzilla.wikimedia.org/39808 +comment (10Phil Chang) [16:40:53] New review: Hashar; "Well ideally, dont add the patchset history in the commit message :-D Anyway it is good to me but I..." [mediawiki/extensions/TitleBlacklist] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/20268 [16:43:36] 03(mod) run tests using a Mediawiki snapshot instead of a clone - 10https://bugzilla.wikimedia.org/39742 +comment (10Antoine "hashar" Musso) [16:44:12] 03(FIXED) Make translated page source more easily accessible - 10https://bugzilla.wikimedia.org/36825 +comment (10Siebrand) [16:44:16] Change merged: Siebrand; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/22197 [16:45:04] 03(mod) Admin levels getting confused - 10https://bugzilla.wikimedia.org/39774 +comment (10Phil Chang) [16:50:38] 03(mod) Admin levels getting confused - 10https://bugzilla.wikimedia.org/39774 +comment (10Phil Chang) [16:53:46] 03(mod) Bugs affecting translatewiki.net (errors from MediaWiki master) (tracking) - 10https://bugzilla.wikimedia.org/39480 (10Siebrand) [16:53:48] 03(NEW) Insufficient URL parameter validation causes exception - 10https://bugzilla.wikimedia.org/39844 normal; MediaWiki extensions: Semantic MediaWiki; (s.mazeland) [16:54:08] 03(mod) Insufficient URL parameter validation causes exception - 10https://bugzilla.wikimedia.org/39844 (10Siebrand) [16:56:31] is Gerrit down for anyone else? [16:56:41] (am I in the middle of a maintenance window?) [16:56:43] sumanah: Negative [16:56:50] never mind [16:56:53] weird hiccup [16:57:04] http://www.downforeveryoneorjustme.com/gerrit.wikimedia.org [16:57:37] marktraceur: indeed, even as I typed, I knew I should have checked dfeojm [16:59:21] I do love that site [16:59:52] I guess the next logical step is "lmdfeojmtfy.com" [17:03:00] New review: Siebrand; "Needs approval from Asher." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/17912 [17:03:23] New patchset: Nikerabbit; "One more path fix" [translatewiki] (master) - https://gerrit.wikimedia.org/r/22210 [17:06:14] New patchset: GWicke; "Start to hook up a simplistic tokenizer" [mediawiki/extensions/Parsoid] (master) - https://gerrit.wikimedia.org/r/22154 [17:06:53] 03(NEW) Hard coded brackets in includes/specials/SpecialListusers.php - 10https://bugzilla.wikimedia.org/39845 normal; MediaWiki: Internationalization; (s.mazeland) [17:08:25] csteipp: thanks [17:08:41] you're welcome! [17:09:32] 03(NEW) Hard coded brackets in includes/specials/SpecialActiveusers.php - 10https://bugzilla.wikimedia.org/39846 normal; MediaWiki: Internationalization; (s.mazeland) [17:14:01] Change merged: Siebrand; [translatewiki] (master) - https://gerrit.wikimedia.org/r/22210 [17:20:15] Is there a list of font styles that are available with MediaWiki software somewhere ? [17:20:29] Oooh, good question [17:20:37] ty [17:20:43] Mlpearc: Did you want to include one in a custom CSS file, or....? [17:20:43] I think [17:21:07] Mlpearc: font for what? svg rendering? [17:21:09] no just wanted to see a list of available ones [17:21:18] i think there was a list of them somewhere [17:21:19] hi Raymond_ , got a moment? [17:21:26] for a Ombox template [17:21:29] Mlpearc: My guess is that, depending on how you want to use it, the list may be different [17:21:55] http://www.everythingfoodanddrink.org/w/index.php?title=MediaWiki:Globalblocking-block-errors&action=submit [17:22:20] New patchset: Aaron Schulz; "[FileBackend] Clear swift connection on invalid HTTP responses." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22211 [17:22:21] change from italic to something else [17:23:25] Mlpearc: ... i dont understand. [17:23:54] OK thanx [17:25:34] New patchset: SPQRobin; "Add @since to new variables, fix variable name" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22212 [17:26:09] sumanah: sure [17:26:32] Raymond_: so, I requested a review from you in Gerrit [17:26:47] Raymond_: no obligation of course :) [17:27:39] Raymond_: but I just wanted to check with you about whether it's ok to request code reviews from you :) [17:27:56] sumanah: I see. will review it after diner (which is in a few minutes) [17:28:16] Thanks! [17:28:17] sumanah: yes, absolutly. whenever I can help I will help with review [17:28:36] Raymond_: :-) if you ever want to find stuff to help out with, you can search for i18n-related stuff with "message:" [17:29:07] Raymond_: like https://gerrit.wikimedia.org/r/#/q/status:open+message:i18n,n,z or https://gerrit.wikimedia.org/r/#/q/status:open+message:language,n,z [17:29:22] sumanah: oh yes. I read your post on wikitech-l. this search method was new to me [17:29:43] or better: this keyword for searching [17:30:29] Glad to be of service! You might also be interested in commenting on http://mw-watchlist.tumblr.com/ regarding watchlist improvements [17:31:33] sumanah: brb. and greetings from Elya/Elke :) [17:31:54] :) [17:39:38] 14(INVALID) [ReplaceText] Incorrect error: You must select at least one namespace. - 10https://bugzilla.wikimedia.org/38170 +comment (10Yaron Koren) [17:41:30] New review: MarkTraceur; "A few things I noted, and am no longer worried about reporting because I've been empowered by actual..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/8924 [17:41:48] New patchset: Jeroen De Dauw; "Fixed order of args in method call" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22213 [17:45:45] 03(mod) Admin levels getting confused - 10https://bugzilla.wikimedia.org/39774 +comment (10Jon) [17:49:07] Hello there! The .sig file for mediawiki-1.19.2.tar.gz has the same size of it. There's something wrong, isn't it? [17:50:11] They are in downloads.wikimedia.org/mediawiki/1.19/ [17:50:52] marktraceur: reviewer docs! empowering! maybe you should leave a note in the reviewer docs like you're a movie reviewer. "Four stars! Empowering! A laugh-a-minute thrillride, says Mark Holmquist of _Rolling Stone_!" [17:51:13] Change abandoned: Umherirrender; "No indexed (fast) database query possible, need another solution." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21417 [17:52:06] hi gustavo_cm - csteipp is the person you want to alert about that [17:52:48] sumanah: thank you :-) [17:52:59] Hi gustavo_com: does the signature not verify? [17:53:19] sumanah: Possibly something more like "Most of us dream that one day, we'll write an article like this one. I laughed, I cried, I really felt for the characters. I will never look at code review the same again. You can't truly understand the horror, but this article will get you close." [17:53:53] marktraceur: :) btw did I ever foist https://www.mediawiki.org/wiki/User:Sumanah/Launchpad-dev-process on you? [17:54:16] * marktraceur drops everything and follows all the links [17:54:50] csteipp: I didn't verify because I didn't even download it. Now downloads.wikimedia.org/mediawiki/1.19 is not responding, so I can't download it. [17:55:04] Launchpad being the Canonical code hosting service? [17:55:40] Ah yes. [17:55:45] hmm, I can still embed the api in an iframe... [17:55:58] oh wait, maybe my browser is so old it doesn't respect x-frame-options [17:56:16] bawolff: ie6 does not... others should [17:56:21] firefox 3.5 [17:56:35] Ok, now it worked. I will download and test it. I just found weird a .sig to be the same size of the signed. All others in that same directory are much smaller than their signed packages. [17:56:36] Hmmm. I can't remember when ff added that.. [17:56:57] bawolff: Welcome to 2012, how was the trip? :) [17:57:08] marktraceur: scary [17:57:30] All these version numbers are just so high... [17:57:32] For example: [17:57:32] mediawiki-1.19.1.tar.gz 2012-Jun-13 18:23:03 17.1M application/x-gzip [17:57:32] mediawiki-1.19.1.tar.gz.sig 2012-Jun-13 18:46:56 0.1K application/octet-stream [17:57:53] But for 1.19.2 both are 17.4M. [17:57:54] 03(mod) Inconsistent photo upload comments - 10https://bugzilla.wikimedia.org/39807 +comment (10Jon) [17:58:47] announcement: whoever gets https://gerrit.wikimedia.org/r/#/c/18234/ merged before wmf11 is entitled to 20 lines of JavaScript code from me, redeemable anytime, in core, any extension, or as a gadget. [17:58:49] :D [17:59:26] this is enough to fix, like, three small bugs! [17:59:47] MatmaRex: If only I had +2 in core :) [17:59:57] gustavo_cm: ah, yes... I see the issue. We'll have another .sig up in a bit. [18:00:20] csteipp: ok, thank you :-) [18:00:21] (please, nobody give me +2 in core, I don't think I could handle that much power) [18:00:39] marktraceur: is also count if you poke somebody with merge rights hard enough to make them merge it... ;) [18:01:08] Hm [18:01:33] New patchset: Ryan Lane; "Disallow MediaWiki from storing local passwords" [mediawiki/extensions/LdapAuthentication] (master) - https://gerrit.wikimedia.org/r/22214 [18:01:47] Looks like Krinkle|detached is out for now [18:02:02] kaldari might be able to help, but he also appears to be out [18:02:25] New review: Krinkle; "Check out the "jquery.spinner" module in core. It may be easier to deprecate the old one in /common ..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/22178 [18:02:25] ^demon|lunch: how do I push tags to my extension's repo? [18:02:38] it tells my I'm not allowed to create new references [18:02:53] <^demon|lunch> Hmm, should be able to. [18:03:20] I just released a security release of LdapAuth (thanks to mediawiki core ;) ) and need to add a tag [18:03:40] Change merged: Ryan Lane; [mediawiki/extensions/LdapAuthentication] (master) - https://gerrit.wikimedia.org/r/22214 [18:03:41] Change merged: Ryan Lane; [mediawiki/extensions/LdapAuthentication] (master) - https://gerrit.wikimedia.org/r/18197 [18:04:03] <^demon|lunch> Ryan_Lane: Try again [18:04:20] there we go [18:04:20] thanks [18:04:28] <^demon|lunch> Should've granted that ages ago. [18:04:29] 03(mod) Edit tokens shown in frames using api - 10https://bugzilla.wikimedia.org/39180 +comment (10Bawolff) [18:04:31] <^demon|lunch> :) [18:04:32] heh [18:04:46] <^demon|lunch> Owners should of course have Push Annotated Tag on refs/tags/* :p [18:04:58] I'm not used to needing to do security releases [18:05:00] you guys are killing me ;) [18:05:10] MatmaRex: I got kaldari to look at it, give 'er a bit [18:05:19] Er, I guess him [18:05:34] oh. I should also post that to mediawiki-l [18:05:45] * marktraceur tends to refer to inanimate objects like reviews as 'er [18:06:03] Ryan_Lane: https://www.mediawiki.org/wiki/Release_checklist might help you, you can cherrypick useful release TODOs [18:06:04] from it [18:06:29] sumanah: well, it's just an extension release [18:06:33] true [18:06:34] I timed it with the mediawiki release [18:06:44] since I couldn't fix the extension without the fix for mediawiki [18:06:50] multichill: Howdy! How goes the WLM prep? [18:07:11] Ryan_Lane: I'm just talking about, like, places to update mediawiki.org or lists to mail or BZ versions to add and settings files to update and stuff [18:07:17] ah [18:07:17] right [18:07:22] in case some of those apply [18:07:29] nearly all do [18:07:34] I updated all of them at the same time [18:07:47] ah. forgot to up the version on the extension page [18:08:29] 03(FIXED) Overwrite of the copyright owner in campaigns has no effect - 10https://bugzilla.wikimedia.org/30762 +comment (10Mark Holmquist) [18:09:00] now everything is updated :) [18:09:25] yay! [18:09:38] Ryan_Lane: I proclaim it: LDAP day! Happy LDAP day. :-) [18:09:42] heh [18:09:56] well, it has been ages since I actually announced a release of it :) [18:09:59] marktraceur: I was wondering the same thing [18:10:01] Just came in [18:10:12] each year on this day we crown an LDAP king and he must dance in a field [18:10:25] to ensure the health of LDAP for another year [18:10:40] multichill: Well, https://bugzilla.wikimedia.org/show_bug.cgi?id=37144 seems to say it's going well [18:11:01] heh. as if anyone else is going to write ldap code :D [18:11:07] multichill: Three issues, one is in core, one is assigned to JeroenDeDauw (so ping him for more) and one has a fix merged and deployed and I should mark it as resolved [18:11:31] No, never mind [18:11:33] It's not merged [18:11:38] Well, a patch, anyway [18:12:13] New patchset: MarkTraceur; "(bug 32247) Add "remove file" in the details step" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/9549 [18:12:39] New patchset: Umherirrender; "Allow array condition for HAVING in database interface" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22208 [18:13:04] New review: Umherirrender; "fixed only typo in commit message" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/22208 [18:14:56] New review: Krinkle; "Great improvement overall, two minor points." [mediawiki/extensions/OnlineStatusBar] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/22180 [18:17:06] New review: Matmarex; "I don't really think that $.createSpinner(idYouHaveToComeUpWith) is an improvement over $('
').a..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/22178 [18:20:47] 03(mod) Shorten thumbnail name convention - 10https://bugzilla.wikimedia.org/39697 (10Rob Lanphier) [18:24:08] 03(mod) WLMMobile: 'cancel' during upload doesn't actually cancel the upload - 10https://bugzilla.wikimedia.org/38317 +comment (10Arthur Richards) [18:27:41] New patchset: Matmarex; "(bug 37132) replace the status bar with an icon to be nicer and neater" [mediawiki/extensions/OnlineStatusBar] (master) - https://gerrit.wikimedia.org/r/22180 [18:27:49] Krinkle|detached: can you reply? ^ [18:35:52] New patchset: Liangent; "Fix zhtable's Makefile.py" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22218 [18:40:11] 03(mod) Chunked upload fails with internal_api_error_UploadStashFileNotFoundException - 10https://bugzilla.wikimedia.org/36587 +comment (10Rob Lanphier) [18:42:05] sumanah: "And similarly, with JavaScript, for a while Launchpad had a small number of people who felt comfortable writing & reviewing JS, but now it has spread to all their teams. Now everyone's expected to be up to speed on our use of JS, and everyone should be able to review it." [18:42:10] Boy that would be nice [18:42:33] New patchset: Trevor Parscal; "Improved icons" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/22113 [18:42:43] 03(mod) Inconsistent photo upload comments - 10https://bugzilla.wikimedia.org/39807 +comment (10Jon) [18:42:49] marktraceur: yeah, it sure would! I am glad that we are growing our frontend expertise, volunteer and paid, but yeah, it's way below ideal [18:43:20] New patchset: Liangent; "Fix zhtable's Makefile.py" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22218 [18:43:23] 03(mod) Inconsistent state within the internal storage backends - 10https://bugzilla.wikimedia.org/39221 +comment (10Rob Lanphier) [18:43:48] 03(mod) Shorten thumbnail name convention - 10https://bugzilla.wikimedia.org/39697 (10Rob Lanphier) [18:45:15] sumanah: So basically, you'd be expanding the 20% time policy? Is that roughly the idea of this document? [18:45:28] Or is it just "these are interesting things to keep in mind" [18:45:35] marktraceur: oh gosh, look at the timestamps on that doc marktraceur -- that was just a case study I did like a year ago [18:45:50] Ah [18:46:02] So it was [18:46:04] marktraceur: yeah, more of the "interesting things to keep in mind" but if you think this is the kind of program we ought to be doing, I'd welcome your thoughts, proposal, etc [18:46:24] sumanah: Well, I'd say at the very least, a broader base of people to ask for review would be great [18:46:37] New review: Nikerabbit; "Did you notice my inline comment?" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21883 [18:46:38] I mean, it happens all the time with JS reviews, things get thrown to the side [18:46:47] in the long run, after all, the only way to keep development sustainable is to have a huge proportion of the contributors also review [18:46:50] Same with UI changes I'd imagine, and testing [18:46:53] * sumanah is simplifying [18:47:05] sumanah: and better tests speed up review [18:47:11] Case in point, MatmaRex's thing today [18:47:25] yes? [18:47:28] If all of the developers who hang out in here reviewed JS, no problem [18:47:30] * sumanah agrees with Nikerabbit a heck of a lot -- the new QA engineer will help a lot with that, I hope [18:47:40] But I had to hunt down either Krinkle or kaldari [18:48:04] marktraceur: to be fair, IIRC Trevor & Roan also can review JS, and probably others can as well [18:48:12] yeah, Roan does for sure [18:48:17] marktraceur: IIRC Anomie can do JS review, but does not have +2 powers on any repo [18:48:21] (the gated trunk model has a lot to do with that, but I suppose it's up to the rest of us JS people to propose ourselves as +2 people) [18:48:27] I can review some JS too [18:48:30] i think Trevor merged one of my changes, too [18:48:59] Nikerabbit: will remember :> [18:50:10] marktraceur: I am trying to encourage more people to propose themselves at https://www.mediawiki.org/wiki/Git/Gerrit_project_ownership but only when they have proven their reputation a little, with (probably) a dozen merged commits and as many well-written code reviews to their name? [18:50:15] Well, depending on whether kaldari merges your change, we can ping these people too [18:50:16] though my problem is that my gerrit dashboard is useless, I might not notice if someone adds me as reviewer [18:50:19] and starting with an extension is probably a good way to go [18:51:10] Nikerabbit: also I know you are swamped with review so I'm trying to encourage reviewers from reviewers who are not as swamped, and I'm trying to help volunteers learn by doing it [18:51:21] so, I try not to add you as a reviewer very much, Nikerabbit [18:51:58] 03(NEW) Bad data in campaign config can break templates - 10https://bugzilla.wikimedia.org/39847 normal; WikiLoves Monuments Mobile: General; (arichards) [18:51:59] sumanah: it's not that am I swamped, I just don't use my dashboard (and I review interesting stuff as it comes in) [18:52:03] MatmaRex: kaldari has some questions [18:52:56] for https://gerrit.wikimedia.org/r/#/c/18234/, what 'preview' is this referring to? There are at least 3 different types of previews in mediawiki. [18:54:04] biab. [18:54:45] New patchset: Liangent; "Convert -{}- markups in title="" and alt=""." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22220 [18:54:45] 03(NEW) Messages with tokens like {{{GENDER}}} display raw token - 10https://bugzilla.wikimedia.org/39848 normal; WikiLoves Monuments Mobile: General; (arichards) [18:55:18] New patchset: Matmarex; "status icons: increase the saturation, lower the brightness" [mediawiki/extensions/OnlineStatusBar] (master) - https://gerrit.wikimedia.org/r/22221 [18:56:17] kaldari: this changesets refers to the "experimental" JS live preview you can enable in preferences [18:56:23] changeset* [18:56:56] in commit message, "preview" means "#wikiPreview element" [18:57:09] in extended commit message* [18:58:49] * marktraceur goes to play with it [19:01:37] 03(FIXED) Add South Africa to the monuments database - 10https://bugzilla.wikimedia.org/38330 +comment (10Maarten Dammers) [19:02:41] New patchset: Matmarex; "status icons: increase the saturation, lower the brightness" [mediawiki/extensions/OnlineStatusBar] (master) - https://gerrit.wikimedia.org/r/22221 [19:04:43] New patchset: Matmarex; "status icons: increase the saturation, lower the brightness" [mediawiki/extensions/OnlineStatusBar] (master) - https://gerrit.wikimedia.org/r/22221 [19:06:09] one would think that with the entire amend workflow gerrit would allow one to actually amend a patchset when one messes up, but no, no way. [19:06:43] MatmaRex: Your mistakes will be immortalized in patchset 1 :) [19:07:09] Gerrit can be unforgiving, but it's also good to know about things like that [19:07:09] MatmaRex: your making the mistake of assuming that gerrit works how one would want it to work :P [19:07:18] ;) [19:07:36] s/ how one would.*// [19:09:06] on the up side, stuff is a LOT faster now [19:09:14] There's that [19:09:37] so 8-step processes take 5 min instead of 20 :) [19:11:38] New review: MarkTraceur; "Actually, this doesn't totally fix the jump, since the spinner icon adds some height to the div. Mak..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/18234 [19:12:23] sumanah: Actually, I ran those scripts for guillom this morning, to count the number of committers -- I don't think there's a limit on API searches anymore [19:12:30] New patchset: Bsitu; "(bug 14901) Email notification mistakes log action for new page creation" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/7986 [19:12:57] that's cool, marktraceur [19:13:22] there's an issue in gerrit: [19:13:54] a notification mail arriving late is sometimes shown early in gmail [19:14:10] is it a known issue? [19:16:54] hmmm. is gerrit-wm supposed not to notify on IRC about reviews to not-most-recent patchsets? [19:17:24] MatmaRex: Which review exactly? [19:17:37] csteipp: any estimative of when the new .sig will be disponibilized? [19:17:40] https://gerrit.wikimedia.org/r/#/c/22180/ [19:17:43] liangent: I haven't heard of that issue, no. more details? [19:17:47] marktraceur: the latest review by me and Krinkle [19:17:49] reviews* [19:18:08] sumanah: liangent: confirming, gmail does mess up the order [19:18:09] gustavo_cm: Sorry, no... sometime today [19:18:25] csteipp: ok. Thanks anyway. [19:18:27] (i didnt report it specifically because the gerrit email overall suck) [19:18:32] emails* [19:19:53] so what's the cause? [19:20:09] New review: Matmarex; "Hm, interesting point. But what if there is no old preview? I think the current way is fine." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/18234 [19:20:21] marktraceur: ^ [19:21:19] liangent: i noticed that it [19:21:36] liangent: i noticed that it "sorts" the "i'd like you to do a code review..." messages first, then reviews later. [19:21:40] why, i have no idea. [19:22:27] New review: MarkTraceur; "Fine, yes, but imperfect :)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/18234 [19:22:39] Change merged: Siebrand; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22216 [19:22:46] New review: Umherirrender; "Affected by revert of Uri class (I41dadbde)." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/18094 [19:23:15] Change merged: Siebrand; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22218 [19:23:18] MatmaRex, liangent, I see that with Thunderbird as well. My threaded view will put the latest "I want you to do a code review" message as the root, and everything else as a one-deep reply to that message [19:23:43] andre__: may I pm? [19:24:12] 03(FIXED) Windows 8 app: include higher-resolution application tile images - 10https://bugzilla.wikimedia.org/39809 +comment (10Brion Vibber) [19:24:52] sumanah, sure. always. [19:25:17] Change merged: Siebrand; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22212 [19:25:26] liangent: it looks like the review mails have "In-Reply-To:" and "References:" headers, while "i'd like you to" mails don't. [19:25:44] i have no idea if this might be tha cause [19:25:56] or is this a gerrit bug or gmail bug, [19:26:12] New review: Tychay; "LGTM. One liner to invalidate cache. :-)" [mediawiki/extensions/Echo] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/19763 [19:26:31] Change merged: Siebrand; [mediawiki/extensions/WikimediaIncubator] (master) - https://gerrit.wikimedia.org/r/21165 [19:27:28] so, is somebody reporting this as a bug? [19:29:15] New patchset: Catrope; "Add tests asserting ordering of annotations works" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/22225 [19:30:06] Change merged: Siebrand; [mediawiki/extensions/DoubleWiki] (master) - https://gerrit.wikimedia.org/r/15637 [19:30:20] New review: Matmarex; "I still think that a throbber over the preview would look weird (since we do not hide the preview to..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/18234 [19:30:22] What [19:30:25] !e DoubleWiki [19:30:25] https://www.mediawiki.org/wiki/Extension:DoubleWiki [19:30:26] * sumanah drums her impatient fingers at lag [19:31:02] That's pretty cool [19:31:26] New review: MarkTraceur; "Seems reasonable." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/18234 [19:32:06] marktraceur: <3 [19:32:27] MatmaRex: A discussion is all I wanted really :) [19:32:33] :) [19:35:40] Occurs to me I hadn't added you to a patch [19:35:43] Now I did! :) [19:37:28] oh my, i saw that one before, but it's a beast, so i stopped looking [19:37:29] ;) [19:37:45] also i think we already have too much mw.whatever stuff [19:37:54] especially since most of it doesnt seem to be documented anywhere [19:38:32] Anyone bored and want to review a change to pdfhandler? ( https://gerrit.wikimedia.org/r/#/c/16930/ ) [19:38:44] *nod* there's a page with some of the docs, but it's pretty sparse [19:38:57] I will certainly document mw.Time, it's worth documenting [19:39:16] isnt there something like doxygen, but for javascript? [19:39:39] I think there is [19:39:41] you seem to have some nice comments in the code [19:40:04] so whats the point of copying them manually, all we're going to gain is that they'll be sitting there, slowly getting outdated [19:40:23] Ha, true [19:44:37] New patchset: GWicke; "Start to hook up a simplistic tokenizer" [mediawiki/extensions/Parsoid] (master) - https://gerrit.wikimedia.org/r/22154 [19:46:52] New patchset: Umherirrender; "Add messages for global groups" [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/22226 [19:49:21] MatmaRex: and those in-reply-to and references doesn't match message-id [19:49:32] message-ids looks like *@mchenry.wikimedia.org [19:49:49] but in-reply-to and references look like *@gerrit.wikimedia.org [19:50:32] liangent: hm, you sure? there's a lot of mails in there [19:51:03] if its actually like this, this looks like a gerrit bug. [19:53:12] MatmaRex: can also be a wmf configuration bug :) [19:53:51] jdlrobson: pull request sent https://github.com/jdlrobson/polaroiderizer/pull/2 [19:54:15] liangent: hm, true, good point [19:54:57] liangent: poke me if you report it somewhere, would you? :) [19:55:15] why bit report it in bugzilla yourself? [19:55:18] *why not [19:55:36] me? i'm too lazy ~ [19:55:38] joancreus: awesome :D [19:55:49] MatmaRex: I found bug 36288 [19:55:51] https://bugzilla.wikimedia.org/show_bug.cgi?id=36288 [19:55:54] (and to be honest i couldnt care less about gerrit mails, i dont read them anyway) [19:55:56] joancreus: can you also send me a pull request with your buttons per country [19:56:06] New review: Raimond Spekking; "Small tweaks only" [mediawiki/extensions/WikimediaMessages] (master) C: 0; - https://gerrit.wikimedia.org/r/22226 [19:56:33] that part wasn't mine :) [19:57:18] hmm it seems whoever did it changed how categories were added [20:03:40] New patchset: Trevor Parscal; "Improved icons" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/22113 [20:04:26] New patchset: Tpt; "(bug 37483) Prp now create automaticaly index and page namespaces if they are not set." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/17643 [20:08:12] 03(FIXED) Project creation fails to create security group rules properly - 10https://bugzilla.wikimedia.org/39722 +comment (10Ryan Lane) [20:09:39] New patchset: Umherirrender; "Add messages for global groups" [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/22226 [20:12:20] New patchset: Umherirrender; "Add messages for global groups" [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/22226 [20:12:59] New review: MarkTraceur; "A few concerns inline, feel free to ignore code convention stuff as I'm really happy that you did al..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/21883 [20:13:30] New patchset: Hashar; "Make arguments to phpunit.php work." [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22258 [20:13:47] New review: Umherirrender; "some fixes of lowercase group member name" [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/22226 [20:14:51] joancreus: made quite a few changes… do you know who is maintaining http://toolserver.org/~erfgoed/stream/ ? [20:16:33] jdlrobson: hmm nope. i think Platonides did something [20:16:45] maybe multichill knows [20:17:01] New review: Hashar; "Fix a very nasty PHPUnit tests failure on contint :/" [mediawiki/core] (REL1_18); V: 1 C: 2; - https://gerrit.wikimedia.org/r/22258 [20:17:12] joancreus: I thought it was you [20:17:24] multichill: i only changed the buttons [20:17:31] multichill: nope someone forked it [20:17:37] erfgoed::6028:akoopal,multichill,silverspoon,rudolphous,mark,jcreus,jeanfred,kolossos,kentaur,husky,ntavares,platonides,strainu,cirdan,raymond,alexxw,brion,yuvipanda,maxsem,awjrichards [20:17:44] Those are the people who have access [20:19:13] mmm [20:19:14] it was Platonides (i checked the mailing list) jdlrobson [20:19:18] ok cool [20:19:28] when i grab him i'll ask him to run latest and greatest :) [20:19:39] Change merged: Hashar; [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22258 [20:22:52] New patchset: CSteipp; "(bug 38333) Check global blocks on account create" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22189 [20:23:43] New patchset: Trevor Parscal; "Improved icons" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/22113 [20:24:59] New patchset: Hashar; "(bug 39700) Fix for html injection" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22194 [20:25:00] New patchset: Hashar; "(bug 35839) Hidden block text leaking to admins" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22193 [20:25:00] New patchset: Hashar; "(bug 39184) LDAP password leakage" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22192 [20:25:00] New patchset: Hashar; "(bug 37587) Enforce language codes to be html safe" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22190 [20:25:01] New patchset: Hashar; "(bug 39180) Set x-frame-options='DENY' for api" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22191 [20:26:01] MatmaRex: not having any luck reproducing the previewing bug. Could you post repro steps in the bug? [20:26:14] https://bugzilla.wikimedia.org/show_bug.cgi?id=25830 [20:28:40] it mentions using a keyboard shortcut. What's the shortcut? [20:29:49] kaldari: well, its not really a bug [20:29:52] 03(mod) LivePreview makes page "jump" - 10https://bugzilla.wikimedia.org/25830 +comment (10Ryan Kaldari) [20:30:00] try previewing a larger article with it [20:30:07] I did [20:30:10] seems to work fine [20:30:26] it works, but the edit field is moved all over the place [20:30:33] when the preview disappears and reappears [20:30:39] preview area* [20:31:04] I don't get any scrolling behaviour at all. The preview just loads in as I would expect [20:31:06] maybe you have too fast a connection to see it :P [20:31:26] I'll try a really huge article :) [20:31:28] I tested on localhost and still got the problem [20:31:33] like WWII [20:31:38] 03(NEW) No session info and session unmatch should be prompted differently on user login - 10https://bugzilla.wikimedia.org/39849 normal; MediaWiki: User login; (liangent) [20:31:55] New patchset: Hashar; "disable broken tests in REL1_18" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22260 [20:32:03] the gist is that when the preview area is already present, it is completely hidden when "Preview" is clicked [20:32:13] so the edit box automatically moves up [20:32:27] (and you get to look at the bottom of the edit page) [20:32:33] then the preview is loaded and inserted [20:32:46] and you are looking at a random part of the article you are previewing [20:33:08] you have to go back to find the edit field, or go up to see where in the article you are ,etc [20:33:16] oh, so this is about the behavior on the 2nd preview [20:33:23] yeah, mostly [20:33:54] the first time we always will have some kind of jump, as new content is being inserted [20:34:09] makes sense [20:34:57] 03(WONTFIX) Add Hungary to the monuments database - 10https://bugzilla.wikimedia.org/38322 +comment (10Effeietsanders) [20:35:48] 03(mod) Add the Philippines to the monuments database - 10https://bugzilla.wikimedia.org/38328 +comment (10Effeietsanders) [20:36:20] geez, previewing WWII takes forever :) [20:36:30] I think I see what you're talking about though [20:37:13] kaldari: there is a reason why that article is always used as the example for THE PARSER IS SLOW!!!!111 arguments ;) [20:38:11] 03(WONTFIX) Add Kazakhstan to the database - 10https://bugzilla.wikimedia.org/39167 +comment (10Effeietsanders) [20:38:41] 03(WONTFIX) Add Cameroon to the database - 10https://bugzilla.wikimedia.org/39163 +comment (10Effeietsanders) [20:39:24] bawolff: probably because the Obama article is U.S.-centric and I can never remember any of the other gazillion-ref articles (seem to mostly be chess related) :) [20:40:40] those chess guys are really into using references for some reason ;) [20:42:08] I'm glad I have no interest in either chess or WWII [20:44:47] New patchset: Jeroen De Dauw; "Refactored parserhooks test to use abstract base" [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/22261 [20:44:48] New patchset: Jeroen De Dauw; "update indent of class loading" [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/22262 [20:44:48] New patchset: Jeroen De Dauw; "update class autoloading registration to not use local vars" [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/22263 [20:44:48] New patchset: Jeroen De Dauw; "Added base tests for remianing parser hooks" [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/22264 [20:45:18] Change merged: Jeroen De Dauw; [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/22261 [20:45:24] Change merged: Jeroen De Dauw; [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/22262 [20:45:29] Change merged: Jeroen De Dauw; [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/22263 [20:45:41] Change merged: Jeroen De Dauw; [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/22264 [20:47:13] New patchset: Hashar; "move parser fuzz test to ParserFuzz group" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22265 [20:49:45] New review: Kaldari; "This seems to be an improvement, but why not put the spinner after the Preview header so there are 2..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/18234 [20:50:30] MatmaRex: My review comment did get formatted correctly, so let me know if it is confusing. [20:50:41] did=didn't [20:50:50] Change merged: Siebrand; [mediawiki/extensions/TitleBlacklist] (master) - https://gerrit.wikimedia.org/r/22102 [20:51:20] New review: Hashar; "Failure is caused by Fuzz tests which should be fixed with https://gerrit.wikimedia.org/r/#/c/22265/" [mediawiki/core] (REL1_18); V: 1 C: 2; - https://gerrit.wikimedia.org/r/22260 [20:51:21] Change merged: Hashar; [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22260 [20:51:35] End of the week, time to put suggestions in https://en.wikipedia.org/wiki/Wikipedia:Wikipedia_Signpost/Newsroom/Suggestions [20:52:05] end of the month, time to update the statuses at https://www.mediawiki.org/wiki/Wikimedia_engineering_report/2012/August [20:52:32] New patchset: Robmoen; "Center Ellpisis for long page titles. Misc positioning fixes." [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/22266 [20:53:25] 03(mod) LivePreview makes page "jump" - 10https://bugzilla.wikimedia.org/25830 +comment (10Ryan Kaldari) [20:54:22] tewwy: TMH & FlaggedRevs are missing in https://www.mediawiki.org/wiki/Wikimedia_engineering_report/2012/August#Features_Engineering :) [20:54:31] New patchset: Hashar; "(34037) phpunit tests timeout too fast" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22267 [20:56:24] kaldari: ok, reading... [20:57:34] sumanah: I'm almost there. I believe Rob is handling TMH update. I'll see if there's any update on FlaggedRevs. [20:57:46] Change merged: Hashar; [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22267 [20:57:47] Change merged: Hashar; [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22265 [20:57:48] got it, thanks tewwy [20:58:36] kaldari: you mean placing the throbber into the h1 element? [20:58:44] yeah [20:58:45] (or is it h2, whatever) [20:58:49] hm [20:59:05] but the "Preview" header only appears after previewing at least once [20:59:12] how about the Editing ..." header? [20:59:14] heading* [20:59:56] New patchset: Hashar; "(bug 39700) Fix for html injection" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22194 [20:59:57] New patchset: Hashar; "(bug 35839) Hidden block text leaking to admins" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22193 [20:59:57] New patchset: Hashar; "(bug 39184) LDAP password leakage" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22192 [20:59:58] New patchset: Hashar; "(bug 37587) Enforce language codes to be html safe" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22190 [20:59:58] New patchset: Hashar; "(bug 39180) Set x-frame-options='DENY' for api" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22191 [20:59:58] New patchset: Hashar; "(bug 38333) Check global blocks on account create" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22189 [21:00:12] 03(NEW) Windows 8 app: open search pane when you start typing - 10https://bugzilla.wikimedia.org/39850 enhancement; Wikipedia App: Search; (brion) [21:00:38] New patchset: Hashar; "Update release notes and incremented version" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22201 [21:00:50] New review: Hashar; "Rebased" [mediawiki/core] (REL1_18); V: 0 C: 0; - https://gerrit.wikimedia.org/r/22201 [21:01:32] Change merged: Bsitu; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/22032 [21:01:44] 03(NEW) Windows 8 app: accept incoming text sharing to perform searches - 10https://bugzilla.wikimedia.org/39851 enhancement; Wikipedia App: Generic; (brion) [21:01:57] New patchset: Hashar; "Update release notes and incremented version" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22201 [21:02:13] New review: Hashar; "Added release notes for tests fixes:" [mediawiki/core] (REL1_18); V: 0 C: 0; - https://gerrit.wikimedia.org/r/22201 [21:02:40] 03(NEW) [Regression] "Copy metadata" functionality is lost - 10https://bugzilla.wikimedia.org/39852 major; MediaWiki extensions: UploadWizard; (raimond.spekking) [21:03:09] 03(NEW) Windows 8 app: in-article find feature - 10https://bugzilla.wikimedia.org/39853 enhancement; Wikipedia App: Generic; (brion) [21:03:26] I think having 2 different throbbers makes sense - 1 for loading the preview and 1 for updating the preview. Having a throbber on the Edit header would be less ideal since the Edit header can be any length (or even more than 1 line) and you don't see that header after the 1st preview. [21:03:40] Change merged: Bsitu; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/22016 [21:04:12] kaldari: you do see the header all the time? [21:04:31] alternately, you could fade the existing preview and overlay the throbber over the top of it (as an absolutely positioned element) [21:04:43] New patchset: Alex Monk; "Use whitespace between function parameters and the brackets." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/22268 [21:05:03] both of these require separate implementations for first preview, and for following previews, and i dont like it :/ [21:05:05] 03(NEW) Windows 8 app: higher-resolution splash screen images - 10https://bugzilla.wikimedia.org/39854 enhancement; Wikipedia App: Generic; (brion) [21:06:17] 03(mod) [Regression] "Copy metadata" link not always at the 1st image - 10https://bugzilla.wikimedia.org/39852 summary; +comment (10Raimond Spekking) [21:06:25] noobish question: is it safe to leave the .htaccess files in tests/jasmine and tests/qunit as "Allow for all" in a production environment? [21:06:33] is it safe to set them to "Deny for all"? [21:06:40] from* [21:06:40] 03(NEW) Update Blackberry Playbook app to a more current release - 10https://bugzilla.wikimedia.org/39855 normal; Wikipedia App: Generic; (brion) [21:07:12] what happens if you go to http://semantic-mediawiki.org/w/tests/jasmine/spec_makers/ and run the php file from there? [21:07:15] Change merged: CSteipp; [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22189 [21:07:26] Crilistalier: while it certainly won't hurt to have them deny from all [21:07:37] Change merged: CSteipp; [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22190 [21:07:56] Change merged: CSteipp; [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22191 [21:08:13] * bawolff thinks its kind of odd we have an allow from all there [21:08:35] Change merged: CSteipp; [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22192 [21:08:40] I suppose those tests are run from the web browser [21:08:49] Change merged: CSteipp; [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22193 [21:09:00] 03(mod) No RTL support in the WLM app - 10https://bugzilla.wikimedia.org/39288 +comment (10Amir E. Aharoni) [21:09:03] The qunit test looks like a javascript test to me [21:09:23] kaldari: really, i think the current solution is Good Enough(TM). it could be solved better, but it works and solves a real problem [21:09:32] true [21:09:33] But I'll deny them in my wiki. Thanks! [21:09:37] kaldari: and i'd very much want to have it merged before sept. 3rd and wmf11 :) [21:09:44] Change merged: CSteipp; [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22201 [21:09:44] Change merged: CSteipp; [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/22194 [21:09:53] kaldari: i'm going to do a little revamp of LivePreview later [21:10:08] fixing up all the old quirks, then using API calls instead of preview [21:10:36] (this will also allow me to fix a bug where previewing a tags is impossible) [21:10:42] 03(NEW) Firefox OS-compatible version of PhoneGap-based app - 10https://bugzilla.wikimedia.org/39856 normal; Wikipedia App: Generic; (brion) [21:15:13] 03(NEW) Windows 8 app: featured pictures should open the image when clicked, not just a referenced article - 10https://bugzilla.wikimedia.org/39857 enhancement; Wikipedia App: Generic; (brion) [21:15:13] New patchset: IAlex; "Use WikiPage::makeParserOptions() where possible." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/18973 [21:15:29] New review: IAlex; "rebase" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/18973 [21:16:46] 03(NEW) The "back" arrow at the top of the page points the wrong way in RTL - 10https://bugzilla.wikimedia.org/39858 normal; WikiLoves Monuments Mobile: General; (amir.aharoni) [21:16:47] 03(mod) No RTL support in the WLM app - 10https://bugzilla.wikimedia.org/39288 (10Amir E. Aharoni) [21:18:25] New patchset: IAlex; "Use WikiPage::makeParserOptions() where possible." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/18973 [21:19:06] New review: IAlex; "Variable name fix in ApiParse.php" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/18973 [21:20:06] https://bugzilla.wikimedia.org/show_bug.cgi?id=39273 could somebody close this bug? the change is merged [21:21:07] 03(FIXED) "Show changes" should not be incorrectly displayed in the Live Preview state - 10https://bugzilla.wikimedia.org/39273 +comment (10Sumana Harihareswara) [21:21:11] 03(mod) Upgrade Wikimedia OTRS installation to the latest version - 10https://bugzilla.wikimedia.org/22622 +comment (10Jérémie Roquet) [21:21:11] 03(mod) [Regression] "Copy metadata" link not always at the 1st image - 10https://bugzilla.wikimedia.org/39852 +comment (10Mark Holmquist) [21:21:34] MatmaRex: done, and also, you can mark bugs resolved now. [21:21:38] * sumanah gave privileges [21:22:16] 03(NEW) WLMMobile: existing photo on monument detail page pixelated on high-res displays - 10https://bugzilla.wikimedia.org/39859 enhancement; WikiLoves Monuments Mobile: General; (brion) [21:22:52] New review: Matmarex; "Same as with Mark's suggestion, this would require separate code for first preview and following pre..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/18234 [21:23:01] sumanah: oh, thanks a lot :) [21:23:07] :) [21:24:15] 03(NEW) Browse countries flips to nearby monuments on re-sort - 10https://bugzilla.wikimedia.org/39860 normal; WikiLoves Monuments Mobile: Browse; (philinje) [21:25:26] 03(NEW) Red underlined titles are aligned incorrectly in RTL - 10https://bugzilla.wikimedia.org/39861 normal; WikiLoves Monuments Mobile: General; (amir.aharoni) [21:25:26] 03(mod) No RTL support in the WLM app - 10https://bugzilla.wikimedia.org/39288 (10Amir E. Aharoni) [21:25:42] kaldari: so. do you think this will do for now, or do i have to come up with a better design? i'm no designer :( [21:26:00] 03(mod) Red underlined titles are aligned incorrectly in RTL - 10https://bugzilla.wikimedia.org/39861 +comment (10Amir E. Aharoni) [21:29:10] 03(mod) Upgrade Wikimedia OTRS installation to the latest version - 10https://bugzilla.wikimedia.org/22622 +comment (10Thehelpfulone) [21:29:21] 03(NEW) Windows 8 app: dynamic section loading - 10https://bugzilla.wikimedia.org/39862 enhancement; Wikipedia App: Generic; (brion) [21:29:58] New review: Tychay; "Just whitespace :-)" [mediawiki/extensions/Echo] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/22268 [21:31:57] 03(ASSIGNED) Messages with tokens like {{{GENDER}}} display raw token - 10https://bugzilla.wikimedia.org/39848 (10Brion Vibber) [21:35:06] 03(mod) [Regression] "Copy metadata" link not always at the 1st image - 10https://bugzilla.wikimedia.org/39852 +comment (10Erik Moeller) [21:35:44] 03(NEW) spinner of monument image loading appears on the wrong side in RTL languages - 10https://bugzilla.wikimedia.org/39863 normal; WikiLoves Monuments Mobile: Browse; (amir.aharoni) [21:35:44] 03(mod) No RTL support in the WLM app - 10https://bugzilla.wikimedia.org/39288 (10Amir E. Aharoni) [21:36:48] 03(mod) [Regression] "Copy metadata" link not always at the 1st image - 10https://bugzilla.wikimedia.org/39852 +comment (10Erik Moeller) [21:39:38] New patchset: CSteipp; "(bug 39184) LDAP password leakage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22269 [21:40:19] 03(NEW) Windows 8 app: language links menu sometimes spills off screen - 10https://bugzilla.wikimedia.org/39864 normal; Wikipedia App: Generic; (brion) [21:41:51] 03(mod) Red underlined titles are aligned incorrectly in RTL - 10https://bugzilla.wikimedia.org/39861 +comment (10Amir E. Aharoni) [21:42:00] Change merged: Siebrand; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/19763 [21:43:23] Change merged: Siebrand; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/22268 [21:43:29] New patchset: Ryan Lane; "Support for requiring a mediawiki group for shell" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/22270 [21:43:35] robla: ^^ [21:43:46] that may make you a little happy ;) [21:44:08] I'd point sumanah at that too, but she's not here :) [21:45:19] specifically, see the topic of the change [21:45:30] 03(mod) [Regression] "Copy metadata" link not always at the 1st image - 10https://bugzilla.wikimedia.org/39852 +comment (10Mark Holmquist) [21:45:55] oh, nice! [21:47:30] 03(NEW) Country name appears in English while the rest of the app works in Hebrew - 10https://bugzilla.wikimedia.org/39865 normal; WikiLoves Monuments Mobile: Browse; (amir.aharoni) [21:48:35] I need to fix a race condition on uids, then make a "shell request" queue on labsconsole using SMW, then I can enable self-registration [21:49:40] 03(NEW) Add Anexos to content namespaces on Portuguese and Spanish Wikipedia - 10https://bugzilla.wikimedia.org/39866 enhancement; Wikimedia: Site configuration; (federicoleva) [21:50:57] 03(NEW) TimedMediaHandler: video transcode to MP4/H.264 support - 10https://bugzilla.wikimedia.org/39867 normal; MediaWiki extensions: TimedMediaHandler; (brion) [21:51:09] New patchset: Siebrand; "Follow-up I2c10cb69: Auto-formatted using IDE." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/22271 [21:51:30] Change merged: Siebrand; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/22271 [21:52:45] I can't seem to find where to upload the logotype to my wiki. [21:52:56] I checked every wiki-setting. [21:53:16] 04(REOPENED) apply explicit lang and dir HTML attributes to country-specific data in the WLM app - 10https://bugzilla.wikimedia.org/39290 summary; +comment (10Amir E. Aharoni) [21:53:53] Krenair: Are you here? [21:54:00] Yes [21:54:07] Where's that setting? [21:54:08] The logotype? [21:54:11] What do you mean? [21:54:11] Yes. [21:54:16] Do you just want to change the logo? [21:54:20] The logo to the left. [21:54:31] I want to add it. [21:54:41] Upload & add. [21:54:41] 03(NEW) Support playing video clips in PhoneGap, Windows 8 apps - 10https://bugzilla.wikimedia.org/39868 enhancement; Wikipedia App: Generic; (brion) [21:54:44] New patchset: CSteipp; "(bug 39700) Add htmlspecialchars encoding to label" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22272 [21:54:47] !logo [21:54:48] The logo that appears in the top left of each page is from $wgLogo in LocalSettings.php. To change this you change the value of $wgLogo to point to the URL of your own logo. See . Be sure $wgLogo is set to an absolute path, starting with "/" (or a protocol "http:"/"https:"). Using pretty URLs a relative path will behave oddly. 135x135 pixels [21:54:55] 03(NEW) Enable MP4/H.264 transcode target support on Wikimedia' TimedMediaHandler setup - 10https://bugzilla.wikimedia.org/39869 normal; Wikimedia: Extension setup; (brion) [21:54:56] Set $wgLogo [21:54:57] 03(mod) Review and deploy TimedMediaHandler extension (timed media handler) to Wikimedia wikis - 10https://bugzilla.wikimedia.org/27699 (10Brion Vibber) [21:54:59] 03(mod) TimedMediaHandler: video transcode to MP4/H.264 support - 10https://bugzilla.wikimedia.org/39867 (10Brion Vibber) [21:55:00] 03(mod) Video files are broken on mobile - 10https://bugzilla.wikimedia.org/38305 (10Brion Vibber) [21:55:00] 03(mod) Support playing video clips in PhoneGap, Windows 8 apps - 10https://bugzilla.wikimedia.org/39868 (10Brion Vibber) [21:55:00] OK. [21:56:12] But how can I upload it to the wiki so that it'll never disappear? [21:56:21] 03(mod) Enable MP4/H.264 transcode target support on Wikimedia's TimedMediaHandler setup - 10https://bugzilla.wikimedia.org/39869 summary (10Brion Vibber) [21:56:21] Some pages may go down. [21:56:35] I don't plan to have my wiki down. [21:57:24] Change merged: CSteipp; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22269 [21:57:51] New patchset: MarkTraceur; "(bug 39852) Mitigate array magic that sometimes happens" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/22273 [21:57:53] 03(NEW) a big "exit" button is shown immediately after logging in - 10https://bugzilla.wikimedia.org/39870 normal; WikiLoves Monuments Mobile: Login; (amir.aharoni) [21:58:06] is there a way to disable resource loader on a per user basis? [21:58:11] 03(mod) [Regression] "Copy metadata" link not always at the 1st image - 10https://bugzilla.wikimedia.org/39852 +comment (10Mark Holmquist) [22:00:05] New patchset: GWicke; "Start to hook up a simplistic tokenizer" [mediawiki/extensions/Parsoid] (master) - https://gerrit.wikimedia.org/r/22154 [22:00:27] Betacommand: No there is not [22:00:37] resource loader plays a real bitch with ad blocking software as it lumps scripts/tools together [22:01:23] Oh, you're saying if there's one script that triggers an ad detector it'll block the whole thing? [22:01:31] Can't you tell your ad blocker to trust bits.wm.o? [22:03:38] RoanKattouw: I often want to block crap [22:03:57] From bits even? [22:04:01] yes [22:04:08] Like what? [22:04:25] * Betacommand goes to dig up is filter list [22:05:04] New review: CSteipp; "Already released as part of 1.20wmf10, 1.19.2, 1.18.5" [mediawiki/core] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/22272 [22:05:07] Change merged: CSteipp; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22272 [22:06:04] If you did ?debug=true it would load the things in separate requests - would that help you? [22:07:43] New patchset: Catrope; "Preserve the leading ./ and ../ in internal link hrefs" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/22163 [22:08:30] bawolff: is there a way to set that as a preference? [22:08:39] RoanKattouw: global banners is one [22:08:50] Right [22:09:14] is there a maintenance script to add users to a group? [22:09:35] * Ryan_Lane really doesn't want to add 600 users to the shell group by hand [22:09:38] Betacommand: no [22:09:43] I don't think so no [22:09:52] But you can still do it from the command line [22:09:55] how do I do it via mysql? [22:10:02] Insert 600 rows into the user_groups table from mysql [22:10:08] Then use eval.php to invalidate the user cache for those users [22:10:17] o.O [22:10:21] INSERT INTO user_groups VALUES (userid, groupname); [22:10:32] Then in eval.php: User::newFromID(userid)->invalidateCache(); [22:11:01] thanks [22:16:16] RoanKattouw: php maintenance/eval.php 'User::newFromID(userid)->invalidateCache();' ? [22:16:23] bleh [22:16:29] userid needs to be the actual number, eh? [22:16:33] No, it reads from stdin [22:16:35] Yes [22:16:47] wait [22:16:49] what? [22:17:02] eval.php reads from stdin, not from $argv. Yes, this is inconvenient [22:17:09] very, very shitty [22:17:09] yes [22:17:56] there we go [22:18:07] for i in `mysql -BNe 'select user_id from user;' novawiki`; do mysql -BNe "INSERT INTO user_groups VALUES ($i, 'shell')" novawiki; done [22:18:15] mysql -BNe 'select user_id from user;' novawiki | php maintenance/eval.php 'User::newFromID(userid)->invalidateCache();' [22:18:25] No [22:18:25] Change merged: Bsitu; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21894 [22:18:41] no? [22:18:48] for i in `mysql -BNe 'select user_id from user;' novawiki`; do mysql -BNe "INSERT INTO user_groups VALUES ($i, 'shell')" novawiki; echo "User::newFromID($i)->invalidateCache();" | php maintenance/eval.php; done [22:19:01] wow [22:19:05] that's just terrible [22:19:14] Yes, you have to echo PHP code and pipe it into php [22:19:55] ok. that'll work. [22:20:09] I may have self-registration done today [22:20:58] Awesome! [22:21:20] I just need to fix this race condition [22:21:22] 03(NEW) Date in filename shows wrong month - 10https://bugzilla.wikimedia.org/39871 normal; WikiLoves Monuments Mobile: General; (philinje) [22:21:22] New patchset: Kaldari; "(bug 25830) fix JS preview causing the page to "jump"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/18234 [22:22:03] Change merged: Trevor Parscal; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/22163 [22:22:03] MatmaRex: What do you think of this one: https://gerrit.wikimedia.org/r/#/c/18234/10 [22:22:10] 03(NEW) Campaign data should be fetched dynamically/periodically within the app - 10https://bugzilla.wikimedia.org/39872 normal; WikiLoves Monuments Mobile: General; (arichards) [22:22:30] it just conditionally switches the spinner to absolutely positioned if the preview is already showing [22:22:35] that way there is no jumping at all [22:23:40] kaldari: let me look [22:23:49] i suppose it's okay if it works :) [22:24:22] jenkins says "fail" [22:24:25] woohooo, trailing whitespace! [22:24:31] also, how did you get jenkins to fail? [22:24:31] oops [22:24:38] i havent managed it yet :D [22:25:15] New patchset: Kaldari; "(bug 25830) fix JS preview causing the page to "jump"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/18234 [22:25:20] MatmaRex: You should, it's soooo much fun [22:25:24] whitespace fix [22:25:58] New patchset: GWicke; "Start to hook up a simplistic tokenizer" [mediawiki/extensions/Parsoid] (master) - https://gerrit.wikimedia.org/r/22154 [22:26:08] kaldari: why do we need "$( '#mw-content-text' ).css( 'position', 'relative' );"? [22:26:31] so the absolute positioning of the spinner will position correctly [22:27:02] ah, you're positioning it absolutely, relative to mw-content-text [22:27:05] uh-oh. [22:27:12] hehe, bad idea? [22:27:59] for me its okay if ot works, but i cant say i like it ;) [22:28:03] if it* [22:28:17] try it, it's much smoother feeling [22:28:32] will do [22:28:37] why is jenkins still complaining? [22:28:50] are there any tests for livepreview? or did somebody break core? [22:28:56] probably a previous checkin is broken [22:29:40] MatmaRex, kaldari: No, it's because your commit doesn't merge cleanly [22:29:44] https://integration.mediawiki.org/ci/job/MediaWiki-GIT-Fetching/4567/console [22:30:22] it used to. [22:30:24] Jenkins doesn't actually test your commit, it tests a local merge of your commit into master. So if there's a conflict, it can't create that merge, and it gives up [22:30:30] my bet is on the whitespace changes ~ [22:30:32] CONFLICT (content): Merge conflict in skins/common/preview.js [22:30:47] RoanKattouw: but it's pretty nice something checks that [22:30:58] Yeah [22:31:07] Well Gerrit wouldn't merge it if it was +2ed anyway [22:31:12] But this is nice as an advance warning against that [22:31:26] yeah [22:31:46] kaldari: i'll fix it, or are you working on it already? [22:31:50] So instead of please review this - approved - crap, doesn't merge - rebase, it's please re---oh lemme fix this conflict real quick [22:31:58] MatmaRex: Go ahead [22:33:14] kaldari: i'll undo the unrelated whitespace changes for now, i'm going to write a big Code Conventions commit for livepreview later [22:33:20] once i get important stuff merged :) [22:34:44] Alllll righty then, let's see if irssi will cooperate with me [22:35:28] That's a yes! :) [22:36:51] kaldari: oh, also [22:36:57] theres another issue with this [22:37:01] oh? [22:37:04] LivePreview can now also show live diffs [22:37:23] so depending on $wikiPreview.is( ':visible' ) could be a bad idea [22:37:23] how's that work? [22:37:51] https://gerrit.wikimedia.org/r/#/c/21296/ [22:38:24] actually [22:38:27] i dont even know [22:38:30] it just might work [22:38:34] i hate jQuery :( [22:40:51] New patchset: Matmarex; "(bug 25830) fix JS preview causing the page to "jump"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/18234 [22:41:43] i undid whitespace changes and it seems to be merging correctly. [22:42:00] pulling... [22:43:04] New patchset: Siebrand; "Update documentation and deprecated methods." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/22274 [22:44:34] it seems to work well with the live diff as well [22:44:36] New patchset: Robmoen; "Center Ellpisis for long page titles. Misc positioning fixes." [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/22266 [22:44:57] yeah, and jenkins approves. [22:45:22] okay, let me actually test it now :P [22:45:36] now you can switch between previews and diffs as much as you want and no jumping [22:46:32] New patchset: Robmoen; "Center Ellpisis for long page titles. Misc positioning fixes." [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/22266 [22:46:57] New review: Matmarex; "I undid whitespace changes and it merges. Also looks totally slick." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/18234 [22:46:59] kaldari: looks totally sweet. [22:47:59] New review: Siebrand; "Added Sam to reviewers for the localisation of API errors question." [mediawiki/extensions/ArticleFeedbackv5] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21746 [22:51:04] New patchset: Ryan Lane; "Adding a hook to retry uidnumber setting" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/22275 [22:54:59] New patchset: Ryan Lane; "Retry creation on constraint violation" [mediawiki/extensions/LdapAuthentication] (master) - https://gerrit.wikimedia.org/r/22276 [22:55:12] Where can I find information about the relay bot on irc.wikimedia.org? [22:55:40] robla: so, I can enable self-registration if the following commits get reviewed: https://gerrit.wikimedia.org/r/#/q/status:open+topic:selfregistration,n,z [22:56:57] New patchset: SPQRobin; "Fix return doc and update whitespace in SpecialBlock.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22277 [22:59:57] 03(mod) Review and deploy SVGEdit extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/38271 +comment (10Jarry1250) [23:00:13] New patchset: SPQRobin; "Fix PHP notice in LogEventsList since c13632" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22278 [23:01:42] New patchset: Matmarex; "(bug 25830) fix JS preview causing the page to "jump"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/18234 [23:04:28] New patchset: Robmoen; "Adjust margin of wpSummary elements per move of summary box." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21964 [23:05:40] Change merged: Siebrand; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22277 [23:11:04] Ryan_Lane: yay, steps towards self-reg! [23:11:29] well. it's basically done [23:11:38] I just need those commits to be reviewed and I can enable it [23:11:51] right [23:11:56] New review: Brion VIBBER; "Fixme here shouldn't block the merge, it can be dealt with later." [mediawiki/extensions/Math] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/22156 [23:12:09] I added a few reviewers, Ryan_Lane, people who had reviewed or authored in those exts before [23:12:17] cool. thanks. [23:12:21] yw [23:12:38] ah. I need to set up a queue in labsconsole using smw [23:12:39] New patchset: Aaron Schulz; "[FileBackend] Added Content-Disposition support to Swift." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22279 [23:12:39] lemme do that now [23:12:44] New review: Siebrand; "Per Brion." [mediawiki/extensions/Math] (master); V: 1 C: 0; - https://gerrit.wikimedia.org/r/22156 [23:12:44] Change merged: Siebrand; [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/22156 [23:14:05] Am I missing a certain setting? I have enabled upload of images, but it won't work. [23:14:19] Could not create dir "mwstore://local-backend/local-public/c/c8". [23:15:03] AaronSchulz: ---^^ [23:15:30] Umeaboy: check your php error logs [23:18:42] Change merged: Bsitu; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/22010 [23:19:09] 03(mod) No RTL Styling support in the WLM app - 10https://bugzilla.wikimedia.org/39288 summary (10Jon) [23:19:58] 03(NEW) Italian region codes are wrong - 10https://bugzilla.wikimedia.org/39873 normal; Monuments database: Database; (maxsem.wiki) [23:20:07] 14(DUP) spinner of monument image loading appears on the wrong side in RTL languages - 10https://bugzilla.wikimedia.org/39863 +comment (10Jon) [23:20:19] Change merged: Catrope; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22279 [23:20:56] Change merged: Trevor Parscal; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21964 [23:21:05] 03(mod) a big "exit" button is shown immediately after logging in - 10https://bugzilla.wikimedia.org/39870 +comment (10Jon) [23:21:25] 03(FIXED) Date in filename shows wrong month - 10https://bugzilla.wikimedia.org/39871 (10Jon) [23:22:21] New patchset: Catrope; "Manage annotations in ve.AnnotationSet object" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/22162 [23:22:22] New patchset: Catrope; "Add tests asserting ordering of annotations works" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/22225 [23:22:33] New review: Siebrand; "@liangent: Can you please rebase this? Cannot be done automatically." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/3367 [23:24:07] New review: Kghbln; "New coding is functional as tested by me. Cannot help concerning the possible security problem, sinc..." [mediawiki/extensions/BreadCrumbs] (master) C: 1; - https://gerrit.wikimedia.org/r/22126 [23:24:29] New patchset: Aaron Schulz; "Cleaned up some whitespace from 45b9073b61d3aa569adb8cff46531a5b06b8bb7a" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22280 [23:24:46] Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22280 [23:25:01] New patchset: Siebrand; "Extend API to allow viewing revdeleted content." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4658 [23:25:03] 03(mod) Bad data in campaign config can break templates - 10https://bugzilla.wikimedia.org/39847 +comment (10Jon) [23:25:09] some initial attempt at interesting gerrit queries: https://toolserver.org/~bawolff/gerrit-stats.htm [23:25:34] bawolff_away: oooh [23:25:34] New review: Siebrand; "Submitter, please address comments on patch set 1." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/4658 [23:25:37] * sumanah clicks [23:25:55] sumanah: very initial (As can be noted by a total lack of css or anything pretty) [23:25:58] heh [23:26:05] Mostly just list of unreviewed commits in reverse order [23:26:10] 14(DUP) Red underlined titles are aligned incorrectly in RTL - 10https://bugzilla.wikimedia.org/39861 +comment (10Jon) [23:26:19] 14(DUP) The "back" arrow at the top of the page points the wrong way in RTL - 10https://bugzilla.wikimedia.org/39858 +comment (10Jon) [23:26:46] New review: Siebrand; "Should this be kept forever, be merged or be abandoned?" [mediawiki/extensions/Scribunto] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/9882 [23:27:04] 14(DUP) Bad data in campaign config can break templates - 10https://bugzilla.wikimedia.org/39847 +comment (10Jon) [23:27:05] 03(mod) Campaign data should be fetched dynamically/periodically within the app - 10https://bugzilla.wikimedia.org/39872 +comment (10Jon) [23:27:17] 03(mod) Campaign data should be fetched dynamically/periodically within the app - 10https://bugzilla.wikimedia.org/39872 +comment (10Jon) [23:28:25] Brian, you made a wall of shame. This makes me inordinately happy. ;-) [23:28:39] RoanKattouw: lol, I just noticed that the disposition headers thumb.php sends must have been garbage for a while [23:29:15] it uses a local temp file name thats just a bunch of hex [23:29:25] sumanah: It was one of the things I missed from extension:CodeReview [23:30:03] robla: ^ some initial attempt at interesting gerrit queries: https://toolserver.org/~bawolff/gerrit-stats.htm Includes a "wall of shame" and "Positively reviewed changes that are not merged" and "Unreviewed changes to extensions" and "Unreviewed changes to mediawiki/core" with numbers [23:31:01] AaronSchulz: And they are stored in? [23:31:18] bawolff: I know this is probably kind of obvious to you, but: [23:31:22] * thank you [23:31:32] * you included #s and a link to the Gerrit query! yay [23:31:32] Umeaboy: the error logs? are you using apache? [23:31:38] glad you liked it [23:31:44] AaronSchulz: Yes. [23:31:45] * yay links & dates [23:31:56] then probably apache.log by default [23:32:32] I think I see it now. [23:32:52] /var/log/httpd/error_log [23:32:54] Right? [23:33:41] bawolff: you don't mind if I email wikitech-l & the analytics list with this, do you? [23:33:55] I'm actually writing an email to wikitech-l currently [23:33:57] or you could do it so I'm not mouthing off ALL the time [23:33:58] oh ok! [23:34:03] rock [23:34:13] I'm not on the analytics list, so feel free to mail there if you want [23:34:18] sure, I'll fwd it. [23:34:26] it's pretty low-traffic, you might be interested [23:34:41] There's no explanation for that error related to my upload in that log-file. [23:34:56] Only error I see is about missing favicon.ico [23:35:04] bawolff: you might be interested in some of analytics's work, like https://github.com/wikimedia/limn [23:35:37] So what do I do? [23:35:55] back later [23:36:22] ^demon: btw, any chance we could have an "anonoymous" gerrit account, which does not have commenting rights or anything, but still have an ssh key that I could feel safe about putting the private part on a public server so I can access the ssh interface of gerrit from the toolserver, without my private key being on the toolserver [23:37:23] New review: Siebrand; "Submitter, please address the comments given." [mediawiki/extensions/UploadWizard] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12353 [23:38:23] New review: Siebrand; "Any progress expected on this monster? It's been dormant for a while now..." [mediawiki/extensions/UploadWizard] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/3808 [23:39:22] RoanKattouw: looks like tim added it in ed43039 [23:39:38] may, 2007 :) [23:40:06] * Added a Content-Disposition header to thumb.php output [23:40:09] Well yeah, you did that ... [23:40:12] heh [23:40:34] * AaronSchulz likes how well annotate works in netbeans with git, even with files moving all over the place [23:40:47] AaronSchulz: Oooooh I see what the lang code is doing there [23:40:51] It's per the RFC [23:41:09] filename *= quote [langcod] [23:41:11] Sorry [23:41:22] 'filename*' equals quote [langcode] quote filename [23:41:26] I don't see it being required [23:41:31] which rfc? [23:41:32] It's not required, no [23:41:37] I had it just now [23:41:47] I knew it was valid, I just didn't get the use [23:41:50] New patchset: Alex Monk; "Add welcome notification for new users." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/22281 [23:41:59] AaronSchulz: https://tools.ietf.org/html/rfc5987#section-3.2 , see ext-value [23:42:14] Referenced by https://tools.ietf.org/html/rfc6266#section-4.1 [23:43:15] "Furthermore, note that the format used for ext-value allows specifying a natural language (e.g., "en"); this is of limited use for filenames and is likely to be ignored by recipients." [23:43:20] heh [23:43:25] 03(mod) No RTL Styling support in the WLM app - 10https://bugzilla.wikimedia.org/39288 +comment (10Jon) [23:43:47] thats what I saw when I was looking at 6266 earlier [23:47:24] 03(mod) The "back" arrow at the top of the page points the wrong way in RTL - 10https://bugzilla.wikimedia.org/39858 +comment (10Jon) [23:47:56] New patchset: Alex Monk; "Add welcome notification for new users." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/22281 [23:50:06] New patchset: Aaron Schulz; "[FileRepo] Added option to shorten long file names." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22282 [23:51:22] New patchset: Siebrand; "Added WikiText Lua module" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/9882 [23:53:25] Change merged: Kaldari; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/18234 [23:53:39] MatraRex: merged the change [23:54:04] MatmaRex I mean [23:58:07] 03(mod) The "back" arrow at the top of the page points the wrong way in RTL - 10https://bugzilla.wikimedia.org/39858 +comment (10Jon) [23:59:25] New review: Siebrand; "Only reviewed on L10n/i18n." [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/17216