[00:03:58] New patchset: Tim Starling; "Store private data encrypted with a public key" [mediawiki/extensions/CheckUser] (master) - https://gerrit.wikimedia.org/r/24503 [00:04:05] Change merged: Tim Starling; [mediawiki/extensions/CheckUser] (master) - https://gerrit.wikimedia.org/r/24503 [00:08:13] New patchset: Krinkle; "ResourceLoader: Refactor style loading" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25037 [00:08:31] New review: Krinkle; "* Rebased" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/25037 [00:10:24] New patchset: Siebrand; "Replace deprecated methods and remove unused variables" [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/25602 [00:14:00] 03(mod) enable mobile redirect broken (Certain iOS users getting served desktop site - reports of mobile view not sticking) - 10https://bugzilla.wikimedia.org/38009 +comment (10Arthur Richards) [00:15:07] New review: Trevor Parscal; "I showed you the problem in person, essentially you start typing really fast after changing the inse..." [mediawiki/extensions/VisualEditor] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/25597 [00:15:56] New review: Tim Starling; "See https://bugzilla.wikimedia.org/show_bug.cgi?id=20512 for discussion about the proxy." [mediawiki/core] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/24962 [00:16:10] 03(mod) enable mobile redirect broken (Certain iOS users getting served desktop site - reports of mobile view not sticking) - 10https://bugzilla.wikimedia.org/38009 +comment (10Arthur Richards) [00:17:10] New patchset: Robmoen; "Restore special chars" [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/25603 [00:17:13] 03(mod) VIPS out of memory on large (>100 Mpx) non-progressive JPEG - 10https://bugzilla.wikimedia.org/32721 +comment (10Derrick Coetzee) [00:18:07] 03(NEW) Chunked uploads: fails immediately when trying to upload large JPEG - 10https://bugzilla.wikimedia.org/40586 normal; MediaWiki extensions: UploadWizard; (dc) [00:21:27] got it all set, learned alot about wiki today, thanks for your help Brion [00:21:34] I'm headed home [00:21:40] Change merged: Katie Horn; [wikimedia/fundraising/DonationEmailUnsubscribe] (master) - https://gerrit.wikimedia.org/r/25203 [00:22:20] whee [00:30:30] New patchset: Bsitu; "better way to capcture article snippet" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/25604 [00:31:47] 03(mod) Parsoid: Possible performance regression on latest master - 10https://bugzilla.wikimedia.org/40577 (10ssastry) [00:34:02] New patchset: Reedy; "Add $wgCopyUploadProxy to be used for copy uploads only." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25605 [00:34:19] 03(mod) Enable $wgAllowCopyUploads (upload by URL) - 10https://bugzilla.wikimedia.org/20512 +comment (10Sam Reed (reedy)) [00:35:33] New patchset: Anomie; "(bug 37643) Ensure a session is created when necessary for Captcha" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/11722 [00:36:40] New review: Anomie; "Patchset 2: Use === rather than == for better style, although in this instance it's unlikely to make..." [mediawiki/extensions/ConfirmEdit] (master) C: 0; - https://gerrit.wikimedia.org/r/11722 [00:37:04] New patchset: Anomie; "(bug 37643) Ensure a session is created when necessary for Captcha" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/11722 [00:37:18] 03(mod) Chunked uploads: fails immediately when trying to upload large JPEG - 10https://bugzilla.wikimedia.org/40586 +comment (10Derrick Coetzee) [00:37:43] Next they're gonna be wanting working async copy upload... ;) [00:37:44] 03(mod) Session may not be started for non-logged-in API edits, causing captcha to fail - 10https://bugzilla.wikimedia.org/37643 +comment (10Brad Jorsch) [00:49:56] New review: Katie Horn; "Yeup." [mediawiki/extensions/DonationInterface] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/24248 [00:49:56] Change merged: Katie Horn; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/24248 [00:52:10] anyone around? [00:52:14] marktraceur, you tehre? [01:01:40] 03(mod) Chunked uploads: fails immediately when trying to upload large JPEG - 10https://bugzilla.wikimedia.org/40586 +comment (10Derrick Coetzee) [01:16:53] anyone know why: http://wiki.lightenedblade.com/wiki/Main_Page is showing no imagse? [01:17:04] Dantman, [01:17:07] marktraceur, [01:17:14] ? [01:17:31] Oh... it's working [01:17:57] Sooo... how did you screw them up into working? [01:18:28] i deleted 2/3 of the nginx config you told me to copy [01:18:31] but now the images wont work [01:18:32] :| [01:18:35] and idk why [01:19:05] That's not images... that's load.php that's the typical result of bad practice [01:19:07] https://gist.github.com/3797444 [01:19:09] ah [01:19:13] Look at all the 404s [01:19:13] load.php [01:19:14] Nowait... [01:19:20] o-o [01:19:20] That's not that [01:19:23] ok [01:19:31] That's a working /wiki/ but completely broken .php [01:20:03] ugh o-o [01:20:07] do i like... [01:20:10] :| [01:20:15] use a new index.php? [01:20:31] will taht help? [01:21:33] The strange part is index.php was working before [01:21:54] yea... [01:22:58] any idea how i can fix this Dantman [01:23:18] When in doubt, comment out... [01:23:25] lol [01:23:29] comment out what? T_T [01:23:30] Wild shot... but try removing the `try_files $uri $uri/ =404; # Don't let php execute non-existent php files` [01:23:43] metalmine, Random things until things start working again ;) [01:23:49] oh gosh [01:23:51] ok [01:24:27] It's a tried and true backup debug technique for development [01:24:30] New review: Katie Horn; "I'm about halfway through a review here, and my most major concern is that we can't deploy this AND ..." [mediawiki/extensions/DonationInterface] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/23027 [01:25:35] Dantman, nope. it's not taht line [01:25:38] Can't figure it out any other way? Start commenting things out till things work... you can start to narrow down which part of the code is causing the issue and improve your understanding of the situation until you know what's wrong. [01:25:50] lol [01:26:17] metalmine, Put it back and try commenting out the location /wiki and location @thumb { blocks [01:26:35] kk [01:26:49] Change merged: Tim Starling; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25605 [01:26:52] metalmine, Btw when we're done we should put most of those other rules back [01:27:02] why? [01:27:03] metalmine, Half of them are security related [01:27:07] ah ok [01:27:08] i see [01:27:59] metalmine, e.g. some of them stops php files from being executed in /images while another stops people from seeing your deleted images. [01:28:13] lol [01:28:17] we can worry about tha AFTER it all works [01:32:08] derp :( [01:42:48] Is there any script or extension out there that automatically caches all of mediawiki's php files (b/c I can't figure out how to use apc)? [01:45:35] no [01:46:05] you should figure out how to use APC [01:49:18] do u have any suggestions where i should start learning it, because the php manual isn't clear enough for me? [01:49:55] you just install it like any other PHP extension [01:50:03] what is the problem you are having with it exactly? [01:51:22] i don't have any problem with it, I just don't have any idea how to run the apc commands, where to run them, and so on? whatever i'll try to figure it out from google? thanks anyway [01:53:03] Ike: https://www.mediawiki.org/wiki/Manual:Cache [01:53:07] That might be somewhat helpful. [01:53:46] what OS are you on? [01:53:53] mac [01:54:08] whatever i don't want to waste your time [01:54:24] suit yourself [01:59:48] * Aaron|laptop watches rename(), fsync() spam his strace of ubiquity [02:00:00] maybe I should try ext3 [02:00:11] New review: Katie Horn; "Actually: I take it back. I understand that the functionality I was trying to preserve doesn't even ..." [mediawiki/extensions/DonationInterface] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/23027 [02:00:25] aaron|laptop: instead of what?! [02:00:31] ext4 [02:00:34] eh [02:00:36] hi Aaron|laptop [02:00:39] XFS ! [02:00:46] domas: anyway, installer is caught in a spin loop in poll() [02:00:52] I don't suppose you could test https://gerrit.wikimedia.org/r/#/c/23644/ against swift for me? [02:00:56] * Aaron|laptop is trying to install kubuntu 12.04 [02:01:26] aaron|laptop: gdb \o/ [02:01:53] the installer is python btw [02:02:32] TimStarling: well if it works with FSBackend it should work with Swift in theory ;) [02:02:50] sure [02:03:02] because swift and a local filesystem are basically the same [02:03:13] well, the interface is [02:03:30] which has unit tests and what not [02:03:40] domas: maybe I'll try vanilla ubuntu [02:04:08] or debian or something else, gah [02:04:13] you know, robla tells me that faidon has discovered some problems with swift and thinks that maybe we should abandon it and use some other file storage system [02:04:24] * Aaron|laptop is tired of futzing with this installer [02:04:48] TimStarling: I was talking to asher/ct about using netapps to replace ms7 [02:05:13] timstarling: :( [02:05:18] it seems to me that the problem would have to be pretty severe to want to throw away a year of MW work [02:05:36] well, maybe other system can use similar interface! [02:05:41] you could use HDFS! [02:05:42] one day ceph will be ready and we can set up a swift rados gateway [02:06:03] or so we hope...asher suggested even reconsidering mogilefs or something [02:06:18] GridFS! [02:06:31] did you see Artur's ranting about GridFS? :) [02:06:37] is the main issue replication support? [02:06:48] anyway, a ceph rados gateway would be a straight drop in, same MW code [02:07:00] that would be sweet, though ceph is still in 0.xx [02:07:18] domas: nope [02:08:10] https://fr.twitter.com/crucially/status/228739246154989568 [02:08:11] New review: Katie Horn; "The gateway definition looks a little thin to me. Also, there's no recurring logic, and we really, r..." [mediawiki/extensions/DonationInterface] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/23027 [02:08:12] ;-) [02:08:28] domas: maybe the installer is not truly hanging, but just waiting on dpckg doing it's 5 million fsyncs? [02:08:38] aaron|laptop: maybe! [02:08:42] strace -f is always a good idea [02:08:48] but the bug about the fsync regression said it was only 2x worse [02:08:55] so that doesn't quite match up [02:08:57] why do you observe fsyncs [02:09:02] only cowards use proper fsync [02:09:16] probably do to rename semantics in ext4 and people worried about atomicity [02:09:20] or people who have SSDs ;-D [02:09:26] <- [02:09:29] :((( [02:09:43] :( [02:10:24] what is the main problem with swift exactly? [02:11:02] TimStarling: well lots of stuff sucks but is tolerable, I think it's just the replication issue mainly [02:11:17] TimStarling: naming? [02:11:22] lol [02:12:12] well, people say it is slow, but I haven't seen the benchmark results [02:12:27] from my perspective, it does way more i/os than it should [02:12:29] but thats just me [02:12:29] 2 thumbs/second [02:12:41] I'm used to wrong standards [02:12:51] not up to domas's high standards ;) [02:12:57] is that I/O limited or CPU limited? [02:13:15] probably the former, getting a new connection and slow starting for each file [02:13:27] faidon traced this stuff, you could talk to him more about it [02:13:35] well, I think that to start the file it has to do most of metadata work already [02:13:54] and metadata in swift is opposite to most of work done in the industry for past fifty years or so [02:13:57] TCP then? [02:14:07] or is that actually opening the connection!?!? [02:14:22] well, "slow connection" may also mean "not enough workers available" [02:15:06] oh well, I didn't look at it for half a year [02:15:08] domas: new tcp connection/handshake [02:15:10] or a quarter [02:15:37] that's latency rather than throughput though [02:15:56] it's also gives no meaningful errors with problems and just doesn't copy have the stuff when things fail [02:16:08] I suppose faidon could rewrite the python code there [02:16:31] domas: still fsycing c header files in /src [02:16:37] whhhhhyyy? [02:16:56] aaron|laptop: disable barriers [02:16:59] enable write cache on disks [02:17:01] \o/ [02:17:05] ergh, disk [02:17:13] lack of error handling sounds a bit more serious than replication, in my opinion [02:17:22] touches more code, so harder to fix [02:17:35] faidon only new stuff failed when he saw the counts were off [02:17:37] more likely to require interface changes [02:17:53] of course all of these is after fixing a basic python syntax error in a main code path [02:18:51] domas: how do I disable those? [02:19:17] oohh.. doing sparc processor files now ;) [02:19:29] barriers=0 [02:19:44] or 'nobarrier' [02:19:46] thats a mount option [02:19:54] mount -o remount,nobarrier / [02:20:03] (I haven't seen ext4 :) [02:20:10] fuck it I'm going to ext3 [02:20:12] (I just know that it enables barriers by default ) [02:20:18] well, just run that command [02:20:22] tell me if you observe any difference :) [02:21:01] more that 1 rename/sec would be nice [02:21:11] well, either get SSD or disable barriers [02:21:19] it is an SSD [02:21:20] if you want to play it safe, get ready to pay the cost, damnit [02:21:22] what? [02:21:39] thats a slow SSD then!!! ;-) [02:21:59] show 'iostat -x 1' [02:22:06] the whole reason I am re-installing is due to changing the drive [02:22:15] heh [02:22:25] [02:22:57] SSDs = end of my reign :( [02:23:47] I changed drives in my laptop just with rsync, I didn't reinstall [02:24:02] it took me a while to get hibernate working again [02:24:28] apparently the initrd stores the UUID of the swap partition that holds the hibernate image [02:24:33] yeah I read about rsync and heard it was evil...or maybe that was dd [02:25:30] I can imagine dd being evil [02:25:39] *shrug*, I just drag&drop stuff over network [02:25:41] when I get a new laptop [02:25:46] \o/ [02:25:48] better be wifi [02:25:52] hate that cable clutter! [02:26:07] lol [02:26:32] with dd you get the same old fragmented filesystem that you started with [02:27:08] right, because fragmentation on SSDs is killer [02:27:24] yeah ok [02:48:41] domas: still seeing the fsyncs, though it's somehow faster [02:48:42] still too slow [02:49:09] did you pay $25 for your SSD? [02:49:49] did you enable trim support on your filesystem? [02:49:57] New patchset: Santhosh; "(bug 39381) Add Javanese font to WebFonts" [mediawiki/extensions/WebFonts] (master) - https://gerrit.wikimedia.org/r/24403 [02:49:58] how much free space you got?! [02:50:06] * Aaron|laptop tries to install systat [02:50:20] "Could not resulve archive.ubuntu.com" [02:50:31] * Aaron|laptop siiiiighs [02:50:43] New review: Santhosh; "Correctly compressed fonts" [mediawiki/extensions/WebFonts] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/24403 [02:52:25] * Aaron|laptop fixes that [02:52:45] domas: heh, dpkg is "locked by another process"...no surprise [02:55:03] domas: sdb has w_wait around 223 [02:55:13] * Aaron|laptop looks up what units that's in [02:55:33] %100 util [02:56:39] what is w_wait [02:58:40] man :) [02:59:13] 03(mod) "cols" preference is redundant and should be removed - 10https://bugzilla.wikimedia.org/24430 (10Chad H.) [02:59:27] basically time to serve average writes (in ms) [03:16:46] New patchset: PleaseStand; "(bug 40384) Move width/height from button to img" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25606 [03:20:46] New patchset: Ori.livneh; "Changes to event data format" [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/25607 [03:25:11] 03(FIXED) HTML validation: Attribute width/height not allowed on element button at this point - 10https://bugzilla.wikimedia.org/40384 +comment (10PleaseStand) [03:29:24] hi all, is there a way in media wiki wherein those namespaces, special pages will not be displayed in url?, i mean a clean url will be dsiplayed on the address bar , like when loggin in, there is no Special:Userlogin on the url, [03:29:26] ?? [03:35:42] 03(mod) Add namespace name "Category" to categories listed at [[Special:UnusedCategories]] - 10https://bugzilla.wikimedia.org/40450 +comment (10Chad H.) [03:52:20] hey Dantman, the index.php is working perfectly :/ [03:52:25] so it is something with the configs [03:52:26] definintely [03:58:17] New patchset: Ori.livneh; "Repository clean-up" [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/25608 [04:00:49] hi all, [04:05:35] New patchset: Ori.livneh; "Repository clean-up" [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/25608 [04:28:40] New review: Katie Horn; "A couple minor changes, one of which won't make sense until after another rebase. Nearly there!" [mediawiki/extensions/DonationInterface] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/20467 [04:29:52] Change merged: Katie Horn; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/24646 [04:33:52] hi all, is there a way to hide the actual content of the url? [04:33:59] when a user login to the site.. it add this to the url /view/Special:UserLogin which i dont want to be seen.. how can i do that [04:34:01] ??? [04:34:57] Change merged: Katie Horn; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/24642 [04:37:06] 03(mod) Parsoid: Possible performance regression on latest master - 10https://bugzilla.wikimedia.org/40577 +comment (10Gabriel Wicke) [04:37:39] New review: Spage; "Sure, handle version if and when needed." [mediawiki/extensions/E3Experiments] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/25607 [04:37:41] Change merged: Spage; [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/25607 [04:38:19] What is the best way to create multiple user accounts at one time with MW 1.17? [04:38:19] Change merged: Katie Horn; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/24641 [04:50:57] deo, no... [04:51:11] hey Dantman ??? [04:51:17] can't I? [04:51:28] no [04:51:39] That's the title... it's there.... period [04:51:41] i dont want that Special:UserLogin to be seen on the url [04:51:52] sorry.. not to be seen rather [04:52:13] Find a different CMS if you want that kind of obsession with the url. [04:52:31] cant it not be redirected? :( [04:53:02] ...that's the title of the login page... if that is not there it is not a login page. [04:54:31] yeah i know.. but its there a way not to be displayed ? like shor URL ? [05:28:43] New patchset: Ori.livneh; "Update Vector to 7524e5d" [mediawiki/core] (wmf/1.20wmf12) - https://gerrit.wikimedia.org/r/25609 [05:31:26] Change merged: Ori.livneh; [mediawiki/core] (wmf/1.20wmf12) - https://gerrit.wikimedia.org/r/25609 [05:41:58] Dantman, finally fixed: wiki.lightenedblade.com [05:42:22] how can i export all the templates btw? [05:42:49] I can't remember if our export script had a namespace filter [05:43:00] metalmine, You should probably show me the final config [05:43:01] hm o-o' [05:43:04] ok here [05:43:10] server { [05:43:10] listen 80; [05:43:10] server_name lightenedblade.com www.lightenedblade.com; [05:43:10] root /home/metalmine/public_html/lightenedblade/; [05:43:11] location / { [05:43:13] autoindex on; [05:43:15] index index.html; [05:43:16] } [05:43:19] location ~ \.php$ { [05:43:23] fastcgi_pass unix:/var/run/php-fpm/php-fpm.sock; [05:43:24] *facepalm* [05:43:28] fastcgi_index index.php; [05:43:30] fastcgi_param SCRIPT_FILENAME $document_root$fastcgi_script_name; [05:43:32] autoindex on; [05:43:34] index index.php; [05:43:36] include fastcgi.conf; [05:43:38] } [05:43:43] } [05:43:45] server { [05:43:47] listen 80; [05:43:49] server_name wiki.lightenedblade.com; [05:43:53] root /home/metalmine/public_html/lightenedblade/w/mediawiki-1.19.2/; [05:43:54] metalmine: pastbin would be better, I think :P [05:43:58] [05:44:00] location / { [05:44:02] autoindex on; [05:44:04] index index.php; [05:44:06] } [05:44:09] location ~ \.php$ { [05:44:13] fastcgi_pass unix:/var/run/php-fpm/php-fpm.sock; [05:44:15] fastcgi_index index.php; [05:44:17] fastcgi_param SCRIPT_FILENAME $document_root$fastcgi_script_name; [05:44:19] include fastcgi.conf; [05:44:23] } [05:44:28] } [05:44:30] i wrote the second block [05:44:32] :D [05:44:34] by hand :D [05:44:36] what? [05:44:38] i ijust learned all this today :| [05:44:43] impretty proud that it's working [05:44:45] OH TAHT PART [05:44:47] sorry [05:44:49] T-T [05:44:53] * metalmine headwalls [05:44:58] https://gist.github.com/3798117 [05:45:00] tehre [05:45:02] derp [05:45:04] QueenOfFrance, i like your id [05:45:49] Dantman, you ok bro? [05:46:15] metalmine, ...you pasted into the channel... hence *facepalm* [05:46:34] metalmine, You're kind of all the way at the very start now... And now your server is back to executing php in /images. [05:46:46] haha yea.... [05:46:54] HOWEVER [05:47:03] it has short url and linked to wiki.lightenedblade.com [05:47:06] :P [05:47:21] so now we can talk about all that security stuff [05:49:28] ^_^ [05:49:38] now how do i export all the templates [05:53:34] 03(mod) jquery.footHovzer module should not cause a scroll bar to appear if total content is shorter than window height - 10https://bugzilla.wikimedia.org/36273 (10Krinkle) [05:53:54] metalmine: You shouldn't ping individual people unless they're the only one who can help [05:54:23] sorry mark [05:54:24] metalmine: And even if you do, rule #0 still applies: Ask the question, don't ask if you can or ask if anyone is around who might know the answer :) [05:54:44] right :P the unspoken irc rule [05:54:47] how could i have forgotten [05:55:09] *nod* [06:06:09] Hi [06:06:19] how do I disable the discussion tab? [06:07:00] creeper100: What does the Mediawiki FAQ say about that? [06:07:15] what the mediawiki faq [06:09:26] tale: where is mediawiki faq [06:09:55] creeper100: look for this in this page http://www.mediawiki.org/wiki/MediaWiki [06:10:34] tale: i pressed ctrl f and tried faq and theres nothing [06:11:16] tale: ok got it thanks [06:11:47] ok how to i remove "main page" from the main page? [06:12:33] New patchset: Tim Starling; "(bug 39674) Fixed loading User from session when hook aborts." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21546 [06:12:38] Change merged: Tim Starling; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21546 [06:25:49] New review: Tim Starling; "Just set $wgUsePathInfo explicitly in the default LocalSettings.php based on an environment check, l..." [mediawiki/core] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/17404 [06:25:56] 03(NEW) formatnum magicword - 10https://bugzilla.wikimedia.org/40587 normal; Wikimedia: General/Unknown; (vssun9) [06:26:17] is there a extension for a better editor? [06:26:30] like a graphical one like the one used on wikia? [06:30:32] !wysiwyg | creeper100 [06:30:32] creeper100: What You See Is What You Get editors allow you to create articles and see the text formatting without needing to Show Preview. A list of wysiwyg editor extensions may be found at . For some discussion, see . See also . [06:31:58] New patchset: Matthias Mullie; "Bug 39587 - Resolved - an exclusion filter or different weighting?" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/25611 [06:32:59] creeper100: What main page do you want to remove from the main page? [06:33:09] The title [06:34:01] creeper100: Does the FAQ say anything about that? [06:34:19] cant find the faq again [06:34:40] creeper100: That is too bad. [06:37:35] 03(mod) formatnum magicword - 10https://bugzilla.wikimedia.org/40587 +comment (10Raziman T V) [06:39:57] New review: Tim Starling; "Jeroen wrote: "Tim: you understand this class is meant to be derived from by base classes for tests ..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/16833 [06:59:00] 03(mod) 500k logo for Swedish Wikipedia - 10https://bugzilla.wikimedia.org/40582 +comment (10Ronnie) [07:03:01] New review: Tim Starling; "I don't really like the O(N^2) double loop to map sockets to clients in SquidPurgeClientPool::run(). " [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12243 [07:07:09] New review: Tim Starling; "MaxSem: no, I don't think it needs to be case- and #- sensitive. It just needs to use the localised ..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/12895 [07:08:51] 03(mod) 500k logo for Swedish Wikipedia - 10https://bugzilla.wikimedia.org/40582 +comment (10Dereckson) [07:10:27] New patchset: Siebrand; "Maintenance for ZeroRatedMobileAccess extension." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/25612 [07:11:14] Change merged: Siebrand; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/25051 [07:17:06] New review: Tim Starling; "You should not add $this->mDuringPreSaveTransform, you should use $this->ot['wiki'] like everything ..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/8784 [07:22:24] 03(FIXED) Don't list Special:ZeroRatedMobileAccess on [[Special:SpecialPages]] - 10https://bugzilla.wikimedia.org/40524 +comment (10Umherirrender) [07:32:04] New patchset: Siebrand; "Some love for WikiLove extension" [mediawiki/extensions/WikiLove] (master) - https://gerrit.wikimedia.org/r/25613 [07:34:03] New patchset: Siebrand; "Type hinting and use strict" [mediawiki/extensions/WikimediaShopLink] (master) - https://gerrit.wikimedia.org/r/25614 [07:38:24] New review: Tim Starling; "It looks fine to me, apart from the issues that Anomie found. It can be merged once they are fixed." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/8511 [07:48:13] 03(NEW) Special:LinkSearch cannot search with a port in the url - 10https://bugzilla.wikimedia.org/40588 normal; MediaWiki: Special pages; (umherirrender_de.wp) [07:50:37] 03(FIXED) AFT contributions entries are very ugly and confusing - 10https://bugzilla.wikimedia.org/38631 (10Matthias Mullie) [07:51:32] 03(FIXED) individual feedback page renders then disappears - 10https://bugzilla.wikimedia.org/39355 (10Matthias Mullie) [07:52:12] 03(FIXED) Talkpage link not appearing - 10https://bugzilla.wikimedia.org/39803 (10Matthias Mullie) [07:52:27] 03(FIXED) Centralised feedback page not visible. - 10https://bugzilla.wikimedia.org/40431 (10Matthias Mullie) [07:53:32] 03(FIXED) Feedback Page - Hide My Post is not tracked in Activity Log - 10https://bugzilla.wikimedia.org/39748 (10Matthias Mullie) [07:54:04] 03(FIXED) Resolved - an exclusion filter or different weighting? - 10https://bugzilla.wikimedia.org/39587 (10Matthias Mullie) [07:56:26] 03(FIXED) Add profiling to AFTv5 functionality - 10https://bugzilla.wikimedia.org/37847 (10Matthias Mullie) [07:57:59] 03(FIXED) Filter menu appears left-justified - 10https://bugzilla.wikimedia.org/38073 +comment (10Matthias Mullie) [08:02:34] 03(NEW) database error while running rebuildLocalisationCache.php - 10https://bugzilla.wikimedia.org/40589 normal; MediaWiki: Database; (amir.aharoni) [08:02:35] 03(mod) 1205: Lock wait timeout exceeded; try restarting transaction (tracking) - 10https://bugzilla.wikimedia.org/28499 (10Amir E. Aharoni) [08:02:37] 03(FIXED) Help Tooltip Bug on IE7 for Feedback forms - 10https://bugzilla.wikimedia.org/33125 +comment (10Matthias Mullie) [08:04:17] 03(NEW) Ogg files stammer - 10https://bugzilla.wikimedia.org/40590 major; Wikimedia: General/Unknown; (juandevojnikov) [08:16:21] New patchset: Siebrand; "Add profiling." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/25615 [08:18:17] New review: Logicwiki; "See comment" [mediawiki/extensions/UniversalLanguageSelector] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/25481 [08:23:32] New patchset: Siebrand; "Minor JS updates." [mediawiki/extensions/wikihiero] (master) - https://gerrit.wikimedia.org/r/25616 [08:25:55] New review: Jalexander; "looks good, verified locally" [mediawiki/extensions/WikimediaShopLink] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/25614 [08:25:55] Change merged: Jalexander; [mediawiki/extensions/WikimediaShopLink] (master) - https://gerrit.wikimedia.org/r/25614 [08:29:02] New patchset: Siebrand; "CSS cleanup." [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/25617 [08:29:58] Change merged: Nikerabbit; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/25479 [08:30:59] 03(FIXED) the star marker overlaps with the word "FEATURED" in an RTL environment - 10https://bugzilla.wikimedia.org/36327 (10Matthias Mullie) [08:33:07] New patchset: Eranroz; "Watchlist grouping" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/16419 [08:34:01] New review: Eranroz; "PS10: Rebase" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/16419 [08:35:19] New review: Siebrand; "No can has easter egg like stuffs? (See SpecialVersion.php)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25487 [08:54:07] New review: Spage; "I went to all the trouble of fetching refs/changes/84/25484/1 and installing it, and there's no Veri..." [mediawiki/extensions/PostEdit] (master) C: 0; - https://gerrit.wikimedia.org/r/25484 [09:08:17] New patchset: Siebrand; "Remove unused variable and other small updates." [mediawiki/extensions/WebFonts] (master) - https://gerrit.wikimedia.org/r/25618 [09:11:48] New patchset: Siebrand; "Replace deprecated methods." [mediawiki/extensions/VipsScaler] (master) - https://gerrit.wikimedia.org/r/25619 [09:14:39] New review: Siebrand; "Niklas reported the hook was taking 22ms on twn. Added some profiling to see what's causing this. Hy..." [mediawiki/extensions/UniversalLanguageSelector] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/25615 [09:20:00] 03(mod) 500k logo for Swedish Wikipedia - 10https://bugzilla.wikimedia.org/40582 +comment (10Nemo_bis) [09:25:14] New review: Eranroz; "when wllimit isn't specified to getLimitOffset, than rclimit is used as the deafult option. I don't ..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/17216 [09:32:54] Change abandoned: Jeroen De Dauw; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/16833 [09:33:23] Change abandoned: Jeroen De Dauw; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/14346 [09:52:28] New review: btongminh; "Language::formatTimePeriod() should be documented to output HTML rather than text, and this should a..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/25527 [09:56:14] New review: Nemo bis; "Ok, I think I'll give up with the HTML entities in the source given that it seems to be mostly Europ..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/25527 [09:58:37] New review: btongminh; "Well, I'm not asking for extensive documentation, but just changing the doxygen return comment "@ret..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/25527 [10:11:50] 03(mod) Non-included tables break parser - 10https://bugzilla.wikimedia.org/35476 (10Bachsau) [10:22:45] 03(NEW) Genitive form of names in the Slovene language - 10https://bugzilla.wikimedia.org/40591 normal; MediaWiki: Internationalization; (dejan.papez) [10:29:50] 03(mod) EditEntity.php:attemptSave(): check token (1) - 10https://bugzilla.wikimedia.org/40558 (10jeblad) [10:31:06] New patchset: Eranroz; "Watchlist grouping" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/16419 [10:33:10] 03(mod) Use http get with https whenever possible (2) - 10https://bugzilla.wikimedia.org/40550 (10jeblad) [10:34:52] 03(mod) Check insertDefaultSites in Utils.php (2) - 10https://bugzilla.wikimedia.org/40551 (10jeblad) [10:36:04] 03(mod) Check permissions on read (3) - 10https://bugzilla.wikimedia.org/40557 (10jeblad) [10:37:07] New patchset: Jeroen De Dauw; "fix name of test class" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/25620 [10:37:49] New patchset: Eranroz; "Watchlist grouping" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/16419 [10:38:11] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/25620 [11:17:32] New review: Inez; "Except the bug that Trevor already mentioned it works well for adding annotations, however it comple..." [mediawiki/extensions/VisualEditor] (master) C: -1; - https://gerrit.wikimedia.org/r/25597 [11:24:40] 03(mod) Enable Extension:Education Program on English Wikipedia (with new user rights configuration) - 10https://bugzilla.wikimedia.org/40477 +comment (10Jeroen De Dauw) [11:25:57] New patchset: Jeroen De Dauw; "Added tests for numberValue" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25621 [11:25:59] 03(mod) Update Sanitizer to support replacement of whole elements instead of just attributes. - 10https://bugzilla.wikimedia.org/40579 +comment (10TMg) [11:29:37] 03(mod) Review Wikibase Repo extension for deployment - 10https://bugzilla.wikimedia.org/38822 +comment (10Daniel Werner) [11:33:46] 03(NEW) Chrome zoom wraps line when unnecessary - 10https://bugzilla.wikimedia.org/40592 normal; MediaWiki: Interface; (rstockbower) [11:34:14] 03(mod) Chrome zoom wraps line when unnecessary - 10https://bugzilla.wikimedia.org/40592 +comment (10Rian Stockbower) [11:39:09] News::: There is a chance to grab a free Mediawiki eBook this weekend .. the website is a bit overloaded so hang in there if things are a bit slow (it's not your fault) .. Here it is http://www.packtpub.com/news/packt-publishing-reaches-1000-it-titles-and-celebrates-open-invitation [11:40:46] Just do a search for Mediawiki (3 books) and remember the Golden Rule .. In order to share these book please use a false name/address and share the scan on this and other channels FOR ALL ! [11:44:16] New patchset: Matthias Mullie; "Bug 40584 - Feedback Page: Add a checklist in Oversight Request flyout" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/25622 [11:49:22] 03(mod) Feedback Page: Add a checklist in Oversight Request flyout - 10https://bugzilla.wikimedia.org/40584 +comment (10Matthias Mullie) [11:51:24] 03(mod) VIPS out of memory on large (>100 Mpx) non-progressive JPEG - 10https://bugzilla.wikimedia.org/32721 +comment (10John Cupitt) [11:57:10] 03(mod) Set up and test the pretty URLs for Wikidata (5) - 10https://bugzilla.wikimedia.org/40389 (10silke.meyer) [11:58:33] 03(mod) Check permissions on read (3) - 10https://bugzilla.wikimedia.org/40557 (10jeblad) [12:01:50] what do these numbers in parentheses mean? [12:01:58] like (3) and (5) above [12:03:50] New patchset: Jeroen De Dauw; "Added auqntityValue" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25623 [12:03:50] New patchset: Jeroen De Dauw; "Added getters to QuantityValue" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25624 [12:03:50] New patchset: Jeroen De Dauw; "Added getValue to stringValue and numberValue" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25625 [12:07:39] 03(mod) Don't use hacks to replicate a browser function, either let align="" pass through or not; in HTML5 - 10https://bugzilla.wikimedia.org/40329 +comment (10TMg) [12:10:54] 03(NEW) Split single-sign-on account creation so users who disagree with labs account conditions can get Git access - 10https://bugzilla.wikimedia.org/40593 normal; Wikimedia: Git/Gerrit; (rainerrillke) [12:12:08] Change merged: Mwjames; [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/25018 [12:12:09] Change merged: Mwjames; [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/24773 [12:17:52] 03(mod) Split single-sign-on account creation so users who disagree with labs account conditions can get Git access - 10https://bugzilla.wikimedia.org/40593 +comment (10Rainer Rillke @commons.wikimedia) [12:20:07] New patchset: VitaliyFilippov; "Use newer tooltipAndAccesskeyAttribs function instead of deprecated ones." [mediawiki/extensions/Drafts] (master) - https://gerrit.wikimedia.org/r/25626 [12:20:07] New patchset: VitaliyFilippov; "Fix for PHP 5.4: add & to function prototype" [mediawiki/extensions/Drafts] (master) - https://gerrit.wikimedia.org/r/25627 [12:20:08] New patchset: VitaliyFilippov; "Always display user's drafts on the edit form." [mediawiki/extensions/Drafts] (master) - https://gerrit.wikimedia.org/r/25628 [12:20:08] New patchset: VitaliyFilippov; "Fix a bug: drafts didn't show up when creating new pages" [mediawiki/extensions/Drafts] (master) - https://gerrit.wikimedia.org/r/25629 [12:29:57] 03(mod) Add editbugs user right to legitimate Bugzilla accounts - 10https://bugzilla.wikimedia.org/40497 +comment (10Sumana Harihareswara) [12:32:09] 03(NEW) Get rid Wikipedia-Specific code - 10https://bugzilla.wikimedia.org/40594 normal; MediaWiki extensions: WikidataRepo; (daniel.kinzler) [12:38:36] hey sumanah [12:38:41] hi DanielK_WMDE [12:39:21] DanielK_WMDE: how is your Friday? [12:41:10] DanielK_WMDE: I think Calming Manatee may be the Mr. Rogers of the internet http://calmingmanatee.tumblr.com/post/25631581265/manatees-guide-to-liking-yourself-more-because-you-are [12:43:32] hi sumanah [12:43:35] hi aude [12:49:01] 03(mod) Review Wikibase Repo extension for deployment - 10https://bugzilla.wikimedia.org/38822 +comment (10Daniel Kinzler) [12:53:20] Change merged: Jens Ohlig; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25495 [12:55:43] 03(mod) disable update.php on beta - 10https://bugzilla.wikimedia.org/37941 +comment (10Chad H.) [13:03:43] Change merged: Matthias Mullie; [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/25604 [13:05:03] New patchset: John Erling Blad; "(Bug 40558) Make token checks explicit in EntiyEdit::attemptSave" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25630 [13:10:19] New patchset: Liangent; "Show redirects correctly on diff pages." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25631 [13:13:43] New review: au; "Looks like a sensible fix to bug 33210." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/8335 [13:19:28] 03(mod) webtools: Setup up webtools.wmflabs.org - 10https://bugzilla.wikimedia.org/40519 +comment (10Tim Landscheidt) [13:35:58] 03(mod) TranslatorSignup: please create a "current settings" form in the page as well as an "unsubscribe" button - 10https://bugzilla.wikimedia.org/39503 +comment (10Marco Aurelio) [13:41:44] New patchset: Nischayn22; "New Validator classes for Geo shapes" [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/25632 [13:56:21] I didn't realize that WikiEditor is *this* awful, at least on a 1.16.5 instance where users can't turn it off >_< [13:57:45] ashley: I of course ask: 1.16.5? [13:58:34] lazy folks are lazy; I'd update it if I could, but my sysadmin access to this particular project was revoked some years ago due to inactivity (and I can't blame the folks who did that) [14:00:15] <^demon> ashley: Which project? [14:01:09] a small-scale Finnish wiki about a comic series [14:02:58] 03(FIXED) User::load() does not account for failure to load from session. - 10https://bugzilla.wikimedia.org/39674 +comment (10Tyler Romeo) [14:05:36] ok, today is mega-writing day. personal blog entry: posted. GSoC blog entry: finishing it up, I hope [14:12:25] oh, a new Calibre is out [14:13:37] Lydia_WMDE: My latest blog entry http://www.harihareswara.net/sumana/2012/09/28/0 is based on the time I told you about "Almost Wikipedia", Mako Hill [14:13:40] 's research [14:24:56] guillom: quick question. When you were suggesting using or linking to a graphic to illustrate TranslateSVG and you mentioned the kidney picture what did you mean? [14:25:54] sumanah: the example you linked to was a SVG picture of a kidney. I thought you could include it into the blog post, and explain in the caption how it would be improved by the extension. [14:26:00] AH [14:26:17] how did I miss that. [14:26:20] I'm sorry, thanks [14:26:22] np [14:26:35] I was like "when did Harry upload a pic of a kidney" [14:26:44] sumanah: I'm happy to answer other questions today and publish your post if it's ready before I go to bed. [14:26:46] (the answer: not recently!) [14:27:03] guillom: I'm fixing it up now and will hit publish myself; thanks for your fixes & suggestions [14:27:15] sumanah: ok [14:31:40] 03(mod) Toolbar is appearing in my userspace - 10https://bugzilla.wikimedia.org/39453 (10the wub) [14:34:53] okay, boys and girls - 20% time. any suggestions how can I help YOU, volunteers? my initial plans were to work on 1.20 tarball blockers, but your suggestions can turn me in a different directions:) [14:35:53] MaxSem: go through changesets pending review [14:43:49] MaxSem - since you're asking for suggestions, could you update your GSoC analysis page? :) [14:44:05] sure [14:45:32] MaxSem - by the way, since you created that page, someone discovered that the "video" project, from the first year, was in fact successful. [14:45:49] linkie? [14:46:05] what is it now, then? [14:47:37] New patchset: MathiasLidal; "hasTitle/hasText must also check for null, as this is what you get when adding map locations without any title or text. This also makes the label parameter work properly as a default title." [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/25634 [14:48:27] MaxSem - https://www.mediawiki.org/wiki/Summer_of_Code_Past_Projects#Video_display [14:48:53] It's part of OggHandler, apparently. [14:49:12] heh, it used to say a different thing:) [14:50:10] Yes it did. [14:52:25] New patchset: Reedy; "Add RELEASE-NOTES for g25605" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25635 [14:54:13] guillom: so, maybe you can help me with this: I am trying to upload a smaller-sized version of Realtime_collab_from_1000_feet.svg https://www.mediawiki.org/wiki/File:Realtime_collab_from_1000_feet.svg so that it can be on mediawiki.org and associated with the correct file [14:59:51] Never mind - I was able to shrink the existing one OK in WP, finally [15:04:07] ok, published [15:07:01] New patchset: Inez; "Create method ve.Range.isCollapsed() and added some tests for ve.Range class." [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/25636 [15:07:16] MaxSem: JeroenDeDauw Lydia_WMDE Nischayn22 Platonides qgil yuvipanda & Yaron I request that you check my blog entry for inaccuracies https://blog.wikimedia.org/2012/09/28/gsoc-students-reach-milestones/ [15:07:35] (but there is no obligation) [15:09:12] sumanah - nice! The only thing I don't really understand is the title of the post. [15:09:59] Yaron: well, they're not really DONE [15:10:05] Yaron: (glad you liked it overall!) [15:10:13] Yaron: so I thought "reach project milestones" was more accurate [15:11:02] Change merged: Reedy; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25635 [15:11:14] Well, it doesn't seem like milestones were really hit yet, for the most part... [15:11:26] Anyway, that's my comment. [15:11:33] I thank guillom for helping me improve the post - the images are way better now, thank you for convincing me that the MW logo was not really useful there :) [15:12:06] Glad I could help :) [15:12:40] sumanah Oh, actually, one other thing - "volunteer developer" seems weird to describe Markus. I'd suggest something like "head Semantic MediaWiki developer". [15:12:53] Yaron: I see what you mean, in reference to the original "what I aim to achieve" goals for each student. But each of them did at least hit *some* milestones.... and it's a little friendlier than just "they passed" [15:13:11] It certainly is friendly. [15:14:25] [updatehistory 698cb8a] Bring in 1.19 history, update 1.17 and 1.18 history too [15:14:26] 1 file changed, 955 insertions(+), 248 deletions(-) [15:14:29] New patchset: Reedy; "Bring in 1.19 history, update 1.17 and 1.18 history too" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25637 [15:14:47] Yaron: I have clarified that Markus is head Semantic MediaWiki developer (and a volunteer, because I do want to mention that) [15:14:54] thx for the suggestion [15:15:12] Change merged: Reedy; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25637 [15:15:24] Alright - it seemed a little too WMF-focused, but I guess that's the focus. :) [15:16:03] Yaron: I hear ya. :) It's tough. [15:16:16] Yeah, tradeoffs everywhere. [15:17:44] New patchset: Reedy; "Updates for MW 1.21" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25513 [15:19:35] New patchset: Reedy; "Updates for MW 1.21" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25513 [15:33:43] New patchset: Mwjames; "Split resource definitions into separate file" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/25639 [15:34:39] Wheeee [15:34:43] And that's 1.20 branched :D [15:36:04] :) [15:36:07] thanks Reedy [15:37:43] Change merged: Demon; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25513 [15:40:06] New patchset: Reedy; "Add $wgCopyUploadProxy to be used for copy uploads only." [mediawiki/core] (wmf/1.20wmf12) - https://gerrit.wikimedia.org/r/25640 [15:40:06] what's our release procedure in git? [15:43:00] a good question [15:45:25] 03(mod) Lohit Punjabi font problems - 10https://bugzilla.wikimedia.org/40473 +comment (10Zarienah Kaur) [15:52:08] chrismcmahon: Morning! Saw your announcement, looks great [15:52:49] hi marktraceur yeah, I'm pretty happy about beta labs, it's something I've wanted since I started here [15:53:19] chrismcmahon: Do you think it would be possible to do something like that, but automatically for new patchsets? Might be helpful for browsertesting in a lot of ways [15:53:44] (not having to proxy for crossbrowsertesting.com, running automatically via Jenkins, etc.) [15:53:58] Is there a mediawiki syntax or template which can compactly represent magnet links? [15:54:00] By this I mean, in the way http://exaple.com is shown as [1] ? [15:54:02] Thats lbracket http://example.com rbracket is shortened to lbracket 1 rbracket [15:54:04] just curous if there's anyway to allow magnetlinks to be treated the same way. At the moment, mediawiki URL syntax is // dependent, it seems [15:54:04] marktraceur: look at Special:Version on beta and see if it's doing what you want for patchsets [15:54:35] K [15:54:52] chrismcmahon: Did you mean to link to live commons UW? Or the beta? [15:55:12] marktraceur: RSN I'll be putting up a list of issues for automated browser testing on mw.o, including a discussion of client-server/VMs/OSs [15:55:24] crud, wrong link? /me looks, thanks [15:58:11] chrismcmahon: I suspect that beta automatically pulls newly merged patchsets--right? [15:58:56] marktraceur: yes, nightly as I understand it. we should and will eventually be doing that via builds in Jenkins, but right now it's a cron job [15:59:03] *nod* [15:59:31] marktraceur: hashar is working on a Jenkins/gerrit interface right now for that and many other purposes [15:59:58] chrismcmahon: My vision involves a Jenkins job on new, *unmerged* patchsets that (for example) creates a VM, sets up vanilla MW, and puts in the new version of the extension.....might be too intensive, though [16:00:19] marktraceur: step by step by step :-) [16:01:18] <^demon> Well we pretty much do that already in jenkins, just not in a fresh VM each time. [16:01:19] and I'm really glad that other people besides me are thinking along those lines too! [16:01:24] <^demon> That's where Zuul comes in. [16:01:27] chrismcmahon: My question is more like "will this sort of thing happen eventually" as opposed to "want it now" [16:03:07] marktraceur: what I want in the near future is to drive FF/IE/Chrome on VMs with beta (and maybe prod and maybe other envs) as targets. [16:03:39] * marktraceur shudders at spending time on supporting IE [16:03:49] gotta do what ya gotta do [16:03:52] lexein: i think you can define supported protocols somewhere [16:03:52] chrismcmahon: But that sounds great, I can't wait :) [16:04:20] lexein: https://www.mediawiki.org/wiki/Manual:$wgUrlProtocols [16:06:55] lexein: Also, off-topic, mailto: and news: will both generate links without '//' necessarily being in the link. It's configuration-dependent, of course :) [16:07:20] s/will/should/ (I don't want to promise things I can't support) [16:08:14] New patchset: Yaron Koren; "Removed GlobalFunctions.php, moved its contents to SemanticForms.php" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/25641 [16:09:26] <^demon> mailto: and news: has worked forever :) [16:09:33] New patchset: Reedy; "Update defaultbranch to point at REL1_20" [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/25642 [16:09:38] <^demon> So does gopher://, if you're interested :) [16:09:46] <^demon> Wonder if that gets turned proto-rel. [16:09:49] <^demon> That'd be funny. [16:09:51] Change merged: Reedy; [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/25642 [16:10:19] Change merged: Yaron Koren; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/25641 [16:10:27] thx - I should have said I'm trying to see if magnet links can be treated "right" on Wikipedia. MatmaRex - marktraceur -heh I forgot about mailto and news links! [16:10:30] New patchset: Reedy; "(bug 40306) Only convert align to float for table." [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/25643 [16:10:43] New patchset: Reedy; "(bug 39975) Fixed thumb_handler.php handling of /temp thumb urls." [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/25644 [16:10:43] * marktraceur gets too much happiness from seeing gopher:// URIs [16:10:56] New patchset: Reedy; "(bug 40098) Don't parse the section's name in the summary when creating a new section" [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/25645 [16:11:04] 03(mod) Chrome zoom wraps line when unnecessary - 10https://bugzilla.wikimedia.org/40592 +upstream; +comment (10Krinkle) [16:11:08] Oh, I def remember gopher links. The sometimes still work, some places. [16:11:10] New patchset: Reedy; "(bug 40380) inexistent language files are loaded" [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/25646 [16:11:23] New patchset: Reedy; "Worked around hash path inconsistency to unbreak stash file thumbs." [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/25647 [16:11:37] New patchset: Reedy; "[FileBackend] Fallback to $wgMemc for swift auth caching in cli mode." [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/25648 [16:11:52] New patchset: Reedy; "LivePreview: bind a delegated click event for #wpPreview/Diff" [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/25649 [16:12:07] New patchset: Reedy; "Add $wgCopyUploadProxy to be used for copy uploads only." [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/25650 [16:12:27] New patchset: Reedy; "Add RELEASE-NOTES for g25605" [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/25651 [16:13:50] marktraceur: I sorta know rohit khare [16:13:54] He works at Google now [16:15:30] Change merged: Reedy; [mediawiki/core] (wmf/1.20wmf12) - https://gerrit.wikimedia.org/r/25640 [16:16:00] sumanah: I'm sure it's relevant, but I'm not sure how? [16:16:42] marktraceur: Did you ever read 'who killed gopher'? [16:16:49] Nope [16:16:53] http://www.ics.uci.edu/~rohit/IEEE-L7-http-gopher.html [16:19:22] yuvipanda, how can you characterize your last year's GSoC project? can it be considered completed and useable? [16:21:28] sumanah: Interesting :) [16:23:21] 03(mod) Enable $wgAllowCopyUploads (upload by URL) - 10https://bugzilla.wikimedia.org/20512 +comment (10Sam Reed (reedy)) [16:23:26] Change merged: Krinkle; [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/25617 [16:23:28] 03(NEW) AFTv5 controls not selectable with tab - 10https://bugzilla.wikimedia.org/40595 normal; MediaWiki extensions: ArticleFeedbackv5; (thewub.wiki) [16:26:57] 03(mod) Unable to change any user preferences if existing wpwatchlistdays value is a non-integer - 10https://bugzilla.wikimedia.org/40585 +comment (10Richard Guk) [16:27:24] 03(mod) Password fields for account creation are marked as required when they are not - 10https://bugzilla.wikimedia.org/23769 +comment (10Richard Guk) [16:28:21] New review: Sumanah; "Thanks for the patch, Kevin. I hope you also find our developer hub and its resources useful" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/25606 [16:29:31] 03(mod) Wikimedia Commons needs a built-in image editor - 10https://bugzilla.wikimedia.org/37732 +comment (10Rainer Rillke @commons.wikimedia) [16:29:57] 03(mod) Unable to change any user preferences if existing wpwatchlistdays value is a non-integer - 10https://bugzilla.wikimedia.org/40585 normal->major (10Sumana Harihareswara) [16:34:15] New review: Siebrand; "This is probably not a good idea. THe files just have to be removed from RL, which was done in I57c3..." [mediawiki/core] (REL1_20); V: 0 C: -2; - https://gerrit.wikimedia.org/r/25646 [16:39:51] New review: Reedy; "I was just going on the list of things merged to 1.20wmf12 that seemed relevant." [mediawiki/core] (REL1_20); V: 0 C: 0; - https://gerrit.wikimedia.org/r/25646 [16:43:37] Yaron, I've updated https://www.mediawiki.org/wiki/User:MaxSem/GSoC_analysis [16:44:02] 03(NEW) Cannot download from HTTPS sources using copy upload via url-downloader - 10https://bugzilla.wikimedia.org/40596 normal; Wikimedia: General/Unknown; (sam) [16:44:20] MaxSem - cool, thanks! That's useful. [16:45:03] MaxSem - really, 7 projects from 2011 were completed and useable? [16:45:33] well, relatively useable [16:45:51] useable != not crap:P [16:46:24] Looking at it now, it seems to me like the number is 2-5, depending on how you count it. [16:47:13] 03(mod) SquidPurgeClient hangs on response from Squid Cache 2.7, or multiple entries in $wgSquidServers - 10https://bugzilla.wikimedia.org/37063 +comment (10Mark A. Hershberger) [16:47:42] Yaron, okay, let's discuss this in detail [16:48:42] MaxSem - okay; it looks like 3 of them (ArchiveLinks, Gadgets customization, SignupAPI) are currently unusable, but awaiting further handling. [16:48:57] 03(mod) LivePreview: styles added by extensions are missing - 10https://bugzilla.wikimedia.org/24134 +comment (10Mark A. Hershberger) [16:49:00] Maybe SelectionSifter too. [16:50:15] Gadgets is pretty useable. it wasn't merged for reasons other than quality [16:50:39] and will still be merged, unless the foundation decides to ditch RL 2.0 completely [16:50:48] Alright. [16:51:30] This is somehow turning into a really GSoC-y day... I guess it just turned out that way. [16:52:21] The "improved SMW search" thing is tricky to assess - it did go into the code, but I'm pretty sure no one has ever used it; it's disabled by default. [16:53:22] By the way, just to be clear, by "unusable" before, I just meant that users can't use the functionality; I wasn't commenting on code quality. [16:53:33] if it's in master, it's at least useable [16:54:25] Maybe your table needs a new column, like "Actually in use"? :) [16:54:48] WMF usage is all I care about [16:55:05] Alright, that's fair. [16:55:25] Hi, sumanah has encouraged me to have a look at https://wikitech.wikimedia.org/view/Pentaho - Is there a piece of Debian / Ubuntu server somewhere where I could get enough permissions (or sysadmin help) to get an instance running? [16:55:26] 03(NEW) Copy upload should record source of the image - 10https://bugzilla.wikimedia.org/40597 enhancement; MediaWiki: Uploading; (sam) [16:55:40] next, Signup API - as far as I know, it's not ready for WMF use, but it kind of works [16:55:51] ... and anybody interested in helping out on this? I promise not to leave the task until we have something up and running [16:55:54] Okay - I wouldn't know. [16:56:14] qgil_: Labs? [16:56:23] and since it isn't abandoned and still vaguely planned to be deployed on WMF, I can't call this project unsuccessful [16:56:56] RoanKattouw, my thought too, but I have never used it and I'm unsure whether that infra is also open to things beyond MediaWiki itself [16:57:18] qgil_: Anything vaguely Wikimedia-related is within scope [16:57:41] ok, I'll keep reading to learn how to make such request. Thank you! [16:58:41] Yaron, and ArchiveLinks was considered one of 2 most successful last year's projects (by Sumana/platform) [16:58:57] Alright. [17:00:12] 03(mod) Split single-sign-on account creation so users who disagree with labs account conditions can get Git access - 10https://bugzilla.wikimedia.org/40593 +comment (10Ryan Lane) [17:00:38] RoanKattouw, should I just make the request at http://deployment.wikimedia.beta.wmflabs.org/wiki/Global_requests (I'm a free-form dude but the free-form of that page baffles me) :) [17:01:48] qgil_: No, that's the deployment-beta project. You should request your own project, in which you can then create VMs. Documentation for this exists on labsconsole.wikimedia.org [17:02:02] 03(NEW) [Regression] jquery.localize tests are failing in IE6-8 - 10https://bugzilla.wikimedia.org/40598 blocker; MediaWiki: JavaScript; (krinklemail) [17:08:20] thanks RoanKattouw [17:11:21] 03(NEW) Hiding user of latest unflagged page revision causes it to become unrevievable - 10https://bugzilla.wikimedia.org/40599 major; MediaWiki: Revision deletion; (matma.rex) [17:12:29] 03(mod) Hiding user of latest unflagged page revision causes it to become unrevievable - 10https://bugzilla.wikimedia.org/40599 +comment (10Bartosz Dziewoński) [17:14:45] 03(mod) RevisionDeleted fails on latest revision - 10https://bugzilla.wikimedia.org/17543 +comment (10Bartosz Dziewoński) [17:14:48] 03(mod) Connectivity interferes with saved articles (saved pages do not work offline) - 10https://bugzilla.wikimedia.org/40013 +comment (10Jon) [17:15:23] New review: Siebrand; "@Sam: Yep. That would be best IMO." [mediawiki/core] (REL1_20); V: 0 C: -2; - https://gerrit.wikimedia.org/r/25646 [17:16:45] 03(mod) Split single-sign-on account creation so users who disagree with labs account conditions can get Git access - 10https://bugzilla.wikimedia.org/40593 +comment (10Ryan Lane) [17:17:08] Change merged: Bsitu; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/24989 [17:24:05] 03(mod) the first line of text does not appear - 10https://bugzilla.wikimedia.org/36928 (10bsitu) [17:25:38] Change merged: Bsitu; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/24394 [17:25:40] 03(NEW) Unreviewing sends a message to the page creator - 10https://bugzilla.wikimedia.org/40600 normal; MediaWiki extensions: PageTriage; (okeyes) [17:27:12] 14(WFM) generateSitemap.php / --server: add error message - 10https://bugzilla.wikimedia.org/34208 +comment (10Mark A. Hershberger) [17:28:10] New patchset: Kaldari; "Some love for WikiLove extension" [mediawiki/extensions/WikiLove] (master) - https://gerrit.wikimedia.org/r/25613 [17:32:24] New review: Jeroen De Dauw; "Overall this looks good to me, needs some cleanup before merge in master though. Or do you first wan..." [mediawiki/extensions/Maps] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/25632 [17:32:58] 03(NEW) 'Cancel' link when editing should be a button, and 'Editing help' link is silly - 10https://bugzilla.wikimedia.org/40601 minor; MediaWiki: Page editing; (zhorishna) [17:34:27] Change merged: Catrope; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/24026 [17:36:50] New review: Siebrand; "I cannot assess your CSS change, Ryan, but feel free to merge." [mediawiki/extensions/WikiLove] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/25613 [17:37:36] New review: Daniel Friesen; "@Tim What about the part where a wiki starts on a server that supports /index.php/Article by default..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/17404 [17:38:12] New patchset: Mwjames; "A general SMW/SRF Ajax printer class (DO NOT MERGE)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/25652 [17:39:30] 03(mod) Don't use hacks to replicate a browser function, either let align="" pass through or not; in HTML5 - 10https://bugzilla.wikimedia.org/40329 +comment (10Daniel Friesen) [17:40:24] Change merged: Kaldari; [mediawiki/extensions/WikiLove] (master) - https://gerrit.wikimedia.org/r/25613 [17:41:36] 03(mod) Split single-sign-on account creation so users who disagree with labs account conditions can get Git access - 10https://bugzilla.wikimedia.org/40593 +comment (10Rainer Rillke @commons.wikimedia) [17:42:10] Change merged: Jeroen De Dauw; [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/25634 [17:44:10] 03(NEW) Allow pipes within external links nested in template parameters - 10https://bugzilla.wikimedia.org/40602 normal; Parsoid: JS/tokenizer; (gwicke) [17:44:23] 03(mod) Allow pipes within external links nested in template parameters - 10https://bugzilla.wikimedia.org/40602 (10Gabriel Wicke) [17:45:41] 03(mod) Connectivity interferes with saved articles (saved pages do not work offline) - 10https://bugzilla.wikimedia.org/40013 +comment (10Jon) [17:48:52] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/25639 [17:51:43] 03(FIXED) invaliduser error is misleading - 10https://bugzilla.wikimedia.org/33781 +comment (10Ryan Kaldari) [17:55:55] salut tantek! [17:56:32] my friend tantek is having some issues with changePassword.php - anyone know who knows that stuff reasonably well? [17:57:16] in particular I'm seeing this error: [17:57:19] DB connection error: Access denied for user 'root'@'localhost' (using password: NO) (localhost) [17:57:31] https://www.mediawiki.org/wiki/Manual:ChangePassword.php btw [17:57:34] New patchset: Christian; "Insert Annotations" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/25597 [17:58:15] 03(mod) Review and deploy OnlineStatusBar extension - 10https://bugzilla.wikimedia.org/32128 (10Bartosz Dziewoński) [17:58:16] 03(NEW) "Purge user page everytime when you login or logout" option should be done away with - 10https://bugzilla.wikimedia.org/40603 normal; MediaWiki extensions: OnlineStatusBar; (matma.rex) [17:58:16] tommorris - indeed, read that a few times. [17:58:19] * tommorris squeaks happily that there is actually VisualEditor development. ;-) [17:58:50] the wiki works fine when used from the Web UI [17:59:15] so I'm not sure what's running differently when attempting to access it from the command line via scripts like changePassword.php [17:59:19] 03(mod) WikiLove tab "heart" icon is low-resolution - 10https://bugzilla.wikimedia.org/35334 normal->trivial (10Ryan Kaldari) [17:59:39] have tried looking through the code to figure out where it is getting that user 'root'@'localhost' and have had no success [17:59:59] has anyone seen this problem from changePassword.php before? [18:01:24] New patchset: Pgehres; "(FR #508) New Paypal adapter; validation before redirect" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/23027 [18:02:27] Hmm. Maintenance seems like a slightly confusing rats nest. I'd look further but I'm (a) not a MediaWiki dev and (b) family. ;-) [18:04:33] 03(mod) Split single-sign-on account creation so users who disagree with labs account conditions can get Git access - 10https://bugzilla.wikimedia.org/40593 +comment (10Ryan Lane) [18:04:54] 03(WONTFIX) Split single-sign-on account creation so users who disagree with labs account conditions can get Git access - 10https://bugzilla.wikimedia.org/40593 (10Ryan Lane) [18:07:17] 03(mod) url parsing does not recognize mixed case protocols - 10https://bugzilla.wikimedia.org/34939 (10jidanni) [18:10:37] New patchset: Mwjames; "A general SMW/SRF Ajax printer class (DO NOT MERGE)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/25652 [18:13:36] 03(mod) Add link to MediaWiki info action in UI - 10https://bugzilla.wikimedia.org/16362 (10Nemo_bis) [18:13:38] 03(mod) Safe permanent link to a page (e.g. using one of its history id) - 10https://bugzilla.wikimedia.org/21572 (10Nemo_bis) [18:15:11] New review: Jeroen De Dauw; "Do you also have an example of how exactly this would be used?" [mediawiki/extensions/SemanticMediaWiki] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/25652 [18:15:26] New review: Mwjames; "Patch#2 works with the SRF example printer" [mediawiki/extensions/SemanticMediaWiki] (master); V: 1 C: 0; - https://gerrit.wikimedia.org/r/25652 [18:15:27] New patchset: Kaldari; "(bug 36791) replace date fields with jquery.ui.datepicker" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/17975 [18:16:56] Change abandoned: Reedy; "Abandoning per Siebrand. Will merge 24457 instead" [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/25646 [18:17:20] 03(mod) Optionally enable urldecode for external links - 10https://bugzilla.wikimedia.org/25934 +comment (10Bartosz Dziewoński) [18:17:20] 03(mod) Skins improvement (tracking) - 10https://bugzilla.wikimedia.org/27292 (10Bartosz Dziewoński) [18:18:11] New patchset: Reedy; "Remove all custom plural rules and use CLDR plural rule system" [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/25670 [18:18:17] 03(mod) 500k logo for Swedish Wikipedia - 10https://bugzilla.wikimedia.org/40582 (10rasmus28) [18:18:27] New review: Kaldari; "We normally use ISO 8601 as the default date format, since that is the most universally understandab..." [mediawiki/extensions/CentralNotice] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/17975 [18:18:27] Change merged: Kaldari; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/17975 [18:18:28] New review: Reedy; "https://gerrit.wikimedia.org/r/25670" [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/25646 [18:18:56] Change merged: Reedy; [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/25650 [18:19:01] Change merged: Reedy; [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/25651 [18:20:14] 14(WFM) 500k logo for Swedish Wikipedia - 10https://bugzilla.wikimedia.org/40582 (10Nemo_bis) [18:21:11] I am very confused by what happens when I load this URL: http://en.wikipedia.org/wiki/\\ [18:21:55] Mirrors and smoke and stuff [18:22:13] I understand http://en.wikipedia.org/wiki// [18:22:26] I'm willing to accept that everything after http://en.wikipedia.org/wiki/ is a page title [18:22:34] but http://en.wikipedia.org/wiki/\\ just doesn't make any sense. [18:22:47] how do i learn about the forward-slash?! [18:22:52] on Chrome I End up at // [18:22:58] on FF I end up at Path (computing) [18:23:07] s/forward/back/ (my fault for the initial mistake, dschoon [18:23:30] hahaha [18:23:31] oh, huh [18:23:38] you're totally right. chrome is translating it? [18:23:43] Also, https://en.wikipedia.org/wiki/%5C [18:23:45] i bet to help poor windows users. [18:24:02] That actually looked like /wiki/\ in my Firefox address bar, but apparently it's really %5C [18:24:20] *nod* Firefox properly (?) loads "Path (computing) (redirected from \\)" for me [18:24:37] Opera "redirects" to https://en.wikipedia.org/wiki/// [18:24:42] I also get [[Backslash]] at /wiki/\ (which is really /wiki/%5C) [18:24:50] i guess in the semantics of URLs, \ is not an escape character. [18:25:08] Does this sound like a browser bug? [18:25:18] I think Chrome's behavior is intentional. [18:25:18] It sounds like Chrome and Opera are Doing It Wrong, yeah [18:25:27] ori-l: can i grab you when you are free? [18:25:39] i'm pretty sure it could be turned off for opera [18:25:43] RoanKattouw: There's a song in there somewhere, but maybe a bug report is more appropriate [18:25:45] and it might be only on windows [18:26:05] Opera normalizes all \ to / in address bar for me [18:26:07] MatmaRex: dschoon is on OS X, methinks [18:26:29] If you go to http:\\en.wikipedia.org\wiki\ in Chrome, it converts the slashes. [18:26:34] And yes, I'm OSX. [18:27:23] i can load https://en.wikipedia.org/wiki/%5C%5C perfectly well [18:27:47] Anyway. Mystery solved. [18:28:09] Computers suck? [18:35:03] 03(mod) Placeholder attribute of search box is not set until load - 10https://bugzilla.wikimedia.org/40464 +comment (10Mark A. Hershberger) [18:37:06] 03(mod) Legacy skins have no "cite this page" link - 10https://bugzilla.wikimedia.org/37879 +comment (10Bartosz Dziewoński) [18:37:06] 03(mod) Legacy skins do not support permalink and related links - 10https://bugzilla.wikimedia.org/37880 +comment (10Bartosz Dziewoński) [18:37:07] 03(mod) Article->PDF not available in classic skin - 10https://bugzilla.wikimedia.org/17693 minor->normal; +comment (10Bartosz Dziewoński) [18:37:15] MaxSem - I don't know if you're still looking into the GSoC analysis thing, but I think the SelectionSifter extension, at least, looks like a dead project. [18:37:38] boo, yuvipanda! [18:38:11] Yaron, I'll catch him and update the list based on his input [18:38:29] New review: Matmarex; "This fixes the following bugs for CologneBlue: bug 37880, bug 17693, bug 37879." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/25415 [18:38:43] somebody should totally start reviewing my rewrite. [18:39:04] Alright, cool - if there's something still going on with that project, that would be good news. [18:39:31] 03(mod) Unreviewing sends a message to the page creator - 10https://bugzilla.wikimedia.org/40600 normal->major (10Ryan Kaldari) [18:42:48] PHP good practices question: is there a recommended shorthand for "if ( $something->method()->anotherLongMethodName() ) { doStuffWith( $something->method()->anotherLongMethodName() ); }" ? [18:43:05] i could sabe the thing to some variable, but for the name to be descirptive, it would have to be about as long [18:43:23] and some people might have issues when i name it "$stuff" and reuse it all over [18:43:26] save* [18:43:53] 03(mod) $wgUsersNotifiedOnAllChanges should not send e-mail to user who made the edit. - 10https://bugzilla.wikimedia.org/33880 +comment (10Michael Jennings) [18:47:20] <^demon> MatmaRex: Code length doesn't matter. Better to be verbose and clear than short and unclear. [18:47:44] <^demon> I would much rather have $someLongVariableName than $foo. You can't grep for short unhelpful variable names :) [18:48:41] ^demon: consider this snippet: http://pastebin.com/WUtXDBiv [18:48:55] it's a part of CologneBlue code i've recently rewritten [18:49:13] how do i make it less ugly while not breaking MW's coding conventions? [18:49:31] <^demon> I don't see what's ugly about it. [18:49:47] hm. oh well then, i'll let it be. [18:49:55] <^demon> Really, you're micro-optimizing here. As long as the code's clear and it doesn't break conventions, it's no big deal. [18:50:11] <^demon> In this case, you're calling a function with low overhead, it's simple enough to just call it twice. [18:50:34] it's not about optimizing the speed, but the looks :) [18:50:52] 03(FIXED) Add Wikijunior namespace to Azerbaijani Wikibooks - 10https://bugzilla.wikimedia.org/31067 +comment (10Dereckson) [18:51:51] it looks even worse when extracted out of , http://pastebin.com/CwwXud0J [18:51:54] Anybody aware of any wiki page or previous discussion about measuring Wikimedia technical community and contributions? [18:52:17] While https://wikitech.wikimedia.org/view/Pentaho exists, this is a useless tool before you decide what data to feed it with. [18:52:24] $veryLongLongLongLongUnpracticalVariableName isn't too practical either [18:52:28] 03(VERIFIED) Add Wikijunior namespace to Azerbaijani Wikibooks - 10https://bugzilla.wikimedia.org/31067 +comment (10Dereckson) [18:52:41] I want to compile data that could be analyzed but I don't want to duplicate previous work [18:53:15] 03(FIXED) Windows 8 app: fix margins/padding on content area - 10https://bugzilla.wikimedia.org/40245 +comment (10Brion Vibber) [18:53:27] Also thinking whether the Analytics team would want to be involved / aware, and whether this is the right channel to reach them [18:55:30] New patchset: Jeroen De Dauw; "Updated permissions as per https://bugzilla.wikimedia.org/show_bug.cgi?id=40477" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/25693 [18:57:07] 03(mod) Enable Extension:Education Program on English Wikipedia (with new user rights configuration) - 10https://bugzilla.wikimedia.org/40477 +comment (10Jeroen De Dauw) [18:57:12] 03(mod) lang="" attribute shouldn't be set to an invalid language code - 10https://bugzilla.wikimedia.org/37564 +comment (10Mark A. Hershberger) [18:58:59] 03(mod) @import styles broken in modules that combine multiple stylesheets - 10https://bugzilla.wikimedia.org/35562 +comment (10Mark A. Hershberger) [18:59:22] New review: CSteipp; "Looks good, I've also been running this in test and links seem to all be generated correctly. All pa..." [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/25529 [19:00:29] 03(NEW) Give (potential) extension tags a high syntactical precedence - 10https://bugzilla.wikimedia.org/40604 normal; Parsoid: JS/tokenizer; (gwicke) [19:00:37] 03(mod) Give (potential) extension tags a high syntactical precedence - 10https://bugzilla.wikimedia.org/40604 (10Gabriel Wicke) [19:00:48] 03(mod) Implement a way to set user group permissions per namespace - 10https://bugzilla.wikimedia.org/29780 +comment (10Mark A. Hershberger) [19:02:02] 03(mod) [PrefixSearch] Namespace name part of prefix search query should not override given namespace id(s) - 10https://bugzilla.wikimedia.org/22773 +comment (10Mark A. Hershberger) [19:05:19] 03(mod) Use separate log_action for patrol action of autopatrolled edits - 10https://bugzilla.wikimedia.org/25799 +comment (10Mark A. Hershberger) [19:06:07] 03(mod) Entries for non-existent categories should be deleted from the 'category' table - 10https://bugzilla.wikimedia.org/26411 +comment (10Mark A. Hershberger) [19:07:06] 03(ASSIGNED) Give (potential) extension tags a high syntactical precedence - 10https://bugzilla.wikimedia.org/40604 (10Gabriel Wicke) [19:07:09] New review: Jeroen De Dauw; "I don't like what's currently done in SRF_SlideShow - it's fetching HTML that's generated in a stati..." [mediawiki/extensions/SemanticMediaWiki] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/25652 [19:07:44] heh... MatmaRex that $this->data stuff is just part of how we do skins for now... [19:08:03] hashar: ping [19:08:33] gwicke: in a conf call right now sorry :-) [19:08:34] hashar: gwicke pings on my behalf :) [19:08:37] 03(mod) Implement configuration database aka configuration management aka no shell excuse - 10https://bugzilla.wikimedia.org/26992 +comment (10Mark A. Hershberger) [19:08:38] Dantman: i realize, that's not what i'm asking about [19:08:48] MatmaRex,
{newtalk}
[19:08:51] (no rush, pong when you're available [19:09:19] hashar: k, we are adding JUnit output to our tests and have some questions for you- just pong when you have time [19:09:29] MatmaRex, what was the variable in question? [19:10:44] let's simplify the question. we have "if ( stuff) { doSomethingWith(stuff); }", i don't want to repeat stuff twice, i dont want the code to get longer - how to do it in php? [19:10:58] New review: btongminh; "I have always found /index.php/Article to be extremely ugly, and I would be in favor of eradicating ..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/17404 [19:11:17] i'd use if ( $a = stuff ) doSomethingWith( $a );, but that breaks about a dozen of MW conventions [19:11:33] MatmaRex, how long the name has to be really varies by what stuff and something really are [19:11:47] then you have seen the examples earlier [19:12:12] something is usually echo, stuff is some ugly -> -> -> expression [19:14:16] New review: btongminh; "Forgot to save the inline comments, which is where the -1 is for." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/17404 [19:14:43] MatmaRex: Does PHP short-circuit in ors? Then you could do echo( stuff || '' ); [19:14:54] (like in JS, console.log( stuff || '' ); [19:15:37] marktraceur: Yes it does short-circuit but it returns a bool rather than the value of the first true-ish operand [19:15:42] Hrm [19:15:55] Proper typing systems, you foil my plans again [19:16:42] New review: Daniel Friesen; "@btongminh I'll mention it again. There is no backwards compatibility being broken. /index.php/Artic..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/17404 [19:17:57] New patchset: Trevor Parscal; "Really remove all, not just half" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/25695 [19:18:29] 03(mod) Per-wiki namespace aliases shouldn't override (remove) global ones - 10https://bugzilla.wikimedia.org/29692 +comment (10Nemo_bis) [19:18:33] Change merged: Catrope; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/25695 [19:19:10] marktraceur: s/proper typing systems/PHP/ [19:19:23] also, this won't work, as i have to wrap stuff e.g. in a
[19:19:58] MatmaRex: So put stuff into $short, if ( $short ) { echo( $short ); } [19:21:55] marktraceur: with MW coding conventions, that makes the code 4 lines instead of four [19:22:02] ideally, i'd like it to be in one line :P [19:22:13] i'd use if ( $a = stuff ) doSomethingWith( $a );, but that breaks about a dozen of MW conventions [19:24:59] 03(NEW) Supporting MobileFrontend on beta labs - 10https://bugzilla.wikimedia.org/40605 normal; Wikimedia Labs: deployment-prep (beta); (arichards) [19:25:26] New patchset: Daniel Friesen; "Remove the default behaviour of "/index.php/Article" style urls." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/17404 [19:26:42] MatmaRex: Do it the long way, but I agree, repeating long variable names sucks. Bytes are cheap, programmers' wrists are not :) [19:31:47] New patchset: Daniel Friesen; "Remove the default behaviour of "/index.php/Article" style urls." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/17404 [19:32:18] Change merged: Aaron Schulz; [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/25644 [19:32:32] Change merged: Aaron Schulz; [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/25647 [19:32:53] O_o [19:33:06] New review: Jeroen De Dauw; "Sorry for the long wait! Unfortunately this does not appear to fix the issue. I'm still getting the ..." [mediawiki/extensions/EducationProgram] (master); V: -1 C: 2; - https://gerrit.wikimedia.org/r/22584 [19:33:10] Why is jenkins giving code-review=-2 instead of verified=-1? [19:33:56] New review: Daniel Friesen; "Erm... rebased... Rebasing something from one MW release to another feels strange." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/17404 [19:34:02] Change merged: Aaron Schulz; [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/25648 [19:35:16] Nooooooooo... T_T the +1's [19:35:41] Dantman: doesn't it give both? [19:38:22] MatmaRex, For that last commit of mine it gave -2 code-review... later when I rebased +1 verified. I thought jenkins was only supposed to handle verified. [19:39:34] New patchset: Adamw; "(FR #508) New Paypal adapter; validation before redirect" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/23027 [19:39:56] New patchset: Jeroen De Dauw; "Remove events bound to onbeforeunload as Vecator adds handlers with incorrect assumptions to it" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/25697 [19:40:03] afaik it gives either +1 verified or -1 verified with -2 code-review [19:40:14] at least that's what i've seen it do [19:40:51] Change abandoned: Jeroen De Dauw; "Implemented the other fix you suggested in I5b5c64529548625ca17a217d458105e7e240adb1" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/22584 [19:42:14] 03(mod) Submitting or saving edits to a course description prompts a "leave page" warning - 10https://bugzilla.wikimedia.org/39158 +comment (10Jeroen De Dauw) [19:44:19] New review: MarkTraceur; "I'm relatively happy with this, but it means you may miss other valid warnings in some cases....else..." [mediawiki/extensions/EducationProgram] (master) C: 1; - https://gerrit.wikimedia.org/r/25697 [19:52:42] Alright, I made a first stab at http://www.mediawiki.org/wiki/User:Qgil/MediaWiki_Community_Metrics [19:52:49] I'll go comment to wikitech-l now [19:57:27] New review: Jeroen De Dauw; "These pages are supposed to work without Vector, so disabling the handlers it had should not cause a..." [mediawiki/extensions/EducationProgram] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/25697 [19:58:27] New patchset: Mwjames; "A working example for the AjaxPrinter class / SMWAPI" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/25698 [19:59:21] New patchset: MaxSem; "More logging" [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/25699 [19:59:53] New patchset: DamianZaremba; "Add shell access hook." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/25700 [20:03:47] New patchset: Mwjames; "A working example for the AjaxPrinter class / SMWAPI" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/25698 [20:08:13] New patchset: Matmarex; "CologneBlue rewrite: fixup for unclickable site title" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25701 [20:08:13] New patchset: Matmarex; "CologneBlue rewrite: kill the evil globals" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25702 [20:08:14] New patchset: Matmarex; "CologneBlue rewrite: fix beforeContent() and afterContent()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25519 [20:08:49] somebody *really* should start reviewing these. [20:11:36] Gotta find someone familiar with skins to do it [20:11:37] ;) [20:12:23] New review: Mwjames; ">> Do you also have an example of how exactly this would be used?" [mediawiki/extensions/SemanticMediaWiki] (master); V: 1 C: 0; - https://gerrit.wikimedia.org/r/25652 [20:13:30] Reedy: no, really. these are straightforward changes [20:13:43] bringing cologneblue to 2012 [20:14:11] well, or at least somewhere around 2010 instead of 1995 where it currently is :D [20:14:30] what's wrong with 1995 [20:14:37] some of us were still young [20:18:05] 03(FIXED) fr.wikiquote Babel malfunction - 10https://bugzilla.wikimedia.org/39472 +comment (10Dereckson) [20:18:45] MatmaRex, I think more like 2006... There's too much non-modern in the front end for it to be 2010+ [20:18:51] I wasn't even born then :P [20:19:30] Ah... 1999... my family's first computer... With.... *gasp* DIAL UP!!! [20:20:12] ah dial-up [20:20:26] the hardest part about going to college in the 90s was going home and dealing with dial-up again [20:20:34] lol [20:21:27] at least we'd networked my parents' house so we could share the dial-up connection [20:22:00] there, finally got texvc working on my macbook [20:22:56] Dantman: i kinda like it, easy of the eyes [20:23:00] and no ugly web 2.0 gradients [20:23:07] (also, responding to your comments right now) [20:24:39] brion: in 1992 I had to take a 20 minute bus ride to get to Internet%BITNET [20:25:07] 03(mod) Ogg files stammer - 10https://bugzilla.wikimedia.org/40590 +comment (10Andre Klapper) [20:25:12] in 1992 I had…. no internet at all [20:25:12] Change merged: Catrope; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25529 [20:25:31] i think we got AOL in '93 ;) [20:25:43] Oh man, AOL [20:25:57] it was on IBM 3270 terminals wired to the VM/CMS machine. Four terminals in the front row had graphic display so you could see GIFs!!!! [20:26:11] Mmmmm... I believe our ISP's name at the time was Sympatico [20:26:14] Despite AOL being short for *America* On Line and it being much much more popular in the US than anywhere else, we did actually have AOL CompuServe for a while when I was a kid [20:26:21] eh [20:26:23] heh [20:26:40] remember when compuserve usernames were numbers? we had that too [20:26:55] New patchset: Mwjames; "A working example for the AjaxPrinter class / SMWAPI" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/25698 [20:27:06] I remember the terrible CompuServe browser they gave you [20:27:08] at least today's internet walled gardens are *on* the internet, instead of the internet being a magical feature of them [20:27:58] 03(FIXED) Enable local file upload for sysops on Gujarati Wikisource - 10https://bugzilla.wikimedia.org/36345 +comment (10Dereckson) [20:28:24] MatmaRex, Also... I wonder if CologneBlue still doesn't have a look/layout we don't want around by default... What do you think about turning it into a standalone skin? [20:29:00] New patchset: DamianZaremba; "Add shell access hook." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/25700 [20:29:17] New patchset: Christian; "Insert Annotations" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/25597 [20:29:18] Dantman: let's say i dont have an opinion on this. it should certainly stay on WMF wikis. [20:29:33] MatmaRex, WMF can just install the skin [20:30:16] Change merged: Catrope; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25530 [20:30:52] Change merged: Trevor Parscal; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/25597 [20:31:16] * Dantman toys with the evil idea of making every core skin a standalone repo and including the built-in ones as submodules [20:32:05] hashar: Got a few minutes for some Jenkins help? I'd like to make sure I've made the right format before I submit this patch. [20:32:24] ;) You know... that might make dealing with skin hacks easier [20:32:35] New patchset: Trevor Parscal; "Create method ve.Range.isCollapsed() and added some tests for ve.Range class." [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/25636 [20:32:38] hashar: (context: parsoid testing) [20:32:39] 03(FIXED) Restore "deletelogentry" right to "Eliminator" group on ja.wikipedia - 10https://bugzilla.wikimedia.org/40521 +comment (10Dereckson) [20:33:12] A clean linear git history... All you have to do is pull updates and git handles the merges [20:33:43] Hm, I just parsed part of bug 40521 as "deletelo gentry" [20:33:48] It's clearly Friday [20:33:51] 03(mod) Supporting MobileFrontend on beta labs - 10https://bugzilla.wikimedia.org/40605 +comment (10Antoine "hashar" Musso) [20:35:17] Change merged: Trevor Parscal; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/25636 [20:35:44] Change abandoned: Trevor Parscal; "Not needed anymore" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/25455 [20:36:55] marktraceur: talking about it in private with gwicke right now :) [20:37:27] hashar: Well, can I join the party? Better yet, take it to #mediawiki-parsoid [20:37:36] gwicke: ^^ [20:37:40] marktraceur: yeah [20:38:12] yeah moving there [20:40:22] is there a way to get diffs from the API instead of just full revisions? [20:40:39] cupco: prop=revisions has an rvdiffto parameter that provides diffs [20:40:49] tyvm [20:43:07] 03(FIXED) $wgSecureLogin does not redirect to http if wpStickHTTPS is unchecked - 10https://bugzilla.wikimedia.org/40541 (10Chris Steipp) [20:45:24] New patchset: Trevor Parscal; "Made save dialog float with toolbar" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/25454 [20:46:05] 03(FIXED) Change namespaces configuration - ku.wiktionary - 10https://bugzilla.wikimedia.org/37524 +comment (10Dereckson) [20:47:26] 03(FIXED) Create Iberocoop: namespace on Meta - 10https://bugzilla.wikimedia.org/38398 +comment (10Dereckson) [20:48:36] 03(VERIFIED) Create Iberocoop: namespace on Meta - 10https://bugzilla.wikimedia.org/38398 +comment (10Dereckson) [20:49:06] 03(FIXED) Activating flood flag on it.wikibooks - 10https://bugzilla.wikimedia.org/39569 +comment (10Dereckson) [20:57:48] 03(mod) User preference for enforcing HTTPS - 10https://bugzilla.wikimedia.org/29898 +comment (10Chris Steipp) [21:00:58] New patchset: Trevor Parscal; "Added callout icon" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/25706 [21:01:07] New patchset: Matmarex; "CologneBlue rewrite: #toplinks fixes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25707 [21:01:50] New review: Matmarex; "Fixed." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/25517 [21:02:30] Change merged: Robmoen; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/25706 [21:03:35] Dantman: see replies. [21:04:05] also, i think this is the first time `git reflog` saved my ass. hooray for git! [21:04:30] Change merged: Robmoen; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/25454 [21:04:53] 03(mod) Ogg files stammer - 10https://bugzilla.wikimedia.org/40590 +comment (10Juan de Vojníkov) [21:07:36] Dantman: also, if there are other changes you looked at and found no errors, i'd greatly appreciate some +1's [21:08:57] One moment... I have to kill Firefox [21:09:01] New patchset: Adamw; "(FR #508) New Paypal adapter; validation before redirect" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/23027 [21:09:58] Merge the last commits in the series [21:09:59] ;) [21:11:10] MatmaRex: I wonder if it's worth marking the first one as -1 or even -2, so someone doesn't submit it, and only merge some of the chain.. which I guess could probably break the skin? [21:11:55] hi [21:12:02] Reedy: yeah, i kinda messed up there [21:12:17] but i dont think this commit is worth a -2 [21:12:31] it still works, merely misses anonlogin [21:12:38] and this i could add in a patchset [21:12:43] I am having problems to run audiofiles in IE and Safari -is this known issue? [21:13:42] the non-rebaseableness comes from the fact that by using getPersonalTools, i have to use makeListItem, which has to add another element there, which it only makes sense to be a span, which broke the styles i set up earlier, to fix which i had to change the html structure [21:13:44] :) [21:14:28] it sais something like "Not allowed http..." I cant read it, its not in the source code [21:15:00] says [21:15:21] Brooke: ya [21:17:45] Actually scratch that... [21:17:54] New review: Mwjames; "Open for two weeks now, tested it again and it seems fine for all previous scenarios aside from the ..." [mediawiki/extensions/SemanticResultFormats] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/24114 [21:17:54] Change merged: Mwjames; [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/24114 [21:18:01] I should get some work done instead of +1ining a dozen commits [21:18:03] New patchset: Matmarex; "CologneBlue rewrite: #toplinks fixes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25707 [21:18:03] New patchset: Matmarex; "CologneBlue rewrite: fix beforeContent() and afterContent()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25519 [21:18:04] New patchset: Matmarex; "CologneBlue rewrite: fix sysLinks()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25518 [21:18:04] New patchset: Matmarex; "CologneBlue rewrite: don't display login/out links in sidebar" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25517 [21:18:04] New patchset: Matmarex; "CologneBlue rewrite: fixup for unclickable site title" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25701 [21:18:05] New patchset: Matmarex; "CologneBlue rewrite: kill the evil globals" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25702 [21:18:12] oh crap. [21:18:24] there were supposed to be two commits submitted. hooray for rebasing... [21:18:34] 03(FIXED) When re-running installation, the schema is incorrectly detected - 10https://bugzilla.wikimedia.org/26820 +comment (10Mark A. Hershberger) [21:18:53] see what you have done, Dantman? :P [21:19:02] Branches, branches... [21:19:09] press all of the rebase butons [21:19:26] Heh. [21:19:27] buttons * [21:19:40] no buttons. just git rebase -i. [21:19:51] it's still kinda amazing there are only 6 instead of 20 [21:20:15] * Dantman has a nice GUI that can handle really simple rebases [21:20:40] Branching would also give you a nice whole right-side to group your commits with [21:21:08] New review: Matmarex; "PS2: a partial fix to make this commit bug-less, but keep rebase stuff under control." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/25517 [21:22:22] You also wouldn't have to worry about bugs [21:22:25] ori-l: ready when you are - done everything my side :) [21:23:30] i'm seriously reconsidering abandoning all of those and submitting one huge squashed commit [21:23:42] or somebody could just start merging those :) [21:23:58] 03(mod) @import styles broken in modules that combine multiple stylesheets - 10https://bugzilla.wikimedia.org/35562 (10Mark A. Hershberger) [21:24:09] New patchset: Jeroen De Dauw; "Updated permissions as per https://bugzilla.wikimedia.org/show_bug.cgi?id=40477" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/25693 [21:24:13] (or reviewing, and by reviewing, i mean a +1 or a -1) [21:24:47] Hello [21:25:45] article name completion is not working in all cases for gu.wikisource [21:26:06] And which cases is it working? [21:26:15] New review: awjrichards; "pending the addition of getRootText(), this looks fine." [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/22114 [21:26:23] I think in the cases of new articles it is working [21:26:28] but not in old cases [21:26:41] 03(mod) "Cancel" link when editing a page should be a button - 10https://bugzilla.wikimedia.org/40601 summary; +comment (10MZMcBride) [21:27:07] I'm trying screen scrape specific wikipedia urls, like http://en.wikipedia.org/wiki/Sceloporus_grammicus or http://en.wikipedia.org/wiki/American_Alligator, Using the MediaWiki API is it possible to use the Page name as an arugement? [21:27:16] e.g. કડવું ૪ (સુદામા ચરિત) was added by me last night, it very well shows that [21:27:37] 03(mod) "Cancel" link when editing a page should be a button - 10https://bugzilla.wikimedia.org/40601 +comment (10Isarra) [21:27:43] because if I call that page directly wikipedia returns a 403 error [21:28:02] 03(mod) Implement JavaScript hook for "article ready" - 10https://bugzilla.wikimedia.org/30713 +comment (10Mark A. Hershberger) [21:28:40] Reedy: નાગર નંદજીના લાલ is a prime example, where it is not working [21:29:11] New patchset: DamianZaremba; "Add shell access hook." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/25700 [21:29:56] mantas322: https://en.wikipedia.org/w/api.php?action=query&prop=revisions&titles=Sceloporus_grammicus&rvprop=content [21:30:19] 03(mod) Implement JavaScript mw.hooks framework - 10https://bugzilla.wikimedia.org/23580 +comment (10Mark A. Hershberger) [21:30:52] Cool! thansk alot buddy. [21:32:04] New review: Hashar; "Thanks for that Chris. That feature I wrote has not been properly tested unfortunately. I wrote it..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25530 [21:32:08] 03(mod) Make the RL not give the fixalpha() (wrapped in an if isIE55) to non IE 5.5 browsers - 10https://bugzilla.wikimedia.org/26878 (10Mark A. Hershberger) [21:32:49] New patchset: DamianZaremba; "Add shell management hook." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/25700 [21:33:06] * Dantman goes to write a blog post on how to use a git trick to handle upgrades when you have core hacks in your code [21:34:09] jdlrobson2: cool i need a bit more time [21:34:14] Dantman: should `git pull` Just Work(TM)? [21:34:28] 03(mod) Make client-side loader load site and user modules - 10https://bugzilla.wikimedia.org/30358 (10Mark A. Hershberger) [21:34:29] (assuming you commited your hacks to master) [21:34:35] (local master) [21:34:40] ori-l: check your pm [21:34:46] just want to make sure i'm doing the right thing.. [21:34:54] MatmaRex, I'm talking about production wikis with hacks... They wouldn't be using master. [21:35:31] 03(mod) Installer should guide setting up the upload directory ("/images") - 10https://bugzilla.wikimedia.org/35277 (10Mark A. Hershberger) [21:35:37] mantas322: have you tried the API Sandbox? [21:35:57] mantas322: it's an interesting way to discover what is possible with the web API https://en.wikipedia.org/wiki/Special:ApiSandbox [21:36:13] MatmaRex, Most won't even be using the real repo... and even if they were... sadly e.g.: REL1_19 and REL1_20 have different bases and you can't merge from one to another. Rebasing would also be a little ridiculous. [21:36:14] im using a c# webclient to make my calls [21:36:22] and im still getting a 403 return [21:36:30] 03(mod) Handle 
 overflow automatically with a scroll bar - 10https://bugzilla.wikimedia.org/260  (10Mark A. Hershberger)
[21:36:39] 	 New review: awjrichards; "See inline comment. Also includes changes unrelated to commit msg - in this case not a huge deal, bu..." [mediawiki/extensions/UniversalLanguageSelector] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/25615
[21:37:09] 	 03(mod) Implement a way to set a canonical url in OutputPage - 10https://bugzilla.wikimedia.org/28602  (10Mark A. Hershberger)
[21:37:40] 	 sumnah havent tried that yet
[21:38:01] 	 Dantman: ah. that makes sense
[21:38:18] 	 !tabcompletion | mantas322 
[21:38:18] 	 mantas322: Instead of manually typing another person's nickname in IRC, you can type the beginning of their name and hit TAB on your keyboard to get it autocompleted, like on the command line.  This avoids misspellings.  Just make sure it's the right person!
[21:38:38] 	 mantas322,  403 from the api doesn't make sense... I have a feeling you're running into WMF's User-Agent restrictions.
[21:38:40] 	 but couldnt you just generate a patch from git repo and apply it to production, then?
[21:38:56] 	 oh my whats happening is my page titles are a little off case wise
[21:39:01] 	 so i get a redirect
[21:39:05] 	 1sec
[21:39:33] 	 hmm nvm
[21:40:44] 	 Dantman: maybe.  
[21:41:25] 	 New patchset: Adamw; "(FR #508) New Paypal adapter; validation before redirect" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/23027
[21:41:29] 	 also, mantas322, you probably want to be on the mediawiki-api-announce mailing list: A low-traffic list for announcements about the API, such as breaking changes and new MediaWiki releases. All messages to this list also go to mediawiki-api, so you don't need to be on both.
[21:41:36] 	 03(NEW) Article name completion/search doesn't work effectively on gu.wikisource - 10https://bugzilla.wikimedia.org/40606 normal; Wikimedia: Site configuration; (dsvyas)
[21:41:37] 	 mantas322: http://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce
[21:43:48] 	 MatmaRex, Perhaps... But then you have a downside or two. You're right back to your own custom repo with no attachment to the real repo, which is no better than the trick I'm going to explain. And you're applying a simple patch. This leads to more conflicts than the 3-way merging used in git.
[21:45:42] 	 alternative would be to commit your patch on top of the version you used, then cherry-pick it to new version and upload your files.
[21:45:56] 	 but this would require some knowledge of git, unlike the previous method
[21:47:48] 	 MatmaRex, and it would quickly become hell in actually projects with potentially dozens of local commits...
[21:48:25] 	 03(mod) Installer should auto-select APC/XCache/etc if available - 10https://bugzilla.wikimedia.org/34239  (10Mark A. Hershberger)
[21:48:50] 	 uh, not really, why? you could cherry-pick them all, and then you're moving to a new branch
[21:49:00] 	 but now you made me anxious to see your solution :P
[21:50:01] 	 MatmaRex, Sure you could... but it would be a mess to select them all... rebasing would actually have the same effect... But either way with the code intermingled it would not be pleasant.
[21:50:18] 	 03(mod) ResourceLoader should have a context instead of using global object variables - 10https://bugzilla.wikimedia.org/34738  +comment (10Mark A. Hershberger)
[21:51:12] 	 thanks for the help guys, my problem was "Identifying your client"   "When you make HTTP requests to the MediaWiki web service API, be sure to specify a User-Agent header that properly identifies your client. Don't use the default User-Agent provided by your client library, but make up a custom header that includes the name and the version number of your client: something like "MyCuteBot/0.1"."
[21:51:22] 	 03(mod) Stress the importance of a cache during install - 10https://bugzilla.wikimedia.org/34236  +comment (10Mark A. Hershberger)
[21:51:23] 	 no more 403a
[21:52:22] 	 yup thought so
[21:53:39] 	 03(mod) ResourceLoader cache not properly fixable after moving MediaWiki - 10https://bugzilla.wikimedia.org/35472  +comment (10Mark A. Hershberger)
[21:54:08] 	 New patchset: Adamw; "(FR #595) Adyen payment gateway" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/20467
[21:55:47] 	 03(mod) ResourceLoader should not output an empty "@media print { }" block. - 10https://bugzilla.wikimedia.org/40498  +comment (10Mark A. Hershberger)
[21:56:03] 	 Reedy: merge that?
[21:59:57] 	 03(mod) PageTriage is not showing a nice error message for users with JavaScript disabled - 10https://bugzilla.wikimedia.org/40520  (10bsitu)
[22:04:21] 	 New patchset: Adamw; "(FR #595) Adyen payment gateway" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/20467
[22:05:07] 	 03(mod) PageTriage: some characters are double-escaped in excerpt - 10https://bugzilla.wikimedia.org/40530  (10bsitu)
[22:06:15] 	 mantas322: Hmm, where'd you find that advice?
[22:06:19] 	 It's a bit inaccurate.
[22:06:39] 	 New review: awjrichards; "Sorry it's taken a while for someone to review this changeset. The changes look good, but the date f..." [mediawiki/core] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/17333
[22:06:44] 	 You should ideally include more than just a bot name. Something useful should also be nicluded. Like a contact method, preferably an e-mail address.
[22:07:04] 	 03(mod) AFTv5 controls not selectable with tab - 10https://bugzilla.wikimedia.org/40595   +accessibility; +comment (10Rodan BURY)
[22:07:05] 	 Brooke: "all complaints can be sent to /dev/null"
[22:07:09] 	 true story!
[22:07:10] 	 the 403 identifying your client???
[22:07:26] 	 http://www.mediawiki.org/wiki/API:Main_page
[22:07:30] 	 towards the end of the page
[22:07:33] 	 I'm not sure what you're asking with three question marks.
[22:07:43] 	 The 403 is a response code from the Web server, isn't it?
[22:07:49] 	 right
[22:07:51] 	 A rather unehlpful one, as i recall.
[22:07:55] 	 I can't type.
[22:08:16] 	 It used to not explain the User-Agent thing. Not sure if it's still mum on the likely culprit.
[22:08:30] 	 http://en.wikipedia.org/wiki/&
[22:08:33] 	 Another fun case. ^
[22:08:35] 	 03(mod) Underscores appearing in page titles in templates instead of spaces. - 10https://bugzilla.wikimedia.org/39243  (10bsitu)
[22:08:58] 	 Heh, that page was more enjoyable when it was translated into twenty languages.
[22:09:40] 	 New review: Andrew Bogott; "I don't know enough about MW to understand $wgHooks['UserRights']... if it does what it looks like t..." [mediawiki/extensions/OpenStackManager] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/25700
[22:11:07] 	 marktraceur: http://etherpad.wmflabs.org is down?
[22:12:24] 	 03(mod) Bad syntax when inserting PROD template via Page Curation - 10https://bugzilla.wikimedia.org/40268  (10bsitu)
[22:13:06] 	 New patchset: DamianZaremba; "Add shell management hook." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/25700
[22:13:29] 	 03(mod) Unreviewing sends a message to the page creator - 10https://bugzilla.wikimedia.org/40600  (10bsitu)
[22:14:32] 	 http://forge.puppetlabs.com/modules?q=mediawiki&commit=Go
[22:15:27] 	 New patchset: preilly; "add new only supported by select mobile carriers banner" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/25710
[22:16:38] 	 sumanah: Maybe so
[22:16:45] 	 New patchset: preilly; "add new only supported by select mobile carriers banner" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/25710
[22:17:02] 	 jdlrobson2: ping
[22:17:18] 	 Change merged: preilly; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/25710
[22:17:49] 	 New patchset: Ori.livneh; "Experimental event logging API" [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/25711
[22:18:08] 	 03(mod) Tidy occasionally isn't executed - 10https://bugzilla.wikimedia.org/38273  +comment (10Max Semenik)
[22:19:51] 	 sumanah: Yes, I initiated a move of some things and forgot to finish the configuration necessary to complete it
[22:22:23] 	 It's surprising that people don't use templates instead of categories.
[22:22:29] 	 Categories are still such a fucking pain in the ass.
[22:23:02] 	 http://piratepad.net/xbV4R2SCbB We're about 5 minutes into a 15-minute doc sprint to create a Wikimedia Labs guide for bot developers 
[22:23:11] 	 in case anyone wants to read, edit, contribute, etc
[22:24:44] 	 03(FIXED) VisualEditor: Clicking bold, italic, etc. should set state for newly entered text when no selection - 10https://bugzilla.wikimedia.org/33140  (10Christian Williams)
[22:24:47] 	 03(mod) Unreviewing sends a message to the page creator - 10https://bugzilla.wikimedia.org/40600  (10bsitu)
[22:25:06] 	 sumanah: Back up, if you're interested
[22:25:46] 	 Change merged: awjrichards; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/23799
[22:26:47] 	 03(mod) MW 1.19: (Fatal error) BitmapHandler::escapeMagickPath: unexpected colon character in path name - 10https://bugzilla.wikimedia.org/36565  +comment (10Max Semenik)
[22:27:12] 	 New patchset: VitaliyFilippov; "Limit auto-fitted thumbnail widths to multiples of 80" [mediawiki/extensions/SlimboxThumbs] (master) - https://gerrit.wikimedia.org/r/25712
[22:28:38] 	 what does this error mean: Could not create directory "mwstore://local-backend/local-public/1/10".
[22:30:49] 	 thank you marktraceur 
[22:30:59] 	 03(NEW) Auto-categorize pages that contain errors flagged by HTMLTidy - 10https://bugzilla.wikimedia.org/40607 normal; MediaWiki: General/Unknown; (b)
[22:31:08] 	 Change merged: VitaliyFilippov; [mediawiki/extensions/SlimboxThumbs] (master) - https://gerrit.wikimedia.org/r/25712
[22:31:12] 	 sumanah: My pleasure!
[22:31:19] 	 Dantman: You may be interested in https://bugzilla.wikimedia.org/40607
[22:31:28] 	 I think you were discussing something similar on the mailing list.
[22:31:35] 	 Metalmine: Are you seeing that on a Wikimedia wiki? (Which one?)
[22:31:52] 	 yes and 
[22:32:02] 	 http://wiki.lightenedblade.com
[22:32:05] 	 RoanKattouw, 
[22:32:05] 	 Heh.
[22:32:08] 	 RoanKattouw: No, his own
[22:32:11] 	 That's a MediaWiki wiki.
[22:32:13] 	 Hmm
[22:32:14] 	 03(FIXED) Stripping images should respect alt text - 10https://bugzilla.wikimedia.org/38107  (10Jon)
[22:32:16] 	 (o;
[22:32:19] 	 ah ok
[22:32:20] 	 oops
[22:32:21] 	 XD
[22:32:25] 	 Brooke, Yeah... the discussion on WikiText that outputs invalid html.
[22:32:28] 	 Wikimedia wikis are Wikipedia, Wiktionary, etc.
[22:32:33] 	 Dantman: Ah, right.
[22:32:35] 	 1.19.2
[22:32:37] 	 ahhhh ok
[22:32:46] 	 Hm
[22:32:47] 	 The naming is awful.
[22:32:49] 	 Admittedly.
[22:32:52] 	 I didn't know 1.19.2 was broken in this way
[22:32:54] * RoanKattouw  summons Aaron
[22:33:27] 	 Dantman: It should be fairly easy to make Tidy auto-categorize, I think?
[22:33:39] 	 Brooke, Sure...
[22:33:48] 	 All right. Marked it as such.
[22:33:57] 	 Erm...
[22:34:02] 	 Let me rephrase...
[22:34:08] 	 I think it would be easy for me to do...
[22:34:34] 	 Understanding the parser is a prerequisite to this being easy
[22:34:40] 	 Oooh OK
[22:34:44] 	 Aaron informs me this isn't actually broken
[22:34:52] 	 Metalmine: ^
[22:34:56] 	 Brooke, ;) if I had the time (i.e.: worked for a MediaWiki Foundation/Fund) I would fix that right now...
[22:34:57] 	 Most likely what's going on is your web server isn't able to create those directories
[22:35:15] 	 I have plenty of time.
[22:35:17] 	 Just no inclination.
[22:35:22] 	 pardon?
[22:35:23] 	 Maybe one day.
[22:35:33] 	 New patchset: Ori.livneh; "Bump version to 0.1" [mediawiki/extensions/PostEdit] (master) - https://gerrit.wikimedia.org/r/25484
[22:35:34] 	 Metalmine: Your Web server has to make folders.
[22:35:37] 	 Where the files go.
[22:35:40] 	 If it doesn't have permissions.
[22:35:41] 	 mhm?
[22:35:47] 	 Because the directory isn't writeable.
[22:35:47] 	 Change merged: Ori.livneh; [mediawiki/extensions/PostEdit] (master) - https://gerrit.wikimedia.org/r/25484
[22:35:52] 	 ah i see
[22:35:58] 	 Or the user doesn't have permissions for whatever reason,
[22:36:00] 	 it'll hit a wall.
[22:36:04] 	 i see
[22:36:08] 	 So check your file system permissions.
[22:36:16] 	 so which group do i give the 777 to?
[22:36:19] 	 You may be able to set everything to 755 or something. Not sure.
[22:36:21] 	 how do i list the groups?
[22:36:25] 	 or that
[22:36:29] 	 755
[22:36:33] 	 RoanKattouw: Do you know?
[22:36:44] 	 I'm not sure how what mwstore:// actually means.
[22:36:52] 	 Metalmine: It depends on which user is running your nginx process
[22:36:53] 	 It's a made-up protocol, isn't it?
[22:37:07] 	 (transparency: I know he's using nginx from previous conversations along the same line)
[22:37:07] 	 how so
[22:37:22] 	 They're all made up protocols...
[22:37:42] 	 Metalmine: If a user called 'metalmine' is running nginx, giving permissions to user 'wiki' won't make any difference
[22:37:49] 	 right
[22:37:49] 	 So you need to figure out which user it is
[22:37:53] 	 Dantman: I'd classify http and https differently.
[22:38:17] 	 marktraceur: Or just give everyone access?
[22:38:20] 	 Metalmine: usually it's the owner of the web files. ls -l in your web site's main directory.
[22:38:27] 	 Brooke: Eh. Security.
[22:38:31] 	 Depends what you're doing, I guess.
[22:38:33] 	 Brooke, lol... ;) I mean the stuff we use for filerpos and iirc external storage
[22:38:45] 	 New patchset: DamianZaremba; "Add shell management hook." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/25700
[22:38:56] 	 Right.
[22:39:03] 	 I'm not sure how mwstore:// resolves internally.
[22:39:06] 	 To /images/, I guess?
[22:39:09] 	 https://gist.github.com/3802433
[22:39:10] 	 I don't really get it.
[22:39:12] 	 marktraceur, 
[22:39:55] 	 Metalmine: So probably your server is running as metalmine
[22:40:08] 	 mhm
[22:40:26] 	 Metalmine: But I can't be sure, since that looks like your home directory
[22:40:46] 	 Yes, mwstore://local-backend/local-public/1/10 resolves internally to /path/to/your/wiki/images/1/10
[22:42:19] 	 Got it.
[22:42:21] 	 New review: DamianZaremba; "Not sure if we want *both* options. Just 1 would be enough for me. The logic works in testing so I'l..." [mediawiki/extensions/OpenStackManager] (master) C: 0;  - https://gerrit.wikimedia.org/r/25700
[22:42:24] 	 Good to know.
[22:43:38] 	 RoanKattouw, ok
[22:44:33] 	 New patchset: Kaldari; "Adding full size minimize buttons for iPad and moving other stuff around" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/25713
[22:45:34] 	 03(mod) Unreviewing sends a message to the page creator - 10https://bugzilla.wikimedia.org/40600  +comment (10Oliver Keyes)
[22:50:53] 	 New patchset: DamianZaremba; "Add shell management hook." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/25700
[22:51:06] 	 what's a data row?
[22:51:10] 	 and how do i add them?
[22:52:15] 	 I don't know what you mean with "data row", could you provide some more context?
[22:52:27] 	 New patchset: DamianZaremba; "Add shell management hook." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/25700
[22:52:37] 	 er sure
[22:52:49] 	 http://wiki.lightenedblade.com/wiki/Direwolf20 look at the bottom
[22:52:58] 	 articles which use infobox templates with no data rows
[22:53:54] 	 New patchset: preilly; "custom font size for Saudi Telecom" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/25714
[22:55:15] 	 Change merged: preilly; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/25714
[22:59:55] 	 03(mod) Activating flood flag on it.wikibooks - 10https://bugzilla.wikimedia.org/39569  +comment (10Dereckson)
[23:04:07] 	 Metalmine: http://wiki.lightenedblade.com/wiki/Template:Infobox#Examples
[23:04:14] 	 Read the documentation, try the examples
[23:04:28] 	 ooooh thanks :D
[23:09:53] 	 Change merged: Kaldari; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/24512
[23:16:33] 	 03(mod) User preference for enforcing HTTPS - 10https://bugzilla.wikimedia.org/29898  +comment (10MZMcBride)
[23:17:49] 	 New patchset: Kaldari; "(bug 26995) Update filename field on Special:Upload after sanitizing" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21478
[23:18:59] 	 csteipp: Thanks for your work on the HTTPS cookie. :-)
[23:19:09] 	 New patchset: Reedy; "(bug 40541) Fixed $wgSecureLogin functionality." [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/25715
[23:20:53] 	 Change merged: Kaldari; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/24962
[23:21:06] 	 Will $wgSecureLogin only work with https://http:// equivalence?
[23:21:22] 	 New patchset: Spage; "Repository clean-up" [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/25608
[23:21:39] 	 Brooke: That does seem to be the case, yes
[23:21:39] 	 $title->getFullURL( $query, false, PROTO_HTTPS );
[23:21:51] 	 Well --
[23:21:56] 	 Brooke: That depends on what $wgServer is
[23:22:00] 	 So if you have secure.wiki.com and wiki.com?
[23:22:09] 	 http://wiki.com and https://secure.wiki.com, that is.
[23:22:10] 	 If $wgServer is an http url, that actually *won't* generate an HTTPS URL
[23:22:12] 	 Change merged: Ori.livneh; [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/25608
[23:22:18] 	 Hm.
[23:22:24] 	 https://gerrit.wikimedia.org/r/#/c/25715/1/includes/specials/SpecialUserlogin.php,unified
[23:22:30] 	 That's where I saw it.
[23:22:34] 	 Yeah
[23:22:36] 	 Well spotted
[23:22:49] 	 I reviewed that and remember that line, but I didn't consider a non-protocol-relative $wgServer
[23:23:02] 	 Crap, that's a problem I suppose
[23:23:23] 	 Dunno. Is anything explicit about the canonical https and http versions?
[23:23:24] 	 Brooke: You're welcome!
[23:23:25] 	 $wgServer?
[23:23:48] 	 csteipp: I left a (rambling) comment on bug whichever about the user preference. Not sure a login checkbox is sane.
[23:24:17] 	 User preference for enforcing HTTPS - https://bugzilla.wikimedia.org/29898
[23:24:18] 	 That one.
[23:24:38] 	 Yeah
[23:24:48] 	 [x] Actually log me in
[23:25:01] 	 [x] Remember me as much hotter than I actually am
[23:25:15] 	 [x] Disable Troll mode
[23:25:31] 	 csteipp: So what I forgot to think about when reviewing this earlier is that you might have something like $wgServer = 'http://foo.com'; in which case the PROTO_* flags don't do anything. As I just pointed out in a review comment that looks like it might cause infinite redirect loops in some cases
[23:25:55] 	 (PROTO_* are only effective if $wgServer = '//foo.com'; )
[23:26:08] 	 03(mod) User preference for enforcing HTTPS - 10https://bugzilla.wikimedia.org/29898  +comment (10billinghurst)
[23:26:14] 	 RoanKattouw: That seems a bit silly.
[23:26:26] 	 Welcome to MediaWiki.
[23:26:32] 	 Reedy: Behave, please.
[23:26:51] 	 Or do I remember this incorrectly... ?
[23:27:01] 	 That sounds unlikely
[23:27:06] 	 (you remembering incorrectly)
[23:27:38] 	 03(mod) VisualEditor: Backspace deletes the wrong character - 10https://bugzilla.wikimedia.org/40416  +comment (10Christian Williams)
[23:27:54] 	 Or wait
[23:28:00] 	 Right, it depends on the *input* to wfExpandUrl()
[23:28:02] 	 Right
[23:28:08] * RoanKattouw  rethinks comment
[23:29:34] 	 No, wait, I am right
[23:30:18] 	 If you feed wfExpandUrl() a URL starting with a single slash (e.g. /w/index.php?stuff), it will first prepend $wgServer, then use PROTO_* to decide what do to *if* the URL isn't already fully qualified
[23:30:42] 	 03(mod) VisualEditor: By-word selection fails when mouse moves - 10https://bugzilla.wikimedia.org/39965  +comment (10Christian Williams)
[23:31:11] 	 So $title->getFullURL( $query, false, PROTO_HTTPS ); will return 'http://foo.com/w/index.php?title=Special:Userlogin&....' if $wgServer is set to 'http://foo.com'
[23:31:26] 	 We have some lovely unit tests...
[23:31:31] 	 RoanKattouw: let me test that... 
[23:31:56] 	 RoanKattouw: Did you comment on Gerrit? I don't see it in scrollback.
[23:32:10] 	 RoanKattouw: Crap, you're right
[23:32:26] 	 > $wgServer='http://foo.com';
[23:32:28] 	 > echo SpecialPage::getTitleFor('Userlogin')->getFullURL(array('returnto'=>'foobar'), false, PROTO_HTTPS);
[23:32:29] 	 http://foo.com/w/index.php?title=Special:UserLogin&returnto=foobar
[23:32:39] 	 You can blame me for the way PROTO_* behave
[23:32:45] 	 !blame
[23:32:45] 	 Whatever happened, it's Domas' fault. For everything else, there's `svn blame`.
[23:33:06] 	 !blame del
[23:33:06] 	 Successfully removed blame
[23:33:20] 	 !blame is Whatever happened, it's Domas' fault. For everything else, there's `git blame`.
[23:33:20] 	 Key was added
[23:33:26] 	 :-)
[23:33:46] 	 Anyway, I'n not sure why $wgServer is so mystical and magical.
[23:33:50] 	 Which is what I was hinting at earlier.
[23:33:52] 	 Brooke: I commented it on the merged one in master
[23:34:03] 	 I'm not sure it was reported in here.
[23:34:06] 	 Yet.
[23:34:15] 	 The reason PROTO_* behave that way is for b/c with sites that don't have $wgServer set right
[23:34:31] 	 (by "right" I mean protocol-relative)
[23:34:51] 	 I think being explicit about what the canonical protocol versions are would be so much better.
[23:34:53] 	 (I suppose I shouldn't phrase it that way, setting an http URL there is actually the right thing to do if you don't support https)
[23:35:08] 	 Brooke: What do you mean by "canonical protocol versions"?
[23:35:08] 	 $wgHTTPSServer = 'https://whatever'; $wgHTTPServer = 'http://whatever';
[23:35:11] 	 03(mod) @import styles broken in modules that combine multiple stylesheets - 10https://bugzilla.wikimedia.org/35562  +comment (10Krinkle)
[23:35:12] 	 Oh
[23:35:15] 	 Right, that would be nice
[23:35:28] 	 Right now I have $wgServer and $wgCanonicalServer which sort of accomplishes that but not really
[23:35:30] 	 This weird $wgServer behavior doesn't seem to make much sense.
[23:35:42] 	 New patchset: Reedy; "Wrap long lines" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25716
[23:35:44] * MatmaRex  loves more configuration variables!
[23:35:46] 	 I'd just kill that variable if it can't be guaranteed to be sane in past versions.
[23:36:23] 	 !developer
[23:36:23] 	 http://www.mediawiki.org/wiki/Developers
[23:36:26] 	 !developer del
[23:36:27] 	 Unable to find the specified key in db
[23:36:35] 	 !developer is Did you mean engineer?
[23:36:35] 	 Key was added
[23:36:46] 	 Trippy.
[23:36:49] 	 So if someone doesn't have ssl and sets wgSecureLogin, they hose themselves... I almost think that's appropriate
[23:36:56] 	 haha
[23:37:09] 	 It won't infinitely redirect, will it?
[23:37:15] 	 The notion that $wgSecureLogin won't work if you don't have https is fine
[23:37:19] 	 But the infinite redirect is nasty
[23:37:35] 	 But I am wondering why wfExpandUrl wouldn't respect the https
[23:37:42] 	 I agree
[23:37:49] 	 Isn't the issue $wgSecureLogin = 'true'; plus a "misconfigured" $wgServer?
[23:37:54] 	 Yes
[23:38:23] 	 Brooke: Basically the bug is that if you have $wgServer = 'http://foo.com'; (which means "I only support http") plus $wgSecureLogin = true; , it'll get in an infinite loop trying to redirect to https
[23:38:31] 	 Right.
[23:38:34] 	 I got that a few mintues ago. ;-)
[23:38:35] 	 minutes
[23:38:46] 	 But the more I learn about $wgServer, the more it seems stupid.
[23:38:56] 	 Yeah, I take full blame for that
[23:38:57] 	 So Tyler's patch can be modified to not do the redirect.. that would be easy
[23:39:07] 	 $wgServer isn't fantastic
[23:39:11] 	 Or we fix wfExpandUrl
[23:39:14] 	 It needs to do the redirect if you want a secure login.
[23:39:16] 	 But it is necessary for reasons related to the parser cache
[23:39:31] 	 If I go to http://foo.com and I have $wgSecureLogin set, it needs to redirect.
[23:39:34] 	 That part is sane.
[23:39:46] 	 Brooke: Not really... he added a redirect so that if you hit the page without https, then you get redirected
[23:39:49] 	 It didn't used to do that
[23:40:02] 	 csteipp: Changing the wfExpandUrl behavior for PROTO_HTTPS would probably be fine because I'm pretty sure nothing used it except the code you and Tyler wrote
[23:40:12] 	 New review: Krinkle; "There is a pretty big stack of dependencies on top of this. Perhaps merge some of them into one befo..." [mediawiki/core] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/25412
[23:40:17] 	 But you'd probably want to do the same with PROTO_HTTP for consistency, in which case you'd need to audit its uses
[23:40:17] 	 csteipp: He made that conditional on a special configuration variable designed to secure your login session, didn't he?
[23:40:20] 	 $wgSecureLogin?
[23:40:30] 	 I'm not sure why you wouldn't redirect.
[23:40:32] 	 PROTO_HTTP is used mostly as a "if protocol not specified, fall back to http" flag I think
[23:40:48] 	 Well, besides the redirect being broken by $wgServer idiocy. (o;
[23:41:19] 	 New review: Krinkle; "16 commits (!)" [mediawiki/core] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/25412
[23:43:58] 	 New review: Matmarex; "I've already condensed some changes, there used to be more ;). (Although not submitted here.)" [mediawiki/core] (master) C: 0;  - https://gerrit.wikimedia.org/r/25412
[23:45:15] 	 New review: Matmarex; "Basically, when you see an issue I didn't fix, you can pretty much assume it's fixed later. Just rev..." [mediawiki/core] (master) C: 0;  - https://gerrit.wikimedia.org/r/25412
[23:52:09] 	 New patchset: Subramanya Sastry; "Removed unnecessary whitespace in tpl name/arg class tests." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25719
[23:57:07] 	 Hi, Extension:Username Blacklist seems to cause problems after the latest PHP upgrade on our server a few days ago. The error message is that Hooks.php expects a reference as parameter somewhere.
[23:57:58] 	 That's usually fixed by removing an ampersand in the relevant function definition in the extension
[23:58:38] 	 Thanks. How do I find the call that is causing the problem?
[23:59:01] 	 The error message should mention the name of the function