[00:23:52] New patchset: Hoo man; "(bug 23243) Warn before deleting a global account" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/26906 [00:24:57] New review: Hoo man; "White spaces, message wording and renamed SpecialCentralAuth::showActionForm to" [mediawiki/extensions/CentralAuth] (master) C: 0; - https://gerrit.wikimedia.org/r/26906 [00:25:42] 03(mod) Cannot search on WP 7 (Windows Phone 7.5) - 10https://bugzilla.wikimedia.org/40754 +comment (10Jon) [00:33:25] New review: GWicke; "Do we" [mediawiki/extensions/Parsoid/cpp/contrib/libhubbub] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/26744 [00:33:25] Change merged: GWicke; [mediawiki/extensions/Parsoid/cpp/contrib/libhubbub] (master) - https://gerrit.wikimedia.org/r/26744 [00:33:43] 03(mod) installer: ability to override LocalSettings.php filename - 10https://bugzilla.wikimedia.org/34426 +comment (10Tim Landscheidt) [00:33:47] Change merged: GWicke; [mediawiki/extensions/Parsoid/cpp/contrib/libhubbub] (master) - https://gerrit.wikimedia.org/r/26896 [00:56:30] 03(mod) Enable Extension:Education Program on English Wikipedia (with new user rights configuration) - 10https://bugzilla.wikimedia.org/40477 +comment (10Jeroen De Dauw) [01:20:17] New patchset: Catrope; "Add missing return in ve.getDOMAttributes()" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/26918 [01:20:30] New patchset: Catrope; "Add setDOMAttributes()" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/26919 [01:20:39] New patchset: Catrope; "Add ve.openHtmlTag()" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/26921 [01:20:50] New patchset: Catrope; "Support custom hashes in ve.getHash()" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/26922 [01:21:21] New patchset: Catrope; "New annotation API: ve.dm.Converter integration" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/26923 [01:21:21] New patchset: Catrope; "New annotation API: ve.ce.TextNode integration" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/26924 [01:21:21] New patchset: Catrope; "New annotation API: update tests" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/26925 [01:21:22] New patchset: Catrope; "New annotation API: Annotation and AnnotationRegistry classes" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/25963 [01:21:22] New patchset: Catrope; "New annotation API: convert existing annotations" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/25964 [01:33:17] New review: Catrope; "Unsetting -2" [mediawiki/extensions/VisualEditor] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/25963 [01:35:28] New review: Catrope; "Undoing -2" [mediawiki/extensions/VisualEditor] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/25964 [01:39:25] New patchset: Catrope; "New annotation API: Annotation and AnnotationRegistry classes" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/25963 [01:39:26] New patchset: Catrope; "New annotation API: convert existing annotations" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/25964 [01:39:26] New patchset: Catrope; "New annotation API: ve.ce.TextNode integration" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/26924 [01:39:26] New patchset: Catrope; "New annotation API: update tests" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/26925 [01:39:27] New patchset: Catrope; "New annotation API: ve.dm.Converter integration" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/26923 [01:39:32] Hey there .. I'm using MediaWiki (latest version) locally on my own pc and was just wondering why it is so slowly loading. Did I ignore some configuration? Every online wikipedia is much faster [01:40:21] online wiki* :D [01:40:51] ItsJustMe: http://www.mediawiki.org/wiki/Manual:Cache you might want some caching [01:41:04] http://www.mediawiki.org/wiki/User:Aaron_Schulz/How_to_make_MediaWiki_fast [01:42:06] Okay, so I'm doing nothing wrong .. It's just the default config .. Thank you :) [01:42:18] np [01:42:18] Caching should be great .. I'll try ^^ [01:42:22] ItsJustMe: Wikipedia doesn't just run on your local PC ;) [01:42:33] anybody from new jersey? [01:42:35] I know Reedy ^^ [01:57:15] Hi, I'm having some trouble upgrading my mediawiki installation. Was on 1.15, moved up to 1.19.2 [01:57:51] Skins don't seem to be working - the pages are all unstyled [01:58:32] what does console on your browser say? [01:59:33] this is the site: http://gmod.org/ [01:59:56] GET http://gmod.org/mediawiki/load.php?debug=false&lang=en&modules=site&only=styles&skin=monobook&* 404 (Not Found) Main_Page:18 [01:59:58] GET http://gmod.org/mediawiki/load.php?debug=false&lang=en&modules=mediawiki.legacy.commonPrint%2Cshared%7Cskins.monobook&only=styles&skin=monobook&* 404 (Not Found) Main_Page:15 [01:59:58] GET http://gmod.org/mediawiki/load.php?debug=false&lang=en&modules=site&only=scripts&skin=monobook&* 404 (Not Found) Main_Page:24 [01:59:58] GET http://gmod.org/mediawiki/load.php?debug=false&lang=en&modules=startup&only=scripts&skin=monobook&* 404 (Not Found) Main_Page:24 [01:59:58] Uncaught ReferenceError: jQuery is not defined Main_Page:932 [01:59:58] Uncaught ReferenceError: $ is not defined [02:00:30] the /mediawiki is wrong [02:01:31] Where is your script path? [02:01:53] scriptpath is /mediawiki [02:02:19] api.php gives a blank page [02:02:30] load.php is a 404 [02:02:59] the previous installation had all kinds of weird links in the install directory [02:03:06] seemingly [02:03:52] What else is at the root of that script path? [02:04:09] I have define('MW_INSTALL_PATH','/var/lib/mediawiki') [02:04:19] $wgScriptPath = "/mediawiki"; [02:08:50] Any suggestions as to what the problem might be? [02:10:13] you might be able to fix it with a symlink [02:10:48] I'm going to bed in a few minutes though [02:11:11] the previous install had localsettings.php at /etc/mediawiki/LocalSettings.php [02:11:34] We really generally don't like using OS packaged installs [02:11:36] !package [02:11:36] Many Linux distributions provide MediaWiki in a packaged format for that distribution. These packages typically contain obsolete and unsupported versions of MediaWiki, also they like to move around files, change the files, and do other batshit insane things. You'll get the best support here if you install MediaWiki directly from one of our tarballs, available at http://www.mediawiki.org/ [02:11:45] purely for that reason [02:11:47] the new install uses /var/lib/LocalSettings.php - or it shoudl do, anyway [02:12:12] I'm fairly sure this was someone's custom install - not a packaged version [02:12:32] is it possible that the new install is still using LocalSettings in the old location? [02:12:59] It'd be less common for someone to move them around themselves [02:13:17] Possibly, depending on how the hell it's been setup, and what they've modified to make it work [02:13:21] (tho I don't see how — previous LocalSettings.php was symlinked from current localsettings location) [02:13:45] can you suggest any fixes? I'm kind of in the shit! [02:16:26] LocalSettings isn't your problem [02:16:53] index.php has possibly been symlinked to your script directory, there should be an api.php and a load.php there too.. [02:17:01] the problem is there doesn't seem to be the load.php [02:17:06] so your getting no css and js [02:18:05] the simplest fix might be to see where the index.php is symlinked to/from [02:18:18] and create one for api.php and load.php in the same place, to the same relevant place [02:19:36] all these files appear to be in the mediawiki directory - could there be some sort of permissions issue? I still have the old index.php, load, api files - should I just symlink to them instead? [02:27:53] do the permissions differ? [02:28:11] I wouldn't link to old versions [02:28:21] load.PHP won't exist [02:28:31] no - just tried that and they don't work [02:29:11] New patchset: Spage; "kill unused survey after user submits (bug 37364)" [mediawiki/extensions/ArticleFeedback] (master) - https://gerrit.wikimedia.org/r/26927 [02:31:01] yaaaaay. die simple survey! [02:36:55] New review: Reedy; "I wonder how much of this is now in aftv5. Either way, other wikis won't be using it either, even mo..." [mediawiki/extensions/ArticleFeedback] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/26927 [02:38:10] 03(mod) Uninstall PrefSwitch extension from Wikimedia wikis - 10https://bugzilla.wikimedia.org/37364 (10spage) [03:31:18] hi [03:37:56] New patchset: Mwjames; "Add print related style sheet registration" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/26928 [03:39:30] Change merged: Mwjames; [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/26928 [04:24:46] New patchset: Mwjames; "Add user prefs intro for SRF" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/26929 [04:26:20] New patchset: Mwjames; "Add user prefs intro for SRF" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/26929 [04:48:58] New patchset: Mwjames; "User preference naming consolidation before release" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/26930 [05:02:50] New patchset: Mwjames; "Update release notes" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/26931 [05:03:23] Change merged: Mwjames; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/26931 [05:22:53] New review: Krinkle; "As I expected, using ".static" is completely fine." [mediawiki/extensions/VisualEditor] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26562 [05:23:07] New review: Krinkle; "Cross browser results: http://integration.wmflabs.org/testswarm/job/1" [mediawiki/extensions/VisualEditor] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26562 [05:23:37] New review: Krinkle; "Test suite in question: http://toolserver.org/~krinkle/tmp/test-js/?module=Prop%20static" [mediawiki/extensions/VisualEditor] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26562 [05:38:18] 03(mod) Creation of new Wikimedia Thailand mailing list - 10https://bugzilla.wikimedia.org/40784 +comment (10Anirudh Bhati) [05:38:56] New patchset: Mwjames; "Update js file from homepage" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/26932 [05:42:03] New patchset: Mwjames; "Update plug-in file" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/26932 [05:42:54] Change merged: Mwjames; [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/26932 [06:02:44] 14(WFM) installer: ability to override LocalSettings.php filename - 10https://bugzilla.wikimedia.org/34426 +comment (10Antoine "hashar" Musso) [06:04:44] 03(mod) Set up parallel automated parser test run on PostgreSQL, SQLite backends for CodeReview output - 10https://bugzilla.wikimedia.org/20343 +comment (10Antoine "hashar" Musso) [06:04:45] 03(mod) Set up automatic PHPUnit test suite runs for MySQL backend - 10https://bugzilla.wikimedia.org/35912 (10Antoine "hashar" Musso) [06:04:47] 03(mod) Jenkins should run PostgreSQL unit tests by default as well - 10https://bugzilla.wikimedia.org/37602 (10Antoine "hashar" Musso) [06:12:50] 03(mod) Mechanism to find usages of raw-html messages - 10https://bugzilla.wikimedia.org/19291 +comment (10Antoine "hashar" Musso) [07:10:41] New patchset: jan; "Add passfile option to install.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26894 [07:25:05] New patchset: jan; "Add passfile option to install.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26894 [07:25:07] 03(mod) jquery.makeCollapsible should avoid page scroll when collapsing elements - 10https://bugzilla.wikimedia.org/40792 +comment (10Krinkle) [07:25:22] New patchset: jan; "Add warnings to install.php for files-options" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26901 [07:33:40] New review: Krinkle; "JSHint + needs unit tests." [mediawiki/extensions/VisualEditor] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/26922 [08:01:31] New review: Nikerabbit; "No release notes?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26845 [08:11:47] 03(mod) Font transferred with MIME type application/octet-stream - 10https://bugzilla.wikimedia.org/40796 +comment (10Niklas Laxström) [08:15:26] New patchset: Burthsceh; "adjust to Coding conventions etc." [mediawiki/extensions/RevisionCommentSupplement] (master) - https://gerrit.wikimedia.org/r/25757 [08:15:27] New review: Krinkle; "Unit tests." [mediawiki/extensions/VisualEditor] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/26919 [08:16:45] New review: Krinkle; "Unit tests." [mediawiki/extensions/VisualEditor] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/26921 [08:16:51] Change merged: Nikerabbit; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/26800 [08:21:57] New patchset: Umherirrender; "Remove autoloader for deprecated Database class" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26934 [08:22:26] New review: Umherirrender; "See Id71be894 for the autoloader" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26843 [08:25:37] New review: Umherirrender; "I do not know, if a release note is needed, for this very old method. Feel free to create one, when ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26845 [08:30:55] New review: Umherirrender; "No caller in core, the latest caller of makeKnownLinkObj is deprecated and maybe removed with If3ad0..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/26822 [08:31:12] New patchset: Eranroz; "Watchlist grouping" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/16419 [08:36:04] New patchset: Burthsceh; "adjust to Coding conventions etc." [mediawiki/extensions/RevisionCommentSupplement] (master) - https://gerrit.wikimedia.org/r/25757 [08:37:46] 03(NEW) Bizarre edit history - 10https://bugzilla.wikimedia.org/40815 normal; MediaWiki: Special pages; (menoush25) [08:44:21] Change merged: IAlex; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26934 [08:45:50] New review: Burthsceh; "I think this is okay except schemes of database table." [mediawiki/extensions/RevisionCommentSupplement] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/25757 [08:45:50] Change merged: Burthsceh; [mediawiki/extensions/RevisionCommentSupplement] (master) - https://gerrit.wikimedia.org/r/25757 [08:50:08] 03(NEW) Extension:NewUserMessage stopped loading random signatures on arwiki - 10https://bugzilla.wikimedia.org/40816 normal; MediaWiki extensions: NewUserMessage; (menoush25) [08:58:30] New review: Krinkle; "Per (other) points on patch 5." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/26440 [08:59:41] 03(FIXED) i-0000049c / integration-wikibugs unreachable - 10https://bugzilla.wikimedia.org/40740 +comment (10Antoine "hashar" Musso) [09:03:53] New review: Krinkle; "This can be abandoned as the rewrite has been merged (last week)." [mediawiki/core] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/23541 [09:04:56] New patchset: Krinkle; "(bug 40660) Don't mangle   in on-wiki JS." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25986 [09:07:05] New patchset: Eranroz; "Watchlist grouping" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/16419 [09:08:13] 03(FIXED) ResourceLoaderWikiModule should not convert " " to a space for pages from the MediaWiki-namespace - 10https://bugzilla.wikimedia.org/40660 summary; +comment (10Krinkle) [09:08:32] New patchset: Krinkle; "(bug 40660) Don't mangle   in on-wiki JS." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25986 [09:09:35] New patchset: Krinkle; "(bug 40660) Don't mangle   in on-wiki JS." [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/26935 [09:09:51] Change merged: Krinkle; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25986 [09:10:01] Change merged: Krinkle; [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/26935 [09:12:03] 03(mod) Vector toolbar. Option to Find / Replace only within selected text - 10https://bugzilla.wikimedia.org/40797 (10Michael M.) [09:49:22] New patchset: Chughakshay16; "Minor formatting changes" [mediawiki/extensions/ConventionExtension] (master) - https://gerrit.wikimedia.org/r/26936 [09:55:28] New patchset: Umherirrender; "pass user object for delete/undelete/filerevert in api/gui" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26937 [10:01:17] 03(NEW) API: cannot restore oldimage - 10https://bugzilla.wikimedia.org/40817 normal; MediaWiki: API; (umherirrender_de.wp) [10:06:20] is there someone around with labs access, who would restart COIBot for me? [10:06:50] instructions for its restart are contained in its directories [10:12:21] hei [10:13:48] gday, /me says ^^^ knowing that nikerabbit has lots of access, but maybe not the time [10:17:10] tsauzor Nikerabbit [11:17:43] New patchset: Chughakshay16; "Modifications in Dashboard.css file" [mediawiki/extensions/ConventionExtension] (master) - https://gerrit.wikimedia.org/r/26938 [11:27:04] New patchset: Chughakshay16; "Modifications in Dashboard.css file" [mediawiki/extensions/ConventionExtension] (master) - https://gerrit.wikimedia.org/r/26938 [11:31:25] New review: leucosticte; "Sorry about not sending this earlier; I'm new to Git and Gerrit and didn't realize you wouldn't rece..." [mediawiki/extensions/DeleteBatch] (master) - https://gerrit.wikimedia.org/r/26655 [11:36:02] 03(mod) Possible memory leak - 10https://bugzilla.wikimedia.org/40804 (10swuensch) [11:43:59] New review: Matmarex; "Just a quick look. Didn't run the code or really chew through it." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/21873 [11:48:56] is there someone around with labs access, who would restart COIBot for me? [11:50:27] New patchset: Eranroz; "Watchlist grouping" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/16419 [12:02:20] sDrewth, I quoted that in #wikimedia-labs [12:15:21] 03(NEW) Error creating thumbnail: Unable to save thumbnail to destination - 10https://bugzilla.wikimedia.org/40818 normal; Wikimedia: Media storage; (raimond.spekking) [12:17:50] New review: Hoo man; "Krinkle, please read my comment above, I've explained everything you are criticizing there ;)" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/26440 [12:38:42] New review: Siebrand; "For twn nt to break, we need to keep one message up for translation." [mediawiki/extensions/WikimediaMessages] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/26907 [12:41:43] pa kde si Milossh [12:46:21] New review: Siebrand; "Are we sure there isn't some dependency in wikimedia config, too?" [mediawiki/extensions/ArticleFeedback] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26927 [12:52:00] New patchset: IAlex; "(bug 23222) The "login again" link on Special:Userlogout now has returnto parameter" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26939 [12:52:41] 03(mod) Should Special:UserLogout pass returnto parameters to Special:UserLogin? - 10https://bugzilla.wikimedia.org/23222 -patch -patch-need-review +patch-in-gerrit; +comment (10Alexandre Emsenhuber [IAlex]) [12:55:09] New review: Siebrand; "Don't introduce patchwork messages, please. Using [$1 text] is preferred." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/26939 [12:55:57] 03(mod) API: Add timestamp sort to list=allimages - 10https://bugzilla.wikimedia.org/27202 +patch-in-gerrit (10Jesús Martínez Novo) [12:58:12] New patchset: leucosticte; "Also delete file versions, not only description pages" [mediawiki/extensions/DeleteBatch] (master) - https://gerrit.wikimedia.org/r/26655 [13:06:09] New patchset: IAlex; "(bug 23222) The "login again" link on Special:Userlogout now has returnto parameter" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26939 [13:08:06] 03(mod) Bizarre edit history - 10https://bugzilla.wikimedia.org/40815 +comment (10Alexandre Emsenhuber [IAlex]) [13:09:19] New review: Dereckson; "Demon > to repro the config breaks, could you confirm the procedure is:" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/25761 [13:11:08] New patchset: Toniher; "Corrected tabs" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/26940 [13:11:08] New patchset: Toniher; "in case no option value attrib" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/25735 [13:16:17] regex question for regex gurus: I want to match something like "foo bar baz" or "foo baz" -- the "bar" there can be something, but it's possible that it's not present at all. how would I do that? would a simple "foo (.*) baz" do? (I don't think so, but I'm more than happy to be corrected) [13:18:38] foo (bar )?baz --> will match either if "bar " (with the space) if present or if not present [13:19:33] so it will only match "foo bar baz" and "foo baz", but no "foo barbaz" nor "foo whatever baz" [13:20:14] I don't know if that's the specifiability you want [13:24:20] Vulpix: it's a good start, though matching "foo whatever baz" would also be nice, given that we're talking about spambot phrases and there's usually some level of variation between them -- I've been able to build a few decent regexes by analyzing past spambot messages, but rest assured that they'll come up with new words and whatnot in an attempt to bypass the filters in place [13:25:06] then "foo (.*) baz" is what you need [13:25:37] alright, thanks! [13:26:49] unless you want to match a specific "just one extra word". I don't know if the dot will match newline characters or not, it depends for sure on the flags passed to the regexp [13:27:30] I hope those foo baz aren't too widely used words :P [13:34:04] Vulpix: nah, this is a relatively specific regex for certain type of spam -- do a (Google) search for "and I spend a lot of my free time on the internet" to see what I mean... [13:34:59] I already imagined there weren't simply 2 words [13:42:59] 03(mod) New edit warning above the editing window should be dismissible - 10https://bugzilla.wikimedia.org/40692 +comment (10Oliver Keyes) [13:57:23] New patchset: Chughakshay16; "Miscellaneous changes" [mediawiki/extensions/ConventionExtension] (master) - https://gerrit.wikimedia.org/r/26941 [14:04:04] New patchset: Chughakshay16; "Miscellaneous changes" [mediawiki/extensions/ConventionExtension] (master) - https://gerrit.wikimedia.org/r/26941 [14:08:50] hi [14:09:05] how I run update.php? [14:09:24] ganimedes: Do you have shell access to the server running MediaWiki? [14:09:38] yes [14:10:16] go into the root directory of mediawiki then, then cd maintenance, then php update.php should do [14:10:53] I find the file [14:11:08] but I don´t now how to run ir [14:11:10] *it [14:11:29] 03(NEW) Config viewer is a 404 - 10https://bugzilla.wikimedia.org/40819 minor; Wikimedia Labs: deployment-prep (beta); (damian) [14:11:30] ganimedes: 'php update.php' ;) [14:12:00] but I only see a list [14:12:15] I don´t see nothing like "php" command [14:12:18] ganimedes: Are you sure you have shell access (via ssh) and not only ftp access? [14:12:41] no, I´m not [14:12:44] *sure [14:12:59] ganimedes: Do you see files, like on your computer, or do you have a command prompt? [14:13:40] I see files and things like "delete" "Upload", "Edit", etc [14:14:22] but none "php" [14:14:45] ganimedes: mhm ok... that probably means you don't use ssh... what application are you using? Filezilla? WinScp? [14:15:34] I´ve got no Idea. It's preset by server [14:15:38] anyway, you have to follow these steps: http://www.mediawiki.org/wiki/Manual:Upgrading#Web_updater [14:16:07] ganimedes, what program are you using to connect to the server? [14:16:17] a web browser with some sort of online control panel? [14:16:28] yes [14:20:24] cPanel? [14:22:33] mmmmm, I see the problem... [14:22:39] "SiteGround customers can purchase SSH access as an upgrade to the standard shared hosting account." [14:23:56] "Even if you don't have SSH access, don't worry, you can still execute the script by adding the above command as a cron job." [14:27:20] hi - this is [14:27:25] Sumana showing a newbie IRC [14:28:44] saper, are you around? This person needs help with Windows & git [14:29:27] What's the problem? Maybe I can help [14:29:33] Or ^demon of course [14:30:01] I've also setup git on Windows [14:30:25] * ^demon hides [14:30:52] ok then, maybe not him [14:30:57] i'm looking for help on installing git-review [14:31:34] vasu_wikimedia, is there any particular problem you're running into or do you just not know where to start? [14:34:35] i'm following instructions at http://www.mediawiki.org/wiki/Git/Workflow#Windows [14:34:46] wondering if this is a good start [14:35:00] Yep, should be [14:35:20] cool, will try that and see if it goes smoothly [14:35:42] I followed them with no major problems... I added a few clarifications, though [14:40:07] vasu_wikimedia: just came back, what's up? [14:41:37] vasu_wikimedia: you can always go without git-review:) a bit more commands to remember but works fine without python & stuff [14:45:31] that seems to have worked [14:45:38] :) [14:45:46] thanks, all [14:48:35] New patchset: Chughakshay16; "Small change" [mediawiki/extensions/ConventionExtension] (master) - https://gerrit.wikimedia.org/r/26942 [14:50:55] 03(ASSIGNED) Validator: Call to undefined method SpecialPageFactory::addAliases() - 10https://bugzilla.wikimedia.org/40769 +comment (10Jeroen De Dauw) [14:50:57] [15:21:09] New review: Jeroen De Dauw; "It's better if you amend the original commit in such a case, but this also works :)" [mediawiki/extensions/SemanticForms] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/26940 [15:25:49] New review: Jeroen De Dauw; "The HTML magic this API module is doing is a bit odd, not really relevant for this change though." [mediawiki/extensions/SemanticForms] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/25735 [15:26:13] New review: Jeroen De Dauw; "Tabs corrected in If124a5a7" [mediawiki/extensions/SemanticForms] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/25735 [15:30:40] Hi! Sumana here helping out a newbie who wants some help using CSS to fool with MediaWiki :) [15:31:16] shirki: thanks for doing those acct reqs! [15:31:43] np [15:31:55] * jeremyb wonders what shirki's question is? [15:31:57] New patchset: IAlex; "Use parseAsBlock() instead of parse() to show the error message in OutputPage::showErrorPage()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26943 [15:32:17] trying to hide topbar and navbar; managed to get rid of the content but the margin is stubborn [15:32:22] there's Common.css and ${skin}.css (both in Mediawiki NS) [15:32:34] I'd like to get rid of the margin for a no-nav display [15:32:36] is there a live site we can look at [15:32:36] ? [15:32:44] yes, using the common.css [15:33:08] I can't find the right element to set the margin to 0 [15:34:23] one sec [15:34:42] http://en.wikipedia.org/wiki/User:Shirki/common.css [15:34:56] thanks Jeremy [15:37:41] New review: Demon; "You don't have to run upgrade.php, just place the new Setup.php into your tree when $wgLogo isn't cu..." [mediawiki/core] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/25761 [15:37:57] New patchset: Mwjames; "Consolidation of SMW_custom.css/js to make it RL sane (DO NOT MERGE)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/26944 [15:39:50] shirki: you're on vector? [15:40:23] 03(mod) Creation of new Wikimedia Thailand mailing list - 10https://bugzilla.wikimedia.org/40784 +comment (10Thehelpfulone) [15:40:25] I'm informed that I am [15:40:57] yeah, must be [15:41:55] shirki: so, that didn't do anything for me on monobook so it must be vector specific so you should probably be putting it in vector.css (or are you developing your own skin?) anyway, that's a tangent [15:42:00] i see the margin issue now [15:42:16] my own skin [15:43:08] the elements may still be taking up space [15:43:51] New patchset: Tpt; "(bug 37419) Rewriting of Index pages edit form in PHP" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/10741 [15:43:55] 03(NEW) Call to undefined method CreditsAction::getCredits() - 10https://bugzilla.wikimedia.org/40820 blocker; MediaWiki: General/Unknown; (tim) [15:48:56] 03(mod) Call to undefined method CreditsAction::getCredits() - 10https://bugzilla.wikimedia.org/40820 +comment (10Sam Reed (reedy)) [15:49:11] New review: Reedy; "Caused Bug 40820 - Call to undefined method CreditsAction::getCredits()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22547 [15:49:44] just saw that bug, dealing with it now [15:49:58] 03(mod) Call to undefined method CreditsAction::getCredits() - 10https://bugzilla.wikimedia.org/40820 +comment (10Sam Reed (reedy)) [15:50:09] shirki: https://en.wikipedia.org/w/index.php?title=User:Jeremyb/vector.css&action=history [15:51:32] brb [15:53:14] Thanks!!!!! [15:53:22] that was amazing [15:53:26] highly appreciated! [15:54:02] <^demon|busy> jeremyb: Your CSS skills greatly exceeds mine. [15:54:06] <^demon|busy> I couldn't figure it out :) [15:54:18] ^demon|busy: mine are crap! [15:54:30] <^demon|busy> Mine must be crap^2 [15:54:36] heh [15:54:44] so, party in baltimore? [15:55:59] * jeremyb needs breakfast... bye! [15:56:27] New patchset: Alex Monk; "(bug 40820) Revert most of my changes to includes/actions/CreditsAction.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26945 [15:56:35] that couldn't be possible [15:56:42] and yes we are :-) [15:56:54] 03(ASSIGNED) Call to undefined method CreditsAction::getCredits() - 10https://bugzilla.wikimedia.org/40820 +comment (10Krenair) [15:56:59] Chad and Sumana say hi [15:57:24] New patchset: Mwjames; "Consolidation of SMW_custom.css/js to make it RL sane (DO NOT MERGE)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/26944 [16:02:42] Change merged: Tpt; [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/10741 [16:09:41] New review: Mwjames; "Would be nice if the gets thoroughly tested before it can be merged because I found some old $wgOut-..." [mediawiki/extensions/SemanticMediaWiki] (master); V: 1 C: 0; - https://gerrit.wikimedia.org/r/26944 [16:10:38] Can someone help me, I've made a mistake with gerrit. [16:10:40] I've created by error this branch: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/ProofreadPage.git;a=shortlog;h=refs/heads/mediawiki/extensions/ProofreadPage [16:10:41] Shown: you know ^demon|busy == chad ? [16:10:42] And merge this change inside: https://gerrit.wikimedia.org/r/#/c/10741/ [16:10:44] gah [16:10:44] Is there a way to delete the branch and un-merge the change ? [16:10:50] nvm! [16:12:33] 03(mod) Call to undefined method CreditsAction::getCredits() - 10https://bugzilla.wikimedia.org/40820 +comment (10Tim Landscheidt) [16:12:47] Tpt: which branch? [16:13:05] mediawiki/extensions/ProofreadPage inside of mediawiki/extensions/ProofreadPage [16:13:24] how was that branch even created? [16:13:42] by a git push gerrit HEAD:mediawiki/extensions/ProofreadPage [16:13:51] I've a commit access. [16:14:04] yes [16:14:06] no problem [16:14:10] https://gerrit.wikimedia.org/r/10741 doesn't indicate that branch. it says master [16:14:14] so the commit itself is fine, it should only go to master? [16:14:28] well except in the comment [16:14:56] iI see in the comments: Change has been successfully pushed into branch mediawiki/extensions/ProofreadPage. [16:15:13] Tpt: where are you now locally (git branch -vv) [16:15:23] yes, the commit is that funny local branch [16:15:31] 03(mod) Call to undefined method CreditsAction::getCredits() - 10https://bugzilla.wikimedia.org/40820 +comment (10Tim Landscheidt) [16:16:32] Tpt: I would "git checkout master && git cherry-pick -n efd5d2a79eb76b254bf3825212ca3a3fcf738531 && git commit -c efd5d2a79eb76b254bf3825212ca3a3fcf738531 && git push gerrit master:master" [16:17:22] or maybe faster will work "git push -f gerrit efd5d2a79eb76b254bf3825212ca3a3fcf738531:master" [16:17:43] and then "git push gerrit :mediawiki/extensions/ProofreadPage" to delete the branch [16:18:24] (you might need git push -f for the last one) [16:19:07] saper: I don't want to merge the change in master now. I just want to delete the wrong branche and find a way to tag the change as "unmerged" and way for more review. [16:19:38] then the last command will remove the branch [16:19:47] (... gerrit :) [16:19:55] I've try but I've an error: [16:19:57] git push gerrit :mediawiki/extensions/ProofreadPage [16:19:59] remote: Processing changes: refs: 1, done [16:20:01] To ssh://Tpt@gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage.git [16:20:03] ! [remote rejected] mediawiki/extensions/ProofreadPage (can not delete references) [16:20:05] error: failed to push some refs to 'ssh://Tpt@gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage.git' [16:20:14] git push -f ? [16:20:58] same problem. [16:21:38] maybe a full ref [16:23:17] $ git push -f gerrit :refs/heads/mediawiki/extensions/ProofreadPage [16:23:19] remote: Processing changes: refs: 1, done [16:23:21] To ssh://Tpt@gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage.git [16:23:23] ! [remote rejected] mediawiki/extensions/ProofreadPage (can not delete references) [16:23:25] error: failed to push some refs to 'ssh://Tpt@gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage.git' [16:23:55] probably need to ask ^demon|busy to delete this branch [16:24:04] but your master is fine :) that's good news :) [16:24:24] Yes :-) Thanks for your help ! [16:25:10] Tpt: refs/mediawiki/extensions/Proofreadpage doesny work? [16:25:16] git push -f gerrit :refs/mediawiki/extensions/Proofreadpage ? [16:25:38] git push -f gerrit :refs/mediawiki/extensions/Proofreadpage [16:25:40] remote: Processing changes: refs: 1, done [16:25:41] let me check that on my local gerrit [16:25:42] To ssh://Tpt@gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage.git [16:25:44] ! [remote rejected] refs/mediawiki/extensions/Proofreadpage (can not delete references) [16:25:46] error: failed to push some refs to 'ssh://Tpt@gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage.git' [16:36:05] remote: Branch refs/mediawiki/extensions/Blahblah: [16:36:05] remote: You need 'Push' rights with the 'Force Push' [16:36:05] remote: flag set to delete references. [16:38:34] remote: Processing changes: refs: 1, done [16:38:34] To ssh://saper@l/mediawiki-core.git - [deleted] refs/mediawiki/extensions/Blahblah [16:38:57] Tpt: yes, even as admin I had to add myself permission "Push" and "force push checkbox" [16:39:13] git push -f saper :mediawiki/extensions/Blahbla <-- this syntax worked [16:39:44] 03(mod) Suppressed edits should not appear in Special:DeletedContributions and Special:Undelete - 10https://bugzilla.wikimedia.org/19725 +comment (10DerHexer) [16:41:36] saper: So, there is no way to do it myself (I've not the 'Force Push' right I think) ? [16:42:14] Tpt: no, even default administrator is not [16:42:43] Tpt: and if you are powerful enough there might be a "Revert change" button after it was merged; this brings it back to "review in progress" [16:42:54] but my gerrit is newer than wikimedia's [16:43:32] New patchset: Alex Monk; "Function for "pretty timestamps" that are human readable and understandable." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/15746 [16:43:50] New patchset: Tpt; "Revert "(bug 37419) Rewriting of Index pages edit form in PHP" Error of manipulation This reverts commit efd5d2a79eb76b254bf3825212ca3a3fcf738531" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/26947 [16:46:32] There is a problem : Gerrit try to revert into master https://gerrit.wikimedia.org/r/#/c/26947/ [16:48:06] I think I'll abandon change and revert and create a new change. [16:48:16] And ask to someone to delete the branch. [17:03:16] Change abandoned: Tpt; "(no reason)" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/26947 [17:06:37] 03(NEW) PostgreSQL searches do not treat Unicode full width characters as their normal counterparts - 10https://bugzilla.wikimedia.org/40821 enhancement; MediaWiki: Search; (tim) [17:08:26] New patchset: Tpt; "(bug 37419) Rewriting of Index pages edit form in PHP" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/26948 [17:10:52] New review: Reedy; "To quote Matthais:" [mediawiki/extensions/ArticleFeedback] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/26927 [17:22:44] New review: Raimond Spekking; "i18n review" [mediawiki/extensions/ProofreadPage] (master) C: 0; - https://gerrit.wikimedia.org/r/26948 [17:27:20] 03(mod) Enable subpages in User namespace on kkwiki - 10https://bugzilla.wikimedia.org/40795 +comment (10Bolatbek) [17:27:36] 03(NEW) Specifying file pages for per-point visitedicon does not work - 10https://bugzilla.wikimedia.org/40822 normal; MediaWiki extensions: Maps; (jeroen_dedauw) [17:27:38] New patchset: Raimond Spekking; "Delete translated text from qqq section." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/26949 [17:27:52] 03(mod) Latin characters are displayed as Cyrillic on kkwiki - 10https://bugzilla.wikimedia.org/40800 +comment (10Bolatbek) [17:28:44] 03(mod) Specifying file pages for per-point visitedicon does not work - 10https://bugzilla.wikimedia.org/40822 (10Jeroen De Dauw) [17:31:57] 03(NEW) problems saving language links containing umlaut - 10https://bugzilla.wikimedia.org/40823 normal; MediaWiki extensions: WikidataRepo; (lydia.pintscher) [17:32:15] 03(mod) Enable subpages in User namespace on kkwiki - 10https://bugzilla.wikimedia.org/40795 +comment (10Bolatbek) [17:37:56] 03(NEW) Maps controls parameter breaks on empty list - 10https://bugzilla.wikimedia.org/40824 normal; MediaWiki extensions: Maps; (jeroen_dedauw) [17:38:10] 03(mod) Maps controls parameter breaks on empty list - 10https://bugzilla.wikimedia.org/40824 (10Jeroen De Dauw) [17:38:45] Tpt: have you tried deleting it? `git push origin :branchname` [17:38:58] 03(mod) Maps controls parameter breaks on empty list - 10https://bugzilla.wikimedia.org/40824 +comment (10Jeroen De Dauw) [17:39:00] jeremyb: Yes [17:39:05] Change merged: Tpt; [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/26949 [17:39:26] hrmmm [17:39:30] * jeremyb runs away [17:41:32] aharoni: Hi ! If you have time can you review https://gerrit.wikimedia.org/r/#/c/26948/ ? [17:44:46] New patchset: Raimond Spekking; "[RevisionCommentSupplement] Update optional/ignore tags" [translatewiki] (master) - https://gerrit.wikimedia.org/r/26950 [17:44:56] Change merged: Raimond Spekking; [translatewiki] (master) - https://gerrit.wikimedia.org/r/26950 [17:57:46] so, wmf cluster responds with http 1.0? [17:57:54] and hence is confusedly messed up about chunked uploads? [17:58:17] 03(mod) PostgreSQL searches do not treat Unicode full width characters as their normal counterparts - 10https://bugzilla.wikimedia.org/40821 (10Marcin Cieślak) [17:58:18] 03(mod) PostgreSQL/pgsql support (tracking) - 10https://bugzilla.wikimedia.org/384 (10Marcin Cieślak) [17:59:52] anyone? [17:59:56] well, it is saturday morning [17:59:59] * yuvipanda sighs [18:00:23] is 'postgresql' keyword gone from bugzilla? [18:00:45] yuvipanda: no, it's saturday evening [18:00:53] well, it's 11:30 saturday night [18:00:54] here [18:01:05] evening, morning, same thing :) [18:01:07] yuvipanda: where's the problem with HTTP 1.0? [18:01:14] saper: no chunked upload [18:01:23] as in, http chunked [18:01:28] not the experimental fireogg stuff we have [18:01:35] so I need to know the size of the file beforehand [18:01:44] which... sucks [18:02:20] saper: unless there's something I'm missing [18:02:31] I was wondering why uploads were succeeding against my local mediawiki install [18:02:35] but failing on testwiki [18:02:58] mine seems to be okay with 1.1, and accepts chunked uploads no problemo [18:03:03] but wmf servers don't seem to [18:03:17] so i'm just wondering if I'm missing something horribly, or if this really is the status quo [18:03:20] saper: ^ [18:03:40] it's nginx now [18:04:30] saper: did you get my messages at all? [18:04:35] freenode keeps disconnecting me :( [18:04:57] yes [18:05:05] [Read error: [18:05:05] Connection reset by peer] [18:05:27] it goet TCP reset from you [18:05:35] recap: Chunked Upload (HTTP Transfer-Encoding: chunked) [18:06:16] honestly [18:06:35] saper: Transfer-Encoding:Chunked missing in 1.0. [18:06:40] mediawiki seems to be able to handle them just fine [18:06:45] something in the middle seems to strip that out [18:18:45] New patchset: Tim Landscheidt; "Enable unit tests for PostgreSQL searching." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/24619 [18:19:27] 03(mod) Validator: Call to undefined method SpecialPageFactory::addAliases() - 10https://bugzilla.wikimedia.org/40769 +comment (10Nischay Nahata) [18:29:58] 03(NEW) Labs DNS configuration only points at a single LDAP server - 10https://bugzilla.wikimedia.org/40825 normal; Wikimedia Labs: General; (rlane32) [18:30:54] 03(mod) i-0000049c / integration-wikibugs unreachable - 10https://bugzilla.wikimedia.org/40740 +comment (10Ryan Lane) [18:36:47] New review: Hoo man; "See comments... shouldn't this also delete the rows from the hidden table at the end?" [mediawiki/extensions/Oversight] (master) C: -1; - https://gerrit.wikimedia.org/r/18229 [18:39:02] *nobody* does chunked uploads? :( [18:40:17] man, why do all developers disappear on weekends, when i have time to appear and make stuff and need somebody to review it. [18:41:47] <^demon> MatmaRex: Developers have lives? [18:41:50] MatmaRex: Most are foundation employees which simply don't work on weekends :/ [18:41:53] <^demon> No, nevermind. Couldn't possible be that. [18:42:37] +1 to MatmaRex [18:42:55] yeah, i undersatnd why, doesn't mean i like it :) [18:43:06] WMF devs and volunteers are kinda incompatible in this way [18:43:15] so we serve HTTP/1.0 [18:43:22] and I *guess* that's mostly squid's doing [18:43:39] and *that* explains why my upload code passes wonderfully when I hit my local mediawiki instance [18:43:43] and fails when I hit testwiki [18:44:23] Sigh, it sucks when you're working on something on a Saturday night and there's nobody else around [18:45:07] booyeah killed a mosquito! [18:45:22] ^demon: Tpt wanted to nuke "mediawiki/extensions/ProofreadPage" *branch* in the extensions/ProofreadPage *project* and - if possible - bring https://gerrit.wikimedia.org/r/#/c/10741/ back to "Review in Progress". Looks like only überadmins can do that. [18:45:55] New patchset: Tim Landscheidt; "Remove obsolete comment." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26951 [18:46:44] <^demon> saper: Branch is easily deleted. Resubmitting the commit to master is a normal submission? [18:46:52] <^demon> There's no magic "mark this no longer as merged" button [18:47:00] ^demon: in my gerrit (trunk) there is a "revert" button [18:47:45] "Revert Change" - appears after submit [18:47:56] not sure if we have it or not that's why asking :) [18:48:07] New patchset: Alex Monk; "bug 18598 - maint script to migrate legacy Oversight data" [mediawiki/extensions/Oversight] (master) - https://gerrit.wikimedia.org/r/18229 [18:48:34] ^demon: he does not want to submit it to master yet, push was a total mistake [18:48:38] New review: Hoo man; "$ grep -r 'SearchDbTest' . -l" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/26951 [18:50:02] on my gerrit I had to add myself to have "Push" and "force push" right to All-Projects.git [18:50:03] <^demon> saper: Ohhhh, ok. [18:50:30] <^demon> It's a Project Owner right. That was fixed in 2.5 iirc, it now relies on reference permissions on refs/for/* [18:50:47] New patchset: Chughakshay16; "Changes in how Author Registration page" [mediawiki/extensions/ConventionExtension] (master) - https://gerrit.wikimedia.org/r/26952 [18:51:01] New patchset: Demon; "Revert "(bug 37419) Rewriting of Index pages edit form in PHP"" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/26953 [18:51:11] <^demon> Done. [18:51:12] <^demon> brb [18:51:45] ^demon: I don't know, in my "master" gerrit even überadmin couldn't do that right away. [18:52:09] <^demon> Uberadmin shouldn't be able to. It's based on create reference permissions iirc. [18:52:14] New review: Alex Monk; "Probably, but I figure it's safer to leave that step to the user. Maybe I should have it print an in..." [mediawiki/extensions/Oversight] (master) C: -1; - https://gerrit.wikimedia.org/r/18229 [18:52:27] <^demon> Oh, that's "Restore" after abandon. [18:52:30] btw gitweb didn't show this branch at all https://gerrit.wikimedia.org/r/gitweb?p=mediawiki%2Fextensions%2FProofreadPage.git;a=commit;h=efd5d2a79eb76b254bf3825212ca3a3fcf738531 [18:52:45] <^demon> I deleted the branch like you asked. [18:52:54] I mean before it look like this too [18:52:57] looked [18:52:59] strange [18:53:33] New patchset: Chughakshay16; "Changes in Author Registration page" [mediawiki/extensions/ConventionExtension] (master) - https://gerrit.wikimedia.org/r/26952 [18:55:02] thanks [18:55:06] Tpt: ^^ [18:55:06] ^demon saper: Thansk a lot ! All is fine now ! [18:55:29] New patchset: saper; "Revert "(bug 37419) Rewriting of Index pages edit form in PHP"" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/26954 [18:56:31] New patchset: Chughakshay16; "Changes in Author Registration page" [mediawiki/extensions/ConventionExtension] (master) - https://gerrit.wikimedia.org/r/26952 [18:56:37] 03(mod) Validator: Call to undefined method SpecialPageFactory::addAliases() - 10https://bugzilla.wikimedia.org/40769 +comment (10Jeroen De Dauw) [18:56:46] Tpt: ouch... I pushed "Revert Change" on your change... guess what? we have now https://gerrit.wikimedia.org/r/#/c/26954/ [18:57:29] good. [18:57:45] Tpt: maybe if you press "revert change" it will be automatically switched to Review in Progress? [18:58:07] 03(mod) OpenLayers form input geocoding broken - 10https://bugzilla.wikimedia.org/38139 +comment (10Jeroen De Dauw) [18:58:26] I've try it 2 hours ago and nothing has change. [18:58:32] ok [18:58:35] * 4 hours [18:58:36] strange [18:59:21] <^demon> Revert change creates a new change to undo what you did. [18:59:31] <^demon> It doesn't reopen the change. [18:59:48] Change abandoned: Tpt; "This is a duplicate of change https://gerrit.wikimedia.org/r/#/c/10741/" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/26948 [19:00:24] <^demon> Submitted, merge pending? [19:00:27] <^demon> Wtf gerrit [19:00:47] <^demon> saper: I'm going to grant you owner rights on that repo so you can mess around with it. [19:01:33] 03(NEW) OpenLayers form input broken - 10https://bugzilla.wikimedia.org/40826 normal; MediaWiki extensions: SemanticMaps; (jeroen_dedauw) [19:01:51] 03(mod) OpenLayers form input broken - 10https://bugzilla.wikimedia.org/40826 (10Jeroen De Dauw) [19:02:13] New review: Szymon ?wierkosz; "Any other questions?" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/4967 [19:03:07] Change abandoned: Szymon ?wierkosz; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4658 [19:03:16] thanks, may be I'll do some work :) [19:05:32] wow, I managed to check out All-Projects.git and mediawiki.git locally [19:06:09] <^demon> mediawiki.git is just a permissions repo, HEAD should point to refs/meta/config. [19:06:22] <^demon> And All-Projects I fixed Read permissions on a couple months ago [19:07:20] Change restored: Tpt; "(no reason)" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/26948 [19:08:17] There is no merge button in change https://gerrit.wikimedia.org/r/#/c/10741 [19:08:35] New patchset: Siebrand; "Comment out unused local variable and reference class variable properly." [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/26776 [19:08:45] New patchset: Siebrand; "Doc updates." [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/26777 [19:08:51] New patchset: Siebrand; "Replace deprecated method calls." [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/26778 [19:09:46] New review: Siebrand; "@Jeroen: Indeed." [mediawiki/extensions/Maps] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26603 [19:09:55] New patchset: Siebrand; "Some maintenance for Maps extension." [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/26603 [19:10:20] New patchset: Siebrand; "Maintenance for EducationProgram extension." [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/26586 [19:11:03] Tpt: besides, I always get lost as the casual user in the maze of index pages w/proofread [19:11:06] New patchset: Tpt; "(bug 37419) Rewriting of Index pages edit form in PHP" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/26948 [19:12:23] New patchset: saper; "Revert "(bug 37419) Rewriting of Index pages edit form in PHP"" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/26955 [19:12:34] Change abandoned: saper; "experiment" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/26955 [19:13:24] spaer: Yes, It's a real problem. I work in order to increase the extension usability. [19:13:37] * saper [19:13:47] I helped some people edit today for the first time [19:13:49] or learn Git [19:13:55] or learn to make user scripts/css :) [19:13:56] yya [19:13:58] yay* [19:14:51] saper: If you can review this patch (before the good merge into master ;-) ), that increase usability of index form https://gerrit.wikimedia.org/r/#/c/26948/ [19:15:21] it's waiting for some months. [19:16:28] 03(NEW) Add a commons category field to the monuments database - 10https://bugzilla.wikimedia.org/40827 normal; Monuments database: Database; (maarten) [19:16:36] Tpt: are you aware of any issues with zooming scans on firefox? [19:17:06] Beau_: No. [19:17:40] New review: Siebrand; "PS2 is a plain rebase. PS3 contains updates based on feedback." [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/26586 [19:17:43] 03(mod) Labs DNS configuration only points at a single LDAP server - 10https://bugzilla.wikimedia.org/40825 +comment (10Damian Z) [19:17:45] Wait. Yes, there is a bug between zoom and old toolbar [19:17:46] 03(NEW) Use the commons category field in the database to categorize images - 10https://bugzilla.wikimedia.org/40828 normal; Monuments database: Unused images; (maarten) [19:17:47] 03(mod) Add a commons category field to the monuments database - 10https://bugzilla.wikimedia.org/40827 (10Maarten Dammers) [19:17:59] Beau_: It's good to see you here ! [19:18:12] New patchset: Siebrand; "Maintenance for EducationProgram extension." [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/26586 [19:18:14] I am just passing by, not stopping though. [19:19:19] Beau_: :-( [19:19:34] Tpt: can you point me to a bug report? I will forward it to interested person. [19:21:18] ( hi Beau_ ) [19:21:40] * yuvipanda waves at sumanah  [19:21:46] <[KrusheR]> does someone know of a javascript snippet to allow to insert "spoiler" sections? [19:21:56] hi sumanah [19:22:06] <[KrusheR]> i mean, hidden sections wich shows themselves pushing a button or something [19:22:35] [KrusheR]: try to look for mw-collapsible or something like this [19:22:46] <[KrusheR]> is that an extension? [19:22:54] no, name of css class [19:22:55] hi yuvipanda [19:23:11] <[KrusheR]> i see [19:23:11] <[KrusheR]> thanks [19:23:14] New patchset: Siebrand; "More maintenance for DeleteBatch extension." [mediawiki/extensions/DeleteBatch] (master) - https://gerrit.wikimedia.org/r/26582 [19:23:32] New review: Siebrand; "PS2 fixes a merge conflict." [mediawiki/extensions/DeleteBatch] (master) - https://gerrit.wikimedia.org/r/26582 [19:24:40] o hi Beau_ [19:24:59] hi MatmaRex, are submitting patches to MW? :) [19:25:18] quite :) https://gerrit.wikimedia.org/r/#/dashboard/417 [19:25:44] nice [19:25:57] Change merged: Siebrand; [mediawiki/extensions/DeleteBatch] (master) - https://gerrit.wikimedia.org/r/26582 [19:26:36] Change abandoned: Siebrand; "Was updated in I146e6421." [mediawiki/extensions/DeleteBatch] (master) - https://gerrit.wikimedia.org/r/26752 [19:30:04] New review: Siebrand; "Because of a recent merge, this should be rebased manually." [mediawiki/extensions/DeleteBatch] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/26655 [19:30:15] New patchset: Siebrand; "Maintenance for TimedMediaHandler extension." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/25745 [19:30:31] New review: Madman; "Using Linker::revUserTools is much cleaner. :)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/26662 [19:31:32] New patchset: Siebrand; "Maintenance for Echo extension." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/25223 [19:33:05] Change merged: Siebrand; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/25223 [19:33:08] New patchset: Siebrand; "More maintenance for LiquidThreads." [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/24690 [19:33:20] Change merged: Siebrand; [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/24690 [19:33:44] New patchset: Siebrand; "Maintenance for AbuseFilter extension." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/22361 [19:33:47] New patchset: Siebrand; "Replace two remaining wfMsg() calls." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/24686 [19:34:09] New patchset: Siebrand; "Maintenances updates for Moodbar." [mediawiki/extensions/MoodBar] (master) - https://gerrit.wikimedia.org/r/24571 [19:36:13] New patchset: Siebrand; "Maintenance for Configure extension." [mediawiki/extensions/Configure] (master) - https://gerrit.wikimedia.org/r/23483 [19:37:56] 14(DUP) Error creating thumbnail: Unable to save thumbnail to destination - 10https://bugzilla.wikimedia.org/40818 +comment (10Aaron Schulz) [19:37:57] 03(mod) Shorten thumbnail name convention - 10https://bugzilla.wikimedia.org/39697 +comment (10Aaron Schulz) [19:38:23] New patchset: Alex Monk; "(bug 40292) Don't use hardcoded brackets" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/24393 [19:39:24] New patchset: Siebrand; "Maintenance for AdminLinks extension." [mediawiki/extensions/AdminLinks] (master) - https://gerrit.wikimedia.org/r/12999 [19:44:21] New review: Siebrand; "This could probably do with some tests..." [mediawiki/core] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/26743 [19:44:22] Change merged: Siebrand; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26743 [20:00:13] 03(mod) Display redirect status in MediaWiki's info action - 10https://bugzilla.wikimedia.org/40154 +comment (10Krenair) [20:02:45] Any Bugzilla admins around? [20:02:59] Thehelpfulone, Reedy? [20:03:47] yep [20:03:55] Oh, there you are. [20:03:56] Hi. [20:03:59] Thehelpfulone: https://bugzilla.wikimedia.org/show_bug.cgi?id=39981 [20:04:01] hi [20:04:04] 03(NEW) ?action=info doesn't show cacading protection - 10https://bugzilla.wikimedia.org/40829 normal; MediaWiki: General/Unknown; (legoktm.wikipedia) [20:04:05] Can you add b/mzmcbride.com and... [20:04:13] one other e-mail address to the CC list of that bug? [20:04:17] I'm getting the other address, hold on. [20:04:21] ok [20:04:28] madman.enwiki/gmail.com [20:04:32] Those two addresses, please. [20:04:36] sure [20:05:00] done [20:05:15] You're wonderful, thanks! [20:05:24] No problem :) [20:05:58] ... That's a security bug... [20:06:22] Right. [20:06:28] That's why I couldn't access it. [20:06:41] Which I created *hides under table* but has been fixed in master for a bit. [20:06:48] Change merged: Siebrand; [mediawiki/extensions/ArticleFeedback] (master) - https://gerrit.wikimedia.org/r/26927 [20:06:56] You already knew about it, and I suspect Madman did because he hid the fix in another mostly-unrelated commit [20:07:03] So I guess it's okay.. [20:07:04] Right. [20:07:09] I didn't actually know about it until just now. [20:07:18] And I didn't what the bug's status was. [20:07:23] Because I couldn't read the comments. [20:07:33] NEW [20:07:38] But nearly fixed! [20:07:59] There's no good reason I couldn't be a Bugzilla admin. [20:08:12] And I didn't hide the change, just found the function I should have been using from the very beginning (still learning the codebase, le sigh). [20:08:20] Except that I'd probably eliminate half the stupid keywords one day. [20:08:21] Change merged: Siebrand; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26939 [20:08:38] You hid it in plain sight! [20:08:41] Next time someone sees me use information directly from the database, please smack me quite hard. [20:09:00] In fact, I'm within your reach, Brooke; you could do it. [20:09:13] Hot. [20:09:44] I thought so. [20:10:14] No one responded to my Java jibe on wikitech-l. I am sad. :p [20:10:27] 03(mod) Reimplement MediaWiki's info action (tracking) - 10https://bugzilla.wikimedia.org/38450 (10Krenair) [20:10:27] 03(mod) ?action=info doesn't show cacading protection - 10https://bugzilla.wikimedia.org/40829 (10Krenair) [20:10:35] RogueMadman, Was that the one suggesting to port MW to Java? [20:10:40] Yes. ;x [20:11:08] I get to make fun of Java because it's my job to work with it 10-12 hours a day. :p [20:11:19] 'Why don't we just port MediaWiki to Java?' lolololololololololol [20:11:19] I swear the dev mailing list provides half my weekly entertainment [20:11:25] HAHA. [20:11:32] (from #wm-labs) [20:11:37] 03(mod) Display redirect status in MediaWiki's info action - 10https://bugzilla.wikimedia.org/40154 +comment (10MZMcBride) [20:11:37] That's awesome. ;x [20:12:26] RogueMadman has had his mouth sewn shut and has had one eye punched out. [20:12:29] Sad. [20:12:32] https://gerrit.wikimedia.org/r/#/c/22880/ probably needs rebasing [20:12:41] True. Will do. [20:12:47] After https://gerrit.wikimedia.org/r/#/c/26743/ [20:13:05] Yep. [20:13:32] 03(mod) ?action=info doesn't show cascading page protection - 10https://bugzilla.wikimedia.org/40829 +easy; summary (10MZMcBride) [20:13:34] Logging on to my dev instance to do it now. [20:14:01] Krenair: You don't happen to have a public dev instance of MediaWiki, do you? [20:14:09] I'd like to see how action=credits looks merged in. [20:14:13] I need to ask for a public IP for mine. [20:14:18] Brooke: I can give you a screenshot. [20:14:22] Badly, apparently [20:14:26] That'll work. [20:14:28] It broke all wikis with a certain config setting [20:14:34] Heh. [20:14:43] But no, I don't [20:15:15] We don't have master.mediaiwki.org or whatever? [20:15:21] http://imgur.com/PmTHO [20:15:28] RogueMadman, is that the labs instance that I noticed the other day? [20:15:41] Hmmm. [20:15:41] Krenair: I don't know. What labs instance did you notice the other day? :p [20:15:49] Yeah, that looks like someone accidentally pasted it in. [20:15:52] One sec I'll find it :P [20:15:58] mediawiki-dev-1? [20:16:12] That was it [20:16:25] I noticed there wasn't a labs project for general mediawiki development, mediawiki instances always on master, instances for different configs and tests, etc., so I asked for one. [20:16:25] And what does it do when there are a thousand authors? [20:16:31] Or more. [20:16:32] Brooke: Cries. [20:16:41] Actually, there's a more concerning output. *finds* [20:16:52] Dies, probably [20:16:55] Heh. [20:17:05] I'm still not sure about the value of ?action=credits. [20:17:10] http://imgur.com/Y8hs5 [20:17:14] As a separate action or merged in. [20:17:17] That's a bug; I just haven't looked for a duplicate yet. [20:17:18] It seems weird. [20:17:33] Why is your shit always in German? [20:17:41] ... [20:17:43] Because it's a good way to test localization. [20:17:51] Interesting. [20:17:54] And it's Scheisse, silly. [20:17:57] Should make it use the config settings which action=credits did probably [20:18:07] It has config settings? [20:18:13] What's the use-case for this feature, again? [20:18:25] It's just an alphabetized version of ?action=history? [20:18:28] Maybe it should move there. [20:18:29] Does it not? I don't think I reviewed the change that moved it over. [20:19:07] Brooke, wgMaxCredits and wgShowCreditsIfMax [20:19:17] :-/ [20:19:47] On the current master (after I killed action=credits), if wgMaxCredits is anything other than 0, you can't load any pages [20:19:55] ( https://bugzilla.wikimedia.org/show_bug.cgi?id=40820 ) [20:19:57] Nice. [20:20:25] I should've been more careful when removing that method... [20:20:26] Oops. [20:20:30] Yeah.. [20:21:23] public static function getCredits() { return InfoAction::getCredits(func_get_args()); } [20:21:25] Or something. ;x [20:21:35] Just make *everyone* confused. ^^ [20:21:57] Or vice versa from InfoAction since it makes sense to have getCredits under CreditsAction. [20:22:13] So is the credits thing merged? [20:22:20] Yeah it was [20:22:22] I'd really like to see more thought there before it gets moved. [20:22:34] Otherwise I worry it'll get moved two or three times. [20:22:35] Hmm. [20:23:00] On a side note, I think I just noticed why the Echo/LQT integration broke [20:24:03] Change merged: Siebrand; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/24393 [20:24:17] 03(mod) Validator: Call to undefined method SpecialPageFactory::addAliases() - 10https://bugzilla.wikimedia.org/40769 +comment (10Nischay Nahata) [20:24:34] https://translatewiki.net/w/i.php?title=Main_Page&action=info [20:24:37] BTW. [20:25:16] 03(FIXED) notification-edit-talk-page has hardcoded brackets - 10https://bugzilla.wikimedia.org/40292 +comment (10Krenair) [20:25:19] Right; that's where it was before my hook code moved it (incidentally). : [20:25:21] :p* [20:25:31] is there a wg setting that just disables the category div above the footer? [20:26:04] wgUseCategoryBrowser doesn't seem to [20:27:54] 03(mod) Validator: Call to undefined method SpecialPageFactory::addAliases() - 10https://bugzilla.wikimedia.org/40769 +comment (10Nischay Nahata) [20:28:56] Brooke: Oh, I just noticed you were probably talking about "and ." [20:29:04] That code clearly needs to be revamped. [20:29:22] I'm talking about the whole thing. [20:30:35] Oh, hey, it's been updated. [20:30:36] ;x [20:31:07] There are the aesthetics, which I hate. [20:31:13] But there's also the functionality, which seems a bit questionable to me. [20:31:17] I guess it makes sense for smaller pages. [20:31:20] I guess. [20:31:28] But then, the question is why you wouldn't just skim the page history. [20:31:35] For large pages, it can't really work... [20:31:36] New patchset: Hoo man; "(bug 7851) Added AJAX patrolling (mediawiki.page.patrol.ajax)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26440 [20:31:49] At which point, I wonder why have the feature at all. [20:32:09] New review: Hoo man; "Fixed $wgAjaxPatrol." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/26440 [20:32:53] I think the theory is it makes it easier to do the attribution required by CC-BY-SA without copying the entire page history. [20:33:25] You wouldn't do either for CC-BY-SA attributino. [20:33:27] attribution [20:33:37] You'd just provide a pointer (a URL). [20:33:52] You're saying that people want a pointer to credits instead of history? [20:34:03] No, I'm saying for something offline. [20:34:30] New patchset: Hoo man; "(bug 7851) Added AJAX patrolling (mediawiki.page.patrol.ajax)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26440 [20:34:46] New review: Hoo man; "White spaces..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/26440 [20:35:06] i see a skin has to take it as a custom action, musta done in prior, upgrade restored [20:35:35] New patchset: Jeroen De Dauw; "Implemented GeoCoordinateValue" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/26964 [20:36:46] Am struggling to understand RogueMadman's InfoAction hook [20:37:17] JuanDaugherty: can't you hide it via CSS? [20:37:38] Well, you have just the right person here to ask questions. ;x [20:38:15] MatmaRex, prolly will check in a bit what I did in 14 (doing 19 now) [20:39:16] New patchset: Umherirrender; "Add userToolLinks to action=info" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26662 [20:39:47] Ah, nvm, worked it out [20:40:06] New review: Umherirrender; "Rebased and resolved merge conflict" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/26662 [20:40:17] JuanDaugherty: adding "#catlinks{ display:none; }" to your [[MediaWiki:Common.css]] should hide it. [20:40:41] Ah, k. Let me know if can do anything to make it simpler; the hook revision was done around midnight on Friday so I don't claim it's particularly sensible, just that it works. :p [20:42:25] 04(REOPENED) Merge action=credits into action=info - 10https://bugzilla.wikimedia.org/39533 +comment (10MZMcBride) [20:43:11] I saw REOPENED in my e-mail and immediately knew who did it. ;x [20:45:19] New patchset: Burthsceh; "Fix database schema and user group" [mediawiki/extensions/RevisionCommentSupplement] (master) - https://gerrit.wikimedia.org/r/26965 [20:47:50] New patchset: Daniel Werner; "(bug 39522) solved bug 39522 for EditableValue.tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26966 [20:47:51] New patchset: Daniel Werner; "Refactored some of the EditableValue tests." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26967 [20:49:26] New patchset: Daniel Werner; "Use $.fn.val( ... ) instead of $.attr.( 'value', ... ) to set input box values" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26968 [20:49:49] RogueMadman, so when I don't set a table header as a Message, I get something like this: [20:49:50] <pageinfo-LiquidThreads> [20:50:00] (It's literally displayed like that on the page...) [20:50:12] Right. The header has to be a message. [20:50:52] -.- ok [20:51:06] I know. :( [20:51:10] If you look at the changes, you'll see why the array was organized the way it was. [20:51:26] And you can't have the choice of message or string in array keys. [20:51:35] (At least, I'm pretty sure you can't.) [20:51:35] Actually, now that I think about it, that makes sense. Okay. [20:51:57] I mean, to a limited extent that enforces localization and escaping. ;) [20:53:31] New patchset: Siebrand; "Partical revert of Id5221b92: Don't use WikiPage::factory()." [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/26969 [20:53:57] New patchset: Siebrand; "Partial revert of Id5221b92: Don't use WikiPage::factory()." [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/26969 [20:54:05] Change merged: Siebrand; [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/26969 [21:05:40] New patchset: Alex Monk; "(bug 38534) Add LQT status to action=info" [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/26970 [21:05:55] Sometimes I sit and wonder what's going on when I'm waiting for git review to finish... [21:06:14] gerrit-wm: Yay! [21:06:21] 03(mod) Add LiquidThreads status to MediaWiki's info action - 10https://bugzilla.wikimedia.org/38534 +comment (10Krenair) [21:06:23] I was going to do that but don't know LQT at all. :p [21:07:57] Krenair: You can just use wfMessage( 'pageinfo-usinglqt' ) if you want. InfoAction will automatically escape it. [21:08:10] Same with all three messages there. [21:08:13] Krenair: git checkout is going on, i think. [21:08:33] Krenair: if the code you're reviewing is old, git has a lot of stuff to check out. [21:08:51] But it's code that I just wrote... [21:08:52] usually, it'd show a progress bar, but obviously gerrit sucks, so it doesn't. [21:08:56] ah, this. [21:09:07] then it makes at least two ssh connections every time you run it. [21:09:17] i have no idea why, but it asks for ssh key password twice. [21:09:18] Maybe it's just my terrible upload bandwidth? :P [21:09:32] and it also seems to check for updates [21:09:40] i'm not sure if every time, but at least from time to time it does [21:10:08] basically, there's a lot of completely unnecessary shit going on every time. [21:10:09] Nah, it takes quite a while from Labs too. ;x [21:11:05] http://www.speedtest.net/result/2225544924.png [21:11:21] Ouchie. [21:11:29] But at least you got an F+. [21:11:41] New patchset: Burthsceh; "Fix database schema and user group" [mediawiki/extensions/RevisionCommentSupplement] (master) - https://gerrit.wikimedia.org/r/26965 [21:11:55] ugh. that's F+? [21:12:04] Heh. [21:12:06] i'm on a 1 mbps download connection :( [21:12:35] and upload is about 200kbps, most. [21:12:51] hooray for central-eastern europe... [21:14:18] I think to some extent the score's based off of typical results in your region. [21:14:35] How does the ?action=info hook code work? [21:14:42] Does it require each extension adding its own section? [21:14:56] 'cause that's what Special:Preferecnes does currently, and it's pretty nasty. [21:14:58] No. [21:15:04] Hmm. [21:15:13] https://gerrit.wikimedia.org/r/#/c/26970/ [21:15:18] That looks like it'll be in its own section. [21:15:21] You can use $pageInfo['header-basic'][] = array('Moo', 'True'); [21:15:22] New patchset: Raimond Spekking; "[ArticleFeedback] Update ignore key" [translatewiki] (master) - https://gerrit.wikimedia.org/r/26971 [21:15:23] Am I misreading? [21:15:27] To add to Basic Information, for example. [21:15:30] Okay. [21:15:32] :-) [21:15:35] Change merged: Raimond Spekking; [translatewiki] (master) - https://gerrit.wikimedia.org/r/26971 [21:15:43] Well, that's what that change would do, yes. [21:15:52] RogueMadman, $pageInfo['header-basic'][] = array( 'Moo', 'True' ); [21:15:53] :) [21:16:16] * siebrand comforts Krenair . http://www.speedtest.net/result/2225551357.png [21:16:24] * RogueMadman headdesks. [21:16:37] ... [21:17:05] ALSO. $pageInfo['header-basic'][] = array( wfMessage( 'Moo' ), wfMessage( 'True' ) ); [21:17:42] Brooke makes a good point, though, Krenair; would the LQT status be better put somewhere like Basic information? [21:17:44] So spacey. [21:17:58] I'd like to avoid further sections. [21:18:04] The protection section already makes me feel weird inside. [21:18:37] I would criticize the spaciness more but the software I work on has the same style for the C++ code. Not for the Java code, though. [21:18:57] So, port MW to Java? ;) [21:19:11] Krenair: And run it under Oracle WebLogic. [21:19:34] Pros: You can take a lunch break while MediaWiki boots! [21:19:47] I think there was some PHP JVM port [21:19:57] 03(NEW) MediaWiki:Post-expand-template-argument-category - 10https://bugzilla.wikimedia.org/40830 normal; MediaWiki: Internationalization; (romaine_wiki) [21:20:44] Did jenkins-bot just ignore https://gerrit.wikimedia.org/r/#/c/26970/? ;x [21:21:46] Fatal error: Call to a member function getUser() on a non-object in /var/www/MediaWiki/Git/core/includes/actions/InfoAction.php on line 217 [21:22:59] 03(mod) Validator: Call to undefined method SpecialPageFactory::addAliases() - 10https://bugzilla.wikimedia.org/40769 +comment (10Jeroen De Dauw) [21:23:22] (from a non-existing page... I guess this is fixed in Madman's patch which is awaiting review) [21:23:44] Yeah. :/ [21:23:54] hi [21:24:00] hi [21:24:13] I want to upgrade a 1.17 wiki to 1.19 [21:25:15] but I don´t find the patch [21:25:46] Why do you still have a 1.17 wiki? o.O [21:25:50] ganimedes: https://www.mediawiki.org/wiki/Upgrading [21:26:05] the wiki is new but [21:26:09] Krenair: He's trying to make that no longer the case. :p [21:26:17] the host give you [21:26:31] that package to download [21:27:01] ganimedes: Unless you have a lot of custom modifications to the MediaWiki core (hopefully not), it makes more sense just to replace all 1.17 files with 1.19, not patch them. [21:27:07] Per the wiki page MatmaRex just gave you. [21:27:43] ok [21:28:12] Let us know how it goes and if you need any further assistance. :) [21:28:12] I´ve got just three extension [21:28:20] newly installed [21:28:42] Might want to check their compatibility with 1.19, but as long as you don't replace LocalSettings.php, they shouldn't be affected. [21:28:57] ok, thanks! [21:29:27] 03(mod) Add LiquidThreads status to MediaWiki's info action - 10https://bugzilla.wikimedia.org/38534 +comment (10MZMcBride) [21:29:31] Sure thing. :) [21:30:09] 03(mod) Validator: Call to undefined method SpecialPageFactory::addAliases() - 10https://bugzilla.wikimedia.org/40769 +comment (10Nischay Nahata) [21:30:32] Brooke: The messages are definitely there, where you linked, so it may indeed just be Gerrit being stupid. [21:31:08] Oh. I see what you mean; it shows the added lines twice. [21:31:16] Brooke, I recommend not using unified [21:31:25] ... Not for me it doesn't [21:32:20] New patchset: Burthsceh; "Fix database schema and user group" [mediawiki/extensions/RevisionCommentSupplement] (master) - https://gerrit.wikimedia.org/r/26965 [21:32:28] I see. [21:32:31] Fatal error: Call to undefined method WikiPage::getContent() in /var/www/MediaWiki/Git/extensions/LiquidThreads/pages/TalkpageView.php on line 140 [21:32:33] Ugh, now what [21:32:36] Brooke: It's the equivalent of En and Qqq. [21:32:43] One is the messages, one is documentation. [21:32:44] It *is* En and Qqq [21:32:54] You just don't see the common lines which make that clear. [21:33:22] Yes, I understand that; I meant the equivalent of MessagesEn.php and MessagesQqq.php, which would be two files. [21:33:35] Explaining why apparently the same array elements are listed twice in the same file. [21:36:38] It doesn't show me a diff at all. [21:36:42] But most (if not all) extensions have their i18n structured like that [21:37:05] Brooke: Well, then client fail? [21:37:16] Works for me: https://gerrit.wikimedia.org/r/#/c/26970/1/i18n/Lqt.i18n.php [21:37:37] Krenair: Right, but a lot of us don't work in extensions at all; when I did, they were internal-only extensions so I never bothered with i18n. [21:37:41] Oh, hmm. [21:37:42] https://gerrit.wikimedia.org/r/#/c/26970/1/i18n/Lqt.i18n.php,unified [21:37:45] (Yes, I am a terrible person and I'm paying for that now.) [21:37:49] I thought they were supposed to have a green background or something. [21:37:54] When it's an added line. [21:38:13] I see it now. [21:38:22] You're looking at the unified diff, not side-by-side [21:38:31] I thought both had background color shifts. [21:38:33] Unified diff uses green text instead of background [21:38:41] That text is not green. [21:38:48] It is on my screen. [21:38:52] Or if it is, it's distinguishable from black. [21:39:14] New patchset: Jeroen De Dauw; "Added base for GeoCoordinateParser and introduced ParserOptions interface" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/27015 [21:39:15] You must have really poor eyesight [21:39:16] WORKSFORME. Better monitor required. :p [21:39:39] New review: Burthsceh; "I think good in that database schema." [mediawiki/extensions/RevisionCommentSupplement] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/26965 [21:40:28] MatmaRex: er... looks like I didn't have your cologneblue change merged in :( [21:40:39] Krenair, RogueMadman: http://pruebita.com/gerrit-26970.png [21:40:41] That's what I see. [21:40:57] That's green. [21:41:03] Added lines are clearly green [21:41:06] I guess. [21:41:09] Hmm. [21:41:09] so now changing left/right/fixed/floating does not work blus the sidebar looks strange, it's tool far away from the top menu [21:41:11] Common lines are clearly light grey [21:41:14] In fact, it is #006000. [21:41:20] To be more precise. [21:41:21] It looks like black to me. [21:41:34] saper: uh, re: your mail? [21:41:36] If I zoom in, it starts to look like green a bit. [21:41:51] Interesting. [21:41:52] All right. [21:42:10] Still not quite sure why it can't just be consistent between unified and side-by-side, but all right. [21:42:26] saper: let me look [21:42:48] Side-by-side uses text colours for code highlighting [21:42:50] saper: the sidebar changing i removed with the very first patch, sorry :) [21:43:01] MatmaRex: I know, but it's floating badly [21:43:17] see http://tools.wikimedia.org/pg/wiki/ [21:43:34] Hang on a sec, so does unified on some files. What is going on here... [21:43:42] saper: there's nothing at that links. [21:43:45] link* [21:43:56] sry http://tools.wikimedia.pl/pg/wiki/ [21:43:59] saper: here's my testwiki: http://users.v-lo.krakow.pl/~matmarex/testwiki/index.php?title=Os%C3%A1n&useskin=cologneblue [21:44:31] https://gerrit.wikimedia.org/r/#/c/26970/1/i18n/Lqt.i18n.php,unified doesn't have code formatting and instead uses coloured text for added/removed lines [21:44:32] It's weird that https://gerrit.wikimedia.org/r/#/c/26970/1/i18n/Lqt.i18n.php has background color changes, when it's much more obvious what was changed. [21:44:43] I feel like Gerrit was designed to be intentionally difficult. [21:44:52] https://gerrit.wikimedia.org/r/#/c/26970/1/classes/Hooks.php,unified does have code formatting and uses background colours for added/removed lines [21:44:58] I feel similarly about Cisco products lately. [21:45:03] Brooke: well it has to be difficult... [21:45:32] Krenair: Right. [21:45:35] That's what I'm used to. [21:45:44] That's why I got confused about the lack of background color. [21:45:49] And couldn't read the diff properly. [21:46:26] Cisco products are designed to be difficult. [21:46:45] It's frustrating. [21:47:11] Krenair: Yeah, no idea wtf going's on there. [21:47:20] That "is" should be moved. [21:47:57] New review: Burthsceh; "I think good in that database schema." [mediawiki/extensions/RevisionCommentSupplement] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/26965 [21:47:57] Change merged: Burthsceh; [mediawiki/extensions/RevisionCommentSupplement] (master) - https://gerrit.wikimedia.org/r/26965 [21:50:06] Krenair: Seems https://gerrit.wikimedia.org/r/#/c/26970/1/i18n/Lqt.i18n.php,unified has syntax highlighting disabled. [21:51:55] is anybody available for some quick reviewing? i very much want this merged before next deployment: https://gerrit.wikimedia.org/r/#/c/23674/ [21:54:02] New patchset: Alex Monk; "(bug 38534) Add LQT status to action=info" [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/26970 [21:54:15] MatmaRex: http://tools.wikimedia.pl/pg/wiki/ vs. http://tools.wikimedia.pl/pg2/wiki/ [21:54:33] Brooke, can you please respond to Gerrit comments in Gerrit? [21:54:35] Instead of BZ? [21:57:20] saper: you're missing some newest commits, https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/core+branch:master+topic:cologneblue-rewrite,n,z [21:57:27] although they're unrelated to this [21:58:13] i think i removed some unconditional
s in top-right non-header links box... [21:58:42] i first heading is supposed to align with sidebar, that should be done in a different way than
s :P [21:58:46] if* [22:00:37] MatmaRex: "pg" is running master as of now, "pg2" is running f000f14 [22:00:48] Krenair: It would be nice, wouldn't it! [22:02:13] MatmaRex: I think maybe we should move quickbar if's to resource loader modules somehow [22:02:20] 03(mod) Shorten thumbnail name convention - 10https://bugzilla.wikimedia.org/39697 +comment (10Paul Kaganer) [22:03:16] saper: this should be implemented on client-side, imo. it might possible for the quickbar to be higher than screen height [22:03:29] and it's theoretically possible for this to render the prefs links unclickable [22:03:32] not really [22:03:41] so you woudnt be able to turn this off [22:03:59] are you just pushing a whole branch to gerrit?! [22:04:17] uhhh... sorta? [22:04:21] those 4 commit depend on each others [22:04:23] other [22:04:26] yeah, they do [22:04:37] the previous ~20 that were already merged did as well :P [22:04:52] I know [22:04:55] but this is ugly [22:05:09] they are really independent mostly [22:05:17] what is ugly? i build on top of previous commits in new ones [22:05:21] well, only mostly [22:05:42] but they should build independently on master whenever it's possible [22:05:48] or squash them into one [22:05:54] actually, these four are not independent at all. [22:06:13] every one really depends on the previous. [22:06:23] it wasn't the case with some of the previous ones, true [22:06:33] so please squash them [22:06:45] it's no fun to download 4 changes only to test them together [22:06:46] why would i? i could as well squash the whole rewrite [22:06:57] you can just download the latest and test it, no? [22:07:04] no [22:07:05] or does gerrit make this impossible? [22:07:17] i thought git-review -d was a little smarter [22:07:27] smaller commits are easier to review [22:07:47] i'd rather review ten 50-line changes than one 500-line behemoth [22:09:21] MatmaRex: yeah but you know what happens if somebody sends patchset 2 to any of those [22:09:41] Hi everyone. Can someone please help me figure were the JS function mw.toolbar.addButton is defined? [22:09:42] fortunately git fetch takes them all [22:09:42] rebase hell, i know. [22:09:57] but it's simple enough to just click that button everywhere [22:10:26] ok http://tools.wikimedia.pl/pg/wiki/ has those 4 changes in as well [22:10:59] Huji: MediaWiki core, resources\mediawiki.action\mediawiki.action.edit.js [22:11:36] MatmaRex : can you please link it on the svn? [22:11:43] saper: Why does it have to be difficult? [22:12:14] Huji: on svn? what do you mean? [22:12:18] MatmaRex: nevermind [22:12:32] Brooke: because it's core assumption is to rely on git as much as possible; i.e. no additional workflow features on top of it [22:12:43] s,it's,its, [22:13:03] Gerrit's existence is an additional workflow feature. [22:13:12] It needn't suck at what it does. [22:13:15] saper: i'm pretty sure git review -d N will download the change with all its dependencies [22:13:20] how else would it work [22:13:27] i don't have an env to test it now, though [22:13:36] so it's on user to understand "git fetch origin refs/changes/98/26898/1" or "git push origin HEAD:refs/changes/26898" [22:13:48] or 'git fetch refs/*:refs/* " :) [22:13:58] MatmaRex: git fetch does [22:14:09] whyyy dont you use git review? [22:14:10] now I have 4 commits ahead of master [22:14:18] because it's fscking stupid tool [22:14:19] it sucks much less than gerrit itself [22:14:27] New patchset: Parent5446; "Fixed remote extension patch in module." [mediawiki/extensions/TwoFactorAuthentication] (master) - https://gerrit.wikimedia.org/r/27017 [22:14:27] New patchset: Parent5446; "Fixed setUp() on tests by calling parent." [mediawiki/extensions/TwoFactorAuthentication] (master) - https://gerrit.wikimedia.org/r/27018 [22:14:38] MatmaRex: did you read its source ?:) [22:14:56] Change merged: Parent5446; [mediawiki/extensions/TwoFactorAuthentication] (master) - https://gerrit.wikimedia.org/r/27017 [22:15:12] Change merged: Parent5446; [mediawiki/extensions/TwoFactorAuthentication] (master) - https://gerrit.wikimedia.org/r/27018 [22:15:34] but -d ABCDE is a shorthand for fetch gerrit refs/changes/DE/ABCDE/N [22:15:35] saper: i didn't dare, it probably has a lot of shelling out and ugly argument parsing [22:16:06] and it's python, which is not particularly for this kind of tasks [22:20:48] MatmaRex: in which commit did you remove 'add new section' from the sidebar? [22:22:52] Oh, and I just realized jenkins-bot was ignoring that LQT change because... it's LQT. Dur. [22:23:32] Huji, I hope you're not still working from SVN [22:23:33] saper: it's still present on talk pages [22:23:44] 03(mod) problems saving language links containing umlaut - 10https://bugzilla.wikimedia.org/40823 (10swuensch) [22:23:46] saper: but let me look [22:23:58] Krenair: no sir ;) [22:24:05] I want to test it on normal pages [22:24:06] saper: i think https://gerrit.wikimedia.org/r/#/c/25415/ [22:24:07] Krenair: disregard [22:24:11] ok, good :) [22:24:14] MatmaRex: no sir. Git is my friend [22:24:24] saper: yeah, that one, it's even in the commit message :) [22:24:54] MatmaRex: what I want to do, literraly, is to override the "click" method of an object created by jquery (assign it to a new function) [22:24:59] pity, because save one click because of this [22:25:00] and I don't konw jquery enough [22:25:55] Huji: $object.off('click') [22:26:06] this will remove all click handlers [22:26:20] MatmaRex: well I don't want to remove it, just to change it [22:26:21] all jquery-registered click handlers* [22:26:27] then you can add your own [22:26:35] MatmaRex: yaah, bot on in the first line :-) ah commit granularity :) [22:26:40] the object I'm interested in, has ID of #mw-editbutton-signature [22:26:42] saper: ugh [22:26:57] saper: i simply used the regular MW sidebar contents there [22:27:10] saper: it'd be on hte first line if i could make it longer :P 60 chars is not enough [22:27:16] MatmaRex : Should I do $("#mw-editbutton-signature").off('click') [22:27:34] Huji: try and see if it works? [22:27:51] you know that the regular MW sidebar isn't perfect? :) [22:27:55] Huji: it might be some sort of a delegated click handler, in which case you're in for a world of hurt [22:28:01] saper: do file a bug :P [22:29:08] Bearbeiten [22:29:08] Erstellen [22:29:08] + [22:29:11] Huji: actually, the docs say it will work for delegated clicks, magic. [22:29:12] MatmaRex so far it worked [22:29:15] this is wrong... [22:29:33] MatmaRex: now I need to figure out how to assign the new function [22:29:47] I tried these two lines of code: [22:29:49] $("#mw-editbutton-signature").off('click'); [22:29:49] $("#mw-editbutton-signature").click(insertTags("~~", "~~")); [22:30:12] but it does the insertTags when I load the page, doesn't wait for me to click [22:30:22] saper: which part is wrong? the "+"? [22:30:32] yeah, it's kinda ugly, i admit [22:30:32] MatmaRex : sorry for bothering you with a jquery question [22:30:37] Huji: do you know any javascript? [22:30:54] MatmaRex : I know JS, but I never tried ot learn JQuery [22:30:57] Huji: $("#mw-editbutton-signature").click(function(){ insertTags("~~", "~~") }); [22:31:08] (not tested) [22:31:12] makes sense tho [22:31:21] MatmaRex: it's bad now... trying to backport monobook crappyness :( [22:32:30] saper: i'm not exactly cheerful when i think about working with assoc arrays in PHP [22:32:31] MatmaRex: worked! Than you [22:32:38] Thank* you [22:32:46] https://gerrit.wikimedia.org/r/#/c/25415 and https://gerrit.wikimedia.org/r/#/c/25416 should really be squashed together - you remove a feature and add it later in some other way [22:32:49] saper: i've had to perform some truly acrobatic feats to do even this lightweight sidebar mangling i did [22:33:08] I appreciate porting this to SkinTemplate really :) [22:33:26] I think SkinTemplate should be expanded a bit and not functionality removed [22:33:31] New patchset: Alex Monk; "(bug 40829) Show cascading protection info on action=info" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27019 [22:33:48] I think we've had QuickTemplate before [22:34:04] saper: i think i made this changes a day apart and already forgot that i removed the new section link before i added it again :) [22:34:08] these* [22:34:19] you should be punished :) :) [22:34:39] 03(mod) ?action=info doesn't show cascading page protection - 10https://bugzilla.wikimedia.org/40829 +comment (10Krenair) [22:35:26] i didn't have any outline of what i'm going to do in next commits, i just jumped in and rewrote random functions ;) [22:35:35] Miranda IM? that's my kind of guy! [22:35:51] even if he does not know jquery? [22:36:01] jquery sucks ~ [22:36:14] why? [22:36:31] document.getElementById() all the way :D [22:36:41] alright, it's pretty nice [22:36:57] except for the part where it will happily chomp up any and all errors and keep going [22:37:26] add an element to every element in an empty set? no problem! [22:37:30] yeah [[:en:Turtles all the way down]] [22:37:30] append* [22:37:49] remove every element in an empty set? have it your way! [22:38:00] why would that be a problem? it's functional programming my dear [22:38:21] i prefer my errors to show up in the error console [22:38:31] and no longer those ugly (if(!empty) { replace() } else { do nothng } ) [22:38:38] it's not an error [22:38:38] instead of having to mine them up in the debugger [22:38:48] it is en error if you mistype the id, for example [22:38:53] an* [22:41:46] so there should a warning about unused/strangely introduced variable [22:42:01] those are meant to chase typos, not list iteration [22:43:05] jQuery is much like PHP in this way [22:43:34] "oh, you accidentaly passed an array there instead of a string? no problem, let me perfome some completely idiotic action on it and carry on" [22:44:44] e.g. SkinTemplate->makeListItem will return "Array" if i accidentally omit the first argument. [22:45:52] $() funnily enough will also accept an array as argument, which is almost never what you want [22:54:02] New patchset: Siebrand; "Maintenance for ReassignEdits extension." [mediawiki/extensions/ReassignEdits] (master) - https://gerrit.wikimedia.org/r/27020 [22:57:38] 03(ASSIGNED) Display redirect status in MediaWiki's info action - 10https://bugzilla.wikimedia.org/40154 +comment (10Krenair) [22:58:51] 03(mod) Add LiquidThreads status to MediaWiki's info action - 10https://bugzilla.wikimedia.org/38534 (10Madman) [23:00:06] 03(mod) Validator: Call to undefined method SpecialPageFactory::addAliases() - 10https://bugzilla.wikimedia.org/40769 +comment (10Jeroen De Dauw) [23:02:23] New patchset: Parent5446; "Added throttling to HTMLForm." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27021 [23:02:23] New patchset: Parent5446; "(DRAFT) Re-implemented Special:Userlogin using FormSpecialPage." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27022 [23:25:50] New patchset: Burthsceh; "add SpecialRevisionCommentSupplementList.php" [mediawiki/extensions/RevisionCommentSupplement] (master) - https://gerrit.wikimedia.org/r/27023 [23:35:55] New patchset: Siebrand; "Maintenance for SecurePoll extension." [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/27024 [23:36:33] New patchset: Jeroen De Dauw; "Implemented GeoCoordinateParser" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/27025 [23:40:55] New patchset: Jeroen De Dauw; "Implemented GeoCoordinateParser" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/27025 [23:42:19] Greetings. So my mediawiki installation has been ticking along just fine. Then I went to create a category this afternoon (something I haven't done in a few months), and it's charfing with "Cannot access protected property Language::$namespaceAliases in /var/www/localhost/htdocs/mediawiki/extensions/MWSearch/MWSearch_body.php on line 90". So I upgraded to 1.19.2, ran update.php, same thing. This is under PHP 5.4.5. [23:46:48] You're presumably running an out of date version of MWSearch [23:47:03] master has [23:47:04] global $wgCanonicalNamespaceNames, $wgNamespaceAliases; [23:47:04] $nsNamesRaw = array_merge($wgContLang->getNamespaces(), $wgCanonicalNamespaceNames, [23:47:04] array_keys( array_merge($wgNamespaceAliases, $wgContLang->getNamespaceAliases()) ) ); [23:48:14] I've got [23:48:15] global $wgCanonicalNamespaceNames, $wgNamespaceAliases; [23:48:15] $nsNamesRaw = array_merge($wgContLang->getNamespaces(), $wgCanonicalNamespaceNames, [23:48:15] array_keys( array_merge($wgNamespaceAliases, $wgContLang->namespaceAliases) ) ); [23:48:41] The difference seeming to be that namespaceAliases isn't invoked as a function. [23:50:01] Yeah [23:50:16] swapping it for getNamespaceAliases() probably sufficies [23:50:25] but there's likely other out of date code in the extension [23:51:14] OK, granted I'm running Gentoo (don't say it...) and just updated to 1.19.2... All the files in MWSearch are dated Jan 25, 2009. [23:51:27] Is this directory part of the normal distribution? [23:53:18] Change merged: Burthsceh; [mediawiki/extensions/RevisionCommentSupplement] (master) - https://gerrit.wikimedia.org/r/27023 [23:56:15] Reedy, grabbing a new copy of MWSearch did the trick. Thanks for your help. [23:56:34] yay, cool [23:56:46] We generally reccommend to update extensions with mediawiki [23:59:18] I usually have to do so little to MediaWiki to keep it running that I didn't even realize I had extensions that were so outdated. [23:59:22] It just runs :)