[00:01:41] TimStarling: finally got around to https://gerrit.wikimedia.org/r/#/c/30750/ [00:02:51] New patchset: Parent5446; "Added Uri class and Uri Query classes." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22167 [00:27:50] New patchset: Kaldari; "Update CentralNotice to master" [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/30926 [00:28:22] Change merged: Kaldari; [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/30926 [00:33:43] New patchset: Aaron Schulz; "[JobQueue] Make use of the isEmpty() function caching in pop()." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30927 [00:38:10] hi there, I want to find code in mediawiki which is creates "tabs": read, edit, view history. I want create my own tab. Does somebody know where to look. I started from index.php, but I cannot find it. [00:39:14] hi MichaelShavlovsk [00:39:15] New patchset: Kaldari; "Update CentralNotice to master" [mediawiki/core] (wmf/1.21wmf2) - https://gerrit.wikimedia.org/r/30928 [00:39:17] hi [00:39:29] Change merged: Kaldari; [mediawiki/core] (wmf/1.21wmf2) - https://gerrit.wikimedia.org/r/30928 [00:39:38] MichaelShavlovsk, that's SkinTemplate's job [00:39:55] MichaelShavlovsk: do you know what a Skin is in MediaWiki? [00:40:23] MichaelShavlovsk, https://www.mediawiki.org/wiki/Manual:Hooks/SkinTemplateNavigation [00:40:37] okay, I found SkinTemplate.php in includes [00:41:54] sumanah, DanielFriesen, thank you! I will play with it now [00:41:54] Reedy: https://gerrit.wikimedia.org/r/#/c/30927/1 [00:42:56] ...and I'll unpack shopping bags, upgrade Moodle, and then go unconscious... [00:43:33] ...though right about now I feel like skipping to step 3... [00:43:42] New patchset: Aaron Schulz; "[JobQueue] Make use of the isEmpty() function caching in pop()." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30927 [00:47:35] New patchset: Alex Monk; "(bug 20188) Show a note at Special:Block when the user is globally locked." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/30929 [00:48:24] if ( $isEmpty === 'true' ) { [00:48:24] return true; [00:48:24] } elseif ( $isEmpty === 'false' ) { [00:48:24] return false; [00:48:24] } [00:48:30] srsly? [00:49:08] 03(mod) Add a note on Special:Block if the account is already globally locked - 10https://bugzilla.wikimedia.org/20188 +comment (10Krenair) [00:49:13] well you don't want to actually use true/false, that would break horribly :) [00:53:59] Reedy: can you deploy that to wmf3? [00:54:12] my wmf branch checkout on this box is gonna take a while to update [00:54:55] haha [00:54:55] yeah [00:55:09] it's on 1.20wmf11 ;) [00:55:44] New patchset: leucosticte; "Bug 15441, bug 39675. Add archive, externallinks PK & more." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30431 [00:56:20] New patchset: Reedy; "[JobQueue] Make use of the isEmpty() function caching in pop()." [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/30931 [00:57:08] Reedy, it could be worse. [00:57:17] Change merged: Reedy; [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/30931 [01:01:15] New patchset: Mwalker; "CN Paging Bugs - Ambiguous Query and Warnings" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/30824 [01:01:55] Is https://bugzilla.wikimedia.org/show_bug.cgi?id=29035 WONTFIX now? (something not working on secure.wm.o from may 2011) [01:02:38] New patchset: Bean49; "(bug 13721) Truncate comment at 255 Bytes" [mediawiki/tools/mwdumper] (master) - https://gerrit.wikimedia.org/r/30932 [01:02:54] andre__: ^ Krenair's question :) [01:02:54] 03(NEW) tokenQuery[tokenType].done is not a function - 10https://bugzilla.wikimedia.org/41570 normal; MediaWiki extensions: MobileFrontend; (maxsem.wiki) [01:03:36] 03(mod) tokenQuery[tokenType].done is not a function - 10https://bugzilla.wikimedia.org/41570 (10Max Semenik) [01:03:39] It's about an external editor accessing the (now deprecated) secure.wm.o site [01:03:54] Krenair, so secure.wm.o is deprecated? I've heard that, but I wasn't sure [01:04:02] in that case close it, yeah (but please explain why) [01:05:25] 03(mod) ee.pl does not work - 10https://bugzilla.wikimedia.org/29035 summary; +comment (10Sumana Harihareswara) [01:05:30] I think it is still reproducible even on the current site [01:05:35] * sumanah commented to that effect [01:06:37] * DanielFriesen wishes that some of the alternates to the current status of https would pick up steam [01:06:51] andre__, well according to [[W:en:WP:SEC]] it is [01:06:59] "The old secure server with URLs like https://secure.wikimedia.org/wikipedia/en/wiki/ is deprecated and may not be supported in the future." [01:07:23] if nobody plans to investigate and fix, it's WONTFIX. [01:07:41] no need to keep tickets open that definitely nobody will fix. [01:07:44] if it were *only* reproducible on the secure.wikimedia.org site, yes. [01:07:56] yes, sure, I intended to imply that [01:07:56] But in this case it does seem reproducible on one of the supported sites. [01:08:03] I see [01:08:03] :) [01:08:40] 03(mod) {{anchorencode:}} removes text between < and > - 10https://bugzilla.wikimedia.org/28212 (10Krenair) [01:09:01] 03(mod) ee.pl does not work - 10https://bugzilla.wikimedia.org/29035 (10Krenair) [01:10:14] 03(mod) CentralAuth: allow renaming of global groups - 10https://bugzilla.wikimedia.org/27551 (10Krenair) [01:17:26] 03(mod) Data too long for column 'rev_comment' - 10https://bugzilla.wikimedia.org/13721 -patch +patch-in-gerrit; +comment (10Bean49) [01:37:27] New patchset: Parent5446; "(bug 38417) Changed edit token construction and checking" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21986 [01:39:39] New patchset: Parent5446; "(bug 32496) Added userid parameter to API block/unblock." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/17588 [01:45:06] New patchset: Adamw; "DO NOT MERGE - 2-round-trip banner load" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/29527 [01:48:36] 03(NEW) Translation memory for phrases like in description - 10https://bugzilla.wikimedia.org/41571 normal; MediaWiki extensions: WikidataRepo; (jeblad) [01:51:09] New patchset: Parent5446; "(bug 32496) Added userid parameter to API block/unblock." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/17588 [01:56:14] New patchset: Parent5446; "(bug 34984) Added "remaining characters" to edit summary." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/17519 [01:57:28] New patchset: Parent5446; "(bug 32496) Added userid parameter to API block/unblock." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/17588 [01:57:57] hi ty, how is it going? I see you updating some patchsets :) [01:59:56] Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30927 [02:00:10] Hi sumanah! It's going good. :3 I don't think I have? [02:00:54] * sumanah may be misunderstanding the recent Gerrit activity just looking at the bot [02:06:20] sumanah: Hi there. When a Gerrit change isn't getting any love and someone needs to be poked about it, does that go to you or Andre or someone else? In particular, I'm looking at ... [02:06:35] sumanah: https://bugzilla.wikimedia.org/show_bug.cgi?id=41566#c2 [02:07:13] Hi, Brooke. I'm the person to ask to give that attention. I'm looking now. [02:07:14] Cool, thank you! [02:07:16] In an attempt to delegate work I'm tempted to yell Sumana's name, but I can also try :P [02:07:29] thanks for the heads-up [02:07:31] Oh, didn't realize you both were around. /me waves. [02:07:35] heja :) [02:07:35] No problem. [02:07:48] New patchset: leucosticte; "Bug 15441, bug 39675. Add archive, externallinks PK & more." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30431 [02:08:10] It should be a trivial change to merge, but there's also a deploy component. [02:08:19] It has to be pushed to the Apaches, I think. [02:08:31] Or the Squids. Something like that. [02:08:37] pgehres: quick note (and I know you're very busy) - if you want a changeset reviewed, adding reviewers manually does help. [02:08:51] Brooke: Project operations/debs/squid [02:09:06] One would hope that it's squid, and it needs rebuilding and deploying... [02:09:11] pgehres: What I do: I look for previous merged changesets in the same repo, and look for who has historically merged them, and add one or two of those people. [02:09:15] Doesn't Squid run on the Apaches, though? [02:09:20] Or am I confused? [02:09:22] No [02:09:24] You're confused [02:09:26] :-( [02:09:34] * Reedy pets Brooke [02:09:40] is the easiest way to see the error message, in case anyone is curious. [02:09:52] * Brooke eyes domas. [02:13:48] sigh, "Quickly want to try something" and now it's 3 hours later. Good night... [02:14:15] New patchset: Adamw; "workaround for same-origin ajax security" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/30934 [02:14:43] New patchset: Mdale; "IE8 fixes; for recent updates." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/30935 [02:15:02] 04(REOPENED) Blank messages via Mobile Feedback should not be sent - 10https://bugzilla.wikimedia.org/41502 +comment (10MZMcBride) [02:16:01] bye andre__ [02:16:19] night [02:16:48] New review: Adamw; "pgehres: this URL might require tweaking the udp2log filter again-- it won't include "?banner="" [mediawiki/extensions/CentralNotice] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/30934 [02:19:29] New patchset: leucosticte; "Bug 15441, bug 39675. Add archive, externallinks PK & more." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30431 [02:34:56] Change merged: Adamw; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/30824 [02:35:26] any one know short URL's for a question please? [02:36:39] New patchset: Alex Monk; "(bug 25377) Tell RenameUser about our user fields in the DB" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/30936 [02:37:03] hi sjobeck1. Do you mean that you want a website that gives short URLs? I use ur1.ca . [02:37:28] 03(mod) AbuseFilter should use Renameuser hooks (filter history/filter logs need to be updated when a user is renamed) - 10https://bugzilla.wikimedia.org/25377 +comment (10Krenair) [02:38:05] 03(mod) AbuseFilter should use Renameuser hooks (filter history/filter logs need to be updated when a user is renamed) - 10https://bugzilla.wikimedia.org/25377 (10Krenair) [02:38:42] no, i mean using short URL's with mediawiki. as in removing the index.php from the URL. [02:39:05] !shorturl [02:39:05] To create simple URLs (such as the /wiki/PAGENAME style URLs on Wikimedia sites), follow the instructions at . There are instructions for most different webserver setups. If you have problems getting the rewrite rules to work, see !rewriteproblem [02:39:06] !prettylink [02:39:27] sjobeck1: take a look at http://www.mediawiki.org/wiki/Manual:Short_URL [02:40:22] yes, i know, been reading it for an hour. my question is this: can i use short URL's and use long URL's at same time? examples would be: [02:40:37] www.example.com/wiki/Page_Name [02:40:58] www.example.com/wiki/index.php?title=Page_Name [02:41:12] and both work at same time ? [02:41:58] Not like that, no. [02:42:06] Your virtual path must be different from your real path. [02:42:16] So if your folder is called "wiki", your virtual path cannot be /wiki/. [02:42:24] Wikipedia uses "w" for the real path. [02:42:34] Example: https://en.wikipedia.org/w/index.php?title=Main_Page [02:42:37] And the virtual path is /wiki/ [02:42:44] But the two cannot be the same or overlap. [02:42:48] ahhh, i see. [02:42:48] Now, [02:43:02] if you want to do... https://en.wikipedia.org/wiki/Main_Page?action=edit, that works. [02:43:05] so if I change my actual file system path to "w" then made "wiki" virtual, it might work [02:43:16] Yeah, that'll work just fine. [02:43:17] nice [02:43:18] thx [02:43:21] No problem. [02:43:29] !rewriteproblem [02:43:29] 1) Try as a fail-safe method; 2) Do not put the files into the document root; 3) Do not map the pages into the document root (see !nullpath); 4) Use different, non-overlapping paths for real files and virtual pages; 5) Do not set a RewriteBase; 6) Put all rules into the .htaccess file in the document root. [02:43:43] You're hitting (4). [02:44:18] gotcha. perfect. thx. [02:44:30] won't my configurations be inside of LocalSettings.php ? [02:45:09] New review: Alex Monk; "Just got this notice while making Ie01488cd, it should be fixed as part of this changeset:" [mediawiki/extensions/Renameuser] (master) C: -1; - https://gerrit.wikimedia.org/r/23986 [02:45:17] New patchset: Aaron Schulz; "[JobQueue] Added a test job that just replaces itself." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30937 [02:46:38] Brooke: won't my configurations be inside of LocalSettings.php     ? [02:47:16] sjobeck1: When you're dealing with short URLs, there's configuration in two places. [02:47:22] One is Web server configuration, typically Apache. [02:47:30] The other is MediaWiki configuration. [02:47:58] You have to tell the Web server that when it gets "/wiki/Foo", to translate that as "/w/index.php?title=Foo" silently and magically. [02:48:14] And yhou have to tell MediaWiki to make its links like "/wiki/Foo" instead of makking them like "/w/index.php?title=Foo". [02:48:21] You can do the Web server part first. [02:48:29] Then do the MediaWiki part. [02:48:35] If you do it in reverse order, things will break temporarily. [02:48:40] New patchset: Aaron Schulz; "[JobQueue] Added a test job that just replaces itself." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30937 [02:49:22] hmmmm, i think i have the mediawiki piece. i do not think i have the apache piece. can you point me at an URL for it? you are very helpful! [02:50:17] sjobeck1: https://www.mediawiki.org/wiki/Manual:Short_URL/Apache [02:52:02] New code comment: Krinkle; Please add an example in demo6.php so that we can easily verify this works as intended.; [02:52:17] New code comment: Krinkle; Add example in demo6.php; [02:53:34] New code comment: Krinkle; Is this method used anywhere? If not, add an example in the demos.; [02:54:32] New code comment: Krinkle; Unintentional committed code: /home/repos/git/mw/mediawiki/core/languages/messages/; [02:57:03] New code comment: Krinkle; Please revert.; [03:06:12] New patchset: Aaron Schulz; "[JobQueue] Added a test job that just replaces itself." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30937 [03:15:17] New patchset: Aaron Schulz; "[JobQueue] Make sure broken/duplicate job removal counts in stats." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30938 [03:16:16] 03(mod) Adding project identification variable to AbuseFilter - 10https://bugzilla.wikimedia.org/41172 +comment (10Krenair) [03:27:36] * Aaron|home wonders what TimStarling is doing [03:28:11] when I should be reviewing your patches? [03:28:39] Brooke: You still around? I struck out. I am getting 404 now. [03:46:10] sjobeck1: What'd you add to where? [03:50:56] LocalSettings.php = [03:50:56] $wgScriptPath = "/wiki"; [03:50:56] $wgArticlePath = "$1"; [03:50:56] $wgScriptExtension = ".php"; [03:50:57] #$wgUsePathInfo = true; [03:51:11] ScriptPath looks wrong. [03:51:21] Your files are in /w, aren't they? [03:51:21] file system path is /var/www/html/mediawiki/ [03:51:38] Hmm, then your ScriptPath would be /mediawiki. [03:51:45] ScriptPath is the location of the physical files. [03:52:23] Oh. [03:52:25] fixed [03:52:53] no site at all at https://www.example.com/wiki/ [03:52:54] :( [03:53:17] You own example.com? [03:53:23] y [03:53:47] when i hit https://www.example.com/mediawiki/ it takes me to https://www.example.com/mediawiki/Mediawiki/ [03:53:56] No matter the rewrite rules, the full form (/w/index.php?title=foo" should always work. [03:54:01] Does the full form currently work? [03:54:19] That is, does https://www.example.com/mediawiki/index.php?title=Foo load? [03:54:29] " --> ) * [03:54:32] no, it is moving me to https://www.example.com/mediawiki/Mediawiki/index.php [03:54:44] Okay, so undo your Web server changes. [03:54:57] And get just the full form (or "ugly" URLs) working again. [03:55:14] The URLs containing index.php. [03:55:21] no changes to web server [03:55:43] fyi. there is no .htaccess [03:55:53] Didn't we go over this above? You can't change the MediaWiki part first. [03:55:58] You have to change the Web server part first. [03:56:18] The Web server has to be told that when a user requests /wiki/Foo, it should silently and magically rewrite that URL to /w/index.php?title=Foo [03:56:31] So the /w/index.php?title=Foo form should always work. [03:56:36] If it doesn't work, you need to undo any changes and get it working first. [03:56:40] Then do the Web server changes. [03:56:45] Then do the MediaWiki changes. [03:57:36] ok. thx. so …………. i read the instructions & didn't get server working. Must that be in htaccess? I only ask as we usually avoid htaccess [03:57:56] What kind of Web server is it? [03:57:59] Apache? [03:58:13] y [03:58:14] Change abandoned: Dzahn; "18:03 < Krinkle> Can a Gerrit op abandon this one: https://gerrit.wikimedia.org/r/#/c/23541/4 ?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/23541 [03:58:38] You don't need to do it in .htaccess. Most people use .htaccess when they can't modify the Apache configuration files due to permissions issues. [03:58:40] i just edit ssl.conf or httpd.conf (very few sites on it) [03:58:52] Right. [03:58:52] great. great. [03:58:52] So you'd do it in httpd.conf. [03:58:59] It's only like one line you need to add. [03:59:09] But first get mediawiki/index.php URLs working again. [03:59:28] If they're 404ing or erroring in some other way, that's the first priority. [03:59:51] New patchset: Tim Starling; "Describes libthai dependency in README." [mediawiki/extensions/wikidiff2] (master) - https://gerrit.wikimedia.org/r/28294 [03:59:57] Change merged: Tim Starling; [mediawiki/extensions/wikidiff2] (master) - https://gerrit.wikimedia.org/r/28294 [04:03:47] Brooke: half way there [04:06:33] New review: Aaron Schulz; "I'd still like to see this at least in doOperations(), so the headers can be set in the main PUT req..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/29769 [04:06:41] Brooke: ok. I got it. [04:06:48] next step (i guess) [04:07:00] So https://www.example.com/mediawiki/index.php?title=Foo works now? [04:07:08] true statement [04:07:13] the truth [04:07:14] yes [04:07:22] Okay. [04:07:40] to be clear, I hope that this always works, since we have a custom script that hits pages uses that style of URL. [04:08:11] New review: Tim Starling; "If tryOggThumb() returns a MediaTransformError, it is not handled correctly in the caller." [mediawiki/extensions/TimedMediaHandler] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/30774 [04:08:13] should I edit 1 line of LocalSettings at a time now ? [04:08:35] No, do the Apache changes first. [04:08:41] Yes, it should always work. [04:08:47] Assuming you don't break it. ;-) [04:09:09] Anyway, edit httpd.conf. [04:09:16] You want to add the lines... [04:09:20] RewriteEngine On [04:09:32] RewriteRule ^/?wiki(/.*)?$ %{DOCUMENT_ROOT}/mediawiki/index.php [L] [04:09:37] Those two lines. [04:09:44] Then graceful Apache. [04:09:49] ack' [04:09:58] God bless you. [04:10:19] pardon ? [04:11:13] I thought you sneezed. [04:11:37] :) [04:11:37] :) [04:12:28] Anyway, add those two lines and graceful (restart) Apache. [04:12:42] Then see if https://www.example.com/wiki/Foo works [04:12:54] dang [04:12:55] nope [04:12:57] Though you may hit an issue as "wiki" and "mediawiki" overlap. [04:13:04] What happens when you try to access that URL form? [04:13:23] 404 [04:13:38] You gracefulled Apache? [04:13:59] affirmative [04:14:27] Can you paste the two lines you added to httpd.conf? [04:14:55] RewriteEngine On [04:14:55] RewriteRule ^/?wiki(/.*)?$ %{DOCUMENT_ROOT}/mediawiki/index.php [L] [04:15:05] (silly emoticon .......sorry) [04:15:56] Does the full form URL still work? [04:16:08] https://www.example.com/mediawiki/index.php?title=Foo ? [04:16:25] y [04:16:29] Okay. [04:16:35] Are you sure mod_rewrite is installed? [04:16:38] It's an Apache module. [04:16:54] let me verify [04:17:36] # locate mod_rewrite [04:17:36] /usr/lib/httpd/modules/mod_rewrite.so [04:17:45] appears so [04:17:58] Not sure, then. [04:18:00] Maybe check the Apache error log? [04:18:07] The rewrite rule should work. [04:18:20] If it isn't working, it sounds like an Apache issue. [04:18:40] DanielFriesen may know more. [04:19:12] New review: Tim Starling; "It's a pity there's no easy way to support efficient rename operations on FS file backends. We didn'..." [mediawiki/core] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/30750 [04:21:25] * DanielFriesen is half-asleep and can't mentally piece together exactly what the current situation is [04:21:40] * Brooke tucks DanielFriesen in. [04:21:44] DanielFriesen: that is a great auto-repsonder [04:21:45] :) [04:22:02] DanielFriesenBot [04:22:48] I see no errors in apache logs or anything relevant [04:23:48] sjobeck1: It might be the overlap between "mediawiki" and "wiki". [04:23:50] Not sure. [04:23:59] Or maybe mod_rewrite isn't working properly. [04:24:01] Dunno, sorry. [04:24:06] New patchset: Tim Starling; "[FileBackend] Support "ignoreMissingSource" for copy and move operations." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30744 [04:24:13] thx so much for help. I am going to try "w" now [04:24:20] New patchset: Tim Starling; "[FileRepo] Changed "publishBatch" to handle failure better." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30750 [04:24:34] Change merged: Tim Starling; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30744 [04:24:41] so that would be /var/www/html/w/ correct ? [04:24:45] Yes. [04:24:47] Change merged: Tim Starling; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30750 [04:24:55] If you move MediaWiki, you'll need to update LocalSettings.php. [04:27:03] TimStarling: yeah, I was wondering about still doing more for file systems...like saving to a temp place and then rename()ing over the current...or if the old way worked as well as you said, just doing that [04:29:25] are we going to keep using the MySQL job queue backend? [04:29:33] because if we are, I think I will have more comments [04:29:51] on https://gerrit.wikimedia.org/r/#/c/29736/ I mean [04:32:49] * Aaron|home would like to use something else at least for some jobs eventually [04:33:33] 03(mod) When #ifexists target page is created/deleted, does not update links tables - 10https://bugzilla.wikimedia.org/31628 +comment (10MZMcBride) [04:33:48] ok, I will write my comment :) [04:33:51] Brooke: it does not matter that this is all over HTTPS. do i need to put this in to ssl.conf ? [04:34:11] Not sure. I don't think so, but I don't have much familiarity with SSL. [04:37:37] New review: Tim Starling; "Do you think it would be useful and/or possible to have a limit on the number of retries, to eventua..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/29736 [04:41:33] sounds like the stuff I mentioned in job/README [04:42:11] could be done [04:42:30] 03(mod) When #ifexists target page is created/deleted, does not update links tables - 10https://bugzilla.wikimedia.org/31628 +comment (10Liangent) [04:42:59] TimStarling: would you add a column or reuse job_params? [04:44:44] New patchset: leucosticte; "Bug 15441, bug 39675. Add archive, externallinks PK & more." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30431 [04:46:39] New review: Tim Starling; "MagicWordArray::matchVariableStartToEnd() is slow, it requires a regex match for every element in th..." [mediawiki/core] (chinese-collation); V: 0 C: -1; - https://gerrit.wikimedia.org/r/28004 [04:47:19] add a column, I guess [04:52:22] 03(mod) Set Transwiki namespace on Chinese (zh) wikimedia - 10https://bugzilla.wikimedia.org/40474 +comment (10Liangent) [04:54:09] 03(mod) Adding project identification variable to AbuseFilter - 10https://bugzilla.wikimedia.org/41172 +comment (10Jasper Deng) [05:07:01] New review: Aaron Schulz; "Also see http://www.php.net/manual/es/function.rename.php#92575" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/30770 [05:16:43] I am trying to get an answer to what should be a simple question. How to block new users? I have clicked on the FAQ and "manual" links on http://www.mediawiki.org/wiki/Communication, but they send me to an empty page. Do I possibly have a problem with a plugin? [05:16:56] TimStarling: I guess we should add comments "New code please do not follow this pattern. Use XXX instead." to various places of our codebase [05:18:06] probably [05:18:21] maybe there are useful applications for the variable feature, but that is not one of them [05:20:56] TimStarling: why does MediaHandler not have a stub getLength function? [05:22:00] no application for it [05:22:15] I didn't want to get into adding a method for every possible parameter of every media type [05:22:43] I thought it was more flexible to provide more general methods, like getShortDesc() [05:24:46] * Aaron|home was looking at https://gerrit.wikimedia.org/r/#/c/29769/ [05:25:41] New review: Aaron Schulz; "Actually it could probably just use getProps() since it already needs the sha1 and content-type anyway." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/29769 [05:27:10] how about MediaHandler::getExtraStreamHeaders()? [05:27:29] then the media handler can specify that it wants X-Content-Duration [05:28:01] and you can have a video base class which uses getLength() if necessary [05:29:40] yeah, and it could actually take a path or FSFile instead of a File as an argument like getLength() does [05:29:54] File is reaaally awkward here [05:30:25] well, File provides caching [05:31:04] if you don't need caching because it's only a cache refresh function that calls it, then I guess you can pass a path [05:31:19] well it's on upload, when the file is stored permanently to begin with [05:31:32] so you don't really have a LocalFile to work with [05:31:32] like getMetadata() [05:32:01] actually, currently the length is in the metadata [05:32:57] that's why OggHandler::getLength() takes a File as a parameter, so it can use $file->getMetadata() which is presumably cached [05:33:40] I don't think you want to pass a path, since that would require reading the whole file again [05:33:58] it's already done once on upload, to get the metadata [05:34:43] yeah, OggHandler already sets 'length' [05:35:17] seems like TimedMediaHandler doesn't [05:35:31] it also does nothing in getImageSize(), not that that's related [05:36:26] Aaron|home: you feeling better? [05:36:55] yes [05:38:00] good to hear [05:39:02] New code comment: Krinkle; Be sure that scripts/getFallbacks.php does this correctly.; [05:39:05] ...and happy TimStarling day, Tim! sorry, didn't arrange for cupcakes :) [05:39:23] yay me [05:40:10] yay you indeed! [05:42:17] TimStarling: wait how does TMH::getLength() work at all? [05:42:51] ah, subclassed, nvm [05:42:58] that would have been an infinite loop [05:43:20] ahh, and length is there [05:43:31] are you thinking of doing something in FSFile::getProps()? [05:44:01] it seems like a similar operation to getImageSize() which is called from there [05:44:16] $tempImage = (object)array(); [05:44:16] $info['metadata'] = $handler->getMetadata( $tempImage, $this->path ); [05:44:25] need for a File object solved in a cute way [05:46:58] * Aaron|home thinks of that rfc [05:48:08] TimStarling: I'd kind of like a getMetadata function for FSFile, but then there is that annoying $ext parameter [05:55:34] TimStarling: for updateCollations.php, I met another difficulty: I can't write a good query to find out outdated cl_from/cl_to pairs except for using nested queries [05:56:01] Pastebin the nested query? [05:57:38] Brooke: select cl_from,cl_to,(select count(*) from categorylinks icl where icl.cl_from=ocl.cl_from and icl.cl_to=ocl.cl_to) ca,(select count(*) from categorylinks icl where icl.cl_from=ocl.cl_from and icl.cl_to=ocl.cl_to and icl.cl_collation in ('uppercase','identity')) cu from categorylinks ocl group by cl_from,cl_to having ca<>cu or cu<2; [05:57:52] I remember I asked it here once [06:00:23] you can use nested queries in maintenance scripts if you want [06:00:43] I'd have to review the whole script and the schema to judge whether that's the best way to do it [06:00:57] I made the query legible: http://p.defau.lt/?JLQfTZIsw4iA8Cn0foB11A [06:01:38] it will work in every DBMS won't it? [06:02:01] TimStarling: not sure but I'll construct it with $db->selectSQLText [06:02:07] Nested subqueries were only an issue in MySQL 4, I thought. [06:02:14] Isn't everyone using 5 these days? [06:02:29] 4.0 maybe [06:03:14] "Starting with MySQL 4.1, all subquery forms and operations that the SQL standard requires are supported, as well as a few features that are MySQL-specific. " [06:03:54] it's been a while since 4.0 was declared "end of life" [06:03:54] it'll be in update.php so I don't think being too slow is also fine here.. [06:04:22] ah yes, our INSTALL file says we need 5.0+ [06:08:52] gtg [06:21:50] TimStarling: I don't see a super nice way to do this, I guess $props can be passed down from upload() -> publish() -> ... -> store [06:22:50] I guess so [06:23:26] then the metadata could go to your little headers functions and the sha1 could be reused while at it [06:23:36] the cost of abstraction: changes are as complicated as the number of layers of abstraction you have to pass data through [06:24:31] people think abstraction makes code flexible, but actually it makes it flexible in a particular axis and harder to change in every other way :) [06:25:22] that's the flaw in 99% of jeroen's code, he thinks he's writing flexible code but actually there's no flexibility at all [06:26:01] because the flexibility that his abstractions give are purely theoretical and probably will never be used [06:26:18] whereas the change cost due to complexity is very high [06:28:58] http://c2.com/cgi/wiki?PrematureAbstraction [06:29:34] * Aaron|home is glad he used array params for lots of file backend stuff [06:30:13] easy to keep tacking options on without function( a, b, d, false, false, g, h, null, j ) type calls ;) [06:34:21] I've been thinking about that sort of problem in C recently [06:34:46] in C, you can't add formal parameters, you can only add extra functions [06:35:00] DoTheThing() -> DoTheThingEx(), DoTheThing2() [06:35:37] and associative arrays are not used for parameter lists [06:36:38] the preferred solution seems to be an OOP style with lots of mutator methods [06:37:05] so in PHP you might write doTheThing(array('foo' => 1, 'bar' => 2)); [06:37:15] in C that would become [06:37:29] thing_operation * op = create_thing_operation(); [06:37:43] thing_operation_set_foo(op, 1); [06:37:48] thing_operation_set_bar(op, 2); [06:37:57] thing_operation_execute(op); [06:38:20] basically mapping named parameters to function names, because those are the only things you can add to an API [06:40:21] hmm [06:49:35] robla: *head explodes* i had no idea you wrote all this json schema stuff! [06:50:24] ori-l: need a sec to wipe off your monitor? :) [06:50:48] yeah, it's been a bit of a hobby for a while [06:51:11] ori-l: which piece did you stumble into? [06:51:18] https://github.com/robla/mediawiki-jsondata [06:52:43] what was the impetus for writing that, if you don't mind me asking? [06:53:39] it was trying to figure out a reasonable UI for this thing: [06:54:05] http://wiki.electorama.com/wiki/Electowidget [06:55:14] total and complete yak shaving toward that goal [06:56:24] Change merged: Nikerabbit; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30582 [06:59:14] this is a nice surprise. i dunno if you peeked at eventlogging, but we settled on jsonschema for data models [07:00:01] none of the hip new serialization formats have a good story when it comes to JS [07:00:24] I saw that (yesterday?) and was going to bring it up [07:23:34] New review: Nikerabbit; "Why are we suddenly having so many timeouts? Is there performance regression somewhere?" [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/30908 [07:24:29] 03(NEW) Wikilink to a repo item by sitelink - 10https://bugzilla.wikimedia.org/41572 normal; MediaWiki extensions: WikidataRepo; (aude.wiki) [07:27:04] Change merged: Nikerabbit; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30917 [07:29:43] New patchset: Santhosh; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/30944 [07:29:43] New patchset: Santhosh; "Option for disabling the IME system" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/30945 [07:31:26] 03(mod) Enable Translate on wikidatawiki - 10https://bugzilla.wikimedia.org/41567 +comment (10Niklas Laxström) [07:31:48] New review: Hashar; "That patch has been applied to master back in April. Since we have barely made any change to REL1_19..." [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/30908 [07:37:02] 03(NEW) Articles I edit do not add to my watchlist - 10https://bugzilla.wikimedia.org/41573 normal; MediaWiki extensions: WikidataRepo; (aude.wiki) [07:38:47] Change merged: Siebrand; [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/30834 [07:38:55] Change merged: Siebrand; [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/30835 [07:39:10] New patchset: Siebrand; "Backport compatible message changes from master" [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/30873 [07:40:23] New review: Nikerabbit; "Is the namespace there so that you can remove all *.ime listeners at once?" [mediawiki/extensions/UniversalLanguageSelector] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/30944 [07:43:21] New patchset: Aude; "remove shared table settings from client" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30947 [07:43:25] Change merged: Siebrand; [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/30946 [07:47:27] New patchset: Aude; "add $wgWBExternalRecentChanges setting to enable or disable the external RC stuff" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30948 [07:59:26] New patchset: Siebrand; "Backport compatible message changes from master" [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/30951 [07:59:31] New review: Aude; "Reason that I use a global variable setting here as I think it will work more easily and out of the ..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/30948 [08:03:11] Change merged: Siebrand; [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/30873 [08:09:21] 03(mod) Add and remove aliases in same edit - 10https://bugzilla.wikimedia.org/41535 +comment (10Aude) [08:09:48] New review: Siebrand; "Appears to be still timing out." [mediawiki/core] (REL1_20); V: 0 C: 0; - https://gerrit.wikimedia.org/r/30951 [08:16:31] 03(FIXED) Fix transwiki import sources for es.wikibooks - 10https://bugzilla.wikimedia.org/41011 +comment (10Hydra) [08:16:54] Change merged: Siebrand; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/30944 [08:28:44] Change merged: Siebrand; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/30945 [08:30:57] New patchset: J; "Use oggThumb for Ogg Theora files if available" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/30774 [08:37:02] 03(mod) Articles I edit do not add to my watchlist - 10https://bugzilla.wikimedia.org/41573 +comment (10Aude) [08:45:24] Change merged: J; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/30935 [08:50:23] New patchset: Ori.livneh; "Not actually a dependency." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/30953 [08:50:35] Change merged: Ori.livneh; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/30953 [09:00:36] 03(mod) CentralNotice API - 10https://bugzilla.wikimedia.org/32536 +comment (10Adam Wight) [09:06:58] New patchset: Aude; "add option to filter external recent changes in SpecialRecentchanges" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30955 [09:07:09] 03(FIXED) move geoIP lookup back to the head - 10https://bugzilla.wikimedia.org/37727 (10Adam Wight) [09:08:37] 03(mod) MediaWiki:File-no-thumb-animation-gif is shown for files exceeding 12.5M, even if they render (Bug 41125 raised limit to 25M) - 10https://bugzilla.wikimedia.org/41511 +comment (10Rd232) [09:10:16] New review: Aude; "It would probably be nice to add this functionality also to the api, which I could do with another p..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/30955 [09:11:52] New review: Aude; "and add this to tests and make sure current tests work. not sure what the issue is but can look int..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/30955 [09:25:09] New review: Nikerabbit; "It can be done with hooks (with limitations especially in the placement of the UI). CleanChanges/Fil..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/30955 [09:25:35] 03(mod) Bad UTF-8 in ThreadSignature breaks huwiki XML dumps and Special:Export - 10https://bugzilla.wikimedia.org/29564 +comment (10Ariel T. Glenn) [09:53:02] 03(NEW) Moving pages (while leaving a redirect) does not work on wikidata.org - 10https://bugzilla.wikimedia.org/41574 normal; MediaWiki extensions: WikidataRepo; (mfwarburg) [09:55:43] New review: Nischayn22; "The answer is that I am not sure how you are going to handle manipulations in future, the functional..." [mediawiki/extensions/Maps] (master) C: 0; - https://gerrit.wikimedia.org/r/29782 [10:01:43] 03(NEW) When I list all pages on wikidata.org the pages are not listed by ID but alphabetically - 10https://bugzilla.wikimedia.org/41575 minor; MediaWiki extensions: Wikidata; (verszil) [10:05:26] Change merged: TheDJ; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/10129 [10:05:37] 03(mod) Wikilink to a repo item by sitelink - 10https://bugzilla.wikimedia.org/41572 +comment (10Daniel Kinzler) [10:15:09] New patchset: Santhosh; "Fix a syntax error" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/30956 [10:21:18] New review: Liangent; "Wait until action=info is done. Some strings (eg. protection level name) can be reused." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/9359 [10:25:45] New review: Helder.wiki; "Any chance of having a maintenance script to update the logs of users already renamed?" [mediawiki/extensions/AbuseFilter] (master) C: 0; - https://gerrit.wikimedia.org/r/30936 [10:26:43] New review: Aude; "does cleanchanges hook into the api results? " [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/30955 [10:29:28] 04(REOPENED) Collection should process redirects - 10https://bugzilla.wikimedia.org/41046 +comment (10Volker Haas) [10:37:11] 03(mod) When I list all pages on wikidata.org the pages are not listed by ID but alphabetically - 10https://bugzilla.wikimedia.org/41575 (10Aude) [10:38:38] 03(NEW) escaping problem on Special:ItemDisambiguation - 10https://bugzilla.wikimedia.org/41576 normal; MediaWiki extensions: WikidataRepo; (lydia.pintscher) [10:39:08] 03(NEW) Use normalized search key in term search index - 10https://bugzilla.wikimedia.org/41577 normal; MediaWiki extensions: WikidataRepo; (daniel.kinzler) [10:39:39] 03(ASSIGNED) Use normalized search key in term search index - 10https://bugzilla.wikimedia.org/41577 normal->04CRIT; +comment (10Daniel Kinzler) [10:53:51] 03(NEW) Show system messages documentation on their wiki pages - 10https://bugzilla.wikimedia.org/41578 enhancement; MediaWiki: Internationalization; (federicoleva) [10:53:52] 03(mod) System messages (tracking) - 10https://bugzilla.wikimedia.org/18521 (10Nemo_bis) [10:54:50] 03(mod) Show translated titles per user language in categories too - 10https://bugzilla.wikimedia.org/29928 +comment (10Foroa) [10:58:28] 03(NEW) Search on wikidata.org shows same item multiple times - 10https://bugzilla.wikimedia.org/41579 normal; MediaWiki extensions: WikidataRepo; (daniel.kinzler) [10:59:36] 03(NEW) Search results show the label twice, but not the item description. - 10https://bugzilla.wikimedia.org/41580 normal; MediaWiki extensions: WikidataRepo; (daniel.kinzler) [11:00:06] Change merged: Siebrand; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/30956 [11:01:59] Hi. [11:02:00] Is gerrit working? [11:02:13] SSH answers, but HTTP not. [11:02:13] gerrit is not in the office today [11:02:45] 03(NEW) Autocomment for item creation does not show label - 10https://bugzilla.wikimedia.org/41581 normal; MediaWiki extensions: WikidataRepo; (daniel.kinzler) [11:03:16] Dereckson: i get http [11:06:50] 03(mod) AbuseFilter should use Renameuser hooks (filter history/filter logs need to be updated when a user is renamed) - 10https://bugzilla.wikimedia.org/25377 +patch-in-gerrit (10Andre Klapper) [11:07:55] 03(mod) Translation memory for phrases like in description - 10https://bugzilla.wikimedia.org/41571 +i18n (10Andre Klapper) [11:08:33] 03(NEW) Show "Page information" toolbox link to info action also in history etc. - 10https://bugzilla.wikimedia.org/41582 enhancement; MediaWiki: General/Unknown; (federicoleva) [11:08:33] 03(mod) Add link to MediaWiki info action in UI - 10https://bugzilla.wikimedia.org/16362 (10Nemo_bis) [11:08:38] 03(mod) Reimplement MediaWiki's info action (tracking) - 10https://bugzilla.wikimedia.org/38450 (10Nemo_bis) [11:09:35] 03(mod) Use normalized search key in term search index - 10https://bugzilla.wikimedia.org/41577 (10Daniel Kinzler) [11:15:49] 03(mod) Use normalized search key in term search index - 10https://bugzilla.wikimedia.org/41577 (10jeblad) [11:20:52] 03(mod) Language links in "Read in other language" miss lang attribute - 10https://bugzilla.wikimedia.org/41554 +patch-in-gerrit; +comment (10Derk-Jan Hartman) [11:23:02] 03(NEW) RecentChanges 504 Gateway Time-out - 10https://bugzilla.wikimedia.org/41583 minor; MediaWiki: Database; (federicoleva) [11:27:33] New patchset: Daniel Kinzler; "Rename testTermArrayStructure, it's not a test." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30960 [11:30:42] New patchset: Daniel Kinzler; "Use plain table name when calling Database::delete." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30961 [11:43:55] New patchset: Daniel Kinzler; "Make ApiBotEditTest robust agnst non-sequential IDs." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30963 [11:45:36] 03(mod) Use normalized search key in term search index - 10https://bugzilla.wikimedia.org/41577 +i18n +performance (10Andre Klapper) [11:53:02] 03(mod) "page_is_redirect" wrong on Indonesian (and probably other non-English) wiki dumps. Doesn't recognize localization of "#REDIRECT" - 10https://bugzilla.wikimedia.org/38919 (10Bean49) [11:57:32] New review: Daniel Werner; "At least try to be consistent if you don't want to consider the cases I have mentioned." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/23100 [12:03:56] 03(NEW) links to local files - 10https://bugzilla.wikimedia.org/41584 minor; MediaWiki: General/Unknown; (christian.muheim) [12:07:02] New patchset: Aude; "add option to filter external recent changes in SpecialRecentchanges" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30955 [12:07:45] 03(mod) Allow wiki syntax in descriptions - 10https://bugzilla.wikimedia.org/41560 (10Lydia Pintscher) [12:07:53] 03(mod) Accented letters not entered properly in aliases - 10https://bugzilla.wikimedia.org/41557 (10Lydia Pintscher) [12:16:31] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30170 [12:28:42] New review: Anomie; "So is there a resolution on all the inline comments here?" [mediawiki/extensions/ConfirmEdit] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/16869 [12:29:45] New review: Nischayn22; "I don't think that substituting of form fields is possible, instead one has to substitute text and t..." [mediawiki/extensions/SemanticWatchlist] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/28400 [12:32:50] 03(mod) Translation memory for phrases like in description - 10https://bugzilla.wikimedia.org/41571 +comment (10Andre Klapper) [12:33:15] New review: Anomie; "Changing to -2 to stop Gerrit Code Review from spamming the log here. Someone ping me once the depen..." [mediawiki/extensions/ConfirmEdit] (master); V: 1 C: -2; - https://gerrit.wikimedia.org/r/16872 [12:35:18] New patchset: Santhosh; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/30972 [12:41:14] Change merged: Siebrand; [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/30967 [12:41:14] New patchset: Pginer; "CSS fix for settings styling" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/30973 [12:41:14] New patchset: Pginer; "mend" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/30974 [12:43:23] Change merged: Siebrand; [mediawiki/core] (REL1_18) - https://gerrit.wikimedia.org/r/30968 [12:45:10] New review: Alex Monk; "Are you going to submit this, Nikerabbit?" [mediawiki/extensions/Calendar] (master) C: 1; - https://gerrit.wikimedia.org/r/30608 [12:45:53] 03(mod) SVG thumbnail is cropped when displayed at natural size - 10https://bugzilla.wikimedia.org/9832 +comment (10Derk-Jan Hartman) [12:46:08] dunno [12:47:37] 03(mod) SVG thumbnail is cropped when displayed at natural size - 10https://bugzilla.wikimedia.org/9832 +comment (10Derk-Jan Hartman) [12:48:33] <^demon> Any reason why not? LGTM. [12:50:37] Change merged: Siebrand; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/30973 [12:51:04] Change merged: Siebrand; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/30972 [12:52:02] New patchset: Raimond Spekking; "Some consistency tweaks in preparation for translation" [mediawiki/extensions/GeoCrumbs] (master) - https://gerrit.wikimedia.org/r/30975 [12:53:55] hi anomie [12:54:05] hi Nikerabbit [12:55:07] what time is it? [12:55:10] New patchset: Pginer; "Fix to reduce the ammount of settings text" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/30974 [12:55:37] 03(mod) Impossible to step from "Upload" to "Release right" - 10https://bugzilla.wikimedia.org/37073 +comment (10Andre Klapper) [12:55:56] <^demon> Nikerabbit: 12:55 UTC. [12:56:34] yeah but over there [12:57:01] New patchset: Santhosh; "Fix to reduce the ammount of settings text" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/30974 [12:57:08] shouldn't you be still sleeping [12:57:24] <^demon> Nikerabbit: It's almost 9am. [12:57:29] <^demon> I've been up since 7:15. [12:57:54] i guess it is because of winter times [12:58:33] <^demon> Did you already shift to winter time? [12:58:47] yes [12:58:50] last sunday [12:59:01] <^demon> Ah. We move this Sunday. [12:59:42] @Sad we cant even syncronize them to the same week [13:00:24] 03(mod) Impossible to step from "Upload" to "Release right" - 10https://bugzilla.wikimedia.org/37073 +comment (10Derk-Jan Hartman) [13:00:38] New patchset: Henning Snater; "Entity selector jQuery widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30136 [13:01:11] 03(mod) Special:LandingCheck on donate.wikimedia.org without any URL parameters is not working - 10https://bugzilla.wikimedia.org/41566 +patch-in-gerrit; +comment (10Andre Klapper) [13:02:30] Change merged: Matthias Mullie; [mediawiki/extensions/GeoCrumbs] (master) - https://gerrit.wikimedia.org/r/30199 [13:02:54] Well, it used to be last week (last Sunday in October) in the US until 2007. [13:03:57] Change merged: Matthias Mullie; [mediawiki/extensions/GeoCrumbs] (master) - https://gerrit.wikimedia.org/r/30975 [13:03:58] * anomie has an alarm clock that tries to be smart, but has the pre-2007 rules hard-coded and no "ignore DST" switch so now it's entirely stupid [13:04:03] New patchset: Demon; "Link $wgVersion on Special:Version to Release Notes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/16433 [13:05:15] New review: Demon; "PS6 fixes the minor typo from PS5." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/16433 [13:05:46] are those smart clocks generally useful? [13:06:21] <^demon> If they can't talk to the internet to find out if there's new rules, they're pretty useless. [13:07:26] Or at least be programmed for the new rules some other way. Or at least have the "smart" feature turned off. [13:08:20] New patchset: Santhosh; "Fix to reduce the ammount of settings text" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/30974 [13:09:36] <^demon> anomie: Indeed. An off switch would be nice :\ [13:12:01] 03(mod) "Download as PDF" contains broken licence link - 10https://bugzilla.wikimedia.org/41273 +comment (10Derk-Jan Hartman) [13:12:10] New review: Santhosh; "Fixed some minor formatting issues" [mediawiki/extensions/UniversalLanguageSelector] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/30974 [13:14:37] my alarm clock syncs to the radio signal. but sunday it didn't do that until after 10am summer time.... so useless :D [13:15:40] Hi [13:15:47] Anyone here have API access? [13:16:29] I was needing someone that was able to write a script to find out the names of all the unique google domains , various MediaWiki sites link to [13:16:53] The reason is that doing a manual linksearch for *.google.com overloads the servers [13:17:01] and it would be better to partition the task [13:17:32] To do this partion, needs a one shot to discover which google domains are in fact linked to from External Links or references [13:23:02] Qcoder00, API access? Um yeah sure, everyone has API access [13:23:04] Qcoder00- API won't help. If extremely current results aren't necessary, download a database dump of the externallinks table (e.g. http://dumps.wikimedia.org/enwiki/latest/enwiki-latest-externallinks.sql.gz for enwiki). Otherwise your best bet is to ask someone with toolserver access to run you a query. [13:23:31] anomie: A query run against the dump would be fine [13:23:52] I don't need all the links [13:24:15] In fact I only need the unique *.google.* portions of the links [13:26:12] https://www.mediawiki.org/w/api.php?action=query&list=exturlusage&euquery=*.google.com&eulimit=500 [13:26:54] Krenair : Thanks [13:27:31] if you can get apihighlimits (bot group by default) you can query 5000 at a time [13:27:59] OK [13:28:48] I tried to query 5000 but I could only go up to 1073 on mediawiki.org, so I guess that's all there is on that wiki [13:29:16] Kester- Except if Special:LinkSearch is blowing up on it, the API will probably blow up too. External link searching doesn't handle extremely large result sets well. [13:29:23] oops, Krenair not Kester [13:30:55] I did that query with eulimit=500 on enwiki and the results came back almost instantly [13:30:55] anomie: Well SpecialLinkSearch gets to an offset of something like 2million and chokes [13:31:11] The intial queries are fine... [13:31:41] It's trying to find the domains after books.google.com because the large numbers of those entries [13:32:07] Qcoder00- I'm surprised it gets even that far. The problem is that to get the first 5000 (or whatever), it just has to fetch the first 5000. But to get the next 5000, it has to skip over the first 5000. And then the next it has to skip 10000, and at some point all that skipping just takes too long. [13:32:27] SO It would be better to run the query against a dump [13:32:36] In one go [13:32:57] Googles domain structure should be relativly stable [13:33:48] I'm not needing every external link ,just the *.google.* portions [13:36:01] Qcoder00- Yes. Get a dump and process it locally. You probably won't even need to actually import the dump into a database, just extract the domains from it as a text file. [13:36:35] Right [13:36:49] I'll pass this on to the bot writer that was working on something... [13:41:53] New patchset: Aude; "cleaning up recent changes code, ExternalRecentChange stuff to handle more stuff" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30809 [13:44:37] 03(mod) Page move vandalism creates watchlist clutter - 10https://bugzilla.wikimedia.org/13602 (10Andre Klapper) [13:44:52] 03(mod) Page move rollback should not leave a redirect - 10https://bugzilla.wikimedia.org/3185 (10Andre Klapper) [13:48:30] 03(NEW) Add the extensions Translate and TranslateNotifications on Wikidata - 10https://bugzilla.wikimedia.org/41585 normal; Wikimedia: General/Unknown; (jeblad) [13:55:22] Change merged: Siebrand; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/30974 [13:55:59] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30566 [13:56:43] moin [13:57:30] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30568 [13:57:56] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30574 [13:58:02] hello, I have a lot of spamer on my wiki. A regexp ensures, that they can't store an wiki article, but is there a way/extension to remove all the user accounts, which haven't written any article? [13:58:17] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30579 [13:58:40] New patchset: Aude; "show deletion log instead of diff for RC when items are deleted" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30981 [13:58:54] <^demon> yoyo[RKN]: The "User Merge and Delete" extension might do what you want. We don't support user deletion in vanilla MediaWiki. [13:59:26] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30136 [14:00:25] hashar: looks like i'm hitting a bug in the sqlite client library (specifically, dbo::quote). which version of the sqlite lib is jenkins using? [14:00:47] my package is php5-sqlite 5.3.6-13ubuntu3.9 [14:01:08] 03(mod) Proper AJAX rollback functionality in core - 10https://bugzilla.wikimedia.org/31270 summary (10Andre Klapper) [14:01:32] 14(DUP) Proper AJAX rollback functionality in core - 10https://bugzilla.wikimedia.org/39468 +comment (10Andre Klapper) [14:01:33] 03(mod) Proper AJAX rollback functionality in core - 10https://bugzilla.wikimedia.org/31270 +comment (10Andre Klapper) [14:01:38] DanielK_WMDE: let me check [14:02:06] DanielK_WMDE: php5-sqlite is 5.3.10-1ubuntu3.4+wmf1 [14:02:31] hashar: so it's newer than mine, so the bug might have been fixed. [14:02:42] php -i says it is SQLite Library => 3.7.9 [14:03:06] 14(DUP) Enable Translate on wikidatawiki - 10https://bugzilla.wikimedia.org/41567 +comment (10Raimond Spekking) [14:03:07] 03(mod) Add the extensions Translate and TranslateNotifications on Wikidata - 10https://bugzilla.wikimedia.org/41585 +comment (10Raimond Spekking) [14:04:38] New patchset: Jeroen De Dauw; "Improved case insensitive lookup of terms" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30984 [14:04:55] 03(NEW) api login returns wrong lgtoken on wikidata.org - 10https://bugzilla.wikimedia.org/41586 blocker; Wikimedia: General/Unknown; (bugreporter) [14:05:36] 03(mod) Add the extensions Translate and TranslateNotifications on Wikidata - 10https://bugzilla.wikimedia.org/41585 +i18n (10Nemo_bis) [14:06:45] New patchset: Alex Monk; "(bug 20188) Show a note at Special:Block when the user is globally locked." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/30929 [14:06:48] 03(mod) Use normalized search key in term search index - 10https://bugzilla.wikimedia.org/41577 +comment (10Jeroen De Dauw) [14:28:36] New patchset: Jeroen De Dauw; "Added gitreview file" [mediawiki/extensions/SemanticExtraSpecialProperties] (master) - https://gerrit.wikimedia.org/r/30993 [14:28:58] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticExtraSpecialProperties] (master) - https://gerrit.wikimedia.org/r/30993 [14:30:01] New patchset: Daniel Kinzler; "Fix handling of striongs containing \0 in sqlite." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30994 [14:30:02] New patchset: Siebrand; "Add jquery.uls to update-externals" [translatewiki] (master) - https://gerrit.wikimedia.org/r/30995 [14:30:23] New patchset: Jeroen De Dauw; "Added gitignore file" [mediawiki/extensions/SemanticExtraSpecialProperties] (master) - https://gerrit.wikimedia.org/r/30996 [14:30:31] Change merged: Siebrand; [translatewiki] (master) - https://gerrit.wikimedia.org/r/30995 [14:30:32] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticExtraSpecialProperties] (master) - https://gerrit.wikimedia.org/r/30996 [14:32:51] DanielK_WMDE, see my comment [14:34:36] MaxSem: so, you don't want the bug fixed until i get around to writing tests for extra stuff? [14:34:49] i mean, sure, it would be good to test for that - but give a -1 for that? why? [14:35:03] is this actually a problem that needs to be fixed before the change can be applied? [14:35:18] is there a terrible rush? [14:35:48] MaxSem: well, it keeps wikidata tests failign on jenkins. that's pretty annoying. [14:36:01] i may add the test you requested later, but it may well be that i don't get around to it. [14:36:22] I need to change the 404 page for a site so that every 404 has "404 Not Found" in the title. Has anyone else done this? [14:36:32] I didn't find an extension to do it ... [14:36:59] New patchset: Aude; "adding some i18n to the recent changes lines" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30998 [14:37:21] 03(mod) Export of coordinates to KML -- does not export all coordinates due to bad "offset" - 10https://bugzilla.wikimedia.org/39633 (10patelmm79) [14:37:54] $db->query( 'CREATE TABLE foo(bar, baz)' ); $db->insert('foo', array('bar'=>'test', 'baz' => $string )); $this->assertEquals($string, $db->selectField('foo', 'baz', array('bar'=>'test')); [14:38:09] what's so terribly hard about this^^^? [14:39:09] DanielK_WMDE, my concern with your tests is that they don't check whether the problem is actually fixed, they just check for a particular encoding [14:39:52] MaxSem: the bug is in the quote() function, which is called ba addQuotes. So the test is testing for the actual problem resp. the corresponding workaround. [14:40:02] MaxSem: testing the full round trip is a good idea, i agree [14:40:14] i just found it a bit strong to give a -1 for that [14:40:20] anyway, it's on my todo list now [14:40:35] (which doesn't mean I get around to it any time soon) [14:42:20] New review: Matmarex; "> At least try to be consistent if you don't want to consider the cases I have mentioned." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/23100 [14:45:23] pft... looks like the red cross hired idiots to do their donation pages... [14:46:22] New patchset: Daniel Kinzler; "Supply required timestamp in ChangesTableTest." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30999 [14:46:29] Even when I select canada as a country it requires a US state and won't accept a Canadian zip code... [14:52:44] New patchset: Jeroen De Dauw; "Magically run ALL of the test functions. I dont always run the tests, but when I do, I run all of them" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/31000 [14:53:04] New patchset: Henning Snater; "Fix regarding the API change of wbsearchentities" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31001 [14:54:15] Does anyone know if it's possible to get the importImages.php to go in alphabetical order? [14:56:50] 03(NEW) Tables are too short - 10https://bugzilla.wikimedia.org/41587 trivial; MediaWiki extensions: Wikidata; (ole.yves) [14:59:05] 03(mod) Tables are too short - 10https://bugzilla.wikimedia.org/41587 +comment (10Saint Johann) [14:59:59] New review: Ragesoss; "Yep, that should do it." [mediawiki/extensions/EducationProgram] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/28816 [15:01:55] 03(mod) Tables are too short - 10https://bugzilla.wikimedia.org/41587 (10Lydia Pintscher) [15:03:07] 03(NEW) Item "kidnapped" after creation - 10https://bugzilla.wikimedia.org/41588 normal; MediaWiki extensions: WikidataRepo; (raimond.spekking) [15:03:14] New patchset: Siebrand; "Use the same protocol for all github hosted projects" [translatewiki] (master) - https://gerrit.wikimedia.org/r/31002 [15:04:19] New patchset: Siebrand; "Use the same protocol for all github hosted projects" [translatewiki] (master) - https://gerrit.wikimedia.org/r/31002 [15:07:56] hello :) [15:08:37] hi benjf [15:09:10] i am attempting to move a MW installation to another server, but getting a 404 on all but the home page [15:09:56] 03(mod) Add the extensions Translate and TranslateNotifications on Wikidata - 10https://bugzilla.wikimedia.org/41585 normal->15enhancement (10Sam Reed (reedy)) [15:10:08] i grabbed a new installation, and imported the old db - i see content and users, but i can't get to the login page :( [15:11:08] any help would be greatly appreciated (i'm a "drupal guy" by day, so this is somewhat new, but I am familiar with the lamp stack) [15:11:26] <^demon> benjf: I'd make sure that any rewrites (like .htaccess or Alias in httpd.conf) got copied over too. [15:11:34] <^demon> Sounds like it's a likely cause if the other data's there fine. [15:11:48] ^demon: thanks, good idea [15:12:05] New patchset: Siebrand; "Use subroutine gitupdate where possible" [translatewiki] (master) - https://gerrit.wikimedia.org/r/31003 [15:12:50] New patchset: John Erling Blad; "Refactor ApiModifyEntity w/subclasses to use serialization" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31004 [15:14:25] 03(mod) Adding project identification variable to AbuseFilter - 10https://bugzilla.wikimedia.org/41172 +comment (10Ajraddatz) [15:14:54] should there be a default .htaccess file included with the MW files? [15:15:09] New review: John Erling Blad; "Lots of errors, must be checked" [mediawiki/extensions/Wikibase] (master); V: -1 C: -2; - https://gerrit.wikimedia.org/r/31004 [15:15:31] ^demon: i think this is the problem [15:16:15] <^demon> There is no default .htaccess [15:16:20] New review: John Erling Blad; "Its the wbsetitem that fails as id and type is removed from ApiModifyEntity. Also wblinktitles fails." [mediawiki/extensions/Wikibase] (master); V: -1 C: -2; - https://gerrit.wikimedia.org/r/31004 [15:16:32] Change merged: Nikerabbit; [translatewiki] (master) - https://gerrit.wikimedia.org/r/31002 [15:18:11] Change merged: Nikerabbit; [translatewiki] (master) - https://gerrit.wikimedia.org/r/31003 [15:19:50] New review: Nikerabbit; "Ah API, good question. I don't think it does that." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/30955 [15:21:51] Change merged: Raimond Spekking; [mediawiki/extensions/GlobalBlocking] (master) - https://gerrit.wikimedia.org/r/24301 [15:22:40] New patchset: Alex Monk; "(bug 41172) Add wiki ID variable" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/31007 [15:23:26] New review: Daniel Werner; "I'd suggest having some sort of test runner. You would just define objects for your tests, without t..." [mediawiki/extensions/DataValues] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/31000 [15:23:26] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/31000 [15:23:28] 03(mod) Adding project identification variable to AbuseFilter - 10https://bugzilla.wikimedia.org/41172 +comment (10Krenair) [15:23:45] 03(FIXED) Undecoded timestamps for block expiry times. - 10https://bugzilla.wikimedia.org/40350 +comment (10Krenair) [15:24:06] New patchset: Siebrand; "Remove wikia from update-externals for now" [translatewiki] (master) - https://gerrit.wikimedia.org/r/31008 [15:24:27] New review: Nikerabbit; "I don't have the extension around to test, but if someone has tested I can merge it." [mediawiki/extensions/Calendar] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/30608 [15:26:41] Change merged: Siebrand; [translatewiki] (master) - https://gerrit.wikimedia.org/r/31008 [15:27:38] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30960 [15:29:59] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30999 [15:33:09] hmm, getting there i think - now the login page loads, but submitting it sends me to my localhost :) [15:34:00] Does helder.wiki ever use IRC? [15:34:15] I think so [15:34:18] yes [15:34:18] as "helder" IIRC [15:36:31] huzzah! got it [15:36:45] my $wgScriptPath was incorrect [15:36:50] I'm getting this on every page load now... I think I broke my test wiki [15:36:52] Notice: Attempted to ack a job in a transaction; committing first. [Called from JobQueueDB::doAck in /var/www/MediaWiki/Git/core/includes/job/JobQueueDB.php at line 230] in /var/www/MediaWiki/Git/core/includes/debug/Debug.php on line 283 [15:37:04] ^demon: thanks again for pointing me in the right direction with the .htaccess file [15:37:18] <^demon> You're welcome. Glad you got it working. [15:37:49] <^demon> Krenair: AaronSchulz has been poking the job queue, maybe he knows. [15:38:03] Aaron|home == AaronSchulz? [15:39:37] New patchset: Reedy; "Update ULS to master" [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/31010 [15:40:10] <^demon> Krenair: Same person, yes. [15:40:56] Okay, Aaron|home would you know why I keep getting this notice on my test wiki (git master, 8eb98ba currently)? [15:40:59] Notice: Attempted to ack a job in a transaction; committing first. [Called from JobQueueDB::doAck in /var/www/MediaWiki/Git/core/includes/job/JobQueueDB.php at line 230] in /var/www/MediaWiki/Git/core/includes/debug/Debug.php on line 283 [15:41:14] Change merged: Reedy; [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/31010 [15:42:17] New review: Cmcmahon; "this is because of FlaggedRevs. Since we're not explicitly testing FlaggedRevs here, giving +2 to s..." [qa/browsertests] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/30801 [15:42:31] New patchset: Siebrand; "Changes for Wikia on github" [translatewiki] (master) - https://gerrit.wikimedia.org/r/31011 [15:42:46] Change merged: Siebrand; [translatewiki] (master) - https://gerrit.wikimedia.org/r/31011 [15:43:15] 14(INVALID) &action=edit parameter is not always at the end of the URL - 10https://bugzilla.wikimedia.org/41561 +comment (10Chris McMahon) [15:45:25] 03(NEW) PHP Fatal error: Class 'Memcached' not found - 10https://bugzilla.wikimedia.org/41589 normal; Wikimedia: General/Unknown; (sam) [15:46:36] New patchset: Alex Monk; "(bug 25377) Tell RenameUser about our user fields in the DB" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/30936 [15:49:17] Who would be the people add as reviewers on that change? ^ [15:49:56] <^demon|lunch> AbuseFilter? Poke werdna. [15:52:10] And possibly Aaron [15:52:16] as it's user rename stuff [15:53:47] New patchset: Alex Monk; "(bug 25377) Tell RenameUser about our user fields in the DB" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/30936 [15:54:44] I have core and extensions in separate directories, instead of extensions being under core. This makes it annoying with extension maintenance scripts because they try to include the class from the wrong place [15:54:55] New patchset: Siebrand; "Fix typo" [translatewiki] (master) - https://gerrit.wikimedia.org/r/31012 [15:55:16] Change merged: Siebrand; [translatewiki] (master) - https://gerrit.wikimedia.org/r/31012 [15:55:52] Also with that change I'm not confident my database queries are the best in the world [15:57:37] New patchset: Siebrand; "Sort and remove duplicate line" [translatewiki] (master) - https://gerrit.wikimedia.org/r/31013 [15:57:40] New patchset: John Erling Blad; "Refactor ApiModifyEntity w/subclasses to use serialization" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31004 [15:57:51] Change merged: Siebrand; [translatewiki] (master) - https://gerrit.wikimedia.org/r/31013 [16:07:09] New review: Daniel Kinzler; "I have several suggestions for improvement. The only thin critical is the one in SqlStore.php. That'..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/30984 [16:07:54] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30947 [16:11:12] 03(mod) ULS: the IME feature causes the Wikidata UI breaking - 10https://bugzilla.wikimedia.org/41541 (10tobias.gritschacher) [16:11:55] * hexmode sighs [16:12:22] 03(mod) PHP Fatal error: Class 'Memcached' not found - 10https://bugzilla.wikimedia.org/41589 +comment (10Sam Reed (reedy)) [16:13:10] Couldn't get what I wanted by setting {{DISPLAYTITLE:}} in [[MediaWiki:noarticletext]] [16:13:14] 03(mod) ULS: the IME feature causes the Wikidata UI breaking - 10https://bugzilla.wikimedia.org/41541 +comment (10Siebrand) [16:13:54] it does change what is displayed on [[MediaWiki:noarticletext]] but not on some [[SomeRandomRedlink]] [16:14:08] New patchset: Alex Monk; "(bug 41582) Show "Page information" toolbox link to info action also in history etc." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31014 [16:14:10] * hexmode thinks this is a bug, opens one [16:14:12] 04(REOPENED) Input method window is transparent - 10https://bugzilla.wikimedia.org/41533 +comment (10Siebrand) [16:14:25] New patchset: Daniel Kinzler; "ORMRow must not ignore failures on insert by deault." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31015 [16:14:43] 03(mod) Show "Page information" toolbox link to info action also in history etc. - 10https://bugzilla.wikimedia.org/41582 +comment (10Krenair) [16:19:14] 03(NEW) Make aliases UI compatible with ULS IME - 10https://bugzilla.wikimedia.org/41590 normal; MediaWiki extensions: WikidataRepo; (tobias.gritschacher) [16:20:08] New patchset: Daniel Kinzler; "Avoid fatal error when some test messes up $wgUser." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31016 [16:20:17] New review: Siebrand; "@Niklas: +2 without +1 and a merge is confusing. What does that mean?" [mediawiki/extensions/PagedTiffHandler] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/30596 [16:20:18] 03(mod) ULS: the IME feature causes the Wikidata UI breaking - 10https://bugzilla.wikimedia.org/41541 (10tobias.gritschacher) [16:21:41] 03(NEW) DISPLAYTITLE does not work in MediaWiki:noarticletext - 10https://bugzilla.wikimedia.org/41591 normal; MediaWiki: General/Unknown; (mah) [16:23:33] anyone know where I can get a copy of the latest tgz of mediawiki? [16:23:48] wget "http://download.wikimedia.org/mediawiki/1.19/mediawiki-1.19.2.tar.gz" [16:23:55] Connecting to download.wikimedia.org|208.80.152.185|:80... failed: Connection timed out. [16:24:57] New review: Siebrand; "I'm considering to revert this. There are too many defects, and on second thought, I'm not convinced..." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/30945 [16:26:12] * chrisc ignore me, found a copy [16:29:43] 03(mod) Hard to tell whether an item has any content. - 10https://bugzilla.wikimedia.org/41495 (10denny vrandecic) [16:29:46] 03(mod) Item "kidnapped" after creation - 10https://bugzilla.wikimedia.org/41588 (10denny vrandecic) [16:30:43] 03(mod) api login returns wrong lgtoken on wikidata.org - 10https://bugzilla.wikimedia.org/41586 (10denny vrandecic) [16:32:14] 03(mod) api login returns wrong lgtoken on wikidata.org - 10https://bugzilla.wikimedia.org/41586 +comment (10Sam Reed (reedy)) [16:32:28] New patchset: Jeroen De Dauw; "Improved case insensitive lookup of terms" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30984 [16:34:02] Ryan_Lane, off-topic but you might be interested: Thunderbord thinks the notifications I receive from WebPlatform's MediaWiki are a scam. I guess it's because noc@webplatform.org via sendgrid.me [16:36:34] Thunderbird :) [16:40:09] 03(mod) Use normalized search key in term search index - 10https://bugzilla.wikimedia.org/41577 (10denny vrandecic) [16:40:37] New patchset: Zfilipin; "BASE_URL environment varibable says which site to test" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/31017 [16:40:38] 03(FIXED) Text loss on edit page - 10https://bugzilla.wikimedia.org/41352 (10denny vrandecic) [16:41:49] 03(mod) HTTPS site doing HTTP requests - 10https://bugzilla.wikimedia.org/41506 (10denny vrandecic) [16:43:45] Change abandoned: Zfilipin; "there is a problem with a previous commit" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/30801 [16:44:16] 03(mod) IME feature should be disabled by default - 10https://bugzilla.wikimedia.org/41542 (10denny vrandecic) [16:44:18] hm, am i wrong, or should bugs only be marked as fixed after the change is merged? [16:44:42] or is it enough for the change to be submitted? [16:45:11] Imo only after it's merged [16:45:25] 03(FIXED) Wikidata SSL - 10https://bugzilla.wikimedia.org/41437 (10denny vrandecic) [16:46:00] I agree, only mark it fixed once the fix is merged [16:46:09] and backported if necessary [16:46:11] andre__: ^ you agree? [16:46:24] thanks [16:46:24] 03(mod) Special:LandingCheck on donate.wikimedia.org without any URL parameters is not working - 10https://bugzilla.wikimedia.org/41566 +comment (10Peter Gehres (WMF)) [16:46:27] 04(REOPENED) Text loss on edit page - 10https://bugzilla.wikimedia.org/41352 +comment (10Bartosz Dziewoński) [16:47:00] Another email >:) [16:47:16] 03(mod) Moving pages (while leaving a redirect) does not work on wikidata.org - 10https://bugzilla.wikimedia.org/41574 (10denny vrandecic) [16:48:40] 03(NEW) make language links protocol-relative - 10https://bugzilla.wikimedia.org/41592 normal; MediaWiki extensions: WikidataRepo; (lydia.pintscher) [16:49:54] New patchset: Zfilipin; "'&action=edit' parameter is not always at the end of the URL" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/31019 [16:50:05] 03(mod) Accented letters not entered properly in aliases - 10https://bugzilla.wikimedia.org/41557 +comment (10denny vrandecic) [16:51:16] ...Wikia looks like a translator's noghtmare [16:51:36] 03(FIXED) Insufficient information to determine the title of the revision's page! - 10https://bugzilla.wikimedia.org/41436 (10denny vrandecic) [16:52:22] New review: Cmcmahon; "accommodate pages that may have FlaggedRevs in place." [qa/browsertests] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/31019 [16:52:22] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/31019 [16:52:32] 03(mod) Item "kidnapped" after creation - 10https://bugzilla.wikimedia.org/41588 (10jeblad) [16:53:19] 03(mod) It is possible to violate the label-description uniqueness constraint on items - 10https://bugzilla.wikimedia.org/41390 (10denny vrandecic) [16:54:10] New review: Cmcmahon; "make default target test env test2wiki, and make that explicit and visible in Jenkins jobs" [qa/browsertests] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/31017 [16:54:10] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/31017 [16:56:22] 03(FIXED) Transaction warnings during update.php - 10https://bugzilla.wikimedia.org/41170 (10denny vrandecic) [16:57:07] 03(mod) Replace wbsetitem with wbeditentity - 10https://bugzilla.wikimedia.org/40561 summary (10denny vrandecic) [16:58:24] 14(WFM) When I list all pages on wikidata.org the pages are not listed by ID but alphabetically - 10https://bugzilla.wikimedia.org/41575 +comment (10denny vrandecic) [16:59:07] 03(NEW) Add global to prevent writing to wb_changes database table - 10https://bugzilla.wikimedia.org/41593 enhancement; MediaWiki extensions: WikidataRepo; (sam) [16:59:22] 03(mod) Add global to prevent writing to wb_changes database table - 10https://bugzilla.wikimedia.org/41593 (10Sam Reed (reedy)) [17:00:27] Is basic syntax hilighting really too advanced for gerrit? [17:00:45] I mean, gerrit is pathetic, but this is *code* we're dealing with... [17:00:53] Isarra: i though it had some? [17:00:56] *but broken on Opera) [17:00:59] New review: Catrope; "@Krinkle: Could you explain your -1? You didn't submit a comment or any inline comments" [mediawiki/extensions/VisualEditor] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/30312 [17:00:59] ( [17:01:06] Well, that's stupid. [17:01:10] It needs an update from its upstream [17:01:25] Will it ever be updated to render html? [17:01:36] Isarra: it certainly has a checkbox that says "Syntax Coloring", i don't know what it does [17:01:45] (in Differences -> Preferences) [17:02:09] I have no idea what that means. Is there a differences menu somewhere? [17:02:12] 03(mod) IME feature should be disabled by default - 10https://bugzilla.wikimedia.org/41542 +comment (10Pau Giner) [17:02:12] <^demon> The upstream syntax highlighter that gerrit used has been pretty much abandoned since it was chosen. [17:02:20] 03(NEW) Make logging of changes to wb_changes optional - 10https://bugzilla.wikimedia.org/41594 normal; MediaWiki extensions: WikidataRepo; (denny.vrandecic) [17:02:21] <^demon> It's likely to be replaced with something nicer. [17:02:28] 03(mod) Make logging of changes to wb_changes optional - 10https://bugzilla.wikimedia.org/41594 (10denny vrandecic) [17:03:36] 03(NEW) Maintenance script for pruning wb_changes - 10https://bugzilla.wikimedia.org/41595 normal; MediaWiki extensions: WikidataRepo; (denny.vrandecic) [17:04:06] is it possible to change the topic branch a changeset belongs to without modifying the commit itself? [17:04:22] because I just tried git review -R -t new-branch and obviously it dodn't work [17:04:27] Wait, there are preferences? Where? [17:04:34] Isarra: when viewing a diff [17:04:35] New review: Parent5446; "Responded to comments. Will fix in next patch." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/17588 [17:04:38] in the top menu [17:04:50] (yup, that's some dumb interface) [17:05:32] Ghah, gitweb is something even worse, isn't it? [17:05:45] <^demon> Gitweb is a flaming pile of trash. [17:05:45] gitweb at least works [17:05:49] <^demon> No, it doesn't. [17:05:51] <^demon> It pretends to. [17:05:53] it does for me [17:05:59] better than gerrit itself, in fact [17:05:59] <^demon> It's a piece of shit. [17:06:01] Use github [17:06:13] Okay, that explains that. I mistook gitweb for gerrit. [17:06:17] <^demon> I hate gitweb, and I can't wait to destroy gitweb. [17:06:21] <^demon> I will remove it. [17:06:27] <^demon> And never ever touch it again. [17:06:41] Although it says something about how bad gerrit is that they can be mistaken for each other... [17:06:48] ^demon: do you maybe know if it's possible to change the topic branch a changeset belongs to without modifying the commit itself? [17:06:57] Though at least it isn't thatbad. [17:07:12] becuase gerrit decided to be clever and put a change called "(bug 457) use semantic headings for the navigation menu" in a branch bug/41456 [17:07:33] <^demon> MatmaRex: That's not gerrit's fault, like I said yesterday. [17:07:43] <^demon> It's git-review's braindead attempts at being "smart" [17:08:08] ugh, sorry, git-review and gerrit are mostly synonymous for me [17:08:10] Is it possible to use consistent urls and names for things such that the same number refers to the same thing in different places? [17:08:21] (and i don't you said anything about it yesterday, to me at least :) ) [17:08:28] <^demon> Somebody asked me about that since Monday. [17:08:50] <^demon> MatmaRex: If the topic bothers you, you could cherry pick and manually push back to gerrit `git push origin HEAD:refs/for/master/MY-AWESOME-TOPIC` [17:08:50] so uh, is there a way? or do i have to add a space to the commit message? :) [17:09:08] alright [17:09:22] * Isarra hugs MatmaRex. [17:09:41] Isarra: you mean in general or in gerrit? ;) [17:09:47] 06(LATER) Item "kidnapped" after creation - 10https://bugzilla.wikimedia.org/41588 +comment (10Lydia Pintscher) [17:10:00] MatmaRex: in... uh... yes. [17:10:43] gerrit isn't half-bad at recognizing magic things, i think [17:11:00] apart from failing completely if the shorthard sha1 happens to contain only numbers... [17:11:11] shorthand* [17:11:30] New review: Alex Monk; "resources/SecurePoll.js could do with code style fixing (mostly just whitespace issues). I've commen..." [mediawiki/extensions/SecurePoll] (master) C: -1; - https://gerrit.wikimedia.org/r/27024 [17:12:01] 03(NEW) Language objects should only load messages when needed - 10https://bugzilla.wikimedia.org/41596 normal; MediaWiki: Internationalization; (daniel.kinzler) [17:13:05] 03(mod) Language objects should only load messages when needed - 10https://bugzilla.wikimedia.org/41596 +wikidata (10Daniel Kinzler) [17:14:43] why does wikibugs use first part of your e-mail when notifying about a new bug, but your full name when notifying about anything else? [17:14:45] bug or feature? [17:15:40] bug [17:15:42] been there for ages [17:16:10] is it even reported? [17:16:24] maybe [17:16:52] New patchset: Aaron Schulz; "[JobQueue] Added a test job that just replaces itself." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30937 [17:17:00] aude: asked for you to review something that I think you'd be able to help with just now, but if I'm wrong please let me know [17:17:01] New patchset: Aaron Schulz; "[JobQueue] Added a test job that just replaces itself." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30937 [17:17:11] I thought something like that got fixed months ago [17:17:34] <^demon> Might've. The bot's almost never updated though. [17:17:42] Reedy, I noticed the Wikidata SSL bug was fixed, are you going to fix that broken HTTPS-E commit? [17:18:17] Krenair: I did, and it went into the 3.0.3 release [17:19:02] oh ok, I must've missed that email [17:19:08] I didn't email it [17:19:09] ^demon: https://gerrit.wikimedia.org/r/#/c/30937 :) [17:19:16] I got pinged in IRC about it [17:21:23] sumanah: link? [17:21:47] aude: https://gerrit.wikimedia.org/r/#/c/28904/ [17:22:36] MatmaRex: want to try your hand at some UploadWizard JS review? https://gerrit.wikimedia.org/r/#/c/30443/ [17:23:59] sumanah: sure, i'll look, but i barely know what UW does, and not at all how ;) [17:24:28] sumanah: i'd ask brion [17:24:49] i've not looked at proofread page yet nor OAI stuff yet [17:24:50] New patchset: Aaron Schulz; "Removed old broken script." [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/31023 [17:25:11] MatmaRex: If you need any guidance, I may be able to shed light on it [17:25:18] (if it's my patchset, that may be more complicated) [17:26:08] ok, thanks aude [17:26:40] 03(NEW) special page to list all items without label in a given language - 10https://bugzilla.wikimedia.org/41597 normal; MediaWiki extensions: WikidataRepo; (lydia.pintscher) [17:27:42] 14(DUP) Make logging of changes to wb_changes optional - 10https://bugzilla.wikimedia.org/41594 +comment (10Sam Reed (reedy)) [17:27:42] 03(mod) Add global to prevent writing to wb_changes database table - 10https://bugzilla.wikimedia.org/41593 +comment (10Sam Reed (reedy)) [17:27:58] marktraceur: thanks, but i think i'll figure it out. i'm a lone-wolf kinda guy ;) [17:28:49] MatmaRex: :) that's fine, I just don't want you to feel like you have to figure it out alone, UW was a beast to figure out at first [17:29:35] morning all. I am struggling with a mod_rewrite issue with Apache with Short URL's. tried 3x and struck out each time. any one know how to debug what Apache is *actually* doing ? pls. thx. [17:30:07] New patchset: Nischayn22; "Fixes display of Special:Properties." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/31024 [17:31:53] 03(FIXED) Special:Properties page should link to "action=view" for special properties - 10https://bugzilla.wikimedia.org/22442 +comment (10Nischay Nahata) [17:32:07] 03(mod) Display of special properties in Special:Properties page is strange (1.8 alpha) - 10https://bugzilla.wikimedia.org/29422 +comment (10Nischay Nahata) [17:32:43] sjobeck: Are you referring to the code or to the interface? [17:33:23] Sorry, wrong person. [17:33:29] Meant marktraceur. [17:34:50] Isarra: The code :) [17:35:22] Oh. [17:35:44] isarra: I mean the httpd.conf for this Apache server where mediawiki is sitting at the location on the file system at /var/www/html/w/ [17:35:47] sjobeck: what is actually not working? what are the symptoms? [17:35:52] I have tried .htaccess and httpd.conf and no luv. it yields HTTP 500 [17:36:02] "doesn't work" could mean a lot of things [17:36:13] ah [17:36:13] sjobeck: The htaccess goes in the... uh... [17:36:13] New review: Alex Monk; "That's been abandoned now. Is this going to be abandoned as well?" [mediawiki/extensions/SemanticForms] (master) C: 0; - https://gerrit.wikimedia.org/r/27196 [17:36:18] Actually, I have no idea, sorry. >.< [17:36:20] well, long url's work fine. example.com/mediawiki/index.php?=Me [17:36:33] short url's of example.com/wiki/Me fail with a 500 [17:36:49] Last time I just shoved everything into an include in the main apache.conf and hoped it would work and it mostly did. [17:36:58] MatmaRex :) [17:37:17] isarra: have a snippet please ? thx ! [17:38:02] New patchset: Matthias Mullie; "maintenance" [mediawiki/extensions/CreditsSource] (master) - https://gerrit.wikimedia.org/r/31026 [17:38:27] fyi, this works too example.com/wiki/index.php/Cloud which i don't know what that type of URL is. [17:38:49] I added the rewrite rules from the mediawiki wiki into the vhost definition for the url. [17:38:56] And they just worked. Mostly. [17:39:17] RewriteRule ^/?wiki(/.*)?$ %{DOCUMENT_ROOT}/w/index.php [L] [17:39:17] RewriteRule ^/*$ %{DOCUMENT_ROOT}/w/index.php [L] [17:39:39] Replace w with mediawiki, though. [17:39:53] If your base directory is mediawiki. [17:40:33] What is the name of the directory the files are in? [17:40:47] mlitn: descriptive commits! [17:40:56] it was "mediawiki" but someone told me to not do that and use "w" [17:41:10] mlitn: http://www.mediawiki.org/wiki/Git/Commit_message_guidelines [17:41:41] mediawiki works fine, it's just longer. But if you have w, those lines in htaccess in it should work? Somehow. I dunno how htaccess works, though. [17:42:00] ori-l: "committed the changes" [17:44:41] New review: Alex Monk; "As far as I can tell from operations/mediawiki-config it's not used on any WMF site but is still on ..." [mediawiki/extensions/ScanSet] (master) C: 1; - https://gerrit.wikimedia.org/r/26781 [17:44:48] New patchset: preilly; "Update MobileFrontend to master" [mediawiki/core] (wmf/1.21wmf2) - https://gerrit.wikimedia.org/r/31029 [17:48:11] New patchset: preilly; "Update MobileFrontend to master" [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/31030 [17:48:13] ori-l: you're right - won't happen again! [17:48:21] Change merged: Mwalker; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/30934 [17:48:39] Change merged: preilly; [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/31030 [17:48:40] New review: Reedy; "I know it was discussed "recently".. Should be dropped from make-wmf-branch too" [mediawiki/extensions/ScanSet] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26781 [17:48:48] Change merged: preilly; [mediawiki/core] (wmf/1.21wmf2) - https://gerrit.wikimedia.org/r/31029 [17:48:54] Oh wow, WMF San Francisco is affected more by the Giants' victory parade than WMF New York City (Andrew & me) is affected by Sandy [17:49:36] New review: Dzahn; "get rid of non-puppet wikibugs starting script to prevent duplicate bots, yea" [wikimedia/bugzilla/wikibugs] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/27193 [17:49:36] Change merged: Dzahn; [wikimedia/bugzilla/wikibugs] (master) - https://gerrit.wikimedia.org/r/27193 [17:49:59] isarra: looking [17:53:21] 03(mod) When I list all pages on wikidata.org the pages are not listed by ID but alphabetically - 10https://bugzilla.wikimedia.org/41575 +comment (10Zil) [17:54:15] 03(mod) When I list all pages on wikidata.org the pages are not listed by ID but alphabetically - 10https://bugzilla.wikimedia.org/41575 +comment (10Zil) [17:54:50] New review: Alex Monk; "Please use a short first line in future. It is used as a summary - you can see why in the parent com..." [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/26772 [17:55:19] Interestingly, MediaWiki commits have decreased 6% in the past 12 months compared to the previous YoY period, while the number of contributors has increased up +65 (86%) from previous 12 months [17:55:27] https://www.ohloh.net/p/mediawiki [17:56:13] isarra: it seems like rewrite is simply not working [17:56:21] qgil, that's probably because of the git migration [17:56:31] can you point me where to go next for that issue? [17:56:42] About the commits, can it be that the past 12 months was a period more of maintenance compared to the previous 12 months? [17:56:45] in SVN you would commit and then if the commit was broken it'd be fixed in futher commits [17:56:51] any one out there know how to debug mod_rewrite ignoring me ? [17:56:57] In Git everything is amended and then the final working version makes it into the repo [17:57:05] That's my understanding of it anyway [17:57:19] in gerrit* [17:57:47] <^demon> Indeed. If there was a way to combine "follow ups" in SVN, I think the numbers would be closer to one another. [17:58:31] in "pure git", you'd either do it the way you did on svn, or use topic branches, but instead of amending, you'd create follow-up commits and only merge to master once it was deemed good enough, i think [17:58:37] Krenair, that makes sense: thank you! [17:58:37] about the increase of contributors, we are seeing nice % up in all rpojects. I guess WMF aggressive hiring is part of this but still there seems to be something more? [17:58:38] How are you feeling this increase of population? Only in commits stats or actually visible in day to day project life? [18:01:14] qgil: Krenair has been contributing actively for less than a year so he'll have a somewhat shorter perspective on that :) [18:01:20] That might also be down to the git migration, but I'm not sure because I didn't really know the community before it [18:01:41] sjobeck: Do you have a 'RewriteEngine On' line, and does apache have the rewrite module included? [18:01:48] well, Krenair is an actual proof that increase, then ;) [18:01:53] I actually decided not to contribute until the git migration. [18:02:07] New patchset: Reedy; "Remove ScanSet as it's not deployed anymore" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/31031 [18:02:31] remember that the population stats are also a bit skewed - where people would submit a patch before, they submit a gerrit changeset now [18:02:45] I knew it was coming up and thought there wouldn't be much point learning my way around SVN [18:04:06] Change merged: Reedy; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/31031 [18:04:14] Looking at the monthly stats, until April there were about 30-something contributors. Since April the monthly average rounds the 50s. [18:04:57] qgil: hmm, https://www.mediawiki.org/wiki/Wikimedia_engineering_report/2012/January "100 unique committers contributed code to MediaWiki." [18:05:24] qgil: (and here you're only counting patches/commits, right?) [18:06:49] New review: Krinkle; "Same thing as before (see comment on patch set 1)" [mediawiki/extensions/VisualEditor] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/30312 [18:07:03] qgil: you may already know this: before the Git migration, translators had to commit translation improvements & message changes as SVN commits [18:07:17] git migration was march 21st(roughly?), so actually that sort of makes sense [18:07:17] so we are conflating translations (which are also an important contribution stream) with code commits [18:08:00] sumanah, 100? Ohloh counts 328! Ok, same contributors may use different email addresses, but still: https://www.ohloh.net/p/mediawiki/contributors [18:08:35] sumanah, yes all this stats are based on code contributions only [18:08:45] qgil: 100 in January, not overall [18:09:06] 03(mod) api login returns wrong lgtoken on wikidata.org - 10https://bugzilla.wikimedia.org/41586 +comment (10merl) [18:09:31] sumanah, currently all translations are being channeled through the Translation bot, who counts as just one: https://www.ohloh.net/p/mediawiki/contributors/96637260357 Maybe it was also the case in SVN? [18:10:12] I believe individual translators often committed translations in SVN, qgil - will poke around https://www.mediawiki.org/wiki/Special:Code/MediaWiki [18:10:24] New patchset: Trevor Parscal; "Cleanup tool API" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/30312 [18:10:46] sumanah, ah. Again according to Ohloh readings there are 140 MediaWiki contributors active in the past 12 months, which gets closer to those 100 unique in January [18:11:24] Anyway, the numbers seem to be going up no matter how we compute ;) [18:11:35] 03(NEW) Page’s title is not the same than page’s label after editing - 10https://bugzilla.wikimedia.org/41598 normal; MediaWiki extensions: Wikidata; (ltrlg.wp) [18:11:43] :) true. Look at https://www.mediawiki.org/w/index.php?title=Special:Code/MediaWiki&offset=109950 for a sampling [18:12:18] r109945: raymond's "Localisation updates for core and extension messages from translatewiki.net" [18:13:21] New patchset: Reedy; "Catchable fatal error: Argument 1 passed to ReaderFeedbackHooks::ratingToolboxLink() must be an instance of Skin, instance of VectorTemplate given in /usr/local/apache/common-local/php-1.21wmf3/extensions/ReaderFeedback/ReaderFeedback.hooks.php on line 1" [mediawiki/extensions/ReaderFeedback] (master) - https://gerrit.wikimedia.org/r/31033 [18:13:23] New review: Krinkle; "Haven't tested yet, but looks good to me." [mediawiki/extensions/VisualEditor] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/30312 [18:13:36] Change merged: Reedy; [mediawiki/extensions/ReaderFeedback] (master) - https://gerrit.wikimedia.org/r/31033 [18:14:25] 03(mod) Page’s title is not the same as page’s label after editing - 10https://bugzilla.wikimedia.org/41598 summary (10Ltrlg) [18:14:55] New patchset: Reedy; "Update RF to master" [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/31034 [18:15:22] Change merged: Reedy; [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/31034 [18:18:33] 03(mod) Page’s title is not the same as page’s label after editing - 10https://bugzilla.wikimedia.org/41598 (10Lydia Pintscher) [18:18:42] New patchset: Umherirrender; "Fix prop=userid in list=protectedtitles" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31035 [18:20:31] 03(FIXED) PHP Fatal error: Class 'Memcached' not found - 10https://bugzilla.wikimedia.org/41589 +comment (10Daniel Zahn) [18:21:07] sumanah, we all agree after it's merged I'd say [18:21:16] but looks like it needs clariifcation :/ [18:21:29] andre__: I'll leave that to you. :) [18:22:04] New patchset: Umherirrender; "Fix prop=userid in list=protectedtitles" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31035 [18:22:33] New review: Umherirrender; "Fix syntax error, saving before commit can help" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/31035 [18:23:45] Change merged: Catrope; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/30312 [18:24:15] New patchset: Foxtrott; "force type=submit for buttons; provide placeholder attribute" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/30891 [18:24:52] New review: John Erling Blad; "This is work in progress, but I forgot to mark it as such" [mediawiki/extensions/Wikibase] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/30055 [18:26:11] New patchset: Siebrand; "Fix fatal: $skin is not a Skin, but a SkinTemplate" [mediawiki/extensions/ReaderFeedback] (master) - https://gerrit.wikimedia.org/r/31037 [18:28:40] Change merged: Reedy; [mediawiki/extensions/ReaderFeedback] (master) - https://gerrit.wikimedia.org/r/31037 [18:29:21] New patchset: Reedy; "Update to master again" [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/31038 [18:29:45] Change merged: Reedy; [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/31038 [18:30:03] sumanah, re I921fc032 ("Reduce master load from Title::isValidMoveOperation when possible") - I'm not sure about this one, sorry [18:30:55] Krenair: that's one of the AbuseFilter ones? [18:31:01] Krenair: or I mean LQT? [18:31:22] LQT [18:31:44] New review: Daniel Werner; "also, needs rebase" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/30055 [18:31:59] Krenair: given that a lot of WMF sites need LQT improvements I'm hoping I can ask you to become one of the people who works on LQT [18:32:48] Echo, the replacement, won't be really ready for at least a few months [18:33:05] Echo isn't exactly a replacement for LQT [18:33:16] echo is not a replacement for LQT. [18:33:37] Echo really doesn't interect the use cases for LQT at all. [18:33:59] maybe he meant Flow? [18:34:12] I meant Flow. [18:34:14] Argh. [18:34:18] that's not ready at all :) [18:34:20] I need to stop saying Echo when I mean Flow [18:34:24] And database performance/profiling isn't really something I know much about [18:34:55] there's always a first time [18:35:16] On the subject of Echo actually, on Trello I see two bug cards which are WFM. The other is about duplicate notifications for one event [18:35:33] 03(NEW) Message 'wikibase-api-cant-edit' markef as "Do not translate" but used in UI - 10https://bugzilla.wikimedia.org/41599 normal; MediaWiki extensions: WikidataRepo; (raimond.spekking) [18:35:36] 03(mod) PHP Fatal error: Class 'Memcached' not found - 10https://bugzilla.wikimedia.org/41589 +comment (10Sam Reed (reedy)) [18:35:45] It was enabled on MediaWiki.org at one point but then there was a bug and it was disabled. [18:35:48] New patchset: preilly; "Update ZeroRatedMobileAccess to master" [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/31040 [18:36:52] New patchset: Siebrand; "Fix documentation and variable name" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/31041 [18:37:05] New patchset: preilly; "Update ZeroRatedMobileAccess to master" [mediawiki/core] (wmf/1.21wmf2) - https://gerrit.wikimedia.org/r/31043 [18:37:33] Is there any chance it can be re-enabled? [18:37:38] Change merged: preilly; [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/31040 [18:37:42] Change merged: preilly; [mediawiki/core] (wmf/1.21wmf2) - https://gerrit.wikimedia.org/r/31043 [18:37:47] The config says it was this bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=39085 [18:37:47] 03(mod) tokenQuery[tokenType].done is not a function - 10https://bugzilla.wikimedia.org/41570 +comment (10Jon) [18:39:25] New patchset: Siebrand; "Fix docs" [mediawiki/extensions/ShortUrl] (master) - https://gerrit.wikimedia.org/r/31045 [18:39:25] sumanah, I guess actually that change looks okay [18:39:40] New review: Chughakshay16; "And reg the suggestion of displaying links in the same line as normal categories, I would like to ad..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/3981 [18:39:53] +1'd [18:40:07] Krenair: re reenabling functionality on mw.org, you could ask its product manager [18:42:50] Hello. [18:43:16] hi Dereckson [18:43:30] I'll email Terry Chay [18:44:15] Oh - actually [18:44:16] or the director, that works too [18:44:24] tewwy, are you around at the moment? :) [18:45:01] 03(mod) Meta-Wiki mobile site has errant trademark symbol (™) in footer - 10https://bugzilla.wikimedia.org/41141 +comment (10Brion Vibber) [18:46:33] New patchset: Siebrand; "Fix documentation and variable name" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/31047 [18:47:43] hmm guess not. [18:48:26] New patchset: Mwalker; "More intelligent banner caching for CN" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/31048 [18:48:38] New patchset: Umherirrender; "Add 'contentmodel' to resultproperties in prop=revisions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31049 [18:50:07] Change abandoned: Siebrand; "Actually, I'm not really sure. Do dropping this." [mediawiki/extensions/ShortUrl] (master) - https://gerrit.wikimedia.org/r/31045 [18:50:11] Change abandoned: Siebrand; "Actually, I'm not really sure. Do dropping this." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/31047 [18:51:12] New review: Adamw; "Great! I just need to test it..." [mediawiki/extensions/CentralNotice] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/31048 [18:51:22] New patchset: Aaron Schulz; "[JobQueue] Use "flush" option with commit()." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31050 [18:51:34] 03(mod) Missing indentation for lists - 10https://bugzilla.wikimedia.org/41543 +comment (10Jon) [18:52:19] 03(mod) Display of special properties in Special:Properties page is strange (1.8 alpha) - 10https://bugzilla.wikimedia.org/29422 +comment (10Yaron Koren) [18:54:00] New patchset: Siebrand; "(bug 40495) Undefined $item" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/30614 [18:54:31] New review: Siebrand; "PS3 addresses comment on PS2." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/30614 [19:01:29] 03(mod) Display of special properties in Special:Properties page is strange (1.8 alpha) - 10https://bugzilla.wikimedia.org/29422 +comment (10Nemo_bis) [19:01:35] 03(mod) Special:Properties / usage of system message "Smw property template" is broken - placeholders (1.8 beta2) - 10https://bugzilla.wikimedia.org/41480 +comment (10Nemo_bis) [19:03:06] New patchset: Katie Horn; "Falseish when I was trying to look for a zero. So very annoyed." [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/31056 [19:04:23] New review: Pgehres; "looks good" [mediawiki/extensions/DonationInterface] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/31056 [19:04:23] Change merged: Pgehres; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/31056 [19:08:35] New patchset: Aude; "store rc_bot in change info blob" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30803 [19:11:46] New patchset: Umherirrender; "Add 'dimensions' and 'thumbmine' to resultproperties in prop=imageinfo" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31058 [19:14:09] ParserTests::testParserTest with data set #0 ('Blank input', '', '', '', '') [19:14:14] hashar: is anyone fixing that? [19:14:37] tried this morning [19:14:39] gave up [19:15:22] AaronSchulz: i18n team has been hit by the timeout issue while submitting changes against REL1_18 and REL1_19. Those branches did use a 2 seconds timeout. [19:15:29] it is 10 secs in master [19:15:34] so "should not happen" :-] [19:15:40] New patchset: Daniel Kinzler; "ORMRow must not ignore failures on insert by deault." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31015 [19:15:48] New patchset: Umherirrender; "Add 'contentmodel' to list=deletedrevs" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31060 [19:16:11] PHP_Invoker_TimeoutException: Execution aborted after 10 seconds [19:16:16] that is crazy [19:16:34] 03(mod) tokenQuery[tokenType].done is not a function - 10https://bugzilla.wikimedia.org/41570 +comment (10Jon) [19:16:45] 03(mod) Message 'wikibase-api-cant-edit' marked as "Do not translate" but used in UI - 10https://bugzilla.wikimedia.org/41599 +i18n; summary (10Raimond Spekking) [19:17:57] New patchset: Daniel Kinzler; "Fix handling of prot-rel URLs in SiteObject." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31062 [19:17:57] New patchset: Aaron Schulz; "Added a script to clean up file 404s." [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/31063 [19:19:08] AaronSchulz: https://bugzilla.wikimedia.org/show_bug.cgi?id=41565 [19:19:59] AaronSchulz: the NewParserTests do a ton of initialization before each test. I suspect the first run to be very long since it needs to recache a few languages, parse articles etc.. [19:20:11] 03(mod) Blank messages via Mobile Feedback should not be sent - 10https://bugzilla.wikimedia.org/41502 +comment (10Jon) [19:20:22] New patchset: Umherirrender; "Add missing resultproperties to list=deletedrevs" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31064 [19:20:24] 03(mod) random occurences of svn and phase3 in code - 10https://bugzilla.wikimedia.org/38714 normal->minor; +easy (10Andre Klapper) [19:20:26] 03(NEW) untranslated search placeholder - 10https://bugzilla.wikimedia.org/41600 normal; MediaWiki extensions: UniversalLanguageSelector; (waldir) [19:20:34] hashar: https://gerrit.wikimedia.org/r/#/c/31050/ simple [19:21:15] AaronSchulz: expect I have no knowledge about the transaction system :) [19:21:28] New patchset: Nischayn22; "Added support for custom texts." [mediawiki/extensions/SemanticWatchlist] (master) - https://gerrit.wikimedia.org/r/28400 [19:22:03] New patchset: Daniel Kinzler; "Introducing maintenance/populateSitesTable.php" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31065 [19:22:43] 03(mod) Blank messages via Mobile Feedback should not be sent - 10https://bugzilla.wikimedia.org/41502 +comment (10Oliver Keyes) [19:22:54] New patchset: TheDJ; "There is no need to use an expanded URL for this downloadlink." [mediawiki/extensions/Collection] (master) - https://gerrit.wikimedia.org/r/31066 [19:23:01] New patchset: Daniel Kinzler; "Introducing maintenance/populateSitesTable.php" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31065 [19:23:49] Change merged: Aaron Schulz; [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/31063 [19:24:35] 03(NEW) Language search should use native/default name - 10https://bugzilla.wikimedia.org/41601 normal; MediaWiki extensions: UniversalLanguageSelector; (waldir) [19:25:52] 03(mod) HTTPS site doing HTTP requests - 10https://bugzilla.wikimedia.org/41506 +patch-in-gerrit; +comment (10Daniel Kinzler) [19:27:15] gerrit sucks. I see no way to view the diff of a merged commit through the commit log of a file [19:27:43] New patchset: Adamw; "DO NOT MERGE - 2-round-trip banner load" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/29527 [19:27:59] 03(mod) Display of special properties in Special:Properties page is strange (1.8 alpha) - 10https://bugzilla.wikimedia.org/29422 +comment (10Nischay Nahata) [19:28:46] New patchset: jan; "(bug 24620) Add tests for LogFormatter" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31067 [19:29:17] well, just found a way to do that... :/ [19:30:32] 03(mod) tokenQuery[tokenType].done is not a function - 10https://bugzilla.wikimedia.org/41570 +comment (10Jon) [19:31:35] New review: jan; "I have created a second change with the tests for this change: I7218a1738c97db1d888605cecdfbffe21ca0..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/29279 [19:31:35] New patchset: TheDJ; "(bug 41273) Expand license URL for PDF rendering" [mediawiki/extensions/Collection] (master) - https://gerrit.wikimedia.org/r/31069 [19:31:49] hashar: can you look at https://gerrit.wikimedia.org/r/#/c/30937/ then? [19:31:57] 03(mod) "Download as PDF" contains broken licence link - 10https://bugzilla.wikimedia.org/41273 +patch-in-gerrit; +comment (10Derk-Jan Hartman) [19:32:11] useful for testing [19:32:20] Change abandoned: Hoo man; "Probably you're right, these are just to long..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/28918 [19:33:00] 03(ASSIGNED) HTTPS site doing HTTP requests - 10https://bugzilla.wikimedia.org/41506 (10Daniel Kinzler) [19:33:06] New patchset: Nischayn22; "Added support for custom texts." [mediawiki/extensions/SemanticWatchlist] (master) - https://gerrit.wikimedia.org/r/28400 [19:33:14] 03(NEW) Message 'wikibase-error-sitelink-already-used' is not parsed - 10https://bugzilla.wikimedia.org/41602 normal; MediaWiki extensions: WikidataRepo; (raimond.spekking) [19:33:28] 03(NEW) Localisation for special pages of extensions no longer working - 10https://bugzilla.wikimedia.org/41603 normal; MediaWiki extensions: Translate; (s.mazeland) [19:33:28] 03(mod) Bugs affecting translatewiki.net (errors from MediaWiki master) (tracking) - 10https://bugzilla.wikimedia.org/39480 (10Siebrand) [19:34:13] 03(mod) Blank messages via Mobile Feedback should not be sent - 10https://bugzilla.wikimedia.org/41502 +comment (10Jon) [19:35:57] 03(mod) Display of special properties in Special:Properties page is strange (1.8 alpha) - 10https://bugzilla.wikimedia.org/29422 +comment (10Yaron Koren) [19:36:32] New review: Alex Monk; "I was messing around with emails and got a bad one while I was still on this branch. $5 is supposed ..." [mediawiki/extensions/Echo] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/15959 [19:38:32] Krenair: Yes sorry [19:38:53] 03(mod) Blank messages via Mobile Feedback should not be sent - 10https://bugzilla.wikimedia.org/41502 +comment (10Oliver Keyes) [19:39:34] New review: Hashar; "Do we have tests for the job queue? If so you might want to write one." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/30937 [19:39:45] off for dinner [19:39:58] 03(mod) ee.pl does not work - 10https://bugzilla.wikimedia.org/29035 +comment (10Bawolff) [19:40:09] New review: Yaron Koren; "I think you can pass in the HTML for form fields directly in to wfMessage() - you just need to call ..." [mediawiki/extensions/SemanticWatchlist] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/28400 [19:40:51] wtf gerrit [19:41:11] 03(FIXED) Unable to input Japanese text - 10https://bugzilla.wikimedia.org/41547 +comment (10Yuvi Panda) [19:41:34] 03(mod) HTTPS site doing HTTP requests - 10https://bugzilla.wikimedia.org/41506 +comment (10Sam Reed (reedy)) [19:42:44] New review: Nischayn22; "that is true for PHP, not sure if it applies to JS as well. Did you try out the new patchset?" [mediawiki/extensions/SemanticWatchlist] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/28400 [19:43:49] New patchset: Aaron Schulz; "[JobQueue] Added a test job that just replaces itself." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30937 [19:44:01] New patchset: Hoo man; "(bug 7851) Added AJAX patrolling (mediawiki.page.patrol.ajax)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26440 [19:44:23] 03(mod) Display of special properties in Special:Properties page is strange (1.8 alpha) - 10https://bugzilla.wikimedia.org/29422 +comment (10Nischay Nahata) [19:44:28] New review: Hoo man; "Yet another manual rebase..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/26440 [19:45:20] :/ [19:47:01] New review: Aaron Schulz; "Other stuff mixed in." [mediawiki/core] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/30937 [19:47:06] New review: Hashar; "I guess you also wants to update docs/hooks.txt." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/27265 [19:47:58] New patchset: Hoo man; "(bug 36053) Login returnto doesn't work if title isn't in the URI" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/29729 [19:47:58] New patchset: Aaron Schulz; "[JobQueue] Added a test job that just replaces itself." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30937 [19:47:58] New review: Hoo man; "Rebase" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/29729 [19:49:49] 03(mod) Wikis waiting to be renamed (tracking) - 10https://bugzilla.wikimedia.org/19986 +comment (10とある白い猫) [19:49:56] New review: Siebrand; "This is pretty cool. Regardless of all future review comments: Thanks!" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/31067 [19:50:39] New review: Hashar; "What about not using $wgUser anymore ? Cant you craft a user dedicated to that test class?" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/31016 [19:51:21] New review: Hashar; "I have zero knowledge about the ORM* classes so I am stepping out of this review request :/" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/31015 [19:52:00] 03(NEW) Watch list icon doesn't update on subsequent page load - 10https://bugzilla.wikimedia.org/41604 normal; MediaWiki extensions: MobileFrontend (Beta); (jrobson) [19:52:05] New review: Adamw; "It's very cool, I'm sort of blocked on the [1..max] randomness though, pls explain" [mediawiki/extensions/CentralNotice] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/31048 [19:52:21] 03(mod) Blank messages via Mobile Feedback should not be sent - 10https://bugzilla.wikimedia.org/41502 +comment (10Arthur Richards) [19:52:41] 03(mod) Message 'wikibase-api-cant-edit' marked as "Do not translate" but used in UI - 10https://bugzilla.wikimedia.org/41599 (10jeblad) [19:54:13] New patchset: Daniel Kinzler; "(Bug 41594) Create option to disable wb_changes table" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31074 [19:54:47] New patchset: Spage; "Add interactive validation of form fields" [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/30755 [19:55:57] 03(mod) Add global to prevent writing to wb_changes database table - 10https://bugzilla.wikimedia.org/41593 +comment (10Daniel Kinzler) [19:56:18] New patchset: TheDJ; "Restructuring Math classes" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/30177 [19:56:40] 03(NEW) History pushState misbehaving on 4.0.4 - 10https://bugzilla.wikimedia.org/41605 normal; MediaWiki extensions: MobileFrontend (Beta); (jrobson) [19:56:54] Change abandoned: Siebrand; "Depends on an abandoned patch set. Thanks for pointing it out, Alex." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/27196 [19:59:44] New patchset: Siebrand; "Localisation updates from http://translatewiki.net." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31076 [20:00:54] 04(REOPENED) Message 'wikibase-api-cant-edit' marked as "Do not translate" but used in UI - 10https://bugzilla.wikimedia.org/41599 +comment (10Raimond Spekking) [20:01:23] 03(mod) User contributions feed does not display diffs - 10https://bugzilla.wikimedia.org/41085 (10wempwer) [20:02:14] Change merged: Reedy; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31062 [20:02:26] 03(NEW) History only shows latest move - 10https://bugzilla.wikimedia.org/41606 normal; MediaWiki: History/Diffs; (aklapper) [20:03:17] https://integration.mediawiki.org/ci/job/MediaWiki-Tests-API/8199/ seems to hung up... [20:04:26] New patchset: Siebrand; "Comment out unused local variable and reference class variable properly." [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/26776 [20:04:32] New review: Reedy; "How does this work if you've already got entries in the database?" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/31065 [20:04:50] New review: Siebrand; "PS4 removed pre-existing trailing whitespace per comment on PS3." [mediawiki/extensions/Validator] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26776 [20:04:55] same for this https://integration.mediawiki.org/ci/job/Ext-Wikibase/1756/ [20:04:55] anyone? [20:06:20] 14(WFM) api login returns wrong lgtoken on wikidata.org - 10https://bugzilla.wikimedia.org/41586 +comment (10Daniel Kinzler) [20:07:50] 03(mod) Supporting __STATICREDIRECT__ - 10https://bugzilla.wikimedia.org/40755 (10jeblad) [20:08:40] hoo: going to restart jenkins [20:08:42] all seems hung up [20:08:57] 03(mod) api of mobile view outputs section headers with HTML differently then normal view - 10https://bugzilla.wikimedia.org/41546 (10Jon) [20:08:58] Reedy: Thanks... this IMO happens way to often [20:09:51] <^demon> No need to stop the whole server...could've just killed the hung test. [20:09:54] I tried [20:10:05] <^demon> Now we have to re-trigger all of those builds :\ [20:10:05] For both of them [20:10:20] The interface wouldn't refresh after stopping it [20:10:33] New patchset: Parent5446; "Added Uri class and Uri Query classes." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22167 [20:11:10] New patchset: Siebrand; "Maintenance for SecurePoll extension." [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/27024 [20:11:40] New patchset: Siebrand; "Localisation updates from http://translatewiki.net." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31076 [20:12:43] New review: Siebrand; "Thanks for the review. New PS uploaded with updates." [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/27024 [20:13:14] New patchset: Jeroen De Dauw; "Introduced Term interface and maintenance script to rebuild the term search keys" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31078 [20:13:17] ^demon: https://gerrit.wikimedia.org/r/#/c/31050/ is another simple one [20:15:06] New review: Parent5446; "The problem is that sometimes you have hooks (such as InfoAction), which pass a context as one of th..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/27265 [20:16:30] 03(mod) MF beta selecting 'Main Page' from search shows non-special-cased page display - 10https://bugzilla.wikimedia.org/41290 +comment (10Jon) [20:16:59] 03(mod) escaping problem on Special:ItemDisambiguation - 10https://bugzilla.wikimedia.org/41576 (10jeblad) [20:17:29] New review: Hashar; "Is that a bug in a specific SQLite version? Or just a bug? We might face this issue whenever we ins..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/30994 [20:19:49] 03(mod) escaping problem on Special:ItemDisambiguation - 10https://bugzilla.wikimedia.org/41576 (10jeblad) [20:19:49] 03(mod) Add item link is broken on Special:ItemByTitle - 10https://bugzilla.wikimedia.org/39485 (10jeblad) [20:20:07] 03(mod) Deleted revision of a file is not moved when file is renamed - 10https://bugzilla.wikimedia.org/40737 +comment (10Jesús Martínez Novo) [20:22:25] 03(mod) escaping problem on Special:ItemDisambiguation - 10https://bugzilla.wikimedia.org/41576 (10jeblad) [20:24:12] New review: Spage; "It worked on piramido. Fixing this means ACUX appears with appearance glitches on IE7 and IE8, Stev..." [mediawiki/extensions/E3Experiments] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/30762 [20:24:12] Change merged: Spage; [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/30762 [20:24:47] New review: Daniel Kinzler; "@hashar: it's a limitation of sqlite, at least in version 5.3.6-13ubuntu3.9. I didn't check any othe..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/30994 [20:25:02] New patchset: Aaron Schulz; "Updated TimedMediaHandler to master." [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/31079 [20:26:27] New patchset: Aaron Schulz; "Updated TimedMediaHandler to master." [mediawiki/core] (wmf/1.21wmf2) - https://gerrit.wikimedia.org/r/31080 [20:28:05] Change merged: Siebrand; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31076 [20:29:41] New patchset: Jeroen De Dauw; "Bump to 0.1 and updated doc files" [mediawiki/extensions/Wikibase] (0.1.x) - https://gerrit.wikimedia.org/r/31081 [20:31:02] New patchset: Daniel Kinzler; "Fix handling of striongs containing \0 in sqlite." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30994 [20:32:54] New review: Matmarex; "Doesn't hurt, but isn't MediaWiki always in standards mode in IE?" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/30819 [20:33:32] New patchset: jan; "(bug 24620) Add tests for LogFormatter" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31067 [20:33:48] New review: Hoo man; "With the default skins it should... so maybe we should mark this change as IE lt 8 in the code comment?" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/30819 [20:35:05] 03(mod) Moving pages (while leaving a redirect) does not work on wikidata.org - 10https://bugzilla.wikimedia.org/41574 +comment (10Daniel Kinzler) [20:35:25] Reedy: can you grab something from the error log for me, please? [20:35:34] Change merged: Aaron Schulz; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/30774 [20:35:39] [76c44306] 2012-10-31 20:34:13: Fatal exception of type MWException. [20:35:40] New patchset: Spage; "Restore benefits CSS, tooltips for error messages" [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/30752 [20:36:01] or ^demon or AaronSchulz. [20:36:10] page moves are failing on wikidata.org for some reason. [20:36:18] 14(DUP) Special:Properties / usage of system message "Smw property template" is broken - placeholders (1.8 beta2) - 10https://bugzilla.wikimedia.org/41480 +comment (10[[kgh]]) [20:36:19] 03(mod) Display of special properties in Special:Properties page is strange (1.8 alpha) - 10https://bugzilla.wikimedia.org/29422 +comment (10[[kgh]]) [20:36:25] please post the log to https://bugzilla.wikimedia.org/show_bug.cgi?id=41574 [20:36:59] New patchset: Aaron Schulz; "Updated TimedMediaHandler to master." [mediawiki/core] (wmf/1.21wmf2) - https://gerrit.wikimedia.org/r/31080 [20:37:54] 03(mod) Display of special properties in Special:Properties page is strange (1.8 beta2) - 10https://bugzilla.wikimedia.org/29422 summary (10[[kgh]]) [20:38:09] New patchset: Aaron Schulz; "Updated TimedMediaHandler to master." [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/31079 [20:38:38] New review: Siebrand; "Thanks for the review. PS4 contains an update addressing the comments." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/27179 [20:38:41] Change merged: Aaron Schulz; [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/31079 [20:38:54] Change merged: Aaron Schulz; [mediawiki/core] (wmf/1.21wmf2) - https://gerrit.wikimedia.org/r/31080 [20:38:55] New patchset: Siebrand; "Add profiling for DB interaction and make methods non-static where possible" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27179 [20:40:24] New patchset: Jeroen De Dauw; "Updated readme and release notes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31100 [20:40:32] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31100 [20:42:16] 03(mod) User contributions feed does not display diffs - 10https://bugzilla.wikimedia.org/41085 +comment (10Andre Klapper) [20:42:35] siebrand: Thank you for your review, I have uploaded a new version [20:42:44] New review: Foxtrott; "@Matmarex: AFAIK IE might switch automatically to compatibility mode, e.g. because of none-standard ..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/30819 [20:42:50] is gerrit down? :( [20:43:05] alright, i guess it's back up now [20:43:05] New patchset: Adamw; "FU: send content-type to avoid warning" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/31115 [20:43:21] 03(mod) Moving pages (while leaving a redirect) does not work on wikidata.org - 10https://bugzilla.wikimedia.org/41574 +comment (10Antoine "hashar" Musso) [20:44:21] Change merged: Mwalker; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/31115 [20:44:24] New review: Daniel Kinzler; "assuming that we don't expect any explicit transaction to be open at that point, it seems fine." [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/31050 [20:44:45] 03(mod) Moving pages (while leaving a redirect) does not work on wikidata.org - 10https://bugzilla.wikimedia.org/41574 +comment (10Antoine "hashar" Musso) [20:44:47] could somebody review the changesets linked to from https://bugzilla.wikimedia.org/show_bug.cgi?id=41456 ? this bug messes up the cologneblue sidebar [20:45:42] New patchset: Matmarex; "CologneBlue rewrite: output the sidebar items as
    lists" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30359 [20:45:54] 03(mod) Localisation for special pages of extensions no longer working - 10https://bugzilla.wikimedia.org/41603 +code-update-regression (10Andre Klapper) [20:46:08] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31074 [20:46:50] 03(ASSIGNED) Moving pages (while leaving a redirect) does not work on wikidata.org - 10https://bugzilla.wikimedia.org/41574 +comment (10Daniel Kinzler) [20:47:05] New review: Matmarex; "Just reworded commit message. It seemed to be the only way to get gerrit to change the topic branch ..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/30359 [20:47:19] 03(mod) Moving pages (while leaving a redirect) does not work on wikidata.org - 10https://bugzilla.wikimedia.org/41574 (10Daniel Kinzler) [20:47:49] MatmaRex: oh no, a colognblue deciple! [20:48:01] can't we just get rid of the evil old skins? [20:48:29] DanielK_WMDE: apparently some people still use them :-D [20:48:37] DanielK_WMDE: though we might ask the community about removing them. [20:48:44] New patchset: Siebrand; "Localisation updates from http://translatewiki.net." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31117 [20:48:46] New review: Aaron Schulz; "Are any of these tables ones that will have many rows per user?" [mediawiki/extensions/AbuseFilter] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/30936 [20:49:27] New patchset: Siebrand; "Fix documentation and variable name" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/31041 [20:49:49] Change merged: Siebrand; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31117 [20:51:08] DanielK_WMDE: i just spent a few weeks recently making it not suck [20:51:26] but evil old skins i'd happily kill [20:51:43] nostalgia and standard badly need to go. [20:52:05] Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30937 [20:52:07] New patchset: Matmarex; "(bug 457) use semantic headings for the navigation menu" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30361 [20:52:29] DanielK_WMDE: in the meantime, you can look at this ^ for improvements to the good new skins :) [20:52:44] New patchset: Matmarex; "(bug 457) use semantic headings for the navigation menu" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30361 [20:52:44] 03(FIXED) It is possible to violate the label-description uniqueness constraint on items - 10https://bugzilla.wikimedia.org/41390 +comment (10Jeroen De Dauw) [20:53:11] New review: Matmarex; "PS4 was just to change the topic branch to bug/457 - for reasons unknown to me gerrit insisted that ..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/30361 [20:54:08] MatmaRex: i'm going to bed now, I have been at the office 10 hours [20:54:38] DanielK_WMDE: good night then :) [20:55:46] New patchset: Chughakshay16; "(bug 21119) link to toggle hidden categories" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/3981 [20:56:14] DanielK_WMDE: Good night, I follow you soon [20:56:38] anybody else willing to review some cologneblue fixups? i have three changesets pending, sone for almost a month... https://gerrit.wikimedia.org/r/#/q/topic:cologneblue-rewrite,n,z :) [20:56:50] one* [20:57:31] 03(mod) links to local files not working - 10https://bugzilla.wikimedia.org/41584 summary; +comment (10Andre Klapper) [20:59:48] MatmaRex: lemme check [21:00:19] New patchset: Katie Horn; "Making sure we add an antimessage on transactions we deliberately fail." [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/31120 [21:00:42] New patchset: Hoo man; "(bug 36053) Login returnto doesn't work if title isn't in the URI" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/29729 [21:00:50] New review: Alex Monk; "Obviously, it really depends on the users." [mediawiki/extensions/AbuseFilter] (master) C: 0; - https://gerrit.wikimedia.org/r/30936 [21:00:58] New review: Hoo man; "Rebased" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/29729 [21:01:01] New review: Pgehres; "seems fine" [mediawiki/extensions/DonationInterface] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/31120 [21:01:01] Change merged: Pgehres; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/31120 [21:02:06] thedj: with these three i'm basically done with the rewirte, all i want to do now is a) change the style to immediately outputting HTML like the other skins do instead of constructing strings in the submethod and returning them to be echoed later and b) run stylize.php and do assorted minor fixes [21:02:27] New patchset: Umherirrender; "Add missing resultproperties to list=deletedrevs" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31064 [21:04:04] New review: Hashar; "The method visibility in includes/CategoryViewer.php (from public to private) should be made in anot..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/27179 [21:04:27] MatmaRex: you know that the collection extension inserts li elements into your sidebar ? [21:06:06] thedj: i know now ;) [21:06:06] New patchset: Jeroen De Dauw; "Bump to version 0.2" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/31121 [21:06:16] Change merged: Jeroen De Dauw; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/31121 [21:06:35] thedj: when rewriting the function for the first time, i though that there could only be an array of links in the sidebar data, not raw HTML [21:06:44] it's not exactly documented anywhere [21:07:03] (well, now it is, because i documented it) [21:08:48] MatmaRex: yeah, i don't think it's actually really intentional :D [21:08:57] heh. [21:09:10] fun, fun, fun ~ [21:09:23] New review: Hoo man; "@Hashar: Might be better, yes" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/27179 [21:09:39] New patchset: Reedy; "Fix handling of prot-rel URLs in SiteObject." [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/31122 [21:09:44] 03(mod) RecentChanges 504 Gateway Time-out - 10https://bugzilla.wikimedia.org/41583 +comment (10Andre Klapper) [21:10:37] Change merged: Reedy; [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/31122 [21:12:21] MatmaRex: did you test addPortletLink ? [21:14:22] New patchset: Siebrand; "Localisation updates from http://translatewiki.net." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31123 [21:15:00] thedj: no, good point, i will in a minute [21:15:05] thedj: you can test this at http://users.v-lo.krakow.pl/~matmarex/testwiki/index.php?title=Main_Page [21:15:09] (my test wiki) [21:15:18] it's running the quickbar rewrite right now [21:16:45] thedj: alright, it doesn't exactly work, doesn't add the link to the list, but just at the end of #quickbar [21:16:52] hooray for special-casing [21:17:06] case 'cologneblue': [21:17:06] $( '#quickbar' ).append( $link.after( '
    ' ) ); [21:17:06] yay [21:17:14] working on a fix... [21:17:20] MatmaRex: i was already fearing something like that [21:18:30] New patchset: Jeroen De Dauw; "Disable phase 2 special pages and API module" [mediawiki/extensions/Wikibase] (0.2.x) - https://gerrit.wikimedia.org/r/31124 [21:19:43] thedj: the fix is trivial, just remove the case: and it works, but [21:20:01] New patchset: Jeroen De Dauw; "Bump to 0.2 beta" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31125 [21:20:02] cologneblue currently uses different ids for the sidebar parts [21:20:05] New review: Reedy; "Or, I guess, I mean, shouldn't this (optionally?) empty the sites table out first?" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/31065 [21:20:11] portlets* [21:20:13] which kinda sucks in this case [21:20:15] Change abandoned: Jeroen De Dauw; "(no reason)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31125 [21:20:40] New patchset: Jeroen De Dauw; "Bump to 0.2 beta" [mediawiki/extensions/Wikibase] (0.2.x) - https://gerrit.wikimedia.org/r/31126 [21:20:56] MatmaRex: this might not be a regression.. in which case i would also be fine with leaving it as is for now. [21:21:19] thedj: i'd say a lack of features [21:21:25] addPortletLink just works as it did before [21:21:33] (which is "barely") [21:21:50] but this should be fixed, of course [21:22:06] i'm just thinking how to do this "properly" [21:22:53] New patchset: Jeroen De Dauw; "Bump to 0.3 alpha" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31127 [21:24:30] thedj: alright, i have a plan, but i'd prefer to execute it as a new changeset, because otherwise i'll end up with rebase hell [21:26:10] New review: Nikerabbit; "It means that I didn't find any issues by reading the code, but I have not verified that it works as..." [mediawiki/extensions/PagedTiffHandler] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/30596 [21:28:17] Change merged: TheDJ; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30335 [21:28:52] New patchset: Krinkle; "Clean up: Fix trailing comments from I7e22cc3c" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31128 [21:29:29] hoo|away, Krenair, MatmaRex - do any of you ever use Windows? [21:29:40] speaking of long open changesets... if someone could review and merge my MathJax patches from 3-4 months ago :D [21:29:41] Sometimes, yeah. [21:30:02] sumanah: all the time [21:30:02] 03(mod) Thumbnails not displayed for local videos on test2wiki - 10https://bugzilla.wikimedia.org/41528 +comment (10Jan Gerber) [21:30:05] sumanah: i'm on Windows right now [21:30:23] thedj: you already asked Brion, right? [21:30:46] Krenair: MatmaRex - are either of you on XP? https://bugzilla.wikimedia.org/show_bug.cgi?id=24515 [21:31:07] I don't know whether that's reproducible. [21:31:40] I run Windows XP in a virtual machine to play a game sometimes [21:31:43] sumanah: yup. lookin [21:31:45] g [21:31:49] New patchset: Jeroen De Dauw; "Improved case insensitive lookup of terms" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30984 [21:31:54] sumanah: well not every week, but in the past, yes. [21:32:36] * sumanah looks at https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/Math,n,z [21:33:38] sumanah: i only have IE 6 from a package called MultipleIEs, and i'm not sure if all the quirks are reproducible on it, but i'll look [21:33:46] thanks MatmaRex [21:33:52] (or if it doesn't have its own ones) [21:34:01] MultipleIE and IETester are not reliable. [21:34:15] my system IE got updated to 8 [21:34:29] New patchset: Jeroen De Dauw; "Introduced Term interface and maintenance script to rebuild the term search keys" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31078 [21:34:34] New patchset: Aaron Schulz; "[JobQueue] Added "reduceContention" option to JobQueueDB." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31129 [21:34:37] Windows can't handle more than 1 IE on a Windows install any secondary install, let alone multiple ones, will be different than the real deal. [21:34:56] <^demon> Krinkle: I remember IETester. I used that to make my scores artificially high on TestSwarm until you said I shouldn't :p [21:34:57] ha [21:34:57] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/30984 [21:35:02] <^demon> I was sad, because I couldn't keep up with Brion anymore. [21:35:11] haha [21:35:16] that cross-browser testing site, what is it? we have a group login, last I recall [21:35:18] ^demon: http://swarm.jquery.org/scores [21:35:33] Use BrowserStack (my recommendation) or CrossBrowserTesting [21:35:38] WMF has accounts with both. [21:35:43] both donated iirc [21:35:55] Change abandoned: Jeroen De Dauw; "(no reason)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31078 [21:36:09] for CBT we have a shared login, for BrowserStack we have individual accounts [21:36:14] sumanah, fyi I've been given +2 on a bunch of editor engagement extensions [21:36:24] congrats Krenair [21:36:28] New patchset: Jeroen De Dauw; "Revert "Improved case insensitive lookup of terms"" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31130 [21:36:29] <^demon> "[Announce] Gerrit 2.5 final" [21:36:30] <^demon> \o/ [21:36:32] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31130 [21:36:38] <^demon> Too bad LDAP's still broken beyond use :( [21:36:40] ^demon: does it include that LDAP thing we need? [21:36:42] :( [21:36:44] ^demon: And yes, in case you noticed (or didn't notice, actually) the scores page is now performant again. It used to time out. [21:36:52] sumanah: it appears like i can't even load the bugzilla page with my IE6 :P [21:36:54] they released 2.5 with broken ldap? [21:36:54] whoa' [21:36:58] Turns out all it needed was a mysql index and a slightly different query. [21:37:06] that's incredibly lame [21:37:20] Krenair: well I know what your CR time might be going towards :) [21:37:20] <^demon> Ryan_Lane: Yes. Still no upstream fix for it (I've been trying to fix it in my spare time, but it's not easy :() [21:37:21] New patchset: Jeroen De Dauw; "* Improved case insensitive lookup of terms * Introduced Term interface * Added maintenance script to rebuild the term search keys" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31131 [21:37:28] New patchset: Jeroen De Dauw; "* Improved case insensitive lookup of terms * Introduced Term interface * Added maintenance script to rebuild the term search keys" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31131 [21:37:34] <^demon> Since 2.5 came out without it, we'll have to do a custom 2.5 build to include it. [21:37:38] that's bullshit [21:37:38] Though no IE6-8 and less feature rich, there is also a free alternative: https://browserling.com/ [21:37:54] New review: Jeroen De Dauw; "Reviewed and verified by John" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/31131 [21:37:55] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31131 [21:38:09] <^demon> Ryan_Lane: I've been prodding constantly. Hard part is doing it in a way that causes Google no downtime. [21:38:16] <^demon> :( [21:38:16] somewhat unstable though, sometimes you see the browser of another user on your screen :P [21:38:16] sumanah: alright, i did it. i can confirm that the second testcase scales up much faster than the other two. [21:38:32] sumanah: I have IE7 in a VM on my personal machine, want me to check out some font sizes there? [21:38:32] New review: John Erling Blad; "Whaaaat!! :D" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31131 [21:39:02] it's not hella urgent [21:39:20] I can test it as well, I just thought you had got someone else to do it [21:39:26] 03(mod) IE Font Sizing Bug - 10https://bugzilla.wikimedia.org/24515 +comment (10Bartosz Dziewoński) [21:39:44] <^demon> Ryan_Lane: Good news though, gitblit & network graph plugins got merged to their respective masters this week. So we'll be able to use those as soon as we upgrade. [21:40:10] cool [21:40:22] yay re gitblit [21:40:36] what's a good "ooh ahh" demo instance of gitblit for me to browser? [21:40:39] browse* [21:41:25] <^demon> https://demo-gitblit.rhcloud.com/ [21:41:34] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (0.1.x) - https://gerrit.wikimedia.org/r/31081 [21:42:48] Change merged: Nikerabbit; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/30614 [21:43:55] 03(mod) untranslated search placeholder - 10https://bugzilla.wikimedia.org/41600 normal->minor; +comment (10Niklas Laxström) [21:46:40] sumanah: Yes, I use Windows from time to time... and almost always on my small netbook, as it's not really stable on Linux :/ Why? [21:48:34] New review: John Erling Blad; "There was 1 error:" [mediawiki/extensions/Wikibase] (0.2.x); V: 0 C: -1; - https://gerrit.wikimedia.org/r/31124 [21:50:38] hoo: no prob, I was just looking for someone to try to repro a bug, and it's now done [21:51:10] New review: Lupo; "Using https://commons.wikimedia.org/wiki/File:Tochon_d%27Annecy.tiff as test file. Uploading works n..." [mediawiki/extensions/PagedTiffHandler] (master) C: -1; - https://gerrit.wikimedia.org/r/30621 [21:52:02] Krinkle: About the missing user.tokens key, any suggestions what I should do? Just disable to module if it's not present or gather the token from the API (which will add more complexity which I wanted to avoid)? [21:52:04] New patchset: Siebrand; "Update parts order in message files" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31134 [21:52:38] hoo: the former, just return early if it doesn't exist (as if the module hasn't loaded at all) [21:52:45] I had a look at that IE bug, unfortunately I've got IE8 [21:52:58] Krinkle: Ok, that's easy :) [21:53:58] Or fortunately, depending on how you view it [21:54:21] New review: Siebrand; "21:02:27 CONFLICT (content): Merge conflict in RELEASE-NOTES-1.21" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/31067 [21:54:36] New patchset: Matmarex; "make addPortletLink work with CologneBlue" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31135 [21:54:41] thedj: ^ [21:55:03] thedj: (i didn't yet test that this code actually works, will do in a minute) [21:55:31] New review: TheDJ; "I think this is missing the new action page information link right ?" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26898 [21:55:47] New review: John Erling Blad; "Spurious error it seems." [mediawiki/extensions/Wikibase] (0.2.x); V: 1 C: 2; - https://gerrit.wikimedia.org/r/31124 [21:55:47] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (0.2.x) - https://gerrit.wikimedia.org/r/31124 [21:56:06] thedj: ah, you do know that were were two quickbar-related changesets? this is the second: https://gerrit.wikimedia.org/r/#/c/30359/ and it badly wants merging, too ;) [21:56:14] New patchset: Hoo man; "(bug 7851) Added AJAX patrolling (mediawiki.page.patrol.ajax)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26440 [21:56:56] New review: Hoo man; "Handle the case that mw.user.tokens.get( 'patrolToken' ) isn't (yet) available" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/26440 [21:57:08] New review: Matmarex; "Hm, yes it is, but the link in present in the toolbar. Do you think I should add it here?" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/26898 [21:57:15] thedj: ^ [21:57:54] MatmaRex: i'll get onto that one in a sec. [21:58:27] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (0.2.x) - https://gerrit.wikimedia.org/r/31126 [21:59:51] thedj: sure, thanks [22:00:52] MatmaRex: regarding the bottomlinks. is there a precendent of discrepencies with regard to page actions in toolbox vs bottomlinks ? then i would be fine with it, otherwise i think we should add it to bottomlinks. [22:02:47] thedj: i have absolutely no idea. my aim in that commit was not to break anything while removing the cruft :) [22:03:44] i think they are intended to be the most important ones [22:04:25] or maybe just all the ones that were available at the time ;) [22:05:39] i think 'all that are specific to this page' [22:06:10] but we can do it separately [22:06:17] i think i'll go ahead and add it in this commit [22:06:32] Is jenkins hanging again? :/ [22:06:48] i'll add it after "Page history" [22:07:03] hoo: we are all working too hard. the butler is calling it quits :D [22:07:16] HA [22:07:41] :D [22:09:26] New patchset: Matmarex; "CologneBlue rewrite: rewrite bottomLinks()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26898 [22:10:00] whoops [22:10:03] i forgot the files [22:10:14] New patchset: Matmarex; "CologneBlue rewrite: rewrite bottomLinks()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26898 [22:10:15] there. [22:10:16] thedj: ^ [22:10:47] 03(mod) PagedTiffHandler assumes one-based page numbers; doesn't work with ImageMagick 6.7.7-2 which returns zero-based page numbers - 10https://bugzilla.wikimedia.org/37692 +comment (10Lupo) [22:11:37] New patchset: Nikerabbit; "Get rid of lots of deprecated code" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/31136 [22:11:54] 03(mod) Localisation for special pages of extensions no longer working - 10https://bugzilla.wikimedia.org/41603 +comment (10Niklas Laxström) [22:14:26] New review: Nikerabbit; "Tested all modules of Special:Magic, exporting not tested." [mediawiki/extensions/Translate] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/31136 [22:18:32] New patchset: Robmoen; "Base for inspectors & context menu to operate on 0 length selection." [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/31137 [22:18:49] New review: TheDJ; "one more issue with xhtml vs html5." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26898 [22:19:07] New review: Matmarex; "Krinkle: replied inline." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/30359 [22:19:27] New patchset: Matmarex; "CologneBlue rewrite: output the sidebar items as
      lists" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30359 [22:19:32] 14(WFM) mediawiki.legacy.mwsuggest shouldn't be loaded if ext.vector.simpleSearch is loaded - 10https://bugzilla.wikimedia.org/23985 +comment (10Krinkle) [22:20:29] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/31127 [22:21:37] Krinkle: btw. i had seen it in the past, but also again this week. a RL result, that was simply missing an entire module of CSS. This happens rarely, but happens. [22:21:45] New patchset: Mwalker; "More intelligent banner caching for CN" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/31048 [22:21:59] thedj: locally? [22:22:03] no en.wp [22:22:16] New review: Matmarex; "TheDJ: replied inline." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/26898 [22:22:21] thedj: ^ "This seems to be completely unimportant and is consistent with the rest of the file. I'll fix minor issues like this later in one sweep, together with stylize.php and assorted coding conventions fixes." [22:22:41] thedj: Was it an observation below or in the front? in other words, could it be that it was loaded in a different way that you just didn't see? [22:22:48] Or was it visibly missing in the interface. [22:22:56] (i.e. unstyled components) [22:23:19] Krinkle: it was the vector site css module. [22:23:44] all the modules were there, just the vector css was missing from the output. [22:23:53] was the tag there? [22:24:01] the response empty? [22:24:26] no the response was there. it just missed one of the css modules in the bundle [22:24:51] New patchset: Aaron Schulz; "Fixed nextJobDB.php to handle recent job queue changes." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31138 [22:24:51] we have also seen it with diff css or history css modules I think, missing at random. [22:24:58] Reedy: ^ [22:25:24] * MatmaRex thinks that gerrit-wm should ping the changeset owner when posting a notification to IRC. [22:25:38] 03(NEW) MediaWiki core tests are slower since Precise upgrade - 10https://bugzilla.wikimedia.org/41607 major; Wikimedia: Testing Infrastructure; (hashar) [22:26:46] 03(mod) MediaWiki core tests are slower since Precise upgrade - 10https://bugzilla.wikimedia.org/41607 +performance (10Krinkle) [22:26:55] Krinkle: it's like one of the module post process tasks fails, times out whatever, and that it skips it and serves the modules that did succeed. [22:27:22] 03(mod) Language objects should only load messages when needed - 10https://bugzilla.wikimedia.org/41596 +comment (10Siebrand) [22:27:28] thedj: what do you mean by bundle? skin css isn't loaded through mw.loader but via a hard tag [22:27:36] was the tag there? [22:27:39] yes [22:27:46] but the reponse was empty? [22:27:51] 03(mod) MediaWiki core tests are slower since Precise upgrade - 10https://bugzilla.wikimedia.org/41607 +comment (10Antoine "hashar" Musso) [22:28:10] New review: Aaron Schulz; "I see all these tables have user id and user text. Please use the UserCache class and do batch looku..." [mediawiki/extensions/AbuseFilter] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/30936 [22:30:27] New patchset: Parent5446; "(bug 38417) Changed edit token construction and checking" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21986 [22:31:23] New patchset: Lupo; "(bug 41146) Make mb_string optional in DatabaseOracle" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31141 [22:31:40] 03(mod) IME feature should be disabled by default - 10https://bugzilla.wikimedia.org/41542 +comment (10Siebrand) [22:32:12] New review: Platonides; "Other than the "fewer than" change, I don't think the others really need changes. Do you see somethi..." [mediawiki/extensions/ConfirmEdit] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/16869 [22:32:32] New review: Matmarex; "Krinkle: replied inline." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/26898 [22:32:32] Change merged: Reedy; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31138 [22:32:48] New patchset: Matmarex; "CologneBlue rewrite: rewrite bottomLinks()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/26898 [22:33:28] New review: Adamw; "Just let me know if you want to bother with my criticisms." [mediawiki/extensions/CentralNotice] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/31048 [22:34:07] 03(mod) MediaWiki core tests are slower since Precise upgrade - 10https://bugzilla.wikimedia.org/41607 +comment (10Antoine "hashar" Musso) [22:34:14] New patchset: Reedy; "Fixed nextJobDB.php to handle recent job queue changes." [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/31142 [22:35:02] MatmaRex: hmm, i see thumbnails with white borders.. I thought I fixed all those a couple of years ago. [22:35:22] must have missed one skin. [22:35:24] 03(mod) Fatal installer error using Oracle DB (HTTP 500 error): undefined function mb_check_encoding() - 10https://bugzilla.wikimedia.org/41146 +patch-in-gerrit; +comment (10Lupo) [22:35:31] 03(mod) Error creating thumbnail: oggThumb failed to create the thumbnail. - 10https://bugzilla.wikimedia.org/41376 +comment (10Jan Gerber) [22:35:36] Change merged: Reedy; [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/31142 [22:35:53] thedj: hm? where? i don't understand [22:38:39] MatmaRex: div.thumb -> border-color: white. used to create a 'fake' margin. [22:41:44] hi valhallasw! how are you? [22:42:23] Change merged: TheDJ; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30359 [22:42:59] 03(mod) MediaWiki core tests are slower since Precise upgrade - 10https://bugzilla.wikimedia.org/41607 +comment (10Antoine "hashar" Musso) [22:43:40] thedj: ah. [22:43:49] oh, thanks for the merge! :) [22:44:58] 03(NEW) List change author in gerrit mails - 10https://bugzilla.wikimedia.org/41608 normal; Wikimedia: General/Unknown; (Platonides) [22:46:16] New patchset: Jeroen De Dauw; "Implemented monolingaul dv in JS and added tests" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/31143 [22:46:27] !b 36839 [22:46:28] https://bugzilla.wikimedia.org/show_bug.cgi?id=36839 [22:47:35] 03(FIXED) coll-print_export sidebar section borked on CologneBlue - 10https://bugzilla.wikimedia.org/41456 +comment (10Bartosz Dziewoński) [22:51:06] 03(mod) Watch list icon doesn't update on subsequent page load - 10https://bugzilla.wikimedia.org/41604 +comment (10Jon) [22:53:52] 03(mod) Adding project identification variable to AbuseFilter - 10https://bugzilla.wikimedia.org/41172 +comment (10Jasper Deng) [22:59:36] New patchset: Aaron Schulz; "[JobQueue] Added "avoidDeadlocks" option to JobQueueDB." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31129 [23:01:00] New patchset: Hoo man; "Clean up and restructed the AbuseFilter JS" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/30110 [23:03:59] andre__: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#.22Wkimedia_Foundation_error.22_--_what_to_do.3F can you respond? [23:04:38] sumanah & co, here is the draft of the first monthly community metrics report: http://www.mediawiki.org/wiki/User:Qgil/MediaWiki_Community_Metrics/Metrics_Report_2012-11-01 [23:05:05] Planning to send an email to Wikitech this evening [23:05:11] I AM LOOKING GREEDILY AT THIS DATA QUIM, THANK YOU SUPERLATIVELY [23:05:21] wow :) [23:05:33] qgil: do you want nitpicking now? :) [23:05:38] why not [23:06:01] I know that thedj, Ori, Tychay, and ankur are NOT new contributors as of last month [23:06:01] * Lydia_WMDE waves @ sumanah qgil and andre__ [23:06:08] Lydia_WMDE: wave back! [23:06:10] Lydia_WMDE, hi! :) [23:06:44] sumanah, may be two things: either they don [23:07:13] "But you probably don't need to send a rocket to Saturn with this data anyway." I am laughing - thank you for that. [23:07:21] either they don't keep discipline in their git email/name/else, or it's the first time they send a commit to that project [23:07:46] what does "Recovering" mean (Wikibase repo description)? [23:08:08] sumanah, they had higher levels of contribution, then went down, now go up again [23:08:11] ah [23:08:24] "recovering" makes it sound like it was addicted to something [23:08:30] (to me) [23:08:43] sumanah, I need to consolidate those labels. I might end up using a simple traffic light color code. It's just to give a hint on progress [23:09:04] 03(mod) Meta-Wiki mobile site has errant trademark symbol (™) in footer - 10https://bugzilla.wikimedia.org/41141 +comment (10Arthur Richards) [23:09:05] sumanah, maybe you should do/watch less drugs and more sports? :D [23:09:27] or maybe it's me non-native speaker. Probably the later [23:10:16] Hi, I am doing Tab in mediawiki. I was able add a tab, the problem is I don't know how to show text I created in main area. Now if user clicks to the tab then I made that he will be rediredcted to completely different page. I want that only main text are will be changed. As I understand now, it should be done throug title->getLocalURL, but I dont know where I can specify my action. [23:10:28] I'm not sure what it needs to recover from= [23:10:38] did it have a commit drop ? [23:10:58] sumanah, Platonides http://en.wiktionary.org/wiki/recover :) Find an alternative if you don't like that verb and I'll add it [23:11:25] "rising" or "restabilizing" [23:11:43] sumanah, about the non-new contributors, highlighting them might help those developers sorting out their contributions in Ohloh and being more disciplined in Git [23:11:46] * sumanah doesn't mean to bikeshed too much [23:12:06] qgil: but I don't want to nag those people about this fairly unimportant thing [23:12:48] is it nagging? Anyway, I'll look at these case later today and I will edit accordingly [23:13:10] Understandable disagreement here [23:13:20] I am about to be abducted to dinner [23:13:35] sumanah, same here with picking kids at school :) [23:13:46] sumanah, thanks for flash feedback! [23:14:28] :D [23:14:28] thanks for doing this qgil [23:14:45] New patchset: Reedy; "(Bug 41594) Create option to disable wb_changes table" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/31148 [23:14:50] I will be a magical Miranda Zero/Aleph/Morpheus/other scifi character with this data [23:16:20] New patchset: Reedy; "Point .gitreview at the correct branch" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/31149 [23:16:23] sumanah, looking forward to consolidate this data and add new in the next reports [23:16:43] qgil, I don't see the name as being bad [23:16:51] Change merged: Reedy; [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/31148 [23:16:55] Change merged: Reedy; [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/31149 [23:16:57] but for recovering, it should have performed bad first IMHO [23:17:18] thedj, do you have any idea why you apear as new contributor at https://www.ohloh.net/p/mediawiki/contributors/96637305558 & https://www.ohloh.net/p/mediawiki-extensions-wmf/contributors/2630287364735702 ? Did you change email in your git commits or is it indeed the first time you contributed for those specific projects? [23:18:34] * sumanah needs to flee to eeeat [23:19:28] bon appetit! [23:21:03] New patchset: Reedy; "Update branch" [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/31150 [23:21:07] qgil: hmm, all merges ? i received gerrit +2 rights recently... perhaps that's it. [23:21:59] Change merged: Reedy; [mediawiki/core] (wmf/1.21wmf3) - https://gerrit.wikimedia.org/r/31150 [23:22:26] I don't think it should be counting merge commits.. [23:23:32] <^demon|brb> If you've got multiple e-mail addresses in Gerrit (I have 3), Ohloh will treat them as different users unless you've registered them all with Ohloh. [23:23:43] New review: Platonides; "After this change, PreferencesTest.php suddenly needs a DB when run with other tests (not needed sta..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/29972 [23:23:51] thedj, Krenair you can see the specific commits counted at the bottom of those URLs [23:24:11] thedj, Krenair eg https://www.ohloh.net/p/mediawiki-extensions-wmf/commits/223381107 [23:24:15] New patchset: Reedy; "Update Wikidata revision" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/31151 [23:25:10] thedj, in any case I wonde why it appears as 'new contributor' if you had before commits done from the same email address [23:25:29] qgil: they are all merges from gerrit to master it seems. that is what distinguishes them [23:25:47] i probably have a different main email in gerrit then I have in git pushes. [23:27:38] thedj, yes [23:27:42] thedj, Krenair ^demon|brb ok, we may get some data distortion due to this but it will stabilize as the core devs get their +2 and people (optionally) sort out their data in Ohloh [23:28:03] in merges you have the gmail account, while in others the videolan one [23:28:03] thedj, I will remove you from the new in the monthly report [23:28:18] qgil: check [23:28:47] New patchset: Mwalker; "Adding CTID to Session Velocity Filter output" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/31152 [23:29:04] <^demon|brb> qgil: It doesn't have anything to do with +2, but with which e-mails you commit with vs. use as your primary contact address in gerrit (they can differ) [23:29:06] New patchset: Kaldari; "Echo: Add "reverted" notification for when a user's edit is reverted." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/15959 [23:29:14] New review: Hoo man; "I've checked it out and it worked well, only very minor stylish things left AFAIS now (see comments)." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/3981 [23:29:14] <^demon|brb> Solution is the same: register both in ohloh :) [23:29:28] ^demon|brb, good to know, thanks [23:29:44] New patchset: Matmarex; "make addPortletLink work with CologneBlue" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31135 [23:31:06] thedj: you might want to see this ^ :) [23:32:06] i don't have time to review now. jumping into bed. [23:32:50] sure. just wanted you to know there's a fix [23:32:58] good night [23:33:12] New review: Tychay; "Again!" [mediawiki/core] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/30552 [23:33:12] New patchset: Mwalker; "More intelligent banner caching for CN" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/31048 [23:33:12] Change merged: Tychay; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30552 [23:33:40] New patchset: Matmarex; "make addPortletLink work with CologneBlue" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31135 [23:34:22] New patchset: Matmarex; "make addPortletLink work with CologneBlue" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31135 [23:38:57] 03(NEW) Exception: User::addToDatabase: hit a key conflict attempting to insert a user row, but then it doesn't exist when we select it! - 10https://bugzilla.wikimedia.org/41609 major; MediaWiki extensions: CentralAuth; (krinklemail) [23:38:58] 03(mod) Code quality issues (and other stuff that sucks) (tracking) - 10https://bugzilla.wikimedia.org/700 (10Krinkle) [23:41:47] 14(WFM) Tool bar : IE7 shows the link add UI differently - 10https://bugzilla.wikimedia.org/23064 +comment (10Krinkle) [23:42:23] 03(mod) Tool bar : IE7 shows the link add UI differently - 10https://bugzilla.wikimedia.org/23064 (10Krinkle) [23:45:54] 03(mod) Show "Page information" toolbox link to info action also in history etc. - 10https://bugzilla.wikimedia.org/41582 +comment (10MZMcBride) [23:46:22] 03(mod) Create NavigationPopups extension - 10https://bugzilla.wikimedia.org/503 +comment (10Krinkle) [23:46:48] New patchset: Kaldari; "Echo: Add "reverted" notification for when a user's edit is reverted." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/15959 [23:49:58] New review: Tim Starling; "I don't think the ustring functions should be present in the sandbox unconditionally, since apart fr..." [mediawiki/php/luasandbox] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/27921 [23:50:27] 03(mod) Dialogs: Search and Replace : Suggesting to add "Match Word" option - 10https://bugzilla.wikimedia.org/22478 (10Bartosz Dziewoński) [23:50:27] 03(mod) Search Suggest bugs (tracking) - 10https://bugzilla.wikimedia.org/27411 (10Bartosz Dziewoński) [23:53:25] New review: Tim Starling; "The upstream bug report needs to be referenced from a comment in the implementation. If there isn't ..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/30994 [23:55:03] New patchset: Kaldari; "Echo: Add "reverted" notification for when a user's edit is reverted." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/15959 [23:58:24] New patchset: Matmarex; "(bug 457) use semantic headings for the navigation menu" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30361