[00:00:48] Change merged: Pgehres; [mediawiki/core] (wmf/1.21wmf6) - https://gerrit.wikimedia.org/r/37966 [00:01:02] New review: Tychay; "At this point, since the commit cannot go live without our approval and there is nothing "wikipedia ..." [mediawiki/extensions/GuidedTour] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/35399 [00:06:02] New patchset: Jforrester; "Alter messages to pull in the links for messages from other messages" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37971 [00:06:32] New patchset: Ori.livneh; "Bug 35866 - ParserFunctions: Division by zero in Expr.php" [mediawiki/extensions/ParserFunctions] (master) - https://gerrit.wikimedia.org/r/37368 [00:08:20] 03(mod) Add all extensions used by WMF to Jenkins - 10https://bugzilla.wikimedia.org/34617 +comment (10Merlijn van Deen) [00:08:55] ^ Reedy [00:12:17] ori-l: so it's wrong? [00:12:27] Or left [00:12:28] it's actually still wrong [00:12:37] ori-l fail [00:13:40] Reedy: if ( (float)$right === 0 ) will still cause errors to be thrown [00:13:41] 03(mod) Assign upload_by_url right to the image-reviewer group on commonswiki - 10https://bugzilla.wikimedia.org/42921 +comment (10Dereckson) [00:13:46] because the modulo operator casts to int [00:13:51] 03(mod) Assign upload_by_url right to the image-reviewer group on commonswiki - 10https://bugzilla.wikimedia.org/42921 +patch-in-gerrit +shell (10Dereckson) [00:13:58] !right == wrong [00:13:58] There are multiple keys, refine your input: rights, rightssql, [00:14:01] !right == left [00:14:01] There are multiple keys, refine your input: rights, rightssql, [00:14:08] shush wm-bot [00:14:11] Reedy: so if $right = 0.02, (float) $right != 0 [00:14:38] but 5 % 0.02 will throw a division by zero error. [00:14:52] so the check on 426 should actually cast to int [00:15:46] i'm not sure if this points to a bigger bug (people thinking parserfunction's modulo operator works on floating point values when it doesn't) [00:15:52] New review: Siebrand; "Weird fail. Probably because of a Jenkins issue." [mediawiki/extensions/Translate] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/37976 [00:19:09] New patchset: Katie Horn; "Quick fix to account for the fact that we have no "down for maintainence" page, and a maintenance window in a minute." [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/37982 [00:20:02] Change merged: Pgehres; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/37982 [00:20:57] Reedy: heh http://www.mediawiki.org/wiki/Help:Extension:ParserFunctions "The operator mod gives wrong results for some values of the second argument" [00:22:05] L2MATH [00:22:07] Change merged: Mwalker; [wikimedia/fundraising/tools] (master) - https://gerrit.wikimedia.org/r/37392 [00:24:07] New patchset: Siebrand; "Address type incompatibility warnings" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/37976 [00:24:57] Reedy: ? [00:25:05] i am not hip to your memes [00:25:40] lol [00:25:45] don't worry about it [00:25:49] GIGO [00:26:09] New patchset: Trevor Parscal; "Adjustments and fixes for styles" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37983 [00:26:13] New review: Ori.livneh; "The modulo operator is more broken than initially supposed (it uses PHP's modulo operator, which cas..." [mediawiki/extensions/ParserFunctions] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/37368 [00:26:32] New review: Siebrand; "Overriding Jenkins." [mediawiki/extensions/Translate] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/37836 [00:26:33] Change merged: Siebrand; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/37836 [00:27:43] New review: Siebrand; "Overriding Jenkins." [mediawiki/extensions/Translate] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/37976 [00:27:43] Change merged: Siebrand; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/37976 [00:37:53] New patchset: Inez; "(bug 42925) Inspector doesn't open properly" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37945 [00:38:03] 03(mod) Parsoid: Does not insert a necessary between and - 10https://bugzilla.wikimedia.org/37846 +patch-in-gerrit; +comment (10Gabriel Wicke) [00:38:12] New review: Christian; "Trying to make Jenkins re-run." [mediawiki/extensions/VisualEditor] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/37592 [00:39:40] New patchset: Robmoen; "Throw edit warning on cancel." [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37948 [00:39:47] New review: Trevor Parscal; "recheck" [mediawiki/extensions/VisualEditor] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/37945 [00:41:09] New patchset: Adamw; "banner screenshot url in results" [wikimedia/fundraising/tools] (master) - https://gerrit.wikimedia.org/r/37986 [00:45:47] New patchset: Trevor Parscal; "Fix tests for bug 42806 patch" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37987 [00:46:11] New patchset: Aaron Schulz; "Added UIDGenerator class for getting statistically unique IDs." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/37052 [00:46:36] New review: Inez; "Attempt to re-merge." [mediawiki/extensions/VisualEditor] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/37945 [00:48:21] New patchset: Inez; "(bug 42925) Inspector doesn't open properly" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37945 [00:48:41] New review: Inez; "Attempt to re-merge (after re-basing)." [mediawiki/extensions/VisualEditor] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/37945 [00:49:30] 03(mod) A strict and correct Git workflow document is needed - 10https://bugzilla.wikimedia.org/36437 (10d_entous) [00:50:06] New patchset: Krinkle; "Throw edit warning on cancel." [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37948 [00:50:31] New patchset: Kaldari; "More formatting work on the overlay and base files" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/37789 [00:50:45] New review: Krinkle; "+2 per Inez. Trying again jenkins." [mediawiki/extensions/VisualEditor] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/37945 [00:52:22] New patchset: Ori.livneh; "Bug 35866 - ParserFunctions: Division by zero in Expr.php" [mediawiki/extensions/ParserFunctions] (master) - https://gerrit.wikimedia.org/r/37368 [00:52:44] New review: Krinkle; "One more time, should be fixed now." [mediawiki/extensions/VisualEditor] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/37945 [00:52:55] Change merged: jenkins-bot; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37945 [00:53:05] Reedy: ^ :) [00:54:46] ori-l: Add some more to the phpunit tests too? ;) [00:55:03] Reedy: sure. it also fixes {{#expr: 123 mod (2^64-1)}} [00:55:20] New patchset: Bsitu; "Initial check-in for email batch" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/35342 [00:55:28] (the example given in the extension's docs demonstrating mod being broken) [00:56:06] New review: Jforrester; "recheck" [mediawiki/extensions/VisualEditor] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/37592 [00:56:47] New review: Bsitu; "No change in this patch set, just rebased it, :)" [mediawiki/extensions/Echo] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/35342 [00:57:03] New review: Jforrester; "recheck" [mediawiki/extensions/VisualEditor] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/37971 [00:57:06] New review: Reedy; " Reedy: sure. it also fixes {{#expr: 123 mod (2^64-1)}}" [mediawiki/extensions/ParserFunctions] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/37368 [00:57:07] New review: Jforrester; "recheck" [mediawiki/extensions/VisualEditor] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/37987 [00:57:09] 03(mod) Parsoid: Does not insert a necessary between and - 10https://bugzilla.wikimedia.org/37846 (10Gabriel Wicke) [00:58:08] Suddenly, everybody at the office disconnected. [01:01:51] New patchset: CSteipp; "(bug 42814) Fix AbuseLog API permissions" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/37989 [01:01:55] New patchset: Ori.livneh; "Bug 35866 - ParserFunctions: Division by zero in Expr.php" [mediawiki/extensions/ParserFunctions] (master) - https://gerrit.wikimedia.org/r/37368 [01:02:16] Reedy: ^ [01:02:25] New review: Jforrester; "Re-triggering V+1 from Jenkins, hopefully." [mediawiki/extensions/VisualEditor] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/37971 [01:02:41] 03(mod) Abusefilter API does not check for abusefilter-view-private userright - 10https://bugzilla.wikimedia.org/42814 +comment (10Chris Steipp) [01:02:42] Change merged: jenkins-bot; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37971 [01:02:44] yay [01:02:54] 03(mod) Raw $PAGEINTRO in email notifications - 10https://bugzilla.wikimedia.org/42752 +comment (10Aaron Schulz) [01:02:58] New review: Jforrester; "Re-triggering V+1 from Jenkins, hopefully." [mediawiki/extensions/VisualEditor] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/37592 [01:03:09] Change merged: jenkins-bot; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37592 [01:03:39] New review: Jforrester; "Re-triggering V+1 from Jenkins, hopefully." [mediawiki/extensions/VisualEditor] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/37987 [01:03:53] Change merged: jenkins-bot; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37987 [01:06:38] 03(mod) Raw $PAGEINTRO in email notifications - 10https://bugzilla.wikimedia.org/42752 +comment (10Aaron Schulz) [01:07:22] New patchset: Ori.livneh; "Bug 35866 - ParserFunctions: Division by zero in Expr.php" [mediawiki/extensions/ParserFunctions] (master) - https://gerrit.wikimedia.org/r/37368 [01:08:23] Reedy: the test case added to funcsParserTests.txt didn't really belong there; the phpunit addition is where it ought to go. eighth time's a charm. [01:08:40] love you long time [01:09:05] (long) time [01:09:25] We should bump the minor version number [01:09:27] bad Reedy [01:09:38] 1.4.1 -> 1.4.2 or something [01:09:43] or even 1.5 [01:09:52] 2.0! [01:09:56] just like the web. [01:10:14] also parserfunction's versioning scheme doesn't handle floating-point values [01:10:31] New patchset: Siebrand; "Update docs and type hints." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/37992 [01:11:38] New review: Krinkle; "not tested, but a few minor issues." [mediawiki/extensions/VisualEditor] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/37983 [01:12:00] New patchset: Reedy; "Bug 35866 - ParserFunctions: Division by zero in Expr.php" [mediawiki/extensions/ParserFunctions] (master) - https://gerrit.wikimedia.org/r/37368 [01:12:02] Change merged: Kaldari; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/37360 [01:12:50] New patchset: Siebrand; "Update docs and type hints." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/37992 [01:13:45] 03(mod) Raw $PAGEINTRO in email notifications - 10https://bugzilla.wikimedia.org/42752 +comment (10Richard Guk) [01:17:09] New review: Siebrand; "Overriding Jenkins." [mediawiki/extensions/Translate] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/37992 [01:17:09] Change merged: Siebrand; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/37992 [01:22:44] preilly: 039415ae2aa5c73513697cb0341c3c5e7d9840cf [01:26:11] 03(NEW) VisualEditor: While using link inspector, transaction hangs and page eventually explodes. - 10https://bugzilla.wikimedia.org/42935 normal; VisualEditor: General; () [01:26:51] 03(mod) VisualEditor: Inspector doesn't open properly - 10https://bugzilla.wikimedia.org/42925 (10Rob Moen) [01:40:47] 03(NEW) VisualEditor: Integration in production should not ignoreHidden on user preference - 10https://bugzilla.wikimedia.org/42936 normal; VisualEditor: Technical Debt; () [01:44:08] 03(mod) Parsoid: Escape plaintext three-tildes ~~~ are expanded to signature unexpectedly - 10https://bugzilla.wikimedia.org/37841 +patch-in-gerrit; +comment (10Gabriel Wicke) [01:44:31] New patchset: Robmoen; "Prevent Inspector frame from reloading on close." [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37997 [01:44:45] New patchset: Trevor Parscal; "(bug 42920) Add the feedback tool" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37998 [01:45:52] 03(mod) Investigate crash in serializer - 10https://bugzilla.wikimedia.org/41119 +comment (10Gabriel Wicke) [01:47:25] 03(mod) A single get escaped in round-trip - 10https://bugzilla.wikimedia.org/41228 +comment (10Gabriel Wicke) [01:48:25] New patchset: Jforrester; "Create first VE Technical Debt bug entry for tracking, resolution" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37999 [01:48:28] 03(mod) Recognize interwiki and language links - 10https://bugzilla.wikimedia.org/42160 +comment (10Gabriel Wicke) [01:49:29] 03(mod) Parsoid: Escape plaintext three-tildes ~~~ are expanded to signature unexpectedly - 10https://bugzilla.wikimedia.org/37841 (10Gabriel Wicke) [01:50:41] New patchset: Demon; "Undoing more of my branching mistake, delete submodules from master" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/38000 [01:52:52] 03(mod) A strict and correct Git workflow document is needed - 10https://bugzilla.wikimedia.org/36437 (10d_entous) [01:53:01] New patchset: Kaldari; "More formatting work on the overlay and base files" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/37789 [01:53:23] 03(mod) A strict and correct Git workflow document is needed - 10https://bugzilla.wikimedia.org/36437 (10d_entous) [01:54:15] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/38000 [01:55:50] Change merged: Kaldari; [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/37961 [01:56:59] New patchset: Demon; "Revert "Commit of various live hacks"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/38001 [01:57:57] New review: Kaldari; "For some reason, when those icons are compressed with pngcrush, it makes them uneditable for me in P..." [mediawiki/extensions/Echo] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/36941 [01:58:02] New patchset: Demon; "Revert "Applied patches to new WMF 1.21wmf6 branch"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/38002 [02:00:28] New patchset: Demon; "Deleting one last extension I left in master" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/38003 [02:01:00] 03(mod) A strict and correct Git workflow document is needed - 10https://bugzilla.wikimedia.org/36437 +comment (10dan) [02:01:15] New patchset: Trevor Parscal; "Add recursion guard back in" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/38004 [02:02:27] New patchset: Kaldari; "More formatting work on the overlay and base files" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/37789 [02:02:57] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/38001 [02:03:28] Change merged: jenkins-bot; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/38004 [02:03:48] 03(mod) VisualEditor: While using link inspector, transaction hangs and page eventually explodes. - 10https://bugzilla.wikimedia.org/42935 +comment (10Rob Moen) [02:04:38] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/38002 [02:06:18] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/38003 [02:10:04] What version of PHP does the wikipedia editor need to work [02:10:05] New patchset: Catrope; "Remove FIXMEs resolved in 15c5495255f86dd8357a1b628c9d4b1e1af76e31" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/38005 [02:11:07] 03(NEW) Removing copy/pasted link annotations removes the original as well - 10https://bugzilla.wikimedia.org/42937 major; VisualEditor: Data Model; () [02:12:56] New patchset: Trevor Parscal; "(bug 42937) Removing copy/pasted link annotations removes the original as well" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/38009 [02:13:10] 03(mod) Removing copy/pasted link annotations removes the original as well - 10https://bugzilla.wikimedia.org/42937 (10Trevor Parscal) [02:13:47] Change merged: jenkins-bot; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/38005 [02:14:00] Change merged: jenkins-bot; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37999 [02:14:53] 03(mod) VisualEditor: Removing copy/pasted link annotations removes the original as well - 10https://bugzilla.wikimedia.org/42937 summary; +comment (10James Forrester) [02:16:41] 03(mod) VisualEditor: While using link inspector, transaction hangs and page eventually explodes. - 10https://bugzilla.wikimedia.org/42935 (10James Forrester) [02:21:37] New review: Catrope; "Yay references! Code is good, but please fix the typo in the doc comment." [mediawiki/extensions/VisualEditor] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/38009 [02:22:22] Change merged: jenkins-bot; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/38009 [02:23:27] New patchset: Trevor Parscal; "Adjustments and fixes for styles" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37983 [02:25:40] Anyone active. I need to know what version of php I need to get Wiki Editor ext to work. [02:26:22] running on 5.2.17 [02:27:45] 03(mod) Parsoid: Linking on a part of a word triggers linktrail - 10https://bugzilla.wikimedia.org/33091 +patch-in-gerrit; +comment (10Gabriel Wicke) [02:34:15] New patchset: Jforrester; "Fix typo'ed documentation issue with gerrit change 38009" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/38011 [02:35:01] New patchset: Trevor Parscal; "Adjustments and fixes for styles" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37983 [02:41:16] New patchset: Trevor Parscal; "(bug 42920) Add the feedback tool" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37998 [02:43:18] 03(mod) VisualEditor: Removing copy/pasted link annotations removes the original as well - 10https://bugzilla.wikimedia.org/42937 +comment (10James Forrester) [02:45:15] 03(mod) Please edit the archives of wikilovesmonuments-l mailing list - 10https://bugzilla.wikimedia.org/42673 +comment (10Philippe Beaudette) [02:45:47] New patchset: Trevor Parscal; "(bug 42920) Add the feedback tool" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37998 [02:46:35] New review: Trevor Parscal; "Rebase" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37998 [02:47:53] New patchset: Trevor Parscal; "(bug 42920) Add the feedback tool" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37998 [02:50:14] Change merged: jenkins-bot; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37983 [02:54:42] Change merged: jenkins-bot; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37998 [02:54:44] 03(mod) VisualEditor: Re-enable the feedback tool for deployment - 10https://bugzilla.wikimedia.org/42920 (10Rob Moen) [02:55:33] Change merged: jenkins-bot; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37948 [02:55:46] Change merged: jenkins-bot; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/38011 [02:56:01] Change merged: jenkins-bot; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/37997 [03:03:38] New patchset: Anomie; "(DO NOT SUBMIT) Lua ustring implementation" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/38013 [03:04:00] New patchset: Trevor Parscal; "Add left margin to save dialog, visible with show changes" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/38014 [03:09:12] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/36350 [03:14:02] Hey, I was wondering if anyone can assist me with something mediawiki related? [03:14:43] New patchset: Trevor Parscal; "Check if there's a document before we try and set focus on it" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/38015 [03:18:11] Change merged: jenkins-bot; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/38014 [03:19:50] New patchset: Aaron Schulz; "Live performance tweaks." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/38016 [03:20:18] Hrmph. [03:22:01] Change abandoned: Aaron Schulz; "Wrong branch" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/38016 [03:22:43] Well I am asking my question, so hopefully someone can provide me an answer. How do you successfully duplicate the Vector skin, so I can make changes on the duplicate? [03:24:05] Change merged: jenkins-bot; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/38015 [03:24:26] New patchset: Trevor Parscal; "Hide the show changes button when we are creating a page" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/38017 [03:25:11] * Susan looks for Roan. [03:25:28] data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw== seems to be blocking me from clicking in parts of VE. [03:25:43] And I'm getting this werid shadow thing. [03:25:51] Change merged: jenkins-bot; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/38017 [03:26:44] http://pruebita.com/visual-editor-mediawiki.org-shadow-2012-12-10.png [03:26:56] That's expected behavior. Ish [03:27:20] There is something in your article that's being alienated (rendered as an uneditable thing), and for some reason VE believes it's positioned there [03:27:25] And sometimes the "Save page" dialog doesn't come up front. [03:27:31] I'm not sure if this just me or VE. [03:27:35] So difficult to tell... [03:27:36] "doesn't come up front"? [03:28:37] http://pruebita.com/visual-editor-mediawiki.org-save-page-dialog-weirdness-2012-12-10.png [03:28:41] That. [03:28:58] If I play with the zoom/window size, I can see the checkboxes below. [03:29:02] But can't reach the button. [03:29:09] Frustratingly. [03:29:10] wow, that's bad [03:29:16] Could well be a bug in the monobook integration [03:29:26] It's possible it's personal JS/CSS. [03:29:30] OR that. [03:29:33] Or, rather. [03:29:55] Anyone know what version wikipedia wikiEditor needs [03:29:57] Are any of the devs using Monobook? [03:29:58] PHP wise [03:30:09] Susan: Sadly, no [03:30:12] I'm surprised to see that James focused on browser compatibility rather than skin compatibility. [03:30:15] Heh. [03:30:18] We don't do as much monobook testing as we should [03:30:24] Though in a lot of ways, I think VE should be skin-agnostic. [03:30:38] I'm not sure why it's limited to certain skins. [03:30:49] At least I can use Monobook now. [03:31:08] WFM on HEAD [03:31:19] Probably either a user CSS issue, or something that's been fixed since the last deploy [03:31:26] Where are you testing? [03:31:30] localhost [03:31:32] Gay. [03:31:41] There's no head copy floating around? [03:31:47] Translatewiki.net needs VE! [03:31:55] Not anywhere on a public server that I know of, no [03:31:57] factor: 1.17, probably? The documentation on mediawiki.org should tell you. [03:32:42] RoanKattouw: You don't use Monobook? [03:33:23] Susan, I am using 1.19.3 but php 5.2 [03:33:36] I may try wii editor 3.0 [03:33:50] instead of 3.1 if I can find it [03:35:42] 03(mod) Wikis waiting for creation (tracking) - 10https://bugzilla.wikimedia.org/16976 (10sumone10154) [03:37:55] so...any idea how to duplicate the vector skin for changes? I do not want to modify the skin itself. [03:38:03] New review: Spage; "Some important comment comments, and I get two test failures. I didn't study the test suite in depth." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/37657 [03:38:39] Susan: No, I use Vector [03:40:07] New patchset: Trevor Parscal; "Added VisualEditor specific edit notices" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/38018 [03:41:30] New patchset: Trevor Parscal; "Added VisualEditor specific edit notices" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/38018 [03:45:49] Change merged: jenkins-bot; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/38018 [04:03:17] 03(NEW) "expand" widgets [+] fail on Wikipedia for numerical only categories - 10https://bugzilla.wikimedia.org/42938 normal; MediaWiki extensions: CategoryTree; () [04:06:59] New patchset: Santhosh; "(bug 30071) Support gender in mood messages ("happy" etc)" [mediawiki/extensions/MoodBar] (master) - https://gerrit.wikimedia.org/r/29925 [04:14:34] !noc [04:14:34] All configuration is done in LocalSettings.php (near the end of the file). Editing other files means modifying the software. Default settings are not in LocalSettings.php, you can look in DefaultSettings.php. See , , , and [04:14:55] !config [04:14:55] All configuration is done in LocalSettings.php (near the end of the file). Editing other files means modifying the software. Default settings are not in LocalSettings.php, you can look in DefaultSettings.php. See , , , and [04:18:31] 03(NEW) VisualEditor: Save button should be disabled if dm state is identical to page when it was loaded - 10https://bugzilla.wikimedia.org/42939 normal; VisualEditor: Initialisation and integration; () [04:18:53] New patchset: Santhosh; "Remove a var_dump statement" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/38019 [04:21:47] 03(mod) Please add a link back to Special:AbuseFilter in Special:AbuseFilter/ - 10https://bugzilla.wikimedia.org/40862 (10Adithya Parthasarathy) [04:23:33] * Betacommand is starting to really hate mediawiki messages and namespaces [04:24:09] where are the values for recent changes IE (Show last 1 | 2 | 6 | 12 hours 1 | 3 | 7 days all) defined at? [04:30:19] Betacommand: &uselang=qqx should show you the page with the message names compared to messages [04:30:33] Betacommand: For recent changes, it's $wgRCLinkDays [04:30:41] New review: Spage; "Looks good, minor comments." [mediawiki/extensions/Onboarding] (master) - https://gerrit.wikimedia.org/r/37610 [04:30:42] For the watchlist, it seems to be hardcoded. [04:30:50] PleaseStand: why cant I find that value on noc? [04:31:50] Betacommand: If it's the default setting, it would be in DefaultSettings.php, but not necessarily in the Wikimedia configuration. [04:32:07] PleaseStand: its not default [04:32:39] PleaseStand: Im trying to tweak my local install to use the finer limits [04:32:52] default min is 1 day [04:33:08] $wgMiserMode? [04:33:38] Hmm. [04:33:48] New patchset: Catrope; "Set the save timeout to 100s as well" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/38021 [04:36:16] PleaseStand: any ideas? [04:37:49] #p-personal a.new:visited { color: red; } /* personal visited new links */ [04:37:56] what is wrong with my code? [04:39:52] can anyone help? [04:40:28] Change merged: jenkins-bot; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/38021 [04:42:21] ocheal: missing ; [04:43:24] betacommand: where? [04:43:50] at the end [04:45:25] betacommand: nope, thats fine [04:45:46] this one is working just fine, #p-personal a.new { color: Tomato } /* personal visited new links */ [04:46:23] ocheal: red; } [04:46:29] see the extra ; there? [04:47:19] this also works, #p-personal a.new { color: Tomato; } /* personal visited new links */ [04:47:49] 03(mod) A strict and correct Git workflow document is needed - 10https://bugzilla.wikimedia.org/36437 +comment (10Quim Gil) [04:52:54] 03(mod) VisualEditor: Save button should be disabled if dm state is identical to page when it was loaded - 10https://bugzilla.wikimedia.org/42939 (10James Forrester) [04:57:57] 03(mod) Gerrit statistics - 10https://bugzilla.wikimedia.org/37463 (10Quim Gil) [04:58:53] 03(mod) Swap gitweb for GitBlit - 10https://bugzilla.wikimedia.org/38383 (10Quim Gil) [04:59:46] 03(mod) List of Gerrit users - 10https://bugzilla.wikimedia.org/35508 (10Quim Gil) [05:00:34] New patchset: Catrope; "Updating VisualEditor to master" [mediawiki/core] (wmf/1.21wmf5) - https://gerrit.wikimedia.org/r/38022 [05:00:59] Change merged: Catrope; [mediawiki/core] (wmf/1.21wmf5) - https://gerrit.wikimedia.org/r/38022 [05:01:17] So, no subpages in the file: namespace then? [05:01:25] 03(mod) Please add a link back to Special:AbuseFilter in Special:AbuseFilter/ - 10https://bugzilla.wikimedia.org/40862 (10Gautham Shankar) [05:01:29] 03(mod) Documentation for Gerrit on labs is almost as ugly as Gerrit itself - 10https://bugzilla.wikimedia.org/35403 (10Quim Gil) [05:01:32] 03(mod) A strict and correct Git workflow document is needed - 10https://bugzilla.wikimedia.org/36437 (10Quim Gil) [05:02:27] New patchset: Catrope; "Updating VisualEditor to master" [mediawiki/core] (wmf/1.21wmf6) - https://gerrit.wikimedia.org/r/38023 [05:03:19] Change merged: Catrope; [mediawiki/core] (wmf/1.21wmf6) - https://gerrit.wikimedia.org/r/38023 [05:14:17] New review: Brian Wolff; "I don't think dynamically setting a hook when a parser function is activated is the right approach. ..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/37837 [05:16:35] New patchset: Catrope; "And also use a 100s timeout for show changes" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/38025 [05:19:26] Change merged: jenkins-bot; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/38025 [05:32:51] Change merged: Santhosh; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/37872 [05:33:22] 03(mod) Indicate context when language list is shown for input method selection - 10https://bugzilla.wikimedia.org/42382 (10Amir E. Aharoni) [05:35:46] Change merged: Amire80; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/38019 [05:37:16] New review: Brian Wolff; "Sorry, I read that too fast. Ignore the part of my comment about what if somebody calls {{setlang th..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/37837 [05:43:02] New patchset: Spage; "Reinstate qunit test" [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/38026 [06:07:17] New patchset: Ori.livneh; "JSON Schema validation in PHP" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/37825 [06:08:52] New patchset: Ori.livneh; "CACHE_MEMCACHE -> CACHE_ALL_THE_THINGS" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/38027 [06:10:20] New review: Ori.livneh; "Setting the stage for a self-merge by pretending to be triggering a test run." [mediawiki/extensions/EventLogging] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/38027 [06:11:54] New patchset: Parent5446; "Changed LoginForm::addNewaccountInternal() to return Status." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/17952 [06:13:38] New review: Ori.livneh; "Self-merging after Jenkins failure, for the lulz." [mediawiki/extensions/EventLogging] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/38027 [06:13:39] Change merged: Ori.livneh; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/38027 [06:13:51] How do we change visited link color of new page in the top header? [06:14:32] New patchset: Parent5446; "Changed LoginForm::addNewaccountInternal() to return Status." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/17952