[00:01:43] New review: Alex Monk; "Comments on PS4 apply to PS5" [mediawiki/extensions/SpecialNamespaces] (master) C: -1; - https://gerrit.wikimedia.org/r/39720 [00:05:55] 03(mod) Change logo for the Finnish Wiktionary - 10https://bugzilla.wikimedia.org/43348 +comment (10Nemo) [00:05:56] 03(mod) Add localised logos for Wiktionaries without one - 10https://bugzilla.wikimedia.org/43240 +comment (10Nemo) [00:14:15] New patchset: Carlb; "bug 43220: use mediawiki:listings-template to override formatting" [mediawiki/extensions/Listings] (master) - https://gerrit.wikimedia.org/r/39394 [00:14:43] 03(mod) Unable to change file extension while uploading file - 10https://bugzilla.wikimedia.org/34703 (10Marek Blahuš) [00:16:14] I get "Failed to import keypair" from labsconsole. Do I need to add my pubkey to that site? [00:17:02] the same key worked fine with gerrit [00:17:39] yes [00:18:29] Yurik: your private key is private. don't upload it. [00:18:53] ori-l: i said pub key, not private :) [00:19:17] ok, just making sure. [00:19:32] New review: Alex Monk; "Am now getting
" [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/37812 [00:19:43] I was going to say the same thing [00:19:56] hehe, lots of ppl posted their private keys? [00:20:29] anyway, trying to setup my dev env (windows). Git is running, i can pull with ssh [00:20:30] No, the way you said it implied you tried something that wasn't your public key [00:20:45] that's what the server told me :( [00:21:00] ugh windows [00:21:09] Krenair: can you help me make sense of your comment? where are you getting this error? on a development instance? [00:21:23] -> #wikimedia-e3 [00:22:48] New review: Alex Monk; "Ignore the above, I had an old copy of EventLogging..." [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/37812 [00:23:07] so I got the public key uploaded to gerrit.wikimedia.org, but the same key gives me "Failed to import keypair." on labsconsole.wikimedia.org [00:23:27] I tried to regen a new one, but it gave me the same error. [00:25:26] 03(mod) Unable to change file extension while uploading file - 10https://bugzilla.wikimedia.org/34703 +comment (10Marek Blahuš) [00:25:54] New patchset: Carlb; "bug 43220: use mediawiki:listings-template to override formatting" [mediawiki/extensions/Listings] (master) - https://gerrit.wikimedia.org/r/39394 [00:27:36] New patchset: Carlb; "bug 43220: use mediawiki:listings-template to override formatting" [mediawiki/extensions/Listings] (master) - https://gerrit.wikimedia.org/r/39394 [00:31:40] New patchset: Legoktm; "(bug 43283) Have action=info check protected namespaces" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39845 [00:32:29] New review: Legoktm; "According to https://www.mediawiki.org/wiki/Manual:$wgNamespaceProtection, the MediaWiki namespace p..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/39845 [00:34:06] New patchset: Alex Monk; "Fix validation messages" [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/40075 [00:35:06] New patchset: MrBlueSky; "(minor) wfParseUrl() throws a Notice for some inputs" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/40076 [00:37:51] Change merged: Ori.livneh; [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/40075 [00:42:29] New patchset: Alex Monk; "(bug 43358) Fix for enwiki's HTML in noname message" [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/40077 [00:48:24] qgil > I wrote a little script to get a count of patches merged by authors from Gerrit. Would you be interested by this kind of Gerrit queries processing (e.g. the repartition of Gerrit changes merged by branch, to identify amount backported vs. amount submitted in current version)? [00:49:47] My personal goal is to have a script to help check if the == Patch Contributors == section is up to date. [00:50:33] (in the CREDITS file) [00:57:26] New patchset: Carlb; "Initial check-in of Special:Namespaces for MW 1.17-1.20" [mediawiki/extensions/SpecialNamespaces] (master) - https://gerrit.wikimedia.org/r/39720 [01:00:30] Interesting fact: Reedy, Aaron Schulz, IAlex and Umherirrender beat L10n-bot in commit amounts to MediaWiki itself. [01:01:59] New review: Alex Monk; "Apart from two more minor issues, code style looks good now." [mediawiki/extensions/SpecialNamespaces] (master) C: 0; - https://gerrit.wikimedia.org/r/39720 [01:02:56] 03(mod) Special:EducationProgram times out when not cached - 10https://bugzilla.wikimedia.org/42923 +comment (10Jeroen De Dauw) [01:03:44] 03(mod) Special:EducationProgram times out when not cached - 10https://bugzilla.wikimedia.org/42923 +comment (10Jeroen De Dauw) [01:04:06] New patchset: Carlb; "Initial check-in of Special:Namespaces for MW 1.17-1.20" [mediawiki/extensions/SpecialNamespaces] (master) - https://gerrit.wikimedia.org/r/39720 [01:05:49] 03(mod) Special:EducationProgram times out when not cached - 10https://bugzilla.wikimedia.org/42923 +comment (10Jeroen De Dauw) [01:06:34] New patchset: Jeroen De Dauw; "Added alias for Special:EducationProgram" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/35814 [01:08:03] New patchset: Alex Monk; "(bug 43358) Fix for enwiki's HTML in noname message" [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/40077 [01:12:54] New patchset: Carlb; "Initial check-in of Special:Namespaces for MW 1.17-1.20" [mediawiki/extensions/SpecialNamespaces] (master) - https://gerrit.wikimedia.org/r/39720 [01:14:24] New review: Ori.livneh; "OK, but I'd like to revisit this. Thanks!" [mediawiki/extensions/E3Experiments] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/40077 [01:14:25] Change merged: Ori.livneh; [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/40077 [01:15:20] 03(mod) Raw HTML message for invalid user name gets displayed to user - 10https://bugzilla.wikimedia.org/43358 +comment (10Krenair) [01:16:56] 03(mod) Raw HTML message for invalid user name gets displayed to user - 10https://bugzilla.wikimedia.org/43358 +comment (10Ori Livneh) [01:17:14] Before cleaning operation, case handling, etc. it detected 19 people already credited (and 89 to credit). Good, that works. [01:29:47] New patchset: Siebrand; "Remove en-gb" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/40078 [01:30:10] Change merged: jenkins-bot; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/40078 [01:33:26] Change merged: Yaron Koren; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/39863 [01:43:43] 03(mod) Thumbnails of large PNGs are not generated - 10https://bugzilla.wikimedia.org/9497 +comment (10Bawolff (Brian Wolff)) [01:52:37] Change merged: Reedy; [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/39851 [01:56:27] Quick question: After using Bluehost's SimpleScripts to install MediaWiki 1.19.1, the wiki homepage is now just a blank screen. Any suggestions? [01:56:48] The source of the page is totally empty, etc. [02:00:08] !blank | skip [02:00:08] skip: A blank page or HTTP 500 error usually indicates a fatal PHP error. For information on debugging (including viewing errors), see . [02:15:12] 03(mod) Create mediawiki-india Mailinglist - 10https://bugzilla.wikimedia.org/43353 +comment (10Philippe Beaudette) [02:25:43] 03(mod) PHP strict violations - 10https://bugzilla.wikimedia.org/43344 +comment (10Dereckson) [03:18:26] New patchset: Dereckson; "Update CREDITS" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/40079 [03:27:03] New review: Dereckson; "If you've been included as reviewer, this means your name has been added to the CREDITS file." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/40079 [03:41:01] New review: Ori.livneh; "Thanks for putting this change-set together, Dereckson -- it's very nice of you." [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/40079 [04:03:55] 03(mod) [Enhancement] SpecialVersion.php: version info: in addition to SHA hashes, please show also the date (perhaps more info) - 10https://bugzilla.wikimedia.org/43354 +comment (10Dereckson) [04:36:12] 03(mod) Add Javanese font to WebFonts - 10https://bugzilla.wikimedia.org/39381 +comment (10bennylin) [04:37:39] 03(mod) Allow WebFonts to be loaded but disabled by default. - 10https://bugzilla.wikimedia.org/43297 +comment (10bennylin) [04:48:01] 03(mod) Enable Narayam on the Javanese projects - 10https://bugzilla.wikimedia.org/39960 +comment (10bennylin) [04:48:03] 03(NEW) Enable WebFonts on the Javanese projects - 10https://bugzilla.wikimedia.org/43359 normal; Wikimedia: Extension setup; () [04:49:15] 03(mod) Enable WebFonts on the Javanese projects - 10https://bugzilla.wikimedia.org/43359 (10bennylin) [04:49:15] 03(mod) Add Javanese font to WebFonts - 10https://bugzilla.wikimedia.org/39381 (10bennylin) [04:53:29] 03(mod) Add Javanese font to WebFonts - 10https://bugzilla.wikimedia.org/39381 +comment (10bennylin) [04:53:47] 03(mod) Enable WebFonts on all WMF projects - 10https://bugzilla.wikimedia.org/34982 +comment (10bennylin) [06:10:09] 03(mod) Wikilove for it.wikivoyage - 10https://bugzilla.wikimedia.org/43274 +comment (10Emanuele Raoli) [06:10:18] 03(mod) Enable the "autopatrolled" group on it.wikivoyage - 10https://bugzilla.wikimedia.org/43327 +comment (10Emanuele Raoli) [06:20:37] 03(mod) PHP Fatal moving Semantic pages - 10https://bugzilla.wikimedia.org/43080 (10Nischay Nahata) [07:05:01] Change merged: IAlex; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/40079 [07:10:28] Change merged: IAlex; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39087 [07:19:23] Change merged: IAlex; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/38355 [08:05:45] New patchset: PleaseStand; "Add 'safe' option and .each() function to mw.Map()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/40081 [08:38:08] 03(mod) | (vertical bar) character is not accepted in aliases - 10https://bugzilla.wikimedia.org/43136 +comment (10Nikola Smolenski) [08:54:46] 03(mod) [Enhancement] SpecialVersion.php: version info: in addition to SHA hashes, please show also the date (perhaps more info) - 10https://bugzilla.wikimedia.org/43354 +comment (10T. Gries) [09:04:25] 03(mod) No right column in "Modern" skin. - 10https://bugzilla.wikimedia.org/39337 +comment (10Fiable.biz) [09:20:08] hi [09:38:14] New review: Matmarex; "-1 for typos D:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/40079 [10:01:19] MatmaRex: I can't believe you caught my name being misspelled and I didn't. I throw myself at your mercy. [10:13:06] marktraceur: noticing misspellings is one of my useless talents ;) [10:13:36] MatmaRex: Usually it's one of mine as well, but evidently my holiday party drinking affected me more than I realized [10:16:21] haha :D [10:18:41] New patchset: Raimond Spekking; "[GuidedTour] Register extension" [translatewiki] (master) - https://gerrit.wikimedia.org/r/40082 [10:18:53] Change merged: Raimond Spekking; [translatewiki] (master) - https://gerrit.wikimedia.org/r/40082 [10:48:55] is there any tool that can perform automatic backups of mediawiki? [10:49:06] for now i am using the dumpxml.. thing [10:55:59] azi`: not afaik [10:56:24] but when making a backup, remember to include the /images directory and LocalSettings.php [11:01:55] you could dump the mysql db instead of dumping into xml format (but you still need the config file and the images, as Sar uman says), depending on your access [11:02:08] it's quicker to restore if you are using it for a true backup [11:28:57] How to do profiling? My edits are very slow, I did every performance tuning I could do. [11:29:37] !profiling [11:29:37] For information on how to enable profiling for MediaWiki, see [11:30:03] this page seems outdated [11:30:54] Why? [11:31:32] I am using MW 1.20 [11:31:46] I modified StartProfiler.php as it says [11:32:35] pastebin? [11:32:38] issue? [11:34:40] http://pastebin.com/gehDWuh2 [11:35:37] Dantman: But there is nothing in the page source; it doesn't work. [11:36:06] walter: The profiler does not output any information at all into the page [11:36:25] It only saves it to the database to be agregated and used [11:37:17] Outputting everything into page source would be impossible. [11:37:20] Dantman: It says, "To view profiling information as HTML comments appended to the bottom of a page..." [11:38:37] ...well I guess I can't guarantee that continues to work... I've never heard of anyone using it... but are you even using ?forceprofile=true? [11:39:34] Dantman: I wanna retry the method again after I get done with my db maintenance, though somebody said that this is outdated... [11:39:53] some skins might not provide the place to show these comments or whatnot [11:39:57] (but i never used it personally) [11:40:10] I heard profiling gets done through resource loader and there are new methods... [11:40:15] We have a standard simple viewer at profileinfo.php [11:40:37] Profilimg doesn't really have anything to do with RL [11:41:23] MatmaRex: good point [11:41:43] Dantman: profileinfo has to involve the db right? [11:41:53] Course [11:43:23] yeah I didn't want to log info to db, but if html comments won't work, I'll give profile info a try. [11:44:08] But just to confirm again, this is the only (standard) way to profile? [11:44:24] mhmm [11:45:27] There are too really big issues with comments [11:45:31] two* [11:46:28] Firstly php is run in places other than page views... like RL and maintenance scripts... these are impossible to cover with comments. [11:48:23] Secondly we still run code after skins have been rendered, and some of that code could still take a period of time in profiling. But you can put any of that profiling info into the comment after it's been rendered. So profiling comments will always be incomplete. [11:49:07] And now that I think about it... thirdly, a single sample is never a good source of profiling info. You want to aggregate and average across multiple requests. [11:54:47] Hi guys, is it possible to watch changes of talk pages? My situation: I have a page of sub-ambassador project. This page is a list of articles which are edited by students. Professor need to watch changes of talk pages too, not only main articles. Thanks [11:55:41] Dominikmatus: that's how it works by default [11:55:43] Dominikmatus: When you put something on your watchlist both the page and it's associated talkpage are watched [11:55:51] Dominikmatus: you always watch both the content page and its talk page at once [11:58:12] Thanks dantman for explaining, but the comments were not even showing. [11:58:33] btw, if we are talking about this. for special:associated the option related ns, doesnt work [11:58:39] But I'll consider these drawbacks with comments [11:58:48] MatmaRex: Dantman: I know, but it do not work. I don't know how on EN wiki, but on CS wiki it do not work. I mean [11:59:07] Rightnow I think I figured the source of slow edits [11:59:08] ..specilal page [11:59:45] Its this line, #$wgSquidServers = array( '123.123.123.123' ); [12:00:21] This is the public ip of the server on which squid and apache both are installed [12:00:48] Dominikmatus: i'm not sure i understand. how can it not work? clicking "Watch" (or the funky star on Vector) adds both the primary page and its talk to your watchlist [12:00:50] 03(mod) EducationProgram: Fatal "Call to a member function getId() on a non-object" in EPTimelineGroup.php - 10https://bugzilla.wikimedia.org/42509 +comment (10Sage Ross) [12:01:46] If I comment out this line, the edits are instant! [12:02:23] Ether your squid server is slow, or more likely MW cannot connect to it to purge [12:02:25] #$wgSquidServers = array( '123.123.123.123' ); is not painfull, but there is a little delay [12:02:41] Dominikmatus: I dont understand you neither:-) [12:03:55] I am not sure if squid server is being slow, but what do you mean by MW unable to connect? [12:04:57] I have also this line included, $wgSquidServersNoPurge = array( '127.0.0.1' ); [12:06:20] New review: Matmarex; "Tentative -1 until you explain yourself :)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/40081 [12:06:39] And somehow I previously figured that you need the public ip with #$wgSquidServers, is that true? [12:06:40] walter: MediaWiki connects to the squid servers so that when you edit a page it can purge the cache for the page so people will see the new contents. [12:07:13] hmmm [12:07:23] so what should be the correct setting? [12:07:37] Apache and squid on the same server [12:07:56] walter: If it cannot connect it will typically have to wait for the connection to timeout... which can sometimes be configured for long times like 30 or 60 seconds [12:08:08] The caches must be purged, but at the same time the fast edits are just delicious!! [12:08:29] walter: Whatever IP can be used by the server to send a HTTP PURGE request [12:09:37] Though I think it is connecting as it should, can you elaborate your last sentence please? [12:10:39] Can server use its internal (private) ip or should it be public ip [12:10:54] to send the HTTP purge request? [12:11:55] What would be the config for webserver and proxy on the same box, in simple words? [12:12:18] That'll vary... it could be the public IP, if you want the connection to go out and come back (may not be the most efficient) and it's possible to make a connection and accept purges from the same ip. Or it could be the loopback address, if Squid has been configured to listen on that IP. [12:13:05] I'm pretty sure you may have to configure a whitelist of what IP to permit to send PURGE requests to squid inside of squid config [12:15:49] nowhere in the squid caching manual it says to configure squid whitelist, I think #$wgSquidServers does the job of creating whitelist [12:16:01] No it doesn't [12:16:02] New review: Matmarex; "Looks good, but I'm not +1ing, because I didn't actually run the code and I'm not too familiar with ..." [mediawiki/extensions/AbuseFilter] (master) C: 0; - https://gerrit.wikimedia.org/r/30110 [12:16:03] That's impossible [12:16:41] The whitelist I speak of would be from squid's perspective. A list of IPs that it will allow to eliminate cache entries. [12:16:56] ok googling to configure squid [12:17:39] but how come if there should be whitelist, no error or timeout is happening to me? [12:17:56] I'm pretty sure there's a whitelist like that... because allowing everyone to PURGE would be a DOS vector. [12:18:57] And apart from this, what setting do you suggest [12:19:11] if apache is listening on localhost:80 [12:19:30] and squid is on the same server, feeding requests to apache [12:20:35] I couldn't get any enlightenment from this, "That'll vary... it could be the public IP, if you want the connection to go out and come back (may not be the most efficient) and it's possible to make a connection and accept purges from the same ip. Or it could be the loopback address, if Squid has been configured to listen on that IP." :( [12:32:16] New patchset: Siebrand; "Remove WikiLovesMonuments 2012 survey" [translatewiki] (master) - https://gerrit.wikimedia.org/r/40083 [12:32:29] Change merged: Siebrand; [translatewiki] (master) - https://gerrit.wikimedia.org/r/40083 [12:57:20] Dantman: The issue was aws security groups if you know, and squid setting is correct, and edits are good now. thanks for all the help. [13:05:11] New patchset: Matmarex; "(bug 42354) final and ultimate fix, for JS this time" [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/40084 [13:07:36] New patchset: Matmarex; "(bug 43227) fix noncollapsible sidebar due to HTML changes" [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/40084 [13:08:18] 03(mod) display problem, login problem, possible caching issue - 10https://bugzilla.wikimedia.org/42452 +comment (10Bartosz Dziewoński) [13:08:21] 03(mod) Navigation/Toolbox side panel is not collapsible/expandable when being logged out - 10https://bugzilla.wikimedia.org/43227 +patch-in-gerrit; +comment (10Bartosz Dziewoński) [13:09:39] 03(mod) Oversight button not working - 10https://bugzilla.wikimedia.org/37550 +comment (10Oliver Keyes) [13:38:59] 03(mod) CentralAuth: Username not substituted in Centralauth-renameuser-merged message - 10https://bugzilla.wikimedia.org/42727 (10Quentinv57) [13:49:38] New patchset: Nikerabbit; "All tab was selected by default but showing untranslated" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/40085 [14:04:26] How to delete MediaWiki:Wikimedia-copyright page [14:04:28] ? [14:09:38] Hello. [14:10:18] ibut > if you wish to remove the default message, you can create it on your local wiki, with a blank content. [14:11:00] MatmaRex: thanks for the names check and review, this is annoying this has been merged so soon. [14:11:18] Dereckson: That doesn't work [14:11:48] ibut: url of your [[Mediawiki:Wikimedia-copyright]] page? [14:12:12] 03(NEW) #formlink|link type=button does not work with ugly urls - 10https://bugzilla.wikimedia.org/43360 major; MediaWiki extensions: SemanticForms; () [14:12:14] I tried deleting, blanking, putting a hyphen, but this default text "Text is available under the Creative Commons..." keeps coming back [14:12:23] my wiki is private [14:12:41] I guess this is because Mediawiki:Wikimedia-copyright isn't the relevant message to edit. [14:12:48] I have a Mediawiki:Copyright page [14:13:10] but Mediawiki:Wikimedia-copyright overrides [14:13:33] It was working fine before, but I stupidly imported the page [14:13:52] and now I cant delete [14:14:10] I can put my copyright in this Mediawiki:Wikimedia-copyright page though [14:14:21] but why I cant just delete? [14:14:24] Okay, Wikimedia-copyright isn't a standard message, it's included in the WikimediaMessages extension, which provides for Wikimedia wikis a standard set of messages. [14:14:42] oh [14:14:55] thanks for telling me that [14:15:12] Do I need this extension for my private wiki? [14:15:13] So I wonder if there isn't an hook in this extension who do the message replacement. [14:15:32] I don't think so, except if you want to have licenses text like CC-BY, CC-BY-SA, etc. [14:15:45] localized in every language [14:16:05] nope [14:16:19] let me check what was the reason behind installing this extension [14:16:31] Also the extensions were last updated a week ago [14:16:46] Yes, we merged two messages in one. [14:16:47] And this problem occurred just now [14:17:27] We had two concurrent messages, wikimedia-editpage-tos-summary and wikimedia-copyrightwarning. [14:17:34] We removed the first. [14:17:44] Last week update is a l10n one. [14:18:20] ibut: wait MatmaRex comes back, he will be able to help you to debug the situation [14:19:16] Well I guess I'll just disable the extension for now [14:19:26] Thanks a lot for helping [14:33:25] Dereckson: "annoying this has been merged so soon"? man, i would like to have this kind of problems with my changesets :P [14:33:59] argh, ibut's gone [14:34:29] (i agree though, that was merged too quickly) [14:34:36] back to afk ~ [14:35:09] New patchset: Dereckson; "Update CREDITS" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/40086 [14:38:08] New patchset: Dereckson; "Update CREDITS" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/40086 [14:39:14] New review: Dereckson; "Follow-up: Gerrit change I9a5190e2" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/40079 [14:40:13] New review: Dereckson; "If you've been included as reviewer, this means your name has been added to the CREDITS file." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/40086 [14:43:22] New review: btongminh; "This needs RELEASE-NOTES. Also, please start your sentences in the commit message with a capital." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/39570 [14:51:48] 03(mod) [Regression] removeUnusedAccounts.php broken (needs to ignore newuser logging entry) - 10https://bugzilla.wikimedia.org/34581 +comment (10Rob Kam) [14:51:56] 03(NEW) Support block element inside link in HTML5 - 10https://bugzilla.wikimedia.org/43361 normal; MediaWiki: Parser; () [14:58:10] 03(NEW) Limit Special:Contributions to registered or anonymous users when filtered to User or User talk namespace - 10https://bugzilla.wikimedia.org/43362 normal; MediaWiki: Special pages; () [14:58:23] 03(mod) Limit Special:Contributions to registered or anonymous users when filtered to User or User talk namespace - 10https://bugzilla.wikimedia.org/43362 normal->15enhancement (10Hex) [14:59:43] 03(mod) Add Javanese font to WebFonts - 10https://bugzilla.wikimedia.org/39381 +comment (10Dereckson) [15:02:15] 03(mod) Add watch star to items in Special:Contributions - 10https://bugzilla.wikimedia.org/40661 summary (10Hex) [15:03:14] 03(mod) Enable WebFonts on the Javanese projects - 10https://bugzilla.wikimedia.org/43359 +patch-in-gerrit +shell; +comment (10Dereckson) [15:22:12] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/40085 [15:33:18] 03(mod) Support block element inside link in HTML5 - 10https://bugzilla.wikimedia.org/43361 (10Daniel Friesen) [16:01:50] New patchset: Siebrand; "Fix typo." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/40087 [16:02:23] Change merged: Siebrand; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/40087 [16:04:07] New patchset: Yurik; "(bug 35064) Added Cyrillic chars to Special Symbols editor" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/40088 [16:09:26] New patchset: Siebrand; "Substitute available message instead of "Edit"" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/40089 [16:09:50] Change merged: Siebrand; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/40089 [16:17:38] New patchset: Siebrand; "Actually use plural" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/40090 [16:18:56] ugh who broke it now [16:19:25] !blame [16:19:25] Whatever happened, it's Domas' fault. For everything else, there's `git blame`. [16:19:54] Echo isn't compatible with SQLite, it's a known bug [16:20:04] Jenkins can't run tests on it yet [16:20:14] * MatmaRex 's just jokin' [16:20:46] New review: Alex Monk; "Go away Jenkins" [mediawiki/extensions/Echo] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/40090 [16:20:47] Change merged: Alex Monk; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/40090 [16:21:26] New review: Siebrand; "Override Jenkins as it set failure on something unrelated. Added Antoine to reviewers." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/40090 [16:22:10] New review: Alex Monk; "Hashar, please disable mwext-Echo-testextensions-master on Echo - https://bugzilla.wikimedia.org/sho..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/40090 [16:24:11] New review: Alex Monk; "You can upload PS2 for this btw, we just can't merge it until I2096f50b is in core master." [mediawiki/extensions/Echo] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/37564 [16:24:31] New review: Siebrand; "Looks like I cannot score here for whatever reason. I'll add Antoine to the patch set. Score is -1 b..." [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/40080 [16:24:36] siebrand, Reedy, RoanKattouw: could you review https://gerrit.wikimedia.org/r/#/c/40088/ [16:25:58] siebrand, ... trying to open https://gerrit.wikimedia.org/r/40080 gives "The page you requested was not found, or you do not have permission to view this page." [16:29:32] New review: Siebrand; "Added inline comment." [mediawiki/extensions/TemplateSandbox] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/39768 [16:31:06] New review: Anomie; "IAlex, you should probably have waited a bit longer before merging for people being added to review ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/40079 [16:33:38] New review: Siebrand; "Raimond: No reason to fuzzy translations. Just grammar fixes." [mediawiki/core] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/38825 [16:33:44] 03(mod) #formlink|link type=button does not work with ugly urls - 10https://bugzilla.wikimedia.org/43360 +comment (10Yaron Koren) [16:35:02] anomie: I guess IALex saw the three +1 so thought "should be ok". [16:35:39] anomie: I opened https://gerrit.wikimedia.org/r/#/c/40086/ for the corrections [16:36:05] Dereckson- I saw that, my bit seems ok to me. [16:36:16] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/38825 [16:36:40] New patchset: Amire80; "Fix selector position when closing a translation row" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/36909 [16:36:52] What's the criteria to be on the 'Developers' part of that list anyway? [16:36:54] New review: Amire80; "Just a rebase, not tested yet." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/36909 [16:37:12] Krenair: I don't know [16:37:20] Have CR +2 right? [16:37:26] 03(NEW) Entity selector should set input value when setting the entity programmatically - 10https://bugzilla.wikimedia.org/43363 normal; MediaWiki extensions: WikidataRepo; () [16:37:34] Have n changes merged? [16:37:42] Be considered as developer by peerS? [16:38:00] I guess this is a tricky question [16:38:10] git blame CREDITS is interesting on the matter [16:39:04] New review: Anomie; "I did create [[mw:Help:Extension:TemplateSandbox]] already, but I'm not really sure what to put ther..." [mediawiki/extensions/TemplateSandbox] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/39768 [16:41:16] New patchset: Parent5446; "Use JSON for Xml::encodeJsVar." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39839 [16:43:38] 03(mod) Entity selector should set input value when setting the entity programmatically - 10https://bugzilla.wikimedia.org/43363 +comment (10Henning (WMDE)) [16:43:46] 03(mod) Echo doesn't work on SQLite - 10https://bugzilla.wikimedia.org/41987 +comment (10Krenair) [16:45:42] New review: Amire80; "Tested." [mediawiki/extensions/Translate] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/36909 [16:45:53] New patchset: Anomie; "(bug 43312) Add messages for explanatory text to editpage form" [mediawiki/extensions/TemplateSandbox] (master) - https://gerrit.wikimedia.org/r/39768 [16:46:35] 03(mod) jQuery.entityselector widget returns wrong selected entity information (label set to ID if no label) - 10https://bugzilla.wikimedia.org/43317 +comment (10Henning (WMDE)) [16:50:51] Someone wants admin rights on mediawiki.org - https://www.mediawiki.org/wiki/Project:Requests/User_rights/Edokter [16:56:35] jeez why do russian spambots seem to like our category talk pages so much [16:59:28] New patchset: Nischayn22; "Fix usage of Microsoft's translation service." [mediawiki/extensions/LiveTranslate] (master) - https://gerrit.wikimedia.org/r/40092 [17:00:21] which id should i use to close bugzilla bug? The guide said "Merge ID", but i'm not sure which one that is [17:02:57] Yurik, ... what? [17:03:32] when closing bugzilla bug, i want to give a reference to the patch that fixed the issue, right? [17:04:04] Well it should already be there [17:04:05] see https://www.mediawiki.org/wiki/Git/Workflow#Formally_reviewing_and_merging_or_rejecting_code [17:04:16] there - where? in bugzila? [17:04:20] If it's not there, say 'Gerrit change merged' and set it to RESOLVED FIXED. [17:04:36] The ID should be '123' from https://gerrit.wikimedia.org/r/#/c/123 [17:04:58] Sometimes the person who merged the fix will close the bug [17:05:20] So you won't necessarily have to worry about it [17:05:57] right, but shouldn't we at least mark the bug as partially resolved somehow? Otherwise it might be pending for a while [17:06:13] and someone else might duplicate effort by trying to fix it [17:06:44] 03(mod) Cyrillic letter Yat should be included among Special characters in the Enhanced editing toolbar - 10https://bugzilla.wikimedia.org/35064 +comment (10Yuri Astrakhan) [17:06:45] Yes, you should [17:06:53] That's what I was just telling you how to do... [17:07:26] i thought you said it will appear automatically. How does that work? [17:07:38] No I didn't [17:07:46] I said it should already be there [17:08:04] The person who uploaded the patch *should've* said so in the bug when they uploaded it [17:08:43] AA, gotcha, so yes, when i do git review, right afterwards i should go to the bug and switch it to fixed. thx :) [17:09:04] No [17:09:09] Not at all [17:09:15] Do not set a bug to fixed until it is merged [17:09:26] You should make a reference on the bug when you upload the patch [17:09:43] When the patch gets merged, you, the merger, or anyone else, should mark it as RESOLVED FIXED [17:10:15] And if the uploader forgot to mention the Gerrit change number on the bug, they should say that as well [17:11:22] i see, review is not the same as a merge. So my question than is - shouldn't we change the bug to reflect that there is a patch pending? It used to be that all patching was appended to the bug itself, thus everyone saw that even though the bug is open, it has a patch that can be applied [17:12:10] i feel like there should be at least an automated comment generated for the bug with the gerrit link [17:12:36] Some people mark a bug with a pending patch as 'ASSIGNED', assigned to the uploader's email, and add the 'patch-in-gerrit' keyword [17:13:46] 03(mod) Cyrillic letter Yat should be included among Special characters in the Enhanced editing toolbar - 10https://bugzilla.wikimedia.org/35064 +patch-in-gerrit (10Yuri Astrakhan) [17:20:10] 03(mod) 401 Unauthorized error preventing thumbnail display - 10https://bugzilla.wikimedia.org/43345 +comment (10Dereckson) [17:20:11] 03(mod) Thumbnail/imagescaler (tracking) - 10https://bugzilla.wikimedia.org/41371 (10Dereckson) [17:20:15] 03(mod) Greyscale Jpg Thumbnails do not get sharpened - 10https://bugzilla.wikimedia.org/43268 +comment (10Dereckson) [17:20:31] 03(mod) Greyscale Jpg Thumbnails do not get sharpened - 10https://bugzilla.wikimedia.org/43268 (10Dereckson) [17:20:33] 03(mod) Thumbnail/imagescaler (tracking) - 10https://bugzilla.wikimedia.org/41371 (10Dereckson) [17:24:17] 03(NEW) Not updated thumbnails / original file when reverting a picture to an older version (JPG, 2007, 2,898 � 3,807) - 10https://bugzilla.wikimedia.org/43364 normal; Wikimedia: General/Unknown; () [17:24:18] 03(mod) Thumbnail/imagescaler (tracking) - 10https://bugzilla.wikimedia.org/41371 (10Dereckson) [17:44:04] 03(mod) File path issues for eqiad migration - 10https://bugzilla.wikimedia.org/43340 +comment (10Brad Jorsch) [17:46:51] New patchset: Jarry1250; "Make the PNG thumbnail update live" [mediawiki/extensions/TranslateSvg] (master) - https://gerrit.wikimedia.org/r/39380 [17:49:07] 03(NEW) PageTriage uses server rather than local time - 10https://bugzilla.wikimedia.org/43365 normal; MediaWiki extensions: PageTriage; () [17:51:46] New patchset: Anomie; "(bug 41889) Fix $.tablesorter explodeRowspans" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/34104 [17:51:58] New review: Anomie; "PS8: Rebased" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/34104 [17:56:20] New patchset: Anomie; "Hook to allow manipulation of image data" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/32189 [17:57:34] New review: Anomie; "Trivial whitespace fix, and minor cleanup to commit message." [mediawiki/core] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/32189 [17:58:05] New patchset: Dereckson; "Update CREDITS" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/40086 [17:58:06] New patchset: Alex Monk; "(bug 38633) Don't block non-existent users via the API" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39860 [18:01:33] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/32189 [18:07:10] 03(mod) Separate link class for anonymous users - 10https://bugzilla.wikimedia.org/43179 minor->15enhancement; +comment (10Dereckson) [18:07:10] 03(mod) Adding CSS semantic classes to changes list - 10https://bugzilla.wikimedia.org/40072 (10Dereckson) [18:09:11] New patchset: Jarry1250; "Make the PNG thumbnail update live" [mediawiki/extensions/TranslateSvg] (master) - https://gerrit.wikimedia.org/r/39380 [18:12:05] 03(NEW) Wikitext not parsed in nocreatetext message - 10https://bugzilla.wikimedia.org/43366 minor; MediaWiki extensions: SemanticForms; () [18:13:07] 03(NEW) formlink with popup broken - 10https://bugzilla.wikimedia.org/43367 major; MediaWiki extensions: SemanticForms; () [18:16:48] 03(mod) Separate link class for anonymous users - 10https://bugzilla.wikimedia.org/43179 +comment (10Steve) [18:21:39] New patchset: Yaron Koren; "Added Greek translations, by Protnet" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/40093 [18:23:28] 03(mod) Ogg files stammer - 10https://bugzilla.wikimedia.org/40590 +comment (10Juan de Vojníkov) [18:28:20] Change merged: Yaron Koren; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/40093 [18:36:41] 03(NEW) Remind to visit the page while logged in! - 10https://bugzilla.wikimedia.org/43368 trivial; MediaWiki: Watchlist; () [18:39:45] New patchset: Jarry1250; "(bug #32987) The language used to render SVGs should be definable" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25838 [18:42:47] 03(NEW) UploadWizard Flickr and “You are already uploading the file” - 10https://bugzilla.wikimedia.org/43369 normal; MediaWiki extensions: UploadWizard; () [18:44:39] 03(mod) UploadWizard Flickr and “You are already uploading the file” - 10https://bugzilla.wikimedia.org/43369 +comment (10Jean-Fred) [18:46:02] New review: Dereckson; "Gerrit doesn't offer drafts scoring." [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/40080 [18:46:22] 03(mod) The language used to render SVGs should be definable - 10https://bugzilla.wikimedia.org/32987 (10Jesús Martínez Novo (Ciencia Al Poder)) [18:50:21] 03(mod) Echo doesn't work on SQLite - 10https://bugzilla.wikimedia.org/41987 +comment (10Dereckson) [18:52:43] hi [18:53:21] i'm writing an extension [18:53:51] what is the right method to link to an php-file insite my extension folder? [18:57:50] absolute path /mediawiki/extensions/FooBar/test.php dont work in every environment [18:59:39] lbenedix: try using $IP/extensions/FooBar/test.php? [19:00:17] New review: Matmarex; "+/-0 because a) I didn't run the code, just read it b) it still has some IE-related issues as noted ..." [mediawiki/extensions/TranslateSvg] (master) C: 0; - https://gerrit.wikimedia.org/r/39380 [19:00:51] New review: Matmarex; "(Also, I didn't look at PHP code at all.)" [mediawiki/extensions/TranslateSvg] (master) C: 0; - https://gerrit.wikimedia.org/r/39380 [19:02:01] still get a 404 [19:02:24] in a plain mediawikisetup it works great [19:02:27] but not with https://github.com/SilkeMeyer/wikidata-vagrant [19:05:07] ah, you mean to link, not to include [19:05:20] its included [19:06:11] in the extension i create a form and i need the path for the action="test.php"-attribute [19:06:13] you shouldn't get a 404 if a included PHP class /code isn't found, but a warning or a fatal [19:06:22] New review: Siebrand; "Right. I missed it was a draft." [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/40080 [19:07:17] 03(mod) #formlink|link type=button does not work with ugly urls - 10https://bugzilla.wikimedia.org/43360 +comment (10Niklas Laxström) [19:07:53] lbenedix: I don't think that changing the action of the form is the way to go. Why not create a new "action" parameter for the index.php and handle it? like "index.php?action=yourextension" [19:08:30] sounds interesting [19:09:26] lbenedix: or if the form is in a special page, posting over the special page title should give you full control over it already [19:10:08] no, the form is inserted into a article-page via javascript [19:10:41] i thougt i [19:10:56] 'll put the handler for the post-request into the extensions folder [19:11:21] lbenedix: if you want to go through the new action, you can see examples here http://www.mediawiki.org/wiki/Category:Page_action_extensions . Extension:CreateBox is a simple one [19:11:51] it adds action=create IIRC [19:13:54] actually, I don't know why there are so many extensions listed on that category. Extension:WikEd, really? [19:14:08] that should be wrong [19:19:11] i added the CreateBox extension [19:22:15] New patchset: Ryan Lane; "Remove nova credential check for ssh key form" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/40094 [19:22:17] No test for DatabaseUpdater class. [19:22:28] Super... [19:22:40] Change merged: Ryan Lane; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/40094 [19:25:37] how do i test the createbox-extension? [19:26:35] If anyone's active right now, I'm trying to figure out how to display the logged in user's name in a skin PHP file. Is this possible? [19:26:42] :WHOIS daemon [19:26:50] Hello immewnity. [19:27:16] Yes, this is possible. The good question is how. [19:28:12] I've been trying to figure out how to use getName, but as a PHP newbie, I haven't the slightest idea how. [19:28:26] By the way, you already have an indice this is possible: you already have this information printed in the top right corner. [19:28:52] 03(NEW) Add request for shell at registration time - 10https://bugzilla.wikimedia.org/43370 normal; MediaWiki extensions: OpenStackManager; () [19:29:27] The issue there is, it's part of personal tools, and I can't figure out how to either duplicate it or separate it. [19:29:49] hi [19:29:53] Hi Oren_Bochman [19:30:13] any one know about "tags" in the API [19:30:18] hi Oren_Bochman [19:30:29] ;-) [19:30:32] 03(mod) #formlink|link type=button does not work with ugly urls - 10https://bugzilla.wikimedia.org/43360 +comment (10Yaron Koren) [19:30:38] how are you? [19:30:52] I've been better [19:30:57] lbenedix: place an empty on any page (when the extension is installed). It should create an inputbox and when you enter an article name on it and hit the submit button you'll end on an action=create page [19:31:17] oh [19:31:28] would you like some herring? [19:31:49] no 10x [19:31:51] immewnity: you have to get the context object (a lot of class, like SpecialPage already even have a getUser method to directly gives you the user object) [19:32:10] immewnity: Skin also has that [19:32:10] Vulpix: i end up with: /index.php?title=Test&action=edit&prefix=&preload=&editintro=§ion= [19:32:21] 03(NEW) Allow non-admins to give out shell access - 10https://bugzilla.wikimedia.org/43371 normal; Wikimedia Labs: Infrastructure; () [19:32:58] So, if I have Skin::getName(); ?>, would that work? I have a feeling no. [19:33:01] lbenedix: my bad! I though it added action=create :( [19:34:14] immewnity: if you already have a $wgUser object, I guess the solution is $wgUser->getName() [19:34:21] Vulpix: yes, it does, but there might be some redirection [19:34:25] According http://svn.wikimedia.org/doc/classUser.html [19:34:55] On the page, there is no $wgUser. I got that from User.php, which had it defined earlier. Is there a way to retrieve this object from User.php? [19:35:06] Vulpix: i want to send some data via post to a php-file that writes that data to the database [19:35:16] Oren_Bochman: oh no fish? [19:35:24] immewnity: your page main class herits from which other class? [19:35:36] (it would help if you put your current code on pastebin by the way) [19:35:37] Vulpix: the createbox just creates the url to add a new page [19:36:04] I just eat some Humus - my own recipie [19:36:34] Dereckson: I'm editing the template file for the skin, a modified version of Vector.php [19:36:45] Will put in pastebin in a section. [19:37:09] ok, so you inherits from SkinTemplate [19:37:20] lbenedix: Do you have to display any content on the page for that URL? [19:37:29] no [19:38:18] Dereckson: http://pastebin.com/va3KPqLG [19:38:18] immewnity: try $this->getSkin()->getUser()->getName() [19:39:23] Dereckson: That results in no error, but no content - fully blank. [19:39:30] (well, the section is blank) [19:39:49] immewnity: http://www.mediawiki.org/wiki/Manual:How_to_debug [19:41:14] Still doesn't generate content. (when I say blank, the page renders, just nothing results from the code) [19:42:24] 03(NEW) Upon initial registration keystone credentials aren't fetched - 10https://bugzilla.wikimedia.org/43372 normal; MediaWiki extensions: OpenStackManager; () [19:43:22] Since it's regarding the logged in user's name, this probably won't help much, but a live example is here (result should show at top right): http://www.pidgi.net/wiki/index.php?title=Main_Page&useskin=metrolook [19:44:13] Templates are cached. [19:44:33] try something like .../index.php?title=Main_Page&action=purge [19:44:50] That will read again your skin file and so you will see your modifications. [19:45:14] If you have a few minutes, I'm doing a test on Vector.php, I think the best way would be get relevant user -> getname [19:46:01] Nah, it's not the cache. I have all the time needed; I'm hoping to launch this new layout on Christmas, but if this doesn't work, it's not too big of a deal. [19:47:00] Wazza getSkin()->getRelevantUser() ?>! works [19:48:14] So, getSkin()->getRelevantUser(); ?> should theoretically work? [19:48:40] No. You only will call the function. [19:49:10] From there, then, would getName be added? [19:49:12] You want to print it, so it's: getSkin()->getRelevantUser(); ?> [19:49:33] this isn't absolutely necessary, but it's a good idea [19:49:35] I feel completely stupid for forgetting echo. That was probably my problem all along. [19:49:42] Oren_Bochman: okay [19:49:54] ttl [19:49:59] In PHP 5, when you echo directly an object, it calls a specific method, toString, to determine what to print. [19:50:35] Actually, it still isn't showing anything. [19:50:47] if you look ./includes/User.php you'll see there is a function __toString() which do "return $this->getName();" [19:51:03] so echo $this->getSkin()->getRelevantUser() or echo $this->getSkin()->getRelevantUser()->getName() are equivalent [19:51:16] Try with an URL finishing by &action=purge [19:51:43] Purging the cache still yields nothing. [19:51:49] (I mean right click on the edit url > copy link > and replace &action=edit by &action=purge) [19:52:01] Yes, I'm doing so. [19:52:02] You're logged in? [19:52:13] Yes. [19:52:16] http://www.pidgi.net/wiki/index.php?title=Main_Page&useskin=metrolook&action=purge [19:52:18] because getName while logged off returns a blank line [19:52:25] I am logged in, yes. [19:52:53] (unless personal tools is showing my options while logged out, in which case, bigger problems would be at hand!) [19:53:07] Could you update http://pastebin.com/va3KPqLG with the current code? [19:53:08] is there api for making diff links ? [19:53:50] Oren_Bochman: look in includes/diff [19:54:19] hi [19:54:20] (or somewhere in the code such a link is generated like the page history maybe) [19:54:41] i mean the javasctipt api [19:56:26] Oren_Bochman: in resources/mediawiki.action/mediawiki.action.history.js I see some diff-related stuff [19:56:42] @Dereckson: To make sure it isn't cache, I replaced getSkin()->getRelevantUser(); ?> with dummy text, which did display. [19:56:51] 10x [20:02:34] 03(NEW) CTRL+Click on "Feedback from my watched pages �" should open the link in a new tab - 10https://bugzilla.wikimedia.org/43373 normal; MediaWiki extensions: ArticleFeedbackv5; () [20:07:02] immewnity: I tested on http://mediawiki.dereckson.be/ I don't know why, but I get inconsistent results with getRelevantUser [20:07:20] getSkin()->getUser()->getName(); ?> works. [20:07:52] 03(mod) Flickr sets not uploading - 10https://bugzilla.wikimedia.org/43320 +comment (10Jean-Fred) [20:08:13] 03(mod) UploadWizard Flickr and “You are already uploading the file” - 10https://bugzilla.wikimedia.org/43369 +comment (10Jean-Fred) [20:08:16] 03(mod) Flickr sets not uploading - 10https://bugzilla.wikimedia.org/43320 +comment (10Jean-Fred) [20:08:26] 03(mod) South Azerbaijani (azb)'s fallback language is English but in some cases it changes to Persian - 10https://bugzilla.wikimedia.org/43318 -shell +i18n; +comment (10Robin Pepermans (SPQRobin)) [20:08:39] Dereckson: It's still returning nothing. I'm stumped. [20:08:49] (also, switched clients, hence the 2) [20:17:59] New patchset: Alex Monk; "(bug 38633) Don't block non-existent users via the API" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39860 [20:18:07] immewnity2: pastebinyoursource code? [20:18:16] Gah,spacebarnotworkingagainIsee [20:18:30] http://pastebin.com/va3KPqLG [20:19:11] Changed since that paste is getName(); ?> to getSkin()->getUser()->getName(); ?> [20:20:28] 03(mod) Internal extension description outdated - 10https://bugzilla.wikimedia.org/43337 (10Nemo) [20:20:31] 03(mod) Documentation is out of date, incomplete (tracking) - 10https://bugzilla.wikimedia.org/1 (10Nemo) [20:20:33] 03(mod) Interface messages needing rewording or documentation and other issues with existing messages (tracking) - 10https://bugzilla.wikimedia.org/38638 (10Nemo) [20:20:43] Jarry1250: Here's an update paste: http://pastebin.com/7YGdT2K2 [20:21:21] immewnity2: Try $this->skin->getUser()->getName(); [20:23:31] Jarry1250: Fatal error: Call to undefined method MetrolookTemplate::skin() in /home/pidginet/pidgi.net/wiki/skins/Metrolook.php on line 271 [20:23:43] Metrolook.php is the skin name. [20:23:45] Yup, just having a play, one sec. [20:23:48] (well, Metrolook, that is) [20:28:39] hi [20:29:27] how can I add this web to spamblacklist? [20:29:30] http://www./index.php?do=/blog/2994/seo-services-can-convert-your-website-in-to-something-amazing/ [20:30:09] 03(mod) South Azerbaijani (azb)'s fallback language is English but in some cases it changes to Persian - 10https://bugzilla.wikimedia.org/43318 +comment (10Nemo) [20:31:04] immewnity2: $this->getUser()->getName(); ? [20:31:19] ganimedes: The Wikimedia SpamBlacklist or that of a different site? [20:31:21] New patchset: MrBlueSky; "(bug 40588) LinkSearch cannot search with a port in the url" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/28908 [20:31:43] Jarry1250: Fatal error: Call to undefined method MetrolookTemplate::getUser() in /home/pidginet/pidgi.net/wiki/skins/Metrolook.php on line 271 [20:31:46] I've got a wiki [20:32:08] New review: MrBlueSky; "* Make sure things don't break if wfParseUrl() fixes any malformed parts as noted by Lwelling (curre..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/28908 [20:32:23] ah, no,, sorry, wrong channel [20:32:28] buffff [20:32:33] sorry, sorry [20:32:35] ganimedes: "www\." [20:32:36] ganimedes: Ah, well it loads from MediaWiki:Spamblacklist [20:32:44] on my config anyway. [20:32:47] but that isn't a valid URL BTW [20:33:07] yes, but i'm spamming with that [20:34:52] immewnity2: Oh, $this->getRelevantUser() perhaps. [20:35:44] Jarry1250: Go figure, here's the result. Fatal error: Call to undefined method MetrolookTemplate::getRelevantUser() in /home/pidginet/pidgi.net/wiki/skins/Metrolook.php on line 271 [20:37:55] Oh, my bad. I mean $this->skin->getRelevantUser() - or did I try that permutation already? [20:38:19] * $this->skin->getRelevantUser()->getName() [20:38:30] I don't believe so, but I'm going to guess what the result will be... [20:39:07] Oh, different error! [20:39:24] Jarry1250: Notice: Trying to get property of non-object in /home/pidginet/pidgi.net/wiki/skins/Metrolook.php on line 271 [20:42:46] New patchset: Dereckson; "New methods to drop or rename extension index in DatabaseUpdater" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39169 [20:45:06] immewnity2: skin->getUser()->getName(); ?> works for me. [20:45:18] Now I'vebothered to download your code and run it myself: [20:45:20] * :P [20:46:30] Thanks, lol. Even /that/ gives an error, though a different error. Notice: Undefined property: User::$getName in /home/pidginet/pidgi.net/wiki/skins/Metrolook.php on line 271 [20:47:18] (also, the code will probably be horrendous without the CSS modifications, so I apologize!) [20:47:29] immewnity2: what version of MediaWiki do you use? [20:47:42] I'm on 1.19.1 [20:47:57] I guess we tested on 1.21. [20:48:29] That could be why. I'll see if I could update to 1.21, but there's a lot of custom code that I'll have to add back later. [20:48:31] Jarry1250: what's your wiki version? [20:49:01] immewnity2: I could also look 1.19 documentation, to check the correct properties and methods to use. [20:49:06] 1.21git [20:49:34] But we don't have legacy API documentation on http://svn.wikimedia.org/doc/ [20:49:42] Dereckson: That would be great. Else, I could keep going deeper into the custom code hole and attempt to make the necessary modifications. [20:49:56] I'll see if I can upgrade. [20:50:29] immewnity2: you should do custom code as extensions to make upgrading easier [20:51:22] p858snake: I probably should. Thing is, I wasn't documenting any changes I did, so I guess this upgrade will show what breaks. I'll make extensions from there, I suppose. [20:53:33] 03(mod) Enable WebFonts on the Javanese projects - 10https://bugzilla.wikimedia.org/43359 +comment (10bennylin) [20:53:49] Would a wmf build be the most stable to use? [20:54:46] 03(mod) Allow WebFonts to be loaded but disabled by default. - 10https://bugzilla.wikimedia.org/43297 +comment (10bennylin) [20:55:22] immewnity2: MW1.20 is recommended [20:55:41] I won't loose the functionalities that would be needed for this with 1.20? [20:56:05] *lose [21:11:51] I want to have a numbered list with several paragraphs interspersed with bullet points [21:12:07] these several paragraphs and bullet points are part of one numbered list item [21:12:40] the tricky part is I want to have paragraphs both _before_ and _after_ the bullet points [21:15:11] Jarry1250 and Dereckson: Updated to no avail. [21:17:23] 03(NEW) Temporary fatal error when trying to delete a page - 10https://bugzilla.wikimedia.org/43374 normal; MediaWiki: Page deletion; () [21:19:22] immewnity2: I'm repairing my Git repository, I messed it cp -Rp a symbolic link instead the directory before trying to get 1.19 [21:20:04] (long answer for "brb") [21:21:38] Ok. So you're now on 1.20 or 1.21? [21:21:53] New patchset: Alex Monk; "(bug 43282) Add per-namespace restrictions and rights to Special:ListGroupRights" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/40096 [21:21:55] 1.20.2 [21:22:08] 03(mod) Add per-namespace restrictions and rights to Special:ListGroupRights - 10https://bugzilla.wikimedia.org/43282 +comment (10Krenair) [21:22:10] !queue [21:22:11] Ambiguous! Try !reviewqueue, !jobqueue, or !deploymentqueue. [21:22:18] !jobqueue [21:22:18] The Job Queue is a way for mediawiki to run large update jobs in the background. See http://www.mediawiki.org/wiki/Manual:Job_queue [21:25:43] Wait, got it to work now. [21:25:58] The winning code: getSkin()->getUser()->getName(); ?> [21:26:30] Nice. [21:26:38] New patchset: Alex Monk; "(bug 43282) Add per-namespace restrictions and rights to Special:ListGroupRights" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/40096 [21:26:42] 03(mod) Temporary fatal error when trying to delete a page - 10https://bugzilla.wikimedia.org/43374 +comment (10Max Semenik) [21:26:54] Thank you all for the help! [21:27:09] immewnity2 - Since usernames can't contain '<', that's probably ok. Still, it would be better to escape that. [21:27:12] You're welcome. [21:27:25] Then we can be 100% sure it's ok. [21:28:07] 03(mod) Temporary fatal error when trying to delete a page - 10https://bugzilla.wikimedia.org/43374 normal->major (10Max Semenik) [21:28:31] anomie: PHP newbie here. What do you mean by escaping it? Adding \< somewhere? [21:29:29] immewnity2, https://www.mediawiki.org/wiki/Cross-site_scripting [21:29:48] immewnity2 - Use htmlspecialchars(), as in getSkin()->getUser()->getName() ); ?>. See https://www.mediawiki.org/wiki/XSS for details. [21:30:11] Ah, okay, thank you. [21:31:34] 03(mod) Temporary fatal error when trying to delete a page - 10https://bugzilla.wikimedia.org/43374 (10Snowolf) [21:38:11] MatmaRex: ping [21:44:13] Jarry1250: pong [21:44:37] MatmaRex: Ah, just to say thank you for your JS comments [21:44:52] I particularly loved the bit where you said "I know it's not your code but" [21:45:09] *ahem* [21:45:11] :p [21:45:34] oh, is that your code? :P [21:45:42] All of it. Well, after review. [21:45:51] Mark ended up rewriting most of it :p [21:47:17] haha, sorry :P i just looked at the patchset [21:51:47] MatmaRex: Anyway, I took most of your advice, and it definitely works (you can register at http://translatesvg.wmflabs.org and try it out in fact) [22:03:14] 03(mod) Add localised logos for Wiktionaries without one - 10https://bugzilla.wikimedia.org/43240 +comment (10Nemo) [22:03:48] 03(mod) Add localised logos for Wiktionaries without one - 10https://bugzilla.wikimedia.org/43240 (10Nemo) [22:09:48] New patchset: Dereckson; "Add DROP INDEX support to DatabaseSqlite::replaceVars method" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/40281 [22:13:32] As the wiki administrator can I sftp images for use on my wiki, without enabling file uploads for others? [22:14:22] Yes, we have a script for that. [22:14:43] There is also a more convenient way: restrict the upload right to an uploader group or to the sysop group. [22:14:49] So you can directly upload from wiki. [22:15:51] I have a question about our test infrastructure. [22:16:32] https://gerrit.wikimedia.org/r/#/c/40281/ amends an existing test. [22:16:51] phpunit tested my change against tests in master or tests in by branch? [22:16:53] (my) [22:18:24] it'll do it on master as you're using master with a topic branch [22:18:55] 03(mod) South Azerbaijani (azb)'s fallback language is English but in some cases it changes to Persian - 10https://bugzilla.wikimedia.org/43318 +comment (10Arjanizary) [22:20:18] ... [22:24:32] New review: Dereckson; "This change has been tested with the following code:" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/40281 [22:26:25] Okay, another question for another changeset. [22:26:42] https://integration.mediawiki.org/ci/job/mediawiki-core-phpunit-misc/580/console -> PHP_Invoker_TimeoutException: Execution aborted after 2 seconds [22:26:52] I would like to run tests again for this change. [22:27:14] But on Jenkins, trigger a new test run doesn't work anymore. [22:28:29] So https://integration.mediawiki.org/ci/gerrit_manual_trigger/ [22:28:33] Dereckson: post a review with 'reckeck' [22:28:36] recheck* [22:28:39] Query for 39169, select PS3 [22:28:40] in the "body" [22:28:51] "Trigger selected" and it comes up with "No jobs triggered for this event" what [22:28:51] 03(mod) South Azerbaijani (azb)'s fallback language is English but in some cases it changes to Persian - 10https://bugzilla.wikimedia.org/43318 +comment (10Dereckson) [22:29:04] (i only know that because i saw somebody do it :/ ) [22:29:05] 03(mod) South Azerbaijani (azb)'s fallback language is English but in some cases it changes to Persian - 10https://bugzilla.wikimedia.org/43318 +comment (10Dereckson) [22:29:42] Krenair: this is probably linked with the tests disabling for security measures [22:30:18] probably... [22:30:25] Though we are whitelisted, so wtf? [22:31:05] New review: Matmarex; "recheck" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/39169 [22:31:17] Dereckson: ^ [22:31:39] It worked [22:31:40] you already posted this review [22:31:49] That trick should be documented somewhere [22:32:07] as i said, i only know that because i saw somebody do it :/ [22:32:10] Thank you Matma Rex. [22:33:07] Dereckson: about bug 43318: the bug was closed, he seems to be fine with it, so it's not really necessary to reply :) [22:33:08] Good. So now I've everything I need in the core for my indexes rename patches. [22:33:30] SPQRobin: sure, people submits bugs only to be happy with "no we won't fix that" replies... [22:34:23] There is an element in the bug report, who annoys me: ""If the fallback language is Persian it makes finding and translating that entry to South Azerbaijani difficult."" [22:34:48] That could mean people with South Azerbaijani as mother tongue don't speak Persian. [22:35:09] If this last statement is verified, fallback should be removed. [22:35:37] Dereckson: South Azerbaijani speakers do speak Persian, he means that it's easier to find which message to translate when he sees it in English [22:35:47] Oh! [22:36:05] maybe I should make him aware of uselang=qqx [22:37:06] New patchset: Alex Monk; "(bug 37120) Fix slightly broken behaviour with suppressed revisions on Special:Undelete" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/40283 [22:38:04] New review: Alex Monk; "Found this commit sitting around on a branch in my core repository, so be warned it might be horribl..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/40283 [22:38:37] 03(mod) Special:Undelete on suppressed revisions - 10https://bugzilla.wikimedia.org/37120 +comment (10Krenair) [22:38:55] "sitting around on a branch" lol [22:38:59] 03(mod) South Azerbaijani (azb)'s fallback language is English but in some cases it changes to Persian - 10https://bugzilla.wikimedia.org/43318 +comment (10Robin Pepermans (SPQRobin)) [22:40:01] 03(mod) South Azerbaijani (azb)'s fallback language is English but in some cases it changes to Persian - 10https://bugzilla.wikimedia.org/43318 +comment (10Robin Pepermans (SPQRobin)) [22:41:21] New patchset: Matmarex; "Remove everything related to nonexistent $wgExcludeFromThumbnailPurge" [mediawiki/extensions/Configure] (master) - https://gerrit.wikimedia.org/r/40284 [22:43:31] New review: Matmarex; "I'm writting myself a script that checks consistency and that will eventually allow me to sync every..." [mediawiki/extensions/Configure] (master) C: 0; - https://gerrit.wikimedia.org/r/40284 [22:44:13] New review: Hoo man; "This should probably use the hooks which will be introduced in https://gerrit.wikimedia.org/r/39781 ..." [mediawiki/extensions/CentralAuth] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/38895 [22:46:56] SPQRobin: that remembers me I wanted to make a little change in French translation from Special:Version, I've found what I need without UTSL. Thanks for the qqx tip. [22:47:39] :) [22:48:16] [[Special:Version]] in French used SiteMatrix (Version 1.2) [22:48:30] Version has to be in lowercase. [22:49:10] New review: Hoo man; "Sadly not, no (that's why I said that it would result in ugly code)." [mediawiki/extensions/AbuseFilter] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/38731 [22:50:04] People interested by [[Special:Version]] output -> there is a bug to amend the interface: https://bugzilla.wikimedia.org/show_bug.cgi?id=43354 [22:52:02] 03(mod) [Enhancement] SpecialVersion.php: version info: in addition to SHA hashes, please show also the date (perhaps more info) - 10https://bugzilla.wikimedia.org/43354 +comment (10Dereckson) [22:53:05] Dereckson: I didn't read it thoroughly but at first sight it seems to be a duplicate of https://bugzilla.wikimedia.org/show_bug.cgi?id=38783 [22:55:46] 03(mod) Add git date to Special:Version - 10https://bugzilla.wikimedia.org/38783 +comment (10Dereckson) [22:57:10] 03(mod) [Enhancement] SpecialVersion.php: version info: in addition to SHA hashes, please show also the date (perhaps more info) - 10https://bugzilla.wikimedia.org/43354 +comment (10Dereckson) [22:57:11] 03(mod) Add git date to Special:Version - 10https://bugzilla.wikimedia.org/38783 +comment (10Dereckson) [22:59:27] 03(mod) Add git date to Special:Version - 10https://bugzilla.wikimedia.org/38783 +comment (10Dereckson) [22:59:33] https://gerrit.wikimedia.org/r/#/c/17333/ could very easily be resuscitated [23:01:13] New review: Dereckson; "The next time you need proper l10n advices, please add Siebrand or Nikerabbit as reviewers." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/17333 [23:01:59] We'll see if DaSch moves. If not, I will res that. [23:05:13] New patchset: Alex Monk; "(bug 37120) Fix slightly broken behaviour with suppressed revisions on Special:Undelete" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/40283 [23:05:37] New review: Alex Monk; "I don't want to do that until it's at least merged into master." [mediawiki/extensions/CentralAuth] (master) C: 0; - https://gerrit.wikimedia.org/r/38895 [23:09:13] New review: Alex Monk; "trivial code style issue" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/39169 [23:10:30] Ugh I swear my 'review requests' list is two times the size of my 'started by me' list [23:13:27] New patchset: Dereckson; "New methods to drop or rename extension index in DatabaseUpdater" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39169 [23:14:28] Krenair: only two times? [23:14:33] New review: Dereckson; "Fixing style issue." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39169 [23:14:33] Krenair: https://gerrit.wikimedia.org/r/#/dashboard/417 [23:15:12] somebody really should start merging these bad boys :/ [23:15:38] your 'started by' list is small though - https://gerrit.wikimedia.org/r/#/dashboard/98 [23:18:32] Or maybe you just use small commit summaries [23:18:45] Krenair: oh, haha, you win [23:18:56] i rarely touch anything else than core [23:19:17] First line should be 65 chars max. [23:19:33] 03(NEW) EducationProgram: array_merge() expects at least 1 parameter, 0 given - 10https://bugzilla.wikimedia.org/43375 normal; MediaWiki extensions: EducationProgram; () [23:20:50] New patchset: Alex Monk; "(bug 18598) Maintenance script to migrate legacy Oversight data" [mediawiki/extensions/Oversight] (master) - https://gerrit.wikimedia.org/r/18229 [23:21:40] New patchset: Matmarex; "Add missing messages for $wgUpdateCompatibleMetadata" [mediawiki/extensions/Configure] (master) - https://gerrit.wikimedia.org/r/40285 [23:23:03] New patchset: Reedy; "Suppress warnings around copy call" [mediawiki/core] (wmf/1.21wmf6) - https://gerrit.wikimedia.org/r/40286 [23:23:17] Change merged: Reedy; [mediawiki/core] (wmf/1.21wmf6) - https://gerrit.wikimedia.org/r/40286 [23:23:33] New review: Matmarex; "As in I971ea7ad, I'm writting myself a script that checks consistency and that will eventually allow..." [mediawiki/extensions/Configure] (master) C: 0; - https://gerrit.wikimedia.org/r/40285 [23:27:05] Change merged: Reedy; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39861 [23:27:15] (ok tested on a 1280 screen, 65 chars could take two lines) [23:30:24] Change merged: Hoo man; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/39859 [23:30:43] 03(mod) Modifying an AbuseFilter results in HTML showing up in various logs - 10https://bugzilla.wikimedia.org/43105 +comment (10Marius Hoch) [23:39:50] New review: Alex Monk; "Bryan, you're shown as the author of this extension on https://www.mediawiki.org/wiki/Extension:Glob..." [mediawiki/extensions/GlobalUsage] (master) C: 1; - https://gerrit.wikimedia.org/r/34721 [23:43:36] New review: Alex Monk; "Actually Siebrand merged I413de822, so maybe he'll do this as well? :)" [mediawiki/extensions/GlobalUsage] (master) C: 1; - https://gerrit.wikimedia.org/r/34721