[00:00:46] 03(mod) The search box's 'title' argument is "Search Wikipedia" - 10https://bugzilla.wikimedia.org/40910 +comment (10Terry Chay) [00:00:46] 03(mod) Article Feedback - Increase Test Sample to 10% of English Wikipedia - 10https://bugzilla.wikimedia.org/37616 (10Terry Chay) [00:01:10] New patchset: Legoktm; "(bug 28362) add conditional article_views variable" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/38731 [00:01:30] hoo: ^ [00:02:55] back to getting the error.... [16:01:42.701] The stylesheet http://www.bestpracticeswiki.net/skins/twentyten/main.css?303 was not loaded because its MIME type, "text/html", is not "text/css". @ http://www.bestpracticeswiki.net/index.php?title=Main_Page&useskin=twentyten [00:04:24] 03(NEW) Accessing the download pages creates random HTTP 403 errors - 10https://bugzilla.wikimedia.org/43623 normal; Wikimedia: General/Unknown; () [00:04:28] I commented out those lines so now I have correct html: [00:04:29] [00:05:12] so it seems to be a problem with apache config or the mimetypes config [00:05:55] Hi. Extension:RSS is still in need of reviewers for outstanding unreviewed SVN-git migration changes in https://gerrit.wikimedia.org/r/#/c/3925/ [00:06:14] Is anyone willing to help and review, please? [00:11:24] Wikinaut: OK [00:11:56] ori-l: some "complaint" about too much changes. But it more a legacy problem [00:12:19] I mean, I was working hard, and then SVN was migrated to gerrit/git- [00:12:45] in the meantime I fixed some of the already reported minor problems like white space problems [00:12:51] we're migrating to mercurial in february, then darcs by june [00:12:55] the code as such works very well [00:13:03] just kidding. i'm reviewing. [00:13:12] pls. bear with me [00:13:16] thanks [00:13:29] anything especially tricky i should pay close attention to? [00:13:31] do I have to add you as reviewer ? [00:13:37] i've added myself [00:13:43] 03(NEW) Unable to delete Concept - 10https://bugzilla.wikimedia.org/43624 normal; MediaWiki extensions: Semantic MediaWiki; () [00:14:06] ori-l: not special. Perhaps the no-proxy issue, let me explain [00:14:20] Wikinaut: sure, please do [00:14:29] The extension must be able -when the mediawiki runs in an intranet ... [00:14:43] to decide between the use of non-use of a proxy [00:14:50] this is working [00:15:00] but not everyone understood it well [00:15:10] 03(mod) Add a button to request a new fancy captcha (code) - 10https://bugzilla.wikimedia.org/14230 minor->15enhancement; +comment (10Ryan Kaldari) [00:15:19] perhaps I should improve the comments (documentation) [00:15:29] let me know [00:15:54] siebrand, Nikerabbit: can you look over the i18n changes in https://gerrit.wikimedia.org/r/#/c/3925/ (or find someone else to do it)? [00:16:45] ori-l: these appear to be okay [00:16:58] appear to whom? :) [00:17:09] -> me [00:17:30] I need their help with that because there is a lot of i18n trivia and lore I'm still not aware of [00:18:07] I am running the latest version (i.e. https://gerrit.wikimedia.org/r/#/c/3925/ ) in my production systems [00:18:50] 03(mod) Update Wikivoyage logo where applicable - 10https://bugzilla.wikimedia.org/43565 +comment (10This, that and the other) [00:19:06] ori-l: bye for tonight (Berlin local time 01:20) [00:19:20] Wikinaut: tschuss [00:19:35] :-) [00:36:00] 03(mod) Accessing the download pages creates random HTTP 403 errors - 10https://bugzilla.wikimedia.org/43623 (10Andre Klapper) [00:43:40] 03(mod) Remove ability-to-remove-bureaucrat from en.wiktionary bureaucrats - 10https://bugzilla.wikimedia.org/42113 (10msh210) [00:45:32] night [00:54:42] 03(mod) Make it possible to rename users - 10https://bugzilla.wikimedia.org/40061 (10Gabriel Wicke) [01:00:47] Change abandoned: Bsitu; "(no reason)" [mediawiki/core] (wmf/1.21wmf7) - https://gerrit.wikimedia.org/r/42120 [01:01:05] Change abandoned: Bsitu; "(no reason)" [mediawiki/core] (wmf/1.21wmf6) - https://gerrit.wikimedia.org/r/42118 [01:02:51] did the notification system just went hawok? [01:03:01] erm. [01:03:18] I meant: Are there any known issues with notifications? [01:03:32] as I just got a really strange notification [01:04:39] Pages you started were cross referenced on MediaWiki - "Development policy/da, Coding conventions/da, Security for developers/da, Manual:Pre-commit checklist/da were linked by MediaWiki user Ribe, from this page: Developer hub/da" [01:04:56] I've never touched any of those pages [01:05:17] never visited them nor have added them to any watchlist [01:05:35] feature or bug? [01:11:46] StevenW: Volume of requests has gone down significantly. Thank you, sir! [01:13:21] 03(mod) Show Echo flyout scrollbar on hover - 10https://bugzilla.wikimedia.org/43439 +comment (10Ryan Kaldari) [01:13:50] Matthew_: awesome! [01:14:55] Does anyone know what version of ConfirmEdit I should use for MediaWiki 1.18 at where I can get that older version? It looks like I can't upgrade until my stupid hosting decides to let me or I do it manually file by file. [01:15:56] where should I report bugs for the mobile frontend? [01:17:50] AzaToth: in bugzilla.wikimedia.org under product "MediaWiki extensions" and component "MobileFrontend" [01:19:17] 03(NEW) Strange notification from mediawiki.org - 10https://bugzilla.wikimedia.org/43625 normal; Wikimedia: General/Unknown; () [01:19:21] andre__: ty [01:19:33] np [01:20:12] 03(mod) Strange notification from mediawiki.org - 10https://bugzilla.wikimedia.org/43625 (10Krenair) [01:20:37] Krenair: oh, it's echo? [01:20:41] didn't know [01:20:42] Yup. [01:20:45] Really new feature. [01:21:23] I see [01:21:23] Only been in master for 24 hours: https://gerrit.wikimedia.org/r/#/c/40756/ [01:21:32] Not sure why it's been deployed already... [01:22:55] bsitu, ^ [01:23:51] yeah, echo was just updated to master [01:24:12] 03(NEW) Cross-wiki full resolution file links lacks the File: prefix - 10https://bugzilla.wikimedia.org/43626 normal; MediaWiki extensions: MobileFrontend; () [01:24:28] I wonder why wikibugs suddenly lacks my "name" [01:24:36] For new bugs. [01:24:41] Parsing is more broken than usual. [01:24:44] Since the BZ upgrade. [01:24:55] ah [01:25:11] I remember reading that it actually parses the emails. Not sure if that's true (I hope it isn't...) [01:25:17] Yes. [01:25:25] It reads mail headers and the mail body. [01:25:29] "reads" [01:25:34] Krenair: I wonder if you are still using my old hack script [01:25:36] It claws at them with regexen. [01:25:47] AzaToth: Did you write wikibugs.pm? [01:25:59] I think that's the name of it. [01:26:02] I thought it was Tim. [01:26:14] I remember I did some work in it around 2006 [01:27:59] regarding bug 43626 I just filed. I really though it would have been reported allready, but I've not found any bugs relating to it at all... [01:28:19] as if you actually uses the mobile frontend, you can't miss it at all [01:28:27] unless you never open a image [01:28:32] ever [01:29:10] 03(mod) Global (to a wiki farm or family) message delivery (thoughts) - 10https://bugzilla.wikimedia.org/35306 +comment (10Ryan Kaldari) [01:29:17] thought it was going to be fixed last months or so [01:30:36] 03(mod) Respond with valid JS/CSS on redirects when using action=raw&ctype=text/css or action=raw&ctype=text/javascript - 10https://bugzilla.wikimedia.org/31827 (10MZMcBride) [01:30:38] no one using smartphones nowadays? [01:31:49] Hi. [01:32:28] erm... [01:32:30] hello... [01:32:37] *scratches heads* [01:32:59] AzaToth: I'll comment on that bug. [01:33:07] ty [01:33:37] 03(mod) Cross-wiki full resolution file links lacks the File: prefix - 10https://bugzilla.wikimedia.org/43626 +comment (10MZMcBride) [01:33:58] AzaToth: I'm not sure what the bug is about. [01:35:23] Oh, I see it. [01:35:32] That's fun. [01:36:36] I think it's a JS issue. [01:36:39] Maybe. [01:37:25] Feels like it. [01:37:53] Yeah. [01:38:26] New patchset: Bsitu; "limit article-linked notification to main namespace only" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/42211 [01:39:45] AzaToth: Yeah, got it. [01:39:49] AzaToth: Thanks for the bug report. :-) [01:40:02] heh [01:40:17] 03(mod) Cross-wiki full resolution file links lacks the File: prefix - 10https://bugzilla.wikimedia.org/43626 +comment (10MZMcBride) [01:40:26] AzaToth: I wrote a proper bug report in a comment for you. ;-) [01:40:53] I don't think it has to do with the File: prefix, really. [01:41:01] The JS is just simply broken, I think. It's hijacking a link it shouldn't be. [01:41:27] Well, there may be a File: prefix bug mixed in there, but it's just a symptom of the larger broken JS. [01:41:34] Susan: I see [01:41:53] Can you test the bug with JS disabled? [01:42:07] Change merged: Kaldari; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/42211 [01:43:30] It'd be cool to have a ParserFunction like {{integer}} that returns the next integer from 0 each time it's reached in a page. [01:43:36] So you could number table rows, for example. [01:43:43] It'd be easy to abuse though, I think. [01:44:33] Susan: take that up with TimStarling ツ [01:44:43] Heh. [01:44:45] New review: Hoo man; "mhm, I can check that... what about completely killing that code? The log entries are read from a te..." [mediawiki/extensions/CheckUser] (master) C: 0; - https://gerrit.wikimedia.org/r/40287 [01:44:48] AaronSchulz: ^ [01:44:50] Auto numbered in a table would be cool. [01:44:51] I think. [01:45:06] numbering, rather. [01:45:10] 03(mod) Strange notification from mediawiki.org - 10https://bugzilla.wikimedia.org/43625 +comment (10Ryan Kaldari) [01:45:31] 03(mod) Strange notification from mediawiki.org - 10https://bugzilla.wikimedia.org/43625 +comment (10Carl Fürstenberg) [01:45:39] oh, my name! [01:46:01] You're famous. [01:46:31] Susan: do you know if commons have mobilefrontend? [01:46:33] 03(mod) Strange notification from mediawiki.org - 10https://bugzilla.wikimedia.org/43625 (10MZMcBride) [01:46:52] AzaToth: http://commons.m.wikimedia.org/ [01:46:54] Creatively. [01:47:01] heh [01:47:03] I've never visited. [01:47:15] I usually load the full site on my phone. [01:47:18] Though I also disabled JS. [01:47:40] I'll add that as well as a bug. i.e. clicking on "description page here" leads to non-mobile version [01:48:04] 03(mod) Strange notification from mediawiki.org - 10https://bugzilla.wikimedia.org/43625 +comment (10Ryan Kaldari) [01:48:08] AzaToth: The underlying HTML is fine, I think. [01:48:23] possibly [01:48:25] AzaToth: It should be going to upload.wikimedia.org, right? [01:48:35] New patchset: Spage; "bug 43550: return failures from validate" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/41826 [01:48:55] 03(mod) Update Wikivoyage logo where applicable - 10https://bugzilla.wikimedia.org/43565 +comment (10Dereckson) [01:49:25] Susan: it should go to commons.m.w.o [01:49:31] logically [01:49:32] 03(mod) Update Wikivoyage logo where applicable - 10https://bugzilla.wikimedia.org/43565 +comment (10Dereckson) [01:49:43] AzaToth: I'm not sure which link you're referring to. [01:49:48] Oh. [01:49:57] New review: Spage; "I don't know how to add a qunit assertNotOkWithWarning( /Missing/ ) to test that validate both retu..." [mediawiki/extensions/EventLogging] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/41826 [01:49:59] "This is a file from the Wikimedia Commons. Information from its description page there is shown below. " [01:50:02] Right. [01:50:07] That's a separate bug. [01:50:11] yea [01:50:29] I thought you were still talking about the other bug. [01:50:30] Sorry. [01:50:42] heh [01:50:44] How are you, BTW? [01:50:46] Same old? [01:50:54] I haven't seen you around much. [01:51:32] you know, real life [01:52:00] New patchset: Alex Monk; "(bug 20850) Add global_user_groups variable to AbuseFilter" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/38895 [01:52:47] 03(mod) Strange notification from mediawiki.org - 10https://bugzilla.wikimedia.org/43625 +comment (10Ryan Kaldari) [01:53:01] AzaToth: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)/Archive_106#Twinkle-lite_for_nominating_pages_for_deletion.3F [01:53:51] It's official. At the FOSDEM, we'll have two rooms. One for LibreOffice, the other for Apache OpenOffice. [01:54:26] 03(mod) Update Wikivoyage logo where applicable - 10https://bugzilla.wikimedia.org/43565 +comment (10This, that and the other) [01:54:51] 03(NEW) the commons "description page here" link leads to non-mobile commons - 10https://bugzilla.wikimedia.org/43627 normal; MediaWiki extensions: MobileFrontend; () [01:55:17] 03(mod) the commons "description page here" link leads to non-mobile commons - 10https://bugzilla.wikimedia.org/43627 (10MZMcBride) [01:57:16] 03(mod) The search box's 'title' argument is "Search Wikipedia" - 10https://bugzilla.wikimedia.org/40910 (10Krenair) [01:57:16] 03(mod) Article Feedback - Increase Test Sample to 10% of English Wikipedia - 10https://bugzilla.wikimedia.org/37616 (10Krenair) [01:57:21] 03(mod) the commons "description page here" link leads to non-mobile commons - 10https://bugzilla.wikimedia.org/43627 +comment (10MZMcBride) [01:59:15] 03(mod) the commons "description page here" link leads to non-mobile commons - 10https://bugzilla.wikimedia.org/43627 +comment (10Carl Fürstenberg) [02:00:50] AzaToth: You don't get redirected from en.wikipedia.org to en.m.wikipedia.org on your phone? [02:01:04] There's some User-Agent sniffing that should auto-redirect you, I think. [02:01:32] It causes a fun bug where https://en.wikipedia.org will lead to the non-mobile site. [02:01:33] Susan: for wikipedia I'm getting redirect to mobile [02:01:37] Hmmm. [02:01:40] A third bug? [02:01:47] but not for commons when using that link at least [02:02:21] Hmm, yeah, Commons doesn't auto-redirect. [02:02:31] That's surprising. [02:02:56] I assume no one is using mobile phones now adays [02:03:11] everyone is fixed infront of their VT-100 terminals [02:03:12] Heh. [02:03:22] I'll file a bug about the redirect. [02:03:27] nice [02:03:34] You might enjoy . [02:04:10] hehe [02:05:58] regarding twinkle. you could always keep it enabled :-P [02:06:32] That's what that guy suggested. [02:06:36] ツ [02:06:40] Except it's fucking huge, slow, and adds a bunch of tabs. [02:06:48] 03(NEW) commons.wikimedia.org doesn't auto-redirect to mobile site on mobile devices - 10https://bugzilla.wikimedia.org/43628 normal; MediaWiki extensions: MobileFrontend; () [02:06:48] And a bunch of other links I don't want. ;-) [02:06:53] 03(mod) Update Wikivoyage logo where applicable - 10https://bugzilla.wikimedia.org/43565 +comment (10Dereckson) [02:07:25] AzaToth: If I forget to disable it after nominating a page for deletion, I quickly notice beacuse of the UI clutter. [02:07:34] hmm [02:07:39] slow computer? [02:07:40] [rollback] [rollback and kill] [rollback and poison] [02:07:54] hehe [02:07:58] Not really. But JS has been compounding for years. [02:08:18] If it were just Twinkle, it'd be one thing. But there's site, skin, and gadget JS to combat. [02:09:16] I assume you just want https://github.com/azatoth/twinkle/blob/master/modules/twinklexfd.js then [02:09:34] Well, I vaugely remembered that it was modular. [02:09:40] But I couldn't remember about morebit.js. [02:09:45] morebits.js * [02:09:48] 03(mod) Make it possible to rename users - 10https://bugzilla.wikimedia.org/40061 +comment (10Krenair) [02:09:57] I think I have an ancient version of morebits.js lying around. [02:10:06] * Susan eyes the bug summary. [02:10:22] that's usually bad to have ツ [02:10:50] Heh, yeah. [02:11:12] 03(mod) Make it possible to rename users in Gerrit - 10https://bugzilla.wikimedia.org/40061 summary (10MZMcBride) [02:11:33] terrrydactyl: for your branching question, Git is so flexible, and branches are so cheap you can really do what you want about branching. So every time you think "Hmmmm I need a branch", create it. [02:12:29] Dereckson: it's 'So every time you think "Hmmm, wonder what to do", create a branch' [02:13:12] terrrydactyl: personnally I like to develop with a combo of a master branch (the current code) and side branches for new features or bugfixes. Sometimes I add a production branch for a website. So it's more or less like flow or like the workflow offered on the Gerrit/Git workflow page. [02:13:27] but this is only a question of personal preference [02:13:29] Krenair: I've not been able to find any page linked on that page which I've edited [02:13:37] ok [02:14:14] The only think I'm sure is there is no definitive good way, like an ultimate truth for branching decisions. Experience, careful analysis of the needs and personal preferences are the 3 elements which matters the most. [02:14:15] could you put that on the bug please? [02:16:58] 03(mod) Strange notification from mediawiki.org - 10https://bugzilla.wikimedia.org/43625 +comment (10Carl Fürstenberg) [02:17:17] that makes sense. right now the branch i'm working out was used to clone a repository. i want to merge all these to the master branch and stop tracking changes in the remote repo. [02:18:13] AzaToth, Ryan Kaldari should be able to look into this issue better than I can [02:18:54] Krenair: sorry, mixed up Krenair and Kaldari in my head [02:19:05] Hah, I thought that's what had happened :) [02:19:07] * AzaToth hides from the shame [02:19:16] At least it's not Krenair and Krinkle [02:19:21] hehe [02:19:45] "Krenair", sounds like a aeroplane company [02:19:51] heh [02:23:24] New review: Mattflaschen; "I don't think you can directly (without doing your own catch). But you can make wrapper functions l..." [mediawiki/extensions/EventLogging] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/41826 [02:34:55] New review: Hoo man; "I've tested this new version of the change now:" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/42037 [02:38:47] 03(mod) [regression] wgMonthNames and wgMonthNamesShort are in the wrong language on JavaScript pages - 10https://bugzilla.wikimedia.org/41468 +comment (10Huji) [02:39:22] am I able to make an edit request here? [02:40:23] to which page? [02:40:35] http://www.mediawiki.org/wiki/MediaWiki:Newarticletext [02:41:16] there's two "in"s in "Just go back to the previous page in in your browser" [02:41:36] New review: Mattflaschen; "I just realized it won't work since it will never return due to the throws." [mediawiki/extensions/EventLogging] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/41826 [02:43:10] there should be one, but I can't change it since it's an interface page [02:45:47] hello? [02:56:08] Hello ihaveamac. [02:56:15] How can we help you? [02:56:23] oh [02:56:27] Oh, I've seen your question. [02:57:00] it was an edit request, but I decided to go and ask on IRC [02:57:09] Krenair: ihaveamac has seen a typo on [[MediaWiki:Newarticletext]]. [02:57:29] Just go back to the previous page *in in* your browser until you find yourself back home. [02:57:38] On which wiki? [02:57:39] Or in core? [02:57:54] on www.mediawiki.org [02:58:20] I can fix the typo if you provide a link. [02:58:23] http://www.mediawiki.org/wiki/MediaWiki:Newarticletext [02:58:49] What's the typo? [02:59:03] Oh. [02:59:05] I see it. [02:59:11] Reading is hard. [02:59:28] I notice a lot of small things [03:00:04] Fixed. [03:00:16] Thanks. :-) [03:00:20] If you want admin rights on that wiki, you can probably get them. [03:00:23] Dereckson: You for sure. [03:00:24] c: [03:00:37] I don't know about getting admin rights [03:00:40] ihaveamac: Do you edit Wikipedia? [03:00:50] Seems so. [03:00:59] I'm under a different name on wikipedia [03:01:02] since I got renamed [03:01:19] https://en.wikipedia.org/wiki/User:IXavier [03:01:26] yes [03:01:46] although I don't feel fit for administrator [03:02:10] I doubt you could do much damage on mediawiki.org, but all right. [03:02:46] Reedy: When you have a minute, can you make Dereckson an admin, please? https://www.mediawiki.org/wiki/Special:UserRights/Dereckson [03:04:41] Thank you Reedy. [03:05:08] beat me to it :p [03:05:25] Reedy: <3 [03:05:30] lol, it happened again ヾ [03:05:38] It? [03:06:07] "A page you started was cross referenced on MediaWiki" - "User talk:IXavier was linked by MediaWiki user IXavier, from this page: MediaWiki talk:Newarticletext" [03:06:28] Oh. [03:06:43] i don't get it I think [03:06:46] ihaveamac: so now I can answer you: if you see another thing to edit on mediawiki.org, yes you can report them here, it will be a pleasure fo fix them. Thank you to contribute to our wiki. [03:06:53] and User:IXavier is me [03:06:58] ok [03:07:18] there was no edit protected template on the wiki so I came here [03:07:24] 03(mod) Strange notification from mediawiki.org - 10https://bugzilla.wikimedia.org/43625 +comment (10Carl Fürstenberg) [03:07:26] AzaToth: Bizarre. [03:07:36] I wonder why it's you... [03:07:44] Are you user ID 1 or something? [03:07:49] lol no [03:23:32] New patchset: KarenEddy; "Patch7: Modified code to meet coding conventions" [mediawiki/extensions/BiblioPlus] (master) - https://gerrit.wikimedia.org/r/41914 [03:32:25] New review: Hoo man; "Minor code style issues, looks fine despite" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/42153 [03:38:31] three new pointless pages were created [03:38:50] http://www.mediawiki.org/wiki/Special:RecentChanges [03:39:23] ...they're gone already [03:56:06] 03(mod) Enable MicroDesign on it.wikivoyage - 10https://bugzilla.wikimedia.org/43523 +comment (10Emanuele Raoli) [04:04:25] New patchset: Yurik; "API Query smart-continue mode" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42070 [04:08:04] 03(mod) Add a button to request a new fancy captcha (code) - 10https://bugzilla.wikimedia.org/14230 +comment (10Dario Taraborelli) [04:10:47] 03(mod) Enable FlaggedRevs on plwiki for 3 more namespaces - 10https://bugzilla.wikimedia.org/43617 +comment (10Dereckson) [04:10:48] 03(mod) Enable FlaggedRevs custom configuration on Polish Wikipedia - 10https://bugzilla.wikimedia.org/16177 (10Dereckson) [04:10:55] anyone up for an api code review? https://gerrit.wikimedia.org/r/#/c/42070/ [04:11:33] warning: a very complex logic that required large unit tests :) [04:13:55] New review: CSteipp; "After talking with Hoo, this change causes the same group to identified if you pass in the group par..." [mediawiki/extensions/CentralAuth] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/41911 [04:23:10] 03(mod) Enable Labeled Section Transclusion's lsth on mediawiki.org - 10https://bugzilla.wikimedia.org/43612 (10Krenair) [04:25:41] ori-l: i updated http://www.mediawiki.org/wiki/User:Yurik/Installing_Linux_virtual_box_under_Windows_7 some more, let me know if you want me to contribute to the git [04:39:34] New patchset: Brent Garber; "Fix changes for Ia1878588 to work with databases that use non-integer timestamps." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42153 [04:40:53] New review: Brent Garber; "Also fixes the extra space before the comma on the previous line." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/42153 [04:45:04] yay! lets just get the wiki to email more crap to the users when they haven't subscribed for it. [05:10:23] morning folks! [05:13:41] Using 1.19.2, trying to access /wiki/api.php I keep getting redirected to /wiki/Api.php. If I try /wiki/api.php?action=query I get back "No such action". [05:13:57] is there anyway to confirm/deny that $wgEnableAPI is set to true? [05:15:38] uh why not echo it or something? [05:16:18] lile $poo = array(false => 'false', true => 'true') [05:16:28] echo $poo[$wgEnableAPI] [05:16:31] like* [05:16:35] I guess...i haven't been mucking with the .php code though...where's a good place to put it? [05:16:55] um... [05:16:58] localsettings? [05:17:14] Putting an echo in LocalSettings will show up?? [05:17:21] i dunno i've never tried it [05:17:23] do you have pretty urls set on? [05:17:32] don't mess with localsettings just yet [05:17:43] Skizzerz: not sure. is that in localsettings? [05:17:47] also, can you link to your wiki? [05:18:31] Skizzerz: what do you mean by "link to your wiki"? It is an internal company site, not externally accessible. [05:18:35] ah [05:18:39] are you the one that set it up? [05:19:15] (I meant "give a link to your wiki" but it seems that is not possible) [05:19:20] The answer there is complicated. Let's just say, I have set this one up in the past. I wasn't involved in the recent upgrade. [05:19:24] ok [05:19:39] from the above description, it looks like you have pretty urls set on [05:19:45] I have full access, and am willing to experiment a bit. [05:19:48] in your LocalSettings.php, do you have any mention of $wgScript [05:19:54] if so, what is the value set to? [05:20:10] checking... [05:20:14] er, $wgScriptPath [05:20:48] $wgScriptPath = "" [05:21:13] $wgArticlePath = "/wiki/$1" [05:21:15] ok [05:21:27] try just accessing /api.php (without the /wiki) [05:21:55] Ah, I see...that works. [05:22:13] awesome :) [05:22:23] That is, I get "This is an auto-generated MediaWiki API documentation page" [05:22:36] your wiki's files are in a different location (in this case the parent directory) of where you serve your wiki's "pages" from [05:22:52] there isn't anything wrong with that, in fact it is a recommended configuration to have the files and pages being served from two different places [05:22:59] so when they upgraded, they kept the same directory structure but looks like they changed the Docroot setting (or whatever IIS calls that thingy...) [05:23:02] just need to keep that in mind if you have need of accessing the files themselves [05:23:33] very cool. Thanks Skizzerz & Thai !! [05:23:52] i wasn't very helpful :( [05:23:53] Now just gotta change a few build scripts to point to the right URL :) [05:24:16] Is there a better way to do this? I accidentally imported a bunch of deleted stuff I didn't want. [05:24:22] delete from `text` where `old_id` in (select `ar_text_id` from archive);' [05:24:27] if you ever need to access index.php, it'd be in the same spot (e.g. /index.php instead of /wiki/index.php) [05:24:46] Thai: you gave me confidence that I wasn't completely lost :) [05:25:12] Isarra: that will be slow as all heck, but should work. can't think of anything more elegant atm [05:25:30] Skizzerz: cool. Thanks. Now I get what they've done. Going to diff my original LocalSettings & the new one a bit further :) [05:25:44] Skizzerz: How slow? [05:25:54] no idea [05:26:00] probably faster than your count [05:26:03] Would just leaving the text items there be problematic? [05:26:14] and no idea :) [05:26:21] >.> [05:26:30] Isarra: how big is archive? [05:26:30] Can you rename tables? [05:26:40] sure... [05:26:44] ~100k entries [05:27:10] Can you rename databases? [05:27:13] Then it won't be ridiculously slow. [05:27:28] Archive is fast. Text... isn't. [05:28:11] you could test it by replacing DELETE FROM `text`... with SELECT * FROM `text` ... See how long that takes. [05:28:38] (specify only a simple column rather than *) [05:29:00] Skizzerz: Will you be my brain and tell me how to rename archive to archive chicken? [05:29:12] My screen ain't big enough to hold that part of the documentation. [05:29:25] http://dev.mysql.com/doc/refman/5.0/en//rename-table.html [05:29:30] rename table archive to archive_chicken; [05:29:45] Thanks. [05:29:57] Skizzerz: thanks again! [05:30:03] you're welcome [05:30:34] Now how do I make a new archive? [05:30:46] Thinking things through has not been my strong suit today. [05:30:58] Nor has been not screwing up massively. [05:31:04] I wonder if these are related. [05:32:02] Oh, neat, can just copy it... [05:35:32] 03(mod) Create Wikisource Assamese - 10https://bugzilla.wikimedia.org/43129 +comment (10Bishnu Saikia) [05:46:38] ok [05:46:41] cool [06:00:01] 03(mod) Logo and Right menu on Urdu wikipedia are broader than other wikis - 10https://bugzilla.wikimedia.org/43468 +comment (10Muhammad Shuaib) [06:04:21] .config wgLogo urwiki [06:04:22] $stdlogo [06:06:18] 03(mod) Create Wikisource Assamese - 10https://bugzilla.wikimedia.org/43129 +comment (10Dereckson) [06:36:54] 03(mod) Languages are shown multiple times - 10https://bugzilla.wikimedia.org/43568 +patch-need-review; +comment (10Amir E. Aharoni) [06:57:13] New patchset: Amire80; "Allow preferences that need not be rendered in Special:Preferences" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/37395 [07:10:35] 03(mod) FlaggedRev installation requests (tracking) - 10https://bugzilla.wikimedia.org/29744 (10Dereckson) [07:10:35] 03(mod) Change in sqwiki for FlaggedRevs - 10https://bugzilla.wikimedia.org/42782 (10Dereckson) [07:10:42] 03(mod) FlaggedRevs for RU Wiktionary - 10https://bugzilla.wikimedia.org/33753 +comment (10Dereckson) [07:13:35] Change merged: Ori.livneh; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/42206 [07:14:00] New patchset: Ori.livneh; "Update .gitignore" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/42216 [07:15:57] 03(mod) Enable FlaggedRevs on plwiki for 3 more namespaces - 10https://bugzilla.wikimedia.org/43617 +patch-in-gerrit; +comment (10Dereckson) [07:15:57] 03(mod) FlaggedRev installation requests (tracking) - 10https://bugzilla.wikimedia.org/29744 (10Dereckson) [07:18:08] 03(mod) Accessing the download pages creates random HTTP 403 errors - 10https://bugzilla.wikimedia.org/43623 +comment (10Ariel T. Glenn) [07:43:47] 03(mod) Enable FlaggedRevs custom configuration on Polish Wikipedia - 10https://bugzilla.wikimedia.org/16177 (10Nemo) [07:43:49] 03(mod) FlaggedRev installation requests (tracking) - 10https://bugzilla.wikimedia.org/29744 (10Nemo) [07:48:57] Change merged: Ori.livneh; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/42216 [07:59:30] New patchset: Ori.livneh; "Do not consume trailing semicolon as part of URL" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/42220 [08:02:52] New review: Siebrand; "Test failure does not appear related to the patch set." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/37395 [08:13:25] New patchset: Amire80; "WIP: Improving saving feedback" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42086 [08:16:28] New review: Siebrand; "Shouldn't this be limited to those namespaces that have been designated as content namespaces, and n..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/42211 [08:19:43] 03(NEW) Not only NS_MAIN is a content namespace - 10https://bugzilla.wikimedia.org/43629 normal; MediaWiki extensions: Echo; () [08:28:42] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42127 [08:30:05] New patchset: Siebrand; "(bug 28085) Allow login with e-mail address" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42084 [08:30:31] 03(mod) Navigation/Toolbox side panel is not collapsible/expandable when being logged out - 10https://bugzilla.wikimedia.org/43227 +comment (10Andreas Plank) [08:33:51] New patchset: Amire80; "Improving saving feedback" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42086 [08:36:46] 03(mod) allow login with email as well as username - 10https://bugzilla.wikimedia.org/28085 +comment (10Siebrand) [08:36:54] New review: Siebrand; "PS4 updates the commit message to be compliant with https://www.mediawiki.org/wiki/Git/Commit_messag..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42084 [08:43:19] New review: Siebrand; "Is this in any way related to the Hanp extension (see bug 13712)?" [mediawiki/extensions/Josa] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/40773 [08:47:04] siebrand: yes it is [08:54:40] New patchset: Krinkle; "JSDuck: Generated code documentation!" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/42221 [08:58:35] New patchset: Amire80; "Add lang, dir and bidi-isolation to source and translation" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42222 [09:00:44] New review: Krinkle; "See a live example: http://integration.wmflabs.org/mwext-VisualEditor-docs/" [mediawiki/extensions/VisualEditor] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/42221 [09:03:06] New patchset: Amire80; "WIP: display description." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42099 [09:03:10] 03(NEW) set $wgAutoConfirmCount to 10 for fa.wikipedia - 10https://bugzilla.wikimedia.org/43630 normal; Wikimedia: Site requests; () [09:03:10] New patchset: Amire80; "Fix the wrapping of the language selector" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42074 [09:03:15] New patchset: Amire80; "WIP: Add support for message documentation in ULS" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/41935 [09:03:26] New patchset: Amire80; "Fix selector position when closing a translation row" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/36909 [09:03:40] New review: Siebrand; "Nice work. One remaining nit pick from my side." [mediawiki/extensions/GuidedTour] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/41374 [09:04:23] New patchset: Raimond Spekking; "Consistency tweaks in preparation for re-adding to Translatewiki.net" [mediawiki/extensions/RDFIO] (master) - https://gerrit.wikimedia.org/r/42223 [09:06:39] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42222 [09:08:51] New patchset: Krinkle; "JSDuck: Generated code documentation!" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/42221 [09:09:15] New review: Krinkle; "Fixed typo in commit-msg. http://integration.wmflabs.org/mwext-VisualEditor-docs/" [mediawiki/extensions/VisualEditor] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/42221 [09:10:55] New patchset: Raimond Spekking; "Remove double definition of empty array" [mediawiki/extensions/ParserFunctions] (master) - https://gerrit.wikimedia.org/r/42224 [09:11:53] New patchset: Raimond Spekking; "Rename i18n file -> i18n.magic" [mediawiki/extensions/Git2Pages] (master) - https://gerrit.wikimedia.org/r/42079 [09:14:04] New patchset: Santhosh; "propagate events" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42225 [09:15:09] 03(mod) Add Anexos to content namespaces on Spanish Wikipedia - 10https://bugzilla.wikimedia.org/39866 +comment (10Ryan Kaldari) [09:18:01] New patchset: Krinkle; "JSDuck: Generated code documentation!" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/42221 [09:18:27] New review: Krinkle; "Fixed another typo. http://integration.wmflabs.org/mwext-VisualEditor-docs/" [mediawiki/extensions/VisualEditor] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/42221 [09:19:47] 03(mod) Not only NS_MAIN is a content namespace - 10https://bugzilla.wikimedia.org/43629 +comment (10Ryan Kaldari) [09:21:46] New patchset: Raimond Spekking; "Consistency tweaks in preparation for re-adding to Translatewiki.net" [mediawiki/extensions/RDFIO] (master) - https://gerrit.wikimedia.org/r/42223 [09:28:03] New patchset: Tim Starling; "Use consistent hashing for SqlBagOStuff servers" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42226 [09:28:35] New review: Tim Starling; "Submitted consistent hashing as a dependent change." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/41023 [09:29:29] New patchset: Zfilipin; "Updated parallel_tests Ruby gem" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/42228 [09:29:39] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42086 [09:33:48] New review: Tim Starling; "The test failure is apparently unrelated to this change." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42226 [09:39:05] New patchset: Nikerabbit; "Added a file missing from I8849715f" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42229 [09:43:12] Change merged: Santhosh; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42229 [09:43:15] 03(mod) Not only NS_MAIN is a content namespace - 10https://bugzilla.wikimedia.org/43629 +comment (10Siebrand) [09:50:55] Supercalifragielisticexpialidoscious ... #justsaying [09:58:20] New patchset: Nikerabbit; "Unbreak getTranslation" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42230 [10:02:38] freakolowsky: Don't say that too loud, you might sound precocious [10:04:59] bawolff: yeah, but the sound of it is still something quite atrocious [10:06:14] Change merged: Santhosh; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42230 [10:09:09] New patchset: Amire80; "WIP: display description." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42099 [10:09:13] New patchset: Amire80; "Fix the wrapping of the language selector" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42074 [10:09:16] New patchset: Amire80; "WIP: Add support for message documentation in ULS" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/41935 [10:12:59] New patchset: Raimond Spekking; "Remove double definition of empty array" [mediawiki/extensions/ParserFunctions] (master) - https://gerrit.wikimedia.org/r/42224 [10:21:45] New review: Daniel Kinzler; "Please make the serialization code itself robust. The explicit serialize/unserialize doesn't seem to..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42090 [10:22:17] New patchset: Raimond Spekking; "[WikiLexicalData] Re-add extension after merging from SVN into Git" [translatewiki] (master) - https://gerrit.wikimedia.org/r/42231 [10:22:59] Change merged: Raimond Spekking; [translatewiki] (master) - https://gerrit.wikimedia.org/r/42231 [10:24:15] New review: Daniel Kinzler; "This seems fine to me now, except for cases where the serialized data itself changes significantly. " [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/42037 [10:25:11] * bawolff wonders why we look at the page contents on every page view to see if the current page is a redirect instead of looking at the redirect or page table [10:28:06] 03(mod) set $wgAutoConfirmCount to 10 for fa.wikipedia - 10https://bugzilla.wikimedia.org/43630 +patch-in-gerrit +shell; +comment (10Aude) [10:29:16] New review: Nikerabbit; "Approving this with some notes:" [mediawiki/extensions/Translate] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/42074 [10:30:56] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42074 [10:34:55] New review: Nikerabbit; "I guess you did not test this." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/41834 [10:37:57] 03(mod) Add Anexos to content namespaces on Spanish Wikipedia - 10https://bugzilla.wikimedia.org/39866 +comment (10Nemo) [10:41:48] 03(mod) Search suggestion highlighting does not respect grapheme clusters causing wrong rendering for Arabic and Indic scripts - 10https://bugzilla.wikimedia.org/33242 (10Aude) [10:42:46] New review: Nemo bis; "Of course I didn't. Thanks, I'll fix autofocus; what about tabindex, should it be another bug filed ..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/41834 [10:42:47] New review: Nikerabbit; "Only few small things." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/41587 [10:42:58] New patchset: Raimond Spekking; "Consistency tweak: Use "..." instead of '...' in message text" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/42233 [10:43:43] 03(mod) Special:Categories navigation is broken when using Special:Categories/ - 10https://bugzilla.wikimedia.org/43506 (10Aude) [10:45:20] New patchset: Amire80; "Display group description" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42099 [10:47:01] New patchset: Nemo bis; "(bug 34211) Initial focus on Special:Block is nowhere" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41834 [10:47:09] New patchset: Amire80; "Display group description" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42099 [10:47:18] Change merged: Siebrand; [mediawiki/extensions/TranslateSvg] (master) - https://gerrit.wikimedia.org/r/41922 [10:47:23] Change merged: Siebrand; [mediawiki/extensions/Git2Pages] (master) - https://gerrit.wikimedia.org/r/42079 [10:47:41] Change merged: Siebrand; [mediawiki/extensions/RDFIO] (master) - https://gerrit.wikimedia.org/r/42223 [10:47:47] Change merged: Siebrand; [mediawiki/extensions/ParserFunctions] (master) - https://gerrit.wikimedia.org/r/42224 [10:47:54] Change merged: Siebrand; [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/42233 [10:51:45] New patchset: Brian Wolff; "Reuse the WikiPage object to save a db query" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42234 [10:51:47] New review: Nikerabbit; "Code is fine, but leaving design&(un)wantedness to someone else." [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/40781 [10:55:19] Nikerabbit: yeah, I'm half expecting that change to be rejected on a zomg-it-changes-the-interface basis ;) [10:57:25] bawolff: ping me in few weeks if you haven't got any feedback and I'll merge it [10:57:52] thanks, will do [10:59:53] 03(mod) Enable MicroDesign on it.wikivoyage - 10https://bugzilla.wikimedia.org/43523 +comment (10Andre Klapper) [11:00:20] New review: Nikerabbit; "I don't know how long it existed in MW, but if it has been a release, wiki page should be created it..." [mediawiki/extensions/Configure] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/40284 [11:02:52] 03(mod) allow login with email as well as username - 10https://bugzilla.wikimedia.org/28085 +patch-in-gerrit (10Andre Klapper) [11:03:35] New patchset: Amire80; "Handle box-shadow in CSSJanus" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/23601 [11:07:24] 03(mod) Navigation/Toolbox side panel is not collapsible/expandable when being logged out - 10https://bugzilla.wikimedia.org/43227 +comment (10Andre Klapper) [11:08:32] will MW 1.16 work on the latest stable PHP version? [11:09:21] New patchset: Siebrand; "(bug 37176) Localize autosummary of page protecting" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/9359 [11:10:20] I still run on PHP 5.2.4 and want my host to upgrade it so I can install the latest MW version. But will MW 1.16 continue to work in the meantime on latest PHP? [11:10:52] New review: Nikerabbit; "Added Tim and Chad as reviewers. Make sure you train at least one other person to be able to maintai..." [mediawiki/extensions/TemplateSandbox] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/39768 [11:13:43] New review: Nikerabbit; "-1 per Siebrand" [mediawiki/extensions/SpecialNamespaces] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/39720 [11:13:49] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/9359 [11:15:02] New review: Brian Wolff; "As an aside, TimedMediHandler still has code that checks for the setting." [mediawiki/extensions/Configure] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/40284 [11:16:54] Change merged: Siebrand; [mediawiki/extensions/Renameuser] (master) - https://gerrit.wikimedia.org/r/37452 [11:18:46] New patchset: Siebrand; "(bug 22457) More natural flow for the "By e-mail" feature" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/38905 [11:19:22] New review: Nikerabbit; "-1 for unaddressed comments" [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/37664 [11:19:39] New patchset: Santhosh; "Refactor the warnings code" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42235 [11:20:43] New review: Siebrand; "Added Chris for security review and one inline comment on L10n." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/38905 [11:20:59] New review: Nemo bis; "Niklas, it was introduced in r84395 for bug 27641 and reverted a few months later." [mediawiki/extensions/Configure] (master) C: 0; - https://gerrit.wikimedia.org/r/40284 [11:21:53] New review: Nikerabbit; "I'd just prefer to use the new {{PLURAL:$1|1=a new message|new messages}} syntax and $BIG number for..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/38506 [11:23:11] New patchset: Siebrand; "Use getPageViewLanguage() instead of getPageLanguage() in firstHeading." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/37218 [11:25:11] 03(mod) kg and ln does not display in mobile phone modus - 10https://bugzilla.wikimedia.org/43352 +comment (10Andre Klapper) [11:27:41] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/37218 [11:28:13] 03(mod) Navigation/Toolbox side panel is not collapsible/expandable when being logged out - 10https://bugzilla.wikimedia.org/43227 +comment (10Andreas Plank) [11:29:08] Change merged: Siebrand; [mediawiki/extensions/Configure] (master) - https://gerrit.wikimedia.org/r/40284 [11:32:39] New patchset: Matthias Mullie; "DataModel" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27981 [11:33:25] New patchset: Matthias Mullie; "DataModel" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27981 [11:34:08] New review: Matthias Mullie; "Depends on https://gerrit.wikimedia.org/r/#/c/25879/ (which is also the reason the tests fail)" [mediawiki/core] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/27981 [11:34:08] 03(mod) CentralAuth: Username not substituted in Centralauth-renameuser-merged message - 10https://bugzilla.wikimedia.org/42727 +comment (10Krenair) [11:36:09] New patchset: Siebrand; "zhtable maintenance" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39054 [11:37:32] New review: Aude; "The commit message is very informative, but this information will get lost in gerrit and git." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/27981 [11:41:23] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39054 [11:41:53] New patchset: Santhosh; "propagate events" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42225 [11:42:19] hmm, where did execute user right come from... [11:43:14] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39740 [11:44:12] New review: Nikerabbit; "Needs feedback from Pau for the visual design." [mediawiki/extensions/Translate] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42099 [11:44:45] bawolff: haven't seen that [11:44:57] There's code for it in Title.php [11:45:13] its one of the rights checks allowed to be done for special pages [11:45:21] but I can't find any other references to it [11:45:27] and have never heard of it before [11:45:44] is it assigned to any group? [11:45:49] nope [11:45:58] Its also not in the list of core rights in User.php [11:46:09] or have any system messages associated with it [11:46:38] in fact Title.php is the only place in the code where 'execute' or "execute" (With quotes) occurs in the code base according to grep [11:46:59] then what it is checking? [11:47:51] Its just listed as one of the actions that can be done to SpecialPages, everything other then read, createaccount and execute are blacklisted for special pages [11:48:09] New patchset: Liangent; "New collation: zh-zhuyin (bopomofo)." [mediawiki/core] (chinese-collation) - https://gerrit.wikimedia.org/r/36778 [11:48:29] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27391 [11:48:32] meh, it is probably some weird hang over from the early days of MW that nobody ever deleted [11:48:36] New review: Liangent; "They're in previous commits in this branch." [mediawiki/core] (chinese-collation) C: 0; - https://gerrit.wikimedia.org/r/31814 [11:48:58] New patchset: Siebrand; "(bug 33210) Don't convert blue categorylinks to another variant." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/8335 [11:49:36] New patchset: Siebrand; "Partly disable title conversion if variant == main language code" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/19746 [11:50:27] jenkins-bot is having gerrit spamming my mailbox [11:52:10] New review: Siebrand; "11:49:42 Warning: Task "jshint" failed." [mediawiki/core] (chinese-collation); V: 0 C: 0; - https://gerrit.wikimedia.org/r/36778 [11:52:45] hmm, appearently added in bc23aede55e back in 2008 [11:53:08] 03(mod) jQuery.entityselector widget returns wrong selected entity information (label set to ID if no label) - 10https://bugzilla.wikimedia.org/43317 (10Daniel Werner) [11:53:11] New review: Liangent; "Hi hashar, how can I have jenkins not lint files I haven't touched? This is in a branch and those is..." [mediawiki/core] (chinese-collation) C: 0; - https://gerrit.wikimedia.org/r/36778 [11:54:39] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/8335 [12:00:45] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42225 [12:01:47] New patchset: Raimond Spekking; "[TranslateSvg] Enable special page alias file" [translatewiki] (master) - https://gerrit.wikimedia.org/r/42236 [12:01:57] Change merged: Raimond Spekking; [translatewiki] (master) - https://gerrit.wikimedia.org/r/42236 [12:03:10] Change merged: Nikerabbit; [mediawiki/extensions/cldr] (master) - https://gerrit.wikimedia.org/r/40330 [12:08:26] New patchset: Liangent; "(bug 22457) More natural flow for the "By e-mail" feature" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/38905 [12:09:17] New patchset: Brian Wolff; "Remove references to non-existent 'execute' right in Title.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42237 [12:10:29] New patchset: Siebrand; "Fix a few JSLint/JSHint issues" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42238 [12:10:29] New patchset: Siebrand; "Update indentation and formatting" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42239 [12:11:24] New review: Siebrand; "Formatting fully updated in I5d3cf692." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42238 [12:12:17] siebrand: what about adding some unit tests to check message integrity? eg make sure all messages in MessagesEn.php are in messages.inc [12:14:07] New review: Krinkle; "I don't know where this is changing the message, but may I remind you that it is important that the ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/9359 [12:18:27] New review: Krinkle; "I'm wondering, why the urge to clean up legacy modules? They are not included in the jshint run. And..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42238 [12:19:57] New patchset: Siebrand; "Fix a few JSLint/JSHint issues" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42240 [12:20:43] New review: Krinkle; "Reinstating "Do not submit" regarding intend of the commit per previous comments, not regarding the ..." [mediawiki/core] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/23601 [12:21:20] New review: Siebrand; "I can't make the file strict for now, so removing it from .jshintignore is not possible at this time." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42238 [12:23:32] New patchset: IAlex; "Follow-up Idf308e82 (e88b0fb): use wfMessage() and numParams()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41379 [12:24:06] New patchset: IAlex; "Follow-up Idf308e82 (e88b0fb): use wfMessage() and numParams()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41379 [12:25:02] New patchset: IAlex; "Revert "Remove everything related to nonexistent $wgExcludeFromThumbnailPurge"" [mediawiki/extensions/Configure] (master) - https://gerrit.wikimedia.org/r/42241 [12:25:10] Change merged: IAlex; [mediawiki/extensions/Configure] (master) - https://gerrit.wikimedia.org/r/42241 [12:28:22] New review: Siebrand; "FYI, the itch was caused by the jenkins fail on https://gerrit.wikimedia.org/r/#/c/36778/." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42238 [12:28:50] New review: Siebrand; "That is https://gerrit.wikimedia.org/r/#/c/36778/ , without the dot..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42238 [12:30:00] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41379 [12:30:48] New review: Siebrand; "Ah, I see... 11 patch sets merged, 2 not merged yet..." [mediawiki/core] (chinese-collation); V: 0 C: 0; - https://gerrit.wikimedia.org/r/31814 [12:32:43] New review: Liangent; "siebrand, Ief89a298 is in a branch and that ignore-list was not around at the branch point..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/42238 [12:33:21] New review: Siebrand; "Please explain "consistent state". It was proven that the removed global was only present in between..." [mediawiki/extensions/Configure] (master) - https://gerrit.wikimedia.org/r/42241 [12:35:57] New review: Siebrand; "Yes, that became clear to me. IMHO that doesn't change the validity of this patch set." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42238 [12:37:33] New patchset: IAlex; "Move logentry-* messages from newusers and rights log near the other ones" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39731 [12:38:01] New patchset: IAlex; "Move logentry-* messages from newusers and rights log near the other ones" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39731 [12:42:26] New patchset: IAlex; "Revert "Revert "Remove everything related to nonexistent $wgExcludeFromThumbnailPurge""" [mediawiki/extensions/Configure] (master) - https://gerrit.wikimedia.org/r/42242 [12:42:48] Change merged: IAlex; [mediawiki/extensions/Configure] (master) - https://gerrit.wikimedia.org/r/42242 [12:45:19] New review: Liangent; "So silly Gerrit's auto-merge is. It can be automatically done with git command:" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/34975 [12:47:35] New patchset: IAlex; "Add missing messages for $wgUpdateCompatibleMetadata" [mediawiki/extensions/Configure] (master) - https://gerrit.wikimedia.org/r/40285 [12:47:37] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39731 [12:48:09] New review: IAlex; "Thanks for the patch!" [mediawiki/extensions/Configure] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/40285 [12:48:09] Change merged: IAlex; [mediawiki/extensions/Configure] (master) - https://gerrit.wikimedia.org/r/40285 [12:48:24] 03(NEW) Page title doesn't update when a page is loaded - 10https://bugzilla.wikimedia.org/43631 trivial; MediaWiki extensions: MobileFrontend (Beta); () [12:48:37] 03(mod) Page title doesn't update when a page is loaded - 10https://bugzilla.wikimedia.org/43631 +easy (10Jon) [12:48:55] New review: Siebrand; "Math.body.php should be renamed to MathRenderer.php to preserve SCM history." [mediawiki/extensions/Math] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/30177 [12:49:17] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/34975 [12:59:40] hello!! [13:00:10] i configured adding external images in LocalConfig.php, i still can't figure out how to add external images from a different host. [13:01:14] 03(mod) Strange notification from mediawiki.org - 10https://bugzilla.wikimedia.org/43625 +comment (10Carl Fürstenberg) [13:01:47] got four more.... [13:02:10] howdy! [13:02:21] hai [13:03:03] Krenair: you know if kaldari lurks here? [13:03:27] ufk_: what setting did you use - that should be by on default for external images [13:03:39] New review: Krinkle; "There are certain files that are (and should) always be linted because there are still people refusi..." [mediawiki/core] (chinese-collation); V: 0 C: 0; - https://gerrit.wikimedia.org/r/36778 [13:03:44] AzaToth: I've seen him here before [13:04:16] i already configured the usage of external images. i just don't know what tag i need to put in order to show external images. [13:04:35] bawolff: I'm still getting funky notifications from echo... [13:04:53] * bawolff knows nothing about echo [13:05:12] New patchset: IAlex; "Reuse the WikiPage object to save a db query" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42234 [13:05:18] !bug 43625 [13:05:18] https://bugzilla.wikimedia.org/43625 [13:05:33] New review: Krinkle; "Still, you're cleaning up a file that isn't being linted anymore. And for an older branches where it..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42238 [13:05:48] ohh [13:05:51] i can use html tags! [13:05:54] ufk_: There's two external images setting. The most common one, is you just put the url directly in the image page. There's another setting that's less commonly used where you use the tag [13:06:02] cool thanks :) [13:06:15] ufk_: Generally only some html tags. We only let the "safe" one's through [13:07:06] shows [13:07:13] shows \"> after the image [13:08:01] New review: Matmarex; "Looks whitespace-only according to diff." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/42239 [13:08:05] What settings did you enable - $wgAllowExternalImages or $wgAllowImageTag ? [13:08:52] the former you just put the url directly in the page (and it works provided the url ends in .png, .gif or .jpg) the latter you use the image tag [13:09:17] wgAllowExternalImagesFrom [13:09:40] Change merged: IAlex; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42234 [13:10:34] ohhh coool! [13:11:16] ufk_ there's some instructions for how it works at [13:11:20] New review: Matmarex; "Per Krinkle. (To get this off my dashboard.)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/42238 [13:11:20] !wg AllowExternalImages [13:11:20] https://www.mediawiki.org/wiki/Manual:$wgAllowExternalImages [13:11:34] yeah just pasting the url works. thank's a lot [13:11:43] New review: Matmarex; "The same point as on I047da9c7 applies, no?" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/42240 [13:12:57] Yurik: filed https://bugs.launchpad.net/git-review/+bug/1096057 [13:20:17] New patchset: IAlex; "(bug 38633) Don't block non-existent users via the API" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39860 [13:21:21] 03(mod) Strange notification from mediawiki.org - 10https://bugzilla.wikimedia.org/43625 +comment (10Krenair) [13:23:02] New patchset: Liangent; "Followup I888c616e: one more string to localize." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42246 [13:25:09] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39860 [13:25:10] New review: Matmarex; "recheck" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/37395 [13:29:01] New review: Matmarex; "I've already explained my rationale: this is confusing to translators." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/38506 [13:31:46] 03(mod) Add a button to request a new fancy captcha (code) - 10https://bugzilla.wikimedia.org/14230 (10Antoine "hashar" Musso) [13:32:46] New patchset: Raimond Spekking; "[WikiLexicalData] Some optional message keys" [translatewiki] (master) - https://gerrit.wikimedia.org/r/42247 [13:32:56] Change merged: Raimond Spekking; [translatewiki] (master) - https://gerrit.wikimedia.org/r/42247 [13:34:18] New review: Matmarex; "Meh, it won't run the full suite when I'm the one requesting it, even though the code is not mine? S..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/37395 [13:34:59] New patchset: Daniel Kinzler; "(bug 42064) Make EditFilterMergedContent more generic." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42248 [13:37:18] 03(mod) Navigation/Toolbox side panel is not collapsible/expandable when being logged out - 10https://bugzilla.wikimedia.org/43227 +comment (10Bartosz Dziewoński) [13:39:09] New review: Aude; "I have tried the patch and it fixes the bug. More robustness when we change serialization and stuff..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/42037 [13:42:19] New review: Brian Wolff; "Hmm, for some reason I thought a cached page view almost didn't talk to the db at all, but you're ri..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/41196 [13:45:45] New review: Liangent; "Krinkle: Ifeec00fc98c7912b6e16b6f07d1fdc26ab4e4fb5" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/9359 [13:46:09] Change abandoned: Siebrand; "F**k it, then. Don't we all love to throw away other people's work." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42238 [13:46:16] Change abandoned: Siebrand; "F**k it, then. Don't we all love to throw away other people's work." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42239 [13:46:20] Change abandoned: Siebrand; "F**k it, then. Don't we all love to throw away other people's work." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42240 [13:46:33] Change abandoned: Siebrand; "F**k it, then. Don't we all love to throw away other people's work." [mediawiki/extensions/CustomUserSignup] (master) - https://gerrit.wikimedia.org/r/25220 [13:46:39] Change abandoned: Siebrand; "F**k it, then. Don't we all love to throw away other people's work." [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/27024 [13:46:53] Change abandoned: Siebrand; "F**k it, then. Don't we all love to throw away other people's work." [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/27553 [13:47:11] Change abandoned: Siebrand; "F**k it, then. Don't we all love to throw away other people's work." [mediawiki/extensions/PagedTiffHandler] (master) - https://gerrit.wikimedia.org/r/29603 [13:47:19] New patchset: Liangent; "Followup I888c616e: Keep IRC line format unchanged." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42249 [13:47:44] Change abandoned: Siebrand; "No longer interested in working in this." [mediawiki/extensions/ContactPageFundraiser] (master) - https://gerrit.wikimedia.org/r/37779 [13:48:14] Change abandoned: Siebrand; "No longer interested in working on this." [mediawiki/extensions/ApiSandbox] (master) - https://gerrit.wikimedia.org/r/39006 [13:49:24] 03(mod) Status class should accept Message objects - 10https://bugzilla.wikimedia.org/40852 (10Tyler Romeo) [13:49:55] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42037 [13:50:08] New review: Brian Wolff; "That seems a little dramatic given this has a +1 and was only uploading a couple hours ago..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42239 [13:50:18] New review: Daniel Kinzler; "Ib290b465 is being merged, so this at least needs a rebase." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42090 [13:52:55] New review: Siebrand; "It's a dependent patch set." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42239 [13:54:00] New patchset: Siebrand; "Allow preferences that need not be rendered in Special:Preferences" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/37395 [13:54:33] New review: Nikerabbit; "{{PLURAL:$1|1=foo}} syntax already exists in the core, and the more it is used the more familiar tra..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/38506 [13:57:14] New review: Siebrand; "The latter. Thanks for your review, Lupo. Unfortunately it didn't help." [mediawiki/extensions/PagedTiffHandler] (master) - https://gerrit.wikimedia.org/r/29603 [13:58:06] New review: Parent5446; "Same as before (validation)." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/37395 [14:01:43] 03(mod) api login returns wrong lgtoken on wikidata.org - 10https://bugzilla.wikimedia.org/41586 +comment (10Daniel Kinzler) [14:02:07] Krenair: ! [14:02:13] New review: Parent5446; "What if the user is using a proxy of some sort, i.e., the request was forwarded by something other t..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/42204 [14:02:16] "Thread:User talk:^demon/Re: Moved extensions from SVN - Git was linked by MediaWiki user Krenair, from this page: Thread:User talk:^demon/Re: Moved extensions from SVN - Git (2)" [14:02:50] 03(mod) [selenium] more tests for statements UI - 10https://bugzilla.wikimedia.org/43606 (10tobias.gritschacher) [14:03:08] <^demon> Krenair: You didn't need to move that thread around :\ [14:03:37] ^demon: I'm getting mail notifications from echo regarding it [14:03:52] 03(mod) api login returns wrong lgtoken on wikidata.org - 10https://bugzilla.wikimedia.org/41586 +comment (10Daniel Kinzler) [14:03:59] New patchset: Aude; "(bug 43595) Add a cache version variable to SiteArray" [mediawiki/core] (wmf/1.21wmf7) - https://gerrit.wikimedia.org/r/42252 [14:03:59] New patchset: Aude; "Update Wikibase, Diff and DataValues" [mediawiki/core] (wmf/1.21wmf7) - https://gerrit.wikimedia.org/r/42253 [14:04:38] 03(mod) Strange notification from mediawiki.org - 10https://bugzilla.wikimedia.org/43625 +comment (10Carl Fürstenberg) [14:05:25] <^demon> AzaToth: I have no idea why. [14:05:40] 03(mod) Strange notification from mediawiki.org - 10https://bugzilla.wikimedia.org/43625 +comment (10Carl Fürstenberg) [14:06:12] either I have some soft of special account, or echo is broken :-P [14:06:22] sort* [14:08:31] Change merged: Demon; [mediawiki/core] (wmf/1.21wmf7) - https://gerrit.wikimedia.org/r/42252 [14:09:06] Change merged: Demon; [mediawiki/core] (wmf/1.21wmf7) - https://gerrit.wikimedia.org/r/42253 [14:10:51] ^demon: can you explain why you verified while jenkins-bot failed on the latest gerrit one? [14:10:57] makes no sense to me [14:11:11] <^demon> I don't care what jenkins thinks. [14:11:34] <^demon> I'm merging to deployment. I'm assuming it's jenkins failing because...jenkins. [14:12:34] it will always fail phpunit? [14:12:57] <^demon> Not always, but sometimes it does funny things on non-master branches. [14:13:02] ok [14:13:12] <^demon> And antoine's not around for me to ask him why Jenkins is misbehaving. [14:13:30] 03(mod) VisualEditor: Fix "Error loading data from server: error. Would you like to retry?" - 10https://bugzilla.wikimedia.org/43566 +comment (10chaos) [14:13:35] looks like it's not building the job correctly [14:13:46] * aude has no idea why but it's not saying a test failed [14:13:47] <^demon> Yeah, dunno why. [14:13:53] <^demon> Right, I saw that. [14:14:07] <^demon> It's some random phpunit failure, not an actual test problem. [14:14:17] <^demon> (Part of the reason I don't mind overriding jenkins right now) [14:14:21] aude: but ^demon has verified it works 100% so... [14:15:29] AzaToth: yes [14:16:11] ^demon: is "exec returned: 139" that Jenkins/PHPunit/whatever problem? [14:16:29] <^demon> I'm pretty sure it's phpunit being stupid. [14:16:30] New patchset: Zfilipin; "Cleanup: mobile search feature moved to MobileFrontent repository" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/42087 [14:16:56] 139 looks like SIGSEGV to me [14:17:13] New review: Zfilipin; "Forgot to remove :mobile Rake task." [qa/browsertests] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42087 [14:17:50] yea [14:17:53] or EAGAIN [14:18:44] 139 - 128 = 11 (SIGSEGV) [14:20:17] so "php.core" should be somewhere to find out :) [14:21:06] if it dropped core that is [14:21:42] New review: Anomie; "Is there a point in continuing to rebase this when the issues raised on the last real revision remai..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/37395 [14:24:15] New review: saper; "Seems to me that php dies on SIGSEGV doing" [mediawiki/core] (wmf/1.21wmf7) - https://gerrit.wikimedia.org/r/42253 [14:28:37] it takes forever to clone mediawiki-core [14:29:06] seems like there havent been and "git gc --aggresive" run ever [14:29:19] remote: Finding sources: 30% (123309/403775) [14:29:28] I've never seen "finding sorces" before... [14:29:52] there's a lot of files and history [14:30:20] Reedy: in a good word there would be a big blob of everything [14:30:35] as I'm cloning from scratch [14:31:07] but I read the bog yee had about the failures before when trying to do a git gc [14:32:39] <^demon> A full repack of core is probably a good idea. [14:33:11] <^demon> `git repack -a -d -f --depth= --window=` [14:33:32] 03(NEW) Make SRF support foreign image repos - 10https://bugzilla.wikimedia.org/43632 enhancement; MediaWiki extensions: SemanticResultFormats; () [14:33:51] 03(mod) Make SRF support foreign image repos - 10https://bugzilla.wikimedia.org/43632 (10Leonard Wallentin) [14:33:53] 03(mod) Link translatable help pages on mediawiki.org from the relevant special pages - 10https://bugzilla.wikimedia.org/43591 (10Nemo) [14:33:54] 03(mod) Add links to Help pages in Special:Version - 10https://bugzilla.wikimedia.org/17557 (10Nemo) [14:35:01] 03(mod) Add links to Help pages in Special:Version - 10https://bugzilla.wikimedia.org/17557 (10Chad H.) [14:41:29] New review: Siebrand; "@Anomie: The atomatic rebase has nothing to do with the open issues not being addressed. It's just n..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/37395 [14:42:25] 03(mod) Periodical run of currently disabled special pages - 10https://bugzilla.wikimedia.org/15434 (10Guillaume Paumier) [14:43:01] 03(mod) Link translatable help pages on mediawiki.org from the relevant special pages - 10https://bugzilla.wikimedia.org/43591 (10Guillaume Paumier) [14:43:06] 03(mod) Don't use current translation of a string as a suggestion for it - 10https://bugzilla.wikimedia.org/40711 (10Siebrand) [14:44:51] 03(NEW) Change autoconfirmed settings on fawiki - 10https://bugzilla.wikimedia.org/43633 normal; Wikimedia: Site requests; () [14:47:06] 03(mod) Change autoconfirmed settings on fawiki - 10https://bugzilla.wikimedia.org/43633 +comment (10Aude) [14:47:07] 03(mod) set $wgAutoConfirmCount to 10 for fa.wikipedia - 10https://bugzilla.wikimedia.org/43630 +comment (10Aude) [14:48:59] New patchset: Nemo bis; "Make Etherpad lite group description translatable" [translatewiki] (master) - https://gerrit.wikimedia.org/r/42255 [14:50:08] New review: Daniel Kinzler; "There's a better patch coming up, based on I99a19c93" [mediawiki/extensions/AbuseFilter] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/34900 [14:51:08] hi there mitevam [14:51:40] hello sumanah :) good morning [14:51:43] New patchset: Nemo bis; "Make Etherpad lite description translatable" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42257 [14:51:51] New patchset: Amire80; "WIP: Add support for message documentation in ULS" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/41935 [14:52:04] good afternoon mitevam :) how is life in Sofia today? [14:52:30] almost dark already sumanah...quite sad :) [14:53:20] Change merged: Siebrand; [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/42025 [14:53:40] Change merged: Siebrand; [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/42069 [14:53:54] mitevam: so, have you finished all the megabytes I gave you to read? :-) that dissertation chapter is especially dense [14:54:36] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42257 [14:55:26] 03(NEW) API reblock works without checking reblock argument - 10https://bugzilla.wikimedia.org/43634 major; MediaWiki: API; () [14:55:27] 03(mod) Can block a random non-existing user via API - 10https://bugzilla.wikimedia.org/38633 (10Krenair) [14:55:51] * Ulfr devoutly hopes sumanah never gives him homework [14:55:55] New patchset: Amire80; "WIP: Add support for message documentation in ULS" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/41935 [14:56:13] i'm still working through the dissertation sumanah, i am just about to start chapter 5...it got interesting in the last chapter, before that there were some sections about circuit and packet switching and the traveling salesman problem and what not that didn't seem very relevant [14:56:18] That's a fairly easy situation to avoid I think Ulfr :-) [14:56:19] 03(mod) Can block a random non-existing user via API - 10https://bugzilla.wikimedia.org/38633 +comment (10Krenair) [14:56:38] mitevam: ok! so, not sure whether you saw that I'm specifically only suggesting that you read the chapter about the Wikimedia technical ecology [14:56:43] 03(mod) Can block a random non-existing user via API - 10https://bugzilla.wikimedia.org/38633 (10Krenair) [14:56:44] 03(mod) API reblock works without checking reblock argument - 10https://bugzilla.wikimedia.org/43634 (10Krenair) [14:56:45] lemme pull it up so I see what chapter number that is [14:57:03] New patchset: Daniel Kinzler; "(bug 42064) Make EditFilterMergedContent more generic." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42248 [14:58:08] mitevam: probably chapter 4, i actually just finished reading its conclusion :) [14:58:38] mitevam: IV. THE BIRTH AND DEVELOPMENT OF WIKIPEDIA�S TECHNICAL INFRASTRUCTURE and V. WIKIPEDIA AS A SOCIOTECHNICAL SYSTEM actually [14:58:41] sumanah: THE BIRTH AND DEVELOPMENT OF WIKIPEDIA�S TECHNICAL [14:58:42] INFRASTRUCTURE ? [14:58:43] New review: Siebrand; "Where can a reference to the source images be found just in case, for whatever reason, someone would..." [mediawiki/extensions/WikiEditor] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42068 [14:59:28] sumanah: just finished IV, so I should read V as well? [14:59:34] mitevam: both 4 and 5 actually -- "The Software Infrastructure" for instance is a section I do want you to know about and I think his coverage of "wtf is a bot" etc is good [14:59:35] yeah [15:00:10] New patchset: Siebrand; "Remove hard coded brackets. Use 'brackets' key instead" [mediawiki/extensions/WikiForum] (master) - https://gerrit.wikimedia.org/r/42258 [15:00:51] Change merged: Siebrand; [mediawiki/extensions/WikiForum] (master) - https://gerrit.wikimedia.org/r/42258 [15:00:56] mitevam: I'm sorry that I didn't specify that ahead of time; I misremembered the relevant part as being only 1 of the chapters [15:02:15] hello, I have just installed the latest version of media wiki and am having trouble using page protection [15:02:28] sumanah, yes chapter IV was actually really good, it was interesting to see how things were shaped and decisions were made [15:02:33] New patchset: Umherirrender; "Add SpecialPage::getGroupName and use it" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41587 [15:02:39] is their a way of stopping users from using the wiki? [15:02:40] rock [15:02:54] !access [15:02:54] For information on customizing user access, see . For common examples of restricting access using both rights and extensions, see . [15:02:56] jonjo, you want to prevent spam? [15:03:13] New review: Umherirrender; "Fixed more code styling issued" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41587 [15:03:20] I just want admins to edit the wiki [15:03:30] and users just to read [15:03:34] jonjo http://www.mediawiki.org/wiki/Manual:User_rights <- disable anonymous edits [15:04:04] thanks [15:04:37] mitevam: ok! so, after you read Chapter 5, let's chat about what your first step ought to be regarding nurturing the vendor/ISV/enterprise MediaWiki community. I'll be here. [15:04:56] hello .. btw is it possible to exclude redirects in mediawiki's default search results? [15:05:13] New patchset: Siebrand; "Add plural on notified number of languages in log" [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/41007 [15:05:25] sumanah: ok, getting on it :) [15:05:35] cool! talk with you whenever you're done. [15:05:58] New review: Siebrand; "PS4 adds a space in "$10-" as pointed out by Niklas. The other comment may be addressed later, but s..." [mediawiki/extensions/TranslationNotifications] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/41007 [15:06:48] another simple one, how can I include a label in an external link? [15:07:01] www.arm.com [2] atm only the 2 is clickable [15:07:18] www.arm.com [http://www.arm.com/] [15:07:37] jonjo: [http://www.arm.com/ ARM] [15:07:43] [http://arm.com arm.com] [15:07:54] jonjo: yea, it's a space, not a pipe. don't mention it. [15:07:59] arm.com [15:08:02] >> [15:08:10] Ulfr: o_O [15:08:11] ah thanks on my project wiki it is [[address|lol]] [15:08:21] DanielK_WMDE: I'm a purist [15:08:22] :D [15:08:32] jonjo: for internal links, yes. for external links, it must be a space. [15:08:40] ok [15:08:41] Ulfr: but is not supported in wikitext [15:08:43] 03(mod) Divide wikis into database lists by approximate size for performance engineering - 10https://bugzilla.wikimedia.org/39667 +comment (10Andre Klapper) [15:09:01] jonjo: it's an annoying little inconsistency. [15:09:24] as long as it works :) [15:09:29] DanielK_WMDE: Really? [15:09:52] 03(mod) Periodical run of currently disabled special pages - 10https://bugzilla.wikimedia.org/15434 +comment (10Andre Klapper) [15:09:55] Wow. I need to spend some time remembering what wikitext can't do [15:09:58] Ulfr: yep. i have tried to introduce it twice. i think it's available as an option now, but I haven't followed the html5/microdata stuff [15:10:10] * Ulfr shudders [15:10:16] microdata wasn't any fun to implement [15:12:28] Oh, yeah! I remember why I came on here! I've got a widget executing jQuery scripts, but something funky happens when I try to append strings and I wind up with broken tables and lots of extra html tags I don't want there [15:12:35] Is anyone familiar with what I'm talking about? [15:13:19] New patchset: Daniel Kinzler; "Accept IContextSource from EditFilterMergedContent hook." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42260 [15:14:49] i see here http://meta.wikimedia.org/wiki/Help:Searching it says redirects can be excluded from search by checking box [15:15:00] i dont have the check box due to maybe a custom skin ... [15:15:13] ki: Link? [15:15:17] can i change a setting in a file somewhere to have it default to not showing redirects? [15:15:28] 03(mod) Divide wikis into database lists by approximate size for performance engineering - 10https://bugzilla.wikimedia.org/39667 +comment (10Sam Reed (reedy)) [15:15:32] http://asianwiki.com/index.php?title=Special:Search&search=Brain+Korean+Drama&fulltext=Search&profile=default&redirs=1 [15:15:43] ki: that's a project specific help page. it may refer to features that are not present per default [15:16:01] ok [15:16:16] any tips on excluding redirects? [15:16:25] not off hand, no [15:16:29] ok [15:16:32] 03(mod) Periodical run of currently disabled special pages - 10https://bugzilla.wikimedia.org/15434 +comment (10Jarry1250) [15:16:51] ki: It's supposed to appear when you click advanced [15:16:55] ki: why do you want to exclude redirects? the main reason for their existance is that you can find stuff in the search using a different title... [15:17:07] because it seems confusing [15:17:14] the redirect shows up first ... user clicks it [15:17:24] the url in their web browser shows the old url [15:17:26] ki: A number of fields are supposed to appear, they don't with yours [15:17:30] they may link to the page using the old url [15:17:31] etc etc [15:17:54] ki: so, what you really want is not to hide these results, but *resolve* the redirects before showing them? [15:17:56] ki: http://asianwiki.com/index.php?title=Special:Search&search=Brain+Korean+Drama&fulltext=Search&profile=advanced&redirs=1&useskin=monobook [15:18:09] that sounds resonable to me, though it makes it non-obvious why that page turns up in the results [15:18:15] * Ulfr backs off and lets the guy who knows stuff do his thing :D [15:18:35] Ulfr: i'm just theorizing, i don't even know if that feature is present in the default search :P [15:18:40] yeah i see redirects all the time usually shows up before the current url [15:18:50] i would rather just not show redirects at all [15:19:27] ki: so if US redirects to USA, and someone searches for US, you don't want them to find USA? [15:19:27] 03(mod) E-mail notifications (enotifs) are not sent in the recipient's user interface language - 10https://bugzilla.wikimedia.org/2592 (10mybugs.mail) [15:19:43] nope [15:19:50] o_O [15:20:17] ki: you would rather the person have a bad user experience? [15:20:27] wait [15:20:41] if they search for US and it redirects to USA i would want them to find USA but not US [15:20:48] since there's nothing on the page but the redirect [15:21:01] ki: Or perhaps you are very certain that the appropriate WORDS pop up in the relevant pages for SEO purposes.... [15:21:24] a little SEO, but mainly for usability [15:21:37] if someone searches a title that's changed 3 or 4 times [15:21:51] makes sense to just show the current url ... and not the other 3 that has no information on the page but the redirect [15:22:19] ok, that sounds more reasonable :-) [15:23:08] we have to redirect some articles about 3 or 4 times ... so the results sometimes shows those 3 or 4 redirects [15:23:28] i would just like to exclude redirects [15:25:16] 03(mod) Can't view Special:ListFiles page: Call to a member function transform() on a non-object - 10https://bugzilla.wikimedia.org/38612 summary; +comment (10Andre Klapper) [15:25:35] 03(mod) File:Ipiales - D�cembre 2008.local.jpg - No metadata or resolution extracted from the file - 10https://bugzilla.wikimedia.org/39021 (10Andre Klapper) [15:25:53] 03(mod) [Regression] Warning: No such file or directory in /mw/includes/filerepo/backend/FSFileBackend.php on line 418 - 10https://bugzilla.wikimedia.org/39805 (10Andre Klapper) [15:26:11] New patchset: Siebrand; "Fix logging in user language" [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/42261 [15:26:27] neato so the url paramenter (redirs=0 or redirs=1) controls if the redirect shows [15:26:33] New review: Cmcmahon; "maintenance" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/42228 [15:26:33] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/42228 [15:26:40] its probably defaulted to show 1 [15:26:57] now to find where that happens and to make it show 0 [15:27:00] Hello [15:27:04] 03(mod) 404 Not Found The resource could not be found. File not found after file upload - 10https://bugzilla.wikimedia.org/43570 (10Andre Klapper) [15:27:15] hi General [15:27:30] ich have a little problem with my wiki [15:28:01] when i opend a page than comes that: Fatal error: Allowed memory size of 67108864 bytes exhausted (tried to allocate 546091 bytes) in /www/htdocs/w0086789/wiki_sgc/includes/parser/Parser.php on line 443 [15:30:09] 03(mod) windows-nonascii-filename and ForeignAPIRepo: Broken images for file names with nonascii letters - 10https://bugzilla.wikimedia.org/42900 normal->major; +i18n; summary (10Andre Klapper) [15:30:47] 03(mod) Commons images with embedded color profiles shown incorrectly - 10https://bugzilla.wikimedia.org/42827 (10Andre Klapper) [15:32:07] 03(mod) Unable to save thumbnail due to issues with getting sys dir for temp files - wfTempDir() - 10https://bugzilla.wikimedia.org/42730 +comment (10Andre Klapper) [15:32:20] 03(mod) ForeignAPIRepo should ignore file redirects to non-file - 10https://bugzilla.wikimedia.org/42610 (10Andre Klapper) [15:34:42] New patchset: Santhosh; "Renamed definition-diff to definitiondiff" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42262 [15:34:42] New patchset: Santhosh; "Show diff for the outdated messages" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42263 [15:34:43] New patchset: Santhosh; "Refactor the warnings code" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42235 [15:35:30] Could somebody can help me? [15:35:36] 03(mod) Page moves of files on commons slow - 10https://bugzilla.wikimedia.org/41612 (10Andre Klapper) [15:35:50] 03(mod) Cache pollution for error messages (keeps previous language) - 10https://bugzilla.wikimedia.org/41065 (10Andre Klapper) [15:36:46] General, which MediaWiki version? [15:36:47] 03(mod) All labels and lang codes displayed as English - 10https://bugzilla.wikimedia.org/43595 +comment (10Marius Hoch) [15:36:55] wait pleade [15:37:27] andre__ 1.19.0 [15:38:42] General, in general I'd recommend to run latest versions (in this series: 1.19.3) to get bugfixes. [15:38:45] General, tried https://www.mediawiki.org/wiki/Manual:Errors_and_symptoms#Fatal_error:_Allowed_memory_size_of_nnnnnnn_bytes_exhausted_.28tried_to_allocate_nnnnnnnn_bytes.29 already? [15:39:59] okay, can i do this with FTP [15:41:40] New patchset: Daniel Kinzler; "(bug 42064) AbuseFilter + EditFilterMergedContent" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/42268 [15:46:57] I am either stupid or its not obvious how to do simple things lol (I go with the first option) [15:47:07] how do I add / removes links from navigation? [15:47:23] jonjo: Do you mean the sidebar on the left? [15:47:28] yes [15:47:38] MediaWiki:Sidebar [15:47:43] that ist the page [15:47:52] how you can find it [15:47:54] https://www.mediawiki.org/wiki/Manual:Interface/Sidebar [15:48:37] 03(mod) Make AbuseFilter aware of Wikibase content models. - 10https://bugzilla.wikimedia.org/42064 +comment (10Daniel Kinzler) [15:49:36] 03(mod) Upload verification check broken. mp4 uploaded as .ogg - 10https://bugzilla.wikimedia.org/39012 +comment (10Andre Klapper) [15:49:44] General: For your issue - increase php's memory limit. You can set it in the php.ini config file [15:50:27] jonjo: If it makes you feel better, the whole sidebar thing is kind of unintuitive [15:51:32] :) [15:51:47] be nice if it was in an admin pannel [15:52:00] be nice if we had an admin panel ;) [15:52:23] (Well there is an admin links extension I suppose) [15:52:55] guess the idea is to make one [15:53:00] 03(mod) mw:extension:Listings needs to be able to override defaults for listing format and parameters - 10https://bugzilla.wikimedia.org/43220 +comment (10Carl Austin Bennett) [15:53:01] it is a blank canvas [15:53:19] 03(mod) mw:extension:Listings needs to be able to override defaults for listing format and parameters - 10https://bugzilla.wikimedia.org/43220 (10Carl Austin Bennett) [15:53:29] 03(mod) Accessing the download pages creates random HTTP 403 errors - 10https://bugzilla.wikimedia.org/43623 +comment (10Mathias Schindler) [15:54:59] am I able to hide toolbox to non admins? [15:55:10] nope [15:55:29] note that the toolbox admins get is different then the one's ordinary users get [15:56:01] or actually maybe not [15:56:21] 03(NEW) Add hooks for customizing filtering. - 10https://bugzilla.wikimedia.org/43635 normal; MediaWiki extensions: AbuseFilter; () [15:56:21] 03(mod) File with large history can't be deleted (timeout) - 10https://bugzilla.wikimedia.org/40174 +comment (10Andre Klapper) [15:56:25] 03(mod) Deleting of pages with high number of revisions makes server cry - 10https://bugzilla.wikimedia.org/11402 +comment (10Andre Klapper) [15:56:34] actually scratch that, sometimes there's extra links for admins on some pages [15:56:40] 03(mod) Add hooks for customizing filtering. - 10https://bugzilla.wikimedia.org/43635 (10Daniel Kinzler) [15:56:42] 03(mod) Make AbuseFilter aware of Wikibase content models. - 10https://bugzilla.wikimedia.org/42064 (10Daniel Kinzler) [15:56:56] 03(mod) Deleting of pages with high number of revisions makes server cry - 10https://bugzilla.wikimedia.org/11402 (10Andre Klapper) [15:57:39] andre__: don't think that is actually a dupe of that one [15:58:06] 03(mod) Add hooks for customizing filtering. - 10https://bugzilla.wikimedia.org/43635 +wikidata (10Daniel Kinzler) [15:59:10] bawolff: it sounded a lot to me (deletion of page with large history) [15:59:16] but feel free to correct me, please. [15:59:45] Well actually it depends if it was the large number of revisions that caused the issues, or the large number of image versions. Said page probably had both [16:00:24] the schema for images is quite a bit different then how revisions are stored, so a patch for one bug probably won't fix the other [16:00:29] * bawolff will write this on the bug [16:01:22] bawolff: I wanted to wave hi and ask how your new school term is going [16:01:53] sumanah: hi! Its going good. Its unfortunatly going to start again in about 3 days :( [16:02:05] * bawolff wants to stay on vacation doing nothing [16:02:34] * sumanah wants bawolff to stick around doing code review ;-) [16:03:03] * bawolff wants to stick around fixing mediawiki bugs [16:03:24] 03(NEW) Unnecessary ajax call - 10https://bugzilla.wikimedia.org/43636 normal; MediaWiki extensions: MobileFrontend (Beta); () [16:03:27] btw SpecialSearch.php line 160 toggling 0 : 1 to 1 : 0 seems to disable listing redirects ... for a narrow scope wiki seems to make results much more uncluttered and sane [16:05:27] 03(mod) File with large history can't be deleted (timeout) - 10https://bugzilla.wikimedia.org/40174 +comment (10Bawolff (Brian Wolff)) [16:06:03] 03(mod) Interwiki redirects shouldn't make up domains which are not configured as working - 10https://bugzilla.wikimedia.org/43123 +patch-in-gerrit; +comment (10Max Semenik) [16:06:36] ki: That sounds like something that should arguably be a configuration setting [16:06:52] yeah but couldn't find a configuration setting [16:06:54] New review: Hoo man; "Had a first look (untested)" [mediawiki/extensions/AbuseFilter] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42268 [16:07:09] would make sense to add a switch to localsettings [16:07:11] or similar [16:07:35] 03(mod) usability: displaying deletion status of subjectpagename and talkpagename at special:Watchlist/edit - 10https://bugzilla.wikimedia.org/20163 +comment (10Andre Klapper) [16:08:46] Change abandoned: Hoo man; "Better patch by Daniel Kinzler available: Ibb9d4c9a" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/34900 [16:09:21] New patchset: Siebrand; "Partial normalisation of hooks.txt" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42273 [16:09:22] New patchset: Siebrand; "Explicitely add two undocumented hooks" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42274 [16:09:22] New patchset: Siebrand; "Remove docs for hook LoggableUserIPData" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42275 [16:09:43] 03(mod) Moodbar comments & feedback should make checkuser table entries - 10https://bugzilla.wikimedia.org/32925 +comment (10Siebrand) [16:14:20] 03(NEW) Make edit count in user preferences link to list of contributions - 10https://bugzilla.wikimedia.org/43637 normal; MediaWiki: User preferences; () [16:14:48] 03(mod) I can not operate edit/movement/deletion for the page - 10https://bugzilla.wikimedia.org/17226 +comment (10Andre Klapper) [16:17:46] 03(mod) Fatal error: Call to a member function bind() on a non-object in UploadBase.php - 10https://bugzilla.wikimedia.org/40166 (10Andre Klapper) [16:18:11] sumanah, would you like to talk now? i've been reading the same disseration all day and honestly starting to lose focus so maybe it would help to stop for a little bit and keep going later [16:18:22] 03(mod) Move destination checker of UploadWizard into core so it can be re used by Special:Upload - 10https://bugzilla.wikimedia.org/40161 normal->15enhancement; summary (10Andre Klapper) [16:18:36] 03(mod) UploadStash returns unnecessary warnings on title - 10https://bugzilla.wikimedia.org/39990 normal->minor (10Andre Klapper) [16:18:44] mitevam: ok :-) I know what you mean [16:18:56] sumanah: plus it's getting late here and I want to make sure we have enough time before the end of the day [16:19:00] sure, makes sense. [16:19:03] am I able to do code blocks? [16:19:12] 03(mod) Unnecessary ajax call - 10https://bugzilla.wikimedia.org/43636 +comment (10Jon) [16:19:39] sumanah: do we discuss here? [16:19:42] mitevam: about what your first step ought to be regarding nurturing the vendor/ISV/enterprise MediaWiki community -- my first thought is that you'd start expanding the list you started on your userpage [16:19:46] mitevam: yeah, here is good [16:21:13] sumanah: yes ii think that would be a must, also i was thinking it might be helpful to categorize them in some manner depending on how they use mediawiki but maybe that will come naturally [16:21:56] mitevam: now that you've skimmed the archives of mediawiki-enterprise I think you'll have a few more entries to add [16:22:44] 03(mod) vector-simplesearch-containing message not loading on ar.wikipedia.org - 10https://bugzilla.wikimedia.org/41660 +i18n (10Andre Klapper) [16:23:23] sumanah: do you have any other specific suggestions on where do look? [16:23:45] sumanah: do you think it would be useful to browse bug reports for example [16:24:23] mitevam: yes, and valeriej and andre__ can probably help you figure out how to search Bugzilla best to find the bug reports from ISVs, vendors, hosts, etc. [16:25:12] ok so i will be in contact with them on monday for advise on that [16:25:24] 03(mod) I can not operate edit/movement/deletion for the page - 10https://bugzilla.wikimedia.org/17226 +comment (10Bawolff (Brian Wolff)) [16:25:29] mitevam, I didn't see the earlier conversation, but if you need help with Bugzilla, let me know. [16:25:42] mitevam: they're here now :) [16:25:44] hi valeriej [16:25:59] mitevam: Hello! [16:26:18] 03(mod) U+FA5B is normalized to U+8005 - 10https://bugzilla.wikimedia.org/17226 summary (10Bawolff (Brian Wolff)) [16:26:31] Nobody happened to notice and answer my question before I got booted from my desk, did they? [16:26:47] mitevam: you could take a break from dissertation-reading today if you want and just make a first attempt at adding some more people to contact to your list [16:26:47] hello, since i've reinstalled mediawiki some of my templates render strangely - you can have a look here http://www.rcheliwiki.com/Gaui_Hurricane_200 [16:26:57] does anyone know what might be the problem? [16:27:35] valeriej: thank you, yes, I will probably need some help figuring out how to browse bugzilla to identify active vendors/consultants/etc that have reported there [16:27:37] kitsched: Looks like tidy isn't on [16:27:40] !tidy [16:27:40] HTML Tidy is an external application that cleans up HTML for XHTML compliance (such as bad user input like
). Prior to the new preprocessor in 1.12 it was also needed for distributed, transcluded, or conditional HTML, or mixed HTML and wikitables, but newer versions allow it without Tidy. See [16:27:52] Ulfr: What was your question? [16:28:08] Hi & good morning valeriej! [16:28:10] valeriej: mitevam is https://www.mediawiki.org/wiki/User:Mitevam and is an intern working with me [16:28:36] valeriej: andre__ - sorry that other things got in the way of me being able to chat with you yesterday about figuring out the status of any given extension/component [16:28:37] bawolff: jQuery is attempting to output clean tables in my output, but somewhere in the abyss that is the mediawiki parser the table breaks and extra tags get put in like
and

[16:28:41] mitevam: Are you the one doing the vendor stuff? [16:28:43] mitevam, hmmm... finding bug reports from vendors and hosts. Now that is a good question. I don't think there's a categorization or tag for that. [16:28:44] valeriej: sorry, should have inriduced myself :) sumanah suggested you and andre_ could probably help [16:28:45] mitevam: Ok, I'll do what I can to help! [16:28:53] sumanah, no problem :) [16:28:54] andre__, Morning! [16:29:19] right, andre__, there's no one tag, but there are probably tricks we could brainstorm for how to find relevant bugs [16:29:23] bawolff: thanks, turning it on [16:29:33] Ulfr: Indeed, the MW parser is scary [16:29:38] 03(mod) Exception thrown on donate.wikimedia.org due to non-existing "monthly-link" element ID - 10https://bugzilla.wikimedia.org/40152 +comment (10Andre Klapper) [16:29:40] bawolff: yes I am the one [16:29:50] I have a ten minute blank spot in my memory where I decided to look at that code [16:30:04] sumanah, yeah, I'm wondering if there are specific words or such. But unlikely to be able to differentiate from shared/vhosts etc [16:30:06] New patchset: Santhosh; "Show diff for the outdated messages" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42263 [16:30:18] mitevam: Cool. I suppose OPW has been going on for a while now, but nonetheless, welcome to MediaWiki :) [16:30:33] Ulfr: yeah, the code is scary ;) [16:30:46] wiki table syntax has always scared me [16:30:51] I still don't really understand it [16:31:01] bawolff: thank you! it's only been three days now actually since it officially started [16:31:01] but the behavior only manifests when I do a += on a separate line in jQuery [16:31:05] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42273 [16:31:08] sumanah, andre__, mitevam: How about checking emails? Maybe some vendors have name@vendor.com. [16:31:12] when I define the tables on one line it works fine [16:31:18] but editing is no fun :( [16:31:38] valeriej: yeah, mitevam and I could make a small list of the possible vendors and look for those domain names in BZ [16:31:50] yeah, that could work. [16:32:09] of course this would not help us find vendors we had never thought of before, which is part of the goal here [16:32:24] still the problem remains of how to identify ones we dont know about [16:32:52] but it would help us find the *individuals* who would be responsive at vendors we *do* know about [16:32:53] 03(mod) Periodical run of currently disabled special pages - 10https://bugzilla.wikimedia.org/15434 +comment (10Dennis C. During) [16:33:08] andre__, sumanah: It's a place to start. Maybe the reports have stuff in common and you could pick up another search from there. [16:33:13] yeah [16:33:53] Ulfr: What exactly are you doing? Is this some script that runs in the site js? Or is jQuery making wikitext which is then getting put through the parser? [16:34:01] sumanah: on a separate note maybe i should contact the people who created the list you sent me earlier and ask them how they approached the problem, they might have some ideas [16:34:04] 03(mod) Periodical run of currently disabled special pages - 10https://bugzilla.wikimedia.org/15434 +comment (10JackPotte) [16:34:17] bawolff: It's a widget that hypothetically bypasses the wikitext parser [16:34:19] YuviPanda, http://lists.wikimedia.org/pipermail/wikimediaindia-l/2013-January/009126.html [16:34:42] mitevam: which list .... the mediawiki-enterprise list, the mediawiki-distributor list, or something else? [16:34:53] the wikimatrix or list of consultants? ..... [16:34:58] bawolff: Here's the current source with the tables from hell http://www.wikidoc.org/index.php?title=Widget:SandboxNew&action=edit [16:35:00] ah I think you might mean that last one [16:35:03] yes, that's a good idea [16:35:06] sumanah: the wikimatrix list [16:35:19] right [16:35:21] yes, that's a good idea [16:35:47] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42274 [16:36:07] 03(mod) #content_0 missing on small pages - 10https://bugzilla.wikimedia.org/43271 +comment (10Jon) [16:36:43] mitevam: ok! that seems like a task you can work on for the next few work hours and then we'd check in again on Monday.... I figure next week you can start contacting folks or we can strategize a little first about what to ask & offer [16:37:04] hi sumanah see http://lists.wikimedia.org/pipermail/wikimediaindia-l/2013-January/009125.html about hackathons organized in India [16:37:08] Ulfr: try putting the table in a temporary variable (+= 'ing the various lines) and then when fully done making the table, do Q.innerHtml += tempVariable [16:37:16] sumanah: also, so far i have been collecting very minimal information about them, should I try to collect more than just contact info /location? [16:37:35] sumanah, some background about previous hackathons there and the involvement (or not involvement) desired by WMF is welcome [16:37:45] bawolff: Same effect. I can define everything into variables and THEN define it in the same linebut it's something about += that throws everything off [16:37:46] qgil_: looking [16:38:00] New review: Mattflaschen; "If you change it again, remove .svn" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/42216 [16:38:16] sumanah, basically to know if there is anything I need to do [16:38:21] Ulfr: I believe once you append to innerHtml, the browser tries to fix up your html, so if you append half a table, the browser closes the tags, and when you append the second half, the tags from the previous half are now closed (or that's my theory anyhow) [16:38:28] mitevam: I think it's going to be useful for you to collect some freeform notes about what the business or org does, how active they seem to be, how on-the-ball they are, and what their business model is [16:38:31] sumanah: strategise first seems like a good idea, it should not take long [16:38:35] bawolff: ... [16:38:39] * Ulfr facepalms [16:38:53] mitevam: "on-the-ball"ness you may want to keep private, but the rest, you could throw into that table on your wiki page [16:39:32] hi I am installing mediawiki on linux even I chmod 770 to the config file I am still getting the error You don't have permission to access /wikipedia/mw-config/index.php on this server. [16:39:46] bawolff: If you're right I owe you a beverage of your choice [16:39:48] sumanah: would there be another place other than bugzilla to look for them to check if they have been active in the community (not only active as a business) ? [16:39:55] yes [16:40:14] ardian: did you chown to your web server's user? [16:40:20] mediawiki.org, the mailing lists (especially the ones I've mentioned already), IRC logs (although those will be tough to search) [16:41:13] mitevam: mediawiki.org and the mailing lists seem actually *more* promising in some ways than the Bugzilla bugs/enhancement requests [16:41:23] some of them will have actually already contributed code [16:41:40] sumanah / mitevam : Actually there's a search interface for the irc logs now (although I don't know how far back it goes) [16:42:31] sumanah: ok mediawiki.org, mailing lists, irc logs, bugzilla [16:42:41] * bawolff thought there was anyhow. Maybe I imagined it [16:42:45] would be the places to look [16:42:51] mitevam: Code contributions before March 2011 went into Subversion and there is an interface to browse it at https://www.mediawiki.org/wiki/Special:Code/MediaWiki -- https://www.mediawiki.org/wiki/Special:Code/MediaWiki/author and https://www.mediawiki.org/wiki/Developers/Accounts are good places to skim [16:43:05] Ulfr: I only chmod the mw-config dir with chown -R 770 [16:43:21] * yuvipanda_ notes to sumanah that most of the IRC logs seem to be… gone [16:43:22] New patchset: Mattflaschen; "(bug 43144) Refactor to use i18n for extension tours." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/41374 [16:43:23] mitevam: the descriptions at https://www.mediawiki.org/wiki/Developers/Accounts are good to look at [16:43:29] yuvipanda_: petan is the person to talk to about that. [16:43:34] at least in the link in topic (only a tiny subset) [16:43:42] ardian: But the web server's user actually has to own the data [16:43:43] yeah, i'll poke him in a bit. just saw you talking about them so thought i should blurt that out [16:43:51] sumanah / mitevam : http://bots.wmflabs.org/~wm-bot/searchlog could be helpful in searching logs. Some older logs probably at the old mwbot toolserver account [16:43:58] I forget what the first two bytes are, but the last one is everybody [16:44:14] Ulfr: aha [16:44:18] first byte is owner, second byte is group [16:44:27] can you give me the command for that [16:44:43] bawolff: That makes little sense though, as how can an owner not write to or edit his files? [16:44:54] ardian: What's your web server's user? [16:44:57] mitevam: so, for your first pass today/early Monday, I suggest you look at that list of developers, then mediawiki.org, then mailing lists [16:45:30] Ulfr: for other applications I didn't have to use any other user I used my normal system user [16:46:01] Ulfr: While the owner would just have to change the permissions, it could be useful as an extra "did you really mean to delete this file" type check [16:46:09] 03(mod) Vector CSS rule for behavior points to a non-existent file due to versioned path - $wgLocalStylePath misconfigured? - 10https://bugzilla.wikimedia.org/42858 +shell; summary; +comment (10Andre Klapper) [16:46:12] ardian: Are you using debian or unbuntu linux? [16:46:24] ok that sounds like a good start, and I will contact the wikimatrix people , and probably get more ideas as it goes [16:46:36] bawolff: debian [16:46:40] 03(mod) Hide / display file contents on pages depending on tags - 10https://bugzilla.wikimedia.org/40349 normal->15enhancement (10Andre Klapper) [16:46:54] ardian: apache runs as a user named www-data [16:46:54] sumanah: should I edit the same table i used before or make a new one as that was a "first contribution" for the application? [16:47:06] 03(mod) No tooltip for X button in Search field; ambiguous meanings of "X" buttons in dialog - 10https://bugzilla.wikimedia.org/43587 (10Andre Klapper) [16:47:11] 03(mod) zh-min-nan and nan are treated as separate languages - 10https://bugzilla.wikimedia.org/43569 (10Andre Klapper) [16:47:11] mitevam: seems to me like editing that table is fine [16:47:26] if people want to see what the "original contribution" was they can look in the page history [16:47:40] bawolff: so chown www-data * [16:47:54] mitevam: and eventually when your table grows a bit more we'll move it to someplace better on the site and hook into it from https://www.mediawiki.org/wiki/Enterprise_hub [16:48:02] that would do it [16:48:13] 03(mod) ProofreadPage uses too many global variables - 10https://bugzilla.wikimedia.org/37836 (10Andre Klapper) [16:48:14] 03(mod) Code quality issues (tracking) - 10https://bugzilla.wikimedia.org/700 (10Andre Klapper) [16:48:15] 03(mod) ProofreadPage extension configuration is cumbersome - 10https://bugzilla.wikimedia.org/37839 (10Andre Klapper) [16:48:20] mitevam: or https://www.mediawiki.org/wiki/Sysadmin_hub [16:48:35] 03(mod) ResourceLoader-ify Quiz CSS - 10https://bugzilla.wikimedia.org/38372 (10Andre Klapper) [16:49:27] 03(mod) PagedTiffHandler: The uploaded file contains errors: $1 - 10https://bugzilla.wikimedia.org/41318 +easy (10Andre Klapper) [16:49:32] ardian: instead of changing the owner though, you could just make the mode be something like 774 [16:49:33] mitevam: you might also want to know about https://www.mediawiki.org/wiki/MediaWiki_testimonials and https://www.mediawiki.org/wiki/Sites_using_MediaWiki which are out of date, I'm sure, but useful for raw materials [16:49:38] and then everyone can read the files [16:49:47] Yuvipanda yes? [16:49:52] 03(mod) PagedTiffHandler assumes one-based page numbers; doesn't work with ImageMagick 6.7.7-2 which returns zero-based page numbers - 10https://bugzilla.wikimedia.org/37692 (10Andre Klapper) [16:50:19] the only file you probably don't want world readable is LocalSettings.php since it has your database password. The rest should be totally fine to be world readable [16:50:40] (although if you have image uploading enabled, you probably want the image subdirectory owned by the apache user) [16:51:05] mitevam: sound good? [16:51:10] sumanah: ok thank you, bookmarking all of that [16:51:29] sure! ok, cool, and I'm around of course the rest of your day :) [16:51:40] sumanah: yes, i will probably end up having more questions once i get started but good for now [16:51:42] bawolff: nothing is woring very strange [16:51:50] cool! [16:51:51] I will get the error [16:51:53] 03(mod) Add MediaWiki:Multiboilerplate to the Admin Links page - 10https://bugzilla.wikimedia.org/33435 (10Andre Klapper) [16:51:56] 03(mod) Add support for optgroups - 10https://bugzilla.wikimedia.org/41788 (10Andre Klapper) [16:51:58] 03(mod) extension label and legend fail to load properly - 10https://bugzilla.wikimedia.org/39622 (10Andre Klapper) [16:52:06] 03(mod) Allow wikilinks in boilerplate page - 10https://bugzilla.wikimedia.org/41787 (10Andre Klapper) [16:52:12] and thank you valeriej, andre_ and bawolff for the help ! [16:52:39] no problem. I didn't feel very helpful yet, though :P [16:52:42] ardian: Oh, for the chown command, you also need a -R so it recurses through all the directories [16:53:01] bawolff: I actually did it [16:53:10] andre__: valeriej - is now a good time for us to talk about sources of information re the recency & importance of various MW extensions? [16:54:02] qgil_: I'm still looking at http://lists.wikimedia.org/pipermail/wikimediaindia-l/2013-January/009125.html and thinking [16:54:06] I think I should read the whole thread [16:54:25] andre__: I like it when you go on mass bug prioritizing drives, I find out about all sorts of interesting new bugs I've never heard of before [16:54:27] sumanah, valeriej, I'd have time, sure. [16:54:56] 03(mod) Deleted feedback messages can't be restored - 10https://bugzilla.wikimedia.org/40981 (10Andre Klapper) [16:56:16] sumanah, andre__: Oh, yes. I'm available. [16:56:40] 03(mod) No fallback for dynamic sections - 10https://bugzilla.wikimedia.org/42746 (10Max Semenik) [16:56:40] 03(mod) Stop parsing HTML twice - 10https://bugzilla.wikimedia.org/41569 (10Max Semenik) [16:57:04] valeriej: andre__ - ok! so, to start, valeriej, what browser are you using? [16:57:21] New review: Mattflaschen; "Siebrand, git has implicit renames. In your local git repo, you can use git log --follow newfilenam..." [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/30177 [16:57:41] valeriej: I ask because if you're using Firefox then you can use some special scripts that Andre developed -- have you heard of Greasemonkey? [16:57:47] sumanah: firefox 17 [16:57:50] New review: Mattflaschen; "Siebrand, see also http://git-scm.com/book/ch2-2.html#Moving-Files and http://stackoverflow.com/ques..." [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/30177 [16:58:04] 03(mod) Periodical run of currently disabled special pages - 10https://bugzilla.wikimedia.org/15434 +comment (10Bawolff (Brian Wolff)) [16:58:05] New review: Matmarex; "Well, you could have just adjusted the entry in jshintignore and added a magic comment to the JS fil..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42240 [16:58:27] sumanah: Oh, yes, I have those installed, but I actually need to update them with the ones I got yesterday. [16:58:41] valeriej: ok! ah, ok, good to know [16:58:48] 03(mod) zh-min-nan and nan are treated as separate languages - 10https://bugzilla.wikimedia.org/43569 +patch-need-review; +comment (10Amir E. Aharoni) [16:58:59] hi #mediawiki [16:59:01] sumanah, valeriej: I've sent "my" version (which includes email addresses) yesterday via email, yeah [16:59:14] which colors extensions in buglist.cgi and show_bug.cgi [16:59:23] andre__: ah, I SEE, the one that has private stuff that cannot be in the public repo. Got it [16:59:41] sumanah, yeah, I don't want to put email addresses of other people into a repo [17:00:07] makes sense [17:00:49] 03(mod) State that CC licenses with nc are discouraged in the installer - 10https://bugzilla.wikimedia.org/37512 normal->15enhancement (10Andre Klapper) [17:01:43] 03(mod) Strange notification from mediawiki.org - 10https://bugzilla.wikimedia.org/43625 +comment (10Carl Fürstenberg) [17:01:59] I'm gonna add them all until it's fixed :-P [17:02:16] valeriej, sumanah: What quickly comes to my mind about this: I often take a look at the extension's homepages at www.mediawiki.org/wiki/Extension:Foo to get an idea how old or relevant they are (e.g. still in SVN instead of Git: Likely not maintained), in combination with checking what's deployed in https://noc.wikimedia.org/conf/InitialiseSettings.php.txt and https://noc.wikimedia.org/conf/CommonSettings.php.txt [17:02:52] valeriej, sumanah: There are several extensions that are definitely dead, e.g. "UsabilityInitiative". However the bug reports might include some info that is still applicable and valid. [17:03:07] New review: Matmarex; "Just because it merges doesn't yet mean it is still compatible. I've had such issues with git and lo..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/37395 [17:03:50] valeriej, sumanah: so I really hope that the coloring done by the Greasemonkey script (green=deployed, yellow=in progress, red=not deployed on WM wikis) helps you a bit [17:05:43] 03(mod) jQuery color button classes (ui-button-blue, ...) don't show focus and active state properly - 10https://bugzilla.wikimedia.org/37743 normal->minor (10Andre Klapper) [17:05:51] sumanah: andre__ told me about checking InitialiseSettings.php.txt and CommonSettings.php.txt. And the scripts that I have are helpful. [17:06:22] Hopefully kaldari (is he on irc usually) fixes it [17:06:36] valeriej: ok! rockin'. There's 1 more place I wanted you to know about: https://www.mediawiki.org/wiki/Review_queue [17:08:12] 03(mod) help installer deal with memory_limit being too low to load installer i18n - 10https://bugzilla.wikimedia.org/41896 +comment (10Andre Klapper) [17:08:28] sumanah: Ah, thanks! [17:08:33] afaik I've not started soon to all pages on mediawiki.org ツ [17:09:27] valeriej: you're welcome! There are a few extensions in that list that you will probably run into, like Drafts (which we discussed a little yesterday) and SVGEdit [17:09:58] are there anyone else getting echo messages? [17:10:04] valeriej: you may find it useful to watch for the new Wikipedia Signpost every week -- it has a tech report like https://en.wikipedia.org/wiki/Wikipedia:Wikipedia_Signpost/2012-12-24/Technology_report that will help you stay up to date about some of the goings-on in the tech community [17:10:07] 03(mod) Incorrect path detection in NoLocalSettings.php - 10https://bugzilla.wikimedia.org/39232 normal->major (10Andre Klapper) [17:10:15] or am I the only one? [17:10:26] I have no echo messages [17:10:42] AzaToth: you could try sending some kind of echo message to User:Sharihareswara (WMF) [17:10:45] and I could see whether I receive it [17:10:59] sumanah: I din't know how to trigger them [17:11:11] sumanah: I'm getting echo messages for stuff other people are doing [17:11:20] sumanah: Yes, I'll do that. I would have responded differently to that report knowing this, so this information will definitely be helpful. [17:11:27] for example yaron's latest edit [17:12:09] sumanah: see https://bugzilla.wikimedia.org/43625 [17:12:30] (haven't added the lastes two ones though) [17:12:35] 03(mod) Diff pages of archive pages contain some broken links - 10https://bugzilla.wikimedia.org/42608 (10Andre Klapper) [17:12:57] 03(mod) Show diff from empty text for diff=0&oldid= - 10https://bugzilla.wikimedia.org/41364 normal->minor (10Andre Klapper) [17:13:07] 03(mod) help installer deal with memory_limit being too low to load installer i18n - 10https://bugzilla.wikimedia.org/41896 +comment (10Bawolff (Brian Wolff)) [17:13:07] Huh, what? [17:13:25] yaron: "User:Patelmm79, User talk:Patelmm79, User talk:Amblerllc, User talk:Xavi, User talk:Protnet, User talk:Robertseetzen, User talk:Kodene, Template:Create person were linked by MediaWiki user Yaron Koren, from this page: Extension talk:Semantic Forms/Archive November to December 2012" [17:13:30] Oh, I see. [17:13:47] and echo thinks I've created one of the pages [17:13:51] or all [17:13:59] 03(mod) HistoryAction Invalid message parameter: a:1:{s:3:"raw";N;} - 10https://bugzilla.wikimedia.org/41308 summary (10Andre Klapper) [17:14:13] the best one yet was "Länk was linked by MediaWiki user Taidokas, from this page: User:Taidokas" ツ [17:14:26] [[Länk]] is a redlink [17:14:37] 03(mod) Don't show a rollback link when there's no others' revision to rollback to - 10https://bugzilla.wikimedia.org/39397 (10Andre Klapper) [17:15:32] Change abandoned: Jeroen De Dauw; "The serialization code already is robust" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42090 [17:15:44] AzaToth: wow, on so many levels [17:16:15] Is it really the plan that echo will tell us when someone links to a page we are somehow watching or created? because that sounds like it would be annoying [17:16:37] seems so [17:16:53] aat least created [17:17:16] but it seems to be "pages we might create in the future because we where notified about them" [17:18:00] * AzaToth starts to think illuminatis is behind echo [17:19:29] sumanah: thus I don't know how to send you a echo message, as it seems to be totally random [17:19:54] perhaps if I create a page linking to [[Grughtztrobghr]] it might send you one... [17:21:19] 03(mod) "Updated since last visit" markers should not be reset by viewing old revisions - 10https://bugzilla.wikimedia.org/41759 (10Andre Klapper) [17:21:45] 03(mod) "updated since my last visit" shown incorrectly due to lag - 10https://bugzilla.wikimedia.org/12803 +comment (10Andre Klapper) [17:22:08] 03(mod) Option in preferences to disable "updated since my last visit" - 10https://bugzilla.wikimedia.org/38812 minor->15enhancement; summary (10Andre Klapper) [17:23:13] bawolff: You got it in one man :) [17:23:37] Glad to help :) [17:23:44] 03(mod) No way to do logins without user surrendering their password to software - 10https://bugzilla.wikimedia.org/35199 (10Matthew Flaschen) [17:23:46] 03(mod) Add Oauth support to Mediawiki - 10https://bugzilla.wikimedia.org/30348 (10Matthew Flaschen) [17:25:11] 03(mod) Global (to a wiki farm or family) message delivery (thoughts) - 10https://bugzilla.wikimedia.org/35306 +comment (10Ningauble) [17:27:11] 03(mod) File with large history can't be deleted (timeout) - 10https://bugzilla.wikimedia.org/40174 +comment (10Bawolff (Brian Wolff)) [17:27:34] bawolff: old memories ツ [17:28:02] hmm? [17:28:59] the old days when you had to run crying to brion when you accidentally deleted the sadnbox [17:29:11] lol [17:29:30] That was before my time, but I've heard stories [17:29:57] yea, they added the 5000 max rev limit [17:30:24] AzaToth: bawolff - I agree, I'm not clear on under what circumstances I ought to receive an EMAIL notification from Echo; I got something kind of like you did, AzaToth [17:30:35] re a page I made being affected by another person's move [17:30:54] 03(mod) Can't authenticate using my mother language username (UNICODE) when I only have (a public) access to Wikipedia with an ASCII (english) keyboard - 10https://bugzilla.wikimedia.org/34590 +comment (10Andre Klapper) [17:31:09] sumanah: well, I'm getting emails for pages/links I've never been at [17:31:24] I haven't yet checked whether it's legitimately a page I made [17:32:09] unless I have the power to create redlinks... [17:32:30] 03(mod) Rollback of one IPv6 address to another IPv6 address's edit needs shorter edit summary - 10https://bugzilla.wikimedia.org/37356 (10Andre Klapper) [17:32:31] sumanah: I got notification for this page: http://www.mediawiki.org/wiki/User:Taidokas [17:34:05] 03(mod) Strange notification from mediawiki.org - 10https://bugzilla.wikimedia.org/43625 (10bsitu) [17:35:08] sumanah: could be because it seems I'm the only one using the mobile frontend in the universe ツ [17:35:41] thus it singled me out for punishment or something ツ [17:35:56] New patchset: Matmarex; "$.tablesorter: remove and inline getTextFromRowAndCellIndex()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42276 [17:35:56] New patchset: Matmarex; "(bug 40044) make $.tablesorter treat alt attribute like text" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/23100 [17:37:36] 03(mod) Special:Contributions no longer shows at the top that the user you're looking at is blocked - 10https://bugzilla.wikimedia.org/37853 (10Andre Klapper) [17:38:55] New review: Matmarex; "Jarry1250: there doesn't seem to be much point, but I split off the cleanup to change I519cc1f0 anyw..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/23100 [17:39:08] New review: Matmarex; "Split out from I3e9898f3." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/42276 [17:39:15] 03(mod) After switching patrolling off, impossible to effectively hide patrol log entries in Special:Log - 10https://bugzilla.wikimedia.org/42246 (10Andre Klapper) [17:39:16] 03(mod) Create complete and up to date documentation on how to use job queue - 10https://bugzilla.wikimedia.org/42862 (10Andre Klapper) [17:42:53] 03(mod) LoadBalancer::commitMasterChanges: Explicit commit of implicit transaction - 10https://bugzilla.wikimedia.org/40877 +comment (10Andre Klapper) [17:43:00] 03(mod) PHP notices: Explicit commit of implicit transaction and Transaction already in progress - 10https://bugzilla.wikimedia.org/43575 +comment (10Andre Klapper) [17:43:10] 03(mod) Notices while creating another account - 10https://bugzilla.wikimedia.org/41462 +comment (10Andre Klapper) [17:43:11] New review: Siebrand; "> That said, your work would have been much better spent on fixing bugs or reviewing or something." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42240 [17:43:54] New patchset: Nischayn22; "Fix usage of Microsoft's translation service." [mediawiki/extensions/LiveTranslate] (master) - https://gerrit.wikimedia.org/r/40092 [17:44:45] New review: Matmarex; "There is more than enough JS bugs to be handled and features to be written, if that's what floats yo..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42240 [17:46:12] sumanah, "I think I should read the whole thread" Well, you can better put your time on your ToDo, I think. :) The AffCom and me are being respectful to some of the India chapter member opinions but eventually they will see these groups are no harm for them [17:46:18] New review: Siebrand; "L10n/i18n looks fine." [mediawiki/extensions/GuidedTour] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/41374 [17:48:12] 03(mod) Internal error "Undelete failed; someone else may have undeleted the page first" restoring page - 10https://bugzilla.wikimedia.org/28632 +comment (10Andre Klapper) [17:48:15] 03(mod) Undeleting old versions of files proceeds successfully but gives error and fails to log - 10https://bugzilla.wikimedia.org/39299 major->normal; +comment (10Andre Klapper) [17:48:36] 03(mod) Internal error "Undelete failed; someone else may have undeleted the page first" restoring page - 10https://bugzilla.wikimedia.org/28632 (10Andre Klapper) [17:48:37] 03(mod) Improve the error message presented when attempting to undelete a page for which the topmost revision is hidden - 10https://bugzilla.wikimedia.org/23594 (10Andre Klapper) [17:49:01] 03(mod) Problem with file deletion - 10https://bugzilla.wikimedia.org/40802 +comment (10Andre Klapper) [17:49:12] 03(mod) action=delete returns 1 when two of them being submitted simultaneously - 10https://bugzilla.wikimedia.org/40296 (10Andre Klapper) [17:50:15] 03(mod) Deletion of file failed to delete the actual file - 10https://bugzilla.wikimedia.org/39413 (10Andre Klapper) [17:50:36] 03(mod) On Special:Undelete don't show undeleterevdel - 10https://bugzilla.wikimedia.org/39404 (10Andre Klapper) [17:51:34] qgil: thanks for the reply there :) [17:51:36] qgil_: ^ [17:52:35] YuviPanda, thanks. And also thank you for letting me see that yesterday I rushed leaving laptop A on (with qgil) and now I'm on laptop B with qgil_ :) [17:52:49] :P [17:52:53] glad you noticed your tail :P [17:53:04] thanks qgil from me also :) [17:53:05] er... [17:53:06] and now i notice that i've a bouncer running somewhere and i'm not connected to it :P [17:53:32] (tail -> _ suffix) [17:53:46] 03(mod) Problem with file deletion - 10https://bugzilla.wikimedia.org/40802 +comment (10MaxBioHazard) [17:54:19] yuvipanda_ you also have a tail, right. harshkothari I hope to see progress in the next days. [17:54:45] yeah I also hope the same qgil_ :) [17:56:12] 03(mod) MessageContent varies by userlang but its content gets in parser cache without that option set - 10https://bugzilla.wikimedia.org/41065 summary; +comment (10Bawolff (Brian Wolff)) [17:56:43] Change merged: Reedy; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/42048 [17:58:24] 03(mod) zh-min-nan and nan are treated as separate languages - 10https://bugzilla.wikimedia.org/43569 (10Amir E. Aharoni) [18:02:05] New patchset: Liangent; "(bug 22457) More natural flow for the "By e-mail" feature" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/38905 [18:03:42] New review: Mattflaschen; "Great, thanks. Ori and/or S, please review today when you get a chance." [mediawiki/extensions/GuidedTour] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/41374 [18:04:43] 03(mod) After switching patrolling off, impossible to effectively hide patrol log entries in Special:Log - 10https://bugzilla.wikimedia.org/42246 +comment (10Bawolff (Brian Wolff)) [18:06:45] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41023 [18:07:09] New patchset: Aaron Schulz; "Use consistent hashing for SqlBagOStuff servers" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42226 [18:07:57] New review: Liangent; "Failure in PS7 looks random. Can someone diagnose it?" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/38905 [18:08:34] New patchset: Umherirrender; "(bug 40667) deprecate rc_cur_time of recentchanges" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42278 [18:08:50] 03(NEW) labsconsole requires captcha when adding selflinks - 10https://bugzilla.wikimedia.org/43638 normal; Wikimedia Labs: General; () [18:09:32] New review: Umherirrender; "Commited as alternative for I3fc175dd" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/42278 [18:10:22] New review: Umherirrender; "Alternative with schema change in next version: I4a9c2fa8" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/35659 [18:10:38] hi [18:10:43] hi lbenedix [18:10:53] can someone help me with the database access for an extension? [18:11:37] i read http://www.mediawiki.org/wiki/Manual:Database_access but that leaves open questions [18:13:20] Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42226 [18:14:05] 03(mod) Remove ability-to-remove-bureaucrat from en.wiktionary bureaucrats - 10https://bugzilla.wikimedia.org/42113 -shellpolicy +shell; +comment (10Dereckson) [18:14:05] lbenedix: What's your question? [18:14:45] i want to print a table i created on a special page [18:15:27] 03(mod) After switching patrolling off, impossible to effectively hide patrol log entries in Special:Log - 10https://bugzilla.wikimedia.org/42246 (10Bawolff (Brian Wolff)) [18:15:54] Do you have a general idea of what the code should look like from the MW doc, or are you totally lost? [18:16:14] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42082 [18:17:00] Is there a maintenance script or something that can be used to go through page, check if the latest revisions are redirects or not, and update the is_redirect column accordingly? [18:17:06] $dbr = wfGetDB( DB_SLAVE ); $res = $dbr->query('SELECT * FROM `uifeedback`');foreach( $res as $row ) {/**/} [18:17:16] I've... had an error with my wiki. [18:17:28] New patchset: Brian Wolff; "(bug 42246) Always allow hiding patrol entries from main Special:log" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42279 [18:18:01] Isarra: depending on how many pages you have, you could do a null edit on each. [18:18:04] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39849 [18:18:09] lbenedix: Ok. In general we prefer people don't use $dbr->query, but use the $dbr->select wrapper instead [18:18:09] MatmaRex: Hundreds of thousands. [18:18:11] New review: Aaron Schulz; "Is this missing something?" [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/40574 [18:18:29] Isarra: I actually think there is. I wonder if refreshLinks.php would do it... [18:18:34] bawolff: Nope. [18:18:37] Doesn't. [18:18:40] Isarra: ah. well, there are dozens of the scripts there [18:18:44] I ran it thrice! [18:18:49] I ran other random scripts! [18:18:49] there's gotta be one for it [18:18:52] It threw mice at it! [18:19:15] Dammit, it'd be such an easy script to write if I just had a damn working computer. [18:20:08] ori-l: hi, can we talk ? [18:20:29] 03(mod) After switching patrolling off, impossible to effectively hide patrol log entries in Special:Log - 10https://bugzilla.wikimedia.org/42246 +patch-in-gerrit; +comment (10Bawolff (Brian Wolff)) [18:21:49] lbenedix: in this case, the select would look something like $dbr->select( 'uifeedback', '*', '', __METHOD__ ); [18:22:05] 03(NEW) Flag/exclude events originating from WMF's IP range - 10https://bugzilla.wikimedia.org/43639 normal; MediaWiki extensions: EventLogging; () [18:22:12] 03(NEW) SVG to PNG: font rendering problem in Persian - 10https://bugzilla.wikimedia.org/43640 normal; Wikimedia: SVG rendering; () [18:22:18] 03(mod) SVG to PNG: font rendering problem in Persian - 10https://bugzilla.wikimedia.org/43640 (10Huji) [18:22:19] 03(mod) SVG rasterisation on Wikimedia sites (tracking) - 10https://bugzilla.wikimedia.org/8901 (10Huji) [18:22:21] Isarra: http://www.mediawiki.org/wiki/Manual:Edit.php , the last example may be useful, by just passing the contents of getText.php without any other intermediate modification. You'll need to get a list of pages and iterate over all of them executing that script, though [18:22:24] bawolff: i think thats not the problem... i dont know how to get the data from the rows [18:22:33] hi guys, im having this weird issue where mediawiki doesn't recognize that i'm logged in, despite getting the session cookies [18:22:38] lbenedix: oh [18:22:47] works fine on my production server, but stage and local don't seem to be working at all [18:23:03] bawolff: get_class gives me stdClass [18:23:03] na8flush: what version? [18:23:13] 03(mod) Add ability to remove sysop/bureaucrat to fi.wikipedia bureaucrats - 10https://bugzilla.wikimedia.org/42114 +comment (10Dereckson) [18:23:13] 1.18 [18:23:27] yes, you generally access the members using -> operator [18:23:37] 03(mod) SVG to PNG: font rendering problem in Persian - 10https://bugzilla.wikimedia.org/43640 (10Huji) [18:23:38] 03(mod) RTL/bidirectional issues (tracking) - 10https://bugzilla.wikimedia.org/745 (10Huji) [18:23:53] bawolff: $row->column1 ? [18:24:01] sumanah: sorry, 1.19.2 [18:24:18] na8flush: is the wiki public so we can test it? [18:24:36] basically [18:24:54] foreach( $res as $row ) { $row->nameOfCol } [18:25:03] yay [18:25:08] that works [18:25:21] hmm, there should be an example of how to do that on the wiki page [18:25:25] Vulpix: it's not, sorry. I use the API to integrate login to my website, so i set the cookies manually [18:25:52] bawolff: not on http://www.mediawiki.org/wiki/Manual:Database_access [18:26:23] lbenedix: sorry, I meant to say that I need to fix the wiki page so that it gives an example [18:26:37] 03(mod) Strange notification from mediawiki.org - 10https://bugzilla.wikimedia.org/43625 (10bsitu) [18:26:39] Vulpix: By list of pages, do you mean the contents of the page table? [18:26:40] next Question: i have images in that table, how do i get them into the specialpage? [18:27:37] na8flush: setting the cookies yourself - could it be something like your staging wiki has a different db name or something then production, but you're setting the type of cookie your production wikis expect (cookies have things like db name in them to differentiate between separate wikis) [18:28:18] and is there a nice way to create tables on a special-page? [18:28:37] lbenedix: You can use the function wfFindFile( 'file name' ) to get a file object [18:28:40] bawolff: i don't think theres any db info in the cookies, at least not what i set. here's mine: LCMwiki_session=7462db7e899bd8f483a7852001e08246; LCMwikiUserID=24; LCMwikiUserName=Ross.hettel; [18:28:51] 03(mod) Flag/exclude events originating from WMF's IP range - 10https://bugzilla.wikimedia.org/43639 normal->15enhancement; +comment (10Steven Walling) [18:28:51] bawolff: I have a gerrit question re. "how to" follow comments by code reviewers.pls. let me know when I can ask... [18:28:53] bawolff: the images are stored in the database [18:29:25] bawolff: i do use subdomains, which i thought was my problem, but checking the wiki log i can see that the cookies are being received by mediawiki, so that's not it [18:29:32] lbenedix: You mean like the image itself (its binary code) is in the database? [18:29:39] yepp [18:30:16] lbenedix: You may have to create another special page, to serve the images. Try looking into wfStreamFile() [18:30:43] 03(mod) Suppressredirect for patrollers on dawiki - 10https://bugzilla.wikimedia.org/43548 +comment (10Christoffer G. Thomsen) [18:31:50] lbenedix: Well actually, I'm not sure how much StreamFile class will help you. [18:32:11] Isarra: well, a list of FULLPAGENAME, unless you want only mainspace pages... [18:32:30] Vulpix: I have a database. [18:32:36] Of stuff. [18:32:38] There's stuff. [18:32:40] You basically have to create a special page that calls $this->output->disable(), sets a contet-type header, and then echo 's the binary content of image [18:32:42] In the database. [18:32:52] Sorry, I'm... not... er... [18:32:58] * Isarra hugs Vulpix and runs away. [18:33:33] bawolff: ok, sounds manageable [18:33:56] Isarra: yes, the page table may be useful for that. But namespaces (names) aren't stored there [18:34:08] bawolff: /Special:FoobarGetImage?id=124 [18:34:22] bawolff: what about tables in the specialpage? [18:34:37] lbenedix: Look at the extension GoogleNewsSitemap. It outputs an XML file from a special page, so does several of similar steps (disabling outputPage, setting content type) [18:35:10] For tables, if you're doing a gallery of images, MW has a gallery class, but it only works with MW's File objects [18:35:22] no [18:35:35] if you're doing a list of stuff in a table, there's various Pager classes which might be helpful [18:35:53] just text in the table, and a link to the image [18:35:54] 03(mod) Restore normal bureaucrat permissions where changed without consensus - 10https://bugzilla.wikimedia.org/42105 +shellpolicy; +comment (10Dereckson) [18:36:27] Still probably the Pager class is what you're looking for [18:37:19] can you show me an example? [18:37:21] (or more specificly one of its subclasses like ReverseChronologicalPager) [18:37:22] 03(mod) Add Anexos to content namespaces on Spanish Wikipedia - 10https://bugzilla.wikimedia.org/39866 +comment (10Ryan Kaldari) [18:37:48] 03(mod) A table within a wikitext table breaks the outermost one under some conditions - 10https://bugzilla.wikimedia.org/9418 +comment (10Valerie Juarez) [18:37:57] Special:Contributions uses the pager class, so does Special:newimages [18:38:11] (both are defined in files in includes/specials [18:38:26] The pager classes can sometimes be a little hard to get the hang of at first [18:38:42] 03(NEW) Limit notifications about pages I create to namespace 0 - 10https://bugzilla.wikimedia.org/43641 normal; MediaWiki extensions: Echo; () [18:39:03] i hope i dont need so much code for my little table ;) [18:39:05] 03(mod) Limit notifications about pages I create to namespace 0 - 10https://bugzilla.wikimedia.org/43641 (10Steven Walling) [18:39:34] Hello all, I need an advice what to after someone has code reviewed my patchset 8 https://gerrit.wikimedia.org/r/#/c/3925/8 . [18:39:39] I added a reply to each comment, and want to submit a patchset 9 with some problems fixed. [18:39:44] Is this the correct procedure? [18:39:57] The pager class also generally involves setting options for the db query in abstract ways. [18:40:17] Wikinaut: you have to use "Review" below appropriate patchset to publish your inline comment [18:40:18] what about pagination? [18:40:18] s [18:40:28] Wikinaut: then yes, just submit another patchset [18:40:42] lbenedix: Yes, the Pager class does pagination (that's pretty much its main function) [18:40:43] 03(mod) A table within a wikitext table breaks the outermost one under some conditions - 10https://bugzilla.wikimedia.org/9418 +comment (10Valerie Juarez) [18:40:50] you might want to note on comments to PS8 that issues will be fixed in PS9, or vice versa [18:40:55] Hi, does anyone know of an extension that will list all of the pages in a selected category in a horizontal list rather than in a vertical tree? (i.e. basically a list version of CategoryTree) [18:41:35] 03(mod) A table within a wikitext table breaks the outermost one under some conditions - 10https://bugzilla.wikimedia.org/9418 +comment (10Valerie Juarez) [18:41:36] K^Larathiel`: [[Extension:DynamicPageList_(Wikimedia)]] can [18:41:54] Thanks bawolff! [18:42:15] MatmaRex: this is (basically), what i did [18:42:29] 03(mod) A table within a wikitext table breaks the outermost one under some conditions - 10https://bugzilla.wikimedia.org/9418 (10Valerie Juarez) [18:42:44] so, my next step is a next git commit --amend (is this correct)? [18:42:53] 03(mod) Special:Contributions no longer shows at the top that the user you're looking at is blocked - 10https://bugzilla.wikimedia.org/37853 +comment (10Platonides) [18:43:21] New review: Tychay; "Good point. We should update" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/27981 [18:43:24] K^Larathiel`: Its also technically possible to turn a vertical list to a horizontal one with fancy CSS if you're so inclined (so technically its possible with Cat tree, if you add some stuff to MediaWiki:Common.css) [18:43:48] Wikinaut: you haven't published inline comments (or at least i don't see any) [18:44:12] MatmaRex: yes, not yet. I wanted to make sure, that I follow the conventions [18:44:18] i'm not sure at which step you are, but yes, you will probably want to run `git commit --amend` at some point in the process :) [18:44:22] (mom) [18:44:28] Wikinaut: there are no conventions i know of [18:44:37] Wikinaut: just try to make it obvious what is happening [18:44:45] or at least as obvious as it's possible with gerrit [18:44:46] :) [18:44:47] ok, but I wasn't sure about the comments [18:44:56] when submitting further PS [18:45:05] I'm so-so with CSS, do you know of any examples I could work from? Ideally I'd like something that looks like this [ Category:Foo | Page 1 | Page 2 | Page 3 ] [18:45:05] who reads the old comments ? [18:45:13] Wikinaut: you can comment on other patchsets perfectly fine [18:45:19] Wikinaut: people who get them in their mail :) [18:45:26] ah, I forgot [18:45:30] of course [18:45:32] New patchset: Nikerabbit; "Translation memory changes part 2" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42281 [18:45:39] and the reviewers certainlu should read them [18:46:10] 03(mod) Global (to a wiki farm or family) message delivery (thoughts) - 10https://bugzilla.wikimedia.org/35306 +comment (10Ryan Kaldari) [18:46:33] Can you perhaps please also help reviewing the E:RSS so that the new version can be put into git soon, but wait for my next PS [18:47:46] 03(mod) SVG to PNG: font rendering problem in Persian - 10https://bugzilla.wikimedia.org/43640 +comment (10Amir E. Aharoni) [18:48:41] 03(mod) Limit notifications about pages I create to namespace 0 - 10https://bugzilla.wikimedia.org/43641 +comment (10Ryan Kaldari) [18:52:26] 03(mod) Suppressredirect for patrollers on dawiki - 10https://bugzilla.wikimedia.org/43548 +comment (10Dereckson) [18:53:43] Wikinaut: i'm hardly a PHP coder [18:54:04] Wikinaut: you can ask me for HTML / CSS / JS review anytime, but i just wouldn't be helpful with PHP :) [18:54:12] ok [18:56:25] the problem with php is that it's php [18:57:10] * AzaToth goes rewriting MW to rails (I'll be back 2024) [18:57:52] New review: Asher; "Looks like purgeParserCache.php needs updating now." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41023 [18:58:19] 03(NEW) Click outside of Guider tooltip to close - 10https://bugzilla.wikimedia.org/43642 enhancement; MediaWiki extensions: GuidedTour; () [18:58:41] 03(mod) Wrong picture linking - 10https://bugzilla.wikimedia.org/43539 +patch-in-gerrit (10Max Semenik) [19:00:22] is gerrit running on s box which is not the fastest one out there? [19:00:44] 03(mod) Limit notifications about pages I create to namespace 0 - 10https://bugzilla.wikimedia.org/43641 +patch-reviewed (10Steven Walling) [19:01:10] 03(mod) Click outside of Guider tooltip to close - 10https://bugzilla.wikimedia.org/43642 (10Munaf Assaf) [19:02:04] AzaToth: what duration delay are you running into? [19:02:07] 03(mod) Click outside of Guider tooltip to close - 10https://bugzilla.wikimedia.org/43642 +comment (10Steven Walling) [19:02:35] 03(mod) Click outside of Guider tooltip to close - 10https://bugzilla.wikimedia.org/43642 (10Steven Walling) [19:03:05] 03(mod) Keep the permission to remove administrator status on se.wikimedia wiki - 10https://bugzilla.wikimedia.org/42459 (10Nemo) [19:03:19] New patchset: Matmarex; "(bug 40044) make $.tablesorter treat alt attribute like text" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/23100 [19:03:22] StevenW: if there's no path there, it shouldn't be patch-reviewed. If Ryan says it's fixed it should be marked as RESOLVED FIXED, although a link to the gerrit commit should be useful (bug 43641) [19:03:37] New patchset: Matmarex; "$.tablesorter: remove and inline getTextFromRowAndCellIndex()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42276 [19:03:42] sumanah: took a minute to execute "git review -d 12782" [19:03:55] which should have taken like a second [19:04:04] Vulpix: {{sofixit}} [19:04:18] StevenW: okay [19:04:31] AzaToth: would you mind filing a bug? that is indeed a little too long in my opinion. [19:04:41] and I am sure it slows down development for many people. [19:04:42] AzaToth: not really [19:04:49] sumanah: bytheway, there are 249 changes up for review [19:04:57] AzaToth: it probably had to check out an old commit first [19:05:06] <^demon> git-review does lots of round-trips to accomplish git review -d [19:05:07] AzaToth: What can you help review? [19:05:08] unless 12782 was recently rebased [19:05:09] !g 12782 [19:05:09] https://gerrit.wikimedia.org/r/#q,12782,n,z [19:05:50] AzaToth: ... that patch is a year old :P [19:06:05] AzaToth: so it first had to checkout the parent of that revision [19:06:11] that's a year's worth of file changes [19:06:20] git would display a progress bar while it was happening [19:06:24] but git-review knows better [19:06:25] New review: awjrichards; "@Parent5446 - the WMF already essentially does what this patchset does on the WMF cluster, it just h..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42204 [19:06:46] MatmaRex: ah, I see [19:06:57] 03(mod) Strange notification from mediawiki.org - 10https://bugzilla.wikimedia.org/43625 +comment (10Ryan Kaldari) [19:08:07] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/40356 [19:08:08] New patchset: Umherirrender; "Use Database::addQuotes instead of hardcoded quotes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42284 [19:08:36] Change merged: Jeroen De Dauw; [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/40300 [19:08:47] 03(mod) Limit notifications about pages I create to namespace 0 - 10https://bugzilla.wikimedia.org/43641 -patch-reviewed ; +comment (10Jesús Martínez Novo (Ciencia Al Poder)) [19:08:57] ^demon: ...and git-review "git resets --hard" your working directory sometimes, as painful experienced by one our contributors https://bugs.launchpad.net/git-review/+bug/1096057 [19:09:02] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/41220 [19:09:13] MatmaRex: http://dpaste.org/zZsTw/ [19:09:44] it's the git fetch that took time [19:09:52] 03(mod) Broken revisions with rev_page=0 - 10https://bugzilla.wikimedia.org/16674 +comment (10Ryan Kaldari) [19:09:59] <^demon> saper: I saw. I hate git-review :( [19:10:11] AzaToth: .. huh. well, i dunno then, sorry. [19:10:15] saper: ^ [19:10:47] ^demon: you hate both git-review and jenkins? [19:10:54] you want to go back to svn? [19:10:56] MatmaRex: what's up? [19:11:10] <^demon> AzaToth: I hate lots of things, but I hate svn a lot :) [19:11:15] hehe [19:11:32] AzaToth: "git fetch" loads objects over the network, it may take a while (plus SSH connection establishment, key authentication, etc.) [19:11:59] saper: I only have a 100Mbit connection here, so it could be the cause [19:12:02] saper: weekend ~ :D [19:12:15] AzaToth: heheheh [19:12:48] AzaToth: 100 mbps? you are making me cry. [19:12:49] AzaToth: what was your repository at before you did "git review"? [19:13:05] I noticed when I cloned core that I was only allowed to download in around 120kbps around [19:13:15] saper: master gerrit [19:13:23] clean clone [19:13:29] AzaToth: current clean clone? [19:13:39] (took loke 20 min+ to clone the bastard) [19:13:43] like* [19:13:46] yes [19:14:21] git clone && cd core && git review -s && git review -d NNNNN [19:14:34] 03(mod) Lockandhide should be logged in the suppression log - 10https://bugzilla.wikimedia.org/18060 (10jeremyb) [19:14:48] ähem, a PHP question, why are switch/case...case.. deprecated and why should one use more complicated if ... structures ? I *like* clear switch/case... case ... structures [19:15:08] Wikinaut: php is deprecated [19:15:14] lol [19:15:15] good joke [19:15:15] ツ [19:15:20] <^demon> Wikinaut: What makes you think switch is deprecated? [19:15:29] AzaToth: this might be the problem, it's your git that is so slow, not even SSH [19:15:33] Wikinaut: you're probably referring to my review. switch/case isn't that simple, especially when you rely on fall-through [19:15:39] code reviews on E:RSS, and I think also in the code conventions [19:15:47] New review: Siebrand; "I was asked to do review, but these are not the type of changes I'm able to review. Removing myself." [mediawiki/extensions/UploadWizard] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/35821 [19:15:52] <^demon> Code convention says nothing about switch being deprecated, nor is it. [19:16:03] Wikinaut: but that was about "switch (true)", wasn't it? [19:16:08] Yes [19:16:12] what. [19:16:15] switch(true)? [19:16:17] lol [19:16:19] switch(true)? [19:16:22] 03(mod) Debug and reenable Swift-based CAPTCHA - 10https://bugzilla.wikimedia.org/43493 +comment (10Rob Lanphier) [19:16:24] switch(true)/case... case... [19:16:30] I like that [19:16:35] wikibugs: wtf [19:16:36] i've only ever seen code like this in magical wikitext [19:16:37] Wikinaut: this is ... wrong [19:16:40] but if there's a reason not to do will follow [19:16:44] saper: why [19:16:55] pls. a reasoned statement [19:16:58] you can use switch (true) as a shorthand way of expressing a large set of conditions (each one in a case:) [19:17:06] Wikinaut: why would you switch on true [19:17:06] argument of switch should provide a value to be checked in case statements [19:17:09] Wikinaut: you're stretching the purpose of 'switch' [19:17:14] that's madness [19:17:14] Wikinaut: do you know C language? [19:17:25] the values on case: should be constant [19:17:28] we are talking about PHP [19:17:33] Wikinaut: ^ ^ [19:17:45] well, php is php [19:17:47] otherwise a switch doesn't make sense "semantically", if you excuse the word [19:17:50] thus it's fine [19:17:51] Wikinaut: pick any safe coding standard and check what it says about stretching 'switch' [19:18:05] MatmaRex: yes, case "constant" [19:18:15] Wikinaut: let me look at the code [19:18:20] mom [19:18:24] I send you a pointer [19:18:29] because if you switch on ture, and cases are constant, then how the hell does it work? [19:18:59] https://gerrit.wikimedia.org/r/#/c/3925/8/RSSHooks.php [19:19:01] MatmaRex: it's a way of saying "if (false) " multiple times :) [19:19:05] New review: Siebrand; "I was asked to do review, but these are not the type of changes I'm able to review. Removing myself." [mediawiki/extensions/UploadWizard] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/35822 [19:19:07] MatmaRex: you can have: case (X == 1): [19:19:15] MatmaRex: there's no hard requirement for the case condition to relate to the switch [19:19:18] moment [19:19:20] Wikinaut: ... your cases aren't constant. :( [19:19:29] MatmaRex: it's a trick [19:19:34] ori-l: i'm talking about what makes sense, now what parses :P [19:19:37] I am talking about switch(true) { case "1":.... case "2" .... } [19:19:38] not* [19:19:39] 03(mod) After switching patrolling off, impossible to effectively hide patrol log entries in Special:Log - 10https://bugzilla.wikimedia.org/42246 +comment (10Nemo) [19:19:50] <^demon> Clever tricks are clever when you get them right ;-) [19:19:53] and as php is a lousy hack in it's self, it's fine to include lousy hacks ツ [19:19:53] Wikinaut: how is that supposed to work? [19:19:54] although i am quite surprised that it parses [19:20:06] (mom) [19:20:07] if funcall()[] wouldn't for such a long time [19:20:25] OK you are right [19:20:30] MatmaRex: you assume php contains consistency? [19:20:34] sorry, I was at a different code line [19:20:48] AzaToth: i assume it sucks [19:20:58] I KNOW it sucks ツ [19:21:02] <^demon> It had nothing to do with the if, it was the f()[]. Function calls weren't dereferenced. [19:21:04] summary: going back to code as if() then ... if .... [19:21:24] AzaToth: you are too negative [19:21:31] ^demon: lol, yeah, the "if" wasn't part of syntax in my message :P [19:21:39] <^demon> Rather, arrays weren't dereferenced from function returns. [19:21:43] <^demon> Or something. [19:21:54] no, it just didn't parse [19:21:57] 03(mod) Audit salt scripts for completeness (checking against scap/sync-file/sync-dir) - 10https://bugzilla.wikimedia.org/43615 (10Rob Lanphier) [19:21:57] it was a parse error [19:22:04] <^demon> Well yes, but that was why. [19:22:08] [] was only allowed after a variable [19:22:09] <^demon> getArray()['index'] looks too java ;-) [19:22:09] afaik [19:22:15] Wikinaut: the lack of consistency in php makes my head hurt [19:22:36] I've always have to go back to the blody docs to lookup wich order arguments should be made [19:22:39] <^demon> Well, you wouldn't have a ['foo'] in java, but you know what I mean. [19:22:45] AzaToth: that is a valid point strtolower versus str_replace.... [19:22:54] yeah [19:22:54] argggh I jhate PHP in that respect [19:23:23] preg_replace and the eregi shit [19:23:33] (calming down) [19:23:35] yea [19:23:36] (slowly) [19:23:43] and nl2br [19:23:50] <^demon> Well, preg and ereg were two separate regular expression libraries php supported. [19:23:57] if nobody has questions to Extension:RSS I will go to code ... [19:23:59] <^demon> They ditched ereg in favor of preg well, because ereg sucked. [19:24:07] I meant ereg [19:24:25] questions ? [19:25:16] thanks for the discussion. I have learnt not to use switch for case(s) which aren't constants [19:25:24] you all know that if you use server password instead of nickserv, you wont trigger the "changing host" [19:25:48] including the disclosure of your real IP [19:25:57] who cares about "changing host" [19:26:02] New review: Hashar; "Maybe we should start again and fix the error in smaller batches?" [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/27553 [19:26:08] i only got a cloke for the bot to listen to me :P [19:26:10] cloak* [19:26:19] MatmaRex: heh [19:26:19] @trusted [19:26:19] I trust: petan\|w!.*@wikimedia/Petrb (2admin), .*@wikimedia/.* (2trusted), .*@wikipedia/.* (2trusted), .*@mediawiki/..* (2trusted), .*@wikipedia/MZMcBride (2admin), .*@wikimedia/Krinkle (2admin), .*@fsf/.* (2trusted), [19:26:23] LiquidThreads.... arrghghgh [19:26:34] 03(mod) Restore normal bureaucrat permissions where changed without consensus - 10https://bugzilla.wikimedia.org/42105 (10Nemo) [19:26:36] 03(mod) After switching patrolling off, impossible to effectively hide patrol log entries in Special:Log - 10https://bugzilla.wikimedia.org/42246 +comment (10Bawolff (Brian Wolff)) [19:26:42] 03(mod) Add ability to remove sysop/bureaucrat to fi.wikipedia bureaucrats - 10https://bugzilla.wikimedia.org/42114 (10Nemo) [19:26:45] when will this Lqt story be over [19:26:45] Wikinaut: I'm relatively new so I went through a similar process of grumbling about people forcing me to give up my coding style and bag of tricks. The first couple of times people fix bugs in your code that you deployed to production makes you understand why people push back. The fact that code looks strange or surprising to most readers is enough to make it problematic. [19:26:47] 03(mod) Remove ability-to-remove-bureaucrat from en.wiktionary bureaucrats - 10https://bugzilla.wikimedia.org/42113 (10Nemo) [19:27:13] ori-l: E:RSS is more complicated. It was recoded some time ago [19:27:22] from MagpieRSS [19:27:23] to avoid this strange code [19:27:27] then I took over [19:27:31] and fixed many isssues [19:27:31] Wikinaut: while this is admittedly clever, i don't get what the solution with a switch buys us in this case? [19:27:46] it's fine, i guess, it works [19:27:51] so would one with regular ifs :) [19:27:52] MatmaRex: well, the changing host spams two extra lines! [19:28:31] MatmaRex: do you mean, what advantage my use of switch(true).... has ? [19:28:31] AzaToth: checking out full clone now [19:28:37] Wikinaut: yeah [19:28:44] it make the code layout very readible [19:28:51] AzaToth: well, filter it out :P does xchat support filtering incoming messages? [19:28:52] s/make/makes/ [19:29:05] MatmaRex: yes, but that's irrelevant [19:29:15] but I will follow the code convention and recommendations [19:29:20] Wikinaut: it's not readable to me :/ [19:29:30] saper: good luck ツ [19:29:38] Wikinaut: when you scroll down a little, you don't even know what are you comparing the values to [19:29:50] dunno if it saved the pack it made when I cloned it before [19:29:51] MatmaRex: indeed not in gerrit, which sucks [19:30:03] because a raw view is still missing [19:30:15] see bug ... [19:30:21] Wikinaut: are you using some mad editor that displays first lines of all indentation levels up to current one, or what? [19:30:28] 03(mod) After switching patrolling off, impossible to effectively hide patrol log entries in Special:Log - 10https://bugzilla.wikimedia.org/42246 +comment (10Nemo) [19:30:29] AzaToth: changing host does not require spamming, just use sasl authentication on connect [19:30:30] because how else would you see that line continuously? [19:31:01] Notepad++ [19:31:07] 03(mod) After switching patrolling off, impossible to effectively hide patrol log entries in Special:Log - 10https://bugzilla.wikimedia.org/42246 +comment (10Bawolff (Brian Wolff)) [19:31:24] MatmaRex: I use Notepad++ [19:31:26] AzaToth: Receiving objects: 100% (403814/403814), 103.88 MiB | 6.81 MiB/s, done. [19:31:29] Wikinaut: i use it as well [19:31:42] AzaToth: it was remote work that took ages on clone [19:32:10] Wikinaut: what i mean is, when you simply scroll down enough, the switch(...) scrolls out of view [19:32:24] real 17m9,07s [19:32:27] <^demon> We should just delete the ancient history from the git repo, anything prior to the changeover. That number of object is stupid, and the lack of real compression is a problem. [19:32:30] on clone [19:32:42] ^demon: 100M is not that much [19:32:47] ^demon: git could have it packed maybe ready to ship? [19:32:57] ^demon: also, you can make a shallow clone? [19:33:07] New patchset: Umherirrender; "recentchanges.rc_ip is used for retroactive autoblocks" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42288 [19:33:34] MatmaRex: lines 38 until 64 scrolls out on your screen ? [19:34:14] ok, let's stop the discussion, I will remove the switch(true) and everyone will be happy [19:34:15] <^demon> saper: It'll be better one day :) https://docs.google.com/presentation/d/1t2qzSO4z5MbrN21Cz4RrLWz9IZ5ylJNwQassajKyPk8/view#slide=id.gc9e6c53_7_18 [19:34:17] Wikinaut: actually my screen fits 45 lines of code, so yes, it would *just* scroll out :P [19:34:45] Wikinaut: (i mean if i scrolled to the bottom) [19:35:25] i can see 26 lines not fitting on a netbook screen with the same font size i'm using [19:35:33] but yeah, this is quite a pointless discussion [19:35:38] thanks :) [19:35:39] ok, let#s stop, pls [19:35:55] AzaToth: real 0m49,31s [19:36:00] on git fetch here [19:36:03] if (condition) { return ...} if (condition) { return ...} if (condition) { return ...} -- is this okay ? [19:36:18] saper: hmm [19:36:45] Wikinaut: there is also http://www.php.net/manual/en/control-structures.elseif.php if you break [19:36:45] <^demon> fetching often for a repo like core is kind of good. [19:36:56] 03(mod) Flag/exclude events originating from WMF's IP range - 10https://bugzilla.wikimedia.org/43639 +comment (10Ori Livneh) [19:36:57] <^demon> The repo changes frequently, and waiting a long time to fetch would make the fetch slower. [19:37:00] 03(mod) After switching patrolling off, impossible to effectively hide patrol log entries in Special:Log - 10https://bugzilla.wikimedia.org/42246 +comment (10Nemo) [19:37:14] you cloned https://gerrit.wikimedia.org/r/p/mediawiki/core.git? [19:37:23] MatmaRex: you told me, "it will scroll out" [19:37:37] AzaToth: ssh://saper@gerrit.wikimedia.org:29418/mediawiki/core.git to be exact [19:37:46] ok [19:37:47] again; is ... if (condition) { return ...} if (condition) { return ...} if (condition) { return ...} -- is this okay ? [19:37:50] and then "git fetch origin refs/changes/30/5130/1" [19:38:23] Wikinaut: that's how i'd do [19:38:31] Wikinaut: in general I think that it indicates some problems with the logic, which file is this? [19:38:43] perhaps the https clone is slower [19:38:45] Wikinaut: when you include "MatmaRex" in your messages, i get a ding sound that makes me look at this channel :) [19:39:13] 03(mod) Suppressredirect for patrollers on dawiki - 10https://bugzilla.wikimedia.org/43548 +comment (10Christoffer G. Thomsen) [19:39:16] https://gerrit.wikimedia.org/r/#/c/3925/8/RSSHooks.php lines 38 seq. [19:39:29] New patchset: Brian Wolff; "Use nocookiesfornew on account creation if no cookies" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42289 [19:40:00] saper: still think the remote git could benefit from a repack [19:40:23] saper: I am currently recoding as "if (...) return;" [19:40:54] New review: Brian Wolff; "See I421e294e" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/17952 [19:41:33] "finding sources" takes a long time [19:42:23] New review: IAlex; "What is missing?" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/40574 [19:42:38] saper: or am I totally off here? [19:43:33] <^demon> `git repack -d -f --depth=250 --window=250` perhaps. [19:43:57] <^demon> Maybe not so deep. [19:44:31] <^demon> `git repack -d -f --depth=150 --window=250` [19:44:36] <^demon> Wide window, not deep. [19:45:30] no-reuse-delta? [19:45:37] Wikinaut: ok, will check [19:45:42] ha, another git-review bug :) [19:46:29] saper: which? [19:46:45] saper: pls. wait until my next PS [19:47:33] AzaToth: you can't have a local branch called "review" [19:48:06] <^demon> AzaToth: Sadly, I don't trust this enough to run it while the server's running. Would want to do it during some downtime. [19:48:14] <^demon> Maybe we can plan a core repack for during the 2.6 upgrade. [19:49:58] 03(mod) tie bar shows incorrectly in IPA class - 10https://bugzilla.wikimedia.org/37973 +comment (10Andre Klapper) [19:50:20] which is at? [19:51:01] <^demon> When I get https://gerrit-review.googlesource.com/#/c/39140/ merged upstream. [19:52:57] that change is marked as do not submit BTW [19:53:17] <^demon> I hadn't noticed ;-) [19:53:19] saper: "Receiving objects: 8% (32763/403814), 7.44 MiB | 191 KiB/s" [19:53:58] saper: I assume it could be because I'm in Europa and not in the ol' US of A? [19:54:12] <^demon> gerrit box is in eqiad ;-) [19:54:28] I'm always getting shitty speeds from mv/wp [19:56:22] https://bugs.launchpad.net/git-review/+bug/1096180 [19:56:27] 03(mod) Add request for shell at registration time - 10https://bugzilla.wikimedia.org/43370 (10Andrew Bogott) [19:56:31] AzaToth: I am in Europe too [19:57:10] uga [19:57:10] I'll test a ssh clone then as well [19:57:33] ^demon: "When I get https://gerrit-review.googlesource.com/#/c/39140/ merged upstream." evaluates to "false" [19:58:01] AzaToth: personally I see no use in https clone [19:58:15] saper: it's the "link" given [19:58:29] New patchset: Umherirrender; "recentchanges.rc_ip is used for retroactive autoblocks" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42288 [19:58:51] <^demon> saper: It's going in. All but one outstanding nitpick are resolved. [19:59:03] New review: Umherirrender; "Added missing global statement" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/42288 [19:59:06] <^demon> Main thing I'm fighting is upstream--it's a painful migration for them. [19:59:18] <^demon> (Not painful if you use H2, Mysql, or PG) [20:00:00] ^demon: why are you insisting on getting it merged there first? [20:00:03] (just asking) [20:00:15] especially if migration is their only concern? [20:00:15] New patchset: Bsitu; "(bug 43625) - Strange notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/42290 [20:00:28] (it looks so from a quick glance at the discussion under the patch) [20:00:28] <^demon> Well, it needs to be in the same shape it's going to go into upstream as. [20:00:40] New patchset: Nikerabbit; "Translation memory changes part 2" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42281 [20:00:48] <^demon> But I'm tempted to deploy it as-is. It's really a nitpick that's left. [20:00:51] <^demon> A PITA nitpick. [20:01:02] ah, that makes sense, i guess [20:01:23] but wouldn't it be possible to just "amend" our patch later? [20:01:42] (sorry, i have no idea what i'm talking about, please don't make fun of me if i'm making a fool out of myself) [20:01:44] <^demon> Yeah. I'm pretty sure the overall plan behind the patch won't change at this point. [20:01:52] <^demon> I'd at least like another full review of it though. [20:01:57] <^demon> There's a *lot* of crap changing here. [20:02:04] <^demon> And I've fought a lot of annoying edge case bugs. [20:02:07] yeah, this i can see. :P [20:02:11] New review: Nikerabbit; "PS2 fixed heading level in Translate.php" [mediawiki/extensions/Translate] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42281 [20:02:15] (the lots of stuff part) [20:02:36] also [20:02:37] ^demon: you couldn't push them as smaller patches? [20:02:53] gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/server/AccountGroupIncludeByUuidAccess.java / renamed from gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/server/AccountGroupIncludeAccess.java [20:02:53] gods. [20:03:09] <^demon> AzaToth: Sadly, no. All of this stuff is related. [20:03:12] k [20:03:23] <^demon> I'm making a rather invasive schema change. [20:04:14] New review: CSteipp; "Overall, I think this is the right direction. I'll start running some tests on a couple different ve..." [mediawiki/extensions/AbuseFilter] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42268 [20:04:16] saper: http://paste.debian.net/221713/ [20:05:09] <^demon> MatmaRex: Fun story: this was the easiest acceptable way for me to accomplish it. There was a way to do it that was a much much smaller change, but required a PK change and upstream said "Yeah we can't support that :(" [20:05:24] <^demon> Sooo, we came up with a really crappy idea that would've taken at least 50% more code. [20:05:32] <^demon> Then the middle ground, which is painful, but less code. [20:05:33] PK change? [20:05:36] <^demon> primary key. [20:05:41] k [20:05:51] 03(mod) Enable Page Curation on en.wikisource - 10https://bugzilla.wikimedia.org/38512 +comment (10Oliver Keyes) [20:06:02] silly upstream [20:06:08] goid, their gerrit is even worse than ours [20:06:19] more errors [20:06:29] <^demon> They're running master. [20:06:34] <^demon> (well, almost master) [20:06:34] New review: Ori.livneh; "Awesome tests. Will +2 verified once I get the chance (heading to the office)." [mediawiki/extensions/GuidedTour] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/41374 [20:06:35] ^demon: what does your patch actually do? [20:07:14] <^demon> Allows you to inherit members from external groups (like from ldap) into internal groups (managed by gerrit) [20:07:23] ok [20:08:18] <^demon> MatmaRex: re: gerrit errors. I hate to say it but your best solution is using anything but opera :\ [20:08:24] New review: Wikinaut; "so, I reviewed the code reviewer's comments and reply to any." [mediawiki/extensions/RSS] (master) C: 1; - https://gerrit.wikimedia.org/r/3925 [20:08:55] 03(mod) Install sitemap extension into bugzilla, and then update bugzilla robots.txt - 10https://bugzilla.wikimedia.org/33406 +comment (10Andre Klapper) [20:08:58] <^demon> The opera problems got pushed upstream to opera, and their response was basically "Um just don't do that then." [20:09:07] 03(mod) Global (to a wiki farm or family) message delivery (thoughts) - 10https://bugzilla.wikimedia.org/35306 +comment (10Ningauble) [20:09:07] ^demon: it's manageable [20:09:27] ^demon: gerrit's diff viewer sucks anyway for anything more complex than a two-line change [20:09:28] Hi, how do I setup an extension ? [20:09:32] (i use meld locally) [20:10:05] <^demon> There's some outstanding work on the diff viewer. [20:10:12] ^demon: and apart from the diffs, which have various issues, everything works [20:10:15] <^demon> I think we'll be replacing code-prettify soon which will be nice. [20:10:31] ^demon: and yeah, i reported a bug to Opera once [20:10:44] ^demon: in october 2011. no response. :P [20:10:56] (it was a pretty minor one though) [20:11:45] <^demon> There's some talk of trying CodeMirror with gerrit. [20:12:11] <^demon> Would provide better language support for diffs, and the possibility of inline editing (imagine a typofix straight from the UI) [20:12:32] ^demon: i drooled. [20:12:36] Uploaded an .odt file, instead of showing the file I'd like to give people the option to download the file when they click on a link to it. Is this possible? [20:13:08] http://meta.wikimedia.org/wiki/Help:Images_and_other_uploaded_files is what i've been perusing [20:13:59] heave20: this is probably a matter of configuring your webserver to serve them properly [20:14:18] more like an option on the server itself to enable downloading? [20:14:48] <^demon> You can use [[Media:]] links to link directly to the file. [20:14:49] heave20: what happens now? .odt is the format of OpenOffice, right? [20:14:57] yep [20:15:18] I've used Media: and it will link, but I want it to download for the person [20:15:23] taking a look at trying to use the api page, think I'm missing something...if I navigate to /w/api.php, it just gives me the standard 'there is no page, would you like to make one' message [20:15:40] or at least give them the option of Open/save [20:15:47] It's a time off request form [20:16:00] Scooter_: api is located at the same path of index.php [20:16:07] heave20: configure your webserver to serve odt files with application/octet-stream mime type [20:16:22] heave20: this will force the download dialog on all browsers, even if the browser itself can open the file [20:16:46] gerrit question: after a local git commit --amend(on the correct branch), how can I see the unsent diff to gerrit ? [20:16:46] ah, it was the /w/ in the examples throwing me off [20:17:07] Scooter_: edit a page on your wiki, then the URL should have a index.php on it. Change index.php and anything following it with api.php, and the api help page should display there [20:17:11] You guys rule, no doubt i'll be back with more [20:17:15] heave20: if might be possible to do that in htaccess [20:17:23] heave20: but don't ask me how :) [20:17:34] heave20: it might be* [20:17:39] i literally have no idea what you told me, so i'm going to google all of it and find out [20:17:45] i'll check back [20:17:57] Wikinaut: `git show HEAD` [20:18:22] heave20: i don't know what i'm talking about as well [20:18:24] :) [20:18:25] good luck [20:18:26] haha [20:18:29] thanks [20:18:48] Wikinaut: or do you want the diff between current patchset and previous patchset? [20:18:50] MatmaRex: not this. your command shows the diff to git [20:19:00] MatmaRex: yes this is what I want [20:19:05] diff to previous PS [20:19:38] (before I push wiht git review -R) [20:19:42] 03(NEW) impossible to change the data type of a property - 10https://bugzilla.wikimedia.org/43643 normal; MediaWiki extensions: WikidataRepo; () [20:19:48] Wikinaut: you have to find what was the sha1 id of the previous patchset. gerrit displays it next to patchset name/number [20:19:52] ok [20:20:03] Wikinaut: e.g. you have: [20:20:11] Patch Set 8 225594eacd532597881576631fac30251a477d26 [20:20:22] that hexstring is the id. [20:20:24] then you do: [20:20:31] ok [20:20:31] `git diff HEAD` [20:20:43] <^demon> You can also do `git diff HEAD~1` [20:20:45] to diff that sha1 against HEAD (your latest commit on current branch) [20:21:02] ^demon: we want to diff between patchsets, would that work? [20:21:02] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42260 [20:21:11] <^demon> Oh, maybe not. [20:21:17] <^demon> I was thinking HEAD vs last. [20:22:15] Wikinaut: also, i greatly advise you to get a GUI commit log and diff viewer for git. really helps in day-to-day coding [20:22:34] cannot use [20:22:35] Wikinaut: i personally use gitk, because it came with my git for Windows ;), but there exist a few other ones [20:22:49] oh? why? are you working via ssh? [20:22:50] running the git on a headless server [20:23:44] I only found git diff 225594eacd53 working [20:24:34] Wikinaut: also, you can usually trim sha1 ids to first 7 or 8 chars, and git will understand what you want as long as it's unique [20:24:35] New patchset: Wikinaut; "version 2.17 + squashed commit RSS changes fromSVN" [mediawiki/extensions/RSS] (master) - https://gerrit.wikimedia.org/r/3925 [20:24:36] (it usually is) [20:24:51] 03(mod) Special:GlobalUsers doesn't normalize group names with spaces, requires underscore in URL - 10https://bugzilla.wikimedia.org/38883 +comment (10Chris Steipp) [20:24:55] git itself trims the sha1 in most output formats [20:25:00] MatmaRex: I already trimmed it ... [20:25:12] used the sha1 from the gerrit GUI [20:25:56] Wikinaut: sorry if you already knew it, i don't know how strong your git-fu is ;) [20:26:06] question: is there a policy to remove code-reviewer from the list ? [20:26:23] MatmaRex: git-fu = medium [20:26:46] you can watch me on github... [20:27:02] (no, you shouldn't) [20:27:09] we need you here on MediaWiki [20:27:11] Wikinaut: no policy i know of, usually if a reviewer doesn't care, they will remove themselves :) [20:27:17] * MatmaRex stalks Wikinaut on github [20:27:21] ok, good point [20:27:37] <^demon> Yeah. If someone adds me to a change and I don't care, I'm very liberal in removing myself again. [20:27:43] <^demon> I get enough spam as it is ;-) [20:28:45] yeah, in gerrit, every new patchset can mean 6 new mails... [20:28:57] rebase, comment on old, new ps, jenkins 1, jenkins 2, comment on new [20:29:03] in the E:RSS case https://gerrit.wikimedia.org/r/#/c/3925/, there is still Hashar on it ,who helped me during the Berlin Hackathon [20:29:04] 3 is minimum [20:29:17] but he hasn't that much time to review my E:RSS, I think [20:29:23] (sorry, 2 is minimum, but rare :P) [20:29:30] Change merged: Jeroen De Dauw; [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/35657 [20:29:44] and who is Cmcmahon ? [20:30:02] Chris McMahon [20:30:18] and then when one reviews it, then goes MatmaRex and rebases again... [20:30:23] Change merged: Jeroen De Dauw; [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/35667 [20:30:28] Vulpix: ;) [20:31:08] so, world has my new patchset 9 [20:32:09] mother of god, what a wall of text! (sees commit message) [20:32:12] New patchset: Mattflaschen; "(bug 43144) Refactor to use i18n for extension tours." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/41374 [20:32:36] Change merged: Ori.livneh; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/41374 [20:33:14] Vulpix: if you mean E:RSS this a legacy code - I did my very best in spring 2012 - then all unreviewed changes were reverted (which is clear to me, why) [20:33:43] however, thsi is good news, I fixed (until then) all bugs of he E:RSS as it is still life on mediawiki.org etc. [20:33:52] technically, my version is much better [20:34:12] need all of you to get it reviewed in the current version [20:34:20] Vulpix: i quite love Krinkle's commit messages [20:34:27] he pastes a lot of stuff there ;) [20:34:35] then we are "through" and I will rebase to git hEAD [20:35:12] quoting a quip on bugzilla: Remember, your commit message isn't too long until it causes people's machines to go into swap when they read the commit mailing. [20:35:54] if someone wants an up-to-date version (fork) https://github.com/Wikinaut/mediawiki-extension-RSS [20:36:06] but of course, I want to get rid of this fork [20:36:34] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42281 [20:37:29] Change merged: Nikerabbit; [translatewiki] (master) - https://gerrit.wikimedia.org/r/42255 [20:40:19] New review: Aaron Schulz; "What changes does the second sentence of the commit message correspond to?" [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/40574 [20:40:36] Wikinaut: MatmaRex I'm not sure why I'm on the review list for that one [20:40:49] New patchset: Siebrand; "Partial normalisation of hooks.txt" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42295 [20:41:23] New patchset: Spage; "bug 43550: return failures from validate" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/41826 [20:44:43] Good afternoon terrrydactyl. [20:45:01] Hi Dereckson. How are you today? [20:50:07] * YuviPanda awards 'Awesomest Nick on My Screen' award to terrrydactyl  [20:50:09] chrismcmahon: no idea. Can you remove your name ? Catrope is the extension owner, since he moved (my) extension from SVN to git [20:50:32] Wikinaut: thanks, will do [20:50:57] <^demon> Wikinaut: (actually, I moved it, but Roan took over getting your reverted changes back into git :)) [20:51:12] ok [20:53:01] Awww, thanks YuviPanda. :D [20:53:28] ^demon: after a review, i have nothing against becoming maintainer [20:53:51] terrrydactyl: some part of my brain still keeps thinking yoi [20:53:58] *you're Terry Chay though [20:54:13] * YuviPanda retrains that part of his brain [20:54:59] New patchset: Aaron Schulz; "(minor) Make ORMTable handle failed queries nicely." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/37233 [20:59:02] New review: IAlex; "To the change in Title.php, it is now using $this->getLatestRevID() instead of creating an instance ..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/40574 [21:00:23] Change merged: Kaldari; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/42290 [21:02:15] New review: Aaron Schulz; "So you mean that is already done? Then the summary should be reworded." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/40574 [21:03:23] 03(mod) Broken revisions with rev_page=0 - 10https://bugzilla.wikimedia.org/16674 +comment (10Ryan Kaldari) [21:05:17] Change merged: Ori.livneh; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/42220 [21:07:09] I'm wondering if its possible to create a button that would turn on an off an iframe [21:07:22] 03(mod) Strange notification from mediawiki.org - 10https://bugzilla.wikimedia.org/43625 +comment (10Jesús Martínez Novo (Ciencia Al Poder)) [21:07:45] Dereckson: I made a small edit to my .gitignore file and committed it locally, but when I try to push it to gerrit, it says there are no commits to push. I had committee locally yesterday and this morning I pulled Raimond's changes and rebased it. Did that cause a problem? [21:07:47] New patchset: Ori.livneh; "Update module declaration example" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/42297 [21:07:56] New review: IAlex; "No this is in *this* changeset." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/40574 [21:08:27] Dereckson: it also says my branch is ahead by 3 commits. not sure what this means. [21:09:36] hi qgil - got a moment? [21:09:36] terrrydactyl: you have three commits in your local master branch that are not (yet) present in gerrit's (remote) master branch [21:09:46] hi, when was the last server update from master? [21:10:04] <^demon> Yurik: You mean the last deployment? [21:10:09] yep [21:11:04] <^demon> We branched master just this week, Jan 2. [21:11:41] <^demon> Yurik: http://www.mediawiki.org/wiki/MediaWiki_1.21/Roadmap and http://www.mediawiki.org/wiki/Branch_points [21:12:03] 03(mod) Use the current version of files from foreign repos - 10https://bugzilla.wikimedia.org/41832 summary (10Aaron Schulz) [21:12:08] does that include extensions too? because https://gerrit.wikimedia.org/r/#/c/40088/ was merged on 24th, but i don't see it in prod [21:12:25] ^demon: thank you for that email to the list. It made me happy [21:12:47] <^demon> Yurik: It should. [21:13:07] terrrydactyl: when you merge some changes on Gerrit, and want to have them in your master branch, you need to pull them from Gerrit to your local branch -> git checkout master ; git pull [21:13:32] So I guess you're fine [21:13:53] Dereckson: I've already pulled the Gerrit changes. I think I'm having trouble pushing my changes to Gerrit. [21:14:18] Did you commit in your master branch or elsewhere? [21:14:42] I had merged my github branch to master and deleted it [21:14:46] would that cause a problem? [21:15:03] Yes. [21:15:47] If you wish to see the difference between the Gerrit master and your current git repository: git diff ad1d46bc4fe9c36eef968de0ef3496d584022275 HEAD [21:15:49] I wanted to delete my github branch since it was still tracking the remote github that I didn't need anymore and work on master [21:16:14] New review: Aaron Schulz; "My mistake, I kept misreading it when I looked at it." [mediawiki/core] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/40574 [21:16:22] <^demon> fwiw, you can change what remote/branch you track. [21:16:31] <^demon> (Always a possibility, maybe not so here) [21:16:43] New patchset: Amire80; "Show the documentation only if it's not empty" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42299 [21:17:02] I know you can change it, but it seemed easier to just delete the branch since I didn't want to be working in that branch anyways. [21:17:13] Though now I realize it caused problems. [21:17:31] Quick, dirty, barbarian way: git clone ssh://review/mediawiki/extensions/Git2Pages in a new folder, you have a clean repo [21:17:40] New patchset: Aaron Schulz; "(bug 41832) Use the current version of files from foreign repos." [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/42300 [21:17:41] I have an iframe in my wiki that I want the users to turn on an off with a button, is this possible? [21:18:15] terrrydactyl: then, you create for each modification a small branch: e.g. git checkout -b feature/gitignore [21:18:33] terrrydactyl: you reapply in this branch your change, you commit, you send to gerrit [21:18:44] terrrydactyl: you merge on gerrit, git checkout master, git pull [21:18:49] terrrydactyl: and so on [21:19:00] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/40574 [21:19:15] oh okay [21:19:17] New patchset: Aaron Schulz; "(bug 41832) Use the current version of files from foreign repos." [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/42300 [21:19:45] terrrydactyl: imagine you let a change for review. You want to go on to work. git checkout master ; git checkout -b feature/nextfeature ; work -> commit -> review -> git checkout master -> git checkout -b feature/yetanotherfeature [21:19:58] each time, you come back to master, so your branches will always be only one commit ahead from master [21:20:05] New patchset: Raimond Spekking; "[GuidedTour] Add new optional message key" [translatewiki] (master) - https://gerrit.wikimedia.org/r/42301 [21:20:19] Change merged: Raimond Spekking; [translatewiki] (master) - https://gerrit.wikimedia.org/r/42301 [21:21:11] New review: Mgrover; "Looks good" [qa/browsertests] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/42087 [21:21:30] New review: Mgrover; "Looks good" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/42087 [21:21:31] Change merged: Mgrover; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/42087 [21:21:44] Dereckson: git clone ssh://review/mediawiki/extensions/Git2Pages isn't working [21:21:59] "ssh: Could not resolve hostname review: nodename nor servname provided, or not known" [21:23:43] git clone ssh://gerrit.wikimedia.org:29418/... [21:24:02] I have an alias in my .ssh/config file to use review instead [21:24:48] Permission denied (publickey). [21:25:13] Er.... what do you use usually? [21:25:26] for what? [21:25:31] To communicate with Gerrit. [21:25:49] i just use the terminal.. [21:25:52] ^demon: double checked, the changes to the extension have not been deployed [21:26:51] Oh I know. Your Gerrit username probably. git clone ssh://yourusername@gerrit.wikimedia.org:29418/... [21:27:08] Dereckson: hi, have you had any luck reviewing https://gerrit.wikimedia.org/r/#/c/42070/ ? Sorry to bug :) [21:27:32] oh maybe! I don't really remember because mark helped me clone it and i didn't write it down [21:27:33] <^demon> Yurik: Check make-wmf-branch, maybe we're pinning a specific release? [21:27:52] * Susan pins ^demon to the ground. [21:28:33] Dereckson: is there's something after the ...? [21:28:40] <^demon> Susan: You wish ;-) [21:28:49] (o; [21:29:02] New patchset: Ori.livneh; "generateId -> mw.user.generateRandomSessionId" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42329 [21:29:06] git clone ssh://yourusername@gerrit.wikimedia.org:29418/mediawiki/extensions/Git2Pages [21:29:13] ^demon: Actually, while you're here: status of configuration system for MediaWiki? [21:29:26] New patchset: IAlex; "Made the profilers that output text not break js." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/38170 [21:29:35] <^demon> Susan: Nowhere on my radar these days. Gotten tied up with too many other things :( [21:29:44] D: [21:29:46] <^demon> Which sucks, I've always wanted to do it. [21:29:58] Yeah... and it's desperately needed. [21:30:03] that worked, thanks! [21:30:06] To shorten this syntax in ssh://review/mediawiki/.... you can add this information in your .ssh/config file: [21:30:09] Host review [21:30:11] Hostname gerrit.wikimedia.org [21:30:14] Port 29418 [21:30:16] Username yourusernamehere [21:30:23] <^demon> Susan: For wmf *and* 3rd parties...everyone wins with this one. [21:30:31] Password hunter2 [21:30:38] Change merged: IAlex; [mediawiki/extensions/ParserFunctions] (master) - https://gerrit.wikimedia.org/r/39028 [21:30:42] Setting up a host called "review" is kind of silly. [21:30:57] YuviPanda: there is no Password directive in ssh config files. [21:30:59] do i just create the file if i don't have one [21:31:10] <^demon> I don't use a review alias, but I do default the port and username. [21:31:14] YuviPanda: OpenSSH thinks a little about security before adding config instructions [21:31:28] <^demon> Granted, by username is set for all *.wikimedia.org hosts in .ssh/config :p [21:31:29] terrrydactyl: aye [21:31:39] Dereckson: it is a meme http://knowyourmeme.com/memes/hunter2 [21:31:48] ^demon: I mainly use username, for example User Dereckson to SSH to Windows machines [21:31:52] * Susan didn't know that meme. [21:32:18] s/username/User [21:32:27] <^demon> My .ssh/config: [21:32:28] terrrydactyl: it's "User", not Username [21:32:30] <^demon> Host *.wikimedia.org [21:32:30] <^demon> User demon [21:32:30] <^demon> Host gerrit.wikimedia.org [21:32:31] <^demon> Port 29418 [21:32:48] i was wondering why it wasn't highlighted like the rest [21:33:29] New patchset: Wikinaut; "version 2.17 + squashed commit RSS changes fromSVN" [mediawiki/extensions/RSS] (master) - https://gerrit.wikimedia.org/r/3925 [21:33:41] Susan: how could you not know about hunter2. [21:33:52] Host * ControlMaster auto ControlPath ~/.ssh/master-%r@%h:%p [21:33:53] Susan: it seems like you might actually *gasp* have a life! [21:33:53] hunter2 is pretty old, isn't it? [21:33:55] Susan: bash.org is an interesting timesink :) [21:34:06] New review: Wikinaut; "commenting on four white spaces (are removed in the next patchset)" [mediawiki/extensions/RSS] (master) - https://gerrit.wikimedia.org/r/3925 [21:34:11] Oh, right. From bash. [21:34:26] That's a nice addition to be able to open new connections on the same host as a dependency of the previous one, instead to relog. [21:34:47] ^demon: So... any ideas for who to convince to write this beast? [21:35:11] saper: strange... I did only get 180KiB/s via ssh [21:36:08] New review: Wikinaut; "ok, looks good to me. Also to you ?" [mediawiki/extensions/RSS] (master) C: 1; - https://gerrit.wikimedia.org/r/3925 [21:36:10] ^demon: I don't even know how to begin a plan for it, unfortunately. :-/ [21:36:15] <^demon> A masochist? [21:36:28] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/38170 [21:36:30] would it be okay to delete the old repo or should i keep it around? [21:37:19] <^demon> Susan: Someone who's able to write weird backendy stuff with an eye to scalability at wmf scale. [21:37:29] Change merged: Ori.livneh; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/42297 [21:37:40] <^demon> Preferably someone who understands wmf's needs already too (like inherited config, etc) [21:39:24] 03(mod) SVG to PNG: font rendering problem in Persian - 10https://bugzilla.wikimedia.org/43640 +comment (10Huji) [21:42:22] Dereckson: do you create a new branch of each file or every new feature? wouldn't there be a ton of branches in the end? [21:43:38] <^demon> terrrydactyl: General git workflow is "branch-per-feature/fix." [21:44:04] terrrydactyl: you can delete the branches later [21:44:20] terrrydactyl: (in normal git workflow, you don't have to, as they get merged into the master branch) [21:44:28] terrrydactyl: (but gerrit is special) [21:44:38] ^demon: It just gets so overwhelming so fast... [21:44:51] I'm not even sure the WMF side can be handled right now. [21:44:53] anybody that can help me with an issue I'm having? [21:44:59] I'd settle for just covering basic MediaWiki usage. [21:45:04] WMF is too much to handle. [21:45:09] Demos74dx: what is your issue? [21:45:10] okay, not gerrit by itself, this is caused by the amend-based workflow, but i'll stop myself right here before i go on a rant ;) [21:45:14] ^demon: Is the general idea to put config in the DB similar to WordPress? [21:45:24] <^demon> For 3rd parties, probably. [21:45:58] 03(mod) SVG to PNG: font rendering problem in Persian - 10https://bugzilla.wikimedia.org/43640 +comment (10Amir E. Aharoni) [21:46:07] Right. I think the whole WMF aspect has to be sidelined for any work to happen. [21:46:19] I want a user interactable button to turn on or off an iframe [21:46:22] Because it takes a complicated project and makes it simply impossible. [21:46:24] <^demon> You can avoid doing the cdb backend stuff. [21:46:50] I mean: setting a logo in a UI is one thing, but we can't really expect anyone to want to deal with 700+ logos. [21:49:01] <^demon> Maybe--and maybe whoever writes it could punt actually writing the wmf-y stuff. But they'd have to write it at least *thinking* about the long-term plans because otherwise we'll have to massively change it when we add the wmf things. [21:49:20] <^demon> Things like inheritance and per-wiki variances have to be thought about at a high level. [21:49:53] Change merged: IAlex; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42288 [21:52:16] Change merged: IAlex; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42295 [21:56:40] 03(mod) allow list=deletedrevs&drprop=content with "deletedtext" - 10https://bugzilla.wikimedia.org/28261 (10Matthew Flaschen) [21:57:20] New patchset: Kaldari; "Adding More Info link to Special:Notifications" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/42351 [21:58:41] Change merged: IAlex; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42284 [21:58:51] ^demon: doesn't appear like WikiEditor has any special handling in https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/tools/release.git;a=blob;f=make-wmf-branch/default.conf;h=370d9452c2a7eca561b369eb33b1def0b4156ceb;hb=HEAD [22:02:56] New patchset: IAlex; "[JobQueue] Increment stats for jobs ignored as duplicates." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39714 [22:02:57] 03(mod) allow list=deletedrevs&drprop=content with "deletedtext" - 10https://bugzilla.wikimedia.org/28261 (10Aaron Halfaker) [22:03:39] <^demon> Yurik: Looking, one moment. [22:04:54] ^demon: do you remember why the "owner":{"name":...} were missing from "ssh -p 29418 gerrit.wikimedia.org gerrit query --format=JSON --current-patch-set change:41035" and "ssh -p 29418 gerrit.wikimedia.org gerrit query --format=JSON --current-patch-set change:37771", as mentioned in comments to https://gerrit.wikimedia.org/r/#/c/37771/ ? [22:05:29] <^demon> No clue. [22:06:08] <^demon> A couple of people's accounts were messed up briefly, but they've been fixed. [22:06:13] <^demon> It might've had something to do with that. [22:06:15] but now it works, did you upgrade/change db/something else to fix it (it was reported end of Dec 2012) [22:06:33] <^demon> Yeah, fixed Mgrover and Fran. [22:06:42] so this is not a git-review bug and it should bail out saying "corrupted gerrit data" instead? [22:06:49] <^demon> I didn't know Thaiphan's rev was broken, but his user seems to be fine now. [22:07:06] <^demon> Yeah, it's probably gerrit's fault, considering the changes involved. [22:07:10] ok [22:07:15] <^demon> But having git-review handle it nicer would be good too ;-) [22:07:39] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39714 [22:08:23] yeah [22:08:33] that's the question now, to hide a bug or to fail early :) [22:09:20] <^demon> Well, does git-review necessarily need the owner? As long as the git committer/author are fine I don't know why owner matters. [22:10:17] it's really of minor importance, it's just for the "nice" local branch nae [22:10:59] <^demon> Pfft...no need to fail there. [22:11:33] <^demon> Anyway. 5pm, friday. [22:11:40] 22pm :) Friday [22:11:42] New patchset: Terrrydactyl; "Added IntelliJ extensions to .gitignore" [mediawiki/extensions/Git2Pages] (master) - https://gerrit.wikimedia.org/r/42353 [22:14:51] I have to ask, what language are you guys talking about? [22:15:17] ^demon|away: this nice "branch" thing is broken anywany [22:15:18] or more to the point, what language are you coding in [22:15:35] heave20: PHP, JS [22:15:55] thank you [22:16:30] heave20: but a lot of discussions are about Git, a version control system and Gerrit, a code review facility. [22:17:02] If you're puzzled with stories of branches, this is Git. [22:17:23] i'm slowly getting that. And if I'm to understand correctly you all work for Wiki and are the ones behind the programming? [22:17:32] <^demon|away> Yurik: Sorry, I forgot to get back to you. We have 25e693ba54ac74648cad05e9f8749b70ba6895bd deployed, which is the latest version on Jan 1st. [22:17:39] and your geniuses at coding [22:17:46] heave20: actually it's ~50% volunteers on this channel :) [22:17:52] <^demon|away> Yurik: df4848c89c3985f2ad50e266bd47cda9dd6e810a and newer will make it to the next branch. [22:17:56] wow [22:18:32] i love it when people paste sha1s on irc. it looks so hacker. :P [22:18:42] <^demon|away> It's me being lazy to shorten it :p [22:19:11] <^demon|away> Back in the day, we said stuff like r1234. [22:20:25] ^demon|away: that said, you really need to look at I4ecd0659d1f955a9b593d281a3fef0a81c218a52. [22:20:33] ;) [22:23:50] <^demon|away> MatmaRex: lgtm, but what does *display do? [22:24:06] <^demon|away> Also, needs release notes. [22:25:05] Thanks ^demon|away! now if only someone would help review https://gerrit.wikimedia.org/r/#/c/42070/ to get it into production :( [22:25:30] Yurik: have you been helping out by reviewing other changesets? that'll help [22:25:48] sumanah: point taken :) [22:26:16] https://www.mediawiki.org/wiki/Code_review_guide in case you want some tips, Yurik [22:26:34] How do you get more reviewers to review your code? Do you just come in here and meet people and ask people to help review it? I know Dereckson will be reviewing my code a lot but I'm just curious about how other people find reviewers. [22:26:50] terrrydactyl: https://www.mediawiki.org/wiki/Git/Code_review/Getting_reviews is a guide to that [22:27:00] always on point sumanah :D [22:27:26] terrrydactyl: :-) I have been on this job for 2 years so I have a LOT of history in my Firefox "awesomebar" (URL bar history) [22:27:44] ^demon|away: works only on IE 6 [22:27:55] or maybe 7 as well [22:28:08] works = does the same as regular display: [22:28:19] per CSS spec, it's an invalid value and should be ignored [22:29:19] <^demon|away> MatmaRex: I'm not a css guy, really. I mean it *looks* fine, but I'm running a recent version of chrome so I'm biased. [22:29:20] anyway i know i remember i googled where does this and inline-block work to make it, well, work [22:29:30] <^demon|away> I'd feel better if Timo or someone else more visually-minded signed off. [22:29:44] ^demon|away: display:inline + zoom:1 on old IE is the same as display:inline-block on reasonable browsers [22:29:47] essentially, i mean. [22:30:15] New review: Demon; "This *looks* ok, but I'd prefer someone who Knows More to ok this. Will need release notes." [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/39792 [22:30:23] zoom:1 is a nonexistent property per CSS spec and will be ignored everywhere apart from old IEs [22:30:32] New patchset: Jeroen De Dauw; "Change param definitions to work with Validator 1.0" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/39858 [22:30:41] and *display: inline is invalid syntax and will be ignored in the same way [22:30:51] <^demon|away> MatmaRex: I can +1, but I don't feel ok +2'ing that. [22:30:57] except on IE 6 (and maybe 7), and that's why we put it last [22:30:57] sure [22:30:58] <^demon|away> Especially sneaking it in on a friday. [22:31:05] i think i'll add this explanation in a comment somewhere [22:31:09] haha [22:31:12] 03(mod) Add "autoreviewer" to $wgRestrictionLevels on ptwiki - 10https://bugzilla.wikimedia.org/39652 (10Opraco) [22:32:31] ^demon|away: by the way. is there really no way to do release notes the way we do them without merge hell? [22:33:35] heave20: btw, you might enjoy skimming https://www.mediawiki.org/wiki/Manual:MediaWiki_architecture [22:34:01] 03(mod) Suppressredirect for patrollers on dawiki - 10https://bugzilla.wikimedia.org/43548 +comment (10Snowolf) [22:34:20] <^demon|away> MatmaRex: I'm half-tempted to switch us to ff-only for core, actually. [22:34:28] fastforward? [22:34:31] <^demon|away> Yeah. [22:34:46] <^demon|away> It means most changes will have to be rebased before merge, but 2.6 makes that behavior much nicer. [22:34:51] <^demon|away> Something worth discussing. [22:35:13] well, that wouldn't change much, would it? [22:35:14] thank you sumanah, how are you guys responding example: <^demon|away>MatmaRex: I'm half-tempted... [22:35:17] cleaner history, i guess [22:35:31] !tabcompletion | heave20 [22:35:31] heave20: Instead of manually typing another person's nickname in IRC, you can type the beginning of their name and hit TAB on your keyboard to get it autocompleted, like on the command line. This avoids misspellings. Just make sure it's the right person! [22:35:41] heave20: I'm sorry, not sure I understand quite what you mean? [22:35:43] oho [22:35:52] ^demon|away: we wlll end up in the endless patch-approval-rebase-approval- cycle :* [22:35:55] sumanah oh i get it [22:35:56] <^demon|away> MatmaRex: Cleaner history. You'd still have to resolve release notes, but you'd know a bit sooner from the UI. [22:35:59] heave20: we just type someone's name and use this to help ;) [22:36:03] <^demon|away> And not be surprised at merge time. [22:36:06] 03(NEW) installer should use set wgtmpdirectory - 10https://bugzilla.wikimedia.org/43644 normal; MediaWiki: Installer; () [22:36:10] Thank you very much [22:36:11] ^demon|away: oh, i'm not surprised anymore. :P [22:36:25] <^demon|away> saper: I want to merge the copy-approvals-on-rebase change. [22:37:28] 03(NEW) Selecting "back" button after navigating to an article from the Watchlist page results in an empty page - 10https://bugzilla.wikimedia.org/43645 normal; MediaWiki extensions: MobileFrontend (Beta); () [22:37:36] ^demon|away: so no one will be responsible for bad merges :) [22:37:47] <^demon|away> :) [22:38:43] <^demon|away> saper: https://gerrit-review.googlesource.com/#/c/34801/ [22:39:27] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/42299 [22:41:53] 03(mod) Navigation/Toolbox side panel is not collapsible/expandable when being logged out - 10https://bugzilla.wikimedia.org/43227 +comment (10Gregor Hagedorn) [22:43:18] ^demon|away: thx [22:45:51] New review: CSteipp; "Note: This cannot be merged until updates to EditPage in core are done." [mediawiki/extensions/AbuseFilter] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42268 [22:48:45] New review: Siebrand; "Have a look at how this was done in the Narayam extension. Conceptually, there is a default document..." [mediawiki/extensions/Echo] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42351 [22:48:57] New review: Tychay; "If TylerRomeo is okay with this, I'll +2." [mediawiki/core] (master); V: 2 C: 0; - https://gerrit.wikimedia.org/r/42289 [22:55:00] 03(mod) Flag/exclude events originating from WMF's IP range - 10https://bugzilla.wikimedia.org/43639 +comment (10Dario Taraborelli) [22:56:39] 03(mod) Flag/exclude events originating from WMF's IP range - 10https://bugzilla.wikimedia.org/43639 +comment (10Steven Walling) [23:01:44] New patchset: saper; "Remove docs for hook LoggableUserIPData" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42275 [23:03:04] 03(mod) Flag/exclude events originating from WMF's IP range - 10https://bugzilla.wikimedia.org/43639 (10MZMcBride) [23:07:19] New review: Siebrand; "Thanks for the review. I'll fix the merge conflict tomorrow and merge it based on Aaron's approval." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42275 [23:08:00] New patchset: saper; "Remove docs for hook LoggableUserIPData" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42275 [23:17:40] 03(mod) Global (to a wiki farm or family) message delivery (thoughts) - 10https://bugzilla.wikimedia.org/35306 +comment (10MZMcBride) [23:21:03] New patchset: saper; "Remove "LoggableUserIPData" hook" [mediawiki/extensions/CheckUser] (master) - https://gerrit.wikimedia.org/r/42355 [23:22:05] New review: saper; "I have proposed removal of the hook from the CheckUser extension in gerrit change 42355 (I79aadcccec..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/42275 [23:23:22] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41950 [23:23:33] 03(mod) Moodbar comments & feedback should make checkuser table entries - 10https://bugzilla.wikimedia.org/32925 +comment (10Marcin Cieślak) [23:27:36] New review: CSteipp; "Just to confirm, this patch seems to be working fine in 1.21 for a number of scenarios with I99a19c9..." [mediawiki/extensions/AbuseFilter] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42268 [23:36:57] Nikerabbit / siebrand / other international types, the Parsoid team is hoping to test linktrails (like [[Dog]]s) in other languages to make sure we're doing the right thing with them. If you know of ways that languages handle linktrails that are very unlike English, it would be awesome if you could test them against our test instance and report issues to us. [23:45:57] New review: CSteipp; "Tested and working. The other extension using the hook is Translate, so Niklas will need to give an ..." [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/42248 [23:46:07] can someone tell me how to handle post-requests on a specialpage? [23:49:02] New patchset: Mattflaschen; "Depend on jquery.json" [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/42357 [23:52:06] 03(mod) VisualEditor: Deleting content between a heading and an alien fails? - 10https://bugzilla.wikimedia.org/43135 +comment (10Gabriel Wicke) [23:53:02] 03(mod) VisualEditor: Deleting content between a heading and an alien fails? - 10https://bugzilla.wikimedia.org/43135 +comment (10Gabriel Wicke) [23:54:55] 03(mod) Selective serialization (tracking) - 10https://bugzilla.wikimedia.org/41948 (10Gabriel Wicke) [23:54:56] 03(mod) VisualEditor: Deleting content between a heading and an alien fails? - 10https://bugzilla.wikimedia.org/43135 (10Gabriel Wicke) [23:56:14] 03(mod) Selective serialization (tracking) - 10https://bugzilla.wikimedia.org/41948 (10Gabriel Wicke) [23:56:20] someone here? [23:56:49] seems to be a bit silent yes [23:57:08] can you tell me how to handle a post-request on a special-page? [23:57:21] sorry, but I can't [23:57:33] are you referring to some kind of hook? [23:57:58] i have a form that should adress the specialpage [23:58:34] i read, that i should include $wgRequest to my code [23:59:18] lbenedix_: http://www.mediawiki.org/wiki/Manual:Special_pages#WebRequest.php [23:59:18] lbenedix_: if you don't get an answer here try the mediawiki-l list [23:59:20] !lists | lbenedix_ [23:59:20] lbenedix_ : mediawiki-l and wikitech-l are the primary mailing lists for MediaWiki-related issues. See https://www.mediawiki.org/wiki/Mailing_lists for details. [23:59:26] Noooooooooo [23:59:32] Globals = Evil [23:59:41] Try the new RequestContext stuff [23:59:50] $wgEvil