[04:07:48] <TimStarling>	 why is there no abandon button on https://gerrit.wikimedia.org/r/#/c/273690/ ?
[04:31:58] <Leah>	 Dunno. https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/ArticleCreationWorkflow,access looks okay.
[04:34:33] <TimStarling>	 I did it from the command line
[04:34:37] <TimStarling>	 weird
[07:37:22] <Guest64350>	 hello, is there an easy way to rotate text...
[07:38:22] <Guest64350>	 i want to label an table but the text is to long, so the label shoul be vertical
[08:57:24] <tonny_bennet>	 Helllo
[08:58:18] <tonny_bennet>	 I can't start parasoif service on Ubuntu Server
[08:58:29] <tonny_bennet>	 Plase help me
[08:59:58] <tonny_bennet>	 [fatal][worker][119857] uncaught exception Object function createApplication() 
[09:00:24] <tonny_bennet>	 in /var/log/parasoid/parasoid.log
[09:05:49] <Guest48813>	 back again, is there an solution without svg image to lable an table header with text from bottom to top (-90° rotation) ?
[09:05:59] <Guest48813>	 i use an css but the table get wrong scaled... 
[09:29:15] <Guest48813>	 nobody here?
[09:35:40] <Niharika>	 Guest48813: I'm here but I'm sorry, I don't know the answer to your question.
[09:35:52] <Niharika>	 Guest48813: Try asking in ~6 hours? 
[10:37:54] <Guest48813>	 k, i ll try another time thx
[10:37:56] <Guest48813>	 bye
[14:12:37] <kevindank>	 Hello, I've recently installed Wikieditor, i'm looking for a way to upload images while in the edit page.   When i look at Mediawiki's implementation seen here: https://www.mediawiki.org/wiki/User:Theslboat?action=edit&veswitched=1  it shows a pop up which allows you to upload when you hit the image icon
[14:12:51] <kevindank>	 but on my site, it just inserts the image tag wikitext, no popup or upload option
[14:12:53] <kevindank>	 any ideas?
[14:14:04] <kevindank>	 image here: https://imagebin.ca/v/2hoN6I7mAP9Y
[14:16:16] <MatmaRex>	 kevindank: there is some config setting in WikiEditor to enable the popup
[14:17:35] <MatmaRex>	 oh, wait
[14:17:43] <MatmaRex>	 kevindank: hav you tried clicking the "Upload" button there? :D
[14:17:52] <MatmaRex>	 wait, i'm lost now
[14:18:08] <MatmaRex>	 okay, that screenshot is from mw.org, not your site. :D
[14:19:34] <MatmaRex>	 kevindank: from https://www.mediawiki.org/wiki/Extension:WikiEditor#Configuration - i think this is $wgDefaultUserOptions['usebetatoolbar-cgd'] = 1;
[14:20:28] <kevindank_>	 Sorry Matmarex: got kicked
[14:20:36] <kevindank_>	 Did you say theres a config somewhere i need to change?
[14:20:43] <MatmaRex>	 kevindank: from https://www.mediawiki.org/wiki/Extension:WikiEditor#Configuration - i think this is $wgDefaultUserOptions['usebetatoolbar-cgd'] = 1;
[14:22:32] <kevindank_>	 MatmaRex: I had that set already, no luck
[15:07:49] <CZauX>	 I usually use msupload
[16:56:44] <Ox539>	 Hi, I am having troubles with LdapAuthentication
[16:57:18] <Ox539>	 Currently I am trying to go out to a Windows Server 2012 R2 that has Lightweight Active Directory Service installed
[16:57:55] <Ox539>	 Does anyone have any configuration for an Apache 2.4 (Unbuntu 14.04) to query against my AD Domain Controller?
[17:08:30] <Skizzerz>	 AD doesn't allow anonymous binds, so you need to make sure you have credentials for some unprivileged user that is able to bind to the domain in order to query it
[17:09:07] <Skizzerz>	 beyond that tidbit, it'd help more if you actually explained what issues you're experiencing
[17:16:31] <Trela>	 Just got the email.  All the Phabricator tasks are coming up as 403.
[17:35:54] <Ox539>	 Skizzerz: Thanks
[17:37:06] <Ox539>	 Here is my full explanation: http://stackoverflow.com/questions/37352167/ldapauthentication-mediawiki
[17:41:16] <MC8>	 silly git question here, I'm trying to bump from 1.23.13 to 1.23.14, but `git fetch origin 1.23.14` doesn't want to work
[17:42:57] <Krenair>	 Trela, every phabricator page gives you a 403?
[17:43:17] <Krenair>	 Trela, oh, the security tasks? yes, those will for a short time after release
[17:43:22] <shadowm>	 Is it just me, or the 1.26.3 upgrade patch doesn't bump the version number in the code and has "THIS IS NOT A RELEASE YET!" in RELEASE-NOTES-1.26?
[17:43:34] <Trela>	 Okay.
[17:44:14] <Trela>	 Oh yeah, says 1.26.3 in the tarball.
[17:44:18] <Trela>	 Erm, 1.26.2.
[17:44:49] <Krenair>	 ostriches, ^
[17:45:31] <ostriches>	 I'm working on the tags.
[17:45:46] <MC8>	 <3
[17:46:01] <ostriches>	 I suppose I did forget a patch to bump stuff in the tarballs.
[17:46:05] <ostriches>	 I hate releases.
[17:46:20] <Krenair>	 I saw the patch open in gerrit against REL1_26
[17:46:22] <ostriches>	 git will be done soon, security tasks are all open now
[17:46:32] <Krenair>	 didn't see the security patches in gerrit yet
[17:46:49] <ostriches>	 I bypassed it, zuul's already been exploding enough this morning.
[17:46:55] <ostriches>	 And last time the queue took like 6 hours
[17:47:05] <ostriches>	 I pushed directly to all branches
[17:47:59] <Krenair>	 to REL1_26? huh
[17:48:24] <Krenair>	 yep, there they are
[17:48:26] <Krenair>	 ok
[17:48:39] <ostriches>	 Yep https://phabricator.wikimedia.org/diffusion/MW/history/REL1_26/
[17:50:14] <Joergi>	 Hi guys, the MediaWiki 1.26.3 tarball contains the wrong version number - it says 1.26.2 instead of 1.26.3.
[17:50:19] <Joergi>	 Are the other updates included?
[17:50:23] <ostriches>	 They are.
[17:50:30] <ostriches>	 It's just the version number I missed bumping
[17:50:38] <ostriches>	 The tags in git will be correct.
[17:50:46] <ostriches>	 (the patch file should show the actual diff)
[17:51:02] <Joergi>	 commit and create the right tarball? ;-)
[17:51:20] <MC8>	 aren't releases fun
[17:51:27] <ostriches>	 I can retar them after tagging, I suppose yeah
[17:51:50] <Joergi>	 You really should. :-)
[17:51:53] <ostriches>	 MC8: Security releases especially. It's a chicken and egg problem. You want to produce the tars prior to anything being public in git.
[17:52:05] <Joergi>	 Please do that!
[17:52:09] <ostriches>	 I can.
[17:52:15] <ostriches>	 Lemme finish getting them all tidied up in git
[17:53:31] <ostriches>	 It shouldn't take too long once the tags are right since all the patches will be applied.
[17:53:55] <Joergi>	 ostriches: I don't know how you handle security relevant changes in the WMF infrastructure. Other projects use private Git repos, where privileged members can view and test security patches. Then committing them in the public repos and making the release can be done rather quickly. Ahh and you should in fact have a script to do and package the release...
[17:54:12] <ostriches>	 I do :)
[17:54:15] <ostriches>	 And we do :)
[17:54:31] <Joergi>	 But it obviously doesn't work...
[17:54:43] <Trela>	 Humans make mistakes.
[17:55:19] <ostriches>	 Pain is in porting patches between branches, that takes awhile. Once they're staged, building the tars is pretty pain-free.
[17:55:28] <ostriches>	 The human error this time was me forgetting a patch for bumping the version.
[17:56:30] <Trela>	 I always forget to bump version numbers.  :(
[17:56:34] <Joergi>	 Have more stuff done by computers. You could use a script, which uses a regexp to update the version number in that one file where it is, then commits it to git and builds the tarball based upon this commit.
[17:56:55] <ostriches>	 Patches welcome :)
[17:58:05] <Joergi>	 Pretty much three lines in a shell script, exactly as I wrote above. What youdo need for this to work is a user, who is allowed to commit directly although you use gerrit. 
[17:58:42] <Joergi>	 Or you do the commit by hitting the button in Gerrit; a small manual step at that point.
[18:12:48] <Joergi>	 Your security fix "Wrap diff generation in PoolCounter" introduces a fatal error:
[18:13:12] <Joergi>	 PHP Fatal error:  Using $this when not in object context in includes/diff/DifferenceEngine.php on line 827
[18:13:24] <MaxSem>	 bleh
[18:13:29] <Joergi>	  https://git.wikimedia.org/blobdiff/mediawiki%2Fcore.git/44591706fba5a25220aed0a9dd1d4c421b366c1a/includes%2Fdiff%2FDifferenceEngine.php shows the offending line
[18:13:35] <MaxSem>	 what's your PHP version?
[18:13:53] <Joergi>	 5.3. Old, but supported for MediaWiki 1.26.
[18:14:10] <MaxSem>	 not for long, thankfully
[18:14:19] <MaxSem>	 yaaaaay, I fucked it up!
[18:14:22] <MaxSem>	 ostriches, ^
[18:14:36] <ostriches>	 Well shit.
[18:14:42] <ostriches>	 Considering I just pushed tags.
[18:14:46] <Joergi>	 MaxSem: Only who works can make mistakes.
[18:15:26] <Joergi>	 Maybe you want to credit me when fixing "this". :-)
[18:18:37] <ostriches>	 Ugh I knew backporting that was a waste anyway
[18:19:13] <MaxSem>	 we should have made it public then
[18:20:08] <ostriches>	 Well too late now
[18:20:51] <ostriches>	 Tags rescinded.
[18:21:13] <ostriches>	 MaxSem: Please patch REL1_23, 25, 26.
[18:21:20] <ostriches>	 So I can retag.
[18:21:22] <MaxSem>	 raleady doing
[18:29:32] <Trela>	 We are having a WTF moment looking at the WikiEditor diffs.
[18:30:11] <Trela>	 https://i.imgur.com/ACePlGc.png
[18:31:56] <Joergi>	 Trela: How did that get committed?
[18:32:18] <Trela>	 Joergi: Came from the 1.26.3 tarball.
[18:32:37] <Joergi>	 Seems the 1.26.3 is a real goody... :-((
[18:32:55] <Trela>	 Hmm.
[18:33:14] <Trela>	 I think I may have updated WikiEditor at some point and that is just the original 1.26.0 bundled version.
[18:34:29] <ostriches>	 That seems more likely.
[18:34:37] <ostriches>	 WikiEditor wasn't patched in this release.
[18:34:42] <ostriches>	 It was just what was in REL1_26
[18:35:10] <Trela>	 Yeah, reverted on our end.  The patch reviewer's head started to spin over here.  XD
[18:37:57] <Joergi>	 Acording to Git there have not been any changes in WikiEditor 1.26 since the release in 2015...
[18:39:04] <MaxSem>	 okay, my vagrant is successfully FUBAR
[18:40:37] <MaxSem>	 ostriches, https://gerrit.wikimedia.org/r/289895 but I can't even test it :(
[18:42:02] <ostriches>	 1.23 and 1.25 too?
[18:43:47] <MaxSem>	 just cherrypicked
[18:43:58] <MaxSem>	 (and force-merged)
[18:44:26] <ostriches>	 mmk
[18:44:49] <kstange>	 Hey, the patch for the security update mediawiki-1.26.3.patch.gz seems to be from a pre-release of the code
[18:45:09] <kstange>	 the release notes say "This is not a release yet" and it doesn't have the correct version number
[18:45:58] <Joergi>	 kstange: The guys are currently working on this. What you found is not the only problem...
[18:46:52] <kstange>	 Joergi, alright.  Will another email be going out when it's corrected?  Is the 1.26.3 release tarball itself right?
[18:47:39] <Joergi>	 kstange: It fixes the security issues and as far as I can tell it does not contain old code (WikiEditor), which would introduce new issues.
[18:48:12] <Joergi>	 The current 1.26.3 tarball contains the version number 1.26.2, which is wrong. It is 1.26.3 (with additional bugs).
[18:49:01] <kstange>	 okay, so I should wait to upgrade until this is sorted out?
[18:49:35] <Joergi>	 Puhh, why are people asking me things like that?
[18:49:41] <kstange>	 hah
[18:50:03] <kstange>	 thanks for the info
[18:50:25] <Joergi>	 The current 1.26.3 tarball ill fix security issues. If you don't install it, these issues are unfixed. But it contains a bug which breaks things with Diff view.
[18:50:45] <Joergi>	 So either broken diff view or open sec issues. It's up to you...
[18:51:02] <kstange>	 My wiki is private so I think that we can wait a bit for a proper diff and tarball
[18:51:04] <Joergi>	 Or the best of both worlds, but only if you apply https://gerrit.wikimedia.org/r/#/c/289895/
[18:51:04] <MaxSem>	 or run up to date PHP and no diff breakage:P
[18:52:59] <ostriches>	 MaxSem: Was there a patch for 1.23?
[18:53:16] <ostriches>	 Oh yeah there it is
[18:53:16] <MaxSem>	 ostriches, https://gerrit.wikimedia.org/r/289897
[18:53:51] <kstange>	 one other thing I noticed is that https://phabricator.wikimedia.org/T89065 is fixed in the patch I looked at
[18:54:01] <kstange>	 but it's not mentioned in the changelog (this is a bug I reported)
[18:56:22] <ostriches>	 kstange: If it was fixed it was accidental?
[18:56:52] <kstange>	 pretty sure it was fixed on purpose, the code was refactored a little bit to handle https:// wikis
[18:57:00] <MaxSem>	 result of the day: I owe ostriches booze:P
[18:57:08] <kstange>	 but the person who fixed it might not have realized there was an open bug about the issue :)
[18:57:39] <ostriches>	 That's also possible
[18:58:32] <Joergi>	 kstange, ostriches: It was fixed with https://phabricator.wikimedia.org/T107290
[18:58:42] <ostriches>	 Tags look good on all the branches now
[18:59:34] <kstange>	 that doesn't seem to be in the changelog
[19:00:16] <kstange>	 (but I am glad it's finally fixed)
[19:00:25] <ostriches>	 I didn't realize it was backported, hm
[19:01:42] <Joergi>	 ostriches: You _are_ aware that the new patch does _not_ fix the issue?
[19:02:18] <Joergi>	 PHP Fatal error:  Call to protected method DifferenceEngine::textDiff() from context '' in includes/diff/DifferenceEngine.php on line 828
[19:02:28] <ostriches>	 I hate php.
[19:02:39] <ostriches>	 And mediawiki.
[19:03:13] <OutofControl>	 Anyone else upgrading to 1.26.3 seeing version in browser as still 1.26.2?
[19:03:23] <Trela>	 OutofControl: Yes.  Please hold.
[19:04:14] <Joergi>	 OutOfControl: Everyone. The tarball fixes the security issues, but contains a fatal error, if you use PHP 5.3. A solution is being worked on.
[19:05:14] <OutofControl>	 Luckily PHP 5.5 here. Bug in Antispoof extension though. Had to comment out the load_composer_autoloader line.
[19:05:34] <Joergi>	 OutOfComtrol: Please report to Phabricator.
[19:07:09] <OutofControl>	 Thanks. Will do.
[19:09:01] <kstange>	 so for my old bug that was fixed, should I close it as a duplicate of the other one?
[19:10:34] <ostriches>	 Probably
[19:11:27] <Joergi>	 Point to T107290 and close it.
[19:11:27] <stashbot>	 T107290: Run jobs async does not honor $wgServerName - https://phabricator.wikimedia.org/T107290
[19:11:54] <kstange>	 like that?
[19:12:27] <kstange>	 sorry, I'm not extremely familiar with phabricator, so I hope I'm not doing anything stupid :)
[19:19:14] <OutofControl>	 Bug T135870 filed for AntiSpoof. Thanks Joergi
[19:19:14] <stashbot>	 T135870: Antispoof error in extension.json after updating Mediaiwiki to 1.26.3 - https://phabricator.wikimedia.org/T135870
[19:28:24] <ostriches>	 MaxSem: Ok I revoked the tags, can you fix the protected issue in the 3 branches and re-tag?
[19:28:39] <ostriches>	 I gotta go to an appointment, if you can get it fixed and tagged, I'll redo the tars when I'm back
[19:28:47] <ostriches>	 Thanks!! <3 <3
[19:36:55] <kstange>	 it doesn't seem like the commit ab868409e57d actually fixes the issue 
[19:37:20] <MaxSem>	 yeah
[19:37:41] <MaxSem>	 because I can't even get fucking 5.3 to run to test this shit
[19:38:20] <kstange>	 I'm just living on PHP 5.3 from CentOS 6
[19:39:13] <Joergi>	 MaxSem: I have 5.3 here as well. What would be a URL, with which I can reproduce the bug (and test a future fix)?
[19:39:26] <MaxSem>	 just view a diff
[19:41:11] <Joergi>	 MaxSem: Got that.
[19:41:19] <kstange>	 I would try to help but I'm unfamiliar with this construction of $diff = function() use ()
[19:41:47] <Skizzerz>	 kstange: that would be a closure, see http://php.net/manual/en/functions.anonymous.php for more details
[19:42:37] <Joergi>	 If method DifferenceEngine::textDiff() would no longer be protected, but public, that would fix it, right?
[19:42:57] <MaxSem>	 yep, that's what I did
[19:44:12] <Joergi>	 Using reflection and a wrapper class to give the closure private/protected access functionality should be working...
[19:44:33] <Joergi>	 That's cumbersome.
[19:48:09] <Joergi>	 MaxSem: https://gerrit.wikimedia.org/r/#/c/289905/ solves the issue.
[19:55:47] <kstange>	 no other solution comes to my mind based on my understanding of the problem since the call is being made externally to an instance of a class
[19:56:26] <kstange>	 I don't know why textDiff is currently protected
[19:59:26] <MaxSem>	 because it wasn't supposed to have external callers
[19:59:42] <MaxSem>	 aaaand testedd on 1.23
[19:59:45] <MaxSem>	 (ugh)
[20:10:08] <Trela>	 I just updated all ​1,148 wikis in the farm without issue.  *Thumps up!*
[20:10:38] <MaxSem>	 O_O
[20:12:10] <Trela>	 o.o
[20:14:26] <Trela>	 Just saying that 1.26.3 posed no patching issues.  :P
[20:16:26] <kstange>	 but did you include the fixes for PHP 5.3 (assuming you're using 5.3)?
[20:17:44] <Trela>	 I did, but we run 5.6.
[20:41:35] <nihonjoe>	 Question for all y'all.
[20:42:20] <nihonjoe>	 What extension provides the insert menus at the bottom of the edit window?
[20:43:16] <mediawiki_user>	 hello, I'm pretty sure it was already reported before, but version "1.26.3" does not update $wgVersion (to $wgVersion = '1.26.3') in includes/DefaultSettings.php
[20:43:21] <mediawiki_user>	 that's pretty annoying
[20:43:33] <mediawiki_user>	 can you confirm this problem, please ?
[20:45:30] <MaxSem>	 yep, fix coming later today
[20:46:33] <nihonjoe>	 ANyone know?
[20:48:15] <mediawiki_user>	 MaxSem: thx, just making sure it's a know problem :)
[20:48:33] <mediawiki_user>	 known*
[20:51:05] <Trela>	      function getBottomScripts() {
[20:51:05] <Trela>	 -        // In case the skin wants to add bottom CSS
[20:51:05] <Trela>	 -        $this->getSkin()->setupSkinUserCss( $this );
[20:51:06] <Trela>	 -
[20:51:06] <Trela>	          return $this->getScriptsForBottomQueue();
[20:51:06] <Trela>	      }
[20:51:16] <Trela>	 Apparently that was patched out for some reason?  Breaks Vector skin.
[20:51:22] <Mikeonline>	 hi, did lts 1.23.14 miss to change localsettings.php version number? 
[20:52:04] <nihonjoe>	 Trela: Was that to me?
[20:52:24] <Trela>	 General channel, patch issue with 1.26.3.
[20:52:26] <kstange>	 Trela: I don't see anything wrong with vector
[20:52:49] <Trela>	 kstange: It causes the SkinVectorStyleModules hook to not be ran.
[20:52:57] <nihonjoe>	 Aha
[20:53:25] <kstange>	 that's a hook for extensions I assume that I just don't have any using?
[20:53:44] <Trela>	 Skins and extensions.
[20:58:44] <nihonjoe>	 Does anyone know which extension provides the insert menus at the bottom of the edit window? 
[20:59:30] <nihonjoe>	 THe ones for inserting wiki markup, symbols, math symbols, IPA, and the like?
[21:00:42] <nihonjoe>	 And if this isn't the place to ask, where would be better to ask?
[21:02:22] <MaxSem>	 nihonjoe, CharInsert
[21:09:53] <nihonjoe>	 MaxSem: Thanks!
[21:49:36] <gaeta>	 Anyone else experiencing issues with the 1.26.3 release on the main page? (https://www.mediawiki.org/wiki/Download) It seems to be missing commit 6996f6555976(Bump to 1.26.3 for tagging)
[21:53:36] <ostriches>	 gaeta: Yeah, the tarballs missed a few commits. I'm regenerating them now.
[21:53:42] <ostriches>	 The tags in git should all be correct though
[21:54:29] <MaxSem>	 better check than sorry :P
[21:55:07] <gaeta>	 Thanks. I pulled my update from git, but it took me a few minutes to find why the version page wasn't updating. 
[22:19:32] <ostriches>	 New tarballs uploaded.
[22:22:37] <ShakespeareFan00>	 Hi
[22:22:40] <ShakespeareFan00>	 I have a concern
[22:22:47] <ShakespeareFan00>	 It seems when mediawiki does layout
[22:22:58] <ShakespeareFan00>	 It NEVEr seems to behave consistently
[22:23:12] <ShakespeareFan00>	 when trying to do rather precise CSS/ DIV basedlayouts
[22:23:31] <ShakespeareFan00>	 Perhaps someone here can advise on how to beat it into submission?