[00:47:49] J [01:19:22] Hmm it looks like Extension:Contributors is totally broken on master [01:19:37] I'm tempted to just flat out revert it the version in the 1.27 branch [01:19:51] Does that version work in master? [01:19:52] It looks like someone tried to refactor it, but the refactoring couldn't possibly work [01:20:04] Hmm, I should try that first ;) [01:20:09] :-) [01:20:53] The master version has 0 calls to setContributors and the class property is private, so there is no possible way the master version could work [01:21:54] well at the very least its working more than the master one is [01:23:03] yeah seems to work [01:23:26] I don't actually understand what the point of this extension is anyway. Looks like a dupe of Core's ?action=credits feature [01:26:30] 1.27 was kind of an arbitrary point to test. Seems like much of the flaws came in when Ike Hecht rewrote half of it (poorly) [01:43:37] FoxT: ooops!!!! I forgot to use a stable version of that package... so now the latest release of Maps has a @dev requirement >_> [07:14:53] could someone block https://www.mediawiki.org/wiki/Special:Contributions/Onlinevashikaranmolana ? [07:17:54] Looks like he already is [07:20:27] samwilson: do you want to be an admin on mw.org ? [07:20:49] you're a dev so you qualify for auto admin rights [07:24:32] Well if you do, let me know [08:44:18] Hello [08:44:38] Is there a possibiliti to change the name of a created Page? [09:45:24] Hello, is there someone? [09:48:44] hey if I wanted to make a link (e.g. mediawiki style link, like [[Hello]]) but one that sends the user to the edit function of the page.. how might I do that? [09:54:36] the closest I've got is... (and it works) [09:54:36] [//{{SERVERNAME}}/index.php?title={{PAGENAMEE}}&veaction=edit Edit] [09:57:44] hmm which unfortunately doesn't work in the sidebar [09:59:08] hmm this works though... ** //{{SERVERNAME}}/index.php?title={{PAGENAMEE}}&veaction=edit|Edit [10:22:22] . [12:50:04] hello :) is someone there? [12:53:42] DL2ROY: yes, many people. [13:06:59] !ask | DL2ROY [13:06:59] DL2ROY: Please feel free to ask your question: if anybody who knows the answer is around, they will surely reply. Don't ask for help or for attention before actually asking your question, that's just a waste of time – both yours and everybody else's. :) [13:10:55] DL2ROY: Ah, I see, it's in the backscroll. Yeah, you can rename a page by moving it. Use Special:MovePage/Name_of_page_you_want_to_rename [13:39:49] !ask Is it possible to edit the Name of an already created page? [13:39:49] Please feel free to ask your question: if anybody who knows the answer is around, they will surely reply. Don't ask for help or for attention before actually asking your question, that's just a waste of time – both yours and everybody else's. :) [14:43:59] hi [17:48:49] hello! im preparing to Google Code-in and i wish to know how to contribute to mediawiki when the competition starts. How does mediawiki know which contributions i've made? how the whole process works? thanks! [17:50:23] hi migdinny, you can register to phabricator ( https://phabricator.wikimedia.org/ ) and look for relevant tasks [17:51:15] you can scan for interesting tasks here: https://phabricator.wikimedia.org/tag/google-code-in-2017/ [17:51:53] Hi! already did it. But how does the review process work on Google Code in? Im participating and i'd like to work on mediawiki [17:53:14] migdinny, is there any specific task that you already selected? are you familiar with git? and gerrit? [18:01:43] i am familiar with github... dont know if it's the same. i have mediawiki on my wamp server, successfully installed and configured. i can give you an example task on GCI 2016, this year's havn't started yet [18:05:15] gerrit is code review tool used by mediawiki (somewhat similar to github). you can work on the specific task (change the relevant code/doc files) and commit it on a branch, upload to gerrit for review and once the review is passed the code gets to mediawiki [18:05:47] here is a quick overview of the process: https://www.mediawiki.org/wiki/Gerrit/Getting_started [18:08:42] i have github desktop on my own computer. can i do that using this software? do i have to use gerrit in order to have my code reviewed for GCI? [18:14:42] you need gerrit in order to upload code for review in mediawiki (including for GCI). it should be simple to install [18:15:45] migdinny: Can github desktop use custom push urls? [18:16:29] To be clear, you do not install gerrit locally, you need to install git. Gerrit is the name of the web interface we use, its not something you install [18:17:53] Gerrit will work with any general git tool. I'm not familar with github desktop. If it can push stuff to arbitrary git repos its fine, but if its hard coded to github it won't work [18:18:10] yes, sorry if I wasn't clear. to push changes to gerrit you can either use "git review" script or use git to directly push to gerrit URL [18:18:44] migdinny: Any time you submit a patch its associated with your email, which is how we know its you [18:19:16] migdinny: If you want to practise, you're free to submit patches before the competition starts (They won't count for the competition though) [18:27:00] my internet went down, but answering to you: i dont know if github desktop has custom push urls... [18:28:02] i think github desktop can do the same as git does because when i want to clone from a URL i can go for "git clone https...." but instead of git, i use github -> "github clone bla bla" [18:33:54] this is so hard to understand, do i really have to use gerrit on GCI? Can't i use github desktop and commit changes there? [18:34:41] media wiki documentation has a lot of information and i just get confused each line i read. the stuff that goes on the terminal, i think that only works on linux and im using windows [18:37:26] hi migdinny [18:37:32] hi! [18:37:41] We do have developers who run Windows, so everything should still be possible to do without needing Linux [18:37:51] yeah, agree [18:38:10] Using Gerrit is part of the process of contributing to MediaWiki, it has a little steeper learning curve, but shouldn't be too hard to pick up. [18:38:30] yes! can you help me ? [18:41:18] sure, what do you need help with? [18:41:46] the first thing i need to do to contribute is surely to use Git, right? [18:41:53] so i am here: https://www.mediawiki.org/wiki/Gerrit/Getting_started [18:42:12] they ask me to install git. did it. am i on the right way? [18:42:19] yes [18:43:38] https://git-scm.com/download/gui/windows [18:44:22] yea, i downloaded from there [18:44:26] https://help.github.com/articles/setting-your-username-in-git/ [18:44:39] now im here, what do they mean "username for a single repository"? [18:44:57] do they mean that if i commit any change on that repository, that username im setting will be shown there? [18:45:31] They mean your username for use in that repo (vs your default username for all repos) [18:45:39] yes [18:45:51] usernames don't really matter that much, you can always change it later [18:46:14] yes... that link u've sent about the GUI clients [18:46:26] can i use github desktop instead of all these terminals? [18:47:03] since github desktop is listed there as a GUI tool for committing [18:48:57] I've never used it, and I don't think anyone else here has either. So its unclear whetehr or not github desktop supports doing git push to places other than github. If it does you can use it, but given nobody else is using it, you're going to have to figure it out on your own if you want to use it [18:50:11] yes.. i think it does, i just dont know how [18:50:49] the source-code on github is exactly the same on gerrit? because i've downloaded and installed mediawiki on my wampserver using github [18:51:15] Yes, the github source code is a read only mirror of the git source code [18:51:40] that means that any change on gerrit goes to github immediatly right? [18:53:27] Basically. I'm not sure if there is a delay, but it probably wouldn't be more than 30 seconds [18:54:47] my primary question is: on GCI, can i develop on github desktop using the mirror on github.com ? or i have to use gerrit platform ? [18:55:26] and what is phabricator? i see on the tasks provided on GCI 2016 a link to phabricator [18:55:27] whats that? [18:55:58] migdinny: phabricator is a website we keep bug reports on [18:56:14] so it is different from gerrit [18:56:30] i thought they were the same :p [18:56:39] migdinny: If you can submit your patches to gerrit, you can use any local development process you want. But if you're doing something nobody else has experiance with, you're going to be on your own in terms of figuring out how to do it [18:56:54] yeah, got it... [18:57:06] No, phabricator and gerrit are different. One is https://phabricator.wikimedia.org and gerrit is https://gerrit.wikimedia.org [18:58:49] im creating an account on gerrit. they ask me for a shell account name, is it the username i set on Git? [18:59:20] no [18:59:28] whats that then? [18:59:57] Well I mean it could be [19:00:04] xD [19:00:12] https://wikitech.wikimedia.org/w/index.php?title=Special:CreateAccount&returnto=Help%3AGetting+Started [19:00:18] Its whatever username you want to use for the command line [19:00:29] it does not have to be the same as the username you use for git [19:00:31] yeah, thats what i meant [19:00:36] but lots of people chose the same name [19:00:49] by command line what do you mean? [19:00:59] the command line i use to push, pull, commit etc? [19:01:03] on a repo [19:01:17] wikitech accounts are also used for tool labs, which gives you comand line access to a shared server [19:01:38] The shell username would be used for the username in an ssh url used for git push or pull [19:02:02] yeah, got it [19:05:39] how do ssh keys work? [19:05:50] what they are used for? [19:06:01] Think of it like a password that's in a file [19:06:38] https://en.wikipedia.org/wiki/Public-key_cryptography has the more techy details [19:07:11] and i use it to authenticate myself on a repo? [19:07:16] But you run a program, that generates 2 files, one is your private key and one is your public key. Your private key is like your password and allows you access to computers that have your public key [19:07:17] what is its purpose? [19:07:18] yes [19:07:29] hmm [19:08:14] Its not actually a requirement, you can also just use http passwords with gerrit (There's an option in your gerrit preferences, its not on by default and uses a different password than your normal password) [19:08:31] SSH is the industry standard for remote accessing computers [19:08:57] Its more secure than a normal password, as you don't send the password to the other computer, so the the other computer cannot steal your password [19:09:55] yeah, makes sense. [19:10:43] https://www.mediawiki.org/wiki/Gerrit/GitHub can you check this out and tell me if this is what im looking for? im looking for a way to make changes for gerrit using github desktop and discard all this terminal stuff [19:12:33] you could try it and see [19:13:03] hmm gonna do it [19:15:39] i dont think it's gonna work.... im gonna try the tutorial about gerrit and terminal [19:19:50] https://gerrit.wikimedia.org/r/#/settings/ssh-keys im here [19:19:59] i need to add my ssh key to gerrit. how can i do it? [19:20:10] do i have to copy and paste the content of "id_rsa" file? [19:20:14] NO [19:20:19] that's your private key [19:20:22] it needs to stay private [19:20:28] paste id_rsa.pub [19:20:30] understood [19:20:32] that's your public key :) [19:20:36] yeah [19:20:38] thank you !!! [19:20:59] am i still here on this chat? i got problems on my internet [19:21:02] yep [19:21:08] ty´ [19:21:23] one question [19:21:25] i opened that file [19:21:36] i need to copy EVERYTHING or just the key? [19:21:43] it has my email at the end of the file [19:22:37] yes it's everything, did it and worked [19:23:55] everything yeah [19:24:02] when git "fetches" the code, it "updates" it right? [19:24:13] uh, explain what you mean [19:24:29] on github desktop, there's a button on the top [19:24:30] that says [19:24:33] Fetch origin [19:24:41] when i click it, i think it updates the clone on my computer [19:24:48] so it remains the same as the repo [19:24:50] am i right? [19:29:58] I'm not sure what github desktop does, but "fetch" is a specific git command, it fetches in new changes from the server, but doesn't update any of your local branches [19:31:42] when i click on fetch origin, this loads for a little bit [19:31:52] and then shows me another buttom saying "pull origin" [19:32:08] and after clicking it it shows "last fetched just now" [19:32:11] pull is what updates your local branches, and it'll also fetch if necessary [19:32:49] hmm so the combination of this two commands is what i was saying (updating my local code to remain the same as the repo) right ? [19:33:49] yeah [19:33:50] well [19:33:53] pull includes fetch [19:34:07] yea i understood the logic [19:34:18] i just found out that there's a file on mediawiki/core on my own computer [19:34:21] the local code [19:34:28] and that file is: ".gitreview" [19:34:44] which i believe it has the informations on where the changes must go, right? [19:35:43] .gitreview is information for the git-review program [19:35:56] Which is a python script used by some people [19:36:13] yes [19:36:25] what is the git-review program exactly? [19:36:28] if you're using github desktop, you'll probably not be using the command line python script [19:36:43] yeah, im not. but im taking the tutorial to use git bash [19:37:09] and it asked me to install python and pip etc (already did it) [19:38:00] from the command line, to upload a change (without using git-review) you do something like git push ssh://@gerrit.wikimedia.org:29418/mediawiki/core.git HEAD:refs/for/master [19:39:10] hmm, and git-review does the same task? [19:39:28] git review is basically a short cut for that command line, because its annoying to remember [19:39:38] yeah [19:40:08] and it also sets up the pre-commit hook to add change-id (git review -S) [19:40:20] hmm [19:40:24] and git review -d is a convinent shortcut for downloading patches pending review [19:40:52] but all of these things can be done by hand without git-review if you so desire, and they are mostly not even that complicated to do by hand [19:41:24] hmm, for a newbie like me, whats ur advice? is it better for me to use gitreview? [19:42:30] Are you using git from the command line now, or still trying to use github desktop [19:42:41] im using gitbash [19:42:55] already set up my ssh keys on gerrit and on wikitech [19:43:15] In that case, i'd reccomend git-review [19:43:26] https://www.mediawiki.org/wiki/Gerrit/Getting_started on the third step they are saying to install gitreview [19:43:33] https://www.mediawiki.org/wiki/Gerrit/git-review and it took me here [19:43:53] hm [19:46:49] i have one problem [19:46:56] https://www.mediawiki.org/wiki/Gerrit/git-review#Setting_up_git-review [19:47:04] this asks me to : $ cd MyNewProj $ git review -s [19:47:17] but how can i "cd" to my mediawiki/core ? [19:48:26] ok i got it, i was on user's folder, i had to go to wamp/ww [19:59:27] bawolff are you there? [19:59:35] yep [19:59:52] im going to commit a change through gitbash, using gitreview [20:00:07] how can i check that this commit was successful and got into gerrit system? [20:03:40] it will show up on https//gerrit.wikimedia.org Also a notice will be sent to #wikimedia-dev [20:04:06] Include "[TEST; DNM]" in the first line of the commit message if it is a test commit [20:04:24] with or without quotes? [20:26:16] bawolff, u there? [20:26:36] without [20:26:49] im on gitbash, and whenever i do "git review", it asks for my credentials [20:26:57] but it always says that im unauthorized [20:27:14] im using the right credentials, i believe [20:27:22] the same i use to log into gerrit [20:28:05] What is the gerrit remote set to [20:28:22] whats that ? where can i see it? [20:30:13] git remote get-url --push gerrit [20:30:24] or in git config -l [20:31:05] If its saying unauthorized, its probably not using an ssh url, or your ssh config is wrong somehow [20:31:28] https://gerrit.wikimedia.org/r/p/mediawiki/core.git [20:31:29] this [20:32:12] It should be ssh://YOURUSERNAMEHERE@gerrit.wikimedia.org:29418/mediawiki/core.git [20:32:18] how can i change it? [20:32:39] git remote gerrit set-url ssh://... [20:32:40] unless you want to use http pushing, but that uses a different password then you gerrit password (password can be found in your gerrit user preferences) [20:41:25] Im really confused... which commands should i use to commit changes, etc? [20:45:06] commit with git commit as usual [20:45:31] it's just pushing to the server that requires `git review` instead of `git push` [20:46:49] Hi. any composer experts out there ? [20:51:24] just ask your question [20:54:47] :-) thanks. just installed 1.29.2 and ran composer update --no-dev which deinstalled half of the stuff that came initially along with MW. Deleted everything and started anew, this time only with "composer update", which deinstalled also the stuff and installed many development packages. So my question is if this is really intended, and if the fact that half of the packages get removed is wanted - if yes, then why provide them ? [20:54:53] Package examples: ruflin/elastica, symfony ... [20:56:11] I'm managing my installation with git and every new MW install followed by a composer update removes packages that the next MW release brings back again, so a merge of branches results in merge conflicts ("we added", "they removed" etc) [20:56:46] eof :-) [21:53:49] jhf2442: did you checkout the mediawiki/vendor repository? [21:54:54] jhf2442: I'm guessing you did, was there a specific reason you're running composer? was there something extra you wanted to install? [21:59:00] yes, wanted to add semantic mediawiki, but noticed that I always got more changes than expected. Therefore just too a vanilla MW setup and tried composer update -> some of the vendor addons were removed [21:59:18] s/too/took [21:59:46] I'd expected update to bring newer versions of the addons, not to remove them [22:00:24] I think you might have checked out the vendor submodule [22:00:40] try [22:00:44] git submodule deinit vendor [22:00:47] rm -rf vendor [22:00:52] composer update --no-dev [22:04:28] made a copy, removed vendor and ran composer. then did a diff : [22:04:51] Only in ../mediawiki-1.29.2_full/vendor: pear Only in ../mediawiki-1.29.2_full/vendor: pimple Only in vendor/psr/log: .gitignore Only in ../mediawiki-1.29.2_full/vendor: README.md Only in ../mediawiki-1.29.2_full/vendor: ruflin Only in ../mediawiki-1.29.2_full/vendor: stil Only in ../mediawiki-1.29.2_full/vendor: symfony [22:05:00] so basically same result [22:05:38] if eg symfony is not in the released composer.json, why is it present in the vendor directory ? [22:06:32] not that I would need it, but it's kind of strange behavior [22:21:00] jhf2442: you need it for the SyntaxHighlight extension [22:21:14] which is why it's in vendor/ [22:21:20] but only core dependencies are in composer.json [22:22:30] see https://www.mediawiki.org/wiki/Extension:SyntaxHighlight#Installation and in the instructions about composer.local.json [22:37:31] so basically the extension is installed (or delivered by default) but I have to activate it explicitely in composer.local.json to keep it ? [22:45:52] jhf2442: because you're using git and want to install SMW yes. If you use the other default stuff like mediawiki/vendor or the tarball then you wouldn't need to [22:47:38] oh, no, I'm using the tarball, but just handling my website setup using git. so I have a branch mw where I unpack the tarball and merge it into master where I have other plugins, themes and SW installed [22:48:15] * Platonides suggests jhf2442 to clone mediawiki git [22:48:16] the tarbal was what I was refering when talking about vanilla installation [22:50:31] ohhh [22:50:50] don't run composer in the tarball, it'll turn out poorly. use mediawiki git [22:51:07] @Platonides : https://phabricator.wikimedia.org/source/mediawiki/browse/REL1_29/composer.json also has no reference to for example symfony [22:51:34] symfony? [22:51:45] I don't think that's needed at all… [22:51:53] but it's in the tarball :-) [22:52:13] @legoktm : but I need to run composer update to install SMW :-( [22:52:35] that's fine, just get mediawiki from git [22:52:59] OK, will try it out immediately [23:01:10] We use some symfony depenencies but not the whole thing i believe [23:01:38] !hss | jhf2442 [23:01:38] jhf2442: https://upload.wikimedia.org/wikipedia/mediawiki/6/69/Hesaidsemanticga2.jpg [23:02:28] :P [23:02:48] why does it no longer show inline? [23:03:02] inline what? [23:03:08] it prompts for a download [23:03:19] instead of showing in the browser window [23:03:21] as it used to [23:03:27] "Content-Type: application/x-www-form-urlencoded" [23:04:06] grr [23:04:25] that Swift bug again [23:04:26] https://phabricator.wikimedia.org/T123806 [23:12:26] @MaxSem : :-) [23:14:24] @legoktm : OK, when using git the vendor directory does not exist, thus gets populated from scratch by composer update. however, still no symfony and the like, so besides the git merge mess no improvement [23:14:37] you need to create the composer.local.json flie [23:14:50] https://www.mediawiki.org/wiki/Extension:SyntaxHighlight#Installation [23:14:52] and add the syntax highlighter, right ? [23:14:55] yeah [23:16:36] ok, so I think I'll go for the tarball, delete the vendor subdirectory and run a composer update. This will be the starting ground for further additions. then I'll go through all extension directories and check for composer.json files, and add the extensions to the composer.local.json [23:17:49] using the git repo directly makes less sense to me. also the repo is 340MB in size, no need to carry that much data along [23:23:42] git clone has a parameter --depth :P [23:32:24] @platonides depth 0 is equivallent to taking the tarball :-)