[04:08:26] Ugh "PHP Fatal error: Declaration of MediaWikiPHPUnitTestListener::addError(PHPUnit\Framework\Test $test, Throwable $e, float $time): void must be compatible with PHPUnit\Framework\TestListener::addError(PHPUnit\Framework\Test $test, Exception $e, $time) in /var/www/html/w/tests/phpunit/MediaWikiPHPUnitTestListener.php on line 10" [04:08:44] I guess that means I probably have the wrong version of phpunit [04:09:12] * bawolff would be much more inclined to write tests, if the tests broke less often :) [04:27:03] ok, nevermind my whining [04:27:10] running composer update fixed the problem [04:27:23] guess we don't use the system phpunit at all [05:01:55] which is precisely how it should be done, right? use the version in the dependencies of the project [05:13:23] harmaahy1je: right. But prior to mediawiki adopting composer, it used to use system phpunit via pear or something, I think [05:13:34] And i still had that in my mind [05:13:52] Anyways, its always embarassing when I complain about something and it turns out to be my own stupid fault :) [05:22:38] don't be, we all have those problems [10:04:16] Hi guys, I want to move the code from HistoryAction.php getStartBody() to getEndBody() because of some design changes. But if I remove "$s = Html::openElement( 'form', [ 'action' => wfScript(), [10:04:16] 'id' => 'mw-history-compare' ] ) . "\n";" from getStartBody() the "Compare selected revisions" isn't anymore working. How can I fix that? Anyone a suggestion? [10:08:39] So I found out that I need at least "$s = Html::openElement( 'form', ['id' => 'mw-history-compare' ] );" in getStartBody(), but this breaks the design. Why isn't it working when I move the whole code frome getStartBody() to getEndBody()? [18:07:05] So I'm having a quick look through the compatibility page, has anyone done any testing of MW on 1.34 yet? I realise it has only just been released, but, I figured someone might have decided to play with it already. [18:13:13] Lcawte: Nope. It doesn't work with anything [18:15:19] Seriously? Ouch, I didn't know there were that many major breaking changes between point releases... [18:19:46] Lcawte: Sarcasm dear [18:20:31] :D [18:20:40] Sarcasm doesn't work well in text ;) And who knows, with software, it could have been true :P [18:23:59] indeed