[05:31:26] Nice to meet you. First of all I am sorry that I am not good at English. [05:32:17] It looks like you've blocked an Extension:Kartographer application on my website.Where can I contact to request an unblock? Of course, reduce the load on the application. [05:33:17] I'm very sorry, can anyone tell me? [05:33:25] It's not just you, it's blocked for all external requests [05:35:03] Does Extension:Kartographer mean that it can no longer be used? [05:35:27] No [05:35:32] You just need to use a different tile server [05:35:54] https://wiki.openstreetmap.org/wiki/Tile_servers [05:37:53] Thank you @Reedy. I am not good at English, so I can't understand immediately, but I'll look into it. [05:45:47] Is Extension:Kartographer just recently blocked? [05:46:39] That is confusing me. [05:46:46] Yes [05:47:26] thank you for your kindness [07:53:44] It is a continuation of the question in Extension:Kartographer. I don't know how to change the tile URL. [07:54:20] I think it is /extensions/Kartographer/modules/wikivoyage/wikivoyage.js [07:56:06] I'm not a good programmer like you [07:58:38] If you can write the commentary on Extension:Kartographer, users like me will be saved [08:08:21] I hope to be able to commentary on Extension:Kartographer in a few days [16:41:18] Sob: "Notice: Undefined index: wgDBPrefix in D:\Sites\wstudies\wiki\extensions\AuthDrupal\AuthDrupalEncode.php on line 53" http://www.gsws.pitt.edu/wiki/index.php [16:50:00] Nemo_bis: looks like a typo, the "p" in prefix should be lowercased [16:50:12] although.. you probably don't run that wiki [16:50:31] Skizzerz: yeah, just a random wiki archived by WikiTeam [16:50:52] so many die for bitrotting configuration [16:50:57] yep :( [16:51:44] or lack of updates in general [17:01:37] Skizzerz: indeed, like this https://sidvind.com/api.php [438f0727] /api.php MWException from line 226 of /var/www/websites/sidvind.com/public/includes/Hooks.php: Detected bug in an extension! Hook ConfirmEditHooks::APIGetAllowedParams has invalid call signature; Parameter 1 to ConfirmEditHooks::APIGetAllowedParams() expected to be a reference, value given [17:06:08] Is "Configuration Needed" even a MediaWiki thing https://wiki.thinkyhead.com/ [17:13:27] heh, PHP variable and function names are not case sensitive, but array keys are [17:18:32] Funny, this wiki was called "brion" https://archive.org/details/wiki-brioninriafr_gallium [19:52:58] I have a template and inside it there is an external link rendered like [http://foo.bar link text]. I am trying to modify the link rendering using the hook LinkerMakeExternalLink but it isn't being called on page render. any idea what's up? [19:53:05] is the fact that it's inside a template relevant? [19:53:48] >'LinkerMakeExternalLink': At the end of Linker::makeExternalLink() just before the return. [19:53:53] useful docs are useful [19:54:07] I *think* that hook is only called when you generate the external link inside PHP [19:54:16] Reedy: I understand. but shouldn't Linker::makeExternalLink() be called during page render? [19:54:29] Potentially not [19:54:31] since it has to parse the wikitext [19:54:33] ok [19:54:41] Hmm [19:54:41] Though [19:54:52] The extension I was going to look at for an example for this... [19:54:53] Uses LinkerMakeExternalLink [19:55:03] But I don't know if it works inside templates either [19:55:10] maybe caching is screwing it up somehow [19:55:18] yeah, I don't know how templates are implemented [19:55:26] potentially if parser output is cached [19:55:28] nevermind, caching is off [19:55:31] on this instance [19:55:41] Reedy: so basically I want a way to rewrite all external links for a particular domain to another domain [19:55:47] not to change how they're stored. just to rewrite on render [19:55:51] Yeah [19:55:54] So my example... [19:56:11] https://github.com/wikimedia/mediawiki-extensions-SecureLinkFixer/blob/master/includes/Hooks.php [19:56:25] Uses that hook, and basically does soemthing similar... basically replaces http with https in certain cases [19:57:10] yep [19:58:11] ok, so when I save the page it runs [19:59:13] this seems to be whether it's a template or not [19:59:40] where is it being stored? what's preventing it from running other than on save? [20:01:06] I mean it gets called in Parser.php, as far as I can tell [20:02:19] line 1653 I believe is the relevant one [20:07:47] going to try restarting php maybe [20:08:49] same ... I wonder where it's being saved [20:10:13] line 1807 actually (in 1.34) [20:31:22] ok got it [20:31:25] it was the parser cache [20:31:28] nuke it and all is well [21:32:16] what is the most appropriate hook for an extension to call addModules for something that should be added to every page render? currently doing BeforePageDisplay, I guess that's reasonable [21:33:32] that sounds like the right one [21:34:20] cool [22:30:55] who can merge https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/561848 ? [22:56:57] does anyone know offhand how to detect from javascript whether MobileFrontend is active? [23:01:52] I guess you could try to find an id or class that only shows up when it's in use ... but other than that I don't know of anything client-side to test for [23:02:05] DSquirrelGM: well there's the whole mw object [23:02:08] no way to introspect it? [23:04:00] It should inject some variables... But I don't know how stable/long term you can necessarily expect them to be there [23:05:27] ok [23:05:39] or for that matter, if it's going to support user-supplied client-side script at all in the future [23:05:56] DSquirrelGM: what do you mean by "support"? [23:06:12] I am adding a hook with mw.hook() that MobileFrontend fires [23:06:22] but there's no point in adding it if MobileFrontend isn't running [23:06:25] I guess I can just leave it [23:06:51] on a lot of installations external scripts aren't loaded, is what I was trying to say [23:07:10] this is a module loaded by an extension [23:07:16] not sure what you mean by external scripts [23:07:51] this module needs to support certain behavior whether MobileFrontend is there or not [23:08:00] s/module/extension/ [23:11:28] on a separate but related topic, is there any requirement at all how to mark up the edit box for editing pages? currently it's but the id is one thing in vector and another in minervaneue [23:12:48] wpTextbox1 seems to be hardcoded, actually [23:12:52] so maybe just MobileFrontend doesn't use it [23:15:58] anyway, I suppose there's no harm in adding a hook that will never fire [23:29:57] aha. it defines mw.mobileFrontend [23:48:16] ningu: i believe using mw.config.get('wgMFMode') is preferred. it will be null on desktop, and a string on mobile [23:50:53] ok cool