[03:38:56] Merhaba [08:17:11] Hi, is it possible to get the most recent changes? If I go to special recent changes, I don't get the newest changes. Looks like the page needs some time to update. Is it possible to get a 'live' updated recent changes page? [09:06:16] timmyzaaab: It should list the most recent changes. Browser or intermediate cache may be caching that page and display old results. In that case modifying some filters should give you updated results [09:06:40] Some filters may be hiding you "recent" changes, for example changes made by bots [09:06:57] Otherwise, there may be a problem with your installation [09:23:55] Can someone please help me with this username filter issue: https://dpaste.org/wJRu [09:26:15] it works perfectly on regex101.com [09:28:29] when I try to use it on my server it just returns the entire string [14:13:04] Reedy, quick follow-up question from yesterday's job runner discussion. I have my runners...running... and I'm watching the queue sizes and while I generally see stuff getting processed, now it's steady and unchanging with runJobs --group saying `refreshLinks: 0 queued; 455 claimed (455 active, 0 abandoned); 0 delayed` - the runner is going but the [14:13:05] wiki's jobRunRate is still 0.5, is it possible the wiki's php-fpm processes have claimed the jobs but aren't processing them due to low activity on the affected pages and thus the runner can't handle the claimed pages? Is that a possibly correct understanding? [14:13:43] AIUI, if they claim them, they will run them almost immediately... Or at least, within the life of that request [14:14:43] if I'm reading the timestamps right, the jobs are around 30 minutes old [14:15:17] e.g. `refreshLinks Plantilla:Tabla_de_vendedores pages={"7882":[0,"Kit_de_reciclaje_selecto"]} rootJobSignature=5f5b5c3ac75bd97c74f9bdb87a7b9a5e182acac9 rootJobTimestamp=20200424134241 triggeredRecursive=1 causeAction=edit-page causeAgent=GW2ESBot namespace=10 title=Tabla_de_vendedores requestId=6da410e99d276c102662cace [14:15:17] (id=1154677,timestamp=20200424134251) status=claimed` [14:16:04] Is $wgRunJobsAsync true or false? [14:16:19] hmm dunno never set it, so it's whatever the default value would be [14:16:34] should be false [14:16:39] Just double checking.. [14:16:43] As that will spawn other processes [14:16:45] if true [14:16:56] * When $wgJobRunRate > 0, try to run jobs asynchronously, spawning a new process [14:16:56] * to handle the job execution, instead of blocking the request until the job [14:16:56] * execution finishes. [14:18:17] looks to be the default false value [14:21:41] Do your web request workers have some sort of timeout/killer? [14:21:50] like, if not done in X seconds, kill [14:22:11] I believe so, let me check, should be in the php.ini or pool config [14:22:25] Cause, if the job is sufficiently big/complex.. It may not get done [14:22:33] So you might be better just setting runrate to 0 and [14:23:46] `request_terminate_timeout = 90` seconds [14:24:53] and `max_execution_time = 30` [14:25:40] Add in some of the complexities of SMW and time that can take to serve [14:27:11] I can see that these jobs were generally created by a recent template change. This is the smallest of our SMW wikis by far but still has a fairly involved set of templates [14:28:11] a couple of fairly significant template changes to widely used templates, in fact [14:29:04] ok they're starting to decrease it seems [14:29:14] down to 428 [14:30:03] I will set the run rate to 0 to be safe but it's probably just the template and smw complexity of our wikis that leads to this kind of processing. Appreciate the help! [14:30:54] Yeah [14:31:04] And rather than bundling stuff into web requests.. [14:31:19] If your wiki/workload is sufficiently complex, a seperate runner is probably the way forward [14:33:09] Well I'm glad I finally took the time to implement runners. I have them going now for all 5 of my main wikis and I'll test setting their job run rates to 0 to see how that affects job processing. Most of the time their queues are at or near 0, but occasionally template edits can cause quick massive spikes that can take a long time to process. It'll [14:33:09] be interesting to see how this goes over the next few weeks. [14:33:15] Again I really appreciate the help! [14:34:16] np :) [14:34:23] You're monitoring your job queue levels [14:34:34] So if something doesn't quite work right, you should know fairly quickly [14:35:49] I would hope so, but it can be difficult to know if any given pattern to the queue is what it should be, under the given circumstances, or if it's abnormal. Now that I have the runners, maybe I'll see different patterns than what we've historically had using wgJobRunRate. [14:46:18] justinl: Are you tracking actual run rate? [14:47:24] I'm tracking the queue size, currently both through the api siteinfo stats and a job table row count, but I am not tracking the actual rate at which jobs are being run. Is there a way to get that outside calculating it from the queue size? [14:48:34] https://wikitech.wikimedia.org/wiki/Kafka_Job_Queue#Graphs [14:49:38] You can't necessarily calculate it from the change in queue size.. Because jobs get added, jobs get removed [14:50:24] I was looking at those just yesterday, but they're using Kafka. We don't currently have any special handling of the jobs or any logs. [14:51:19] As a gross error check... As long as it's not growing continuously for a long time, and not decreasing, you're probably in a reasonable position [14:51:33] Are the metrics from Kafka or MW itself? I know it can emits stats metrics, never really looked much in to that, though, even though I could enable it via collectd's statsd plugin. [14:54:10] I'd presume from the EventBus extension [14:54:58] graphs like this one [14:54:59] https://grafana.wikimedia.org/d/000000400/jobqueue-eventbus?edit&orgId=1&from=1587718491938&to=1587740091939&var-site=eqiad&var-type=All [14:55:00] are from kafka [14:55:04] Here's our queues from the last 10 days, you can see how bad one of them got. https://imgur.com/jXVnHNe [14:55:42] Interesting about the EventBus extension, I'll have to look into that. [15:01:18] Is anyone here familiar with wikitaxi [16:06:54] where do I go to report a violation of the GPL? I was looking at the fsf's site and they say I have to bring it up with the copyright holders [16:08:12] wychmire: Violation of GPL with what exactly? [16:08:22] Or where, even [16:09:01] A company is using MediaWiki software but not disclosing the source and they've specifically said there are no plans to do so [16:09:36] I'm not sure I want to mention the specific company here but it's one of the bigger wiki farms [16:09:57] What exactly are you thinking they should be releasing etc? [16:14:49] They've made changes to their MediaWiki instance and have developed several custom extensions that Special:Version lists as being GPL-2.0-or-later. Their instances of MediaWiki are publicly available and all new wikis created with them are using their modified version of MediaWiki. I'm not a lawyer or anything but I'm pretty sure they're required to make the source for that available. [16:15:11] They have a github repo, but it's private and non-members can't view it [16:15:18] https://github.com/wikimedia/mediawiki/blob/master/COPYING#L5-L9 [16:15:26] IANAL too, but I would concur [16:15:38] I mean... Explicitly listing it as GPL and not releasing it feels odd [16:16:15] But then, so do many hardware vendors [16:16:24] I'm waiting on at least one request for GPL sources... [16:17:14] wychmire: I guess it would be something you could/would bring up with the Wikimedia Foundation legal team... As per https://meta.wikimedia.org/wiki/Legal#Wikimedia_Foundation_Email_Contacts I guess legal@wikimedia.org [16:17:42] I obviously have no idea how strictly they're willing to enforce this... But I'd hope they'd be willing to at least remind the offender of their obligations [16:19:00] I'll send them an email, thanks. As one of the biggest public wiki farms I think Wikimedia would at least warn them, if not take action of some kind [16:19:17] Well, it's not even necessarily biggest... [16:19:29] Wikimedia are generally considered the maintainers of MediaWiki etc [16:19:40] or at least, the biggest legal entity behind it [16:20:23] The WMF definitely has law/copyright geeks on staff, so I'm sure someone will be able to advise [16:25:33] From my understanding, they don't have to store the code in a public repository. You can ask them to give you a copy of the source code [16:26:59] Also they can charge you a fee for the source code, apparently https://law.stackexchange.com/questions/18499/is-it-a-gplv3-violation-for-a-project-to-charge-a-fee-for-downloading-binaries [17:17:23] Can someone please help me with this username filter issue: https://dpaste.org/wJRu [17:17:37] when I try to use it on my server it just returns the entire string [17:17:41] it works perfectly on regex101.com [18:53:17] Hi all, when editing through https://directory.fsf.org/wiki?title=Free_Software_Directory:Backlog_active&action=edit , the "Show preview" button isn't shown, despite other pages in same wiki having that button. [18:53:25] How to fix that? [19:10:30] Any errors? Browser console? [19:15:01] Reedy: Will check [19:18:37] JQMIGRATE: Migrate installed with logging active, version 3.0.1 load.php:139:630; Deprecated ResourceLoader module "jquery.ui.widget". load.php:31:815; "mw.toolbar" deprecated. 9 load.php:154:976; … [19:18:42] … Deprecated ResourceLoader module "jquery.ui.core". Use OOUI instead. load.php:1:87; JQMIGRATE: jQuery.fn.bind() deprecated load.php:140:208 [19:18:57] That's what appears there [19:19:05] In web page console [19:22:41] Both of those ashouldn't be an issue [19:23:42] I'll see if browser console itself shows smething (I took the text from the browser too, but was the console of the current page) [19:27:30] Sorry, got connection loss. [19:28:02] Reedy: No other information in the entire browser console. [19:29:35] FWIW, I don't see show preview on other pages [19:29:38] https://directory.fsf.org/wiki?title=Gtick&action=edit for example [19:30:24] I wonder if it's FlaggedRevisions related? [19:31:10] Well, whatever is giving [19:31:11] >Please note that you are now editing the latest revision of this page, which is not the approved one shown by default. [19:32:22] Reedy: Hm, i see [19:32:48] https://www.mediawiki.org/wiki/Extension:Approved_Revs in this case [19:33:49] Strangely, this one shows the "Show preview" button: https://directory.fsf.org/wiki?title=Free_Software_Directory:COVID-19_Response_Team&action=edit [19:34:49] Curious [19:35:15] https://directory.fsf.org/wiki/MediaWiki:Common.js [19:35:21] /* Active Backlog: fix. ""Preview" button does not work for Template:Entry. It shows the unedited version"... */ [19:35:25] I'm guessing that explains it [19:37:18] Reedy, looks like using the same composer.local.json to include SMW on our non-SMW wiki works, so I must've had a bad config in the past. However, it displays a banner on every page alerting that SMW is available but not loaded. [19:37:26] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/src/MediaWiki/Hooks/BeforePageDisplay.php#L48 this is the line of the notice [19:37:48] this is the JS that loads it - does it look like there's a clean way of preventing that message? [19:37:52] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/src/MediaWiki/Hooks.php#L160 [19:38:43] If not, I could likely have our main editors tweak the site CSS/JS to hide it. [19:38:51] Reedy: Ah, thanks very much for the help [19:39:07] I'll take note of that and study what must change [19:43:45] justinl: I think I'd poke the SMW people an ask them to add a unique identifier to the class of that div to allow you to hide it [19:44:30] And then do it in site... css? [19:44:40] Cause that's just annoying being on every page [19:44:59] I'm sure our main editors would know how to handle such a thing. [19:45:15] It's not difficult [19:45:21] Yeah it is, I'm just stoked that it makes my desire to move to a wiki family feasible! [19:45:31] Just if anything else uses "errorbox"... it'll hide them [19:45:38] Which probably isn't an actual issue [19:45:55] But asking for unique classes on things is a common enough request we get in MW core [19:46:19] What's the best channel for such a request to them? Their github repo, mailing list? [19:46:29] I'd file a github repo issue personally [19:46:34] Cool, thanks! [19:46:37] Or even propose a PR [19:46:50] it's basically something like [19:47:04] replace '
got it, thanks! [19:51:29] Greetings all [19:53:31] I’ve been having issues with some of the smw related extensions - the change from semantic pages to page forms is new to me - I’m getting this error when trying to ‘edit multiple pages’ [19:53:47] https://www.irccloud.com/pastebin/Offay35G [19:55:52] I’m also having issues with the MITRE hierarchy extension that gives an error about requiring page forms which is already there [19:59:03] Hope this is sufficient, crossing my fingers! https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues/4742 [21:14:02] justinl: LGTM [21:16:43] I'm guessing it's some sort of MW/PF mismatch [21:16:43] https://github.com/wikimedia/mediawiki-extensions-PageForms/commit/656ddbf1734b5ad866bb5b81696579e8d3b330e8 [22:43:22] Reedy: smw 3.1.6 mw 1.34.0 pf 4.8 [22:45:19] Thanks for the link - can I just remove the line “$text = $linkRenderer->makeKnownLink( $this->getTitle(), $templateName, [], $linkParams );” from pf? [22:51:25] I woudln't just remove it, no [22:55:52] 4.8 is the latest version