[10:57:32] How do I add canonical tags to all commons images on my site? [11:01:57] How do I add canonical tags to all commons images on my site? [11:04:36] . [12:43:29] duesen: Ping regarding stable interface policy. Would you be able to look over my email before our meeting today? [13:27:26] Hrm. Whilst developing an extension, I'm getting errors when running update.php with a ParserOptionsRegister hook subscribed - it says that only one argument was passed rather than the three expected. Any ideas? [13:28:39] Have you got a $user and a $forOptions parameter on your handler function? [13:29:32] Reedy: I seem to spend most of my life bugging you at the moment, sorry :p The handler function for the hook has defaults, inCacheKey and lazyLoad per https://www.mediawiki.org/wiki/Manual:Hooks/ParserOptionsRegister [13:29:51] * Naypta imagines this is another case of me being immensely thick and not seeing something obvious [13:30:12] No, not you [13:30:27] I didn't look I'd found the right result in hooks.txt for ParserOptionsRegister [13:30:53] Have you got the actual error message? [13:31:03] It's weird, it's working fine on my local test MW install, but when running update.php I get the error [13:31:06] sure, lemme pastebin it [13:31:35] https://dpaste.org/Fc1E [13:32:46] Line 134 is [13:32:47] Hooks::run( 'LoadExtensionSchemaUpdates', [ $this ] ); [13:33:03] Have you wired up the hook to the wrong handler? [13:33:16] Cause the error message looks like you've basically set [13:33:25] "LoadExtensionSchemaUpdates": "CatTalkHooks::onParserOptionsRegister" [13:33:36] ... [13:33:39] Cause LoadExtensionSchemaUpdates dos only pass one parameter [13:33:46] God I'm an idiot [13:34:06] Looking at https://github.com/wikimedia/mediawiki/blob/master/includes/Hooks.php, it doesn't seem like line 174 is that though [13:34:13] 174 is the last } there [13:34:26] Note that is master [13:34:27] (that did solve the issue though... I need to learn to be less stupid, told you so) [13:34:42] https://github.com/wikimedia/mediawiki/blob/REL1_34/includes/Hooks.php#L174 [13:34:49] ahh has that been significantly refactored since 1.34 [13:35:00] gotcha [13:35:21] Especially very recently in 1.35, yeah [13:35:24] thanks for bearing with my knuckleheadedness Reedy :) [13:36:25] It's when you start asking the same question repeatedly for very similar but not exactly the same situations that I might start getting annoyed ;) [13:37:33] it's always the stupidly easy stuff I somehow manage to consistently fuck up :p [15:00:30] Is there a reason why ContentAlterParserOutput isn't linked to from https://www.mediawiki.org/wiki/Manual:Hooks? Happy to add it myself, but wanted to check if it was deliberately left out of the documentation [15:00:45] Looks like the underlying page for it exists, it's just not linked to on the index page https://www.mediawiki.org/wiki/Manual:Hooks/ContentAlterParserOutput [15:01:41] Nemo_bis: do you perchance know if it is safe to use the same ElasticSearch instance for multiple wikis? [15:07:49] Remilia: I use the same instance for 2 wikis and there's no problem [15:08:02] Each wiki has a different index [15:08:33] Vulpix: thyank you [15:08:35] thank* [15:08:50] $wgDBName but you can override it [15:09:26] Vulpix: I installed it a few days ago and it floored me with the search performance boost (and more importantly actual context instead of template gibberish in the results) [15:29:23] Hi. Does anyone have experience with the Lockdown extension? I want to block users from creating pages in a specific category, but it's rather overwhelming [15:33:58] Marekatt: what if a user creates a page on a different category, and then changes the category to the forbidden one? Does it count as "created under X category"? [15:36:31] Vulpix: Hmm, yes I would prefer if they couldn't do that either. I don't expect any sinister attempts, but want to keep track of what's being added to a few specific categories because they have complicated background tables and updating [15:37:15] And from experience I know users aren't going to read instructions [15:39:33] Marekatt: I'm nearly certain that Lockdown (nor any other extension that exists) can forbid people from adding certain categories into pages [15:40:07] I don't know if Lockdown can do that. I'd rather use AbuseFilter for that purpose, with a rule that looks if the new text wikitext contains the category code but the old wikitext doesn't [15:41:35] that's super easy to work around, but will stop the "user didn't read instructions" case at least (won't stop users intentionally trying to add it by any means possible) [15:43:00] e.g. [[Category:{{{dummy|Forbidden category}}}]] [15:43:11] Okay, that sounds good. I just want them to get a message saying they can't create the page, I trust them not to try to violate it [15:43:34] That sounds good for my purposes [15:45:16] Do you know if I can set up custom messages for when they get blocked from saving their edits? [15:45:38] yes, AbuseFilter lets you specify a custom message [15:45:50] Very good. Thanks guys! [16:57:46] Is a LinksUpdate supposed to be run on every purge of a page, or is it only where the page has a new revision that the LinksUpdate runs? [18:06:48] I have an extension repository on Gerrit (https://gerrit.wikimedia.org/r/admin/projects/mediawiki/extensions/Expressions), but the extension does not yet show up on Special:ExtensionDistributor. It this just a case of waiting a little, or are there additional steps I have to do to get it on there? Thanks! [18:07:56] Yeah, it's not immediate [18:08:27] Alright, then I'll just wait. Thanks [18:08:52] I'm not 100% sure... But the list of extensions is cached for 30 minutes [18:09:00] And the tarballs may only be built overnight [18:10:55] Certainly, if it's not there in 24H, come back and we can poke at it further [18:11:18] Will do, thank you! [18:32:42] It's already up :) [18:33:00] Sweet [18:33:05] Impatient ;p [18:46:39] Heh :P [18:57:33] Guys, how do I add google tag manager tag in timeless skin? [19:03:39] ;j brasil [19:21:15] does anyone know if you're supposed to do anything to tell MW that a LinksUpdate needs to be run when a ParserOutput's content is saved? I'm adding a category in a ContentAlterParserOutput hook, and whilst it adds to the bottom of the page, it doesn't update the categorylinks table unless I manually go into the wikitext and add a different category - at which point the categorylinks update [19:21:37] I presume something is detecting the addition of a category in the wikitext, but I've spent the last three hours trying to find it to no avail :'( going round in circles with DerivedPageDataUpdater and Parser [19:28:02] Naypta: Is your wiki actually processing job queue jobs [19:28:50] Reedy: that's the weird thing - I've tried it with $wgJobRunRate set to 0, and the same behaviour occurs even when manually running the jobs maintenance script [19:29:12] but the interesting thing is, when I try adding a category to the wikitext manually, it still doesn't need me to run the maintenance script, even with $wgJobRunRate at 0 [19:29:41] that updates fine, and in neither case is there a LinksUpdate job that comes up when I ran the jobs manually [19:50:19] Some changes are done instantly if the change doesn't affect a lot of pages [19:51:41] Vulpix: yeah, that makes some sense, but it sadly doesn't help with the overarching issue of LinksUpdate not triggering with the manual category add for some reason