[00:23:09] Why doesn't the Userinfo api action show up in Special:ApiSandbox? I'm testing on mediawiki.org and I'm signed in [00:24:18] himmalerin : where are you looking for it? [00:24:55] the "action" dropdown of https://www.mediawiki.org/wiki/Special:ApiSandbox [00:25:05] it's not an action [00:25:33] *oh* [00:25:41] yeah, that'd explain it [00:25:45] action=query [00:25:47] meta=userinfo [00:25:48] thanks lmao [00:25:51] https://www.mediawiki.org/wiki/Special:ApiSandbox#action=query&format=json&meta=userinfo [16:29:31] DannyS712: first time doing anything like this, did I do anything stupid? https://gerrit.wikimedia.org/r/#/c/607073/ [16:30:37] Changing parameter orders is always awkward [16:30:44] And then attempting to reshuffle them just feels wrong [16:32:07] yep, but how else can you make $user required? [16:32:47] You've also mangled the defaults [16:32:57] The safer way is to have a new method [16:33:20] but naming is hard [16:33:43] also the defaults are intentionally like that to keep old uses relying on them working [16:34:09] It doesn't match the phpdoc then [16:34:12] But it's just confusing [16:34:53] yeah, new method is always easier - doEditContent2 would be fine - not very original, but we have LocalFile::recordUpload, ::recordUpload2, and ::recordUpload3 [16:35:29] Or does it need the do prefix? [16:50:56] better now? [16:55:33] You shouldn't need to duplicate all the code [16:55:51] oh, you haven't [16:56:20] phpcs will complain though [18:01:47] https://phabricator.wikimedia.org/T185664 - anyone who's familiar with the code stewardship process, any idea how long (weeks, some months, many months, years) is left on this process? [18:07:40] Is there any way to scan the code base and find everything that was deprecated or removed in a new version? Does phpcs with mw package does something like that? [18:11:04] it should be in the release notes [18:11:29] The SNR of release notes is hardly useful though [18:11:37] And it's very much a manual process [18:14:43] DannyS712: yes, this is what I'm going thru, but would be very very handy if there was an automated way :) [18:15:25] Back to the manual process then o/ [18:16:41] A static analysis tool that looks for @deprecated probably will work [18:55:01] Hey guys I read "Structured Discussions is no longer in feature development, and new deployments have been suspended." Is there an alternative or will the new version of mediawiki 1.35+ has a build in solution? [18:56:01] hard question [18:56:31] you can still use the software as it is still deployed on a WMF wiki (so at a minimum it shouldn't break) [18:56:53] WMF is currently working on making a system to support current talk page use [18:57:20] ok [18:57:33] you can follow that at https://phabricator.wikimedia.org/tag/discussiontools/ [18:57:49] thank you [18:58:08] I don't know if that will be in the tarball or how far along it will be by the time 1.35 is pencils down [18:58:37] but it's usable in a beta sense on a few WMF wikis [19:47:26] Reedy: hia, i'm still struggling with avoiding a hard depencency on EventStreamConfig in the EventBus extension. I'm not sure how to avoid it since we required strict type declarations for method parameters now [19:47:36] e.g. here [19:47:36] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventBus/+/594505/9/includes/EventBusFactory.php#85 [19:48:02] If the EventStreamConfig class is not loaded, the StreamConfigs class will be undefined