[13:24:40] <AbsyAmr>	 Hi all, I need help in OOUI, is there a documentation for the DateTimeInputWidget?! and if not,I need to more about its parameters (configs), especially if there are configs corresponding to "mintime" and "maxtime".
[13:28:49] <AbsyAmr>	 I need also a reference about the date (and time) Format in the OOUI.
[13:29:29] <Reedy>	 https://doc.wikimedia.org/oojs-ui/master/js/
[13:29:32] <Reedy>	 https://doc.wikimedia.org/oojs-ui/master/php/
[13:40:41] <AbsyAmr>	 Hi Reedy, I have already explored them, but I didn't find a documentation for the DateTimeInputWidget, there is one for DateInputWidget, but not the DateTimeInputWidget. Also I cannot find a refernce for the date format.
[13:48:07] <Reedy>	 Well, you didn't say that in your question
[13:48:15] <Reedy>	 So it's hard to know if/where you have or haven't looked
[13:49:23] <Reedy>	 https://doc.wikimedia.org/mediawiki-core/master/php/classMediaWiki_1_1Widget_1_1DateTimeInputWidget.html
[13:49:51] <Reedy>	 https://www.php.net/manual/en/class.datetime.php
[13:52:11] <AbsyAmr>	 Then, it is using the same date format as it is in php, right?!
[13:53:04] <AbsyAmr>	 I think it is called ISO8601 format, isn't it?
[13:55:01] <Reedy>	 PHP will take many different date formats, it generally doesn't care much
[13:57:43] <AbsyAmr>	 But I have used the same format in PageForms and it didn't work, "d" instead of "D" for the day of month, and "y" instead of "YY" for the year, for example. But when I used this format it worked, but also I didn't find a reference for it, so I had to try it myself until I found out some of the formats, but not all of them.
[13:58:38] <AbsyAmr>	 I mean the format mentioned here https://www.mediawiki.org/wiki/Extension:Page_Forms/Input_types/Datepicker#Parameters
[14:01:57] <Reedy>	 Sure. But they're using their own component
[14:03:51] <AbsyAmr>	 I meant that I used the format that is mentioned in PageForms. I used it in the DateInputWidget, and it didn't work.
[14:04:21] <Reedy>	 Why would it?
[14:04:34] <Reedy>	 PageForms is making their own implementation of a date time picker
[14:04:55] <Reedy>	 It has no relation to the one in MW core
[14:07:52] <AbsyAmr>	 I know, but now I am a Google Summer of Code Student, working on the project "Remove jQuery UI from PageForms", and I am using the OOUI DateInputWidget and the DateTimeInputWidget from the OOUI. And when I worked on the parameter "inputFormat", with the format in mentioned in PageForms, it didn't work and I had to use some particular format. So I need a reference to get the whole format.
[14:28:09] <Ostrzyciel>	 AbsyAmr: (a fellow GSoC student here, hi! :) ) OOUI has rather uh, how to put it... "lacking" documentation, especially when it comes to these configs; for me in the past the most reliable way was just reading OOUI's source code and how is this widget used in extensions or other modules
[14:29:10] <Ostrzyciel>	 AbsyAmr: it looks like one of the few uses for this widget is UploadWizard (see: https://codesearch.wmflabs.org/things/?q=dateInputWidget&i=nope&files=&repos= ), so it may be worth taking a look there
[14:29:43] <Ostrzyciel>	 AbsyAmr: also, I have fingers crossed about your project, I would be really glad if PageForms had bettter UI :)
[14:44:57] <AbsyAmr>	 Ostrzyciel: I was thinking of the idea of reading the source code, but I didn't think it was the best idea. Anyway, I have explored the link you sent, I didn't get deep into it yet, but I will. And I will let you know if I got stuck. Thanks in Advance.
[14:48:25] <Ostrzyciel>	 AbsyAmr: np :) I wish I could recommend you a better source, but I'm afraid there's none
[14:49:06] <Reedy>	 Reading the code, or just trying stuff is usually the best if there's no docs
[17:07:55] <Guest10>	 I've installed the Kartographer extension for Mediawiki, but it doesn't appear to display any icons. Do I need to install the Maki icon set separately?
[17:08:50] <Guest10>	 The mapframe, itself, works fine, the map displays, all additional information...just the icon is missing (shows a "broken image" icon in its place)
[17:16:46] <Reedy>	 Which icon?
[17:17:28] <Guest10>	 I'm using the Sna Francisco museum example on the Kartography page, copied and pasted directly, so the "museum" icon...However, I've also tried other icons in the Maki list, and none work...
[17:18:04] <Guest10>	 Perhaps I don't have it configured properly for where to find the icon files?
[17:19:35] <Reedy>	 https://www.mediawiki.org/w/index.php?title=Extension:Kartographer&action=edit&section=2
[17:19:41] <Reedy>	 You mean like "marker-symbol": "town-hall",?
[17:20:31] <Guest10>	 Yups
[17:31:35] <Reedy>	 What do you have $wgKartographerUseMarkerStyle set to?
[17:35:05] <Guest10>	 I've tried with it set to both true and false, with the same results.
[17:39:32] <Guest10>	 (The map also disappears if I zoom in or out, but that's likely another problem...)
[17:42:56] <Guest10>	 (Looks like I got the zoom to work to a certain extent...)
[18:19:47] <ottomata>	 hiya James_F  yt?
[18:20:05] <ottomata>	 we are wondering if i did something wrong with the phan patch
[18:20:10] <ottomata>	 since https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventBus/+/594505 is failing
[18:20:30] <ottomata>	 this was the phan_dependencies change
[18:20:31] <ottomata>	 https://gerrit.wikimedia.org/r/c/integration/config/+/601384
[18:23:37] <Reedy>	 ottomata: you didn't rtfm :)
[18:23:38] <Reedy>	 ># Note! This list is not used by Phan. Scroll down farther for that list.
[18:24:12] <Reedy>	 or, you're linking the wrong change ;)
[18:25:43] <ottomata>	 huh weird Reedy  i was
[18:25:47] <ottomata>	 i was going by my commit message
[18:25:51] <ottomata>	 but i mixed them up?
[18:25:52] <Reedy>	 https://github.com/wikimedia/integration-config/commit/55d291f5fe4dcecd1ac0b273395a20133220edd8 was the phan change
[18:25:53] <ottomata>	 dunno.
[18:25:54] <ottomata>	 anyeay
[18:25:54] <ottomata>	 https://gerrit.wikimedia.org/r/c/integration/config/+/601381/1/zuul/parameter_functions.py
[18:25:55] <ottomata>	 yeah
[18:26:38] <ottomata>	 ya Reedy  is that the right thing to do?  i'm trying to figure out how to make EventStreamConfig an optional dependency
[18:26:39] <Reedy>	 14:57:53   <file name="includes/EventBusFactory.php">
[18:26:39] <Reedy>	 14:57:53     <error line="180" severity="error" message="syntax error, unexpected ')'" source="PhanSyntaxError"/>
[18:26:39] <Reedy>	 14:57:53   </file>
[18:26:42] <ottomata>	 extension.json does not have it
[18:26:45] <ottomata>	 ...
[18:27:15] <ottomata>	 ok that must be about a recent change i made
[18:27:16] <ottomata>	 will fix
[18:27:17] <ottomata>	 Reedy: 
[18:27:24] <ottomata>	 this is the errored one
[18:27:28] <ottomata>	 https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/59434/console
[18:27:39] <ottomata>	 streamConfigs has undeclared type \Mediawiki\Extension\EventStreamConfig\StreamConfigs" source="PhanUndeclaredTypeProperty"/>
[18:28:14] <Reedy>	 I think you'll need to make a change to the .phan/config.php
[18:28:36] <Reedy>	 like CA does
[18:28:36] <Reedy>	 https://github.com/wikimedia/mediawiki-extensions-CentralAuth/blob/master/.phan/config.php
[18:29:05] <ottomata>	 huh ok
[18:29:17] <Reedy>	 the CI change just makes it there in the "install" used for the tests
[18:29:24] <Reedy>	 phan needs to know it needs to use it
[18:30:09] <ottomata>	 ok
[18:30:51] <Reedy>	 the two config are like "include this for reference" but "don't analyse it"
[18:31:48] <ottomata>	 ok, lets see if jenkins gets happier
[18:39:36] <Krinkle>	 Amir1: How does "ResourceLoaderJqueryMsgModuleMagicWords": "Magic", in Wikibase extension client wip json turn into [object(Wikibase\Client\Hooks\MagicWordHookHandler), "onResourceLoaderJqueryMsgModuleMagicWords"] ?
[18:39:50] <Krinkle>	 https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/07bc520d1c16747f3420dd8aabea1bfadf8888b1/extension-client-wip.json#76
[18:40:47] <Amir1>	 Krinkle: let me check
[18:41:12] <Amir1>	 https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/07bc520d1c16747f3420dd8aabea1bfadf8888b1/extension-client-wip.json#34 ?
[18:41:47] <Krinkle>	 Hm.. I've not seen this before
[18:41:49] <Krinkle>	 what does HookHandlers do?
[18:41:58] <Amir1>	 https://phabricator.wikimedia.org/T240307 (Registration) 
[18:42:05] <Amir1>	 the new hook handler and hook containers
[18:42:18] <Amir1>	 basically the class implements the interface
[18:42:30] <Krinkle>	 ah https://www.mediawiki.org/wiki/Manual:Hooks
[18:42:46] <Krinkle>	 it's to allow centarlising where you implement the interfaces
[18:42:47] <Krinkle>	 right
[18:42:55] <Krinkle>	 interesting
[18:42:59] <Amir1>	 https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/07bc520d1c16747f3420dd8aabea1bfadf8888b1/client/includes/Hooks/MagicWordHookHandler.php#23
[18:43:57] <Krinkle>	 thanks
[18:44:05] <Krinkle>	 I didn't know the interfaces were already in use 
[18:44:07] <Krinkle>	 cool
[18:44:15] <Krinkle>	 that answers my next question too
[18:44:15] <Krinkle>	 :)
[18:44:52] <Amir1>	 Yeah, We are moving to the new system. The plan is to move to extension.json registration for wikibase, we decided to do the hooks (most of them) while we are at it
[19:19:16] <ottomata>	 ya thanks Reedy  jenkins is happy now
[19:19:38] <Reedy>	 sweet :)
[20:49:06] <absor70>	 Hi peeps, I have a code convention question. If I have a very big condition with many comparisons, how should I break the lines? 
[20:50:16] <absor70>	 like so but potentially bigger if ( $foo || $bar || $baz && $foobar )
[20:50:46] <Reedy>	 Depends on how long the variable names/functions names are
[20:51:36] <absor70>	 not so big, but if its stays on the same line it goes way beyond the 80 column
[20:51:56] <Reedy>	 There's no right answer
[20:52:08] <Reedy>	 Most people would probably break at the logical operators
[20:52:29] <absor70>	 Cool, before or after, do you think?
[20:54:21] <Reedy>	 We don't seem to have ever actually codified it either way
[20:55:07] <Reedy>	 And we definitely have code with both :)
[20:55:46] <absor70>	 great, thanks!
[22:30:21] <Amir1>	 Krinkle: I will merge all once jenkins is green (It's green so far) 
[22:30:37] <Amir1>	 thanks!