[19:29:11] Hello I'm trying to use this: https://www.mediawiki.org/wiki/Extension:DrawioEditor / Everything works fine and it's loading but when I'm trying to save, it will load forever and never save. Any idea for what to look for? Maybe a permission issue? I'm using MediaWiki 1.35 on Ubuntu 20.04 [19:30:42] Permissions of what? :) [19:30:57] Well to write a file I guess? [19:31:14] Documentation says it would write into the default image directory, which is fine [19:35:17] And if you disable the extension, saving works fine? [19:35:49] The code doesn't do anything explicitly on save.. [19:37:11] It's not about saving a page, it's about saving the DRAW.IO object. Everything else works fine in MediaWiki! Sorry if I wasn't clear [19:37:36] Checked your browser console? [19:38:47] No I didn't, I'll do that right now! [19:40:33] Reedy ah yes, it returns a jQuery.Deferred exception: Can't find variable: error [19:41:14] I don't imagine too many people in here are familiar with that extension (I'm certainly not) [19:41:29] Best I can really advise is filing a bug under https://phabricator.wikimedia.org/project/view/4999/ and hoping the maintainer picks it up [19:43:51] Thanks ! [20:21:12] Been looking through documentation while doing some more extension upgrades; do special page extensions still need a MyExtension.php file? It seems like they're irrelevant now with extension.json calling the special page file directly [20:22:09] As a caveat, I'm working on an extension with hooks and I wonder if maybe I should just move the description info to the json file and leave in the hooks while ensuring it gets called at some point. [20:23:04] Just want to know if I'm overthinking it. Putting them in the SpecialMyExtension.php seems wrong somehow. I could be misguided on that though. [20:23:33] It's upto you [20:23:41] You can put the hooks in there if you want [20:23:51] Can also create a Hooks class to hold them [20:24:15] Could that class go in the SpecialMyExtension file? [20:24:49] Or maybe I just require_once() at the top of the file? [20:24:51] Putting multiple PHP classes into one PHP file is probably not advised [20:24:58] Yeah, that's what I thought [20:26:29] What are you actually trying to do? :P [20:26:32] But I could just use Autoload Classes in the extension.json, couldn't I? I'm still getting used to this new system; last time I developed extensions myself was several years ago [20:26:46] Yeah [20:26:59] Most of the PHP way of doing things has a mappable thing to extension.json [20:27:09] The only problem is you can't put actual php code into the extension.json [20:27:23] So where you may have had inline functions, they need putting somewhere else [20:27:43] Right [20:27:56] If your structure is right, you don't even need autoloadclasses, you can use PSR-4 autoloading [20:31:47] Good to know. That could come in handy later. Right now my objective is just to update this custom code to at least work with 1.35, but I definitely want to come back later and spend some serious time getting them up to standards [20:32:19] This one in particular is a pre-authentication provider [20:33:25] Moving that into extension.json should be easy [20:33:41] Yeah, I was just confused on how this new way worked [20:33:55] I think I've got it now though, thanks to you [20:34:13] The last time I worked seriously on MediaWiki was about 2015-2016 [20:34:23] So I'm definitely behind the times [23:50:24] Anyone seen this error before? https://pastebin.com/LMfBQMji I checked the vendor folders, redownloaded 1.35, checked the referencing file, even disabled extensions, but I still get that error. I notice the /(wiki path)/ve on call #7 of the trace, and I wonder if that has something to do with it. [23:54:13] Most problems like htis are from truncated filenames due to some extraction bugs [23:56:32] https://github.com/wikimedia/mediawiki-vendor/blob/6f4853398ce57a778dd78044cc84df6b7369af92/composer/autoload_classmap.php#L1160 [23:58:55] My autoload file looks good; it's got the correct code in there