[18:46:30] <Majavah>	 what's the current plan on 1.36 cut time?
[18:53:45] <Reedy>	 later
[18:53:47] <Reedy>	 :D
[18:55:58] <Majavah>	 I'm wondering what to do to https://phabricator.wikimedia.org/project/view/3473/ which is currently grouped by year
[19:01:02] <RhinosF1>	 Majavah: I think most plans are out of the window
[19:12:52] <Reedy>	 You can move 1.36 into 2021 if you want
[19:12:52] <Reedy>	 Obviously it's not coming out in 2020, but it should be out in 2020... I imagine it'll probably be branched in a couple of months, and released a couple of months after that
[19:13:43] <Majavah>	 "it's not coming out in 2020, but it should be out in 2020" you meant should be out in 2021?
[19:14:07] <Reedy>	 yeah
[19:14:48] <Majavah>	 I made a column for this year
[19:22:38] <abuluntu>	 Hi! Hope I have come to the right place... I have an issue at norwegian wikibooks. The categories within the includeonly markup are not categorized at all. Do you have an idea what could cause it?'=D
[19:24:56] <Reedy>	 Probably helpful to provive a link to soem examples ;)
[19:28:41] <abuluntu>	 Thanks! https://no.wikibooks.org/wiki/Mal:Mboks/doc
[19:31:58] <Majavah>	 that doc page only adds Kategori:Metamaler which https://no.wikibooks.org/wiki/Mal:Mboks is in?
[19:35:44] <abuluntu>	 Thats the issue. Mboks doesn't show up at all in Kategori:Metamaler
[19:39:44] <Majavah>	 it does for me https://phabricator.wikimedia.org/F34005163
[19:41:40] <abuluntu>	 Ok... cache possibly?
[19:42:26] <abuluntu>	 Its there now... bother! Thanks for your patience
[19:42:52] <Majavah>	 probably, category changes from from editing templates go thru the job queue afaik, which would cause them to be somewhat delayed
[19:45:23] <abuluntu>	 Thanks anyway!!
[19:55:37] <RhinosF1>	 Why do links like https://en.wikipedia.org/w/index.php?diff=ggh work?
[19:55:48] <RhinosF1>	 Surely using letters as the diff should fail
[19:56:09] <RhinosF1>	 Any random set of letters any length long seem to get the same page
[19:56:12] <RhinosF1>	 Diff
[19:59:01] <Majavah>	 RhinosF1: https://github.com/wikimedia/mediawiki/blob/master/includes/MediaWiki.php#L114
[19:59:19] <Majavah>	 getInt() will return 0 if it's not an integer
[19:59:55] <Majavah>	 0 is falsy, meaning that it does not try to look for a revision with id 0
[20:00:17] <RhinosF1>	 What is it looking for
[20:00:18] <Majavah>	 so it falls back into the main page because that's the default page to view
[20:00:52] <RhinosF1>	 Weird
[20:01:16] <RhinosF1>	 So it's the latest revision of the main page that a non interger returns
[20:01:22] <RhinosF1>	 Surely that should just fail
[20:01:24] <Majavah>	 i'm just looking for where it decides to show the diff instead of the page contents
[20:02:10] <RhinosF1>	 I wonder if Special:Diff/0 is ever used to get the main page's latest edit
[20:02:53] <Majavah>	 ah, in https://github.com/wikimedia/mediawiki/blob/master/includes/page/Article.php#L525 it decides that since that url param is present, it should show a diff
[20:03:42] <RhinosF1>	 For me, any non interger provided to that should just die gracefully
[20:04:19] <Majavah>	 and https://github.com/wikimedia/mediawiki/blob/master/includes/diff/DifferenceEngine.php#L70 causes it to show the latest diff
[20:04:30] <RhinosF1>	 Entering X into https://en.wikipedia.org/wiki/Special:Diff errors and 0 just does nothing
[20:04:37] <Majavah>	 but yes, falling back to zero when it's a bunch of letters is weird
[20:05:00] <RhinosF1>	 Your explanation is fine
[20:05:32] <RhinosF1>	 I'm just not sure it doing that is expected
[20:06:14] <Majavah>	 SpecialDiff just uses form validation to check if that is an int before redirecting
[20:06:29] <RhinosF1>	 0 doesn't redirect fwiw
[20:06:33] <RhinosF1>	 It does nothing