[02:30:34] (03PS1) 10Aude: re-add $wgWBClientSettings["siteGlobalID"] = "enwiki" for travis setup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124513 [02:36:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124513 (owner: 10Aude) [02:39:05] (03PS4) 10Aude: Add / allow injecting experimental mode param in LanguageFallbackChainFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119502 [02:39:17] (03CR) 10jenkins-bot: [V: 04-1] Add / allow injecting experimental mode param in LanguageFallbackChainFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119502 (owner: 10Aude) [02:39:32] (03CR) 10Aude: Add / allow injecting experimental mode param in LanguageFallbackChainFactory (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119502 (owner: 10Aude) [02:44:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119502 (owner: 10Aude) [02:55:00] (03CR) 10Aude: "We don't share settings between client and repo. They are defined separately." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 (owner: 10Bene) [02:55:45] (03PS5) 10Aude: Add / allow injecting experimental mode param in LanguageFallbackChainFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119502 [03:00:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119502 (owner: 10Aude) [03:30:51] (03CR) 10Aude: [C: 04-1] "see comments" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123449 (owner: 10Bene) [03:34:19] (03PS6) 10Aude: Add / allow injecting experimental mode param in LanguageFallbackChainFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119502 [03:39:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119502 (owner: 10Aude) [05:34:58] (03PS1) 10Aude: Allow populate sites table to work without wikibase enabled [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/124517 [05:35:25] (03CR) 10Aude: "needed for populating sites table on wikiquote" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/124517 (owner: 10Aude) [05:40:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/124517 (owner: 10Aude) [05:44:56] (03PS1) 10Aude: Show DispatchStats touched time according to timezone preference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124518 [05:50:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124518 (owner: 10Aude) [07:54:47] (03PS6) 10Bene: Support getting single sitelinks with ClientSiteLinkLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123449 [07:58:30] (03PS5) 10Bene: Add documentation or badgeItems setting and fix the code accordingly [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 [08:01:52] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123449 (owner: 10Bene) [08:05:15] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 (owner: 10Bene) [08:09:49] (03PS7) 10Bene: Support getting single sitelinks with ClientSiteLinkLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123449 [08:14:53] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123449 (owner: 10Bene) [08:15:14] (03PS6) 10Bene: Add documentation or badgeItems setting and fix the code accordingly [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 [08:20:04] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 (owner: 10Bene) [08:34:23] (03PS3) 10Henning Snater: Adjust statementview's edit toolbar definition to capture claimviews [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123563 [08:39:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123563 (owner: 10Henning Snater) [08:47:21] (03CR) 10Bene: "@Aude: Is this then a +1 from you?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 (owner: 10Bene) [08:49:23] (03CR) 10Aude: "@bene still need to review the other parts of the patch and probably worth discussion with thiemo before +1 or +2" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 (owner: 10Bene) [09:00:31] [13WikibaseDataModel] 15thiemowmde comment on pull request #37 144a391b0: Hm, why is "Label" and "Description" singular but "Aliases" is plural? Wouldn't it be better if this is consistent? Should I create a report for this so it can be changed in a follow-up? 02http://git.io/RR9FtA [09:03:43] [13WikibaseDataModel] 15thiemowmde comment on pull request #37 144a391b0: I think the constructor of LabelList should do this.... 02http://git.io/7d5NGw [09:18:40] addshore: you're so cool, thanks. :-) https://gerrit.wikimedia.org/r/#/c/123106/1 [09:19:05] ;p [09:19:22] Thiemo_WMDE: would be great if you could make a style change that fixes https://gerrit.wikimedia.org/r/#/c/123106/1/includes/installer/WebInstallerPage.php [09:20:39] addshore: sure. [09:27:28] (03CR) 10Addshore: [C: 032] Show DispatchStats touched time according to timezone preference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124518 (owner: 10Aude) [09:28:55] (03CR) 10Addshore: [C: 04-1] "I feel like we should add a comment before the two includes you have added saying why they are needed." [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/124517 (owner: 10Aude) [09:29:18] awww [09:29:54] :> [09:30:04] it's for the branch only [09:30:26] ideally we move this stuff to core but then think maybe folks won't like the script [09:30:42] (03CR) 10Addshore: [C: 032] Add / allow injecting experimental mode param in LanguageFallbackChainFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119502 (owner: 10Aude) [09:30:43] and aren't overly enthusiastic about the sites table [09:30:59] suppose i could try :p [09:42:04] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/d5ce998 : aude The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/22513536 [09:44:59] addshore: daily? [09:46:42] * aude wonders what hat today? [09:50:41] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/7888431 : Addshore The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/22513846 [10:00:22] (03PS1) 10WikidataBuilder: New Wikidata Build - 08/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/124569 [10:00:42] oh my! sorry totally missed what time is was Tobi_WMDE [10:00:53] will send a mail :) [10:06:27] addshore: with a hat :) [10:06:30] or cat [10:09:02] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/124569 (owner: 10WikidataBuilder) [10:13:02] (03CR) 10Addshore: [C: 032] "Both jenkins say yes, wooo!" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/124569 (owner: 10WikidataBuilder) [10:13:24] :) [10:23:00] aude: ping :) [10:24:13] hi [10:31:55] aude: do you know what's going wrong here? https://gerrit.wikimedia.org/r/#/c/123449/ [10:32:21] I think Title::getPrefixedText should work for our purposees [10:35:56] it should [10:36:06] can't look at the moment [10:37:46] benestar, aude: you are using a SiteLinkLookup. That relies on the item_per_site table in the repo. If you test client code standalone, that table doesn't exist, since there is no repo. [10:38:12] how that table should be populated for tests is also unclear. [10:38:21] DanielK_WMDE: only tests in non-main namespace don't work [10:38:31] (since it's not part of the mock database layer for the client, sicne it doesn't belong to the client) [10:38:44] and we actually use the mock database [10:38:58] benestar: that's odd, I would expect this to not work at all. actually, it would e4xpect this to trigger a database error, since the table is missing [10:39:09] are you somehow injecting a fake SiteLinkLookup? [10:39:26] can you reproduce the problem locally? [10:40:06] DanielK_WMDE: we inject a MockRepo as sitelinklookup [10:41:57] benestar: ok, maybe that doesn#t handle the titles right? maybe it's a problem with "_" vs " " in the mock? [10:41:59] something like that [10:42:53] maybe, but I think if we don't use underscores, they may not cause any problems at all [10:51:10] aude: hi, when wikiquote gets links exactly? [11:13:15] (03CR) 10Tobias Gritschacher: [C: 032] Apply claimview instead of statementview to property page output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123562 (owner: 10Henning Snater) [11:13:19] (03CR) 10Tobias Gritschacher: [C: 032] Adjust statementview's edit toolbar definition to capture claimviews [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123563 (owner: 10Henning Snater) [11:13:36] (03Merged) 10jenkins-bot: Apply claimview instead of statementview to property page output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123562 (owner: 10Henning Snater) [11:13:38] (03Merged) 10jenkins-bot: Adjust statementview's edit toolbar definition to capture claimviews [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123563 (owner: 10Henning Snater) [11:21:47] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/e0e812d : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/22519417 [11:23:34] (03CR) 10Tobias Gritschacher: [C: 032] re-add $wgWBClientSettings["siteGlobalID"] = "enwiki" for travis setup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124513 (owner: 10Aude) [11:23:58] (03Merged) 10jenkins-bot: re-add $wgWBClientSettings["siteGlobalID"] = "enwiki" for travis setup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124513 (owner: 10Aude) [11:26:27] (03CR) 10Tobias Gritschacher: [C: 032] Add clearfix css for edit link in Vector skin [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124358 (owner: 10Aude) [11:26:53] (03Merged) 10jenkins-bot: Add clearfix css for edit link in Vector skin [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124358 (owner: 10Aude) [11:28:17] [13WikibaseQuery] 15adrianlang 04force-pushed 06htmlForm from 14ea7c7e7 to 146069ea4: 02http://git.io/eLeGRA [11:28:17] 13WikibaseQuery/06htmlForm 146069ea4 15Adrian Lang: Rewrite SimpleQuery special page's search form using HTMLForm [11:29:21] [13WikibaseQuery] 15adrianlang comment on pull request #8 146069ea4: Addressed, and thanks for the link. The `FauxRequest` might qualify as fake, though. 02http://git.io/tQbHbg [11:29:59] Adrian_WMDE: can we somehow configurate the Github bot to stay in here? [11:30:05] *configure [11:30:25] benestar: No clue, ask addshore [11:30:38] benestar: Adrian_WMDE nope [11:30:48] :/ [11:30:52] it's quite annoying [11:31:03] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/124569 (owner: 10WikidataBuilder) [11:31:10] its worse not noticing what happens on github though ;p [11:31:40] benestar: you can hide the "join" / "left" messages [11:31:52] I never see them [11:31:56] but I wanna see who is joining or leaving [11:31:59] ;) [11:32:18] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/0d739a5 : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/22520030 [11:32:21] benestar: so what's the problem then? [11:32:24] :) [11:32:39] you see when gh-bot joins and leaves [11:32:41] :P [11:32:42] ;) [11:46:27] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/1f15c82 : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/22520172 [11:54:04] (03PS2) 10Aude: Allow populate sites table to work without wikibase enabled [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/124517 [11:54:06] addshore: review! ^ [11:54:29] (03CR) 10Addshore: [C: 032] Allow populate sites table to work without wikibase enabled [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/124517 (owner: 10Aude) [11:54:40] thanks [11:54:59] shall see about submitting it to core... been meaning to do that for a long time [11:55:54] (03Merged) 10jenkins-bot: Allow populate sites table to work without wikibase enabled [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/124517 (owner: 10Aude) [11:59:17] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/124517 (owner: 10Aude) [12:35:30] Thiemo_WMDE: I guess for the query stuff for time we could always presume all years are leap years [12:35:36] that would solve all of our problems :P [12:36:52] addshore: Make the change on all calendars in the world then maybe :p [12:36:58] addshore: most, yes, i agree. but I'm afraid there will still be problems. [12:37:53] like querying "where from >= 2013-12-31T12:00:00 and to <= from + 24 hours". [12:38:57] ... you know, 2014-01-01T00:00:00 minus 2013-12-31T23:59:59 will not be 1 but 86401 instead. [12:42:24] the way we store time just sucks :P [12:45:44] [13WikibaseQuery] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/dEmm2w [12:45:44] 13WikibaseQuery/06master 14d2d4e5f 15Jeroen De Dauw: Merge pull request #8 from wmde/htmlForm... [12:47:25] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #37 144a391b0: One label per array element. Multiple aliases per array element. The naming is correct :) 02http://git.io/8ND2Vg [12:49:51] [13Time] 15addshore pushed 1 new commit to 06sinceEpoch: 02http://git.io/PfQppw [12:49:51] 13Time/06sinceEpoch 149ef5f12 15addshore: DNM Poke stuff DO NOT MERGE... [12:49:57] Thiemo_WMDE: if you fancy looking at it ^^ getting a bit interesting [12:51:02] addshore: i would assume that the leap years repeat every 2000 years and are exactly the same. [12:51:30] ... every 1000 years. thats better. [12:52:37] arg, no. 1000 is not dividable by 400. 10000 is. [12:52:56] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #37 144a391b0: I thought about doing this and actually wrote the signature of that method before removing it again. Now we have the new objects one should no longer really be using that format outside of serializers and deserializers. This code here essentially takes care of compat between the old internal storage and the new objects, allowing us to migrate away slowly. Once this is done, [12:53:13] every 4000 years :P [12:53:32] do module 10000, thats easier. [12:53:33] no every 2000 yes! [12:54:11] naturally one issue is 32bit php cates can handle years above 2038 so we cant just use these years in the date :P [12:54:19] hence im only using 1970 and 1972 [12:54:40] it must be dividable by 4, 100 and 400. thats all. [12:56:58] 2038-1970 is only 68. big problem. i don't think you cant make this compatible with broken 32 bit systems. [12:57:18] Thiemo_WMDE: hey, do you still think we need the same config style for badges on repo? [12:59:11] benestar: not 100% sure but yes, i think so. [12:59:30] did you read my and aude 's comments? [12:59:41] because why not? why have two different settings? [12:59:55] actually we are in a meeting right now. [13:00:01] about something else. [13:00:04] sorry. [13:01:10] k [13:01:44] Thiemo_WMDE: so please discuss this internally and tell me when you have a decision, ok? [13:08:22] (03PS2) 10Bene: DNM Insert HTML for badges in ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124391 [13:13:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124391 (owner: 10Bene) [13:18:19] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Wikidata] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/124348 (owner: 10Aude) [13:26:43] hey guys [13:27:06] stupid question: where can i find the wikidata api-doc [13:28:32] this one? http://www.wikidata.org/w/api.php [13:29:05] well that was what i found [13:29:09] is there nothing elser [13:29:21] no demo-sources at all? [13:29:26] * Amir1 is counting seconds for wikiquote integration [13:32:50] Nolispanmo: https://www.mediawiki.org/wiki/Extension:Wikibase/API [13:33:22] yepp that's what i found to [13:33:30] but... it's a mw extension [13:33:52] i wanted to test on a php, python, linux base [13:33:55] depends on what you need - https://www.wikidata.org/wiki/Wikidata:Creating_a_bot [13:35:35] or what you want to do [13:36:09] ah ok [13:36:47] if you want to read/write wikidata I would suggest pywikibot [13:36:50] i just want to play around with reading some data [13:40:52] ok thax for now ! [13:43:16] aude: is this a breaking change? https://github.com/DataValues/Common/pull/7 [13:43:57] aude: this is in now, so https://gerrit.wikimedia.org/r/#/c/121678/ should be rebased and unblocked [13:44:26] asking about the breaking change to know what in what version this should go [13:44:49] not breaking [13:44:51] it's not used [13:44:56] if it's not breaking we could release 0.2.2 whenever we want [13:45:04] ok [13:45:06] great [13:45:23] (03CR) 10Thiemo Mättig (WMDE): "Sorry, I don't think it makes sense to merge this without the code that uses this setting. Maybe it makes more sense to name it "badgeClas" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123447 (owner: 10Bene) [13:45:54] aude: could you then give the gerrit change a try and rebase? [13:47:16] [13Common] 15tobijat pushed 1 new commit to 06master: 02http://git.io/i_wnZA [13:47:16] 13Common/06master 14f907402 15Tobi Gritschacher: Update README.md [13:47:31] why? [13:47:40] [13Common] 15tobijat pushed 1 new commit to 06master: 02http://git.io/mO7jjw [13:47:40] 13Common/06master 141807a7e 15Tobi Gritschacher: Update Common.php [13:47:53] aude: because it has conflicts? [13:47:54] https://gerrit.wikimedia.org/r/#/c/121678/ [13:48:37] or don't we want to further work on that? [13:48:45] it's https://bugzilla.wikimedia.org/show_bug.cgi?id=62495 [13:48:53] (03PS1) 10Thiemo Mättig (WMDE): Remove troublesome fonts from font stack [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124598 [13:48:58] we do, but i don't htink i need to do that right now? [13:49:22] unless you want to review it [13:49:28] not sure. if you want to work on that alone, then not [13:49:54] it's just, nobody would look at it or would pick it up if it is stuck [13:50:04] ok [13:51:12] seems as https://bugzilla.wikimedia.org/show_bug.cgi?id=62495 became a tracking bug [13:51:17] odd to have it in the sprint [13:51:45] it has sub tasks [13:52:08] * aude stashes other stuff [13:52:12] so better take the subtasks in the sprint I thing [13:52:32] one is, the second is not [13:52:40] if I see correctly [13:52:42] if you want [13:54:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124598 (owner: 10Thiemo Mättig (WMDE)) [14:04:04] (03CR) 10Bene: "I actually think "displayBadges" is a quite good name for this setting because it only contains badges which should be displayed. So the e" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123447 (owner: 10Bene) [14:05:18] (03PS12) 10Aude: Use MismatchingDataValueTypeException for Snak formatting [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 [14:05:44] (03CR) 10jenkins-bot: [V: 04-1] Use MismatchingDataValueTypeException for Snak formatting [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [14:07:37] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [14:11:37] Tobi_WMDE: how do we get the data values component to update in wikibase? [14:12:28] it's 0.2.2 ? [14:13:21] can you press the button [14:14:18] (03PS13) 10Aude: Use MismatchingDataValueTypeException for Snak formatting [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 [14:15:13] aude: we should probably wait with the release as long as the wikibase changes has a WIP [14:15:26] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [14:15:37] how do i make my patch work with composer then? [14:15:55] (03PS14) 10Aude: Use MismatchingDataValueTypeException for Snak formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 [14:16:20] jenkins will never approve [14:16:47] aude: yeah that's true.. what is missing in that patch? [14:16:55] more tests [14:16:57] is it not ready for review yet? [14:17:04] it can be reviewed [14:17:47] aude: for you locally, you can always specify e.g. dev-master as version or just cd into the component and do a "git checkout master" [14:17:52] (03CR) 10Thiemo Mättig (WMDE): "> it only contains badges which should be displayed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123447 (owner: 10Bene) [14:17:59] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [14:18:02] no one will review if jenkins says no [14:19:32] (03PS15) 10Tobias Gritschacher: Use MismatchingDataValueTypeException for Snak formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [14:20:03] updated the commit message [14:20:41] aude: you could just require version dev-master for reviewing.. [14:20:49] would be ok I think [14:20:51] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [14:20:51] :/ [14:21:21] aude: if only tests are missing I think we can release also [14:23:03] (03PS16) 10Aude: Use MismatchingDataValueTypeException for Snak formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 [14:28:10] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [14:46:23] Thiemo_WMDE: sorry if I'm disturbing you. May I answer here in IRC because I think you did not understand me correctly. [14:47:21] (03Abandoned) 10Bene: Insert badges for language links on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene) [14:50:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (owner: 10Bene) [14:57:36] (03PS8) 10Bene: Support getting single sitelinks with ClientSiteLinkLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123449 [15:02:13] aude: I fixed the namespace bug [15:02:38] can you pls review https://gerrit.wikimedia.org/r/#/c/123449/ again and prob merge? [15:02:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123449 (owner: 10Bene) [15:05:17] Thiemo_WMDE: -2 https://gerrit.wikimedia.org/r/#/c/124598/1 not comic sans! [15:05:29] (03CR) 10Jeroen De Dauw: [C: 031] Remove troublesome fonts from font stack [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124598 (owner: 10Thiemo Mättig (WMDE)) [15:05:42] wuuut? [15:06:04] JeroenDeDauw: think you want https://gerrit.wikimedia.org/r/#/c/124316/ :p [15:06:26] Tobi_WMDE: I can haz review? https://github.com/wmde/WikibaseInternalSerialization/pull/25 [15:07:03] Thiemo_WMDE: have your comments been answefred sufficiently at https://github.com/wmde/WikibaseDataModel/pull/37 ? [15:07:31] http://comicneue.com/ and it's PD! [15:09:01] aude: approval [15:09:39] [13WikibaseDataModel] 15thiemowmde comment on pull request #37 144a391b0: An "aliases list" is a list of Alias objects. If it's a list of AliasGroup objects it should say that. 02http://git.io/ntAnxg [15:10:18] benestar: shall look [15:10:26] thx [15:10:42] Thiemo_WMDE: well, and AliasGroup can be described as "Aliases" ;p Will change it though - do you mind merging first? [15:10:44] benestar: I see a hardcoded "Q". ouch [15:11:06] :/ [15:11:10] [13WikibaseDataModel] 15thiemowmde comment on pull request #37 144a391b0: Sorry, not convinced. You are stuffing legacy stuff in Entity.php? 02http://git.io/cJpj1Q [15:11:23] Tobi_WMDE: copied a bit from MockRepositry :P [15:11:32] so it isn't my evil ;) [15:11:45] bad code nonetheless :/ [15:12:03] benestar: but now it's in production code and not in some test anymore [15:12:11] hehe, I see [15:12:23] easy to fix [15:12:25] [13WikibaseInternalSerialization] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/lPoDEA [15:12:25] 13WikibaseInternalSerialization/06master 14a5e0182 15thiemowmde: Merge pull request #25 from wmde/move... [15:13:52] (03PS9) 10Bene: Support getting single sitelinks with ClientSiteLinkLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123449 [15:13:55] aude: Tobi_WMDE here you go [15:14:21] [13WikibaseDataModel] 15thiemowmde comment on pull request #37 144a391b0: Oh, right. 02http://git.io/ivahrA [15:14:28] I am a bit surprised that the sitelinklookup actually returns a numeric id [15:14:41] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/oMcbJg [15:14:41] 13WikibaseDataModel/06master 143d45168 15thiemowmde: Merge pull request #37 from wmde/getFingerprint... [15:14:47] but that's not my thing atm [15:14:50] we want to change that [15:14:51] [13WikibaseDataModel] 15thiemowmde 04deleted 06getFingerprint at 144a391b0: 02http://git.io/6NnyCg [15:15:03] maybe JeroenDeDauw knows?! [15:15:39] benestar: this interface was created before we had the EntityId object, much less the ItemId one [15:15:39] errr, wb_terms we want to change and not sure status of wb_items_per_site [15:15:47] it should be updated to return an ItemId [15:15:59] +1 [15:16:09] JeroenDeDauw: ok, but for now I have to use ItemId::newFromNumber [15:16:14] arrr Thiemo_WMDE was quicker [15:16:16] which is really scary [15:16:18] :P [15:16:26] but don't do too much in your patch [15:16:30] benestar: no, using that method is fine [15:16:34] It's not even deprecated [15:16:39] :) [15:16:41] ok, that's great :) [15:16:44] We can remove that stuff later in one go [15:16:44] we know it's an item, at least [15:17:02] JeroenDeDauw: yes, one patch per feature as I've learned from Thiemo_WMDE :P [15:17:08] Tobi_WMDE: i needed the chocolate. ;-) [15:17:19] Thiemo_WMDE: seems legit [15:17:58] ok, aude, so finally this is ready? [15:18:28] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/3fBGww [15:18:28] 13WikibaseDataModel/06master 14522d149 15jeroendedauw: Update method name as per Thiemo_WMDE [15:18:44] JeroenDeDauw: "It's not even deprecated" but has a big CAUTION in its documentation ... :/ [15:18:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123449 (owner: 10Bene) [15:20:38] benestar: yes, you should typically not deal with numeric ids as it states [15:20:48] benestar: you are however getting one, so have to deal tih it [15:20:54] In which case this method is the way to go [15:24:26] [13WikibaseInternalSerialization] 15JeroenDeDauw opened pull request #26: Make use of new setFingerprint method in DataModel (06master...06fingerprint) 02http://git.io/4QTWEw [15:27:31] [travis-ci] wmde/WikibaseInternalSerialization/fingerprint/fad763c : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/22537048 [15:29:41] Tobi_WMDE: Thiemo_WMDE https://github.com/wmde/WikibaseInternalSerialization/pull/26 race race race :D [15:36:05] [travis-ci] wmde/WikibaseInternalSerialization/fingerprint/ea19eb6 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/22537367 [15:36:29] [13WikibaseDataModel] 15thiemowmde created 06entity-doc-cleanup (+1 new commit): 02http://git.io/aT1Ckw [15:36:29] 13WikibaseDataModel/06entity-doc-cleanup 14ab6bb74 15Thiemo Mättig: Inline documentation cleanup of Entity [15:36:41] So how about deprecating 17 methods in Entity? [15:37:11] Thiemo_WMDE: uhm [15:37:17] Thiemo_WMDE: I'm going to hit you now :D [15:37:31] Thiemo_WMDE: AHHHHHH! [15:37:39] sorry? [15:38:29] [13WikibaseDataModel] 15JeroenDeDauw created 06deprecateeee (+1 new commit): 02http://git.io/VUoh0A [15:38:29] 13WikibaseDataModel/06deprecateeee 144332bbe 15jeroendedauw: Deprecate old term related methods in Entity [15:42:00] [13WikibaseDataModel] 15thiemowmde 04deleted 06deprecateeee at 144332bbe: 02http://git.io/QMG1AQ [15:46:25] [travis-ci] wmde/WikibaseDataModel/entity-doc-cleanup/ab6bb74 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/22538232 [15:48:44] (03PS17) 10Aude: Use MismatchingDataValueTypeException for Snak formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 [15:50:36] [travis-ci] wmde/WikibaseDataModel/deprecateeee/4332bbe : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/22538389 [15:50:50] (03CR) 10Aude: "tests can use some more improvements but welcome review" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [15:53:56] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [15:57:19] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06entity-doc-cleanup from 14ab6bb74 to 145ed2f64: 02http://git.io/sIFMWQ [15:57:19] 13WikibaseDataModel/06entity-doc-cleanup 145ed2f64 15Thiemo Mättig: Inline documentation cleanup of Entity [16:01:17] (03PS18) 10Aude: Use MismatchingDataValueTypeException for Snak formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 [16:02:05] (03CR) 10Addshore: [C: 031] Remove troublesome fonts from font stack [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124598 (owner: 10Thiemo Mättig (WMDE)) [16:02:10] [13WikibaseDataModel] 15thiemowmde opened pull request #39: Inline documentation cleanup of Entity (06master...06entity-doc-cleanup) 02http://git.io/o9TplA [16:02:56] Thiemo_WMDE: these docs predate us finding out that we can use string[] rather than array btw ;p [16:03:25] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #39: Inline documentation cleanup of Entity (06master...06entity-doc-cleanup) 02http://git.io/o9TplA [16:03:28] good for me. ;) [16:03:31] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06entity-doc-cleanup at 145ed2f64: 02http://git.io/voY66Q [16:04:57] (03PS1) 10Henning Snater: Removed AutocompleteInterface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124619 [16:05:56] [13WikibaseDataModel] 15JeroenDeDauw created 06refref (+1 new commit): 02http://git.io/faxT5Q [16:05:56] 13WikibaseDataModel/06refref 14f62ac3a 15jeroendedauw: Add reference to reference [16:06:02] DanielK_WMDE: jimbo is hungry? [16:06:39] JeroenDeDauw: yes, please. [16:07:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [16:11:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124619 (owner: 10Henning Snater) [16:13:47] (03PS2) 10Thiemo Mättig (WMDE): Wrap usages of legacy numeric ids in LegacyIdInterpreter calls [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119302 [16:18:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119302 (owner: 10Thiemo Mättig (WMDE)) [16:20:15] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Support getting single sitelinks with ClientSiteLinkLookup (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123449 (owner: 10Bene) [16:22:16] Thiemo_WMDE: please ask JeroenDeDauw why this is ok here [16:23:35] [17:20] JeroenDeDauw benestar: yes, you should typically not deal with numeric ids as it states [16:23:36] [17:20] JeroenDeDauw benestar: you are however getting one, so have to deal tih it [16:23:38] [17:20] JeroenDeDauw In which case this method is the way to go [16:23:40] Thiemo_WMDE: --^ [16:25:51] (03CR) 10Bene: "@Thiemo: This was discussed with aude and Jeroen via IRC and is ok. The code was broken before for non-main namespace titles. To quote Jer" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123449 (owner: 10Bene) [16:26:33] benestar: i'm busy.... enabling wikibase for wikiquote [16:26:38] can look at patches after [16:26:41] benestar: yeah well now I looked at this again I am wondering why you are using a whole Title object there [16:26:53] aude: hehe, was just mentioning you [16:26:57] benestar: passing a string $prefixedTitleText is sufficient [16:27:13] JeroenDeDauw: do you think this would be cleaner? [16:27:27] benestar: it decreases dependencies [16:27:40] the thing that's not so nice about it is that you then have a random string primitive [16:28:28] JeroenDeDauw: that's what I wanted to avoid as it is actually always a title [16:28:53] however, if there are better arguemnts for a string we mgiht consider this [16:28:55] benestar: well, nvm this for now [16:29:12] more important stuff to tackle [16:29:44] (03CR) 10Jeroen De Dauw: [C: 031] Support getting single sitelinks with ClientSiteLinkLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123449 (owner: 10Bene) [16:30:59] DanielK_WMDE: why are you not getting mad at me deprecating 17 methods in Entity? [16:31:09] aude: want to quickly try the references-weirdness here? http://172.16.66.40/wikidata-repo/index.php/Q10578 [16:31:17] I see some glitches on test.wikidata but I cannot produce weirdness on current master [16:31:57] busy enabling wikibase on wikiquote! [16:32:14] aude: it's ok. the instance is always on [16:32:21] ok [16:32:22] I need to go [16:38:18] aude: hi do you have a time for wikiquote getting links from wikidata? [16:38:28] soon [16:38:36] have to populate sites table [16:38:41] and such [16:39:11] * hoo waves [16:39:33] it's going fine... wikiquote has sites table now [16:40:24] ok, if you need me, I'm around :=) [16:40:58] ok [16:41:42] have to deploy update to populate sites table script that allows it to be run before enabling wikibase [16:41:49] * aude sighs.... yet again  [16:42:05] ... :/ [16:42:52] suppose i'll submit patch for core for that [16:42:59] * aude expects it might not be popular [16:43:13] not everyone likes sites table in core [16:45:54] (03PS1) 10Aude: New build, with change to populateSitesTable for wikiquote [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/124633 [16:46:35] hmmm [16:46:42] aude: Yep, but we still should persuade that... [16:47:54] * aude not waiting for jenkins since i don't think jenkins covers this change really [16:48:09] exact change we used for wikisource [16:48:26] (03CR) 10Aude: [C: 032 V: 032] "used this for wikisource, need for wikiquote now" [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/124633 (owner: 10Aude) [16:48:33] it can run gate and submit job [16:52:16] (03Merged) 10jenkins-bot: New build, with change to populateSitesTable for wikiquote [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/124633 (owner: 10Aude) [16:52:45] should have done that earlier [16:54:31] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/124633 (owner: 10Aude) [17:01:43] Ooh, I like the auto-generated descriptions that the wikidata autolist (http://tools.wmflabs.org/wikidata-todo/autolist.html) does… [17:01:56] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #40: Add reference to reference (06master...06refref) 02http://git.io/DMRbBg [17:02:12] aude: Any update on the Wikiquote roll out? :) [17:02:59] (03CR) 10Thiemo Mättig (WMDE): "From what I see this is just reimplementing the exact same logic that's in SiteLinkTable::getEntityIdForSiteLink." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123449 (owner: 10Bene) [17:03:01] slow but coming :) [17:03:18] aude synchronized php-1.23wmf20/extensions/Wikidata 'Update Wikidata build, to allow populating sites table on wikiquote' [17:03:21] Perfect. rschen7754 ^ [17:03:50] :D [17:05:41] Lydia_WMDE, I have a question [17:05:52] yannf: hey [17:05:54] shoot [17:06:23] when will it be possible to manage inter-project links with WD? [17:06:53] i.e. WP <-> Commons <-> Wikisource [17:06:58] yannf: Tpt_ has worked on that. a first rollout started on fr wikisource [17:07:07] depending on how that goes we will expand [17:07:31] yannf: Yes, it has been rooled-out on fr.wikisource yesterday [17:07:32] (03CR) 10Bene: "However, this way we do not have to create a completely useless SiteLink object which makes the code more efficient." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123449 (owner: 10Bene) [17:07:34] 'coz now I add manually links [17:08:19] in fr.wp : {{Autres projets | wikisource = Auteur:Perceval Landon | wikisource titre = Perceval Landon | commons = Category:Perceval Landon | commons title = Perceval Landon }} [17:08:20] Tpt_: Me :p I asked Greg if he could add it to the current SWAT request I had [17:08:45] Thiemo_WMDE: you always have to contradict me, right? [17:09:00] benestar: I thought you did that yourself usually [17:09:00] JohnFLewis: Thanks :-) [17:09:16] JohnFLewis: ? [17:09:34] Tpt_, so the {{auteur}} temp, we need a field for WD id? [17:09:43] benestar: wasup? :) [17:09:51] yannf: In fr.wikisource? [17:09:55] yes [17:10:46] Lydia_WMDE: the badges code will be perfect measured against the lines of discussions I've had with Thiemo_WMDE ... [17:10:55] yannf: No need. it easy to retrive in Lua the id of the Wikidata item linked to the current page [17:10:59] benestar: i really feel sorry. it's not you. [17:11:20] benestar: heh. you don't need to fix this all yourself [17:11:26] if you don't want to that is fine [17:11:30] yannf: It's already done by the author template for links to Wikipedia and Commons (and hopefully later today for wikiquote) [17:11:40] Lydia_WMDE: but I actually want to get my patches merged... ;) [17:11:46] Tpt_, we need a link to WD in the left column, like in WP and Commons [17:12:32] yannf: There is already a link in the toolbar and I've written a piece of JS code that should add it to the "Other project" section too [17:13:07] ah ok [17:13:16] I needed to refresh the page [17:13:59] but then, the link to WP and Commons disappeared [17:14:11] https://fr.wikisource.org/wiki/Auteur:Perceval_Landon [17:15:09] in the left column [17:15:19] ok, there are in the temp [17:16:08] benestar: got it. give me a sec [17:16:45] Lydia_WMDE, actually, I see a problem with Commons, because in WD, we have entries for WP article + WP category [17:17:20] so the WP cat gets link to the Commons cat [17:17:24] in WD [17:17:48] but in the Commons cat, no link appears :( [17:18:43] Lydia_WMDE: what did you get? [17:19:23] benestar: that you want it merged. trying to figure out the remaining issues atm [17:19:45] yannf: Sorry, there was a little bug in the JS script. We just have to wait now... [17:20:01] ok thanks [17:20:33] yannf: I plan to deprectiate or even remove "wp" parameter of the Author template in favour of Wikidata [17:20:54] yannf: In order to don't have to update it "by hand" if the wp page is deleted/moved... [17:21:12] ok, it'd be good [17:22:17] and for Commons too? [17:23:13] yannf: Maybe. Commons is difficult because of Page vs Category problem [17:23:35] yes, what I said [17:23:47] yannf: And also, of course, for Wikiquote [17:25:42] Tpt_, in WD, there is a "Commons cat" parameter. Can we use that? [17:25:48] yes [17:26:05] yannf: Lua allows to do what we want with the data of the linked item [17:27:30] yannf: If you purge your cache, "Autre projets" section should work well [17:28:04] (03CR) 10Jeroen De Dauw: "As the docs of this class say, and as I have already mentioned when we last discussed this, it is not supposed to be used outside of DM. H" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119302 (owner: 10Thiemo Mättig (WMDE)) [17:28:08] ok, thanks [17:29:05] benestar: hey :) [17:29:06] so update [17:29:21] Tpt_, we should be able to add a link to Commons / WP / WQ with "Ajouter des liens" [17:29:22] Thiemo_WMDE will merge your patch [17:29:27] not possible now [17:29:48] the setting name is unclear and should be changed but that will be done in a later patch [17:30:04] if you want you can do this but Thiemo_WMDE can do it too [17:30:07] yannf: You should talk with Lydia_WMDE about it ;-) It's a Wikibase feature. [17:30:14] ok ;) [17:30:31] yannf: sorry - catching up on backlog in a minute [17:32:25] (03PS1) 10Bene: DNM Fix getItemIdForLink in SiteLinkLookup to return ItemId objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124647 [17:32:36] https://www.wikidata.org/w/index.php?title=Q6480652&diff=prev&oldid=119631505 [17:32:42] I started my bot [17:33:59] yannf: i am sorry i am not sure i understand what you want to do? [17:34:27] better links between projects [17:34:47] i.e. WP - Commons - WS mainly [17:34:52] yannf: you mean links from eg wikisource to wp? [17:35:04] I think there was already a patch for this issue [17:35:14] yes, and back, and to Commons [17:35:17] https://gerrit.wikimedia.org/r/#/c/111390/ [17:35:29] is that what you want? [17:35:39] -> would be extended to wikibase of course [17:35:54] now as tpt has shown, it works *from* WS [17:36:54] but I mainly want it *to* WS [17:37:11] from Commons and WP [17:37:12] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124647 (owner: 10Bene) [17:38:05] I think it would hugely increase WS referencement and therefore contributors [17:39:06] yannf: yes, I agree [17:39:12] how is it possible form WS ? [17:39:25] lol, https://gerrit.wikimedia.org/r/#/c/124647/ broke everything^^ [17:39:41] https://fr.wikisource.org/wiki/Auteur:Perceval_Landon [17:40:02] we have links in the template and in the left column [17:40:17] yannf: as i said more will depend on how this goes on wikisource [17:40:24] we can do this in the future [17:40:24] s/template/header [17:40:45] how far? [17:41:14] we will have to see how this goes [17:41:17] it was just deployed [17:41:45] wikipedia will take quite some time [17:41:51] i expect the other projects to go quicker [17:43:04] Lydia_WMDE: The "other project" sidebar works fine in Wikisource. I've haked it a bit to allows to add links using the previous way (with {{Interproject}} template). [17:43:52] (03PS1) 10Thiemo Mättig (WMDE): Rename option 'displayBadges' to 'siteLinkBadges' [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124650 [17:43:59] Tpt_: cool :) let's see how the community likes it. want to write a short email about it? then i can tweet for example "want this for your project too? get in touch" [17:44:21] and then we can see which other project to tackle next [17:45:01] (03CR) 10Thiemo Mättig (WMDE): [C: 032 V: 031] Insert css styles for badges on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123447 (owner: 10Bene) [17:45:14] Lydia_WMDE: Yes [17:45:21] :) [17:45:22] ok, thanks [17:45:24] (03Merged) 10jenkins-bot: Insert css styles for badges on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123447 (owner: 10Bene) [17:45:45] Lydia_WMDE: But I would like to wait 2/3 days in order to be sure that evrything works fine. [17:45:51] makes sense [17:46:11] Tpt_: would be good to have it ready for saturday's weekly summary [17:46:14] A sample of page without {{Interproject}} template call https://fr.wikisource.org/wiki/Daphnis_et_Chlo%C3%A9 [17:46:15] i think [17:46:26] Can someone give me a one or two sentence overview of why wikidata has its own Jenkins? [17:46:35] Lydia_WMDE: Ok. I'll try to write it Thursday. [17:46:58] perfect [17:48:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124650 (owner: 10Thiemo Mättig (WMDE)) [17:50:05] (03PS2) 10Bene: DNM Fix getItemIdForLink in SiteLinkLookup to return ItemId objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124647 [17:50:50] Krinkle: because wmf jenkins doesnt/didn't support composer [17:50:59] (03CR) 10Thiemo Mättig (WMDE): "Having a SiteLink object is not a problem. It doesn't do much. Introducing an other place that uses numeric IDs is a problem in my opinion" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123449 (owner: 10Bene) [17:51:07] we'd like to eventually move back, once composer works on wmf jenkins [17:51:17] aude: Production Jenkins slaves are not allowed to fetch and execute code from third party domains (e.g. npmjs.org or composer) [17:51:31] aude: However for several months now we have labs slaves for this very purpose [17:51:36] right [17:51:40] we have dozens of jobs set up that do npm-install all the time [17:51:43] live and working [17:51:45] we are aware and hashar is working on composer [17:51:47] Any other reasons? [17:51:50] OK [17:51:52] but not yet [17:51:55] there [17:52:00] no other reasons afaik [17:52:14] but we do run automatic selenium / cucumber tests on our daily builds [17:52:35] we would want that and maybe some other things i forget [17:55:05] (03CR) 10Bene: [C: 04-1] "I agree that displayBadges might be a very misleading name. However, siteLinkBadges also does not contain meaningful information as badges" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124650 (owner: 10Thiemo Mättig (WMDE)) [17:55:07] [13WikibaseDataModel] 15JeroenDeDauw created 06terminst (+1 new commit): 02http://git.io/FN2F4Q [17:55:07] 13WikibaseDataModel/06terminst 148c6285e 15jeroendedauw: Make Term non-abstract and add field type checks [17:55:15] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124647 (owner: 10Bene) [17:55:32] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #41: Make Term non-abstract and add field type checks (06master...06terminst) 02http://git.io/NKY-SQ [17:56:41] (03CR) 10Thiemo Mättig (WMDE): "Sure, no problem. I'm all ear." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124650 (owner: 10Thiemo Mättig (WMDE)) [18:00:22] [travis-ci] wmde/WikibaseDataModel/terminst/8c6285e : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/22547970 [18:01:52] (03PS3) 10Bene: DNM Fix getItemIdForLink in SiteLinkLookup to return ItemId objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124647 [18:02:54] Lydia_WMDE: The on-wiki update making Wikiquote phase I official - https://www.wikidata.org/w/index.php?title=Wikidata:Notability&diff=119635225&oldid=118289895 :p [18:02:57] Thiemo_WMDE: once the above patch works we do not have to dicuss the other patch anymore \o/ [18:03:11] JohnFLewis: :D [18:03:19] benestar: \o/ [18:03:37] i just hope that the bot goes okay [18:03:46] oh, it's live [18:03:49] go ahead with wikiquote! [18:03:58] however, it is a quite big and unsplittable patch which will make it hard to review -.- [18:04:20] but it will make JeroenDeDauw very happy :D [18:04:35] rschen7754: thx again for your poking and all [18:04:37] i think what we need to do next time is get all the smaller wikis on global bots [18:04:38] np [18:06:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124647 (owner: 10Bene) [18:06:43] * benestar_ kicks his internet in its ass [18:07:28] lol 4-3-2-1 failures ^^ [18:07:34] seems the bot has started... but we're not approved on en.wikquote :S [18:08:19] mmm, the import tool doesn't work for Wikiquote :( [18:09:04] Lydia_WMDE: you heroine! [18:09:12] lazowik: haha. why? [18:09:13] defending poor volunteer developers [18:09:14] :p [18:09:16] awww [18:11:58] benestar: visibleBadges ? [18:12:41] lazowik: makes me think of invisible badges... ^^ [18:12:58] lol [18:12:58] yeah [18:13:02] let's make a config [18:13:06] sitelinkbadges? [18:13:08] which badges *not* to show [18:13:33] Lydia_WMDE: that's what Thiemo_WMDE suggested [18:13:41] in the first place [18:13:50] ok :D [18:13:55] but you don't like it? [18:14:06] nah, benestar doesn'y [18:14:08] *t [18:14:18] ok [18:14:31] Lydia_WMDE: see my comment [18:14:54] k [18:15:07] https://www.youtube.com/watch?v=zKdxd718WXg [18:15:18] "oh, I am an invisible badge" [18:15:48] https://www.youtube.com/watch?v=hGlyFc79BUE [18:16:00] (03CR) 10Bartosz Dziewoński: [C: 032] Remove troublesome fonts from font stack [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124598 (owner: 10Thiemo Mättig (WMDE)) [18:16:02] (03PS4) 10Bene: DNM Fix getItemIdForLink in SiteLinkLookup to return ItemId objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124647 [18:16:12] [13WikibaseDataModel] 15JeroenDeDauw created 06setlabel (+1 new commit): 02http://git.io/4ieYKQ [18:16:12] 13WikibaseDataModel/06setlabel 14ca1eaa1 15jeroendedauw: Add setLabel to fingerprint [18:16:18] (03CR) 10jenkins-bot: [V: 04-1] DNM Fix getItemIdForLink in SiteLinkLookup to return ItemId objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124647 (owner: 10Bene) [18:16:27] (03Merged) 10jenkins-bot: Remove troublesome fonts from font stack [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124598 (owner: 10Thiemo Mättig (WMDE)) [18:16:28] benestar: shownbatches? displayedbadges? badgestoshow? [18:16:34] badgestodisplay? [18:16:39] Thiemo_WMDE: ^ [18:16:41] lazowik: :DD [18:16:44] really funny xD [18:17:11] Lydia_WMDE: you really seem to like these batches? [18:17:11] badgeClassNames [18:17:22] maybe we should rename badges to batches? [18:17:23] lazowik: very ;-) [18:17:28] yes! [18:17:44] has anyone the possibility to run a bot as the iw import tool isn't working for Wikiquote? [18:17:59] i propose butchers. [18:18:13] Romaine: already happening [18:18:46] alright folks. time to go home for me. i should be back in an hour. [18:18:46] Thiemo_WMDE: yes please xD [18:18:47] <3 [18:18:59] Thiemo_WMDE: :D [18:19:04] Lydia_WMDE: I want to prevent islands of groups of iw's [18:19:06] Thiemo_WMDE: I actually think badgeClassNames hits the point [18:19:24] as it exactly describes what it is [18:20:54] [travis-ci] wmde/WikibaseDataModel/setlabel/ca1eaa1 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/22549401 [18:21:26] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124647 (owner: 10Bene) [18:27:56] (03PS5) 10Bene: Fix getItemIdForLink in SiteLinkLookup to return ItemId objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124647 [18:28:27] (03PS6) 10Bene: Fix getItemIdForLink in SiteLinkLookup to return ItemId objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124647 [18:28:56] JeroenDeDauw: do we have full test coverage on Wikibase? [18:31:31] benestar: No, but we strive for that [18:31:58] [13WikibaseDataModel] 15thiemowmde comment on pull request #42 14ca1eaa1: This looks suspicious. $this->label = $this->label...? 02http://git.io/k6Flbg [18:32:05] hoo: hmm, so may I assume that if the tests all pass for https://gerrit.wikimedia.org/r/#/c/124647/ it doesn't break anything? [18:34:19] (03CR) 10Bene: "Ok, so besides the options "visibleBadges", "badgesToDisplay" or "shownBadges" I'd prefer your suggestion, "badgeClassNames", which descri" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124650 (owner: 10Thiemo Mättig (WMDE)) [18:34:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124647 (owner: 10Bene) [18:34:43] :DD [18:35:33] hoo: ok, you see the tests all pass. Can we now assume that everything is fine? [18:36:09] rschen7754: no need to shout that loudly [18:36:12] :P [18:38:02] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124647 (owner: 10Bene) [18:38:12] [13WikibaseDataModel] 15thiemowmde comment on pull request #42 14ca1eaa1: Does this pattern have a name? I would expect something like TermList::add instead. 02http://git.io/s0fuPQ [18:45:37] OCD rschen7754 [18:47:01] lol [18:49:01] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Cool. Thanks a lot. This helps reducing the number of places that use numeric IDs. Not sure what the other team members say but I like it " (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124647 (owner: 10Bene) [18:52:10] (03CR) 10Bene: Fix getItemIdForLink in SiteLinkLookup to return ItemId objects (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124647 (owner: 10Bene) [18:53:33] Lol, that's funny xD http://www.php.net/manual/en/language.oop5.object-comparison.php#71623 [18:54:52] benestar: Do you know http://phpmanualmasterpieces.tumblr.com/ ? ;) [18:57:10] hoo: do you mean a specific post or the whole website? [18:57:29] benestar: The whole thing :P [18:57:48] no, but looks like being very funny ^^ [19:15:42] [13WikibaseDataModel] 15thiemowmde comment on pull request #36 141712a03: Change this to `throw $this->...` and we are golden. 02http://git.io/radnjw [19:23:37] [13WikibaseDataModel] 15thiemowmde comment on pull request #36 141712a03: I found both `callback` and `callable` but since my PHPStorm displays `@param callback $function` for some reason (https://github.com/nnmatveev/php-stubs/blob/master/stubs/standard_4.php) I used that. 02http://git.io/oFfOmg [19:28:37] [13WikibaseDataModel] 15thiemowmde pushed 2 new commits to 06code-smell: 02http://git.io/NPSwxg [19:28:37] 13WikibaseDataModel/06code-smell 140a88c05 15Thiemo Mättig: Avoid code smell warnings by adding LogicExceptions... [19:28:37] 13WikibaseDataModel/06code-smell 14504d7a0 15Thiemo Mättig: Merge branch 'code-smell' of github.com:wmde/WikibaseDataModel into code-smell [19:30:29] [13WikibaseDataModel] 15thiemowmde pushed 2 new commits to 06code-smell: 02http://git.io/-DoECA [19:30:29] 13WikibaseDataModel/06code-smell 1441ee968 15Thiemo Mättig: Merge branch 'code-smell' of github.com:wmde/WikibaseDataModel into code-smell [19:30:29] 13WikibaseDataModel/06code-smell 14ff25a17 15Thiemo Mättig: Merge branch 'code-smell' of github.com:wmde/WikibaseDataModel into code-smell [19:34:32] [13WikibaseDataModel] 15thiemowmde pushed 2 new commits to 06code-smell: 02http://git.io/UanLIw [19:34:32] 13WikibaseDataModel/06code-smell 14f905feb 15Thiemo Mättig: Merge branch 'code-smell' of github.com:wmde/WikibaseDataModel into code-smell [19:34:32] 13WikibaseDataModel/06code-smell 1495cea39 15Thiemo Mättig: Merge branch 'code-smell' of github.com:wmde/WikibaseDataModel into code-smell [19:38:27] [13WikibaseDataModel] 15thiemowmde closed pull request #40: Add reference to reference (06master...06refref) 02http://git.io/DMRbBg [19:39:42] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/lBiVwQ [19:39:42] 13WikibaseDataModel/06master 14efda446 15thiemowmde: Merge pull request #41 from wmde/terminst... [19:39:49] [13WikibaseDataModel] 15thiemowmde 04deleted 06terminst at 148c6285e: 02http://git.io/4us60A [19:50:28] (03CR) 10Bene: "Sorry for the additional comment but I just realized that "badgeClassNames" also might not fit that well. We have to somehow indicate that" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124650 (owner: 10Thiemo Mättig (WMDE)) [20:04:48] (03PS2) 10Thiemo Mättig (WMDE): Rename option 'displayBadges' to 'visibleBadges' [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124650 [20:11:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124650 (owner: 10Thiemo Mättig (WMDE)) [20:12:03] (03CR) 10Bene: [C: 04-1] "Looking good. See inline comment for a minor issue." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124650 (owner: 10Thiemo Mättig (WMDE)) [20:14:59] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124724 (owner: 10L10n-bot) [20:16:06] (03CR) 10Thiemo Mättig (WMDE): Rename option 'displayBadges' to 'visibleBadges' (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124650 (owner: 10Thiemo Mättig (WMDE)) [20:21:38] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#115 (master - af2306a : Translation updater bot): The build has errored. [20:21:38] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/83eecf8e3938...af2306abf339 [20:21:38] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/22557729 [20:24:32] (03CR) 10Thiemo Mättig (WMDE): Fix getItemIdForLink in SiteLinkLookup to return ItemId objects (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124647 (owner: 10Bene) [20:28:53] (03PS7) 10Bene: Fix getItemIdForLink in SiteLinkLookup to return ItemId objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124647 [20:30:53] (03CR) 10Bene: "Answered inline. See https://gerrit.wikimedia.org/r/#/c/124605/ for the actual implementation (which still depends on some other patches)." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124650 (owner: 10Thiemo Mättig (WMDE)) [20:34:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124647 (owner: 10Bene) [21:27:41] (03CR) 10John F. Lewis: [C: 04-1] "I agree with Lydia." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80778 (owner: 10Burthsceh) [21:32:00] Something really went wrong with the coordinates here: https://www.wikidata.org/w/index.php?title=Q961497&action=history [21:32:30] Compare the selected revisions. ;) [21:33:23] ewk [21:33:25] aude: ^ [21:34:11] ick [21:34:57] :/ [21:40:11] wait, https://gerrit.wikimedia.org/r/#/c/124744/ ? [21:43:42] hi [21:44:23] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #36 1495cea39: ah, have a newInvalidIdException method? 02http://git.io/cJCf2w [21:49:00] (03CR) 10Thiemo Mättig (WMDE): Rename option 'displayBadges' to 'visibleBadges' (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124650 (owner: 10Thiemo Mättig (WMDE)) [21:55:50] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06setlabel: 02http://git.io/I3hXlg [21:55:50] 13WikibaseDataModel/06setlabel 14cddcdc1 15jeroendedauw: Make TermList mutable and add use a more straightroreward approach to adding labels [21:56:04] Thiemo_WMDE: ^^ [21:56:07] Like that more? [21:56:23] huh? [21:56:31] the commit [21:56:37] oh. [21:57:46] be warned... ;) [21:58:37] [13WikibaseDataModel] 15thiemowmde comment on commit 14cddcdc1: Since this also updates existing languages it should be called `setTerm` instead. Same for `setLabel` above. 02http://git.io/Fm7mKQ [22:00:26] (03Abandoned) 10Aude: New build, fixes for phpunit tests, typography and page protection bug [extensions/Wikidata] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/124348 (owner: 10Aude) [22:02:05] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06setlabel from 14cddcdc1 to 1441edb5f: 02http://git.io/7O_IOg [22:02:05] 13WikibaseDataModel/06setlabel 1441edb5f 15jeroendedauw: Make TermList mutable and add use a more straightroreward approach to adding labels [22:02:59] [travis-ci] wmde/WikibaseDataModel/setlabel/cddcdc1 : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/22565865 [22:43:16] (03PS1) 10Aude: Handle exceptions in ClaimDifferenceVisualizer [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/124761 [22:44:49] (03CR) 10jenkins-bot: [V: 04-1] Handle exceptions in ClaimDifferenceVisualizer [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/124761 (owner: 10Aude) [22:48:03] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/124761 (owner: 10Aude) [22:48:15] (03PS2) 10Aude: Handle exceptions in ClaimDifferenceVisualizer [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/124761 [22:53:23] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/124761 (owner: 10Aude) [22:56:23] (03PS1) 10Aude: per wikitech, not sure we want this now. [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/124765 [22:56:33] try to sort out the jenkins etc. [22:57:15] (03PS1) 10Aude: per lydia etc., this can wait until next regular deployment [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/124767 [23:02:24] (03CR) 10Hoo man: [C: 032] "k" [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/124767 (owner: 10Aude) [23:02:43] (03Merged) 10jenkins-bot: per lydia etc., this can wait until next regular deployment [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/124767 (owner: 10Aude) [23:02:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/124765 (owner: 10Aude) [23:03:36] (03CR) 10Aude: [C: 032] per wikitech, not sure we want this now. [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/124765 (owner: 10Aude) [23:03:47] then can rebase the other patch [23:04:02] (03Merged) 10jenkins-bot: per wikitech, not sure we want this now. [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/124765 (owner: 10Aude) [23:04:19] (03PS3) 10Aude: Handle exceptions in ClaimDifferenceVisualizer [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/124761 [23:05:52] * aude can't believe we had code that outputs '?' [23:07:02] we should put our names throw new Exception( "I doubt this will ever happen -- Marius " ); [23:07:13] heh [23:08:24] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/124767 (owner: 10Aude) [23:08:46] (03PS1) 10Aude: Handle exceptions in ClaimDifferenceVisualizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124773 [23:09:28] (03PS2) 10Aude: Handle exceptions in ClaimDifferenceVisualizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124773 [23:09:30] (03CR) 10jenkins-bot: [V: 04-1] Handle exceptions in ClaimDifferenceVisualizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124773 (owner: 10Aude) [23:09:43] grrr [23:14:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/124761 (owner: 10Aude) [23:18:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124773 (owner: 10Aude) [23:21:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124773 (owner: 10Aude)