[00:00:02] <halfak>	 Maybe we can turn that kind of thing into a tag 
[00:00:14] <halfak>	 Oh!  Interesting
[00:00:22] <halfak>	 So they are translated on the fly?
[00:00:33] <Amir1>	 becuase in sever they are stored like this "/* wbaddsitelink: 1 */" and interface parses that
[00:00:44] <Amir1>	 *but* for rollback and reverts
[00:00:48] <Amir1>	 it's all the same
[00:00:56] <halfak>	 Gotcha
[00:01:45] <Amir1>	 rollbacks, restores and reverts are exact edit summaries saved in the database
[00:02:13] <Amir1>	 *are saved with exact edit summaries
[00:02:42] <halfak>	 OK.  So for now, a simple regex will work for us. 
[00:03:59] <Amir1>	 yeah
[00:04:07] <Amir1>	 but for each wiki it's different
[00:04:42] <halfak>	 That'll be OK.  I'm moving all of that description to the wiki-specific feature_list module
[00:05:10] * halfak pushes up some more changes
[00:06:27] <halfak>	 Amir1, see https://github.com/wiki-ai/wb-vandalism/blob/feature_location_refactor/wb_vandalism/feature_lists/wikidata.py
[00:06:48] <halfak>	 is_blp = has_birthday.and_(not_(dead))
[00:06:56] <Amir1>	 great
[00:07:03] <halfak>	 :D
[00:10:03] <Amir1>	 having them in a separate file sounds interesting to me
[00:10:13] <Amir1>	 oh we have PR
[00:12:35] <Amir1>	 halfak: tell me when you're done with the WIP PR
[00:12:46] <halfak>	 Will do.  I think I'll have to finish it off tomorrow. 
[00:13:08] <halfak>	 I have all of the stuff working, but I need to write some tests and I want to start getting us away from using the API for tests. 
[00:14:42] <halfak>	 So I'll be figuring out a nice way to build a partial item for testing purposes. :) 
[00:14:52] <halfak>	 Anyway time to run away.  Have a good one! 
[00:14:53] <halfak>	 o/
[00:15:03] <Amir1>	 halfak: 
[00:15:16] <Amir1>	 I talk to you later about the tests
[00:15:21] <Amir1>	 see you
[00:15:29] <Amir1>	 Enjoy your weekend o/
[12:48:55] <White_Cat>	 hello internet
[12:48:57] <White_Cat>	 press 1 to continue
[17:53:16] <HareJ>	 hello cool cat
[20:20:45] <halfak>	 o/ 
[21:33:49] <YuviPanda>	 halfak: hey
[21:34:05] <YuviPanda>	 halfak: I'm going to be waylaid until thursday with a kubernetes conference I'm afraid :(
[21:34:49] <halfak>	 Gotcha.  Thanks for letting me know. 
[21:35:08] <halfak>	 I'll hold off on any playing with backpressure in prod until you're back. 
[21:35:18] <YuviPanda>	 halfak: yeah, and I haven't really spoken at a conference for almost a year now so doing extra bits of prep
[21:36:34] <halfak>	 :D  cool!  
[21:59:41] <ToAruShiroiNeko>	 hmm
[22:01:02] <ToAruShiroiNeko>	 still looking for that plushie :p
[22:03:39] <ToAruShiroiNeko>	 halfak do you have a european visit at some point this year?
[22:06:32] * YuviPanda feels happy every time he uses &rarr;
[22:08:53] <halfak>	 ToAruShiroiNeko, nothing planned at the moment. 
[22:09:18] <halfak>	 My next scheduled Europe trip would be Wikimania, but I suspect some things will come up between now and then. 
[22:12:38] <ToAruShiroiNeko>	 hmm
[22:12:54] <ToAruShiroiNeko>	 that is surprising
[23:36:53] <halfak>	 https://github.com/wiki-ai/wb-vandalism/pull/14