[00:00:00] Uh oh. I get the "Apache2 Ubuntu Default Page" instead of mediawiki when I go to localhost:8080 [00:00:39] Oh wait. Looks like I'm still coming online. [00:02:01] Let's try that again [00:04:38] Oh goddamn, it's blocked on startup. Stupid virtualenv. [00:08:13] do you want to try another port [00:08:20] it helped me several times [00:09:14] (03CR) 10Krinkle: "If this is the only change, then the problem is most likely that the module is registered in the system on the server, but never associate" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/266167 (https://phabricator.wikimedia.org/T124616) (owner: 10Ladsgroup) [00:09:45] Amir1, just have to reboot it with a gui [00:16:37] * halfak sighs along waiting for vagrant to provision [00:22:36] yesss [00:22:42] the database schema is working now [00:24:04] (03PS11) 10Ladsgroup: [WIP] Some minor improvements to the database schema [extensions/ORES] - 10https://gerrit.wikimedia.org/r/265944 (https://phabricator.wikimedia.org/T124443) [00:36:04] And the provisioning continues [00:40:45] ... [00:48:33] Hey Amir1. I've got to go pack up because I'm traveling tomorrow (a workshop in Omaha) [00:50:09] okay [00:50:19] Amir1, I won't be able to make our usual time this Friday due to said workshop. [00:50:21] any success regarding the vagrant [00:50:26] But I will be around at the usual time on Saturday. [00:50:33] Still provisioing [00:50:40] :( [00:50:40] I'm not sure what's up, but I'll just let it go. [00:50:47] ok [00:51:01] Do you want to have make up seesion? [00:51:06] I should have an editquality PR with the new models and new model stats tomorrow. [00:51:12] Yeah. I think on Saturday morning. [00:51:22] that would be great [00:51:25] We'll need to clean up the board and I'll look into writing the progress report. [00:51:42] I'll do some stuff in the mean time [00:51:50] specially about the KDD paper [00:52:06] assign some tasks for me to do [00:52:12] I also check your PR and merge it [00:52:25] I'm kind stuck in this extension [00:52:36] but It'll end soon [00:52:43] Amir1, oooh. Re. KDD paper, I'll try to get some writing done while flying. [00:52:59] I am a good outliner when I'm stuck in metal tubes. [00:53:06] OK. off to start packing [00:53:07] o/ [00:53:33] o/ [01:09:55] (03PS3) 10Ladsgroup: Make "r" flag red [extensions/ORES] - 10https://gerrit.wikimedia.org/r/266167 (https://phabricator.wikimedia.org/T124616) [01:10:10] (03CR) 10jenkins-bot: [V: 04-1] Make "r" flag red [extensions/ORES] - 10https://gerrit.wikimedia.org/r/266167 (https://phabricator.wikimedia.org/T124616) (owner: 10Ladsgroup) [01:12:27] (03PS12) 10Ladsgroup: Some minor improvements to the database schema [extensions/ORES] - 10https://gerrit.wikimedia.org/r/265944 (https://phabricator.wikimedia.org/T124443) [01:14:01] (03CR) 10Ladsgroup: [C: 032] Some minor improvements to the database schema [extensions/ORES] - 10https://gerrit.wikimedia.org/r/265944 (https://phabricator.wikimedia.org/T124443) (owner: 10Ladsgroup) [01:14:48] (03Merged) 10jenkins-bot: Some minor improvements to the database schema [extensions/ORES] - 10https://gerrit.wikimedia.org/r/265944 (https://phabricator.wikimedia.org/T124443) (owner: 10Ladsgroup) [01:19:07] (03PS4) 10Ladsgroup: Make "r" flag red [extensions/ORES] - 10https://gerrit.wikimedia.org/r/266167 (https://phabricator.wikimedia.org/T124616) [01:19:58] (03CR) 10jenkins-bot: [V: 04-1] Make "r" flag red [extensions/ORES] - 10https://gerrit.wikimedia.org/r/266167 (https://phabricator.wikimedia.org/T124616) (owner: 10Ladsgroup) [01:20:32] (03CR) 10Ladsgroup: "PS4 is rebase only" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/266167 (https://phabricator.wikimedia.org/T124616) (owner: 10Ladsgroup) [01:22:56] (03PS5) 10Ladsgroup: Make "r" flag red [extensions/ORES] - 10https://gerrit.wikimedia.org/r/266167 (https://phabricator.wikimedia.org/T124616) [01:23:21] mess in conflict resolution [01:30:57] (03CR) 10Ladsgroup: "This needs some updates regarding 1- threshold handling change 2- DB schema update" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/264608 (https://phabricator.wikimedia.org/T122537) (owner: 10Awight) [01:59:47] (03PS1) 10Ladsgroup: Fix one bug and an improvement [extensions/ORES] - 10https://gerrit.wikimedia.org/r/266649 [02:02:05] (03PS6) 10Ladsgroup: Make "r" flag red [extensions/ORES] - 10https://gerrit.wikimedia.org/r/266167 (https://phabricator.wikimedia.org/T124616) [02:02:56] (03CR) 10Ladsgroup: [C: 032] Fix one bug and an improvement [extensions/ORES] - 10https://gerrit.wikimedia.org/r/266649 (owner: 10Ladsgroup) [02:05:11] (03Merged) 10jenkins-bot: Fix one bug and an improvement [extensions/ORES] - 10https://gerrit.wikimedia.org/r/266649 (owner: 10Ladsgroup) [02:14:17] awight: hey, do you have some time? [02:24:15] Amir1: Hi! Awesome to see all your work on the MediaWiki extension, thank you for pushing us so far! [02:25:01] I'm more than happy to do this [02:25:05] I love it [02:25:38] How can I help? [02:26:04] I'm about to finish most of my work [02:26:24] We changed database schema per sysadmin suggestions [02:26:55] I updated all of your existing scripts [02:27:06] but you need to update the user contribution patach [02:27:19] since I don't want to interrupt your work [02:27:26] *patch [02:28:07] and I want to ask you if it's okay for you we split to work for user contribution [02:28:24] e.g. you implement some hooks and I implement other ones [02:28:26] sounds great. That patch was a bit of a failure [02:29:13] And one of the most important things we need to do is writing the maintenance script that populates the database [02:29:38] To warm the cache? [02:29:47] you have a WIP patch but you haven't touched it for a while (lots of things have changed) [02:29:52] y\yes [02:29:54] *yes [02:30:20] I think it's okay to let it populate at a natural speed [02:31:24] kk [02:31:27] I love that :D [02:31:51] specially I think that will bring ores.wmflabs.org to its knees [02:32:04] good point! [02:32:12] Abandoning... [02:32:34] awight: last thing I would love to see is a fast code review by you [02:32:39] (03Abandoned) 10Awight: WIP Maintenance script to populate score cache [extensions/ORES] - 10https://gerrit.wikimedia.org/r/239335 (owner: 10Awight) [02:33:00] I don't know much about php maybe I'm not following some coding conventions, etc. [02:33:11] Amir1: I don't see it yet... [02:33:15] or you think something is needed [02:33:15] assign me as a reviewer? [02:33:25] no [02:33:43] reviewing every patch takes a very long time [02:33:54] I made about ten patches I guess [02:34:07] review the whole thing [02:34:20] (I +2'd lots of my patches) [02:35:07] Also you can test everything you want in here: http://mw-revscoring.wmflabs.org/wiki/Special:RecentChanges [02:35:27] currently I'm testing this: https://gerrit.wikimedia.org/r/#/c/266167/ [02:39:07] awight: https://phabricator.wikimedia.org/tag/mediawiki-extensions-ores/ check this, and anything you want, I will make it happen (also if you think tag-integration should be an essential feature, tell me to implement it) [02:39:13] and add [02:41:23] I still don't understand tags well enough to know. [02:41:57] okay :) [02:51:46] Damn, mw-revscoring doesn't have the mw-core patch to rollup extension flags [02:54:52] let me update the mediawiki [02:55:10] (maybe I just apply the patch as temp. wrokaround) [02:56:58] It's not merged yet... https://gerrit.wikimedia.org/r/#/c/247249/ [02:59:11] (03PS1) 10Awight: [WIP] Messing with tag integration [extensions/ORES] - 10https://gerrit.wikimedia.org/r/266654 [02:59:28] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Messing with tag integration [extensions/ORES] - 10https://gerrit.wikimedia.org/r/266654 (owner: 10Awight) [03:02:14] awight: I applied your patch to mw-revscoring [03:02:34] I'll push to get that patch merged :) [03:03:31] * awight 's eyes light up [03:03:56] looks like you need to run composer update [03:04:09] okay [03:04:11] one sec [03:05:20] working [03:11:32] awight: done [03:11:55] It's alive! [03:12:03] Nice red "r" [03:12:54] oh I actually wanted to ask you if you think the "r" should be red or not [03:12:59] https://gerrit.wikimedia.org/r/#/c/266167/ [03:13:05] (this is the patch) [03:13:42] I think it's great--do you want a designer to take a sniff? [03:14:00] maybe [03:14:39] violetto has been kind to help us on several matters, maybe she can take a look at it too :) [03:24:45] So, Special:Contributions doesn't have a hook to display additional filters. Or does it? [03:26:15] in core or in our extension? [03:26:24] includes/specials/SpecialContributions.php [03:26:46] I haven't looked it at [03:26:51] let me check [03:26:56] We would want to add a checkbox via extraOptions or tags, I think. [03:28:25] SpecialContributionsBeforeMainOutput [03:28:36] is it the hook? [03:29:52] I don't even see a way to modify the HTML form using that hook :( [03:29:59] It doesn't look like it [03:30:02] yeah [03:31:00] ContributionsToolLinks [03:31:17] there are only five hooks in that file and these are the related ones [03:31:32] * Amir1 is reading the code more carefully [03:31:42] toollink can add things to the line, but in the wrong place [03:31:56] It's a bit of a scandal that this code isn't reused from the other, identical views [03:32:29] agreed [03:32:44] From what I understand, tags aren't quite right, because there are assumptions about tags being backed by link table rows. [03:35:01] :( [03:35:21] so we should some stuff in core [03:36:30] https://phabricator.wikimedia.org/T124857?workflow=122537 [03:42:49] that's really sad that UserContributions doesn't support hiding minor edits even though it shows the flag [03:43:52] maybe we should copy-paste or reuse it from changeslist and add those parts to user contribs [03:44:03] so we would help lots of people [03:49:03] +1 [03:49:13] Mind if I copy that to the bug? [04:00:48] * awight grimaces. [04:01:00] Reuse might not be such a stroll in the park--each page has its own hooks. [04:01:03] why not [04:01:26] (I was talking about copying to the bug) [04:01:38] I don't know mediawiki very well [04:02:19] For example, includes/specials/SpecialRecentchanges.php -> SpecialRecentChangesFilters [04:02:53] Reusing the code would require that we either shim or migrate all the page-specific hooks [04:32:26] i will be happy to look at it Amir1 [04:32:44] oh thanks :) [04:33:06] is there a task already on phab that i can start looking at? [04:33:19] im going to zzz, but i'll look at it first thing in the morn :) [04:33:42] awesome [04:34:04] (03PS1) 10Awight: Adds filter to Special:Contributions [extensions/ORES] - 10https://gerrit.wikimedia.org/r/266660 (https://phabricator.wikimedia.org/T122537) [04:34:14] https://phabricator.wikimedia.org/T124616 [04:34:20] (03CR) 10jenkins-bot: [V: 04-1] Adds filter to Special:Contributions [extensions/ORES] - 10https://gerrit.wikimedia.org/r/266660 (https://phabricator.wikimedia.org/T122537) (owner: 10Awight) [04:35:16] thanks awight :) [04:35:35] violetto: https://phabricator.wikimedia.org/T124616 [04:35:57] It's a good excuse to rummage through mw-core! [04:37:40] if you rebase I promise to review it ASAP [04:39:24] Amir1: also let me know if there's any kind of "deadlines" [04:39:54] oh, there's no deadline, I'm just super excited [04:40:08] haha okay! [04:40:10] awight: https://gerrit.wikimedia.org/r/#/c/266659/ [04:40:21] i just got a new laptop, can't see changes yet [04:40:59] as in, i need my set up my laptop, happening only this thursday [04:41:40] If you want I can apply it in a test wiki and you check it [04:41:52] it's just a suggestion [04:42:37] violetto: Hi! Same lack of deadline for the related patches I wrote. Thanks for taking a look! [04:42:58] yeah can [04:43:27] I think jdlrobson is interested in cleaning up this code as well, for adding more flexibility for mobile views [04:50:50] done, I applied the patch to mw-revscoring [04:51:01] cool! [04:51:07] if http://mw-revscoring.wmflabs.org/ [04:52:26] I want to apply it to ORES extension too but It seems it's not rebased [04:55:48] Oops, thanks for noticing [04:56:24] Adding support for the flag is turning out to be more than I bargained for... [04:58:46] https://www.dropbox.com/s/40c38sz46hcy7p6/Screenshot%202016-01-26%2020.58.21.png?dl=0&preview=Screenshot+2016-01-26+20.58.21.png [04:58:51] im seeing the right thing? [05:03:47] violetto: If you're looking at the patch to add a new hook, you'll also want the ORES patch which includes that hook... [05:04:11] https://gerrit.wikimedia.org/r/266660 [05:04:43] * awight glances at change number and immediately makes 6 one-line patches [05:17:48] violetto: in the mean time, if you're around. Do you think the "r" flag in recent changes should be red or black? or any kind of suggestion like another color, bigger size, italic, etc. [05:18:09] note that it will be shown beside the "!" sign most of the time [05:18:39] https://usercontent.irccloud-cdn.com/file/3fRTqlXq/ [05:19:37] but sometimes without the "!" flag (when the user does not have patrol flag) [05:19:46] https://usercontent.irccloud-cdn.com/file/maUFza9E/ [05:25:58] awight|away: ah ok [05:27:08] Amir1: i have some questions like, is this supposed to be understandable for people who don't really understand what ores is [05:27:54] and who will be seeing this? (this is going to be a beta experiment right? [05:28:24] i'll see your replies tmr morning k! [05:28:29] night!! [05:40:44] violetto: it'll be for all people but we have a legend at top of the page and also it has a tooltip too [05:41:27] (at first yes, only beta testers will see it but the goal is to enable it for everyone ) [07:36:00] (03PS2) 10Awight: [WIP] Filter out non-damaging changes in Special:Contributions [extensions/ORES] - 10https://gerrit.wikimedia.org/r/264608 (https://phabricator.wikimedia.org/T122537) [07:36:43] (03Abandoned) 10Awight: Adds filter to Special:Contributions [extensions/ORES] - 10https://gerrit.wikimedia.org/r/266660 (https://phabricator.wikimedia.org/T122537) (owner: 10Awight) [07:37:12] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Filter out non-damaging changes in Special:Contributions [extensions/ORES] - 10https://gerrit.wikimedia.org/r/264608 (https://phabricator.wikimedia.org/T122537) (owner: 10Awight) [07:44:55] (03PS3) 10Awight: Integrate with Special:Contributions [extensions/ORES] - 10https://gerrit.wikimedia.org/r/264608 (https://phabricator.wikimedia.org/T122537) [07:45:47] (03CR) 10jenkins-bot: [V: 04-1] Integrate with Special:Contributions [extensions/ORES] - 10https://gerrit.wikimedia.org/r/264608 (https://phabricator.wikimedia.org/T122537) (owner: 10Awight) [07:53:09] (03PS4) 10Awight: Integrate with Special:Contributions [extensions/ORES] - 10https://gerrit.wikimedia.org/r/264608 (https://phabricator.wikimedia.org/T122537) [14:50:55] I woke up this morning to a fully provisioned vagrant! [14:50:57] Wooot [14:51:20] It's slower than molasses though [17:18:48] https://phabricator.wikimedia.org/T123795 [17:18:51] halfak: o/ [17:18:55] check this :) [17:19:00] o/ Amir1 [17:35:21] Amir1, I'm looking at the schema and it seems to make some assumptions that I don't think play out. I'll leave a comment. [22:13:55] o/ [22:13:57] * halfak is layover in ORD [22:14:09] I found a bug in how we're generating accuracy scores when using scaling/centering [22:14:25] Mostly that scaling/centering aren't applied before that scorer, so it looks really bad. [22:14:35] I'll have a PR shortly :) [22:15:05] Oooh. Looks like my modeling/stats PR is still open, so I'll just add it to that. [22:19:22] C'mon ORD wifi. Upload those new models! [22:19:57] Uh oh. Looks like I'm being throttled :( [22:20:21] yay! Still worked. [22:20:39] I need to rebuild the editquality models though because their accuracy stat is probably wrong. [22:22:10] OK. New models building on ores-compute. \o/ [22:22:16] Time for next flight. [22:24:30] * halfak downloads his & Amir1's mini-review of vandalism for notes on the next flight. [22:24:35] OK. Off I go again. [22:24:36] o/