[15:48:07] o/ [15:48:31] I see in the backscroll that plwiki is ready to go. Woot! [15:49:01] yuvipanda, yes. I have a few datasets to load. [15:51:44] o/ Amir1 [15:51:52] hey [15:51:53] just got back to work on my tests. [15:52:05] I don't make PR because I'm writing tests [15:52:15] awesome [15:52:27] I left some messages for you in telegram [15:55:31] wiki-ai/revscoring#547 (polish - 9cc2a05 : amir): The build passed. https://travis-ci.org/wiki-ai/revscoring/builds/110772246 [16:21:30] Amir1, https://phabricator.wikimedia.org/T127586 [16:21:37] What do you think of the proposal? [16:22:32] redaing [16:25:44] that's good but we need to change concept of things in the source code. [16:25:49] I changed it once [16:26:03] now I'm kinda reverting back if we agree on this [16:26:53] I changed it because people were telling me high threshold is not understandable to them, but strictness is [16:27:43] Oh! I see. We can iterate. [16:27:55] How about "High sensitivity" [16:29:57] Amir1, new post https://phabricator.wikimedia.org/T127586 [16:32:27] halfak: that's really good [16:32:33] :D [16:32:47] I don't know how to make a tooltip [16:32:49] let me google [16:33:19] in the mean time let's wait if travis passes this. I couldn't test it due to strange dependencies [16:37:00] wiki-ai/revscoring#548 (polish - 65a96ad : amir): The build was broken. https://travis-ci.org/wiki-ai/revscoring/builds/110778149 [16:41:34] Amir1, you probably want a title attribute E.g. ... [16:42:44] maybe mediawiki has something built-in [16:54:56] (03PS1) 10Ladsgroup: Better messages in preferences [extensions/ORES] - 10https://gerrit.wikimedia.org/r/272324 (https://phabricator.wikimedia.org/T127586) [16:55:09] halfak: ^ [16:55:23] I realized it's not needed at all. [16:55:32] mediawiki uses a class called HTMLForm [16:55:38] and it has attributes [16:55:48] (03CR) 10jenkins-bot: [V: 04-1] Better messages in preferences [extensions/ORES] - 10https://gerrit.wikimedia.org/r/272324 (https://phabricator.wikimedia.org/T127586) (owner: 10Ladsgroup) [16:55:49] and we even defined those attributes! [17:04:55] (03PS2) 10Ladsgroup: Better messages in preferences [extensions/ORES] - 10https://gerrit.wikimedia.org/r/272324 (https://phabricator.wikimedia.org/T127586) [17:16:59] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Please add message documentation when adding messages. See https://www.mediawiki.org/wiki/I18n#Message_documentation f" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/272324 (https://phabricator.wikimedia.org/T127586) (owner: 10Ladsgroup) [17:34:53] (03CR) 10Ladsgroup: "@Siebrand: I added in qqq.json. Is there anything else missing?" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/272324 (https://phabricator.wikimedia.org/T127586) (owner: 10Ladsgroup) [17:55:38] Fun story. After a bit of work, our old SVCs are just as high ROC-AUC as our current gradient boosting classifiers. [17:55:43] wiki-ai/revscoring#551 (format_json - 9dd1b35 : halfak): The build failed. https://travis-ci.org/wiki-ai/revscoring/builds/110791448 [17:56:00] BUT, the PR-AUC is much higher for the gradient-boosting classifiers. [17:58:03] it's great we have these tuning system [17:58:10] Indeed :) [17:58:29] I think that we should eventually change the tuning system to optimize PR-AUC. [17:58:45] This is just a command-line option, so just a few changes in the makefile. [18:05:01] halfak: I sent an email off-list to hashar, [18:05:07] I know how to make the config [18:05:17] but I wanted to be sure because he knows [18:05:19] better [18:06:16] * halfak compiles a new version of scipy for like 50 minutes. [18:06:55] Amir1, seems like that response would have been better if he had linked us to docs rather than just commenting offhandedly that something is generally "required". [18:08:53] welcome to the club of mediawiki developers [18:09:09] woooo [18:09:11] :/ [18:09:14] :D [18:10:39] halfak: I also have a PR in ORES [18:10:57] It redirect ores.wmflabs.org/ it self to ores page at meta [18:11:07] I'm not sure it's a good idea [18:11:27] but it's better than "Hey, I'm ORES :D" :D [18:11:27] Amir1, yeah... I'm skeptical that this is what we want. [18:11:32] Yes it is. [18:11:59] I might just write up something for this. Would you be willing to implement a change if I write up the page? [18:12:13] Sure [18:12:24] I wanted to get violetto on board [18:12:32] but she hasn't answered my ping yet :D [18:12:54] Gotcha. Will be good to have a minimal page in place when she takes a look. [18:15:17] kk [18:20:28] wiki-ai/revscoring#552 (polish - 4f77ea3 : amir): The build was fixed. https://travis-ci.org/wiki-ai/revscoring/builds/110795463 [18:25:02] Amir1, see https://github.com/wiki-ai/ores/pull/123 [18:25:08] Just finished the basic HTML [18:27:06] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed. Looks like you submitted PS1 while I was reviewing PS1, and then I submitted the -1 to PS2." [extensions/ORES] - 10https://gerrit.wikimedia.org/r/272324 (https://phabricator.wikimedia.org/T127586) (owner: 10Ladsgroup) [18:47:54] awesome halfak [18:48:19] I was afk walking home from university [18:48:45] Just finishing up tests on the test statistics. [18:53:46] halfak: I made a PR on revscoring for polish [18:53:52] added tests fixed some other files too [18:54:00] I also put your home page [18:54:10] and I'm making a PR right now [18:54:33] (03CR) 10Ladsgroup: [C: 032] Better messages in preferences [extensions/ORES] - 10https://gerrit.wikimedia.org/r/272324 (https://phabricator.wikimedia.org/T127586) (owner: 10Ladsgroup) [18:55:25] (03Merged) 10jenkins-bot: Better messages in preferences [extensions/ORES] - 10https://gerrit.wikimedia.org/r/272324 (https://phabricator.wikimedia.org/T127586) (owner: 10Ladsgroup) [18:56:12] Comments here: https://github.com/wiki-ai/revscoring/pull/242 [18:59:28] thanks, [18:59:30] just fixed [18:59:32] pushing [19:00:05] halfak: I can't do sudo in mediawiki instance of revscoring [19:00:18] it asks password, it wasn't like this before :( [19:00:34] now I can't update the extension in test server [19:00:47] Amir1, happens to me sometimes and I ping in -labs. [19:01:03] okay [19:01:04] Could be that you are in the middle of a puppet run or puppet has broken. [19:01:06] let me try [19:45:41] Amir1, https://github.com/wiki-ai/revscoring/pull/243 [19:45:49] Gotta run away now. [19:45:59] Will likely be back online in a few hours. [19:46:00] o/ [20:41:18] halfak: awesome, I was afk [20:41:21] halfak: https://phabricator.wikimedia.org/T114508 [20:41:24] \o/