[15:03:01] <halfak>	 o/
[17:02:34] <halfak>	 o/ Amir1 
[17:02:40] <halfak>	 Mind taking a look at https://github.com/wiki-ai/ores/pull/130?
[17:03:51] <halfak>	 Amir1, note that we now have explicit paths for /v1/ and /v2/
[17:03:55] <halfak>	 But the old paths will still work. 
[17:04:19] <halfak>	 They'll just mimic v1. 
[17:04:29] <halfak>	 Luckily flask makes this super-easy to do. 
[17:08:41] <Amir1>	 hmm
[17:08:43] <Amir1>	 sure
[17:08:55] <Amir1>	 o/
[17:13:48] <Amir1>	 halfak: why did you remove label_reverted.py?
[17:15:50] <Amir1>	 is it because it's in editquality?
[17:23:44] <Amir1>	 halfak: keep in mind that you need to update wheels before deployment 
[17:24:11] <halfak>	 Amir1, yeah.  In editquality.
[17:24:36] <halfak>	 Will do.  I'm going to review all of the versions in requirements.txt before moving on to ores-wikimedia-config. 
[17:24:37] <halfak>	 :) 
[17:25:03] <Amir1>	 amazing
[17:25:20] <Amir1>	 I need to check a bug reported by Nikerabbit beofre moving on
[17:28:47] <Amir1>	 halfak: you have done messages in edit_type can you check this? https://phabricator.wikimedia.org/T127694#2125451
[17:28:55] <Amir1>	 is it okay to change it to ""?
[17:29:20] <halfak>	 Yes.  It should really have a description.  Let me grab it for you and you can just fix it while you are working. 
[17:29:33] <halfak>	 "modify content"
[17:29:33] <halfak>	 lol
[17:29:37] <halfak>	 fancy description
[17:29:50] <halfak>	 Oh wait.  Wrong one. 
[17:29:56] <halfak>	 "delete content"
[17:30:11] <halfak>	 See all the description content here: https://en.wikipedia.org/wiki/Wikipedia:Labels/Edit_types/Taxonomy#Actions
[17:30:41] <Amir1>	 thanks
[17:30:54] <halfak>	 brb lunchtime
[17:48:03] <Amir1>	 halfak: I pushed directly to master if that's okay
[17:53:48] <Amir1>	 Also there is a discussion in a gerrit patch of mine in ORES extension: currently, ORES extension doesn't show the flag if edit is patrolled (so if an edit is a false positive, someone mark it patrolled and it won't show up again for others) one of developers in WMDE argues that there are some wikis that don't have patrolling option. My answer is that if a
[17:53:48] <Amir1>	 wiki doesn't have basic tools to fight vandalism why bothering to try complex one (and virtually all of WMF wikis have patrolling option)
[17:54:05] <Amir1>	 also it's great we have WMDE developers checking our work
[18:05:47] <Amir1>	 halfak: Add this link to your bookmarks: https://translatewiki.net/wiki/Special:MessageGroupStats/wiki-ai
[18:19:17] <halfak>	 Amir1, totally OK to push that kind of thing to master.  Just so long as you make sure it's not totally broken first :) 
[18:19:45] <Amir1>	 yeah I checked if it's a valid json or not
[18:19:47] <Amir1>	 and it was
[18:19:52] <Amir1>	 very basic things
[18:19:52] <halfak>	 good good :) 
[18:20:03] <halfak>	 So re. the patrol flag, how do we degrade in those wikis?
[18:20:58] <Amir1>	 sorry, I don't understand
[18:21:57] <halfak>	 In wikis that do not use the patrol flag (or autopatrol edits), how does ORES behave?
[18:22:14] <halfak>	 It seems like it will appear as though ORES predicts everything is good, right?
[18:22:52] <Amir1>	 the ores itself doesn't care
[18:23:02] <Amir1>	 the extension doesn't highlight a thing
[18:23:08] <Amir1>	 I can re-work that 
[18:23:17] <Amir1>	 make it at least optional 
[18:23:40] <halfak>	 I think that might make sense. 
[18:23:42] <Amir1>	 but I need to know should we support those wikis or not
[18:23:50] <halfak>	 I think we should
[18:24:05] <Amir1>	 okay, I work on that
[18:24:07] <Amir1>	 I just realized I lost my keys and my bf is out of town, I need to go find a place :D
[18:24:07] <halfak>	 I'm hoping to talk to the CE dept more about targeted support of "Emerging Communities"
[18:24:26] <Amir1>	 it's about 10 PM here
[18:25:09] <Amir1>	 that would be great
[18:27:13] <Amir1>	 see you soon-ish
[18:27:16] <Amir1>	 o/
[18:27:28] <halfak>	 p/ 
[18:27:30] <halfak>	 o/
[19:22:21] <Amir1>	 Okay
[19:22:42] <Amir1>	 I crashed at my aunt's house, tomorrow I'll look for locksmit
[19:22:45] <Amir1>	 *locksmith
[19:22:49] <Amir1>	 anyway
[19:22:53] <Amir1>	 scap3!
[20:56:22] <grrrit-wm>	 (03CR) 10Ladsgroup: [C: 032] "I will make a patch to support wikis without patrol rights" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/277509 (https://phabricator.wikimedia.org/T129892) (owner: 10Ladsgroup)
[20:57:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Filter out patrolled edit when hidenondamaging = 1 [extensions/ORES] - 10https://gerrit.wikimedia.org/r/277509 (https://phabricator.wikimedia.org/T129892) (owner: 10Ladsgroup)
[23:31:47] <halfak>	 I'm outta here.  Have a good one folks!
[23:31:48] <halfak>	 o/