[12:40:19] o/ halfak [14:50:54] o/ Amir1 [14:51:07] o/ halfak [14:51:10] Sorry for late. Day off == sleep in and program fun things :D [14:51:26] no worries at all [14:52:03] https://phabricator.wikimedia.org/T130515 [14:52:14] here is my report of the bug [14:53:23] Amir1, nicely written bug. [14:53:47] I hope people get to this soon [14:53:50] thanks :) [14:54:27] my plan after finishing scap is to spend some time in the extension [14:54:39] would be okay for you halfak? or [14:54:52] you want something else to be done [14:55:27] Amir1, that sounds great. [14:56:00] \o/ [14:56:36] Just had a thought about loading the ores-scores table -- how does that script work? [14:56:47] As in -- how does it sequence requests to ORES [14:56:55] one at a time? Batch of 50? Parallel? [14:57:08] it runs two kind of requests [14:57:40] first: once an edit is made. one per edit once it's made [14:58:31] second: the maintenance script: not parallel, in batches of 50 (I can simply change it to something else but I think the ores upper limit is 50) [14:59:03] and it's stored in the table forever [14:59:08] Yeah. That's great. [14:59:14] (because I want to support user contribs) [14:59:21] Was just thinking about how we should aim for efficiency there. [14:59:55] in db manners it's efficient as possible [15:00:09] everything is integer [15:01:33] More worried about how ORES will be using resources. [15:01:35] Batch is nice. [15:01:44] It saves us a lot in these use-cases. [15:01:51] but edits are not batched [15:01:57] once an edit is made [15:02:01] That's OK [15:02:04] Intended use [15:02:10] (it makes it distributed) [15:02:22] It's actually distributed with batch too [15:02:25] But only the CPU [15:02:34] The API queries go out in batch. [15:02:43] :) [15:02:51] I mean distributed in time, instead of unleashing tons of requests once a day [15:03:10] there is one possible case: sometimes job queue gets stuck for some reasons [15:03:29] That's where we get all of our efficiency. 3 API requests vs 3 * 50 = 150 API requests. [15:03:38] job queue of mediawiki. I remember there were about 3 million jobs stuck two weeks ago [15:03:57] but once the problem is solved it might unleash ores jobs at once [15:03:59] Amir1, we also have a job queue that can get stuck ^_^ [15:04:09] and it might causes issues for us [15:04:33] \o/ [15:04:37] But we refuse new requests when the queue has 100 tasks backed up. We might want to increase that as we move towards more capacity. [15:04:49] yeah [15:05:57] that would be very good [15:07:04] Generally our queue should never take on tasks. [15:07:40] But I bet we'll hit a little bit of a bottleneck getting the tasks out to the workers [15:08:15] Note to self -- we'll want to write up the "two modes of use" doc for ORES. [15:08:46] "So you want to score edits in realtime" and "So you want to score a big set of edits ASAP" [15:09:05] With this graph: https://meta.wikimedia.org/wiki/Research:Building_automated_vandalism_detection_tool_for_Wikidata#/media/File:Ores_wikidatawiki_response_timing.single_batch_and_cached.svg [15:09:42] that graph makes me smile every time I see it [15:10:10] halfak: one thing about the extension: do you remember we talked about wikis that doesn't have patrolled enabled [15:10:22] Yeah [15:10:35] I want to add support for these wikis, even though I think there would be a very few wikis with this situation [15:11:26] my design plan is in a way that the "r" for edits that their score pass the threshold won't never disappear [15:11:52] Ohh! I like it. [15:11:53] in wikis with patrolled enabled it disappears after edit is being patrolled [15:12:07] Yeah. [15:12:21] and if edit is auto patrolled [15:12:30] it never gets the "r" flag [15:12:39] but their scores is stored in db [15:12:45] Hmm. [15:12:47] kk [15:13:09] I did it for analytical reasons (to get false positives easily) [15:13:23] So, it sounds like auto patrolled edits will never be flagged. [15:13:38] https://phabricator.wikimedia.org/T130536 [15:13:40] BTW ^ [15:13:53] Looking at it. I think I'll want to do a new deploy. [15:14:14] I'm going to put the ores submodule back, I think. [15:14:25] But I have already solved the problem in packaging. [15:14:54] And then we'll have swagger deployed! [15:15:03] yeah but we can learn and lower their scores [15:15:09] in new models [15:15:32] oh [15:15:45] okay, I'm here to do whatever is needed [15:16:25] Amir1, so on these wikis, are all edits autopatrolled? [15:16:35] it seems [15:17:04] that's where I need to fix [15:19:26] okay one of releng replied to the bug [15:19:29] let me check [15:26:49] halfak: is ores-compute-2 dead? [15:26:54] Yes. [15:26:57] Sorry for no warning. [15:27:03] I needed the CPUs yesterday. [15:27:11] I hope I didn't delete anything important :\ [15:27:16] no [15:27:30] I'm just trying to deploy in a target except ores-compute-01 [15:27:42] Try one on staging. [15:28:16] ores-staging-01.eqiad.wmflabs? [15:28:29] Actually, that one is dead and staging-02 is alive now. [15:28:37] Maybe you really just want a new test VM. [15:28:45] I need staging for deployment staging. [15:29:18] * halfak configures a new VM [15:29:21] yeah [15:29:25] thanks [15:29:58] OK ores-scaptest-01 will be configured in the staging role in a few minutes. [15:30:25] awesome [15:30:42] You'll need to run the "initialize_staging_server" stuff from the fabfile or implement the same in scap3. [15:31:47] sure [15:32:50] Amir1, https://gerrit.wikimedia.org/r/278735 [15:34:40] {{done}} [15:34:40] How cool, Amir1! [15:34:45] :P [15:36:53] Thanks! [15:52:40] * halfak deploys to staging [15:54:42] * halfak closes 17 tasks from last week. [15:54:46] Good work team! [16:00:02] hmm, I wanted to show them off tomorrow in the weekly meeting [16:00:03] :D [17:07:31] halfak: updated [17:11:27] Amir1, I can't really test. Otherwise it looks good to go. [17:12:06] I've spent last three days trying to test it [17:12:14] it's okay :) [17:13:06] definitely need some work when we are in prod (things I can't do right now, for example targets in prod that we don't know them) [17:13:16] Github is down [17:13:17] right now [17:13:22] :| [17:13:32] Tried to merge and failed. [17:13:44] Feel free to self-merge if you see github come back online. [17:14:54] ok [17:14:57] thanks [17:14:59] awesome [17:18:38] Amir1, http://ores-staging.wmflabs.org/v2/#/default [17:18:53] http://ores-staging.wmflabs.org/v2/spec/ [17:19:01] Yay! It worked! [17:20:03] \o/ [17:20:07] to the extension [17:21:02] halfak: how I can get spec with UI? [17:42:45] http://ores-staging.wmflabs.org/v2/spec/ [17:42:53] http://ores-staging.wmflabs.org/v2/ [17:43:46] Amir1, ^ [17:44:26] I'm going to head out for a bit to talk the dog out. [17:44:30] Will likely be back in a few hours. [17:44:48] okay [17:45:00] I will be working on the extension in the mean time [18:07:11] (03PS1) 10Ladsgroup: Support wikis when $wgUseRCPatrol = false [extensions/ORES] - 10https://gerrit.wikimedia.org/r/278751 (https://phabricator.wikimedia.org/T130150) [18:55:12] akosiaris: looks like there has been a lot of work done on the wheels deployment setups [18:55:54] yup I 've seen it moving forward quite happily [18:57:49] Amir1: add akosiaris too to the puppet patches you want reviewed [18:58:09] sure [18:58:12] thanks [18:58:15] \o/ [18:59:21] yuvipanda: we might need to add some extra configuration WRT using scap3 when we are in prod [18:59:31] mostly permission and stuff like that [19:06:09] (03CR) 10Ladsgroup: [C: 04-1] "It seems when $wgUseRCPatrol is disabled, all edits have rc_patrolled = 0 and not 1 which mean we already support those wikis the same way" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/278751 (https://phabricator.wikimedia.org/T130150) (owner: 10Ladsgroup) [19:09:29] akosiaris: added you :) [19:19:13] Amir1: merged 1, reviewed 2 [19:23:49] awesome, thanks [20:14:35] (03Abandoned) 10Ladsgroup: Support wikis when $wgUseRCPatrol = false [extensions/ORES] - 10https://gerrit.wikimedia.org/r/278751 (https://phabricator.wikimedia.org/T130150) (owner: 10Ladsgroup) [20:53:15] halfak: tell me if you're around [23:46:55] (03PS1) 10Ladsgroup: Let user make hidenondamaging default [extensions/ORES] - 10https://gerrit.wikimedia.org/r/278839 (https://phabricator.wikimedia.org/T130560) [23:58:29] (03CR) 10Ladsgroup: "you can test it in https://mw-revscoring.wmflabs.org/" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/278839 (https://phabricator.wikimedia.org/T130560) (owner: 10Ladsgroup)