[13:33:19] <travis-ci>	 wiki-ai/revscoring#652 (master - 9e7144c : Amir Sarabadani): The build was broken. https://travis-ci.org/wiki-ai/revscoring/builds/122048208
[14:18:48] <halfak>	 o/ 
[14:18:52] <halfak>	 Reviewing wikilabels stuff now. 
[14:19:02] <halfak>	 I don't have long to work, but I want to unblock amir1
[14:19:12] <Amir1>	 awesome
[14:19:27] <Amir1>	 halfak: I actually wrote somewhere why I did that
[14:19:32] <Amir1>	 but I can't find it
[14:19:49] <Amir1>	 how are you by the way?
[14:20:10] <halfak>	 Good!  Glad to see the Hindi stuff merged.  That was really difficult. 
[14:20:24] <halfak>	 I wish I had sumit's comment before I dug into signing character ranges. 
[14:20:43] <Amir1>	 OK. I can't find it
[14:21:23] <Amir1>	 my reasons is that we can use it as a an attribute in the db object later (and in other scripts, as you can see) 
[14:21:55] <Amir1>	 the difference is we know this logger is for DB and not for something else (assuming we have other loggers too)
[14:22:07] <halfak>	 Yeah...  I like this, but I think that we should abstract more aggressively to give us flexibility later. 
[14:22:11] <halfak>	 One sec. 
[14:22:12] <Amir1>	 it's a common practice in mediawiki
[14:22:23] <Amir1>	 but I wasn't sure it would be good here
[14:22:26] <halfak>	 See https://github.com/wiki-ai/ores/tree/master/ores/metrics_collectors
[14:22:50] <halfak>	 I think this pattern will work well for us. 
[14:23:09] <halfak>	 e.g. datasources_extracted(self, context, model, version, rev_id_count, duration)
[14:23:22] <halfak>	 Could fire a log event or could send structured data to statsd
[14:24:39] <Amir1>	 hmm
[14:25:42] <Amir1>	 I think I need to read these code in more depth and implement them in wikilabels later
[14:26:09] <Amir1>	 I need to wrap my head around it
[14:26:31] <halfak>	 Either way, I think this is good to merge. 
[14:34:13] <halfak>	 Amir1, I'm confused by https://github.com/wiki-ai/wikilabels/pull/104
[14:35:02] <Amir1>	 halfak: thanks for asking
[14:35:14] <Amir1>	 XHR.status is something like this: 200
[14:35:16] <Amir1>	 or 404
[14:35:18] <Amir1>	 403
[14:35:45] <Amir1>	 but status is a string like "error"
[14:35:51] <halfak>	 Oh!  Gotcha. 
[14:38:35] <Amir1>	 \o/
[14:38:40] <Amir1>	 thanks halfak 
[14:40:53] <halfak>	 Amir1, have any thoughts about this? https://github.com/wiki-ai/wikilabels/pull/103/files#r59134682
[14:42:00] <Amir1>	 I'm okay with changing it
[14:42:08] <Amir1>	 let me do that real quick
[14:42:37] <halfak>	 kk
[15:08:00] <Amir1>	 halfak: ^
[15:10:20] <Amir1>	 \o/
[15:11:27] <halfak>	 :D
[15:12:44] <Amir1>	 I'm making a card about structured logging
[15:13:15] <halfak>	 Awesome :) 
[15:33:05] <Amir1>	 halfak: https://phabricator.wikimedia.org/T132295
[15:33:11] <Amir1>	 for when you're back
[16:36:39] <Amir1>	 halfak: oh, btw, I made the Japanese too but the best thing turned out to be Logistic regression which we don't have scorer (or we have and I didn't find it) 
[16:36:47] <Amir1>	 so I made it with gradent boost
[17:58:20] <halfak>	 Amir1, that's very unusual.  I suspect that something went wrong.  
[17:58:45] <halfak>	 Thanks for filing that task. :) 
[17:59:15] <halfak>	 I thought I was going to be able to come back and work for a bit, but it turns out that I need to do some yard work.  I'll be on telegram and not too far from my computer if you need something.