[03:43:15] halfak: congratulations on the dashboard! [12:07:46] Wow! It finally works! [13:06:24] Hey putnik [13:06:33] We just got it deployed. Sorry for the delay. [13:20:55] o/ Amir1 [13:21:09] I just heard that the Wikidata model is flagging everything as damaging. [13:21:27] putnik, are you using ScoredRevisions? [13:23:45] ^ putnik [13:24:37] https://qsnapnet.com/snaps/swlpzhjttymn29 [13:25:15] Yes, it's ScoredRevisions. [13:26:12] OK. Checking on that. I bet the thresholds are set wrong. The wikidata prediction model is trained in a different way than the rest. [13:27:08] 06Revision-Scoring-As-A-Service, 10rsaas-editquality: ScoredRevisions flags everything on Wikidata - https://phabricator.wikimedia.org/T133903#2248452 (10Halfak) [13:27:21] https://phabricator.wikimedia.org/T133903 [13:28:20] Looks like we might need a wikidata admin to set up a config var called ScoredRevisionsThresholds [13:37:35] addshore: ^ [13:37:46] =p [13:37:46] 04Error: Command “p” not recognized. Please review and correct what you’ve written. [13:37:49] =o [13:37:49] 04Error: Command “o” not recognized. Please review and correct what you’ve written. [13:38:32] set a var where? [13:47:01] halfak: hey [13:47:26] I just woke up, my last night incidient totally messed my sleeping time [13:47:29] anyway [13:47:34] waaatt? [13:47:58] halfak: I'm adming in wikidata [13:48:02] addshore, we have a lot of people loading the ScoreRevisions gadget from meta. [13:48:28] via their global.js [13:48:41] and wikidata needs some special configuration in order for it to work right, [13:48:52] So we'd like to get a config var before the JS for the gadget loads. [13:49:26] we can do that via common.js [13:49:37] but I'm not sure it the best way [13:49:40] Across the whole site? That would work OK. this isn't much data. [13:49:50] But yeah. I'd like to do this the Right(TM) way [13:50:33] Var will look like {low: 0.8, med: 0.9, high: 0.95} [13:51:17] yeah, we have it set up in fa.wp [13:51:17] but the holw thing is a gadget [13:51:17] *whole [14:05:10] addshore, any thoughts on whether it would be OK to put this config into MediaWiki:Common.js or not? [14:05:26] it doesn't sound too terrible [14:06:24] okay [14:06:34] I'm putting it there right now [14:09:29] Great! Thanks Amir1. [14:09:36] I think this will solve the problem putnik raised. [14:27:30] halfak: https://www.wikidata.org/w/index.php?title=MediaWiki:Common.js&diff=326198314&oldid=321529339 [14:34:37] 06Revision-Scoring-As-A-Service, 10rsaas-editquality: ScoredRevisions flags everything on Wikidata - https://phabricator.wikimedia.org/T133903#2248452 (10Ladsgroup) [[https://www.wikidata.org/w/index.php?title=MediaWiki:Common.js&diff=326198314&oldid=321529339 | This edit]] should fix it. [14:34:38] 10[1] 04https://meta.wikimedia.org/wiki/https://www.wikidata.org/w/index.php%3Ftitle%3DMediaWiki:Common.js%26diff%3D326198314%26oldid%3D321529339 [14:38:43] 06Revision-Scoring-As-A-Service, 10rsaas-editquality: ScoredRevisions flags everything on Wikidata - https://phabricator.wikimedia.org/T133903#2248672 (10Halfak) a:03Halfak [14:39:04] 06Revision-Scoring-As-A-Service, 10rsaas-editquality: ScoredRevisions flags everything on Wikidata - https://phabricator.wikimedia.org/T133903#2248452 (10Halfak) Confirmed. Works great. @putnik, I'm going to resolve. Feel free to re-open and thanks for reporting! [14:39:19] 06Revision-Scoring-As-A-Service, 10rsaas-editquality: ScoredRevisions flags everything on Wikidata - https://phabricator.wikimedia.org/T133903#2248674 (10Halfak) [14:39:57] halfak: I'm working on this right now [14:39:57] https://github.com/wiki-ai/wikilabels-wikimedia-config/pull/24/files#diff-18f97e5cf2fcbd56e07b3cda3b8e289cR2 [14:40:05] it should be very simple by puppet [14:40:22] 06Revision-Scoring-As-A-Service, 10rsaas-editquality: ScoredRevisions flags everything on Wikidata - https://phabricator.wikimedia.org/T133903#2248676 (10putnik) It looks good now. {F3942500} [14:40:28] Amir1, we have a command in the fabfile.py that moves those configs to the right spot. [14:41:05] yeah, I can imagine fabric is able to this job as well [14:41:14] but we have labels-experiment [14:41:38] and it doesn't work properly in this machine [14:41:51] it's your call halfak [14:42:41] https://github.com/wiki-ai/wikilabels-wikimedia-config/blob/master/fabfile.py#L149 [14:43:06] I'd say stick with what we have now and make proposals/discussion for how to make it better [14:43:20] I can imagine puppet working nicely too. [14:44:15] Oh! We need to not have puppet write the configs because they contain passwords. [14:44:36] heh. I have some secret files on my machine that I can share with you or you can just grab from our servers. [14:45:00] e.g. wmflabs/98-oauth.yaml and wmflabs/97-database.yaml [14:45:51] I think these should be uploaded into the private repo [14:46:07] then I can invoke it from puppet [14:46:38] but I'm not sure how safe is the private repo, YuviPanda might know better [14:47:07] Yeah. I asked about that and YuviPanda said "no private repos for labs" or something to that tune. [14:49:25] I know the puppetmaster in the beta cluster has access to the repo [14:49:36] but I'm not sure about other ones [14:50:24] halfak: In that case it's impossible to make a config file without uploading those configs to the puppet repo and that's not obviously what we want [14:51:36] Yeah. So uploading directly from dev machine is what we have :/ [14:52:35] sine we have only one node, and our plan is to deprecate it and integrate the whole thing with an extension (db, etc.) eventually I think that's bearable [14:53:30] btw: I updated this patch https://github.com/wiki-ai/wikilabels/pull/114 [14:53:41] it would be great to take a look at this [14:57:41] Amir1, looking at this more carefully, it seems like we "abandon" a label. [14:57:49] It seems like we should "abandon" a task. [14:58:32] It abandons a task [14:59:10] Have you tried some tests with it? [15:01:21] Yeah, just thinking about how Label gets flagged as "completed" [15:01:27] Rather than the Task [15:01:51] oh [15:02:00] you mean in the UI [15:02:11] We might want to just merge this as "working" and flag the part of the system as in need of refactoring. [15:02:33] the problem is that actually task.complete() actually runs label.complete() [15:02:43] I can move it to a upper level in the JS [15:03:36] it starts from here [15:03:36] https://github.com/wiki-ai/wikilabels/blob/master/wikilabels/wsgi/static/js/wikiLabels/Workspace.js#L284 [15:03:55] https://github.com/wiki-ai/wikilabels/blob/master/wikilabels/wsgi/static/js/wikiLabels/Workspace.js#L346 [15:04:11] and finally https://github.com/wiki-ai/wikilabels/blob/master/wikilabels/wsgi/static/js/wikiLabels/Workspace.js#L363 [15:05:51] * halfak starts his sequence of meetings. [16:31:02] halfak: Amir1 there's a hack of sorts for private stuff for labs that madhuvishy used for wikimetrics [16:31:55] madhuvishy helped me set up the fab-based upload of creds\. So it seems she still recommended that pattern as recently as a couple months ago. [16:32:56] halfak: yeah the private repo stuff is slightly more complicated - if you want to go that route - i'm happy to rework the fab stuff around it [16:33:32] Generally, I'd like to keep things simple [16:35:51] halfak: let me share the wikimetrics-deploy code and you can see how it's set up - the only reason we went that way was to keep secrets at a location like git where it cant go missing from, and to make it easy for other people to get the creds without emailing/scp etc [16:36:14] https://github.com/wikimedia/analytics-wikimetrics-deploy [16:45:07] Gotcha. Thanks. [16:53:10] 10Revision-Scoring-As-A-Service-Backlog, 10ores, 10wikilabels, 07JavaScript: When Chrome is preventing the pop-out window , the code is stuck ! - https://phabricator.wikimedia.org/T131667#2249017 (10Ghassanmas) [16:54:01] 06Revision-Scoring-As-A-Service, 10ores, 10wikilabels, 07JavaScript: When Chrome is preventing the pop-out window , the code is stuck ! - https://phabricator.wikimedia.org/T131667#2174235 (10Ghassanmas) [18:30:25] thanks for the help madhuvishy and YuviPanda :) [18:30:45] 10Revision-Scoring-As-A-Service-Backlog, 10wikilabels, 07JavaScript: When Chrome is preventing the pop-out window , the code is stuck ! - https://phabricator.wikimedia.org/T131667#2249345 (10Ladsgroup) [18:43:55] halfak: what do you think of my comment regarding abandoning a label vs. abandoning a task [18:44:05] (before your meetings start) [19:02:14] Just finished presenting at metrics. :) [19:03:25] Hmmm... Seems like we want Label.hasData() and task.isComplete() [19:03:54] task.isComplete() returns true if task.isAbandoned() or label.hasData() returns True. [19:03:58] Amir1, ^ [19:04:00] What do you think? [19:10:16] halfak: hmm [19:10:45] I can implement it [19:10:51] won't be very hard [19:17:29] OK. Mostly just thinking out loud. [19:17:35] I don't want to make you do a bunch more work. [19:17:39] Amir1, ^ [19:17:45] We could save it for a future refactoring. [19:17:57] halfak: I have no preferences [19:18:07] both sounds good to me [19:18:09] kk lets do it then. [19:18:25] okay [19:18:27] on it [19:19:44] * halfak runs away for a bit [19:55:03] untested [19:55:08] (do it very soon) [22:08:20] wiki-ai/revscoring#685 (dict_speedup - 6fa5ab7 : halfak): The build passed. https://travis-ci.org/wiki-ai/revscoring/builds/126510654 [22:23:18] 06Revision-Scoring-As-A-Service, 06Research-and-Data, 10Research-management, 03RD-2016Q1: Revscoring on FY16 Research roadmap - https://phabricator.wikimedia.org/T106864#2250156 (10ggellerman) 05Open>03Resolved [22:23:20] 06Revision-Scoring-As-A-Service, 06Research-and-Data, 10Research-management, 03RD-2016Q1: Revscoring tasks from Wikimania discussions - https://phabricator.wikimedia.org/T106398#2250157 (10ggellerman) [22:23:33] 06Revision-Scoring-As-A-Service, 06Research-and-Data, 10Research-management, 03RD-2016Q1: Revscoring on FY16 Research roadmap - https://phabricator.wikimedia.org/T106864#2250158 (10Halfak) You can find it all here: https://phabricator.wikimedia.org/tag/revision-scoring-as-a-service-backlog/ [23:06:50] halfak: hey, if you're around. I just tested this: https://github.com/wiki-ai/wikilabels/commit/cec9be6d2998c6e12896745a001faf568f4ef366