[00:58:29] (03PS1) 10Catrope: Factor out Cache::$classMap into $wgOresModelClasses [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306316 [01:10:52] (03CR) 10Krinkle: Factor out Cache::$classMap into $wgOresModelClasses (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306316 (owner: 10Catrope) [09:00:35] (03CR) 10Thiemo Mättig (WMDE): "It looks like this code could have at least some tests when you start extracting functionality in public functions (or even other classes)" (032 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306316 (owner: 10Catrope) [10:35:22] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES: Edits being flagged by review tool on enwiki aren't likely to be damaging - https://phabricator.wikimedia.org/T143738#2577355 (10Ladsgroup) Per [[ https://ores.wikimedia.org/v2/scores/enwiki/damaging/?model_info | model info]] I set the high (defaul... [12:37:46] halfak: around? [13:41:02] halfak: we deployed the change [13:41:08] but it doesn't work properly [13:41:19] I guess it's some kind of caching [13:41:22] I'm checking [13:43:47] o/ [13:44:35] found the issue [13:46:52] Arg. [13:46:59] Something we can work around easily? [13:52:41] I just saw in -operations that the change will go out in 4 hours [13:52:54] Amir1, do you think about doing the ORES deploy today? [13:53:08] Not sure [13:53:30] Specially it requires lots and lots of maintenance scripts here and there [13:53:35] One thing we can do [13:53:36] So, one thing I was wondering... How do the thresholds for ORES get captured in the review tool? [13:53:49] let's book a window [13:54:07] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 13Patch-For-Review: Edits being flagged by review tool on enwiki aren't likely to be damaging - https://phabricator.wikimedia.org/T143738#2577355 (10hashar) Got it deployed. According to eval.php `$wgOresDamagingDefault` is properly set to `soft`... [13:54:45] halfak: https://gerrit.wikimedia.org/r/#/c/306028/ [13:55:40] Cool. So we can update those in batch for a deployment. [13:56:37] We should get the new ORES deployed on beta and update these thresholds there [13:56:39] Sound good? [13:57:12] yeah [13:57:24] but all of them should be done at probably the same time [13:57:45] so I think a deployment window would be good [14:10:39] Amir1, so I'm unclear on this. Does that mean we can do the services window today? [14:11:44] no, I mean we get a dedicated deployment window [14:11:46] Looks like there is a MediaWiki train today. [14:11:56] And then services right afterwards [14:12:11] because it requires both deployment on services on wikipedia [14:12:24] the train goes every day [14:12:25] :D [14:12:44] Not on Fridays? [14:12:52] Or holidays [14:14:15] Amir1, OK if I do a Beta deployment of ORES? [14:14:34] hmm [14:14:38] yeah, [14:14:47] halfak: I think we should deploy in beta [14:14:54] and I run maintenance scripts [14:15:03] but please change testwiki models too [14:15:03] OK. Working on beta deploy now [14:15:12] Oh sure. Just increment version? [14:15:14] and increment their version [14:17:19] https://gerrit.wikimedia.org/r/306439 [14:17:21] Amir1, ^ [14:18:23] my connection is killing me [14:18:42] halfak: merged [14:18:52] Nice. [14:19:08] So, now there are people calling for RC Patrolling on English Wikipedia [14:19:28] I guess a RFC would be great [14:21:39] 10Revision-Scoring-As-A-Service-Backlog, 10MediaWiki-Patrolling, 10MediaWiki-extensions-ORES, 10MediaWiki-extensions-Patroller, 07Community-consensus-needed: Enable RC patrolling on trwiki - https://phabricator.wikimedia.org/T140475#2579040 (10Halfak) [14:23:36] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 13Patch-For-Review, 15User-Ladsgroup: Edits being flagged by review tool on enwiki aren't likely to be damaging - https://phabricator.wikimedia.org/T143738#2579041 (10Ladsgroup) a:03Ladsgroup [14:24:03] Amir1, I'm going to file a task and let others do an RFC [14:24:14] Awesome [14:25:36] halfak: The next deployment window for the threshold thing is 3:30 from now [14:26:00] In the mean time we can on the beta deployment [14:26:12] and I need to work on of WMDE patches [14:28:44] Sounds good. [14:29:02] I'm going to reply to this thread at VPT. [14:29:14] And I'll get the beta deploy right afterwards. [14:33:37] 06Revision-Scoring-As-A-Service, 10MediaWiki-Patrolling, 10MediaWiki-extensions-ORES, 07Community-consensus-needed: Enable RecentChanges patrolling on English Wikipedia - https://phabricator.wikimedia.org/T143791#2579077 (10Ladsgroup) [14:33:57] halfak: https://www.mediawiki.org/wiki/Extension:Patroller [14:34:03] https://www.mediawiki.org/wiki/File:SpecialPatrol.png [14:34:09] This is not that patrolling [14:34:19] Oh. [14:34:20] Woops [14:34:30] Got a good link? [14:37:38] Yeah [14:38:26] halfak: https://meta.wikimedia.org/wiki/Help:Patrolled_edit [14:49:07] Okay, the WMDE patch is done now [15:04:48] Working on beta deploy [15:15:18] awesome [15:15:21] Amir1, OK deploy to beta is complete :) [15:15:28] okay [15:15:56] I'm testing things [15:16:04] It might take some time [15:39:27] halfak: okay, one of maintenance scripts is broken [15:39:33] reallly bad [15:39:33] :D [15:43:44] :S [15:48:21] Several issues here and there [15:48:30] each one of them requires a patch [16:02:21] the pipeline is reasonable and looks okay but I can't understand it doesn't work [16:02:52] also this one makes huge modifications to ores_classification table [16:03:02] definitely should not be ran in rush hours [16:06:47] Amir1, does it make the changes in batch? [16:07:03] in batches 1K [16:07:08] Cool [16:07:09] but still, big [16:07:26] 1k inserts should be sub-1 second [16:08:15] RoanKattouw: what's the mechanism that gets the data from ores into the database? yes, please add me to the task(s) as appropriate. regarding the pageview stuff, yeah, it's about having the pageview data (e.g., 1 day trend, 1 week trend, 1 month trend) readily available via api.php in a performant fashion [16:23:17] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 15User-Ladsgroup: Update model versions is badly broken in ORES extension - https://phabricator.wikimedia.org/T143798#2579398 (10Ladsgroup) [16:23:20] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 15User-Ladsgroup: Update model versions is badly broken in ORES extension - https://phabricator.wikimedia.org/T143799#2579413 (10Ladsgroup) [16:32:31] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 15User-Ladsgroup: Update model versions is badly broken in ORES extension - https://phabricator.wikimedia.org/T143799#2579413 (10Ladsgroup) 05Open>03Invalid [16:51:15] halfak: I go home continuing work on this [16:51:37] but this one looks super messy [16:51:48] possibly take one day or two to get that cleaned up [16:51:55] sorry to be bearer of bad news [17:00:23] (03PS1) 10Ladsgroup: Fix CheckModelVersions by changing order of actions [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306468 (https://phabricator.wikimedia.org/T143799) [17:00:52] (03CR) 10Ladsgroup: "Tested in mw-revscoring.wmflabs.org" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306468 (https://phabricator.wikimedia.org/T143799) (owner: 10Ladsgroup) [17:04:02] legoktm: hey, this one is a little bit urgent (blocker for pushing new models) https://gerrit.wikimedia.org/r/306468 [17:04:10] I need to go now, for when you have some time :) [17:04:13] o/ [17:24:07] dr0ptp4kt: There's an extension called ORES that makes HTTP requests to the ORES service and stores scores in a DB table on demand [17:25:09] However, there's a fundamental difference between ORES data and page view data [17:25:30] RoanKattouw: yeah, the thought is, imagine if this were called for every single page on a day. understood on the difference. [17:25:44] ORES scores are per-revision and don't ever change, because the revision never changes (the model can change, so it's really stored per-model per-rev) [17:25:44] RoanKattouw: what's the thing that your code will be doing with ores? [17:25:52] Whereas page view data changes over time [17:26:12] page/month views? [17:26:16] ^ unchanging [17:26:29] Or we could have revision views! [17:26:32] I guess historical page view data is unchanging yes [17:26:34] Now that would be a hell of thing [17:26:42] but you may not want to store all of it [17:26:48] Then again, many current revisions are years old. [17:27:01] Also, the real reason we have ORES data in the DB IMO is so we can do filtering [17:27:08] "Show me RecentChanges but only revisions with a high ORES score" [17:27:32] ^ right [17:27:48] Doing that on-demand has unpredictable performance implications. [17:29:13] Whereas with page views, that's not really the main use case. You just want to know what the page view count is for a given page [17:29:23] Can the existing page view API not do that performantly? [17:30:33] RoanKattouw, I don't think the pageview count is that useful [17:30:45] Instead, I think you want a sense of "rate" and "trend" [17:31:05] Hmm I guess so [17:31:23] E.g. a page may have only been created last week so it hasn't racked up many pageviews, but it's been viewed at high "rate" and is "trend"ing upwards. [17:31:25] halfak: For the moment let's stop talking about page views and start talking about edit review in the ERI meeting ;) [17:31:46] \o/ [17:32:02] Not EIR anymore :) [18:03:04] legoktm: Allegedly you're working on an extension to do ... something with page view data? [18:03:19] dr0ptp4kt: You may be interested in the answer ---^^ [18:10:17] 06Revision-Scoring-As-A-Service, 10MediaWiki-Patrolling, 10MediaWiki-extensions-ORES, 07Community-consensus-needed: Enable RecentChanges patrolling on English Wikipedia - https://phabricator.wikimedia.org/T143791#2579840 (10Halfak) [18:11:32] dr0ptp4kt: Someone else helped me find https://www.mediawiki.org/wiki/Extension:WikimediaPageViewInfo , which may be interesting to you [18:25:03] RoanKattouw: Hey, do you have some time to review a trivial patch in the extension? [18:25:05] https://gerrit.wikimedia.org/r/#/c/306468/1/maintenance/CheckModelVersions.php [18:25:41] halfak: We are in "soft" mode from now on as default [18:25:58] * halfak hates that name [18:26:13] :D [18:32:10] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 13Patch-For-Review, 15User-Ladsgroup: Edits being flagged by review tool on enwiki aren't likely to be damaging - https://phabricator.wikimedia.org/T143738#2577355 (10Ladsgroup) 05Open>03Resolved [18:34:28] (03CR) 10Catrope: [C: 032] Fix CheckModelVersions by changing order of actions [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306468 (https://phabricator.wikimedia.org/T143799) (owner: 10Ladsgroup) [18:35:37] (03Merged) 10jenkins-bot: Fix CheckModelVersions by changing order of actions [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306468 (https://phabricator.wikimedia.org/T143799) (owner: 10Ladsgroup) [18:35:59] thanks [18:43:14] halfak: when you have some time, please make a note in VP/T [18:43:21] I'm working on the extension [18:55:32] halfak: I've got a puppet change -- https://gerrit.wikimedia.org/r/#/c/301505/ -- which includes a small change to service::uwsgi. I think that change will cause the ORES wsgi service to restart when puppet runs for the first time [18:55:48] Yuvi and I plan to deploy it this afternoon [19:27:15] bd808: hey, Can I see the change? [19:27:32] just to be sure it doesn't affect ores [19:27:41] https://gerrit.wikimedia.org/r/#/c/301505/ [19:28:09] line 134 in modules/service/manifests/uwsgi.pp [19:28:19] changing from "logto" to "logger" [19:28:40] mostly so I can make logging a bit nicer for Striker [19:29:28] I don't think it will break anything, but it will change the ini file and trigger a uwsgi restart [19:30:14] bd808: okay, Good luck and thanks for your work [19:30:49] the fancier logging that striker will be doing is in modules/striker/manifests/uwsgi.pp starting at line 59 [19:34:44] RoanKattouw: yeah, working on that. Still blocked-ish on getting it on beta cluster. [19:37:06] (03PS1) 10Ladsgroup: Fix for purging scores [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306494 (https://phabricator.wikimedia.org/T143798) [19:38:11] legoktm: https://gerrit.wikimedia.org/r/#/c/306494/ is super trivial [19:38:13] :D [19:39:41] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 13Patch-For-Review, 15User-Ladsgroup: Update model versions is badly broken in ORES extension - https://phabricator.wikimedia.org/T143798#2579398 (10Ladsgroup) [19:39:44] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 13Patch-For-Review, 15User-Ladsgroup, 05WMF-deploy-2016-08-30_(1.28.0-wmf.17): Update model versions is badly broken in ORES extension - https://phabricator.wikimedia.org/T143799#2580205 (10Ladsgroup) [19:39:51] looking [19:39:55] how are things going? [19:40:14] good, we deployed in enwiki [19:40:24] did you test that? [19:40:33] this patch? yes [19:41:30] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES: Unclear header for ORES options in Preferences - https://phabricator.wikimedia.org/T143822#2580219 (10Ladsgroup) [19:41:59] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES: Unclear header for ORES options in Preferences - https://phabricator.wikimedia.org/T143822#2580206 (10Ladsgroup) Hey, do you mean in preferences or beta features part? [19:42:36] (03CR) 10Legoktm: [C: 032] Fix for purging scores [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306494 (https://phabricator.wikimedia.org/T143798) (owner: 10Ladsgroup) [19:42:43] yesss [19:42:44] thanks [19:44:09] so I guess the model update didn't go properly? [19:44:51] nah, We haven't deployed it yet [19:45:02] but I guessed it might not work properly [19:45:07] so tried in beta [19:45:12] and it was a mess [19:45:25] It's smooth and okay now [19:46:06] (03Merged) 10jenkins-bot: Fix for purging scores [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306494 (https://phabricator.wikimedia.org/T143798) (owner: 10Ladsgroup) [19:49:54] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 13Patch-For-Review, 15User-Ladsgroup: Edits being flagged by review tool on enwiki aren't likely to be damaging - https://phabricator.wikimedia.org/T143738#2580263 (10hashar) Well done @Ladsgroup [19:52:45] ok, I'm going afk for a bit for lunch [19:53:42] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 13Patch-For-Review, 15User-Ladsgroup: Edits being flagged by review tool on enwiki aren't likely to be damaging - https://phabricator.wikimedia.org/T143738#2580318 (10Ladsgroup) Thanks @hashar :) [19:55:58] (03PS1) 10Ladsgroup: Remove deprecated config [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306500 [20:10:37] (03CR) 10Ladsgroup: [C: 032] Remove deprecated config [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306500 (owner: 10Ladsgroup) [20:12:46] (03Merged) 10jenkins-bot: Remove deprecated config [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306500 (owner: 10Ladsgroup) [20:20:38] (03CR) 10Ladsgroup: Factor out Cache::$classMap into $wgOresModelClasses (033 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306316 (owner: 10Catrope) [20:20:52] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES: Unclear header for ORES options in Preferences - https://phabricator.wikimedia.org/T143822#2580422 (10kaldari) In Recent Changes preferences (and just the header). [20:22:52] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 07Easy, 15User-Ladsgroup: Unclear header for ORES options in Preferences - https://phabricator.wikimedia.org/T143822#2580423 (10Ladsgroup) p:05Triage>03Normal a:03Ladsgroup [20:23:00] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 07Easy, 15User-Ladsgroup: Unclear header for ORES options in Preferences - https://phabricator.wikimedia.org/T143822#2580428 (10Ladsgroup) I do it :) [21:27:08] 10Revision-Scoring-As-A-Service-Backlog, 10MediaWiki-extensions-ORES: Inject ores scores to rc-data - https://phabricator.wikimedia.org/T143611#2573377 (10Legoktm) Errrr, I'm confused. Can you explain the problem that needs fixing? [21:28:41] PROBLEM - ORES web node labs ores-web-05 on ores.wmflabs.org is CRITICAL: HTTP CRITICAL: HTTP/1.1 502 Bad Gateway - 324 bytes in 0.076 second response time [21:54:11] RECOVERY - ORES web node labs ores-web-05 on ores.wmflabs.org is OK: HTTP OK: HTTP/1.1 200 OK - 353 bytes in 1.134 second response time [21:56:46] 10Revision-Scoring-As-A-Service-Backlog, 10MediaWiki-extensions-ORES: Request scores when someone checks out edits that are not stored in ores_classification - https://phabricator.wikimedia.org/T143612#2573392 (10Legoktm) Is this a duplicate of {T131785}? Or subtask? [22:14:47] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES: ORES extension should Assume good faith page creator's revisions - https://phabricator.wikimedia.org/T137846#2580747 (10Iniquity) >>! In T137846#2571165, @Ladsgroup wrote: > @Iniquity. Hey, Can you explain more? Hi, in Russia Wikipedia we have 'ed... [23:36:24] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 10ORES, 07Epic, 03Research-and-Data-2017-Q1: [Epic] Deploy ORES review tool - https://phabricator.wikimedia.org/T140002#2580909 (10Legoktm) [23:36:27] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 10Wikimedia-Site-requests, 07Beta-Feature, and 2 others: Deploy ORES review tool in English Wikipedia - https://phabricator.wikimedia.org/T140003#2580908 (10Legoktm) 05Open>03Resolved