[05:12:44] (03PS2) 10Ladsgroup: Factor out Cache::$classMap into $wgOresModelClasses [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306316 (owner: 10Catrope) [05:15:02] (03CR) 10Ladsgroup: [C: 032] Factor out Cache::$classMap into $wgOresModelClasses [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306316 (owner: 10Catrope) [05:15:54] (03Merged) 10jenkins-bot: Factor out Cache::$classMap into $wgOresModelClasses [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306316 (owner: 10Catrope) [05:16:31] (03CR) 10Ladsgroup: [C: 032] Add UNIQUE indexes to ores_classification [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306854 (https://phabricator.wikimedia.org/T143962) (owner: 10Catrope) [05:16:37] (03CR) 10jenkins-bot: [V: 04-1] Add UNIQUE indexes to ores_classification [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306854 (https://phabricator.wikimedia.org/T143962) (owner: 10Catrope) [05:17:38] (03PS2) 10Ladsgroup: Add UNIQUE indexes to ores_classification [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306854 (https://phabricator.wikimedia.org/T143962) (owner: 10Catrope) [05:18:16] (03CR) 10Ladsgroup: Add UNIQUE indexes to ores_classification [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306854 (https://phabricator.wikimedia.org/T143962) (owner: 10Catrope) [05:19:22] (03CR) 10Ladsgroup: "recheck" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306854 (https://phabricator.wikimedia.org/T143962) (owner: 10Catrope) [05:19:39] (03CR) 10Ladsgroup: "oops :D" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306854 (https://phabricator.wikimedia.org/T143962) (owner: 10Catrope) [05:20:34] (03CR) 10Ladsgroup: [C: 032] Add UNIQUE indexes to ores_classification [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306854 (https://phabricator.wikimedia.org/T143962) (owner: 10Catrope) [05:21:28] (03Merged) 10jenkins-bot: Add UNIQUE indexes to ores_classification [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306854 (https://phabricator.wikimedia.org/T143962) (owner: 10Catrope) [05:24:45] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 07Schema-change: Do the schema changes for uniqueness constraints. - https://phabricator.wikimedia.org/T145317#2626359 (10Ladsgroup) [07:53:39] (03CR) 10Legoktm: "This is breaking beta cluster:" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306854 (https://phabricator.wikimedia.org/T143962) (owner: 10Catrope) [08:02:31] (03CR) 10Ladsgroup: "I'm guessing that's because there are some incorrect data in the beta cluster db needing clean up." [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306854 (https://phabricator.wikimedia.org/T143962) (owner: 10Catrope) [08:02:51] legoktm: revert or db cleanup? [08:03:02] let me run the clean up script [08:07:06] Amir1: whatever you think is appropriate [08:07:23] Amir1: is it possible that there's bad data in a production db? [08:08:03] It's quite possible. Because I don't think we have ran the maintenance scripts we should have [08:10:54] ok, then we should make sure those happen before the schema change [08:11:05] yeah, definitely [08:36:40] (03CR) 10Ladsgroup: "No, it's not bad data. Reverting." [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306854 (https://phabricator.wikimedia.org/T143962) (owner: 10Catrope) [08:36:53] (03PS1) 10Ladsgroup: Revert "Add UNIQUE indexes to ores_classification" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/309818 [08:40:04] (03CR) 10Legoktm: [C: 032] Revert "Add UNIQUE indexes to ores_classification" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/309818 (owner: 10Ladsgroup) [08:40:49] (03Merged) 10jenkins-bot: Revert "Add UNIQUE indexes to ores_classification" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/309818 (owner: 10Ladsgroup) [09:40:14] (03CR) 10Ladsgroup: "Before re-introducing this I think we need a maintenance script to do the job of cleaning up duplicate rows for us." [extensions/ORES] - 10https://gerrit.wikimedia.org/r/306854 (https://phabricator.wikimedia.org/T143962) (owner: 10Catrope) [09:41:21] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 07Schema-change: Do the schema changes for uniqueness constraints. - https://phabricator.wikimedia.org/T145317#2626564 (10Ladsgroup) The main patch got reverted. [10:43:19] (03PS1) 10Ladsgroup: Move storeScores stuff into another method [extensions/ORES] - 10https://gerrit.wikimedia.org/r/309824 [11:34:01] (03PS1) 10Ladsgroup: Drop unique part from oresm_model index [extensions/ORES] - 10https://gerrit.wikimedia.org/r/309825 (https://phabricator.wikimedia.org/T144432) [13:40:44] (03PS1) 10Ladsgroup: Revert "Revert "Add UNIQUE indexes to ores_classification"" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/309837 [13:41:52] (03CR) 10Ladsgroup: "I checked, it was bad data first, then it was the lack of old the index that got deleted causing error. I added old index manually again (" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/309837 (owner: 10Ladsgroup) [13:41:56] (03CR) 10Ladsgroup: [C: 032] Revert "Revert "Add UNIQUE indexes to ores_classification"" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/309837 (owner: 10Ladsgroup) [13:42:52] (03Merged) 10jenkins-bot: Revert "Revert "Add UNIQUE indexes to ores_classification"" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/309837 (owner: 10Ladsgroup) [14:26:38] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 13Patch-For-Review, 07Schema-change, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Add uniqueness constraints to ores_classification - https://phabricator.wikimedia.org/T143962#2584746 (10Ladsgroup) Okay. It was only bad data in the beta cluster. W... [15:14:05] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 13Patch-For-Review, 07Schema-change, 05WMF-deploy-2016-09-13_(1.28.0-wmf.19): Add uniqueness constraints to ores_classification - https://phabricator.wikimedia.org/T143962#2626776 (10jcrespo) [15:14:08] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 07Schema-change: Do the schema changes for uniqueness constraints. - https://phabricator.wikimedia.org/T145317#2626774 (10jcrespo) 05Open>03Invalid @Ladsgroup You have assigned what I assume is something related to a schema change. This is not... [15:48:11] 06Revision-Scoring-As-A-Service, 10rsaas-articlequality , 03Research-and-Data-2017-Q1, 15User-Ladsgroup: Generate recent article quality scores for English Wikipedia - https://phabricator.wikimedia.org/T135684#2626804 (10DarTar) [16:12:00] 06Revision-Scoring-As-A-Service, 10Data-release, 06Research-and-Data, 10rsaas-articlequality : Publish article quality score dataset - https://phabricator.wikimedia.org/T145332#2626819 (10DarTar) [16:12:54] 06Revision-Scoring-As-A-Service, 10Data-release, 06Research-and-Data, 10rsaas-articlequality : Publish article quality score dataset - https://phabricator.wikimedia.org/T145332#2626836 (10DarTar) [16:12:56] 06Revision-Scoring-As-A-Service, 10rsaas-articlequality , 03Research-and-Data-2017-Q1, 15User-Ladsgroup: Generate recent article quality scores for English Wikipedia - https://phabricator.wikimedia.org/T135684#2306938 (10DarTar) [16:13:15] 06Revision-Scoring-As-A-Service, 10rsaas-articlequality , 03Research-and-Data-2017-Q1, 15User-Ladsgroup: Generate recent article quality scores for English Wikipedia - https://phabricator.wikimedia.org/T135684#2306938 (10DarTar) [16:14:10] 06Revision-Scoring-As-A-Service, 10Data-release, 06Research-and-Data, 10rsaas-articlequality , 03Research-and-Data-2017-Q1: Publish article quality score dataset - https://phabricator.wikimedia.org/T145332#2626819 (10DarTar) [16:38:53] 06Revision-Scoring-As-A-Service, 10Data-release, 06Research-and-Data, 10rsaas-articlequality , 03Research-and-Data-2017-Q1: Publish article quality score dataset - https://phabricator.wikimedia.org/T145332#2626890 (10DarTar) I was thinking the AQ score dataset would be good material for a short blog post... [16:52:32] 06Revision-Scoring-As-A-Service, 10Data-release, 06Research-and-Data, 10rsaas-articlequality , 03Research-and-Data-2017-Q1: Publish article quality score dataset - https://phabricator.wikimedia.org/T145332#2626913 (10Ladsgroup) Forgive me if my question is a little bit stupid but It's already in datasets... [16:59:19] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 07Schema-change: Do the schema changes for uniqueness constraints. - https://phabricator.wikimedia.org/T145317#2626920 (10Ladsgroup) I'm sorry. I've got distracted by several (personal) stuff today. Sorry. I will do it soon with more careful thought. [17:07:25] 06Revision-Scoring-As-A-Service, 10Data-release, 06Research-and-Data, 10rsaas-articlequality , 03Research-and-Data-2017-Q1: Publish article quality score dataset - https://phabricator.wikimedia.org/T145332#2626922 (10DarTar) For all our major data releases we create a registry entry in [[ https://figshar... [17:07:36] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 07Schema-change: Do the schema changes for uniqueness constraints. - https://phabricator.wikimedia.org/T145317#2626923 (10jcrespo) @Ladsgroup do not apologize; you did nothing wrong- but if you need help from me I beg you to use the above recommen... [17:08:04] 06Revision-Scoring-As-A-Service, 10Data-release, 06Research-and-Data, 10rsaas-articlequality , 03Research-and-Data-2017-Q1: Publish article quality score dataset - https://phabricator.wikimedia.org/T145332#2626924 (10DarTar) @Ladsgroup I realize I should document the process (and benefits) somewhere on w... [17:09:20] 06Revision-Scoring-As-A-Service, 10Data-release, 06Research-and-Data, 10rsaas-articlequality , 03Research-and-Data-2017-Q1: Publish article quality score dataset - https://phabricator.wikimedia.org/T145332#2626925 (10DarTar) >>! In T145332#2626913, @Ladsgroup wrote: > I was thinking that having a table i... [18:00:10] 06Revision-Scoring-As-A-Service, 10Data-release, 06Research-and-Data, 10rsaas-articlequality , 03Research-and-Data-2017-Q1: Publish article quality score dataset - https://phabricator.wikimedia.org/T145332#2626974 (10Nettrom) I think there's two AQ datasets going around. One is the one @Ladsgroup pointed... [19:09:57] 06Revision-Scoring-As-A-Service, 10Data-release, 06Research-and-Data, 10rsaas-articlequality , 03Research-and-Data-2017-Q1: Publish article quality score dataset - https://phabricator.wikimedia.org/T145332#2626996 (10DarTar) @Nettrom agreed, we should definitely reference the 2015 one (maybe cross-link t...