[03:02:45] (03CR) 10Catrope: Only make hidenondamaging available if damaging is enabled (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/310475 (owner: 10Catrope) [03:19:31] (03PS1) 10Catrope: Use aliases with "damaging" in them so we can add other ones (e.g. "goodfaith") [extensions/ORES] - 10https://gerrit.wikimedia.org/r/312164 [03:19:34] (03PS1) 10Catrope: Only pull in damaging scores when damaging model is enabled [extensions/ORES] - 10https://gerrit.wikimedia.org/r/312165 [03:20:48] (03CR) 10jenkins-bot: [V: 04-1] Only pull in damaging scores when damaging model is enabled [extensions/ORES] - 10https://gerrit.wikimedia.org/r/312165 (owner: 10Catrope) [03:21:00] (03CR) 10jenkins-bot: [V: 04-1] Use aliases with "damaging" in them so we can add other ones (e.g. "goodfaith") [extensions/ORES] - 10https://gerrit.wikimedia.org/r/312164 (owner: 10Catrope) [03:24:48] (03PS1) 10Catrope: [WIP] Add goodfaith filtering [extensions/ORES] - 10https://gerrit.wikimedia.org/r/312166 (https://phabricator.wikimedia.org/T137966) [03:25:53] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add goodfaith filtering [extensions/ORES] - 10https://gerrit.wikimedia.org/r/312166 (https://phabricator.wikimedia.org/T137966) (owner: 10Catrope) [07:27:45] 06Revision-Scoring-As-A-Service, 10Edit-Review-Improvements, 10rsaas-editquality, 03Collab-Team-Q1-July-Sep-2016: Research how to present ORES scores to users in a way that is understandable and meets their reviewing goals - https://phabricator.wikimedia.org/T146333#2658280 (10Pginer-WMF) For those not fol... [11:30:27] (03CR) 10Ladsgroup: Use STRAIGHT_JOIN to work around optimizer bug for hidenondamaging=1 (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/311637 (https://phabricator.wikimedia.org/T146111) (owner: 10Catrope) [13:20:47] (03CR) 10Thiemo Mättig (WMDE): Only make hidenondamaging available if damaging is enabled (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/310475 (owner: 10Catrope) [14:01:58] halfak: I'll join in five minutes [14:02:06] Amir1, sounds good. [14:02:07] grab a coffee [14:13:22] 06Revision-Scoring-As-A-Service, 10rsaas-articlequality : Generate monthly article quality dataset - https://phabricator.wikimedia.org/T145655#2658886 (10Halfak) Stat1003 got a reboot, so I'm trying to pick up where I left off. [14:27:06] 06Revision-Scoring-As-A-Service, 10DBA, 10MediaWiki-extensions-ORES: Ensure ORES data violating constraints do not affect production - https://phabricator.wikimedia.org/T145356#2659030 (10Halfak) [14:29:40] 06Revision-Scoring-As-A-Service, 10DBA, 10MediaWiki-extensions-ORES: Ensure ORES data violating constraints do not affect production - https://phabricator.wikimedia.org/T145356#2627432 (10Halfak) Assigning this to @Ladsgroup because it looks like the last thing to do is to run the maintenance script. We can... [14:30:08] 10Revision-Scoring-As-A-Service-Backlog, 10DBA, 10MediaWiki-extensions-ORES: Ensure ORES data violating constraints do not affect production - https://phabricator.wikimedia.org/T145356#2659065 (10Halfak) [14:31:46] 10Revision-Scoring-As-A-Service-Backlog, 10DBA, 10MediaWiki-extensions-ORES: Ensure ORES data violating constraints do not affect production - https://phabricator.wikimedia.org/T145356#2627432 (10Halfak) p:05Triage>03High [14:31:57] 10Revision-Scoring-As-A-Service-Backlog, 10DBA, 10MediaWiki-extensions-ORES, 15User-Ladsgroup: Ensure ORES data violating constraints do not affect production - https://phabricator.wikimedia.org/T145356#2659070 (10Halfak) a:03Ladsgroup [14:34:26] 10Revision-Scoring-As-A-Service-Backlog, 10MediaWiki-extensions-ORES, 10rsaas-editquality: [Spec] Use `reverted` models in ORES review tool - https://phabricator.wikimedia.org/T146378#2659073 (10Halfak) [14:37:35] 10Revision-Scoring-As-A-Service-Backlog, 10MediaWiki-extensions-ORES, 10rsaas-editquality: [Spec] Use `reverted` models in ORES review tool - https://phabricator.wikimedia.org/T146378#2659088 (10Halfak) @jmatazzoni, if we do something like this, that would extend the ORES review tool support to 24 wikis (up... [14:37:57] 10Revision-Scoring-As-A-Service-Backlog, 10MediaWiki-extensions-ORES, 10rsaas-editquality: [Spec] Use `reverted` models in ORES review tool - https://phabricator.wikimedia.org/T146378#2659073 (10Halfak) p:05Triage>03Normal [14:38:53] 10Revision-Scoring-As-A-Service-Backlog, 10DBA, 10MediaWiki-extensions-ORES, 15User-Ladsgroup: Ensure ORES data violating constraints do not affect production - https://phabricator.wikimedia.org/T145356#2659094 (10jcrespo) Can I have a look at it before it is run? It is very easy to create lag by accident,... [14:42:07] 10Revision-Scoring-As-A-Service-Backlog, 10MediaWiki-extensions-ORES, 15User-Ladsgroup: Use rc_timestamp index when joining to ores_classification - https://phabricator.wikimedia.org/T138444#2659098 (10Halfak) [14:42:23] 10Revision-Scoring-As-A-Service-Backlog, 10MediaWiki-extensions-ORES, 15User-Ladsgroup: Use rc_timestamp index when joining to ores_classification - https://phabricator.wikimedia.org/T138444#2400491 (10Halfak) [14:42:40] 06Revision-Scoring-As-A-Service, 10DBA, 10MediaWiki-extensions-ORES, 13Patch-For-Review, 07Performance: hidenondamaging=1 query is extremely slow on enwiki - https://phabricator.wikimedia.org/T146111#2650989 (10Halfak) [14:45:30] 06Revision-Scoring-As-A-Service, 10revscoring, 07Spike: [Spike] Investigate HashingVectorizer - https://phabricator.wikimedia.org/T128087#2659121 (10Halfak) [14:45:33] 10Revision-Scoring-As-A-Service-Backlog, 10rsaas-editquality: Implement ~100 most important hash vector features in editquality models - https://phabricator.wikimedia.org/T145812#2659120 (10Halfak) [14:45:59] 10Revision-Scoring-As-A-Service-Backlog, 10rsaas-editquality: Implement ~100 most important hash vector features in editquality models - https://phabricator.wikimedia.org/T145812#2641766 (10Halfak) p:05Triage>03Low [14:47:55] 10Revision-Scoring-As-A-Service-Backlog, 10revscoring, 10rsaas-editquality: [Research] What's the difference in scoring ranges when we don't balance sample weight? - https://phabricator.wikimedia.org/T145809#2659140 (10Halfak) p:05Triage>03Low [14:51:41] 06Revision-Scoring-As-A-Service, 10revscoring, 07Spike: [Spike] Investigate HashingVectorizer - https://phabricator.wikimedia.org/T128087#2659154 (10Halfak) [14:51:43] 10Revision-Scoring-As-A-Service-Backlog, 10rsaas-editquality, 07Spike: [Spike] Proof of concept damage detection with hash vectors - https://phabricator.wikimedia.org/T132581#2659156 (10Halfak) [14:52:10] 06Revision-Scoring-As-A-Service, 10ORES: Add a new grafana pane for timeout error metric - https://phabricator.wikimedia.org/T140363#2659157 (10Halfak) [14:53:10] 06Revision-Scoring-As-A-Service, 10revscoring: Implement abstraction for Sparse Feature Vectors - https://phabricator.wikimedia.org/T132580#2659163 (10Halfak) [14:53:12] 10Revision-Scoring-As-A-Service-Backlog, 10revscoring, 07Spike: [Spike] How to deal with large abstract feature vectors? - https://phabricator.wikimedia.org/T139978#2659165 (10Halfak) [14:54:02] 10Revision-Scoring-As-A-Service-Backlog, 10MediaWiki-extensions-ORES: ORES extension should show ORES prediction of wp10 model for articles in categories - https://phabricator.wikimedia.org/T124617#2659167 (10Halfak) [15:16:49] Amir1, do you have a change for that maintenance script? [15:16:58] https://phabricator.wikimedia.org/T145503 [15:17:13] Or should I just look at https://phabricator.wikimedia.org/diffusion/EORS/browse/master/maintenance/PopulateDatabase.php [15:22:53] 10Revision-Scoring-As-A-Service-Backlog, 10DBA, 10MediaWiki-extensions-ORES, 15User-Ladsgroup: Ensure ORES data violating constraints do not affect production - https://phabricator.wikimedia.org/T145356#2659254 (10Halfak) @jcrespo yes please. I'm confirming now what should be reviewed. [15:42:19] 06Revision-Scoring-As-A-Service, 10ORES: Add a new grafana pane for timeout error metric - https://phabricator.wikimedia.org/T140363#2462193 (10Halfak) 05Open>03Resolved [15:42:29] 06Revision-Scoring-As-A-Service, 10ORES: Add a new grafana pane for timeout error metric - https://phabricator.wikimedia.org/T140363#2462193 (10Halfak) Was actually resolved a long time ago. [15:47:05] Amir1, also please review when you get a chance: https://etherpad.wikimedia.org/p/ores_weekly_update [15:50:50] 06Revision-Scoring-As-A-Service, 10Edit-Review-Improvements, 10rsaas-editquality, 03Collab-Team-Q1-July-Sep-2016: Research how to present ORES scores to users in a way that is understandable and meets their reviewing goals - https://phabricator.wikimedia.org/T146333#2659312 (10Halfak) Very well said, @Pgin... [15:56:00] halfak \o [15:56:45] to which pages "pages_ids" to create the https://phabricator.wikimedia.org/T146284 list for [17:24:22] (03CR) 10Catrope: Use STRAIGHT_JOIN to work around optimizer bug for hidenondamaging=1 (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/311637 (https://phabricator.wikimedia.org/T146111) (owner: 10Catrope) [17:25:40] (03CR) 10Catrope: Only make hidenondamaging available if damaging is enabled (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/310475 (owner: 10Catrope) [17:32:43] halfak: sure [17:33:17] great. Thanks Amir1 [17:33:28] Sorry to miss your Q GhassanMas [17:38:28] halfak: Made some changes [17:40:28] Cool will post soon. [17:40:41] Amir1, did you see my Q re. maintenance script? [17:40:47] I don't know what to review :S [17:40:58] nope [17:41:14] you need to reply and then I can see it [17:42:43] It's in IRC. [17:42:48] Amir1, do you have a change for that maintenance script? [17:42:51] https://phabricator.wikimedia.org/T145503 [17:42:55] Or should I just look at https://phabricator.wikimedia.org/diffusion/EORS/browse/master/maintenance/PopulateDatabase.php [17:42:57] ^ Pasted [17:44:28] halfak: No, I meant my patch in the phab card that is in the review column [17:45:37] Isn't this the phab card? https://phabricator.wikimedia.org/T145503 [17:45:48] I don't see a patch linked. [17:49:12] that shouldn't happen [17:49:40] OMG I haven't pushed the patch [17:50:03] lol [17:50:04] \o/ [17:51:17] 06Revision-Scoring-As-A-Service, 10revscoring: Train on all data, Report test statistics on cross-validation - https://phabricator.wikimedia.org/T142953#2659655 (10Halfak) 05Open>03Resolved [17:51:22] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 13Patch-For-Review, 15User-Ladsgroup: Change default threshold for Wikidata to high - https://phabricator.wikimedia.org/T144784#2659656 (10Halfak) 05Open>03Resolved [17:51:27] 06Revision-Scoring-As-A-Service, 10ORES: Investigate short period of ores-web-03 insanity - https://phabricator.wikimedia.org/T145353#2659657 (10Halfak) 05Open>03Resolved [17:51:35] 10Revision-Scoring-As-A-Service-Backlog, 10rsaas-editquality: Implement ~100 most important hash vector features in editquality models - https://phabricator.wikimedia.org/T145812#2659659 (10Halfak) [17:51:37] 06Revision-Scoring-As-A-Service, 10revscoring, 07Spike: [Spike] Investigate HashingVectorizer - https://phabricator.wikimedia.org/T128087#2659658 (10Halfak) 05Open>03Resolved [17:51:41] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 13Patch-For-Review, 07Schema-change, and 2 others: oresm_model index should not be unique - https://phabricator.wikimedia.org/T144432#2659661 (10Halfak) 05Open>03Resolved [17:52:11] (03PS1) 10Ladsgroup: Add maintenance/CleanDuplicateScores.php [extensions/ORES] - 10https://gerrit.wikimedia.org/r/312286 (https://phabricator.wikimedia.org/T145503) [17:52:18] (03CR) 10jenkins-bot: [V: 04-1] Add maintenance/CleanDuplicateScores.php [extensions/ORES] - 10https://gerrit.wikimedia.org/r/312286 (https://phabricator.wikimedia.org/T145503) (owner: 10Ladsgroup) [17:53:38] afk for dinner [17:55:51] 10Revision-Scoring-As-A-Service-Backlog, 10DBA, 10MediaWiki-extensions-ORES, 15User-Ladsgroup: Ensure ORES data violating constraints do not affect production - https://phabricator.wikimedia.org/T145356#2659682 (10Halfak) @jcrespo see T145503#2659669 which references https://gerrit.wikimedia.org/r/#/c/312286/ [18:47:18] 10Revision-Scoring-As-A-Service-Backlog, 10MediaWiki-extensions-Wikilabels: Copy JS into extension and create special page - https://phabricator.wikimedia.org/T146405#2659950 (10Halfak) [18:48:56] 10Revision-Scoring-As-A-Service-Backlog, 10MediaWiki-extensions-Wikilabels: Copy JS into extension and create special page - https://phabricator.wikimedia.org/T146405#2659967 (10Halfak) Hey @bmansurov, I think this is either done or nearly done, but I wanted to make sure that all of the bits were documented an... [18:52:00] 10Revision-Scoring-As-A-Service-Backlog, 10MediaWiki-extensions-Wikilabels: [Discuss] Implement Wikilabels backend in MediaWiki? - https://phabricator.wikimedia.org/T146406#2659973 (10Halfak) [18:52:06] 10Revision-Scoring-As-A-Service-Backlog, 10MediaWiki-extensions-Wikilabels: Copy JS into extension and create special page - https://phabricator.wikimedia.org/T146405#2659986 (10bmansurov) Cool. Here is the patch that needs a +2 before we can move on with the next steps: https://gerrit.wikimedia.org/r/#/c/264415/ [19:24:49] 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Implement new json-lines pattern in editquality - https://phabricator.wikimedia.org/T146410#2660076 (10Halfak) [19:25:36] 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Implement new json-lines pattern in editquality - https://phabricator.wikimedia.org/T146410#2660092 (10Halfak) [19:25:39] 06Revision-Scoring-As-A-Service, 10revscoring: Implement PCFG features - https://phabricator.wikimedia.org/T144636#2660091 (10Halfak) [19:26:01] 06Revision-Scoring-As-A-Service, 10revscoring: Implement a basic scoring strategy for PCFGs - https://phabricator.wikimedia.org/T146335#2660094 (10Halfak) [19:26:03] 06Revision-Scoring-As-A-Service, 10revscoring: Implement PCFG features - https://phabricator.wikimedia.org/T144636#2605842 (10Halfak) [19:33:50] 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Implement new json-lines pattern in editquality - https://phabricator.wikimedia.org/T146410#2660104 (10Halfak) This is needed in order to implement PCFG features because we're relying on revscoring 1.3.0 (which uses json-lines) in order fit the PCFGs (like... [20:04:29] 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Produce tables of stats for damaging and goodfaith models - https://phabricator.wikimedia.org/T146280#2660202 (10jmatazzoni) I went over the numbers with Pau and Roan and we have one request and two questions. **Request:** @Halfak writes: > I wasn't aske... [20:11:42] (03CR) 10Ladsgroup: [C: 032] Use STRAIGHT_JOIN to work around optimizer bug for hidenondamaging=1 (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/311637 (https://phabricator.wikimedia.org/T146111) (owner: 10Catrope) [20:12:44] (03Merged) 10jenkins-bot: Use STRAIGHT_JOIN to work around optimizer bug for hidenondamaging=1 [extensions/ORES] - 10https://gerrit.wikimedia.org/r/311637 (https://phabricator.wikimedia.org/T146111) (owner: 10Catrope) [20:37:30] 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Produce tables of stats for damaging and goodfaith models - https://phabricator.wikimedia.org/T146280#2660341 (10Halfak) **Question #1** That's my mistake. I probably accidentally re-used data. I'll look into getting it updated. **Question #2** It doesn... [21:20:46] (03PS2) 10Ladsgroup: Add maintenance/CleanDuplicateScores.php [extensions/ORES] - 10https://gerrit.wikimedia.org/r/312286 (https://phabricator.wikimedia.org/T145503) [21:52:37] 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Produce tables of stats for damaging and goodfaith models - https://phabricator.wikimedia.org/T146280#2660691 (10Catrope) >>! In T146280#2660341, @Halfak wrote: > **Question #1** That's my mistake. I probably accidentally re-used data. I'll look into gett... [21:54:18] halfak: Sorry for the confusion there, we don't actually want probabilities at a given score, and we agree that that doesn't make sense. Joe just wanted to double-check that the numbers really did speak about thresholds (which I was confident was true, but he was less confident) [22:04:47] 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Produce tables of stats for damaging and goodfaith models - https://phabricator.wikimedia.org/T146280#2660709 (10jmatazzoni) Thanks @Halfak. So sorry to pressure you again. But we need to see these numbers before we start user testing. How we present the OR... [22:45:24] RoanKattouw, gotcha. Certainly about thresholds. [22:45:45] But. I don't think it is crazy to want real precisions of the prediction [22:48:03] halfak: Sure, but if you're gonna spend time helping us, that's not prio #1 :) [22:48:22] kk [23:03:15] 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Produce tables of stats for damaging and goodfaith models - https://phabricator.wikimedia.org/T146280#2660920 (10Halfak) Update complete. [23:05:50] 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Produce tables of stats for damaging and goodfaith models - https://phabricator.wikimedia.org/T146280#2660926 (10Halfak) Oh. Column D will take a little bit longer. [23:35:25] 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Produce tables of stats for damaging and goodfaith models - https://phabricator.wikimedia.org/T146280#2660956 (10Halfak) OK. Now the table above is completely fixed. I've replaced the useless 1-Precision column with "Negative precision" which is just a te... [23:36:55] 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Produce tables of stats for damaging and goodfaith models - https://phabricator.wikimedia.org/T146280#2660969 (10Halfak) This got a little tricky and it seems I'm doing this a lot so here's my code block and output for generating this: ``` >>> from numpy i...