[03:21:17] (03CR) 10Legoktm: [C: 031] "I'll let Thiemo approve this :)" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/314845 (https://phabricator.wikimedia.org/T146560) (owner: 10Ladsgroup) [07:01:43] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I can't spot an obvious mistake in the code." [extensions/ORES] - 10https://gerrit.wikimedia.org/r/314449 (https://phabricator.wikimedia.org/T143611) (owner: 10Ladsgroup) [09:13:35] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Yay for more tests! No +2 because of suggestions to simplify this code a bit, see my comments." (033 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/314845 (https://phabricator.wikimedia.org/T146560) (owner: 10Ladsgroup) [17:24:37] 06Revision-Scoring-As-A-Service, 10DBA, 10MediaWiki-extensions-ORES, 15User-Ladsgroup: Ensure ORES data violating constraints do not affect production - https://phabricator.wikimedia.org/T145356#2706309 (10Ladsgroup) ``` ladsgroup@terbium:~$ mwscript extensions/ORES/maintenance/CleanDuplicateScores.php --w... [17:31:50] 06Revision-Scoring-As-A-Service, 10DBA, 10MediaWiki-extensions-ORES, 15User-Ladsgroup: Ensure ORES data violating constraints do not affect production - https://phabricator.wikimedia.org/T145356#2706349 (10Ladsgroup) @jcrespo: I ran the maintenance script and then this: {P4196} Is it okay now? Thanks [18:46:17] (03CR) 10Ladsgroup: Extensive CI tests, part I (032 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/314845 (https://phabricator.wikimedia.org/T146560) (owner: 10Ladsgroup) [18:47:03] (03PS3) 10Ladsgroup: Extensive CI tests, part I [extensions/ORES] - 10https://gerrit.wikimedia.org/r/314845 (https://phabricator.wikimedia.org/T146560) [18:47:59] (03CR) 10jenkins-bot: [V: 04-1] Extensive CI tests, part I [extensions/ORES] - 10https://gerrit.wikimedia.org/r/314845 (https://phabricator.wikimedia.org/T146560) (owner: 10Ladsgroup) [18:49:15] (03PS4) 10Ladsgroup: Extensive CI tests, part I [extensions/ORES] - 10https://gerrit.wikimedia.org/r/314845 (https://phabricator.wikimedia.org/T146560) [18:50:12] (03CR) 10jenkins-bot: [V: 04-1] Extensive CI tests, part I [extensions/ORES] - 10https://gerrit.wikimedia.org/r/314845 (https://phabricator.wikimedia.org/T146560) (owner: 10Ladsgroup) [18:57:51] (03PS5) 10Ladsgroup: Extensive CI tests, part I [extensions/ORES] - 10https://gerrit.wikimedia.org/r/314845 (https://phabricator.wikimedia.org/T146560) [18:58:38] o/ [18:58:53] (03CR) 10jenkins-bot: [V: 04-1] Extensive CI tests, part I [extensions/ORES] - 10https://gerrit.wikimedia.org/r/314845 (https://phabricator.wikimedia.org/T146560) (owner: 10Ladsgroup) [19:01:21] (03PS6) 10Ladsgroup: Extensive CI tests, part I [extensions/ORES] - 10https://gerrit.wikimedia.org/r/314845 (https://phabricator.wikimedia.org/T146560) [19:03:15] (03CR) 10Ladsgroup: [C: 032] Extensive CI tests, part I [extensions/ORES] - 10https://gerrit.wikimedia.org/r/314845 (https://phabricator.wikimedia.org/T146560) (owner: 10Ladsgroup) [19:04:36] (03Merged) 10jenkins-bot: Extensive CI tests, part I [extensions/ORES] - 10https://gerrit.wikimedia.org/r/314845 (https://phabricator.wikimedia.org/T146560) (owner: 10Ladsgroup) [19:19:50] (03CR) 10Ladsgroup: "You can check it in your localhost. I also cherry-picked it in mw-revscoring.wmflabs.org for you to test. I will write CI tests alongside " [extensions/ORES] - 10https://gerrit.wikimedia.org/r/314449 (https://phabricator.wikimedia.org/T143611) (owner: 10Ladsgroup) [19:54:59] halfak: hey, The deployment went smooth, the backport went smooth, I just ran the maintenance script and it went smooth too [20:21:15] Hey Amir1! Great news. [20:21:22] Did the schema change happen? [20:21:27] Or will that happen later? [20:21:40] Not yet it will happen soonish [22:06:15] 06Revision-Scoring-As-A-Service, 10ORES, 15User-Ladsgroup: Send celery logs to /srv/log/ores instead of /var/lib/daemon.log - https://phabricator.wikimedia.org/T147898#2707557 (10Ladsgroup) [23:47:30] Amir1, if around, can you review https://etherpad.wikimedia.org/p/ores_weekly_update ? [23:47:58] halfak: Hey, I wanted to go to sleep but ended up with some stuff [23:48:01] let me check [23:48:51] Na. It's OK. I'll take a proof reading run. Go to sleep :P [23:49:39] halfak: I just read it [23:49:42] it's okay [23:49:44] one thing [23:49:55] kk [23:50:01] I removed the bracket [23:50:06] Looks good to me [23:50:07] otherwise it's good [23:50:21] OK here goes [23:51:25] HERE COMES THE SPAM [23:51:49] 06Revision-Scoring-As-A-Service: Present about ORES transparency at AoIR - https://phabricator.wikimedia.org/T147706#2707793 (10Halfak) 05Open>03Resolved [23:51:50] \o/ [23:51:51] 06Revision-Scoring-As-A-Service, 10revscoring: Add type decoding support to tsv2json - https://phabricator.wikimedia.org/T146939#2707794 (10Halfak) 05Open>03Resolved [23:51:53] 06Revision-Scoring-As-A-Service, 10ORES, 13Patch-For-Review, 15User-Ladsgroup, 07Wikimedia-log-errors: Quiet result.get Warning in tasks - https://phabricator.wikimedia.org/T146680#2707795 (10Halfak) 05Open>03Resolved [23:51:55] 06Revision-Scoring-As-A-Service, 10revscoring: Implement PCFG features - https://phabricator.wikimedia.org/T144636#2707797 (10Halfak) [23:51:57] 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Update editquality for revscoring 1.3.0 - https://phabricator.wikimedia.org/T146410#2707796 (10Halfak) 05Open>03Resolved [23:51:59] 06Revision-Scoring-As-A-Service, 10rsaas-articlequality : Generate monthly article quality dataset - https://phabricator.wikimedia.org/T145655#2707800 (10Halfak) 05Open>03Resolved [23:52:00] _o/ [23:52:01] 06Revision-Scoring-As-A-Service, 10DBA, 10MediaWiki-extensions-ORES, 13Patch-For-Review, and 2 others: hidenondamaging=1 query is extremely slow on enwiki - https://phabricator.wikimedia.org/T146111#2707798 (10Halfak) 05Open>03Resolved a:03Halfak [23:52:05] 06Revision-Scoring-As-A-Service, 10DBA, 10MediaWiki-extensions-ORES, 15User-Ladsgroup: Ensure ORES data violating constraints do not affect production - https://phabricator.wikimedia.org/T145356#2707802 (10Halfak) [23:52:08] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 13Patch-For-Review, 15User-Ladsgroup, 05WMF-deploy-2016-10-04_(1.28.0-wmf.21): Build a maintenance script to clean up duplicate data. - https://phabricator.wikimedia.org/T145503#2707801 (10Halfak) 05Open>03Resolved [23:52:08] _o_ [23:52:10] \o/ [23:52:11] 06Revision-Scoring-As-A-Service, 10MediaWiki-API, 10MediaWiki-extensions-ORES, 07Epic: [Epic] Implement ORES service proxy in api.php - https://phabricator.wikimedia.org/T143895#2582434 (10Halfak) [23:52:15] 06Revision-Scoring-As-A-Service, 10DBA, 10MediaWiki-extensions-ORES, 15User-Ladsgroup: Ensure ORES data violating constraints do not affect production - https://phabricator.wikimedia.org/T145356#2627432 (10Halfak) 05Open>03Resolved [23:52:22] wikibugs nooooo [23:52:23] lol [23:52:33] How do we get it back? [23:52:51] * halfak reads https://wikitech.wikimedia.org/wiki/Wikibugs [23:53:35] legoktm, wikibugs got kicked because of flooding (lol) [23:53:41] How do we get it back? [23:53:59] halfak: it comes back whenever it has something to say here [23:54:09] Oh. OK That's cool :) [23:54:11] Nothing to do then [23:54:23] it will always rejoin -labs [23:57:36] 06Revision-Scoring-As-A-Service, 10ORES: Investigate memory leak in precached - https://phabricator.wikimedia.org/T146500#2707815 (10Halfak) I noted in meeting that I suspect that there's something going on with metrics collection. [23:57:42] o/ wikibugs [23:58:04] OK I'm out of here for the evening. Good night (or whatever day part is apt) all!