[10:33:10] (03PS1) 10Ladsgroup: Add regression test for when hidenondamaging is true in Special:Contributions [extensions/ORES] - 10https://gerrit.wikimedia.org/r/333586 (https://phabricator.wikimedia.org/T155500) [10:56:42] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "This introduces a lot of duplicate code. Even most of the assertions are the same as in the test case above. I hope we can refactor this f" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/333586 (https://phabricator.wikimedia.org/T155500) (owner: 10Ladsgroup) [11:23:16] (03PS11) 10Sbisson: [DO NOT MERGE] Fetch thresholds from live stats for filters [extensions/ORES] - 10https://gerrit.wikimedia.org/r/332825 (https://phabricator.wikimedia.org/T152161) [13:56:04] (03PS1) 10Esanders: build: Re-use MessageDirs in banana conf [extensions/ORES] - 10https://gerrit.wikimedia.org/r/333628 [13:57:05] (03CR) 10Ladsgroup: "I will refactor it this weekend. Would it work for you?" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/333586 (https://phabricator.wikimedia.org/T155500) (owner: 10Ladsgroup) [14:20:30] (03CR) 10Ladsgroup: [C: 032] build: Re-use MessageDirs in banana conf [extensions/ORES] - 10https://gerrit.wikimedia.org/r/333628 (owner: 10Esanders) [14:22:37] (03Merged) 10jenkins-bot: build: Re-use MessageDirs in banana conf [extensions/ORES] - 10https://gerrit.wikimedia.org/r/333628 (owner: 10Esanders) [16:50:39] 10Revision-Scoring-As-A-Service-Backlog, 07artificial-intelligence: Article similarity scorer - https://phabricator.wikimedia.org/T155853#2961830 (10Halfak) [16:51:23] o/ Amir1 [16:51:35] Nothing like a pull request merged in the morning to set the day in a positive light :D [16:53:56] halfak: :D you rock [16:54:02] that's the reason [16:54:26] I'm glad you caught that issue re. i18n in review [16:54:28] :) [16:55:07] People think I don't review but I do, I'm just easy :D [16:57:17] halfak: Check this when you have some time: https://github.com/wiki-ai/ores/pull/183 [16:57:37] It'll help I/O both in mediawiki nodes and ores nodes [16:58:06] (It's not much, but given the flow of requests, I hope this will help) [16:58:39] Amir1, gotcha. This is interesting. What do you think about making it not the default? [16:58:59] E.g. you send a param to get better performance. [16:59:04] Yeah, I thought about it but there are tons of json pretiffiers out there [16:59:16] I use one (json_formatter chrome extension) [16:59:34] That's a good point. Not sure we should expect that from our users though. [16:59:36] Hmmm... [16:59:41] and almost all REST base APIs I've seen in wikimedia does it by default too [16:59:47] e.g. https://wikimedia.org/api/rest_v1/metrics/pageviews/top/fa.wikipedia/all-access/2017/01/21 [16:59:49] That's a good point. [17:00:12] But then again, the mw api gives formatted JSON back for all example queries. [17:00:16] Maybe we can do something like that. [17:00:20] Ooops. Meeting time! [17:00:39] yeah [17:00:44] I'll join in one minute [17:03:08] kk [17:04:41] tgr|away: coming? [17:36:48] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Add regression test for when hidenondamaging is true in Special:Contributions [extensions/ORES] - 10https://gerrit.wikimedia.org/r/333586 (https://phabricator.wikimedia.org/T155500) (owner: 10Ladsgroup) [17:38:06] (03Merged) 10jenkins-bot: Add regression test for when hidenondamaging is true in Special:Contributions [extensions/ORES] - 10https://gerrit.wikimedia.org/r/333586 (https://phabricator.wikimedia.org/T155500) (owner: 10Ladsgroup) [17:53:00] halfak: I'm heading home, Talk to you soon about pretty-printing [17:53:32] one note, If you hit the mediawiki API without a browser, I don't think that would prettify it for you [17:53:34] but not sure [17:55:45] Amir1: you could pipe it through `jq .` [18:15:27] o/ [18:15:43] srrodlund and I were going to talk about ORES things this afternoon, if anyone would like to join in [18:16:00] Probably comparing our understandings of architecture and API [18:25:15] halfak: I'm back [18:25:42] I don't quite get it yet [18:26:06] but overall I have no strong preferences [18:26:29] If you think we should do the prettified version by default, I'm game [18:53:38] o/ [18:53:57] Sorry Amir1. Went to go get lunch [18:54:22] So yeah, the MW API does format=jsonfm in the examples. [18:55:20] It looks like you get formated HTML with JSON in it by default. [18:55:36] https://en.wikipedia.org/w/api.php?action=query&prop=revisions&titles=API&rvprop=timestamp%7Cuser%7Ccomment%7Ccontent [18:55:49] I don't think we should output something that isn't machine readable. [18:56:11] Especially because it will break backwards compatibility, but I do think that we should render pretty by default. [18:56:40] okay [18:56:46] I'll do it soon [18:57:56] Cool :) [18:58:17] Amir1, what do you think we should have as a means to say "strip the whitespace from my JSON"? [18:58:32] could do format=json/jsonfm like the mw API [18:58:50] halfak: one of the two options: 1- json/jsonfm 2- minify argument [18:58:51] Or we could do something like "trim=true" [19:00:01] dr0ptp4kt: halfak uh, sorry, I overslept my alarm [19:01:13] No worries tgr. You didn't miss too much because we have the meeting later today to focus on reading infra stuff. [19:14:30] 10Revision-Scoring-As-A-Service-Backlog, 10Wikilabels: Add notice of CC0 status of Wikilabels data to UI & Docs - https://phabricator.wikimedia.org/T156052#2962545 (10Halfak) [19:14:53] 06Revision-Scoring-As-A-Service, 10Data-release, 06Research-and-Data, 10Wikilabels: Licensing of labeled data - https://phabricator.wikimedia.org/T145024#2962559 (10Halfak) [19:14:55] 10Revision-Scoring-As-A-Service-Backlog, 10Wikilabels: Add notice of CC0 status of Wikilabels data to UI & Docs - https://phabricator.wikimedia.org/T156052#2962558 (10Halfak) [19:16:34] 06Revision-Scoring-As-A-Service, 10Data-release, 06Research-and-Data, 10Wikilabels: Licensing of labeled data - https://phabricator.wikimedia.org/T145024#2962564 (10DarTar) @Slaporte we're moving forward and assuming CC0 for data collected so far and we have a new task to keep track of any suggestion of la... [19:16:52] 06Revision-Scoring-As-A-Service, 10Data-release, 06Research-and-Data, 10Wikilabels: Licensing of labeled data - https://phabricator.wikimedia.org/T145024#2962566 (10DarTar) [19:17:14] 10Revision-Scoring-As-A-Service-Backlog, 10Wikilabels: Add notice of CC0 status of Wikilabels data to UI & Docs - https://phabricator.wikimedia.org/T156052#2962568 (10Halfak)