[00:46:39] (03CR) 10Krinkle: Make rcshow=oresreview bypass query optimizer failure (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/337263 (https://phabricator.wikimedia.org/T152585) (owner: 10Ladsgroup) [01:08:51] (03PS1) 10Gergő Tisza: Fix task ID in comment [extensions/ORES] - 10https://gerrit.wikimedia.org/r/339335 [01:13:57] (03CR) 10Gergő Tisza: [C: 032] "Self-merge, trivial comment-only change." [extensions/ORES] - 10https://gerrit.wikimedia.org/r/339335 (owner: 10Gergő Tisza) [01:14:24] (03CR) 10Gergő Tisza: Make rcshow=oresreview bypass query optimizer failure (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/337263 (https://phabricator.wikimedia.org/T152585) (owner: 10Ladsgroup) [01:15:15] (03Merged) 10jenkins-bot: Fix task ID in comment [extensions/ORES] - 10https://gerrit.wikimedia.org/r/339335 (owner: 10Gergő Tisza) [03:32:41] o/ [03:32:44] Hey Amir1 [12:21:11] 06Revision-Scoring-As-A-Service, 10Edit-Review-Improvements-RC-Page, 10ORES, 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 06Community-Liaisons (Jan-Mar 2017): Enable the ORES good faith and damaging models by default on wikis that have ORES ... - https://phabricator.wikimedia.org/T158225#3030378 [14:49:20] 06Revision-Scoring-As-A-Service, 10Edit-Review-Improvements-RC-Page, 10ORES, 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017): Enable the ORES good faith and damaging models by default on wikis that have ORES as a Beta, and communicate this to the ... - https://phabricator.wikimedia.org/T158225#3049696 [15:02:12] o/ Amir1 [15:02:14] Hey sorry for being late. [15:02:16] So, I can only work through IRC for the meeting today. Will that work OK? [15:02:27] halfak: hey, sure [15:04:45] Am working from staeiou's living room in Berkeley and it's pretty early in the morning ^_^ [15:04:53] So, the backlog column! [15:05:18] https://phabricator.wikimedia.org/T158774 [15:05:55] halfak: I tried to see what's wrong but it's really strange thing [15:06:01] It's not easy to solve [15:06:31] What's the exact language we have for that filter? [15:06:59] "Only show edits needing review" [15:07:07] Aha! I think this might be the real problem. [15:07:22] halfak: Wikidata [15:07:26] On recent changes, we have "Hide probably good edits" [15:07:39] Yeah. I got that from wikidata. [15:07:40] this is for user contribs [15:07:55] Right. On user contrib it has different language than on recent changes. [15:08:00] halfak: btw. ORES review tool is deployed in cswiki [15:08:14] Oh yeah. I saw that. Good work :D [15:08:52] I've been traveling so I've hardly gotten to sit down with my laptop in a few days. [15:08:53] in user contribs we don't use patrolling because it queries from revision table and that doesn't rc_patrolled (in rc table) [15:09:35] no worries. Enjoy your travels :) Tell me if I can take over anything :D [15:11:16] 10Revision-Scoring-As-A-Service-Backlog, 10MediaWiki-extensions-ORES: ORES filter on Special:Contributions should handle Flow edits - https://phabricator.wikimedia.org/T158774#3046916 (10Halfak) It looks like the language we use for that type of filter on the Special:RecentChanges page is "Hide probably good e... [15:11:50] Amir1, I don't know what you're referring to with rc_patrolling. [15:12:43] In the end, we're using "hidenondamaging=1" in both cases [15:13:10] It's hard to explain in text :D The user says all of his edits should be marked as okay because of patrolling [15:13:30] (because he's admin and all of his edits get labeled as patrolled) [15:13:41] but we don't use that in our system [15:13:47] *contribs [15:13:56] for the reason I mentioned above [15:14:51] OK. well the problem I'm discussing is still a problem. [15:15:03] Are the user's flow posts "edits that need review"? [15:15:39] I tried to look up that but it was quite complex [15:15:48] * Amir1 curses at flow [15:16:37] What I'm trying to tell is that It's probably fixable but it needs some time to investigate [15:16:47] it's a time-consuming but easy task [15:17:08] I don't think we need to "fix" it. It seems that changing the language to match the language on recent changes is easier. [15:17:56] Because really, this is doing the same thing as we do on recent changes (minus patrolling), right? [15:18:35] ...Flow edits show up when we "hide probably good edits" [15:19:30] halfak: Sorry. I don't get the part about language [15:19:49] wikidata is a multi-lingual it doesn't care about language [15:19:59] OK. no worries. How about we just see what matej says about my comment and go from there. [15:20:18] s/.$/?/ [15:20:48] :D [15:20:49] sure [15:21:04] OK. moving that into the maint column [15:21:36] 10Revision-Scoring-As-A-Service-Backlog, 10MediaWiki-extensions-ORES: ORES filter on Special:Contributions should handle Flow edits - https://phabricator.wikimedia.org/T158774#3046916 (10Halfak) p:05Triage>03Normal [15:21:37] halfak: when I saw yoru comment, every thing is clearer now [15:21:43] Oh good :) [15:22:03] The problem in the message key is something else [15:22:27] I think there is something bigger going on, why flow edits show up when we do "hidenondamaging" [15:23:02] 10Revision-Scoring-As-A-Service-Backlog, 10Bad-Words-Detection-System, 10revscoring: Add language support for Finnish - https://phabricator.wikimedia.org/T158587#3041229 (10Halfak) @4shadoww, I think the old one should work. 8 months isn't too old for this kind of signal. [15:23:07] https://phabricator.wikimedia.org/T158587 [15:23:14] does ORES service can't score them and score them really high or we messed up in getting query or flow injects them regardless and making a mess [15:23:16] Sorry. Got ahead of myself and made a comment [15:23:40] Gotcha re. Flow. I think we should prod the collab team about fixing that. [15:24:14] the message key is something that I need to fix sometime soon [15:24:36] they know flow better than we do [15:25:29] Amir1, would you add them to the task? I'll get this finnish language one placed into new dev. [15:25:50] halfak: sure [15:26:48] 06Revision-Scoring-As-A-Service, 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-ORES, 10Wikidata: Support ORES for propagated Wikidata edits - https://phabricator.wikimedia.org/T158025#3023878 (10Halfak) [15:27:18] 10Revision-Scoring-As-A-Service-Backlog, 10Bad-Words-Detection-System, 10revscoring: Add language support for Finnish - https://phabricator.wikimedia.org/T158587#3041229 (10Halfak) p:05Triage>03Normal [15:27:48] 10Revision-Scoring-As-A-Service-Backlog, 10MediaWiki-extensions-ORES, 15User-Ladsgroup: Fix message in Special:Contributions - https://phabricator.wikimedia.org/T158862#3049807 (10Ladsgroup) [15:28:47] 10Revision-Scoring-As-A-Service-Backlog, 10MediaWiki-extensions-ORES: ORES filter on Special:Contributions should handle Flow edits - https://phabricator.wikimedia.org/T158774#3046916 (10Ladsgroup) The message is something else I made T158862 for that. For the flow issue, It'd be great if collab team chime in... [15:29:20] great :) [15:29:33] OK. Looks like I have the finnish lang stuff in the right spot. [15:29:42] I just confirmed that we're waiting on human review. [15:31:26] nice [15:32:58] https://phabricator.wikimedia.org/T158437 is new dev. [15:33:23] I'm excited to look at that. I think we'll end up transplanting a bit from "precached" and then simplifying that. [15:34:00] I'll just assume that we can get the same data structure as RCStream's events. [15:34:17] 10Revision-Scoring-As-A-Service-Backlog, 10ChangeProp, 10ORES, 06Services (watching): Change ORES rules to send all events to new "/precache" endpoint - https://phabricator.wikimedia.org/T158437#3036977 (10Halfak) p:05Triage>03Normal [15:34:23] Awesome, I'd love to see that happen (I wanted to steal the subtask but saw you're assigned) [15:34:48] Oh do it :) I'm going to be traveling until next Thursday. [15:34:54] I think you'd likely beat me to it. [15:34:57] :) [15:35:25] :P [15:35:45] It's not my fault. You can give me other things to do but if I get bored I do it [15:37:34] kk :D [15:37:50] https://phabricator.wikimedia.org/T158862 [15:37:53] :) [15:37:59] moving that to maint [15:38:21] I know that Glorian is looking into https://phabricator.wikimedia.org/T158430 [15:38:31] So I'll move that to "active" on the main board [15:41:05] 06Revision-Scoring-As-A-Service, 10Wikidata, 07artificial-intelligence: [Spike] Use suggested properties to get signal for completeness - https://phabricator.wikimedia.org/T158430#3049859 (10Halfak) [15:42:52] I don't know what to think of https://phabricator.wikimedia.org/T156897 [15:43:35] halfak: I think we decided to keep it there last grooming [15:44:50] Yeah. So I'm just really not sure what the task *is* [15:44:57] halfak: but I think we can make it invalid as a duplicate of other wikilabels bugs [15:45:04] This my opinion [15:45:35] Oh wait. I was confusing this with another ytask. [15:46:56] 10Revision-Scoring-As-A-Service-Backlog, 10Research Ideas, 10revscoring, 07artificial-intelligence: Interface and database for setup and manual scoring of revisions based on specified criterion - https://phabricator.wikimedia.org/T156897#3049902 (10Halfak) 05Open>03declined [15:47:08] 10Revision-Scoring-As-A-Service-Backlog, 10Research Ideas, 10revscoring, 07artificial-intelligence: Interface and database for setup and manual scoring of revisions based on specified criterion - https://phabricator.wikimedia.org/T156897#2989116 (10Halfak) @fnielsen, please file a separate task if you'd li... [15:49:16] halfak: backlog looks clean [15:49:22] :) Indeed it does. [15:49:26] I want to pick up stuff to do for ores [15:49:35] I'm going to pack up and head across the bay to SF [15:49:43] Kinda bored [15:49:58] halfak: please don't forget about the "kdd" paper [15:50:09] I need to apply it really soon [15:50:18] Also I can't find it's DOI :(((( [15:50:21] I've got it on my calendar. Will make sure to spend the time. [15:50:40] Sorry. No idea about a DOI. I think we'll get one once it is filed. [15:51:20] gotta run, but I should be somewhat available on IRC within a couple of hours. [15:51:22] o/ [15:51:31] halfak: I'm here [15:51:32] o/ [16:36:22] 10Revision-Scoring-As-A-Service-Backlog, 10Bad-Words-Detection-System, 10revscoring: Add language support for Finnish - https://phabricator.wikimedia.org/T158587#3050013 (104shadoww) I have sorted the [[ https://meta.wikimedia.org/wiki/Research:Revision_scoring_as_a_service/Word_lists/fi | word list ]]. Does... [16:36:22] 10[1] 04https://meta.wikimedia.org/wiki/https://meta.wikimedia.org/wiki/Research:Revision_scoring_as_a_service/Word_lists/fi [16:37:56] AsimovBot: Are you using internet explorer? [16:37:56] 04Error: Command “are” not recognized. Please review and correct what you’ve written. [17:11:46] PROBLEM - ORES web node labs ores-web-03 on ores.wmflabs.org is CRITICAL: CRITICAL - Socket timeout after 10 seconds [17:12:03] not again :((( [17:20:46] PROBLEM - ORES worker labs on ores.wmflabs.org is CRITICAL: CRITICAL - Socket timeout after 10 seconds [17:23:36] RECOVERY - ORES worker labs on ores.wmflabs.org is OK: HTTP OK: HTTP/1.1 200 OK - 456 bytes in 0.543 second response time [17:28:46] PROBLEM - ORES worker labs on ores.wmflabs.org is CRITICAL: CRITICAL - Socket timeout after 10 seconds [17:30:36] RECOVERY - ORES worker labs on ores.wmflabs.org is OK: HTTP OK: HTTP/1.1 200 OK - 442 bytes in 0.564 second response time [18:06:48] PROBLEM - ORES worker labs on ores.wmflabs.org is CRITICAL: CRITICAL - Socket timeout after 10 seconds [18:07:38] RECOVERY - ORES worker labs on ores.wmflabs.org is OK: HTTP OK: HTTP/1.1 200 OK - 443 bytes in 0.546 second response time [18:31:28] Amir1: Hmm so we (collab team) want to enable goodfaith in production (so the scores get populated in the tables), any pitfalls we should be aware of? [18:31:38] Is there anything we should do other than a config change? [18:46:49] ( halfak ) [18:48:48] PROBLEM - ORES worker labs on ores.wmflabs.org is CRITICAL: CRITICAL - Socket timeout after 10 seconds [18:49:38] RECOVERY - ORES worker labs on ores.wmflabs.org is OK: HTTP OK: HTTP/1.1 200 OK - 443 bytes in 1.082 second response time [18:52:18] RoanKattouw, I don't see any issue with just enabling "goodfaith" in the ORES extension other than the increased storage requirement. This will make ores_classification twice as big. [18:52:25] * halfak looks at ORES worker issue. [18:52:29] Right [18:52:47] PROBLEM - ORES worker labs on ores.wmflabs.org is CRITICAL: CRITICAL - Socket timeout after 10 seconds [18:52:48] Also if I enable it now, and don't deploy code that exposes it for another couple weeks, then I don't have to worry about backfilling anything, right? [18:53:01] cause it'll just populate while unexposed for the next few eeks [18:53:08] +1 [18:53:22] We only backfill the most recent N edits anyway. [18:53:26] I think N is something like 5k [18:53:37] RECOVERY - ORES worker labs on ores.wmflabs.org is OK: HTTP OK: HTTP/1.1 200 OK - 443 bytes in 1.064 second response time [18:54:25] WEIRD [18:54:38] Looks like that memory leak in precached is happening again. [18:54:47] But this time it happened way faster [18:55:27] I'll file a new task. [18:55:37] RECOVERY - ORES web node labs ores-web-03 on ores.wmflabs.org is OK: HTTP OK: HTTP/1.1 200 OK - 443 bytes in 0.042 second response time [18:56:08] halfak, Amir1: https://gerrit.wikimedia.org/r/339472 [18:56:23] I'll leave that up for 24h to get comments, and if nobody objects I'll schedule it for SWAT next week [18:57:27] 06Revision-Scoring-As-A-Service, 10Analytics, 10ChangeProp, 10EventBus, and 2 others: Create generalized "precache" endpoint for ORES - https://phabricator.wikimedia.org/T148714#3050708 (10Halfak) Just quickly noting that it seems we still have a memory leak in `ores precached` (the utility that runs in la... [19:04:51] 06Revision-Scoring-As-A-Service, 10Analytics, 10ChangeProp, 10EventBus, and 2 others: Create generalized "precache" endpoint for ORES - https://phabricator.wikimedia.org/T148714#3050726 (10Pchelolo) > Just quickly noting that it seems we still have a memory leak in ores precached (the utility that runs in... [19:11:04] 06Revision-Scoring-As-A-Service, 10Analytics, 10ChangeProp, 10EventBus, and 2 others: Create generalized "precache" endpoint for ORES - https://phabricator.wikimedia.org/T148714#3050759 (10Halfak) Yeah. We have an experimental installation at ores.wmflabs.org where we deploy experimental models that aren'... [19:13:24] 10Revision-Scoring-As-A-Service-Backlog, 10Bad-Words-Detection-System, 10revscoring: Add language support for Finnish - https://phabricator.wikimedia.org/T158587#3050795 (10Halfak) Looks great. Are there any more words (or word variants) that would would like to add to the list before we encode it in our mo... [19:20:08] 06Revision-Scoring-As-A-Service, 10Analytics, 10ChangeProp, 10EventBus, and 2 others: Create generalized "precache" endpoint for ORES - https://phabricator.wikimedia.org/T148714#3050811 (10Pchelolo) > Is there a ChangeProp in labs that will allow us to track the production wikis? Nope, we don't have acces... [19:21:12] 06Revision-Scoring-As-A-Service, 10Analytics, 10ChangeProp, 10EventBus, and 2 others: Create generalized "precache" endpoint for ORES - https://phabricator.wikimedia.org/T148714#3050812 (10Halfak) Boo. OK. No worries. Onward with `ores precached` for now. [19:37:14] 06Revision-Scoring-As-A-Service, 10Revision-Scoring-As-A-Service-Backlog, 10Bad-Words-Detection-System, 10Wikilabels: Dexbot overwrote manual changes to our tracking table. - https://phabricator.wikimedia.org/T158899#3050893 (10Halfak) [19:54:49] 10Revision-Scoring-As-A-Service-Backlog, 10Bad-Words-Detection-System, 10revscoring: Add language support for Finnish - https://phabricator.wikimedia.org/T158587#3051074 (10Zache) I added some common bad words more from fiwikis abuse filter rules. Though i think that there would be more if the more is better. [19:55:29] 10Revision-Scoring-As-A-Service-Backlog: Add notice to on-wiki labeling pages (e.g. en:WP:Labels) about deprecation. - https://phabricator.wikimedia.org/T155440#3051075 (10Halfak) Made some notices about our move to Translatewiki.net https://meta.wikimedia.org/w/index.php?title=Template:Wiki_labels/Interface_tr... [20:38:43] (03CR) 10Jforrester: [WIP] Add goodfaith filtering (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/312166 (https://phabricator.wikimedia.org/T137966) (owner: 10Catrope) [20:53:51] RoanKattouw: Sorry I was afk. Aaron's assessment is correct [20:54:07] you might need to talk to DBAs about it [20:54:36] but it won't become twice, it growths at twice speed (in long run that doesn't matter) [21:10:56] halfak: Sorry, I was afk [21:11:06] answered above [21:21:02] 10Revision-Scoring-As-A-Service-Backlog, 10Bad-Words-Detection-System, 10revscoring: Add language support for Finnish - https://phabricator.wikimedia.org/T158587#3051321 (10Halfak) More is generally better. This isn't the last chance to extend the list though it may be the last chance to extend the list di... [21:38:52] Thanks Amir1 [21:44:17] 06Revision-Scoring-As-A-Service, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-ORES, and 3 others: Add class to diff and history links in changes lists for easier selecting in CSS/javascript - https://phabricator.wikimedia.org/T157178#3051345 (10EddieGP) 05Open>03Resolved Cl... [21:57:09] halfak: around? [22:34:08] 10Revision-Scoring-As-A-Service-Backlog, 10revscoring: Make ORES/revscoring read mediawiki pages for swear words and bad words - https://phabricator.wikimedia.org/T158916#3051496 (10Ladsgroup) [22:34:39] 10Revision-Scoring-As-A-Service-Backlog, 10revscoring: Make ORES/revscoring read mediawiki pages for swear words and bad words - https://phabricator.wikimedia.org/T158916#3051526 (10Ladsgroup) [22:40:43] 06Revision-Scoring-As-A-Service, 10Edit-Review-Improvements-RC-Page, 10Edit-Review-Improvements-ReviewStream, 10rsaas-editquality, and 2 others: Automatically adjust ORES threshold settings when ORES models are updated - https://phabricator.wikimedia.org/T152161#3051541 (10jmatazzoni) [22:59:07] 10Revision-Scoring-As-A-Service-Backlog, 10Mobile-Content-Service, 10ORES, 06Operations, 06Services (watching): Limit resources used by ORES - https://phabricator.wikimedia.org/T146664#2667780 (10Ladsgroup) I don't know about disk quota but regarding RAM. This easily can be added in the puppet using [[ht... [23:00:30] 10Revision-Scoring-As-A-Service-Backlog, 06Operations: Set up oresrdb redis node in codfw - https://phabricator.wikimedia.org/T139372#2430068 (10Ladsgroup) Is there any plans on syncing codfw/eqiad redis nodes? It would be needed if the codfw starts to get traffic. [23:25:07] 10Revision-Scoring-As-A-Service-Backlog, 10ORES, 07Easy: Add banner to ORES main and ui pages in labs noting the experimental nature - https://phabricator.wikimedia.org/T150962#2802803 (10Ladsgroup) https://github.com/wiki-ai/ores/pull/188 [23:31:06] 06Revision-Scoring-As-A-Service, 10ORES, 07Easy, 15User-Ladsgroup: Add banner to ORES main and ui pages in labs noting the experimental nature - https://phabricator.wikimedia.org/T150962#3051724 (10Ladsgroup) a:03Ladsgroup [23:41:33] 06Revision-Scoring-As-A-Service, 10ORES, 07Easy, 15User-Ladsgroup: Add banner to ORES main and ui pages in labs noting the experimental nature - https://phabricator.wikimedia.org/T150962#3051733 (10Ladsgroup) It'll be something like this: {F5802214} [23:49:59] (03PS1) 10Ladsgroup: Make wording of filters in Special:Contribs as the same as ChangesLists [extensions/ORES] - 10https://gerrit.wikimedia.org/r/339581 (https://phabricator.wikimedia.org/T158862) [23:50:12] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 13Patch-For-Review, 15User-Ladsgroup: Fix message in Special:Contributions - https://phabricator.wikimedia.org/T158862#3051762 (10Ladsgroup)