[00:39:51] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 15User-Ladsgroup: Deploy ORES review tool to etwiki - https://phabricator.wikimedia.org/T159609#3116699 (10Ladsgroup) https://et.wikipedia.org/w/index.php?title=Vikipeedia_arutelu:Saatkond&oldid=4606630#Deployment_of_ORES_review_tool [00:40:27] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 15User-Ladsgroup: Deploy ORES review tool to etwiki - https://phabricator.wikimedia.org/T159609#3073112 (10Ladsgroup) 05Open>03Resolved [12:02:49] 06Revision-Scoring-As-A-Service, 10Wikilabels, 10rsaas-editquality: Complete hewiki edit quality campaign - https://phabricator.wikimedia.org/T130263#3117583 (10Ladsgroup) I need to thank @Amire80 for his great work on pushing this. Thanks :) [12:37:55] 06Revision-Scoring-As-A-Service, 10Edit-Review-Improvements-RC-Page, 10ORES, 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 07User-notice: Enable the ORES good faith and damaging UI by default, on wikis that have these ORES models available (i... - https://phabricator.wikimedia.org/T158225#3117637 [13:43:09] o/ [13:44:00] halfak: o/ [13:44:10] o/ glorian_wd [13:44:15] I think you have committed something yesterday? [13:44:21] regarding to WikiLabels [13:44:24] with iframe [13:44:29] Yeah should have been clear :P I linked directly to it from your PR. [13:44:39] I don't know how you managed to work on that old branch :P [13:45:08] yeah. I just picked a random branch and created a PR with it [13:45:25] ha. You're supposed to create a new branch off of master and work on that ;) [13:45:38] ok will do [13:45:44] but I think you still managed to see the changes on the code right? [13:46:47] halfak: I saw the committed code. It seems you simplified the code I wrote [13:48:38] glorian_wd, yeah. Seems we need a better way to address item width issue. [13:49:26] yeah agree [13:49:34] but I guess, you managed to find it at the end? [13:51:30] find it? [13:51:37] Find what? [13:51:46] halfak: find the way to address item width issue [13:52:05] I said so because I saw the screenshot you posted [13:52:44] Hmm... different issue. [13:52:49] See Amir1's reply [13:54:25] Amir1's reply on phab? [13:56:37] in meeting, but halfak I think the db of staging needs changing of campaign type for wikidatawiki [13:56:43] halfak: in IRC, I saw that Amir1 said something regarding the termbox. But I think that's not an issue because you can expand the term box by clicking "more languages" [13:58:16] Amir1, not campaign type, but "view" [13:58:26] yup that :P [13:58:33] :) [14:00:09] halfak: changing view type? are you referring to PrintablePageAsOfRevision? [14:00:43] glorian_wd, yup [14:01:35] halfak: oh okay. So I suppose we need to implement PrintablePageAsOfRevision in the staging? [14:01:42] prior to launching it? [14:03:13] glorian_wd, I'm fixing a problem with the code now [14:04:09] halfak: oh okay. Keep me updated then. Thanks :) [14:09:16] Amir1, the real problem I have with wikidata width is the redraw that happens when the javascript engages. [14:09:24] I think we might be stuck with a little scrollbar. [14:34:00] halfak: was your last commit solved the issue that you mentioned before? [14:34:11] I think so, yes. [14:34:44] halfak: so shall we launch the pilot now? I can work on my project chat message :D [14:46:28] 06Revision-Scoring-As-A-Service, 10Edit-Review-Improvements-RC-Page, 10ORES, 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017): Conform ORES sensitivity levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3117950 (10Halfak) Damage patrollers need to catch most-all of the dam... [14:49:52] 10Revision-Scoring-As-A-Service-Backlog, 10ORES, 06Operations: [spec] Active-active setup for ORES across datacenters (eqiad, codfw) - https://phabricator.wikimedia.org/T159615#3117957 (10akosiaris) >>! In T159615#3116226, @mobrovac wrote: > How about replicating the precaching redis instance across DCs? Wou... [15:08:06] glorian_wd, ^ [15:08:10] to staging withyou! [15:08:30] halfak: to staging with me? [15:14:14] Check it out: http://labels-staging.wmflabs.org/ui/wikidatawiki/ [15:14:24] Amir1 & glorian_wd: ^ [15:15:26] halfak: I saw 3 campaigns there. Which one I should choose? [15:15:30] https://usercontent.irccloud-cdn.com/file/O2ydgUKb/3%20campaigns [15:15:45] glorian_wd, seriously? [15:15:48] The item quality one. [15:15:50] yeah [15:15:58] Oh those are worksets. [15:16:03] yes [15:16:21] Empty ones because you didn't label anything before 48 hours. [15:16:24] Request a new one. [15:17:22] halfak: I see. So everyone must request a workset prior to starting labeling items? [15:17:27] Yup [15:17:37] noted. [15:18:00] I will post the invitation on Wikidata project chat shortly. cc: Lydia_WMDE [15:18:50] Not in production yet. [15:18:56] But yeah, start working on the prose. [15:19:19] I think I'm ready for a deployment. [15:19:29] Amir1, any concerns with me doing a wikilabels deploy right now? [15:19:44] ah right! I thought it has been deployed. I have just realized it's still in staging [15:19:58] * halfak works on cards [15:19:58] nah, I'm around working on wiidata, ping me if there is anything [15:20:02] kk [15:20:25] 06Revision-Scoring-As-A-Service, 10Wikilabels: Late march wikilabels deployment - https://phabricator.wikimedia.org/T161002#3118017 (10Halfak) [15:20:49] 06Revision-Scoring-As-A-Service, 10Wikidata, 10Wikilabels, 13Patch-For-Review, 15User-Ladsgroup: Wikidata items render badly in Wikilabels - https://phabricator.wikimedia.org/T160256#3093284 (10Halfak) a:05Ladsgroup>03Halfak [15:21:06] 06Revision-Scoring-As-A-Service, 10Wikidata, 10Wikilabels, 13Patch-For-Review, 15User-Ladsgroup: Wikidata items render badly in Wikilabels - https://phabricator.wikimedia.org/T160256#3093284 (10Halfak) [15:21:09] 06Revision-Scoring-As-A-Service, 10Wikidata, 10Wikilabels: Deploy the pilot of Wikidata item quality campaign - https://phabricator.wikimedia.org/T159570#3118038 (10Halfak) [15:21:11] 06Revision-Scoring-As-A-Service, 10Wikilabels: Late march wikilabels deployment - https://phabricator.wikimedia.org/T161002#3118036 (10Halfak) [15:21:59] 06Revision-Scoring-As-A-Service, 10Wikidata, 10Wikilabels, 13Patch-For-Review, 15User-Ladsgroup: Wikidata items render badly in Wikilabels - https://phabricator.wikimedia.org/T160256#3118040 (10Glorian_WD) @Halfak : I think we can close this ticket already? [15:25:01] Looks like we have some rendering issues that are still there in prod. [15:25:16] But with the form and not items. looking into that asap [15:25:38] halfak: actually I havent realized where the problem is [15:25:58] is it something regarding to the width? [15:26:47] maybe you are referring to the workspace width (i.e. workspace is the place where the item is shown). [15:27:05] Form and not items. [15:29:15] 06Revision-Scoring-As-A-Service, 10Edit-Review-Improvements-RC-Page, 10ORES, 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017): Conform ORES sensitivity levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3118057 (10jmatazzoni) OK. Thanks Aaron. Let's move forward as planned... [15:33:52] 06Revision-Scoring-As-A-Service, 10Edit-Review-Improvements-RC-Page, 10ORES, 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017): Conform ORES sensitivity levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3118065 (10jmatazzoni) [15:36:08] :P to glorian_wd for pinging me about closing a task while I'm doing the work to close it. [15:36:30] halfak: oh sorry. Previously I thought you have finished it : [15:36:32] :) [15:36:57] my intention was just to help you in updating the task on that phab [15:38:01] :) [16:00:01] 06Revision-Scoring-As-A-Service, 10Edit-Review-Improvements-RC-Page, 10ORES, 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 07User-notice: Enable the ORES good faith and damaging UI by default, on wikis that have these ORES models available (i... - https://phabricator.wikimedia.org/T158225#3118125 [16:06:14] 06Revision-Scoring-As-A-Service, 10Wikidata, 10Wikilabels: Deploy the pilot of Wikidata item quality campaign - https://phabricator.wikimedia.org/T159570#3118146 (10Halfak) ``` halfak@wikilabels-01:~/backups$ pg_dump -h wikilabels-database --user u_wikilabels u_wikilabels -W | gzip -c > 2017-03-21.sql.gz Pas... [16:06:36] 06Revision-Scoring-As-A-Service, 10Wikidata, 10Wikilabels: Deploy the pilot of Wikidata item quality campaign - https://phabricator.wikimedia.org/T159570#3071810 (10Halfak) a:05Glorian_WD>03Halfak [16:06:46] 06Revision-Scoring-As-A-Service, 10Wikilabels: Late march wikilabels deployment - https://phabricator.wikimedia.org/T161002#3118017 (10Halfak) a:03Halfak [16:07:04] OK board is cleaned up. [16:08:14] 06Revision-Scoring-As-A-Service, 10Beta-Cluster-Infrastructure, 10ORES, 15User-Ladsgroup: deployment-ores-redis /srv/ redis is too small (500MBytes) - https://phabricator.wikimedia.org/T160762#3118160 (10Ladsgroup) This should make it less severe until I migrate it to a bigger instance [16:11:41] 06Revision-Scoring-As-A-Service, 10Wikilabels, 10rsaas-editquality: Complete hewiki edit quality campaign - https://phabricator.wikimedia.org/T130263#2131236 (10Doror) >>! In T130263#3117583, @Ladsgroup wrote: > I need to thank @Amire80 for his great work on pushing this. Thanks :) +1 [16:17:29] awight|afk, I'm really clearly seeing what you were saying about having ScoreRequest and ScoreResponse objects. [16:17:30] :) [16:17:57] I'm exploring that right now as a way to capture "precache" of the request for better metrics. [16:18:33] (in ORES) [16:31:03] * glorian_wd reading halfak's messages [16:31:14] glorian_wd, ready for announcement. [16:31:38] halfak: yeah. I am looking for the WikiLabels link [16:33:07] halfak: this one http://labels.wmflabs.org/ui/wikidatawiki/ right? [16:33:25] yup [16:35:19] halfak: ok. I am working on the announcement [16:41:18] Amir1, looks like ores-beta is thoroughly broken due to disk space issues. [16:41:19] halfak, Lydia_WMDE: posted on https://www.wikidata.org/wiki/Wikidata:Project_chat#Item_Quality_Pilot_Campaign [16:41:37] MISCONF Errors writing to the AOF file: No space left on device [16:41:39] https://ores-beta.wmflabs.org/v2/scores/testwiki/damaging/10 [16:41:57] I saw that you dis a flushall, but maybe it was the wrong redis. [16:42:12] Oh wait. I might be able to do this rather than bothering you. [16:42:14] * halfak checks. [16:55:12] halfak: BTW, thanks for deploying the campaign [16:55:15] :) [16:56:23] glorian_wd, no problem. happy we got the road blocks out of the way :) [16:56:32] halfak: yeah finally. [16:56:55] halfak: oh dont forget to check my clustering work if you have time [17:01:36] halfak: lol I'd love to help redesigning that [17:01:44] encapsulation is joyous [17:02:03] I'm working on how a ScoreResponse will do formatting now. [17:02:15] It's nice to encapsulate v1 and v2 response structures there :) [17:03:10] awight, I'll ping the PR when I have something :) [17:04:16] IMHO, stay away from the ActiveRecord pattern as much as possible. [17:04:32] A data encapsulation should at most have accessors. [17:04:42] Any more interesting transformations and operations should be in other classes [17:04:54] like, ScoreReponseFormatter [17:05:29] * halfak feels like that is starting to sound like Java [17:05:30] :P [17:05:46] maybe just def format_response() in each versioned route module [17:07:11] eh whereever you want to put it, but IMO outside the data object [17:08:05] eventually we'll have three different output formats or something, and it shouldn't be a scoreresponse responsibility to know about any of that [17:08:38] * awight waxes pedantic [17:08:39] hm... seems OK to me [17:17:12] OK lunch time. [17:44:20] (03CR) 10Catrope: [C: 04-1] "You did not update qqq.json (neither the message keys nor the actual documentation) for the logactions->typeofchange change." [extensions/ORES] - 10https://gerrit.wikimedia.org/r/343783 (https://phabricator.wikimedia.org/T160803) (owner: 10Mooeypoo) [17:47:47] Back! [17:47:54] Back! [17:48:03] wups [18:30:16] (03CR) 10Mooeypoo: "> You did not update qqq.json (neither the message keys nor the" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/343783 (https://phabricator.wikimedia.org/T160803) (owner: 10Mooeypoo) [18:51:50] (03PS3) 10Mooeypoo: Add conflicts for category changes [extensions/ORES] - 10https://gerrit.wikimedia.org/r/343783 (https://phabricator.wikimedia.org/T160803) [20:02:29] 06Revision-Scoring-As-A-Service, 10MediaWiki-extensions-ORES, 13Patch-For-Review, 07Performance: Concerns about ores_classification table size on enwiki - https://phabricator.wikimedia.org/T159753#3119157 (10Tgr) Limiting `ores_classification` to `recentchanges` rows means losing the ability to filter user... [20:07:54] 06Revision-Scoring-As-A-Service, 10MediaWiki-API: Forward request data in proxied Action API modiles - https://phabricator.wikimedia.org/T161029#3119166 (10Tgr) [20:08:13] 10Revision-Scoring-As-A-Service-Backlog, 10ORES: Implement parallel connection limit for querying ORES - https://phabricator.wikimedia.org/T148997#3119179 (10Tgr) [20:08:15] 10Revision-Scoring-As-A-Service-Backlog, 10ORES: [Spec] Tracking and blocking specific IP/user-agent combinations - https://phabricator.wikimedia.org/T137962#3119180 (10Tgr) [20:08:17] 06Revision-Scoring-As-A-Service, 10MediaWiki-API: Forward request data in proxied Action API modiles - https://phabricator.wikimedia.org/T161029#3119178 (10Tgr) [20:56:56] halfak: around? [20:57:06] Yeah. What's up? [20:57:18] I wanted to label some edits for fawiki [20:57:31] and it seems the rtl is messed up a little [20:57:47] also when you select an option, it's almost invisible [21:02:19] yuck. looking [21:02:55] Can you tell me more about what's messed up here. [21:03:00] It's hard for my eyes to see it all. [21:04:11] Amir1, ^ [21:04:35] Are not sure checkbox is on the text [21:04:56] also yes and no buttons should flip [21:05:03] (look at the borders) [21:10:46] Gotcha. Not sure why this happened. I can take a pass at it. [21:10:56] Or would you like to? [21:13:29] Amir1, ^ [21:13:46] not sure [21:13:52] I can check and tell you soon [21:27:07] OMG. The checkbox is so weird. [21:35:49] Amir1, https://github.com/wiki-ai/wikilabels/pull/169 [21:35:53] I fixed some of the issues. [21:35:59] nice [21:36:00] If you think this is good, feel free to merge. [21:36:00] Thanks! [21:36:06] But I think you'll find more than I did. [21:36:40] halfak: Is it okay if push to your PR and merge it? [21:36:58] Amir1, yup [21:37:11] I'll side with your judgement if you want to do a deployment. [21:38:12] 06Revision-Scoring-As-A-Service, 10ORES: Exclude precaching requests from cache_miss/cache_hit metrics - https://phabricator.wikimedia.org/T159502#3119752 (10Halfak) I did a bunch of work on this today. I'm working on developing `ScoreRequest` and `ScoreResponse` classes that will preserve information about t... [21:40:27] halfak: okay! [21:40:28] Thanks [22:00:17] 10Revision-Scoring-As-A-Service-Backlog, 10ORES, 06Operations: [spec] Active-active setup for ORES across datacenters (eqiad, codfw) - https://phabricator.wikimedia.org/T159615#3119850 (10mobrovac) What about setting ORES up behind RESTBase and use Cassandra? In that case it wouldn't even matter where the re... [22:26:08] halfak: And they are merged now [22:26:15] Do you want me to deploy now? [22:26:24] I tested the UI in experiment [22:31:44] I deploy tomorrow