[14:48:24] o/ [14:56:21] 10Revision-Scoring-As-A-Service-Backlog, 10Wikilabels: Complete Romanian Wikipedia edit quality campaign - https://phabricator.wikimedia.org/T156517#3203393 (10Halfak) [16:03:21] o/ [16:03:38] I was only three minutes late. That's promising [16:04:09] halfak: I have some PRs in wikilabels, do you have a minute to review? [16:04:15] Yup :) [16:05:07] Oh yeah. Saw this. Was thinking that maybe the real bug is that "destructive" and "constructive" do not show their selected state well. [16:05:32] I think I'm OK with merging this, but I need to dig up that phab task and make sure that it's described appropriately. [16:08:02] Thanks [16:09:19] halfak: my plan for today is https://phabricator.wikimedia.org/T161376 and https://phabricator.wikimedia.org/T139956 [16:09:30] If you have anything else in mind please do tell [16:14:10] 06Revision-Scoring-As-A-Service, 10Bad-Words-Detection-System, 10revscoring, 07Bengali-Sites, 15User-Ladsgroup: Add language support for Bengali - https://phabricator.wikimedia.org/T162620#3203468 (10Aftabuzzaman) @Halfak done [16:15:04] 06Revision-Scoring-As-A-Service, 10OOjs-UI, 10Wikilabels, 15User-Ladsgroup: On labels.wmflabs.org, make the blue buttons more visible when they have been selected - https://phabricator.wikimedia.org/T163222#3190410 (10Halfak) Merged these and filed {T163623} because I think that's a bug. [16:16:28] Amir1, I think that sounds great. [16:16:30] Amir1, I was thinking I might have time to do some sketches for the ORES model info interface, but I think that'll have to wait for later. [16:16:48] I'm going to try to get the revscoring refactoring finished off. I'm just writing out the documentation now. [16:17:18] I've been doing lots of cross-validation tests of our models. It's easy to accidentally break model performance when you configure the system to do scaling and that sort of stuff internally. [16:17:22] great! [16:17:51] It seems Bengali is finished. Getting it merged with revscoring would be an easy task too [16:18:37] Nice! [16:18:39] \o/ [16:39:08] Why do people right regular expressions in our BWDS stuff!? [16:39:09] lol [16:39:37] *write [16:39:45] * halfak drinks more coffee [17:44:12] 06Revision-Scoring-As-A-Service, 10revscoring: Implement "thresholds", deprecate "pile of tests_stats" - https://phabricator.wikimedia.org/T162217#3155892 (10Halfak) Ready for review! https://github.com/wiki-ai/revscoring/pull/307 [17:45:30] Amir1, ^ for when you feel like looking through a big pile of stuff. [17:45:48] :)))) [17:45:57] Fun story, we have way more functionality and a lot more flexibility and I've cut down the # of lines by 300 [17:46:08] Less fun story, I still changes 3000 lines. [17:46:13] sure. I'm about to finish early parts of genetic algorithm [17:46:32] once I'm done, I review yours [17:46:34] cool :) that'll be a nice thing to integrate to our tuner [17:46:42] 3000 lines /o\ [17:46:51] I've been busy [17:47:00] I spent all of easter weekend working on this [17:48:34] Awesome [18:05:30] Sorry. Pushed a bit more cleanup to the PR, but I'm done now. [18:05:46] I'm running away. Got a hot date. ;) o/ [18:05:52] Have a good one, Amir1 [18:16:16] you too