[00:00:00] I've got some working models for fiwiki damaging/goodfaith [00:00:01] :) [00:08:02] 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Train/test damaging & goodfaith model for Finnish Wikipedia - https://phabricator.wikimedia.org/T163012#3208389 (10Halfak) a:03Halfak [00:08:06] 06Revision-Scoring-As-A-Service, 10rsaas-editquality: Train/test damaging & goodfaith model for Finnish Wikipedia - https://phabricator.wikimedia.org/T163012#3183245 (10Halfak) https://github.com/wiki-ai/editquality/pull/67 [00:08:18] Yay [00:09:18] Might even be able to get them deployed next :) [00:09:29] RoanKattouw, BTW, I finished the work on thresholds (probably, still in review) [00:09:36] Ooh, nice [00:09:44] Oh, good news BTW [00:10:16] ORES is now on by default except for a few wikis on a blacklist [00:10:27] And the RCFilters beta feature is also available on "all wikis except ..." [00:10:50] Cool :) I'm working with Jeff on an announcement about ORES funding. That'll be a good thing to say too :) [00:11:00] So when you enable the ORES extension for fiwiki, you don't have to do anything special, it'll already get (have!) RCFilters and it'll have ORES by default from the get-go [00:11:35] Nice. Will it just pick up the current threshold metrics? [00:11:41] "All wikis except XYZ" will change to "All wikis period" on May 9th, the "except" bit is just part of our staged rollout [00:11:47] Yes, it will, once that code rolls out [00:11:53] (Thursday) [00:12:03] So we won't have to hand-code them into the config anymore [00:12:11] I set some defaults based on what the most common settings seemed to be [00:12:27] Cool. So, um, when I deploy this thresholds thing, we're going to need to change how you do that. [00:12:27] But we will still want to take a look at the model's properties and decide whether those defaults are appropriate [00:12:33] Yes [00:12:43] OK. Just so long as you're ready for that :)) [00:12:56] I am, so long as it's going to be backwards-compatible for at least a week or so [00:13:42] As in, at least one of our code bases (either Extension:ORES or the service) is going to need to be able to deal with both for a little while [00:14:10] Hmm... that's an interesting (but not unreasonable) requirement. [00:14:21] I'll need to make some changes. [00:14:28] We can do either backwards compat on your side, or forwards compat on our side [00:14:36] Oh good point [00:14:39] 10Revision-Scoring-As-A-Service-Backlog, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-ORES, 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017): ORES on en.wiki chokes on "V. likely good faith" + "Likely have problems" - https://phabricator.wikimedia.org/T163757#3208414 (10jmatazzoni) [00:14:40] In the latter case, you don't have to do anything [00:14:49] Except that you can't deploy your thresholds code until we tell you you can [00:14:56] hmm.. Let me check that out and see if it can be easy on the ORES side. [00:15:05] Yeah we should just do it wherever it's easiest [00:15:08] That'd be OK. You're my target audience for that anyway :) [00:15:22] The only qualm I have about doing it on our side is that we have to have something to test against [00:15:47] RoanKattouw, can do that. We're running in wmflabs and can deploy there first. [00:15:55] Right, exactly, I was about to suggest that [00:16:59] That's a big reason why we have the wmflabs cluster running. (note, not ores-beta) [00:17:11] ores.wmflabs.org can actually handle requests at a high capacity. [00:42:39] OK, cool [00:43:21] I am happy with that strategy, but just be aware that that means you can't deploy your breaking API change until we're ready for it, which may end up meaning that you can't deploy changes to the ORES service for a little bit (or only with difficulty) [00:53:57] 10Revision-Scoring-As-A-Service-Backlog, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-ORES, 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017): ORES on en.wiki chokes on "V. likely good faith" + "Likely have problems" - https://phabricator.wikimedia.org/T163757#3208481 (10Catrope) The... [01:45:49] (03PS4) 10Catrope: Align damaging thresholds to filters thresholds [extensions/ORES] - 10https://gerrit.wikimedia.org/r/346188 (https://phabricator.wikimedia.org/T160575) (owner: 10Sbisson) [01:47:28] (03CR) 10jerkins-bot: [V: 04-1] Align damaging thresholds to filters thresholds [extensions/ORES] - 10https://gerrit.wikimedia.org/r/346188 (https://phabricator.wikimedia.org/T160575) (owner: 10Sbisson) [01:47:53] (03CR) 10Catrope: "PS4: Don't hardcode the bad levels, because some of them might be disabled in config. Also use ->text() instead of ->parse() to avoid doub" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/346188 (https://phabricator.wikimedia.org/T160575) (owner: 10Sbisson) [01:55:20] (03CR) 10Catrope: [C: 031] "I'd like to merge this, but does anyone know why the tests are failing? It doesn't seem like this patch should have caused us to hit broke" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/346188 (https://phabricator.wikimedia.org/T160575) (owner: 10Sbisson) [02:43:47] 10Revision-Scoring-As-A-Service-Backlog, 10ORES: Bad Request (400) on testwiki test models - https://phabricator.wikimedia.org/T163764#3208633 (10Mattflaschen-WMF) [02:46:17] 10Revision-Scoring-As-A-Service-Backlog, 10ORES: Bad Request (400) on testwiki test models - https://phabricator.wikimedia.org/T163764#3208646 (10Mattflaschen-WMF) @Ladsgroup In case we want to look in the future, where are the logs for this? [02:48:33] T163764 is slowing down local work on MediaWiki-Vagrant (not sure if affects real requests as well). Wondering if you could take a look. [02:48:34] T163764: Bad Request (400) on testwiki test models - https://phabricator.wikimedia.org/T163764 [09:29:49] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I don't fully understand the big picture, but I found so many smaller issues, I believe they justify an edit request (-1)." (0311 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/344815 (https://phabricator.wikimedia.org/T161029) (owner: 10Gergő Tisza) [10:50:21] (03PS5) 10Sbisson: Align damaging thresholds to filters thresholds [extensions/ORES] - 10https://gerrit.wikimedia.org/r/346188 (https://phabricator.wikimedia.org/T160575) [10:51:43] (03CR) 10jerkins-bot: [V: 04-1] Align damaging thresholds to filters thresholds [extensions/ORES] - 10https://gerrit.wikimedia.org/r/346188 (https://phabricator.wikimedia.org/T160575) (owner: 10Sbisson) [11:01:53] (03PS6) 10Sbisson: Align damaging thresholds to filters thresholds [extensions/ORES] - 10https://gerrit.wikimedia.org/r/346188 (https://phabricator.wikimedia.org/T160575) [11:07:50] (03CR) 10Sbisson: "PS5 and PS6 change the options of the sensitivity preference to 1) consider those who might be disable and 2) never include likelygood." [extensions/ORES] - 10https://gerrit.wikimedia.org/r/346188 (https://phabricator.wikimedia.org/T160575) (owner: 10Sbisson) [11:29:18] (03PS7) 10Sbisson: Align damaging thresholds to filters thresholds [extensions/ORES] - 10https://gerrit.wikimedia.org/r/346188 (https://phabricator.wikimedia.org/T160575) [12:24:29] 10Revision-Scoring-As-A-Service-Backlog, 10Mobile-Content-Service, 10ORES, 06Reading-Infrastructure-Team-Backlog: MCS endpoint checks timing out / flapping in production again - https://phabricator.wikimedia.org/T146933#3209452 (10NHarateh_WMF) [12:24:40] 10Revision-Scoring-As-A-Service-Backlog, 10Mobile-Content-Service, 10ORES, 06Operations, and 2 others: Limit resources used by ORES - https://phabricator.wikimedia.org/T146664#3209453 (10NHarateh_WMF) [12:30:35] 06Revision-Scoring-As-A-Service, 10Mobile-Content-Service, 10ORES, 10RESTBase-API, and 3 others: Add ORES WP10 data to summaries? - https://phabricator.wikimedia.org/T157132#3209573 (10NHarateh_WMF) [14:12:56] 10Revision-Scoring-As-A-Service-Backlog, 10ORES, 07Documentation: Make ORES meta documentation translatable - https://phabricator.wikimedia.org/T163786#3209937 (10Halfak) [14:16:05] 10Revision-Scoring-As-A-Service-Backlog, 10ORES, 07Documentation: Make ORES meta documentation translatable - https://phabricator.wikimedia.org/T163786#3209950 (10Halfak) I think we'll want to look at our documentation and seriously ask ourselves what we're OK with becoming calcified against changes (what ge... [14:22:08] 10Revision-Scoring-As-A-Service-Backlog, 10ORES: Convert "Get support" from a phab process to an on-wiki process - https://phabricator.wikimedia.org/T163787#3209970 (10Halfak) [14:26:34] 10Revision-Scoring-As-A-Service-Backlog, 10ORES, 07Documentation: Make ORES meta documentation translatable - https://phabricator.wikimedia.org/T163786#3209977 (10Halfak) [14:26:36] 06Revision-Scoring-As-A-Service, 10ORES, 07Documentation, 07Epic: [Epic] Clean up ORES service documentation - https://phabricator.wikimedia.org/T148974#3209976 (10Halfak) [14:27:38] 10Revision-Scoring-As-A-Service-Backlog, 07Documentation: Design a good way document models in progress for ORES - https://phabricator.wikimedia.org/T132438#3209979 (10Halfak) [14:27:40] 06Revision-Scoring-As-A-Service, 10ORES, 07Documentation, 07Epic: [Epic] Clean up ORES service documentation - https://phabricator.wikimedia.org/T148974#2738206 (10Halfak) [14:27:56] 10Revision-Scoring-As-A-Service-Backlog, 07Documentation: Design a good way document models in progress for ORES - https://phabricator.wikimedia.org/T132438#2198562 (10Halfak) [14:27:58] 06Revision-Scoring-As-A-Service, 10Wikilabels, 15User-Ladsgroup: Move campaign progress interface to wikilabels repo/system - https://phabricator.wikimedia.org/T139956#3209981 (10Halfak) [14:59:45] 10Revision-Scoring-As-A-Service-Backlog, 10ORES: Convert "Get support" from a phab process to an on-wiki process - https://phabricator.wikimedia.org/T163787#3210053 (10Trizek-WMF) >>! In T163787#3209964, @Halfak wrote: > (...) when we've received a request from outside of phabricator, we've been able to work w... [15:01:09] 10Revision-Scoring-As-A-Service-Backlog, 10ORES: Convert "Get support" from a phab process to an on-wiki process - https://phabricator.wikimedia.org/T163787#3210057 (10Halfak) Workshops, conferences, posts on the ORES talk page, posts on the Wiki labels talk pages, posts on my personal talk page, emails, IRC. [15:19:59] 10Revision-Scoring-As-A-Service-Backlog, 10ORES: Convert "Get support" from a phab process to an on-wiki process - https://phabricator.wikimedia.org/T163787#3210147 (10Trizek-WMF) If you can deal posts on the ORES talk page because people put request there, maybe vous should have the two entries mentioned equa... [15:30:37] 10Revision-Scoring-As-A-Service-Backlog, 10ORES: Convert "Get support" from a phab process to an on-wiki process - https://phabricator.wikimedia.org/T163787#3210198 (10Halfak) So what you're saying is that there should be two Right(TM) ways to do things? Or should we just have a, "Ask questions on the talk pa... [15:38:31] uh oh. looks like I'm getting weird errors with the new ORES version. [15:38:39] I'm going to try to clean those up. [16:09:19] Amir1, https://github.com/wiki-ai/ores/pull/195 [16:09:26] Have some time to take a quick look at this? [16:11:39] I'm working on setting up a deployment for today. [16:12:36] I might just self-merge because this'll be non-controversial. [16:13:09] Hmm.. I think this should run in Beta for a bit first, so I'm not going to aim for a full deployment today. [16:18:12] 06Revision-Scoring-As-A-Service, 10ORES: Fix errorred state for missing rev_ids - https://phabricator.wikimedia.org/T163798#3210404 (10Halfak) [16:18:16] 06Revision-Scoring-As-A-Service, 10ORES: Fix errorred state for missing rev_ids - https://phabricator.wikimedia.org/T163798#3210417 (10Halfak) https://github.com/wiki-ai/ores/pull/195 [16:18:25] 06Revision-Scoring-As-A-Service, 10ORES: Fix errorred state for missing rev_ids - https://phabricator.wikimedia.org/T163798#3210418 (10Halfak) a:03Halfak [17:41:10] 06Revision-Scoring-As-A-Service, 10Edit-Review-Improvements-RC-Page, 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 05MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), 13Patch-For-Review: Create a preference for 'classic' ORES shading ... - https://phabricator.wikimedia.org/T163025#3210810 [17:48:47] 06Revision-Scoring-As-A-Service, 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10ORES: Let ERI order based on ORES scores - https://phabricator.wikimedia.org/T163040#3184283 (10jmatazzoni) Amir, it sounds like you'd like to have a reverted filter. Why not just request that we mark edits as Reve... [18:00:32] 06Revision-Scoring-As-A-Service, 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10ORES: Let ERI order based on ORES scores - https://phabricator.wikimedia.org/T163040#3210868 (10jmatazzoni) So, we did a little more research, and it turns out that Rollback is marked as patrolled, but Undo is not.... [18:03:10] 06Revision-Scoring-As-A-Service, 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10ORES: Let ERI order based on ORES scores - https://phabricator.wikimedia.org/T163040#3210871 (10jmatazzoni) As to enabling you to sort the results page, that would be amazing but would require redesign of the result... [18:46:42] 06Revision-Scoring-As-A-Service, 10Wikidata, 07artificial-intelligence: [Spike] Use suggested properties to get signal for completeness - https://phabricator.wikimedia.org/T158430#3211096 (10Halfak) a:05Glorian_WD>03Halfak [20:05:48] (03PS4) 10Gergő Tisza: Forward request data to ORES API [extensions/ORES] - 10https://gerrit.wikimedia.org/r/344815 (https://phabricator.wikimedia.org/T161029) [20:07:01] (03CR) 10Gergő Tisza: Forward request data to ORES API (035 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/344815 (https://phabricator.wikimedia.org/T161029) (owner: 10Gergő Tisza) [20:15:27] (03CR) 10Catrope: [C: 032] Align damaging thresholds to filters thresholds (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/346188 (https://phabricator.wikimedia.org/T160575) (owner: 10Sbisson) [20:17:03] (03Merged) 10jenkins-bot: Align damaging thresholds to filters thresholds [extensions/ORES] - 10https://gerrit.wikimedia.org/r/346188 (https://phabricator.wikimedia.org/T160575) (owner: 10Sbisson) [20:27:21] (03CR) 10Sbisson: Align damaging thresholds to filters thresholds (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/346188 (https://phabricator.wikimedia.org/T160575) (owner: 10Sbisson) [21:35:37] PROBLEM - ORES worker labs on ores.wmflabs.org is CRITICAL: CRITICAL - Socket timeout after 10 seconds [21:35:47] PROBLEM - ORES web node labs ores-web-03 on ores.wmflabs.org is CRITICAL: CRITICAL - Socket timeout after 10 seconds [21:35:48] PROBLEM - ORES web node labs ores-web-05 on ores.wmflabs.org is CRITICAL: CRITICAL - Socket timeout after 10 seconds [21:36:37] RECOVERY - ORES worker labs on ores.wmflabs.org is OK: HTTP OK: HTTP/1.1 200 OK - 457 bytes in 0.755 second response time [21:36:47] RECOVERY - ORES web node labs ores-web-05 on ores.wmflabs.org is OK: HTTP OK: HTTP/1.1 200 OK - 457 bytes in 1.261 second response time [21:36:47] RECOVERY - ORES web node labs ores-web-03 on ores.wmflabs.org is OK: HTTP OK: HTTP/1.1 200 OK - 457 bytes in 1.290 second response time [21:37:31] Weird. We usually don't get caught doing a deployment [21:42:36] 06Revision-Scoring-As-A-Service, 10ORES: Deploy ORES mid-April - https://phabricator.wikimedia.org/T162892#3178444 (10Halfak) https://gerrit.wikimedia.org/r/350311 [21:44:38] o/ Amir1 [21:44:57] Any chance you want to review https://gerrit.wikimedia.org/r/350311 before I push it to beta? [22:04:36] 06Revision-Scoring-As-A-Service, 10ORES: Deploy ORES mid-April - https://phabricator.wikimedia.org/T162892#3212187 (10Halfak) [22:04:38] 06Revision-Scoring-As-A-Service, 10ORES: Fix errorred state for missing rev_ids - https://phabricator.wikimedia.org/T163798#3212188 (10Halfak) [22:05:07] 06Revision-Scoring-As-A-Service, 10ORES: Deploy ORES mid-April - https://phabricator.wikimedia.org/T162892#3178444 (10Halfak) This is now running at https://ores.wmflabs.org and https://ores-beta.wmflabs.org [22:06:25] 06Revision-Scoring-As-A-Service, 10ORES: Deploy ORES mid-April - https://phabricator.wikimedia.org/T162892#3212193 (10Halfak) FYI: @Pchelolo. We'll likely be deploying this tomorrow. It'll make it so our `/precache` endpoint accepts a raw POST body JSON blob. Do you have a task that we should make this a su... [22:06:28] (03PS1) 10Catrope: Follow-up c047cd54d69ed: rename oresDamagingPref values back [extensions/ORES] - 10https://gerrit.wikimedia.org/r/350316 (https://phabricator.wikimedia.org/T160575) [22:08:18] (03CR) 10jerkins-bot: [V: 04-1] Follow-up c047cd54d69ed: rename oresDamagingPref values back [extensions/ORES] - 10https://gerrit.wikimedia.org/r/350316 (https://phabricator.wikimedia.org/T160575) (owner: 10Catrope) [22:17:35] 10Revision-Scoring-As-A-Service-Backlog, 10ChangeProp, 10ORES, 06Services (blocked): Change ORES rules to send all events to new "/precache" endpoint - https://phabricator.wikimedia.org/T158437#3212255 (10Pchelolo) [22:17:37] 06Revision-Scoring-As-A-Service, 10ORES: Deploy ORES mid-April - https://phabricator.wikimedia.org/T162892#3212254 (10Pchelolo) [22:17:47] 06Revision-Scoring-As-A-Service, 10ORES: Deploy ORES mid-April - https://phabricator.wikimedia.org/T162892#3178444 (10Pchelolo) @Halfak Added a subtask. [22:18:56] (03CR) 10Mattflaschen: [C: 04-1] Follow-up c047cd54d69ed: rename oresDamagingPref values back (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/350316 (https://phabricator.wikimedia.org/T160575) (owner: 10Catrope) [23:55:20] (03CR) 10Catrope: Follow-up c047cd54d69ed: rename oresDamagingPref values back (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/350316 (https://phabricator.wikimedia.org/T160575) (owner: 10Catrope) [23:57:05] (03CR) 10Catrope: Follow-up c047cd54d69ed: rename oresDamagingPref values back (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/350316 (https://phabricator.wikimedia.org/T160575) (owner: 10Catrope)