[16:38:08] <halfak|Mobile>	 o/
[16:39:09] <halfak|Mobile>	 But thought I'd pop in
[16:45:02] <glorian_wd>	 halfak|Mobile: o/
[17:58:10] <halfak|Mobile>	 I think my plan for today is to start having later in the day.  I'm talking advantage of the morning up "hack" up a tree from my yard.  
[17:58:50] <halfak|Mobile>	 I need to process it into firewood.  I'm  7 hours into a 12 hour job :/
[18:06:25] <paladox>	 halfak|Mobile your cuttin wood in your garden?
[18:09:09] <halfak|Mobile>	 https://goo.gl/photos/FDjuM13bACsQMyZo6
[18:10:43] <paladox>	 lol
[18:10:48] <paladox>	 that's alot of green
[18:28:53] <glorian_wd>	 halfak|Mobile: now I understand your "yardwork"  :)
[20:15:05] <glorian_wd>	 halfak|Mobile: still do the yardwork?
[20:43:20] <halfak|Mobile>	 Yup.  Holy crap am I exhausted.  Just taking a break for a very late lunch now
[20:43:44] <halfak|Mobile>	 It's a good thing I'm in shape or there's no way this would ever get done
[20:44:57] <glorian_wd>	 chill a bit halfak|Mobile :)
[20:45:49] <halfak|Mobile>	 So much stuff that needs to get done :@
[20:47:11] <glorian_wd>	 halfak|Mobile: So, I have created a directory called "Wikidata" under /revscoring/features/. Within this directory, I added the revision_oriented.py for both datasources and features. This revision_oriented file consists of new functions that I created, the ones that you said have to be moved to wikiclass.
[20:47:11] <glorian_wd>	 The idea is, I want to call these functions from  wikiclass/wikiclass/feature_lists/wikidatawiki.py
[20:47:19] <glorian_wd>	 halfak|Mobile: does my approach correct?
[20:47:20] <paladox>	 halfak|Mobile heh that's a long day
[20:47:49] <glorian_wd>	 if it's correct, at least, I can help you to move these stuffs to wikiclass :)
[20:48:15] <halfak|Mobile>	 Glorian, just add the features to wikidatawiki.py
[20:51:14] <glorian_wd>	 halfak|Mobile: what do you think if I created PR both on revscoring and wikiclass, then you can review the changes?
[20:51:51] <glorian_wd>	 create*
[20:56:18] <halfak|Mobile>	 I don't think you'd need to change anything in revscoring to do what you want to do
[21:00:24] <glorian_wd>	 halfak|Mobile: the change in revscoring is, adding a directory called "Wikidata" which consists of revision_oriented.py for both datasources and features. Does that necessary?
[21:00:45] <glorian_wd>	 This revision_oriented.py contains the new functions that I created
[21:02:55] <halfak|Mobile>	 No wikidata specific things in revscoring
[21:06:18] <glorian_wd>	 halfak|Mobile: hmm, could I put the functions' logic in wikidatawiki.py as well?
[21:23:25] <halfak|Mobile>	 Yes.  
[21:23:40] <halfak|Mobile>	 Generally that's what we do
[21:26:21] <glorian_wd>	 halfak|Mobile: Ok. Then I need to find way to test whether I can extract the features that I create on wikidatawiki.py. BTW, this is something that I have tried for couple hours, and still did not get how to do it :/
[21:26:38] <Zppix>	 o/
[21:27:01] <Zppix>	 halfak|Mobile:  need me to do anything?
[21:27:53] <halfak|Mobile>	 https://github.com/wiki-ai/wikiclass/blob/master/wikiclass/feature_lists/tests/test_enwiki.py
[21:28:02] <halfak|Mobile>	 glorian_wd: ^
[21:28:12] <halfak|Mobile>	 See the tests we have
[21:28:31] <halfak|Mobile>	 Zppix: I'm AFK.  But let me think.  
[21:28:57] <halfak|Mobile>	 Ooh!  I wanted to talk to you about getting more prod services running in labs
[21:29:11] <halfak|Mobile>	 E.g. change propagation
[21:29:15] <halfak|Mobile>	 Heard of it?
[21:29:28] <Zppix>	 yes, what exactly do you need though?
[21:34:11] <Zppix>	 halfak|Mobile:  ^
[22:27:36] <glorian_wd>	 halfak|Mobile: Gonna do it tomorrow. Thanks for the hint! good night!
[22:27:44] <glorian_wd>	 o/