[00:25:10] Zppix: sorry to drop off. Currently change prop only works in production so we have work arounds for labs in ORES. [00:25:50] Was hoping to get a mirror installation in labs. Folks a similar niche as icinga as general support for services [00:25:58] *fills [00:26:36] Also holy crap I'm finally done coping things up. It's amazing how much less *stuff* seems to be there after processing the tree [00:57:36] ok i will talk to paladox in a bit if hes around still [01:00:57] paladox are you about? [01:01:02] halfak|Mobile: ^ [01:04:50] so you want a mirror of prod? i mean just setup scap have a use the deployment-prep server and scap it to both prod and labs? [01:05:04] wmnet can scap to wmflabs but wmflabs cannot go to wmnet [01:05:36] halfak^ [01:11:07] Amir1: is https://github.com/wiki-ai/editquality/pull/24 ready for merge? [03:14:14] Zppix: nope [03:15:58] ack [03:16:25] Amir1: your on the coc committee no? [03:16:38] Yup [03:17:07] Amir1: We need a better explaintation on how it needs to be formatted, attribution, etc [03:17:53] for example https://github.com/wiki-ai/ores/pull/206 was denied due to the unclearness of repo inclusion of COC [03:18:50] Zppix: Well, as a CoC member my duty is to handle reports of violation. These kind of stuff should be tackled by talking in community [03:19:08] the workflow I had in mind was using code review in mediawiki core [03:19:13] which happened [03:19:24] Amir1: i know the workflow, im talking about attributon and such [03:19:46] Amir1: i also know commenting on that task is like talking to teens in a high school [03:20:11] :))) That's a fair point [03:20:29] The text is negligible to have attribution, etc. and it only links to the real CoC which has attribution (obviously) [03:20:36] so I don't think this would be needed [03:20:56] Amir1: That should be made *clear* [03:21:39] Yeah, but again, in those cases I'm not a CoC committee member as it means nothing here, I'm just a community member suggesting things [03:22:02] considering, mediawiki license its required to attribute [03:22:05] Zppix: Where do you think we need to make it clear [03:22:22] hell anywhere, a billboard, a simple notice, anything [03:25:22] hmm, okay. Let me see [05:21:09] wiki-ai/revscoring#1022 (pytz - 4dee4f7 : Amir Sarabadani): The build passed. https://travis-ci.org/wiki-ai/revscoring/builds/241661004 [11:51:48] Zppix hi i am now. [15:36:02] o/ [15:36:03] glorian_wd, [15:36:08] Saw you pinging me on hangouts [15:36:16] halfak: o/ [15:36:47] yeah. Basically, I am curious if it's possible to extract/print the value of the features that we create on wikidatawiki [15:37:11] That's what I sought last night. It seems that the extractor function in wikiclass works differently than the one in revscoring [15:37:48] That doesn't make any sense. [15:37:55] You shouldn't be using an extractor. [15:38:04] Just use solve() like in the tests I linked you to. [15:40:18] hmm ok let me try it again [15:40:29] :) [15:46:29] halfak i saw you talking about something todo with icinga and icinga monotoring services. Not sure what you meant though? [15:46:32] also hi [15:47:19] Hi paladox ! [15:47:37] :) [15:47:52] So I was thinking about your maintenance of labs-based icinga (which I think is great because it mirrors a critical service generally only available in production) [15:48:08] And was asking myself about other types of services I wanted from production. [15:48:16] And I thought ChangeProp would be a good idea. [15:48:23] Ah yep. [15:48:48] What do you think about maintaining another generalized service> [15:48:50] *? [15:49:09] Yep [15:49:37] You can have it monotore what ever services you want :) [15:49:38] No limits :) [15:50:14] I wonder if in puppet do they add the check for ChangeProp since i could copy [15:50:20] (migrate it to icinga2 format) [15:50:41] paladox, ahh. I wasn't clear. I was hoping to convince you to maintain ChangeProp in labs itself. :) [15:50:52] SInce you're maintaining icinga in labs. [15:50:56] Ah [15:51:00] what's ChangeProp? [15:51:20] Is it done by icinga? [15:51:32] It allows applications (like ORES) to respond to changes as they happen. E.g. a revision is saved, we score it and cache the score for future requests. [15:51:45] ChangeProp is entirely separate from icinga [15:51:56] But I figure that many apps in labs will want to use changeprop [15:52:02] Just like they will want to use icinga. [15:52:08] oh [15:52:19] how does that get setup? [15:52:30] That's a good question. I haven't looked into it. [15:52:34] Ok [15:52:46] I'm sure it has a nice scap/puppet setup [15:52:55] I had one other thought that you might be more interested in. git-lfs [15:53:04] is it this https://www.mediawiki.org/wiki/Change_propagation ? [15:53:11] Yup. that's it. [15:53:37] https://github.com/wikimedia/change-propagation [15:54:56] Will need help to setup that :) [15:57:14] I recomment asking about it in #wikimedia-services. Generally a nice bunch :) [15:57:56] I have a list of things that labs is lacking and should really have for basic prod-like support. [15:58:21] (ChangeProp, Scap, some git versioned file storage, etc.) [15:59:44] ok [16:00:00] halfak there's scap in labs [16:00:10] git-lfs i thought is also in labs [16:00:34] The scap doesn't seem to work for any-ol deployment (e.g. ores deploys outside of beta-labs) [16:00:41] Last I checked anyway. [16:00:48] I didn't know about git-lfs being available. [16:01:39] Oh [16:01:52] halfak anything in the wikimedia apt repo is installable on labs. Also the deployment puppet role seems to work for me. [16:10:42] halfak: im here fyi [16:14:17] halfak: you wanted memeory checks from icinga didnt you? [16:19:16] o/ Zppix [16:19:29] yeah. I suppose so. [16:19:52] halfak: also i reviewed the pytz pr amir created i think its good to merge? you agree? [16:20:13] link? [16:20:18] halfak that will requiring you to add the check_mem file to all the instances that you want the check on. [16:20:40] https://github.com/wikimedia/puppet/blob/e959321aa620b77403cc9379db2e86080323c6e8/modules/icinga/files/check_ram.sh [16:20:42] halfak: https://github.com/wiki-ai/revscoring/pull/323 [16:20:51] paladox, will need to find a way to do it with puppet. [16:20:57] Oh [16:21:14] Zppix, merged [16:21:15] add this https://github.com/wikimedia/puppet/blob/d0f5eaba58416f9d15e8fb05203cf08a6deebc3e/modules/icinga/manifests/plugins.pp#L100 puppet class [16:21:30] halfak: lol i could done that :P [16:21:39] halfak ^^ [16:21:58] Zppix, that readme still renders badly. [16:22:03] paladox, looking [16:22:09] ok thanks :) [16:22:25] halfak: what exactly are you not liking? [16:22:42] Compare the renderings side-by-side [16:22:52] There's a lot of obvious differences. [16:23:15] will do ill try to make it look similar if not make it look pretty [16:24:47] Sure! Improvements are welcome, but given the squash, you should put it in a separate PR [16:25:07] paladox, trying to figure out what exactly I need to do here. I don't do that much puppet. [16:25:24] Do I just require icinga::plugins in our base role? [16:26:36] yep [16:27:16] WTF puppet repo [16:27:18] Seriously [16:27:22] This thing is such a mess. [16:27:56] halfak got an error? [16:28:47] Na. Just trying figure out the right place to add it. [16:29:06] ok [16:29:21] halfak is your repo public? [16:29:38] puppet repo [16:30:04] https://github.com/wikimedia/puppet/tree/d0f5eaba58416f9d15e8fb05203cf08a6deebc3e/modules [16:30:14] oh [16:31:24] So I think I'm adding "require icinga::plugins" to https://github.com/wikimedia/puppet/blob/d0f5eaba58416f9d15e8fb05203cf08a6deebc3e/modules/ores/manifests/base.pp [16:31:27] Does that seem right? [16:31:38] yeh [16:31:45] hope this works :) and dosent fails :) [16:32:13] Looking more, it seems that I need the prepend "::", so more like "require ::icinga::plugins" [16:32:21] ah [16:32:41] try that :) [16:36:29] halfak: in order to call the test class, do I need to pass MediaWiki user ID? I keep getting this error 'AttributeError: module 'mwtypes' has no attribute 'User'' :/ [16:36:37] which points to my mwxml [16:38:03] MediaWiki user ID [16:38:07] What [16:38:10] Why [16:38:16] You're testing wikibase processing. [16:43:26] "test class" doesn't make sense either [16:43:28] glorian_wd, ^ [16:43:41] https://gerrit.wikimedia.org/r/358240 [16:43:57] Zppix, would you make a task on the Scoring-platform-team workboard for setting this up? [16:44:06] And assign it to yourself :D [16:44:29] That workboard is the way we track and report progress, so I want to make sure you make it into our next progress update for working on this. [16:48:57] halfak: task for what exactly sorry i've been in github [16:49:45] halfak: 1- I made a document for UX fixes, hope you saw it [16:50:26] Amir1: o/ sorry if i seem liked i was angry towards you last night this coc stuff is quite annoying to me :/ [16:50:33] 2- the blocker for one of the oldest bug is resolved now, I can fix it [16:51:06] Zppix: none at all, CoC discussions is heated and I don't think you were angry [16:51:51] Amir1: okay i just felt as i read the convo earlier again today i felt like i was being a bit out of line but whatever as long as we both agree no harm no foul :) [16:52:27] Exactly :) [16:53:34] Amir1: fyi i didnt know wb was defunct til after i made that pr im going to close it (if its not already) i already disabled wb-vandalisms ci cause its just a waste of resources :) [16:54:10] Zppix: that's great. Thanks. We should close it at some point at time, I don't know if github allows that [16:54:53] Ill look into that [16:55:08] halfak: sorry, I meant test function. [16:56:11] Amir1: i could disable all types of merging for prs on that repo, effecively disabling the repo unless a change is just pushed to master w/o pr and i coould add a notice in the master branch to use revscoring? [16:56:41] That would be great [16:57:02] ok doing it [16:57:26] ok i can disable them all but i disabled 2/3 of them ill add the notice [16:58:42] Amir1: halfak am i okay to directly push to wb-vandalism's master branch to put a notice to use revscoring repo instead since wb-vandalism is defunct? [16:59:55] okay on my side but IDK about halfak, specially this might be used somewhere I'm not aware of (and he would definitely know) [17:00:16] hence is why i asked both of you :) [17:00:54] halfak: So, I am trying to write test functions for wikidatawiki, similar to the one which you showed me last night. And I keep getting the error that I've mentioned above on the line where "import wikidatawiki" is placed. [17:10:24] Zppix, the task I was referring to was for memory checks [17:10:32] (sorry stepped away for a minute) [17:11:17] Amir1, I think wke should move that repo [17:11:27] So that it is Ladsgroup/wb-vandalism again [17:11:46] We don't use it at all. [17:12:02] glorian_wd, you need to be more specific about the error. [17:12:14] No one can help you with a paraphrased error message and no code. [17:12:48] Zppix, when you create the phab task, let me know and I'll post https://gerrit.wikimedia.org/r/358240 to it. [17:16:11] halfak: -backlog or the main board? [17:16:25] Main board. Active column. [17:17:35] halfak: https://phabricator.wikimedia.org/T167602 [17:17:48] halfak: The code is https://gist.github.com/GlorianY/f29e80f9a1c2843d22fd46b05aa09ce4. The line import wikidatawiki yields to an error " File "/usr/local/lib/python3.5/dist-packages/mwxml/iteration/user.py", line 6, in class User(mwtypes.User):AttributeError: module 'mwtypes' has no attribute 'User'". [17:19:13] What is in wikidatawiki.py? [17:19:14] Seriously? [17:20:33] what's the full error? [17:20:47] So I can figure out what line in wikidatawiki.py is erroring. [17:22:31] CUSTOM - check disk_space on Ores-worker-05 is OK: DISK OK 6gb left on / [17:25:35] halfak: the content of wikidatawiki is similar to https://github.com/wiki-ai/wikiclass/blob/master/wikiclass/feature_lists/wikidatawiki.py. [17:25:44] the full error is https://usercontent.irccloud-cdn.com/file/iEVaBaEu/the%20full%20error [17:25:49] seems pointing to mwxml [17:27:50] glorian_wd, are your requirements up to date? [17:28:20] halfak: (bug: Txxxx in the commit message is your friend) cough cough https://gerrit.wikimedia.org/r/#/c/358240/2//COMMIT_MSG [17:28:35] Zppix, you created the task after I uploaded the patchset [17:28:50] halfak: it doesnt matter the bot will still pick it up [17:29:24] i fixed it for you :P [17:29:48] Nice [17:30:54] glorian_wd: fyi revscoring has a requirement that was upgrade to a newer version please update accordingly that may be the issue [17:31:08] that was set today [17:31:20] halfak, Zppix : yea. I am trying on it now [17:31:49] halfak: should i send a email to wiki-ai mailing list about the pytz upgrade? [17:32:18] Zppix, na. But I think filing a task in "Done" would be good. It can go out with our next periodic update. [17:32:24] ok [17:32:45] E.g. https://phabricator.wikimedia.org/phame/post/view/52/status_update_june_3rd_2017/ [17:33:54] halfak: https://phabricator.wikimedia.org/T167604 [17:34:41] Perfect. [17:35:10] halfak: I have installed the latest packages on requirements.txt, and the same error still occurs. Strange [17:36:22] what file is this happening in ? [17:36:29] glorian_wd, https://gist.github.com/halfak/5c49a36d80f6e59fa1665dc898f2f2a8 [17:36:43] mwtypes==0.2.0 [17:39:21] My mwtypes==0.2.0 [17:41:57] mwxml==0.2.2 [17:43:35] halfak: https://gist.github.com/GlorianY/4f524642ff29ed7e164f1539bed54b0f [17:44:03] Mine is 0.3.1. I think it should be fine [17:44:11] hmm [17:48:11] Confirmed that all works with mwxml 0.3.1 [17:49:26] Let me try to degrade the mwxml [18:05:20] halfak is scb2005 your instance? [18:05:38] it is showing as down in #wikimedia-operations [18:06:24] halfak: I think the error is already solved once I degraded my mwxml. I will have a closer check after dinner [18:06:32] thanks! [18:06:35] * glorian_wd starving [18:06:39] halfak #wikimedia-services say there's an instance for changeprops [18:06:43] in beta cluster [18:06:57] paladox: you mean beta cluster? there's an instance on deployment-changeprop.deployment-prep.eqiad.wmflabs [18:24:53] paladox, we share that instance with a few others [18:25:01] Oh ok [18:25:25] paladox, the beta cluster changeprop propagates changes to the beta wikis. We want to propagate changes from the prod wikis to labs systems [18:25:41] oh [18:33:37] glorian_wd, that's weird. Mine worked with the current version of mwxml [18:47:28] do you need anything else halfak? [18:48:32] Been talking to paladox about setting up some other services in labs. [18:48:46] We'd use changeprop if it existed. [18:48:59] I'm also interested in talking about git-lfs or some other type of versioned large file storage. [18:49:16] halfak: https://lists.wikimedia.org/pipermail/wikitech-l/2017-June/088297.html [18:50:02] We have a lot of large files in the project (models and datasets for training/testing models) [18:50:18] It's a pain to check out the repo when you need to download all the history of all the models :( [18:50:40] Zppix, yeah. that's the person who sort of checked out and stopped responding on phab. Maybe he'll pick it back up again soon :) [18:50:57] gerrit i think doesnt do that paladox can you confirm that gerrit doesn force you to dl large files to preview them? [18:51:16] Zppix what's dl? [18:51:21] download [18:51:38] Nope gerrit dosent [18:52:07] um... this is git [18:52:23] gerrit 2.13.8+ supports git lfs with the git lfs plugin. [18:52:34] Sure. But we need a lfs server [18:52:37] https://github.com/GerritCodeReview/plugins_lfs [18:54:27] I'm sure releng would be willing to add that plugin? [18:54:49] surely we're not the only ones who would use lfs [18:56:40] Zppix, I've talked to them in the past and they were less enthusiastic. :\ [18:57:17] I'd really like to use git-lfs and it is critical that it is available to the public so you don't need prod access to contribute to our projects. [18:57:34] ill look into it if i find a lfs src control that would be combatible with our existing setup, and with wikimedia development standards ill let you know [18:57:52] We get a ton of contribs through github, so I want to be able to use it from there too. [18:57:54] Cool :) [18:58:34] i could ask github if they would be willing to work with us on that as well if you would like [18:58:38] Crap. Forgot to squash. [19:00:36] And now it's mixed together with other commits :\ [19:01:59] halfak: sorry i wish github allowed my cmd line to work instead of making me do 30 steps extra to just do commit [19:02:14] why revert? [19:02:18] Damn. There's no easy way to fix this. [19:02:30] Because the history is now full of bullshit [19:02:34] halfak: you cannot rewrite git history [19:02:40] Oh sure you can [19:02:53] rephrase:you cannot EASILY rewrite history [19:03:15] you would have to edit git objects etc etcf [19:03:43] Ill make sure from now on my prs always have a squash this comment :P [19:04:25] Damn damn damn. Why does it have to mix together all of the commits? [19:05:01] wiki-ai/revscoring#1032 (revert-321-md-from-rst - afb4781 : Aaron Halfaker): The build passed. https://travis-ci.org/wiki-ai/revscoring/builds/241794458 [19:06:45] halfak: it just takes like a picture of the commits in the origin branch of the pr and photoshops it to master (i know thats the worst explaination ever) [19:08:17] halfak: dont forget to schedule your puppet patch for deployment :) [19:09:22] how the hell did you do that? [19:09:33] * halfak flexes muscles. [19:10:08] halfak: ive seen your picture xD just kidding [19:11:00] * halfak is not sure if the joke is that I don't have muscles or that I do :S [19:11:39] both [19:13:00] lol [19:13:04] lol [19:13:30] you cant be mad if i say both now can you :P [19:15:50] Oh you can always be mad. ;) [19:15:56] But no of course not :D [19:16:55] lol [19:17:14] we need an ores bot i cant tell if you said that in good faith halfak :P [19:18:12] AGF [19:28:01] halfak: yeah that's a strange error. [19:39:07] halfak: I am seeing wikibase.py under /wikiclass/feature_lists now. I notice that there's "+1" on each attribute (e.g. wikibase.revision.claims + 1, wikibase.revision.properties + 1). I'm wondering if the underlying reason behind this. Hmm [19:41:30] log(0) is undefined. [19:42:19] Ok. And, why "log"? why not retrieve the original value (i.e. length of list)? [19:43:24] glorian_wd, there's a big difference between 2 and 3 statements. [19:43:36] There's not that much of a difference between 20 and 21 statements. [19:43:46] In a linear scale, the distance is the same. [19:43:50] In a log scale it isn't. [19:44:08] log(21) - log(20) = 0.02 [19:44:22] log(3) - log(2) = 0.18 [19:44:30] 21 - 20 = 1 [19:44:33] 3 - 2 = 1 [19:49:12] halfak: okay makes sense. Thanks :D [19:53:13] halfak: is there date for the wikilabels/ores deploy? [19:54:25] Zppix, not yet. But I'll likely do it this week. [19:55:17] k [19:56:21] halfak: https://git-lfs.github.com/ [19:56:33] Hey Zppix yeah. [19:56:37] I like it. [19:56:43] Not OK for deploys though :( [19:57:13] Would be great if we could somehow mirror the lfs into labs and/or our production environment [19:57:14] how are you currently doing deployments? [19:57:24] scap in prod, fabric on labs. [19:57:30] With models in the repo itself. [19:57:33] *model files [19:58:44] halfak: do you know if your prod server can talk to wmflabs servers? [20:00:44] if so you can scap to wmflabs from prod but for wmflabs to prod, maybe use a bot that keeps them sync'd similar to translatewiki bot [20:01:32] change prop from wmflabs to prod and prod to wmflabs isnt going to be easy [20:01:43] you can think firewalls and networking engineers for that [20:01:49] Zppix, no changeprop from labs to prod. [20:01:56] irregarldess its not easy [20:01:59] Instead from prod to labs to tools [20:02:14] prod to labs *should* be easy. [20:02:28] that is yes [20:02:44] prod iirc can talk to labs but labs cannot directly talk to prod [20:02:53] Right. [20:02:59] I've got to head out folks. [20:03:09] Time to do my late lunch again :S [20:03:12] ill talk to ops and bawolff [20:03:24] And then I should probably take some time off this afternoon (CDT) [20:03:26] :) [20:03:36] hey cdt is my timezone you thief [20:03:56] Zppix, tomorrow, ottomata will come online and will be very interested in helping out with making sure that EventBus works in labs. :) [20:04:07] I'll make sure you get introduced. :) [20:04:12] ok, ill talk to security about labs ->prod [20:04:14] ottomata is EDT [20:04:26] Have a good one! [20:04:27] o/ [20:04:31] you too [20:05:25] halfak: thanks for your help today. Have a good Sunday :) [20:05:42] glorian_wd: im here if you need me [20:06:00] Zppix: okay cool [20:06:49] glorian_wd: is the wikidatawiki thing a public statement if not thats the import error [20:07:22] Zppix: It's already solved after I degrade my mwxml [20:07:30] The error was really weird though. [20:07:42] mwxml what ver are you using now? [20:07:45] degraded* [20:07:55] the same version with halfak [20:08:05] 0.2.2 [20:08:21] this is wikiclass or revscoring repo? [20:18:10] Zppix: wikiclass [20:18:20] ok [20:19:47] glorian_wd: im setting requirements.txt to always install 0.2.2 [20:24:03] Zppix: but according to halfak , the latest one also works [20:24:45] Nonetheless, I guess it's safer to set mwxml 0.2.2 in the requirements [20:25:42] glorian_wd: end users should have to experiment thats our job in my opinion [20:25:53] shouldnt* [20:28:38] halfak lol a 3:30pm lunch :) [20:33:02] paladox: got any ideas about change prop? [20:33:09] all mine require talking to ops and security [20:33:38] Zppix nope, was talking to halfak today about that. [20:36:03] whoses all in security besides bawolf? [20:36:58] Reedy [20:37:43] ill try him [20:39:25] Zppix: gotcha [20:55:24] I suggest putting yourself on +g or +r botnets are starting to filter into freenode [22:16:05] Zppix: still there? [22:24:14] not for long ill be back around 8 cdt [22:24:21] pm* [22:25:03] Zppix: lol. I am already in bed at 8 PM CDT [22:25:10] okay then. no worries. [22:25:34] feel free to ask here and i can email you or something [22:25:37] thats really early [22:25:38] it's 23:25pm here :) [22:35:15] Zppix: No. I gotta go to sleep anyway. It's already 00:34 here :). Have a nice evening folks [22:36:15] Zppix: I initially wanted to ask you something. But let me try to get the answer myself first. If I get stucked again, I will ask here tomorrow :D