[12:16:23] 10Scoring-platform-team (Current), 10Wikilabels, 10editquality-modeling, 10Spanish-Sites, 10artificial-intelligence: Complete eswiki edit quality campaign - https://phabricator.wikimedia.org/T131963#3624122 (10Elitre) Congrats. (what about the empty checkboxes in description?) [13:31:56] PROBLEM - puppet on ores-redis-02 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [14:02:26] RECOVERY - puppet on ores-redis-02 is OK: OK: Puppet is currently enabled, last run 45 seconds ago with 0 failures [14:03:23] o/ [14:03:35] Hey Amir1! Around? [14:23:39] We really need to get the thresholds stuff deployed to beta. [14:34:40] 10Scoring-platform-team, 10JADE, 10Epic: Deploy JADE MVP API in labs - https://phabricator.wikimedia.org/T176333#3624521 (10Halfak) [15:04:40] halfak: I'm around now [15:04:53] I can work on it a little now [15:05:04] Just need to grab a coffee [15:05:13] let me know when you're around [15:05:14] Great! Thank you [15:05:24] In meeting now but should be done in 20 mins [15:39:16] halfak: let me know when it's done [15:40:56] done! [15:41:11] So. I'd like to get a beta deployment of new ORES out today. Is that crazy? [15:41:36] We're a day past our self-imposed deadline to go to prod (though we updated that deadline to 9/25) [15:42:36] halfak: well, we didn't make the patch in the extension [15:42:59] :/ So that still needs to be done. Sorry I didn't communicate well with you and Adam how pressing this was. [15:43:07] and tbh, I lost the track of things in the extension that's why it's hard to fix it [15:43:37] I know it was high priorty [15:44:41] OK. Do you think this is something you could work on today or tomorrow? I'll get everything else in place today. [15:46:57] halfak: I promise to work on it but what I want to make the things super fast is the example of thresholds [15:47:09] let me get the old one and check this out with you [15:47:25] Sure. :) [15:51:06] halfak: right now it calls https://ores.wikimedia.org/scores/enwiki/damaging/?model_info=test_stats&format=json [15:54:16] then based on the config tries to get threshold for keys defined in https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/InitialiseSettings.php#L18833 [15:54:25] Sure. Should probably call https://ores-misc.wmflabs.org/v2/scores/enwiki/damaging/?model_info=statistics.thresholds.true.%27maximum%20filter_rate%20@%20recall%20%3E=%200.9%27|statistics.thresholds.true.%27maximum%20filter_rate%20@%20recall%20%3E=%200.75%27&format=json [15:54:27] like "recall_at_precision(min_precision=0.99)" [15:55:28] FWIW: The order that the thresholds are listed in the result represents the same order that was given in the input. [15:55:48] So you can specify all relevant thesholds in the URL and then find them in the response. [16:00:01] fixing it, specially b/c compatabile is complex [16:00:16] I'm not sure if I can do it today [16:00:44] but probably tomorrow it will be done [16:01:22] Amir1, OK that sounds good. [16:01:48] We'll be able to do a beta deploy tomorrow. [16:01:57] I can do a labs deploy today. [16:02:10] awesome [16:37:57] 10Scoring-platform-team: Grafana has confusing or wrong scale for "scores errored" graph - https://phabricator.wikimedia.org/T175651#3624943 (10fdans) [21:50:31] 10Scoring-platform-team (Current), 10ORES: Fix v1 routes for model_info in ORES - https://phabricator.wikimedia.org/T176443#3625767 (10Halfak) [21:50:37] 10Scoring-platform-team (Current), 10ORES: Fix v1 routes for model_info in ORES - https://phabricator.wikimedia.org/T176443#3625780 (10Halfak) https://github.com/wiki-ai/ores/pull/225 [21:51:07] 10Scoring-platform-team (Current), 10ORES: Fix v1 routes for model_info in ORES - https://phabricator.wikimedia.org/T176443#3625783 (10Halfak) [21:55:36] o/ Amir1 [21:55:55] halfak: heyyy [21:56:00] IF you review some stuff for me, I'll get your reviews done too :D https://github.com/wiki-ai/editquality/pull/97 [21:56:31] https://phabricator.wikimedia.org/T174704 [21:56:35] These have been waiting :D [21:56:48] Not anymore! [21:56:52] :D [21:56:54] {{done}} [21:56:55] You rule, Amir1! [21:57:02] Thank you AsimovBot [21:57:21] wiki-ai/revscoring#1251 (srwiki - 6a6e009 : Amir Sarabadani): The build was fixed. https://travis-ci.org/wiki-ai/revscoring/builds/278383208 [21:57:28] I don't know what is up with https://github.com/wiki-ai/ores/pull/225 [21:58:21] i just restarted it [21:58:30] it might be a one-time bug [21:58:36] I did that too. [21:58:40] two time? [21:58:57] Same is happening here https://github.com/wiki-ai/revscoring/pull/363 [21:59:00] WTF [22:00:37] https://stackoverflow.com/questions/32947793/after-importing-nltk-nltk-download-is-not-working [22:00:47] A bunch of "cannot reproduce" [22:24:30] I give up. Need to go. Have a good one! [22:24:33] o/