[01:31:27] halfak: How long ago did you ping me? Just got it :) [01:31:52] I've been focusing on navigation vectors. Made decent progress, all things considered. [01:45:42] awight: Agreed, that was my idea, just try hitting the v2 API, and if that errors out try v1 [01:45:56] ("just"... it probably takes some work, but I think that gives us the best transition) [01:47:33] RoanKattouw: I think that’ll work well, and we’re already in good shape to fall back like that since we know that the old and new Stats classes coexist easily. I’ll just tweak the static factory method we use to get a Stats. [02:37:04] (03CR) 10Awight: "Thanks for the pointers, I'll add the fallback logic and config munging." (035 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/380893 (https://phabricator.wikimedia.org/T175053) (owner: 10Awight) [02:40:27] (03PS12) 10Awight: Support new thresholds API [extensions/ORES] - 10https://gerrit.wikimedia.org/r/380893 (https://phabricator.wikimedia.org/T175053) [06:40:44] (03PS13) 10Awight: [WIP] Support new thresholds API [extensions/ORES] - 10https://gerrit.wikimedia.org/r/380893 (https://phabricator.wikimedia.org/T175053) [06:41:33] (03CR) 10Awight: "PS13 Isn't ready for serious review yet, I still need to make tryFetchAPI safer for detecting server compatibility." [extensions/ORES] - 10https://gerrit.wikimedia.org/r/381261 (https://phabricator.wikimedia.org/T175053) (owner: 10Awight) [06:41:55] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Support new thresholds API [extensions/ORES] - 10https://gerrit.wikimedia.org/r/380893 (https://phabricator.wikimedia.org/T175053) (owner: 10Awight) [07:12:18] 10Scoring-platform-team, 10Community-Liaisons, 10JADE: Set up working group for JADE - https://phabricator.wikimedia.org/T170954#3656259 (10Qgil) Moving this task back to the #community-liaisons backlog. Is this support request still active? Is it expected to be continued in #liaisons-oct-dec-17 ? [13:15:43] (03PS1) 10Sbisson: RCFilters: highlight damaging levels [extensions/ORES] - 10https://gerrit.wikimedia.org/r/382162 (https://phabricator.wikimedia.org/T172757) [13:30:39] 10Scoring-platform-team (Current), 10DBA, 10MediaWiki-extensions-ORES, 10Blocked-on-schema-change, and 5 others: Concerns about ores_classification table size on enwiki - https://phabricator.wikimedia.org/T159753#3657239 (10Marostegui) >>! In T159753#3657238, @Stashbot wrote: > {nav icon=file, name=Mention... [13:42:41] o/ [14:42:24] 10Scoring-platform-team (Current), 10Collaboration-Team-Triage, 10ORES, 10Patch-For-Review: Make RCFilters compatible with both the old and new thresholds APIs - https://phabricator.wikimedia.org/T175053#3657427 (10Halfak) Looks like there is a misunderstanding here. There are not "TWO breaking changes".... [15:11:00] 10Scoring-platform-team, 10Edit-Review-Improvements-Integrated-Filters, 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Patch-For-Review, 10Wikimedia-log-errors: PHP Warning: Attempted to serialize unserializable builtin class Closure$Changes... - https://phabricator.wikimedia.org/T176236#3657507 [15:51:12] o/ awight [15:51:36] halfak: holla [15:52:27] I noticed something annoying while trying to update the extension’s threshold call [15:52:45] Since that call is heavily cached, I had to change the TTL from 1 day to 1 minute [15:53:28] The issue is that we won’t know about server code being switched without calling it :) [15:53:45] Calling "it"... What' [15:53:48] s "it"? [15:53:53] The ORES server? [15:53:56] yes [15:54:18] Right. makes sense. We only *need* to know that server code has changed when we need to call it. [15:55:09] Might be more suitable to do it in a maintenance script. Then we can run the script when we know that the ORES server code changed. [15:55:17] It could be part of the deploy process for ORES server. [15:55:39] I suppose we'll need to schedule the maint script separately. [15:56:12] That does sound better, but what does the extension do if it needs thresholds before the maint script is called... [15:56:30] * awight is always searching for the easiest path ;-) [15:56:43] awight, when might that happen? [15:57:01] We'll need to do a config deploy for the ext. to know about new models. [15:58:14] e.g. if the cache expires or when we first deploy code that uses a new cache key [15:58:41] my point is just that the frontend code should probably retain the ability to call the API when needed [15:58:55] so I might as well just keep the architecture the same for now [15:59:14] ooh—one moment, I need to reserve a room [15:59:58] I understand cache expiry (or rather invalidation) but not "new cache key" [16:00:22] I don't see how not calling the ORES server is being proposed :S [16:00:25] if we change how the key is constructed. Something I want to do, actually [16:00:31] ok jumping into the call, gimme 2min [16:36:06] 10Scoring-platform-team (Current), 10Collaboration-Team-Triage, 10ORES, 10Patch-For-Review: Make RCFilters compatible with both the old and new thresholds APIs - https://phabricator.wikimedia.org/T175053#3657906 (10awight) >>! In T175053#3657427, @Halfak wrote: > Looks like there is a misunderstanding here... [16:50:48] awight: halfak: the stakeholder list is up to 50+ names. Ready to start communicating? :) [16:50:57] Keegan: :D [16:51:01] Yes, I believe so [16:51:25] The last thing I wanted to do shouldn’t affect your first mailing (I believe), which would be to document exactly which languages were missing contacts for. [16:51:56] * Keegan nods [16:54:16] So IIRC, I'm going to contact these individuals with this message and send them to the JADE talk page for general feedback about what they want out of the tool [16:54:57] Then I'm going to email wikitech and wikidata and look for feedback for /Schema and /Implementation [16:54:59] Keegan: great! [16:55:18] Hmm, those subpages are a bit out of date [16:55:29] (I can wait on that, no problem) [16:55:39] I'll go ahead and get to the individuals after lunch [16:56:23] o/ Amir1! Welcome to official working lots of hours for ORES. [16:56:33] * halfak gets the artificial whip [16:56:34] ;) [16:56:41] halfak: Glad to be here :D [16:57:11] On second look, those subpages are current enough, they’re just messy. I’m okay with broadcasting. But would you mind sending the announcement by us first, and I can make sure we’re emphasizing the pressing questions? [16:57:18] So, FYI, I merged your PRs for eswiki and hrwiki. Those should be good to go in ORES. Do you want to update the wmflabs and prod deploy repos to include them? [16:57:21] Amir1, ^ [16:57:34] I have an open PR we could merge so it doesn't conflict/ [16:57:44] halfak: yeah sure [17:01:06] Amir1, https://github.com/wiki-ai/ores-wmflabs-deploy/pull/87 [17:01:18] BTW, you might want to merge this first or just build on it. [17:02:01] Related: https://gerrit.wikimedia.org/r/#/c/379935/ [17:02:31] I'm going to go grab lunch [17:02:33] back in a bit [17:03:40] 10Scoring-platform-team: Cached thresholds should be invalidated for new model versions. - https://phabricator.wikimedia.org/T177421#3658047 (10awight) [17:05:12] halfak: will do [17:09:45] Keegan: I made a sobering edit to that list of users, listing the wikis we don’t have contact info for yet. [17:10:48] We had staff assistance for some (e.g. fawiki and huwiki), and others were supported by volunteers from other wikis, and I didn’t document well enough to figure that out. [17:12:08] awight: Ah. That's okay. We can still draw them in where applicable. The point is to get varied experience on a range of wikis to participate. I think we'll get that. [17:12:26] excellent, I like that perspective. [17:14:40] (03CR) 10Ladsgroup: [V: 032 C: 032] Updates for revscoring 2.0.x [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/379935 (https://phabricator.wikimedia.org/T175180) (owner: 10Halfak) [18:28:40] (03CR) 10Catrope: [C: 031] RCFilters: highlight damaging levels [extensions/ORES] - 10https://gerrit.wikimedia.org/r/382162 (https://phabricator.wikimedia.org/T172757) (owner: 10Sbisson) [18:29:21] awight /me broke gerrit 2.15 rc 0 [18:29:22] lol [18:29:32] with the mysql connector update to 6.0.6 [18:29:34] it broke sql [18:29:50] so /me is reverting it in https://gerrit-review.googlesource.com/#/c/gerrit/+/130776/ [18:30:03] i suggest everyone to use mariadb connector over the mysql one [18:30:14] if they want stability and support for mariadb/mysql [18:57:23] halfak: Amir1: JMatazzoni came by with a question about rolling out the new RCFilters as the default. [18:57:49] He wants to know what we think about migrating people’s existing ORES preferences. [18:59:04] It’s a small blocker to their deployment, so I suggested that we might be fine with the old preferences getting thrown away. It might be good for these users to have to look at how to set up new RCFilters, and to see that there are many more ways to configure ORES in the new system. [18:59:06] Thoughts? [19:05:42] awight, no strong opinion. Will jmat be putting energy into making sure everything is in a good state for that? Or do they just want to throw a switch? [19:06:05] I think it’s in good state (to not migrate prefs) already. [19:06:06] Not sure about migrating preferences. I think this is more a question for user-research. [19:06:22] There’s a patch to do so, but it’s not through review yet. [19:06:35] E.g. how do people use these preferences and can people figure out what to do if we just switch them? [19:06:48] One other thought: what's the purpose of forcing a bunch of people to migrate? [19:07:23] Yeah that’s how I feel. My arbitrary gut feeling is that people will have to relearn the UI so making the prefs identical might actually slow them down? But that’s very arbitrary. [19:07:44] Forcing a migration? I don’t think it will be experienced like that. [19:07:57] The switch to making RCFilters the default is just a normal deployment [19:08:24] and the preferences migration would be a transparent thing they do to make the users’ default RCFilters behave very similarly to the old stuff. [19:09:04] I think I see what you’re saying. yeah without the prefs migration, the users have to click around a bit before their RC behaves the same. [19:12:23] Hmm... Yeah. I don't see a big issue with enabling by default so long as there's a fallback pathway. [19:12:44] halfak: What do you mean by fallback? [19:14:48] RoanKattouw: I need the new magic to get Watchlist to use RCFilters…. This doesn’t work for me: $wgStructuredChangeFiltersOnWatchlist = true; [19:14:58] awight, essentially, legacy ORES Review Tool functionality. [19:14:58] I do have the structured filters on RC [19:15:40] halfak: Kk. AIUI, the fallback only exists for no-javascript browsers? [19:15:41] E.g. by de-selecting "Give me new RCFilters" but keeping the "Use ORES highlighting" on or something like that. [19:16:11] awight, seems like we should make it a possibility for everyone. Or we could spin the roulette wheel and see if someone wants to shoot us for taking away their toy. [19:17:05] Well this is separate from the preferences issue, so I’ll tell them that from our non-user-research perspective we’re okay with lack of migration… [19:19:31] I’m not aware of any opt-out once RCFilters becomes the default. [19:19:43] I need fud. biab [19:24:42] halfak: Good news, there is still an opt-out. c.f. https://ca.wikipedia.org/wiki/Especial:Preferències?uselang=en#mw-prefsection-rc [19:24:50] “Hide the improved version of Recent Changes” LOL [19:24:56] Great! [19:25:00] That's just fine. [19:25:20] Maybe we should ask them to put quotes around "improved" just to preempt the trolls [20:06:56] halfak: I think it might already be troll bait, and intentional at that! [20:07:26] :) [20:52:57] (03CR) 10Catrope: [C: 032] RCFilters: highlight damaging levels [extensions/ORES] - 10https://gerrit.wikimedia.org/r/382162 (https://phabricator.wikimedia.org/T172757) (owner: 10Sbisson) [20:58:46] (03Merged) 10jenkins-bot: RCFilters: highlight damaging levels [extensions/ORES] - 10https://gerrit.wikimedia.org/r/382162 (https://phabricator.wikimedia.org/T172757) (owner: 10Sbisson) [20:58:55] Argh awight left 2 mins before I could answer [20:59:07] You need to enable that $wg AND enable the beta feature, it's a bit annoying [20:59:12] But Special:Watchlist?rcfilters=1 works too [20:59:39] (03PS1) 10Catrope: RCFilters: highlight damaging levels [extensions/ORES] (wmf/1.31.0-wmf.2) - 10https://gerrit.wikimedia.org/r/382301 (https://phabricator.wikimedia.org/T172757) [21:28:06] o/ RoanKattouw [21:28:16] Did you see my ping in -collaboration? [21:28:33] Heya [21:28:38] Yeah I did [21:28:44] I'll ask Joe to look at it and respond [21:28:59] We're launching to all wikis (except a few FlaggedRevs wikis) tomorrow so we're a bit busy :) [21:32:20] Just saw the email re. transition from beta feature. [21:32:30] Was there an announcement that this was coming that I missed? [22:35:10] O/ halfak hows it going? [22:35:34] o/ Zppix [22:35:40] was just about to step away :/ [22:36:44] Oh well have a great night halfak :P [22:36:49] You too :) [23:19:22] (03CR) 10Catrope: [C: 032] RCFilters: highlight damaging levels [extensions/ORES] (wmf/1.31.0-wmf.2) - 10https://gerrit.wikimedia.org/r/382301 (https://phabricator.wikimedia.org/T172757) (owner: 10Catrope) [23:26:37] (03Merged) 10jenkins-bot: RCFilters: highlight damaging levels [extensions/ORES] (wmf/1.31.0-wmf.2) - 10https://gerrit.wikimedia.org/r/382301 (https://phabricator.wikimedia.org/T172757) (owner: 10Catrope)