[00:08:47] RoanKattouw: k I’m unblocked and deploying the revscoring 2.x service on beta now. [00:08:52] should be up. [00:08:55] * awight reads logs [00:24:31] fyi the new service is 50x’ing all over the place, investigating... [00:29:45] 10Scoring-platform-team, 10Gerrit, 10ORES, 10Operations, and 2 others: Support git-lfs files in gerrit - https://phabricator.wikimedia.org/T171758#3475312 (10mmodell) Relatedly, phabricator had some work done on git-lfs support upstream, however, it seems to be undocumented and probably unfinished (it was... [02:24:49] (03PS1) 10Awight: Add required scap config `keyholder_key` [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/383766 [03:20:09] (03PS1) 10Awight: Update config, mostly to drop revert models [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/383769 [04:29:21] (03PS2) 10Awight: Update config, mostly to drop revert models [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/383769 [05:55:51] 10Scoring-platform-team (Current), 10Collaboration-Team-Triage, 10ORES, 10MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), 10Patch-For-Review: Make RCFilters compatible with both the old and new thresholds APIs - https://phabricator.wikimedia.org/T175053#3678681 (10awight) I've left the beta... [06:00:58] (03PS1) 10Awight: Temporarily use the v1 API for fetching scores. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383776 (https://phabricator.wikimedia.org/T175053) [06:06:24] (03CR) 10Awight: [V: 031] "Smoke tests good locally." [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383776 (https://phabricator.wikimedia.org/T175053) (owner: 10Awight) [09:49:15] (03CR) 10Ladsgroup: Update config, mostly to drop revert models (031 comment) [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/383769 (owner: 10Awight) [10:01:07] 10Scoring-platform-team (Current), 10ORES, 10Operations, 10Patch-For-Review, 10User-Ladsgroup: Review and fix file handle management in worker and celery processes - https://phabricator.wikimedia.org/T174402#3679022 (10akosiaris) Given that up to now we are configuring the PER PROCESS file limit, can I a... [10:32:06] (03PS1) 10Ladsgroup: Draftquality model work only on main namespace [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383814 (https://phabricator.wikimedia.org/T176183) [10:33:07] (03CR) 10jerkins-bot: [V: 04-1] Draftquality model work only on main namespace [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383814 (https://phabricator.wikimedia.org/T176183) (owner: 10Ladsgroup) [10:36:30] (03PS2) 10Ladsgroup: Draftquality model work only on main namespace [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383814 (https://phabricator.wikimedia.org/T176183) [14:44:48] o/ [14:44:56] * halfak gets to work reviewing Amir1's work. [14:45:24] halfak: goat morning [14:45:39] 🐐! [14:45:56] I'm currently trying to come up with a good sampling strategy for fawiki articlequality campaign [14:46:01] So, I think the oauth PR is still wrong. I think we should get rid of the window-opening pattern. [14:48:43] I'll submit a commit. [14:49:13] what I've goat so far: 1- around 10% of (late) revisions in fawiki are more than 10KB 2- most of stub articles are properly tagged, so I'd say let's get 2K sample of revisions bigger than 10K and 18K less than 10KB, in the second sample, if it's tagged with stub article, we auto-label it as stub and give everything else to users to label so it'll be 2K sample + everything in the 18K sample that doesn't have the stub tag [14:49:17] Amir1, one thing I wanted to try was building a model on English Wikipedia with language independent features and then run that on fawiki to build strata. [14:49:38] that would be easier. And it sounds like a good strategy to me. [14:50:34] halfak: which one? :D [14:50:44] Amir1, the one you proposed. [14:51:44] Awesome, I start to draw the distribution of sizes to get a proper number and then sample [14:52:55] Sounds good. :) [14:58:10] 10Scoring-platform-team (Current), 10ORES, 10Operations, 10Patch-For-Review, 10User-Ladsgroup: Review and fix file handle management in worker and celery processes - https://phabricator.wikimedia.org/T174402#3679834 (10Halfak) @akosiaris, see my notes in T177036 [14:59:12] o/ akosiaris [14:59:21] Let me know if you want to chat about those file handle limits. [15:02:42] Amir1, https://github.com/wiki-ai/wikilabels/pull/201 [15:02:45] ready for your review [15:07:51] merged :) [15:08:17] \o/ [15:12:32] halfak: can we deploy now :D [15:12:45] working on your other PR [15:12:51] oh cool [15:17:11] Amir1, OK all set. I think you're clear to do a deploy if you want to. [15:17:22] niiiiice [15:17:24] Thanks [15:17:29] back in a bit. [15:51:07] * halfak gets above water for the first time in forever. [15:51:25] I'm checking out JADE stuff and I'm going to look into making the event-generator API [15:52:37] https://www.confluent.io/blog/messaging-single-source-truth/ [15:52:57] (03PS1) 10Catrope: Don't use STRAIGHT_JOIN for Watchlist queries [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383868 (https://phabricator.wikimedia.org/T176456) [15:57:47] O/ [16:00:15] o/ codezee [16:00:20] Saw you working on that PR :) [16:00:23] o/ Zppix [16:01:40] Halfak need me to do anything on phab for you all? Sorting, task creation, etc? [16:01:43] o/ [16:02:47] Zppix, why don't you review the FAQ? https://www.mediawiki.org/wiki/ORES/FAQ [16:02:53] It's a work in progress, but it has a lot of content. [16:03:21] Halfak ok will do ill let you know on what i think [16:07:13] Halfak mind if i make a few changes to support question's answer in beginner question just straight up linking to a page with no content around it bugs me :P [16:23:09] Zppix, be bold! :) [16:33:49] Amir1: halfak: fyi, the FetchScoreJob on beta has been down for a day, but I have a tiny patch to get it working again: https://gerrit.wikimedia.org/r/383776 [16:34:21] o/ awight [16:34:24] COol [16:35:15] 10Scoring-platform-team (Current), 10ORES, 10Operations, 10Patch-For-Review, 10User-Ladsgroup: Review and fix file handle management in worker and celery processes - https://phabricator.wikimedia.org/T174402#3680194 (10awight) @akosiaris Good questions! I only just now found good [[ https://www.freedesk... [16:35:45] (03CR) 10Ladsgroup: [C: 032] Temporarily use the v1 API for fetching scores. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383776 (https://phabricator.wikimedia.org/T175053) (owner: 10Awight) [16:35:50] :D [16:37:16] (03Merged) 10jenkins-bot: Temporarily use the v1 API for fetching scores. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383776 (https://phabricator.wikimedia.org/T175053) (owner: 10Awight) [16:37:47] halfak: akosiaris is right that the 8k limit should be plenty if it’s per-process, so I’m thinking I’ll go ahead with another stress test using the current limits, to try to understand the issue better. [16:38:27] I’ll write a script to dump the stats I was ruminating about in https://etherpad.wikimedia.org/p/ORES_stress_test_variables_to_monitor [16:39:53] Sounds good. I'm guessing the per process limit is fine and we're hitting some other limit. OR the per-process limit is grouping all of the forked children together. [16:40:20] it’s creepy. [16:40:30] We might also be hitting the poll vs select thing. [16:41:42] That’s allegedly a 1024 compiled-in limit. [16:46:23] I keep… neglecting that. [16:47:03] Not sure what you mean re. poll vs. select. [16:48:30] awight: needs backport and deploying? [16:49:29] hafak: I can’t believe I dropped this clue, but I see this issue affecting anything using the select() syscall, https://github.com/cesanta/mongoose/issues/439 [16:50:15] Amir1: I think the merge is enough, since nothing has gone to production yet. [16:50:48] oh yeah [16:51:02] Amir1: I do have some more patches for the ores prod repo though: https://gerrit.wikimedia.org/r/#/projects/mediawiki/services/ores/deploy,dashboards/default [16:51:25] I need to grab something to eat [16:51:32] after that, will check [16:51:42] (03CR) 10Brian Wolff: [C: 031] Don't use STRAIGHT_JOIN for Watchlist queries [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383868 (https://phabricator.wikimedia.org/T176456) (owner: 10Catrope) [16:51:45] Amir1: This will also be handy, https://gerrit.wikimedia.org/r/#/c/377345/2 [16:51:46] thanks! [16:52:22] (03CR) 10Awight: [C: 032] "Looks elegant for being a crazy hack :D" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383868 (https://phabricator.wikimedia.org/T176456) (owner: 10Catrope) [16:52:54] (03CR) 10Brian Wolff: [C: 031] "In some cases, Special:Recentchangeslinked will be better without STRAIGHT_JOIN as well." [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383868 (https://phabricator.wikimedia.org/T176456) (owner: 10Catrope) [16:53:24] https://commons.wikimedia.org/wiki/File:JADE_event_flow_(abstract).svg [16:53:26] awight, ^ [16:53:36] An executor turns events into actions against something. [16:53:43] A translator just reformats the events for storage. [16:54:29] halfak: what are you drawing in? [16:54:39] google drawing. I shared the doc with you :) [16:54:46] (03Merged) 10jenkins-bot: Don't use STRAIGHT_JOIN for Watchlist queries [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383868 (https://phabricator.wikimedia.org/T176456) (owner: 10Catrope) [16:54:46] aha k [16:55:18] looks useful [16:55:46] I'm hoping to do a little bit of thinking about how the JADE API and its state DB will work together. [16:56:06] 1. transactions to preserve integrity of event order and the validity of events. [16:56:17] 2. code structure should reflect the basic set of events [16:56:38] Maybe that code structure can be replicated in the API and any executors that process events. [16:56:57] (03CR) 10Halfak: [C: 04-1] "Missing targets for CODFW" [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/377345 (owner: 10Awight) [17:03:26] off to lunch [17:03:28] back in a bit [17:39:33] (03PS1) 10Catrope: Don't use STRAIGHT_JOIN for Watchlist queries [extensions/ORES] (wmf/1.31.0-wmf.3) - 10https://gerrit.wikimedia.org/r/383885 (https://phabricator.wikimedia.org/T176456) [17:40:08] (03CR) 10Ladsgroup: [C: 04-1] "Agreed with halfak" [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/377345 (owner: 10Awight) [17:44:17] (03PS3) 10Awight: Include new cluster as deployment targets [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/377345 [17:46:48] (03CR) 10Catrope: "@Brian: I looked into that, but ORES is currently disabled on RCLinked completely, see T163063" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383868 (https://phabricator.wikimedia.org/T176456) (owner: 10Catrope) [17:47:45] (03CR) 10Ladsgroup: [V: 032 C: 032] Include new cluster as deployment targets [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/377345 (owner: 10Awight) [17:53:53] K the FetchScoreJob fix worked. [17:55:50] 10Scoring-platform-team, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-ORES, 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017): [1.31.0-wmf.2 ]&hidenondamaging=0 is ignored when "Show only likely problem edits" preference is enabled - https://phabricator.wikimedia.org/T177884#3680565 (1... [18:01:00] (03CR) 10Chad: [C: 032] Don't use STRAIGHT_JOIN for Watchlist queries [extensions/ORES] (wmf/1.31.0-wmf.3) - 10https://gerrit.wikimedia.org/r/383885 (https://phabricator.wikimedia.org/T176456) (owner: 10Catrope) [18:06:49] 10Scoring-platform-team, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-ORES, 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017): [1.31.0-wmf.2 ]&hidenondamaging=0 is ignored when "Show only likely problem edits" preference is enabled - https://phabricator.wikimedia.org/T177884#3673797 (1... [18:06:56] (03Merged) 10jenkins-bot: Don't use STRAIGHT_JOIN for Watchlist queries [extensions/ORES] (wmf/1.31.0-wmf.3) - 10https://gerrit.wikimedia.org/r/383885 (https://phabricator.wikimedia.org/T176456) (owner: 10Catrope) [18:11:24] halfak: I'm working on https://phabricator.wikimedia.org/T178004, obviously I need to query mw api to get usernames (otherwise it's useless) should I do it in flask or use js and differed rendering of the page? [18:11:50] if we use flask, it might be a dos vector but we can simply cache [18:15:42] (03PS1) 10Awight: Make getWikiID static, cos it's useful [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383888 [18:15:45] (03PS1) 10Awight: Use the v3 API for fetching scores. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383889 [18:20:47] (03CR) 10Awight: "recheck" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383888 (owner: 10Awight) [18:21:19] Did I tell you my desk in WMDE office has buttons to go up and down, so I work standing for some hours and then sitting for the next few [18:21:41] It's so fun to play with, hope doesn't break any time soon [18:22:24] buttons! I have a wood box I put my laptop on sometimes, which I was thinking is pretty luxurious… until now. [18:25:01] Amir1, good Q. It would be nice if we could cache. [18:25:09] But really, I think that JS makes sense. [18:25:16] awight, what do you think [18:25:19] I'm kind of torn. [18:25:29] \o/ for standing desks. [18:25:47] I want to get one so I can put my bike underneath it with a trainer so I can pedal in the inter. [18:25:51] *winter [18:26:26] https://i.pinimg.com/736x/a9/85/0f/a9850f91bc999a1d3a453bc2999aca14--treadmill-desk-office-chairs.jpg [18:26:31] if we can do LRU cache, I don't think javascript would be okay [18:26:49] since we show the page to user and then we say, oh wait a second, let me do more stuff [18:27:10] I’m not sure how it’s a DoS vector, it’s just calling the MW API right? [18:27:18] also centralized caching means less global warming [18:27:45] awight, call coming from browser vs. from wikilabels server. Easier to block individual IPs from api.php. [18:27:59] Still should be a really cheap call and api.php will cache. [18:28:15] (03CR) 10jerkins-bot: [V: 04-1] Make getWikiID static, cos it's useful [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383888 (owner: 10Awight) [18:28:20] +1 the legitimate users are few, and abusers can hit the api.php endpoint all day regardless [18:29:48] (03CR) 10jerkins-bot: [V: 04-1] Use the v3 API for fetching scores. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383889 (owner: 10Awight) [18:43:02] https://www.mediawiki.org/wiki/Topic:Tzvxe3sckmfoftp8 [18:43:51] nice article! [18:46:27] (03PS2) 10Awight: Make getWikiID static, cos it's useful [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383888 [18:46:29] (03PS2) 10Awight: Use the v3 API for fetching scores. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383889 [18:46:32] (03PS1) 10Awight: Choose more magical magic [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383895 (https://phabricator.wikimedia.org/T175053) [18:54:53] (03CR) 10Catrope: [C: 032] Choose more magical magic [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383895 (https://phabricator.wikimedia.org/T175053) (owner: 10Awight) [18:55:12] (03CR) 10Catrope: [C: 032] Make getWikiID static, cos it's useful [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383888 (owner: 10Awight) [18:56:35] RoanKattouw: ty! [18:59:10] (03CR) 10jerkins-bot: [V: 04-1] Choose more magical magic [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383895 (https://phabricator.wikimedia.org/T175053) (owner: 10Awight) [18:59:13] (03CR) 10jerkins-bot: [V: 04-1] Make getWikiID static, cos it's useful [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383888 (owner: 10Awight) [19:00:01] ugh. > Error: your composer.lock file is not up to date. Run "composer update" to install newer dependencies [19:00:17] (03CR) 10Awight: "recheck" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383895 (https://phabricator.wikimedia.org/T175053) (owner: 10Awight) [19:05:02] 10Scoring-platform-team, 10JADE: Post about judgments/endorsements/preference - https://phabricator.wikimedia.org/T178101#3680763 (10Halfak) [19:06:50] 10Scoring-platform-team, 10JADE: Post about suppression for JADE comments - https://phabricator.wikimedia.org/T178102#3680783 (10Halfak) [19:08:28] halfak: I've been searching for an API module to turn global user id to username, I couldn't find any, did you use something specific? [19:08:40] 10Scoring-platform-team, 10JADE: Post about public analytics for JADE - https://phabricator.wikimedia.org/T178103#3680803 (10Halfak) [19:10:09] Amir1: Perhaps ask anomie in #mediawiki-core [19:10:28] Thanks [19:14:25] Excellent. Turns out, both the uwsgi and celery service workers share a PGID within each service. [19:19:09] 10Scoring-platform-team, 10JADE: Post about judgments/endorsements/preference - https://phabricator.wikimedia.org/T178101#3680851 (10Halfak) a:05awight>03Halfak [19:25:02] 10Scoring-platform-team, 10Wikilabels, 10User-Ladsgroup: Add list of labelers to campaign stats (sort by labels submitted) - https://phabricator.wikimedia.org/T178004#3680858 (10Ladsgroup) For now: https://github.com/wiki-ai/wikilabels/pull/203 We need to discuss this. [19:27:16] 10Scoring-platform-team, 10JADE, 10ORES: Design a collaborative judgement pattern for JADE - https://phabricator.wikimedia.org/T171496#3680876 (10Halfak) [19:31:15] These need review, https://gerrit.wikimedia.org/r/#/c/383769/ https://gerrit.wikimedia.org/r/#/c/383766/ [19:31:44] Amir1: halfak: ^ These are necessary to run revscoring 2 on beta... [19:32:41] (03CR) 10jerkins-bot: [V: 04-1] Make getWikiID static, cos it's useful [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383888 (owner: 10Awight) [19:32:59] (03CR) 10jerkins-bot: [V: 04-1] Use the v3 API for fetching scores. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/383889 (owner: 10Awight) [19:33:30] awight: the first one already has my comment, regarding the second one, I have no idea about the funcationality, a +1 from Tyler or Mukunda would suffice for me [19:35:09] (03PS3) 10Awight: Update config, keep in sync with the set of revscoring 2 models [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/383769 [19:35:38] 10Scoring-platform-team (Current), 10Wikilabels, 10User-Ladsgroup: Add list of labelers to campaign stats (sort by labels submitted) - https://phabricator.wikimedia.org/T178004#3680893 (10Ladsgroup) [19:36:40] 10Scoring-platform-team (Current), 10ORES, 10editquality-modeling, 10User-Ladsgroup, 10artificial-intelligence: Train/test edit quality models for eswikibooks - https://phabricator.wikimedia.org/T176332#3621783 (10Ladsgroup) https://github.com/wiki-ai/editquality/pull/100 [19:43:41] 10Scoring-platform-team, 10articlequality-modeling, 10artificial-intelligence: Article quality campaign for Persian Wikipedia - https://phabricator.wikimedia.org/T174684#3680921 (10Ladsgroup) This is a random sample: https://quarry.wmflabs.org/query/22237 I analyzed the distribution of page sizes and it's o... [19:44:49] 10Scoring-platform-team, 10JADE: Post about judgments/endorsements/preference - https://phabricator.wikimedia.org/T178101#3680923 (10Halfak) https://www.mediawiki.org/wiki/Topic:Tzw0uv2bucrdprm4 [19:44:56] 10Scoring-platform-team (Current), 10JADE: Post about judgments/endorsements/preference - https://phabricator.wikimedia.org/T178101#3680924 (10Halfak) [19:45:06] (03CR) 10Ladsgroup: [V: 032 C: 032] Update config, keep in sync with the set of revscoring 2 models [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/383769 (owner: 10Awight) [19:45:33] https://www.mediawiki.org/wiki/Topic:Tzw0uv2bucrdprm4 [19:45:43] ^ Post about judgements, endorsements, and preference [19:45:52] For the user group. [19:45:55] cc Keegan ^ [19:46:04] Working on one about suppression [19:46:10] halfak: I’m thrilled to read these notes btw, just very heads-down today. [19:46:39] No worries. Thanks for your focus! Treat this as an FYI. I'll try to keep pings to a minimum :) [19:46:40] BTW I have to cut out in an hour…. Will probably be working tomorrow. [19:46:49] OK thanks. GOod to know. [19:46:53] pings are fine [19:47:33] 10Scoring-platform-team (Current), 10JADE: Post about judgments/endorsements/preference - https://phabricator.wikimedia.org/T178101#3680929 (10Halfak) [19:47:36] 10Scoring-platform-team, 10JADE, 10ORES: Design a collaborative judgement pattern for JADE - https://phabricator.wikimedia.org/T171496#3680928 (10Halfak) [19:47:51] 10Scoring-platform-team (Current), 10Bad-Words-Detection-System, 10revscoring, 10User-Ladsgroup, 10artificial-intelligence: Add language support for Serbian - https://phabricator.wikimedia.org/T174687#3680931 (10Zoranzoki21) Why is closed as resolved? srwiki is not in list on http://labels.wmflabs.org/ui/ [19:49:27] The PR for eswikibooks is up [19:49:30] 10Scoring-platform-team, 10ORES: [Spike] Should we integrate JADE with Flow? - https://phabricator.wikimedia.org/T153147#3680948 (10Halfak) [19:49:30] and I'm leaving [19:49:45] o/ ! [19:49:45] see you in the hack session (and Monday) [19:50:06] o/ [19:50:12] Thanks Amir1! [19:50:24] PR 100! [19:50:44] lol https://phabricator.wikimedia.org/P6112 [20:01:07] 10Scoring-platform-team (Current), 10Bad-Words-Detection-System, 10revscoring, 10User-Ladsgroup, 10artificial-intelligence: Add language support for Serbian - https://phabricator.wikimedia.org/T174687#3680973 (10Zoranzoki21) 05Resolved>03Open [20:05:47] (03CR) 10Thcipriani: "hrm, this change seems fine except it *should be* doing the exact same thing scap is trying to do." [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/383766 (owner: 10Awight) [20:11:43] (03CR) 10Awight: "> hrm, this change seems fine except it *should be* doing the exact" [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/383766 (owner: 10Awight) [20:15:36] halfak: I’m watching filehandles climb during a stress test... [20:16:50] 10Scoring-platform-team, 10Wikilabels: Edit quality campaign for Serbian Wikipedia - https://phabricator.wikimedia.org/T178108#3681018 (10Halfak) [20:17:10] 10Scoring-platform-team (Current), 10Bad-Words-Detection-System, 10revscoring, 10User-Ladsgroup, 10artificial-intelligence: Add language support for Serbian - https://phabricator.wikimedia.org/T174687#3570233 (10Halfak) Ahh! I see. We need a separate task for setting up a labeling campaign. See {T1781... [20:17:14] 10Scoring-platform-team (Current), 10Bad-Words-Detection-System, 10revscoring, 10User-Ladsgroup, 10artificial-intelligence: Add language support for Serbian - https://phabricator.wikimedia.org/T174687#3681037 (10Halfak) 05Open>03Resolved [20:17:24] awight, a minor amount or *a lot* [20:17:25] ? [20:17:46] awight, a little climbing should be normal as new libraries are imported as needed. [20:17:50] But it should level off quickly. [20:18:16] That’s exactly what I’m seeing. It’s very level now… [20:18:53] Only climbed about 200 FHs and now completely static [20:19:15] Waiting to see if something else happens when we hit an overload condition [20:19:58] 10Scoring-platform-team, 10Wikilabels: Edit quality campaign for Serbian Wikipedia - https://phabricator.wikimedia.org/T178108#3681045 (10Halfak) Looks like translations are read. Next we need a set of trusted user groups. Usually these represent users who have gone through a substantial vetting process. Fo... [20:26:59] Well, that was interesting. [20:27:19] The celery service died without any increase in the open filehandles [20:29:20] awight: i wasnt supposed to eat that xD jk [20:30:26] Zppix: ah, the low-calorie protocol. Optimized with a peanut butter subcarrier. [20:32:20] awight: and a low-tolerance budget [20:34:08] lol [20:36:22] https://www.mediawiki.org/wiki/Topic:Tzw3qg8qiqow10d8 [20:36:33] Should we integrate JADE with Flow? [20:36:37] (03CR) 10Thcipriani: "> > hrm, this change seems fine except it *should be* doing the exact" [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/383766 (owner: 10Awight) [20:37:20] 10Scoring-platform-team, 10ORES: [Spike] Should we integrate JADE with Flow? - https://phabricator.wikimedia.org/T153147#3681077 (10Halfak) I just posted https://www.mediawiki.org/wiki/Topic:Tzw0uv2bucrdprm4 which describes a workflow that involves a "discussion post". I was imagining a flow topic. So I made... [20:43:30] halfak: I feel like i have already voiced my opinion of flow and its being of a too forumy and not wiki-like style, so in my opinion as long jade doesnt follow flow in its design i have no issues [20:43:45] Too forumy? [20:43:54] But it's supposed to be a forum./ [20:44:02] What are the benefits of "wiki-like"? [20:45:02] To me, the benefits of Flow are massive. I've done a lot of directed user-tests with flow and talk pages. People can't figure out talk pages and notifications are very difficult to use. In contrast, Flow is very easy to figure out and the notifications are intuitive and useful. [20:46:33] I’m open to hearing about alternatives. The main properties I was looking for were, * Supports admin oversight without any extra development effort, * Similarly, supports editing your comment and a public history. * Encourages conversation. [20:46:41] Flow definitely encourages conversation. [20:50:35] 10Scoring-platform-team, 10JADE: Post about suppression for JADE comments - https://phabricator.wikimedia.org/T178102#3681159 (10Halfak) https://www.mediawiki.org/wiki/Topic:Tzw4ebq17wbdog74 [20:50:44] 10Scoring-platform-team (Current), 10JADE: Post about suppression for JADE comments - https://phabricator.wikimedia.org/T178102#3681160 (10Halfak) [20:51:00] 10Scoring-platform-team (Current), 10JADE: Post about suppression for JADE comments - https://phabricator.wikimedia.org/T178102#3680783 (10Halfak) a:05awight>03Halfak [20:58:04] halfak: oh hey. This bug might be fixed in celery already. [20:58:35] 10Scoring-platform-team (Current), 10ORES, 10Operations, 10Patch-For-Review, 10User-Ladsgroup: Review and fix file handle management in worker and celery processes - https://phabricator.wikimedia.org/T174402#3681200 (10awight) I used lsof to watch filehandle usage over the lifecycle of the celery service... [20:58:41] \o/ Really? That would be nice. We have a weird problem with upgrading though. Celery dropped support for sub-tasks and we use them. [20:59:53] "During an unsupportably heavy load, the number of handles climbed by *1*." [20:59:59] halfak: I mean how much is flow used in reality outside of mediawiki.org? [21:00:02] Interesting. I wonder what the 480 jump is too [21:00:16] Zppix, a few wikis have gone all in. Wikidata seems to like it. [21:00:33] I've been trying to get it in Meta. [21:00:35] halfak: compared to all the bigger projects like enwiki whom dont [21:00:49] halfak: i dont quite believe its worth the time [21:00:50] Zppix, right. I don't think Flow makes sense for a big project. [21:00:57] But it would have if they'd used it from the start. [21:01:08] Wikidata is almost as big as enwiki now. [21:01:13] It's going to be the biggest wiki in no time. [21:01:22] Zppix, what time? [21:01:38] halfak: the time to develop the intergration [21:02:16] halfak: yeah that subtask thing should probably be fixed anyway, I vaguely remember it’s doing something that causes threads to be coupled to one another when they could update results more asynchronously. [21:04:11] awight, AFAICT there's no good option for doing the same thing. [21:04:26] Still ends up being async. [21:04:47] Zppix, integration will need to be developed either way. [21:04:57] IMO Flow looks to be the easiest by far. [21:05:05] It looked fun a year ago, but was out of my pay grade as a volunteer ;-) [21:05:28] Zppix, I'm really curious where your negative opinion of Flow comes from. What exactly is wrong with it? [21:05:39] awight, right I remember discussing it with you. [21:09:16] halfak: I just like how the non-flow styles look on a page I think flow just ruins it [21:09:36] * awight chokes on a bit of celery fiber [21:09:43] nothing, nothing [21:10:34] Zppix, I can help you set up some user CSS ;) [21:10:36] Or a new skin. [21:10:48] halfak: i like my vector ty [21:11:11] Sure, just a bit of CSS then [21:11:13] *done* [21:11:15] next [21:12:12] can you print 2000 in all 1 hundred notations thanks [21:12:13] xD [21:12:16] 10Scoring-platform-team (Current), 10ORES, 10Operations, 10Patch-For-Review, 10User-Ladsgroup: Review and fix file handle management in worker and celery processes - https://phabricator.wikimedia.org/T174402#3681269 (10awight) Now *this* is interesting. The Celery code involved in the failure, https://g... [21:13:22] 10Scoring-platform-team (Current), 10ORES, 10Operations, 10Patch-For-Review, 10User-Ladsgroup: Review and fix file handle management in worker and celery processes - https://phabricator.wikimedia.org/T174402#3681281 (10Halfak) Before we have that discussion, we could just give it a shot to see if it work... [21:13:38] awight, is that backport "easy"? [21:15:00] 10Scoring-platform-team (Current), 10ORES, 10Operations, 10Patch-For-Review, 10User-Ladsgroup: Review and fix file handle management in worker and celery processes - https://phabricator.wikimedia.org/T174402#3681285 (10awight) Sounds good. It also sounds like the Celery developers would be open to a con... [21:15:06] 10Scoring-platform-team, 10Wikilabels: Edit quality campaign for Serbian Wikipedia - https://phabricator.wikimedia.org/T178108#3681288 (10Zoranzoki21) >>! In T178108#3681045, @Halfak wrote: > Looks like translations are read. Next we need a set of trusted user groups. Usually these represent users who have g... [21:15:53] halfak: Seems to be medium-easy, just changing one file. Looking at the git log, there were a few details that had to be worked out, so it’s not trivial, but definitely doable. [21:16:09] * awight facepalms big time [21:16:38] I can’t believe I needed to watch the FHs not climb at all to disabuse myself of the FH exhaustion theory. [21:17:07] empiricism is great! Don't feel bad for wanting to check! [21:17:08] * awight hands in my unrepentant skeptic card [21:17:15] NO! [21:17:19] Keep it. [21:17:21] It's good. [21:17:21] * Zppix hands back skeptic card [21:17:29] lol. [21:17:46] awight: i got my own skeptic card, i think its required to live have yours [21:18:01] I need to gulp some wildfire, see you tomorrow! [21:18:05] 10Scoring-platform-team, 10JADE: Post about public analytics for JADE - https://phabricator.wikimedia.org/T178103#3681304 (10Halfak) https://www.mediawiki.org/wiki/Topic:Tzw5fix7hbs4ui8j [21:18:15] 10Scoring-platform-team (Current), 10JADE: Post about public analytics for JADE - https://phabricator.wikimedia.org/T178103#3681305 (10Halfak) [21:18:57] Keegan, FYI, all posts are live. See https://www.mediawiki.org/wiki/Talk:JADE [21:19:26] I've got to run away a bit early, but I feel good about the day ending on that note. Back tomorrow morning. Have a good one folks! [21:23:07] halfak: o/ [21:58:37] halfak: roger dodger