[01:21:16] (03PS1) 10Legoktm: build: Adding MinusX [extensions/ORES] - 10https://gerrit.wikimedia.org/r/388767 [01:21:18] (03CR) 10Legoktm: [C: 032] build: Adding MinusX [extensions/ORES] - 10https://gerrit.wikimedia.org/r/388767 (owner: 10Legoktm) [01:34:54] (03Merged) 10jenkins-bot: build: Adding MinusX [extensions/ORES] - 10https://gerrit.wikimedia.org/r/388767 (owner: 10Legoktm) [08:28:31] 10Scoring-platform-team, 10Bad-Words-Detection-System, 10revscoring, 10artificial-intelligence: Add language support for Icelandic - https://phabricator.wikimedia.org/T178524#3735045 (10Snaevar) I would also like to mention that I used some regex in the BWDS list, so "haha+" (for example) is intended to al... [10:12:51] 10Scoring-platform-team (Current): Build mid-level WikiProject category training set - https://phabricator.wikimedia.org/T172321#3735076 (10Sumit) [14:41:24] wiki-ai/ores#813 (master - c84a7f2 : Adam Roses Wight): The build was broken. https://travis-ci.org/wiki-ai/ores/builds/297225077 [14:56:44] 10Scoring-platform-team (Current), 10ORES: Consistent TimeoutErrors when using Celery 4 - https://phabricator.wikimedia.org/T179524#3735243 (10awight) The approach I want to try is to coerce the "inprogress" and "missing" child tasks into a Celery native subtask "group". [15:48:42] awight: ores-misc disk size sane now? [15:49:47] codezee: Thanks for the cleanup! [15:49:54] It’s looking much more reasonable, 4.7G free. [15:50:02] That’s enough to build all the wheels if we need to, etc. [15:50:24] nice... [15:55:33] 10Scoring-platform-team (Current): Grant AWight admin access to ORES pypi repos - https://phabricator.wikimedia.org/T168672#3735308 (10awight) [16:52:13] o/ [16:52:38] Traveling today [17:21:05] halfak|Mobile: :( [17:39:11] awight: i replied to pr #230 in wikiai-ores [17:40:23] wiki-ai/revscoring#1288 (coverage - 7ab856c : Amir Sarabadani): The build passed. https://travis-ci.org/wiki-ai/revscoring/builds/297279209 [17:43:14] awight: https://github.com/wiki-ai/revscoring/pull/370 [17:44:57] Amir1: hey, it’s like using modern tools turns out to have advantages! [17:45:13] Thanks! [17:46:33] Zppix: Thanks for having me take another look [17:46:42] it actually seems to be caused by the server not starting [17:46:43] 10Scoring-platform-team (Current), 10revscoring, 10User-Ladsgroup, 10artificial-intelligence: Compare coverage reports of migrating to pytest - https://phabricator.wikimedia.org/T179507#3735415 (10Ladsgroup) For #revscoring: https://github.com/wiki-ai/revscoring/pull/370 https://codecov.io/gh/wiki-ai/revsc... [17:46:51] and might have to do with the patch I merged... [17:46:52] from revscoring.errors import ModelInfoLookupError [17:46:53] ImportError: cannot import name 'ModelInfoLookupError' [17:47:00] aah [17:47:10] right, and that won’t be fixed until we push new revscoring. [17:52:54] Amir1: ^ ready for merge? [17:53:08] wait a sec for coverage report [17:53:20] Ok [17:53:53] wiki-ai/ores#814 (coverage - 4ecf6b9 : Amir Sarabadani): The build failed. https://travis-ci.org/wiki-ai/ores/builds/297283231 [17:54:42] it failed because of the ores problem, let me re-run the build [17:55:00] Ok let me know when your ready for merte [17:55:04] Merge* [17:57:03] Amir1: I don’t think that’ll pass until I can push revscoring 2.0.9 [17:57:18] awight: okay [17:57:19] Thanks [17:57:26] awight: Do you have perms to give me maintainer at pypi? [17:57:34] Amir1: want to merge since the pr is not the reason? [17:58:00] awight: you pinged yourself, I tried that before but couldn't [17:58:03] Zppix: yeah [17:58:29] thanks for checking! [18:00:21] Amir1: done let me know if you need anymore done :) [18:00:58] Zppix: yeah, there is one. Let me run a test [18:06:09] Ok [18:10:19] 10Scoring-platform-team (Current), 10revscoring, 10User-Ladsgroup, 10artificial-intelligence: Compare coverage reports of migrating to pytest - https://phabricator.wikimedia.org/T179507#3735438 (10Ladsgroup) For #ores https://codecov.io/gh/wiki-ai/ores/pull/224 this is interesting, it seems that by migrati... [18:22:32] wiki-ai/wikilabels#211 (coverage - 84405f6 : Amir Sarabadani): The build failed. https://travis-ci.org/wiki-ai/wikilabels/builds/297291942 [18:27:52] wiki-ai/wikilabels#213 (coverage - 17ae36d : Amir Sarabadani): The build was fixed. https://travis-ci.org/wiki-ai/wikilabels/builds/297293597 [18:29:27] ^ ready Amir1 ? [18:29:55] not yet, one quick thing [18:30:02] Ok [18:37:27] wiki-ai/wikilabels#213 (coverage - 17ae36d : Amir Sarabadani): The build was fixed. https://travis-ci.org/wiki-ai/wikilabels/builds/297293597 [18:38:02] Zppix: Now ready for merge :D [18:38:06] Ok [18:39:08] Done [18:39:39] 10Scoring-platform-team (Current), 10revscoring, 10User-Ladsgroup, 10artificial-intelligence: Compare coverage reports of migrating to pytest - https://phabricator.wikimedia.org/T179507#3735465 (10Ladsgroup) For #wikilabels: https://github.com/wiki-ai/wikilabels/pull/210 I was checking and amazingly I real... [18:39:51] Thanks [18:40:59] Np [18:41:04] Anything else Amir1 ? [18:43:23] There is one thing but I push to master [18:43:28] too straightforward :D [18:43:37] Ok [18:45:38] Amir1: whats the path for the test i need to add to run a specific pytest from root? [18:45:52] from root_dir of the project i mean [18:46:23] codezee: do you mean running all the tests of the project [18:46:48] awight: I pushed this directly in master https://git.io/vFC6U :D [18:47:41] posthumously blessed. [18:47:44] Amir1: i need to run only one test, bascially bec i;m debugging it [18:48:27] codezee: add the path as argument [18:48:30] let me get docs [18:49:51] http://pytest.readthedocs.io/en/reorganize-docs/new-docs/user/directory_structure.html [18:49:56] pytest tests/test_appmodule.py [18:51:55] Amir1: thanks! [19:20:37] Amir1: halfak|Mobile: ^ That was suspiciously easy…. but I want to try it on beta to see if the timeout is in fact gone. [19:21:12] awight: you have my prayers [19:21:17] LOL [19:21:20] I’ll need that [19:21:29] :D [19:22:13] wiki-ai/ores#818 (CELERY_4 - 01e7c3d : Adam Roses Wight): The build was broken. https://travis-ci.org/wiki-ai/ores/builds/297309313 [19:25:20] Amir1: Which version of pytest are you using? I’m getting syntax errors on our starargs, with version 3.1.3 [19:25:41] ohey, nvm. Something bad happening with py2 vs py3 [19:26:25] Any advice or a wiki page on how to run the tests correctly? [19:45:46] awight: run correctly meaning? running pytest . from root dir is the best way [19:50:48] there goes a big one... [19:53:42] codezee: Good to hear that’s all it takes—I was running into something about pytest3 in virtualenv pulling from a system py2 pytest location. [19:53:51] Just local issues then. [19:54:21] that seems scary :/ [19:57:24] Amir1: any way i can ask travis to run a check on a branch diff than master? i want to run once before i open a PR [20:04:34] nvm got it... [20:09:39] apparently my old flake8 version missed errors....and i thought all was well [20:23:50] 10Scoring-platform-team (Current), 10ORES: Consistent TimeoutErrors when using Celery 4 - https://phabricator.wikimedia.org/T179524#3735543 (10awight) I ended up doing something simpler but wasteful. The synchronous subtask step came from sharing feature extraction between multiple models in a scoring request... [21:00:00] this is very strange, i'm using dict unpacking in one of my codes, which runs fine locally bec python 3.6 but i notices ores-misc is complaining bec that feature is not present in python3.4 [21:00:01] https://stackoverflow.com/questions/34766677/python-splat-unpack-operator-in-python-cannot-be-used-in-an-expression [21:00:10] *but i noticed [21:01:16] btw, I’m probably on the same distro, so I did “virtualenv -p python3.4 venv/“ to make sure I match production [21:02:18] the problem is production is 3.4 i suppose but i didn't realize that the construct which is used "{**wp[prev_topic]['topics']...." was only introduced after 3.5 [21:02:43] I think it’s pretty easy to write the long way, though? [21:03:34] result = wp[prev_topic][‘topics’] ; result.update({other thing... [21:04:54] awight: oh, wasn't aware of that thanks.... [21:05:20] :) [21:05:42] thanks for boosting my confidence wrt. pytest, it’s working fine now! [21:08:57] i just told you the command to run them... :P [21:15:20] awight: if you may - https://github.com/wiki-ai/drafttopic/pull/10 [21:17:22] codezee: yes but I could have spend hours wondering in the weeds otherwise [21:17:35] thanks for the quick response... :) [21:26:10] i opened one tmux locally and one remote and ended up detaching from the local one when i wanted to detach from the remote one... [21:26:30] perks of tmux sessions at too many places... :/ [21:32:10] awight: do you know if T170506 has a GCI mentor (CC Amir1 ) [21:32:11] T170506: [Wikimania doc sprint] docs on how to install ORES - https://phabricator.wikimedia.org/T170506 [21:33:01] Zppix: Amir1 added the GCI tag so I think he’s planning to do that. [21:33:28] Zppix: you can check that if you're registered on GCI website [21:33:42] codezee: not if its not imported yet xD [21:33:56] yeah, that is true, it cannot predict future :D [21:34:38] I wonder if ORES could technically predict the future [21:39:00] Halfak https://www.mediawiki.org/wiki/Topic:U1bfosekyw1e88yv what you think? [23:00:21] (03PS1) 10Awight: Bump ores to get new subtask design [services/ores/deploy] (CELERY_4) - 10https://gerrit.wikimedia.org/r/389287 (https://phabricator.wikimedia.org/T179524) [23:01:26] (03CR) 10Awight: [V: 032 C: 032] "Self-merge on branch" [services/ores/deploy] (CELERY_4) - 10https://gerrit.wikimedia.org/r/389287 (https://phabricator.wikimedia.org/T179524) (owner: 10Awight) [23:14:36] 10Scoring-platform-team (Current), 10ORES, 10Patch-For-Review: Upgrade celery to 4.1.0 for ORES - https://phabricator.wikimedia.org/T178441#3735742 (10awight) A little something to keep track of: I test-deployed the Celery 4 code to beta, and most of the wheels installed, but some did not. Installing the *....