[08:30:20] (03CR) 10Addshore: [C: 031] Don't use $row->ores_damaging_threshold in Contributions where it isn't set [extensions/ORES] - 10https://gerrit.wikimedia.org/r/390072 (https://phabricator.wikimedia.org/T179830) (owner: 10Catrope) [11:03:05] 10Scoring-platform-team, 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10ORES, 10Regression: [regression] ORES filters are not available on French Wikipedia naymore - https://phabricator.wikimedia.org/T180115#3747154 (10Trizek-WMF) [11:04:53] 10Scoring-platform-team, 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10ORES, 10Regression: [regression] ORES filters are not available on French Wikipedia naymore - https://phabricator.wikimedia.org/T180115#3747168 (10Trizek-WMF) [11:09:43] Amir1: ^ [11:10:02] halfak|Mobile: hey, I just joined, let me read the logs [11:10:50] halfak|Mobile: I think it's the threshold thing [11:11:00] but will check in details [11:11:05] * Amir1 dives into logs [11:11:20] Sure. Let me know if I can review for you. Seems urgent [11:12:18] I'm supposed to be running a workshop today. But the conference is mostly disorganized. I don't feel bad skipping out for an emergency. [11:13:29] Keynote was supposed to start 15 minutes ago. Doesn't look like it is starting any time soon. [11:14:08] Conference chair still isn't here. 4 people in the main auditorium. [11:38:12] Lol. I can't even get into the room I'm doing the workshop in. I didn't realize that a lack of fluency in Portuguese would be so crippling at a conference. [11:38:41] Can't always get away with English and my level 1 Spanish. [11:39:23] Amir1, any thoughts? It looks like we're still seeing errors in threshold lookup. [11:46:23] halfak|Mobile: I'm still trying to get my head around it [11:46:31] I think we never fixed it in the first place [11:47:09] Yikes. Should have been. I have a test that demonstrates what I thought was the fix. [11:47:16] Ooh! I might know what's up. [11:47:43] So when you ask for thresholds, you get a list of objects [11:48:21] [{...}, {...}, ...] [11:48:59] With the change, when a specific threshold is impossible, then a null takes the place of the threshold object in the list [11:49:37] I bet that null isn't handled. I asked awight about that when I submitted the change for review and he wasn't sure how it would be handled. [11:49:54] Amir1: ^ [11:50:25] Either way, it should have broken in beta [11:51:33] halfak|Mobile: everything in beta is broken [11:51:49] I will check and try to fix [11:52:22] So beta is currently not a good place to test? [12:09:47] yeah [12:52:29] 10Scoring-platform-team, 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10ORES, 10Regression: [regression] ORES filters are not available on French Wikipedia naymore - https://phabricator.wikimedia.org/T180115#3747154 (10Ladsgroup) I'm investigating it atm, first observation:... [12:56:35] (03CR) 10Ladsgroup: "It breaks some tests, please fix them and also add regression tests" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/390072 (https://phabricator.wikimedia.org/T179830) (owner: 10Catrope) [13:22:05] halfak|Mobile: Just letting you know that I'm still investigating it [13:28:20] 10Scoring-platform-team, 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10ORES, 10Regression: [regression] ORES filters are not available on French Wikipedia anymore - https://phabricator.wikimedia.org/T180115#3747711 (10Luke081515) [13:42:41] halfak|Mobile: the offending query is https://ores.wikimedia.org/v3/scores/frwiki/?models=damaging&model_info=statistics.thresholds.false.%22maximum+recall+@+precision+%3E=+0.995%22|statistics.thresholds.true.%22maximum+filter_rate+@+recall+%3E=+0.9%22|statistics.thresholds.true.%22maximum+recall+@+precision+%3E=+0.6%22|statistics.thresholds.true.%22maximum+recall+@+precision+%3E=+0.9%22&format=json [13:44:32] The last part is causing the error [13:44:36] digging deeeeeeeper [14:44:36] 10Scoring-platform-team (Current), 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10ORES, and 2 others: [regression] ORES filters are not available on French Wikipedia anymore - https://phabricator.wikimedia.org/T180115#3748077 (10Ladsgroup) a:03Ladsgroup [14:44:53] 10Scoring-platform-team (Current), 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10ORES, and 2 others: [regression] ORES filters are not available on French Wikipedia anymore - https://phabricator.wikimedia.org/T180115#3748083 (10Ladsgroup) 05Open>03Resolved p:05Triage>... [14:45:02] halfak|Mobile: It's resolved now [15:05:58] hi, the PatruBOT just thrown down my article and I don't understand why [17:32:21] Thanks Amir1! I just got a break from workshop stuff. Lots of busty activity on ORES because I've got a bunch of students playing with it. [17:32:34] I <3 caching [17:33:41] Yay stuudents [17:33:52] halfak|Mobile: how is seattle anyway? [17:34:37] I dunno. I'm in Rio. Seattle was last week. ;) [17:34:51] Oh how was it [17:35:04] Rio as in brazil? [18:40:37] Hi, did I miss anything exciting? [18:42:28] Halfaks in rip [18:42:31] Rio* [18:42:42] awight [18:43:22] whew, you had me scared for a moment. [18:43:48] I just got told by the repair company working on my laptop isnt going to send it til tuesday [18:43:59] So i told them some very choice words [19:09:17] “carefully chosen”, is what I hope you mean [19:20:40] awight: I fixed the frwiki problem [19:21:09] https://grafana.wikimedia.org/dashboard/db/ores-extension?orgId=1&from=now-6h&to=now [19:21:17] Amir1: interesting—without pushing the ORES code? [19:21:25] Yeah [19:21:29] I guess just the TTL_DAY [19:21:30] ? [19:21:37] It was another thing [19:21:46] wat. Oh, you fixed it on the client side! [19:21:56] I dived deep into logs until I found the problem [19:22:14] in order to get threshold it asked for min_precision > 0.9 [19:22:17] Wow, nicely played [19:22:18] aha [19:22:23] I reduced it to 0.85 [19:22:27] I remember part of the fix was for that [19:22:30] hahaha excellent [19:22:34] awight: https://ores.wikimedia.org/v3/scores/frwiki/?models=damaging&model_info=statistics.thresholds.false.%22maximum+recall+@+precision+%3E=+0.995%22|statistics.thresholds.true.%22maximum+filter_rate+@+recall+%3E=+0.9%22|statistics.thresholds.true.%22maximum+recall+@+precision+%3E=+0.6%22|statistics.thresholds.true.%22maximum+recall+@+precision+%3E=+0.9%22&format=json [19:22:40] practical. [19:23:02] We should've reduced it anyway [19:23:19] we can't send 400 to our internal queries ;) [19:36:06] I’m looking at RoanKattouw’s patch—strange business, actually. The threshold is being returned with the query, so donno why that was failing. Also, the way he changed it should have worked but getThreshold seems to be failing. [19:36:14] I’ll fix and write tests. [19:36:58] awight: it was being added to the RC query but not the contribs query [19:37:16] I’m running locally though and see it included in the query... [19:38:18] https://phabricator.wikimedia.org/P6299 [19:39:01] It gets added as a constant, so might as well take it out of the query and switch to do it like in your patch. [19:39:13] I’m just puzzled about how it’s failing. [19:40:37] 10Scoring-platform-team, 10ORES, 10SEO: Add relevant search terms to ORES docs - https://phabricator.wikimedia.org/T179631#3731447 (10srodlund) Online documents with appropriately used relevant search terms and phrases may help lead searchers to the information they need. Here are some possible search terms... [19:42:36] Oh. We want it in the queries so we can filter. [19:47:11] So draft quality campaign for enwiki is starting according to scrum of scrums is this correct? awight [19:52:10] Zppix: https://ores.wikimedia.org/v3/scores/enwiki/?models=draftquality [19:52:47] It’s available, but AFAIK there aren’t any frontend pieces making queries into it yet. Amir1: I was wondering if you know of consumers yet> [19:52:47] Is that a yes? [19:52:56] It has begun. [19:52:59] Ok [19:53:28] Well, technically we use “campaign” to describe the labeling initiative, so in those terms it’s finished. [19:53:39] Zppix: Are you thinking of doing or writing something related? [19:54:03] awight: oh i was going to do some labeling [19:54:14] But if theres no labeling to be done then nm [19:55:30] Zppix: http://labels.wmflabs.org/ui/enwiki/ [19:55:44] ah yes it’s finished. [19:55:49] Draft campaign is 100% [19:55:54] \p/ [19:55:55] The edit one isnt [19:56:09] But ive done so many worksheets on it its kinda buring me out [20:21:03] RoanKattouw: If the user is anonymous, do you know if getOption returns null or the default value? [20:21:12] The default [20:21:18] fancy, k thx [20:21:33] ah yep. $this->mOptions = self::getDefaultOptions(); [20:38:29] 10Scoring-platform-team, 10ORES, 10Easy: Wire statistics into test model included with our Vagrant role. - https://phabricator.wikimedia.org/T176914#3749131 (10awight) >>! In T176914#3670697, @Halfak wrote: > Or do you mean that we should simulate threshold statistics and store them in the revid model? That... [20:39:14] 10Scoring-platform-team (Current), 10ORES, 10Easy: Wire statistics into test model included with our Vagrant role. - https://phabricator.wikimedia.org/T176914#3749138 (10awight) [21:32:50] whoa, Disney's research team has a deep neural network that they trained to render clouds https://youtu.be/7wt-9fjPDjQ?list=PLujxSBD-JXgnqDD1n-V30pKtp6Q886x7e [21:38:04] Daamn [21:45:03] wiki-ai/ores#821 (revid_stats - cff401e : Adam Roses Wight): The build failed. https://travis-ci.org/wiki-ai/ores/builds/299877509 [23:21:50] 10Scoring-platform-team (Current), 10ORES, 10Easy: Wire statistics into test model included with our Vagrant role. - https://phabricator.wikimedia.org/T176914#3749522 (10awight) https://github.com/wiki-ai/ores/pull/232 [23:22:05] 10Scoring-platform-team (Current), 10ORES, 10Easy, 10Patch-For-Review: Wire statistics into test model included with our Vagrant role. - https://phabricator.wikimedia.org/T176914#3749525 (10awight) [23:23:09] 10Scoring-platform-team (Current), 10ORES, 10Easy, 10Patch-For-Review: Wire statistics into test model included with our Vagrant role. - https://phabricator.wikimedia.org/T176914#3641241 (10awight) While I'm being greedy, I'd like to take the dummy thresholds out of mw-vagrant and pull thresholds from the... [23:23:21] 10Scoring-platform-team (Current), 10ORES, 10Easy, 10Patch-For-Review: Wire statistics into test model included with our Vagrant role. - https://phabricator.wikimedia.org/T176914#3749530 (10awight) a:03awight