[03:30:16] (03PS1) 10Legoktm: Remove invalid @covers tag [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400143 (https://phabricator.wikimedia.org/T183604) [03:32:05] 10Scoring-platform-team, 10Cognate, 10MediaWiki-Core-Tests, 10MediaWiki-extensions-ORES, and 2 others: Can PHPUnit @covers tags cover entire files - https://phabricator.wikimedia.org/T183604#3860299 (10Legoktm) a:03Legoktm [12:07:12] (03CR) 10Ladsgroup: [C: 032] Remove invalid @covers tag [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400143 (https://phabricator.wikimedia.org/T183604) (owner: 10Legoktm) [12:15:46] (03Merged) 10jenkins-bot: Remove invalid @covers tag [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400143 (https://phabricator.wikimedia.org/T183604) (owner: 10Legoktm) [12:58:56] 10Scoring-platform-team, 10Cognate, 10MediaWiki-Core-Tests, 10MediaWiki-extensions-ORES, and 2 others: Can PHPUnit @covers tags cover entire files - https://phabricator.wikimedia.org/T183604#3860410 (10thiemowmde) >>! In T183604#3859996, @Legoktm wrote: > PHPUnit. Did you read https://phpunit.de/[…] PHPUn... [15:05:18] o/ [15:05:54] bah. [15:08:43] (03PS1) 10Ladsgroup: Update model version when it's different in ScoreParser [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400183 (https://phabricator.wikimedia.org/T183468) [15:09:15] BAM [15:09:56] Amir1: ^ [15:12:38] Coool [15:12:41] halfak: Thanks! [15:15:25] Thank you! [15:15:26] :D [15:18:55] We should rebuild the models :P [15:19:06] also I will make the reverted model for catalan [15:19:30] also I've been refactoring the extension (still) [15:35:01] +1 rebuilding the models will be much faster on stat1005 :D [16:02:10] Amir1: if you start building new models, we should cut a new version of revscoring. [16:02:37] halfak: okay, but I'd suggest my patch gets merged first :D [16:02:55] Which one? [16:02:59] I think i merged both PRs [16:03:47] Amir1: ^ [16:06:07] halfak: sorry, The patch in the extension [16:06:24] it automatically increments the version number when it sees a new one [16:09:14] Oh sure [17:06:31] (03PS1) 10Ladsgroup: [WIP] Split ThresholdLookup into two class [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400188 (https://phabricator.wikimedia.org/T181892) [17:28:32] The models are being rebuilt [18:45:13] 10Scoring-platform-team, 10Cognate, 10MediaWiki-Core-Tests, 10MediaWiki-extensions-ORES, and 3 others: Can PHPUnit @covers tags cover entire files - https://phabricator.wikimedia.org/T183604#3860495 (10Legoktm) >>! In T183604#3860410, @thiemowmde wrote: >>>! In T183604#3859996, @Legoktm wrote: >> PHPUnit.... [18:50:04] 10Scoring-platform-team, 10Cognate, 10MediaWiki-Core-Tests, 10MediaWiki-extensions-ORES, and 3 others: Can PHPUnit @covers tags cover entire files - https://phabricator.wikimedia.org/T183604#3860497 (10Legoktm) 05Open>03Resolved [19:07:40] halfak: its Christmas what are you doing here [19:09:22] :P