[00:00:07] okay, so moving on [00:20:56] 10Scoring-platform-team (Current), 10MediaWiki-extensions-ORES, 10User-Ladsgroup: Increase coverage of ORES extension - https://phabricator.wikimedia.org/T184140#3873732 (10Ladsgroup) [00:22:58] 10Scoring-platform-team, 10ORES: Rebuild ORES wheels on Stretch - https://phabricator.wikimedia.org/T184135#3873748 (10Halfak) https://github.com/wiki-ai/wikiclass/pull/57 https://github.com/wiki-ai/draftquality/pull/16 I'm waiting on @Ladsgroup to finish up the changes to editquality and then we'll be comple... [00:27:50] halfak: pushed new models [00:28:06] Amir1, great. [00:28:13] Did you get the requirements.txt too? [00:28:18] yup [00:29:34] Cool [00:30:17] Amir1, would you check on the simple little PRs here: [00:30:17] https://github.com/wiki-ai/wikiclass/pull/57 [00:30:17] https://github.com/wiki-ai/draftquality/pull/16 [00:30:40] (03PS1) 10Halfak: Rebuilds wheels using Debian Stretch [research/ores/wheels] - 10https://gerrit.wikimedia.org/r/401822 [00:31:42] * halfak updates that gerrit change [00:32:16] (03PS2) 10Halfak: Rebuilds wheels using Debian Stretch [research/ores/wheels] - 10https://gerrit.wikimedia.org/r/401822 (https://phabricator.wikimedia.org/T184135) [00:34:02] 10Scoring-platform-team, 10ORES, 10Patch-For-Review: Rebuild ORES wheels on Stretch - https://phabricator.wikimedia.org/T184135#3873776 (10Halfak) https://github.com/wiki-ai/ores/pull/245 [00:35:02] OK I think that's all for tonight. I'm outta here. [00:35:14] Thanks for working with me on this stuff, Amir1. [00:35:34] have halfak, I'm staying here to get ORES extension in shape šŸ’Ŗ [00:35:47] *have fun [00:35:57] OMG there's a muscley arm in unicode!? [00:36:11] šŸ’Ŗ [00:36:11] lol [00:36:16] :))) [00:36:17] OK gone for real [00:36:18] o/ [00:36:22] o/ [01:21:30] 10Scoring-platform-team (Current), 10MediaWiki-extensions-ORES, 10User-Ladsgroup: Refactor Scoring.php - https://phabricator.wikimedia.org/T184142#3873825 (10Ladsgroup) [01:21:57] (03PS1) 10Ladsgroup: Rename and cleanup Scoring.php [extensions/ORES] - 10https://gerrit.wikimedia.org/r/401824 (https://phabricator.wikimedia.org/T184142) [01:22:16] * awight sprinkles sleep-dust over Amir1 [01:22:42] TBH, I'm starting to feel sleepy :)) [01:23:07] (03CR) 10jerkins-bot: [V: 04-1] Rename and cleanup Scoring.php [extensions/ORES] - 10https://gerrit.wikimedia.org/r/401824 (https://phabricator.wikimedia.org/T184142) (owner: 10Ladsgroup) [01:26:47] awight: for when you have some free time: https://gerrit.wikimedia.org/r/#/c/401815/1/includes/Storage/SqlModelLookup.php [01:27:02] on it! [01:27:19] This is "clean"est that I can get until I move all functionalities to ModelStorage [01:28:21] (03PS2) 10Ladsgroup: Rename and cleanup Scoring.php [extensions/ORES] - 10https://gerrit.wikimedia.org/r/401824 (https://phabricator.wikimedia.org/T184142) [01:28:43] I also made the list of classes needing more tests, would be great to split them up and write more tests [01:28:57] Amir1: What about adding the model row using the same updateModelVersion logic, when checkModelVersion canā€™t find an existing model? [01:29:24] Amir1: Iā€™d be happy to do so, maybe I can start tomorrow. [01:29:33] great [01:30:36] awight: regarding your suggestion, I thought about it too, I was mostly worried about misconfiguration issues [01:31:05] but we should keep it in mind and move the method so it does it as well [01:31:46] Misconfiguration, like creating spurious model rows? [01:32:29] yeah [01:32:50] I think making a patch for that is extremely easy [01:32:59] yeah, let's do it [01:35:28] awight: with that change, do you think we should abandon https://gerrit.wikimedia.org/r/#/c/401815/1/includes/Storage/SqlModelLookup.php ? [01:35:32] less is more IMO [01:37:10] +1, this patch would be quite a surprising side effect for a ā€œgetModelDataā€ function, plus it doesnā€™t do us any good until the next request. [01:37:20] i.e. I like the simple way better. [01:37:24] (03PS1) 10Ladsgroup: Update model version when model lookup can't find the model [extensions/ORES] - 10https://gerrit.wikimedia.org/r/401827 (https://phabricator.wikimedia.org/T184127) [01:37:47] sooner coded than said ;-) [01:38:19] :D [01:38:32] it was extremely quick [01:39:00] (03Abandoned) 10Ladsgroup: Add models when ores_model is empty [extensions/ORES] - 10https://gerrit.wikimedia.org/r/401815 (https://phabricator.wikimedia.org/T184127) (owner: 10Ladsgroup) [01:39:44] (03CR) 10Awight: [C: 032] Update model version when model lookup can't find the model [extensions/ORES] - 10https://gerrit.wikimedia.org/r/401827 (https://phabricator.wikimedia.org/T184127) (owner: 10Ladsgroup) [01:41:20] awight: it won't merge is as it depends on the rename thingy :D [01:57:30] (03CR) 10Awight: [C: 032] Rename and cleanup Scoring.php (034 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/401824 (https://phabricator.wikimedia.org/T184142) (owner: 10Ladsgroup) [01:59:45] (03Merged) 10jenkins-bot: Rename and cleanup Scoring.php [extensions/ORES] - 10https://gerrit.wikimedia.org/r/401824 (https://phabricator.wikimedia.org/T184142) (owner: 10Ladsgroup) [01:59:47] (03Merged) 10jenkins-bot: Update model version when model lookup can't find the model [extensions/ORES] - 10https://gerrit.wikimedia.org/r/401827 (https://phabricator.wikimedia.org/T184127) (owner: 10Ladsgroup) [02:05:15] (03CR) 10jenkins-bot: Rename and cleanup Scoring.php [extensions/ORES] - 10https://gerrit.wikimedia.org/r/401824 (https://phabricator.wikimedia.org/T184142) (owner: 10Ladsgroup) [02:12:22] (03CR) 10jenkins-bot: Update model version when model lookup can't find the model [extensions/ORES] - 10https://gerrit.wikimedia.org/r/401827 (https://phabricator.wikimedia.org/T184127) (owner: 10Ladsgroup) [02:13:37] awight: thanks for the review, Should I make a followup for your comments or we should write it down somewhere (like phabricator) so we don't forget [02:17:29] 10Scoring-platform-team (Current), 10MediaWiki-extensions-ORES, 10MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), 10Patch-For-Review, 10User-Ladsgroup: Refactor Scoring.php - https://phabricator.wikimedia.org/T184142#3873825 (10Ladsgroup) Needs more cleanup and integration tests. I hate or... [02:40:03] (03CR) 10Ladsgroup: "@Petar.petkovic: It doesn't make any sense and I can't reproduce it and can't find it in logs, 1- Are you sure you are running the latest " [extensions/ORES] - 10https://gerrit.wikimedia.org/r/401608 (https://phabricator.wikimedia.org/T181334) (owner: 10Ladsgroup) [02:45:07] Amir1: Do what you like with the comments, nothing in that last review really bothered me. We should smoke test that ā€œprecached=1ā€ is making it through to the ORES API, thatā€™s all. [02:46:44] nah, I mean your suggestions are good and we should keep track of them, e.g. for screaming when 'models' is not in ores response [02:48:50] Good question in general. CR comments are pretty much ā€œread-onceā€ thanks to being buried in code. [02:52:29] (03PS1) 10Ladsgroup: Minor fixes to ORES\Hooks [extensions/ORES] - 10https://gerrit.wikimedia.org/r/401834 [02:52:40] ^ [02:52:46] I'm leaving for the day [02:52:50] see you soon [02:52:51] o/ [12:18:26] (03CR) 10Catrope: [C: 032] Minor fixes to ORES\Hooks [extensions/ORES] - 10https://gerrit.wikimedia.org/r/401834 (owner: 10Ladsgroup) [12:21:43] (03Merged) 10jenkins-bot: Minor fixes to ORES\Hooks [extensions/ORES] - 10https://gerrit.wikimedia.org/r/401834 (owner: 10Ladsgroup) [12:24:48] (03CR) 10jenkins-bot: Minor fixes to ORES\Hooks [extensions/ORES] - 10https://gerrit.wikimedia.org/r/401834 (owner: 10Ladsgroup) [15:02:26] halfak: FWIW, Iā€™m thinking that everything we discussed just now would work with or without MCR. [15:02:48] +1 [15:02:59] Rather than scores in nice slots, itā€™d just be the larger JSON struct. [15:03:12] Gonna be AFK for a qhile to travel to a doctor appointment [15:03:40] Wellā€¦ Iā€™m inspired to try a mini-prototype in MW to test some of the principles, but I guess we shouldnā€™t drag away from MVP. [15:03:47] godspeed! [15:03:48] With MCR, maybe we should store the event itself next to the revision it creates :) [15:03:54] whoa [15:03:56] And still just have a big blob [15:03:58] thatā€™s awesome. [15:04:21] Just one slot for, event that caused this edit. [15:04:26] * awight rehinges jaw [15:29:09] Iā€™m getting PTSD reading the discussions about uninstalling Flow [15:29:20] uninstalling it where? [15:29:27] everywhere? [15:29:34] or is this just one wiki? [15:49:00] apergos: Sorry for the distractionā€”this is a tiresome repetition of the blindly anti-WMF taking away of toysā€¦. https://commons.wikimedia.org/wiki/Commons:Village_pump/Proposals#Proposal_to_uninstall_Flow [15:49:23] It will cause migraines. [15:49:46] ā€œKill Flow because I decided I donā€™t like seeing other people using it!" [15:50:27] oh, commons [15:50:41] while it's undoubtedly important to the comunity, I can drop it back off my radar [15:51:00] uninstall from all wikis would mean something as far as the dumps, that's all. thanks for the reply [15:51:09] lol I see [15:56:16] 10Scoring-platform-team, 10Cleanup, 10Gerrit, 10Repository-Admins, 10Release-Engineering-Team (Kanban): Investigate and clean up deprecated ORES repos - https://phabricator.wikimedia.org/T179610#3875449 (10demon) a:05demon>03None [18:37:44] 10Scoring-platform-team, 10Bad-Words-Detection-System, 10revscoring, 10artificial-intelligence: Add language support for basque - https://phabricator.wikimedia.org/T184205#3876074 (10MaiteUrra) [19:42:49] back and in another meeting ^_^ [19:57:03] For some inane reason, my IRC client translates ā€œ^_^ā€ into person-wearing-halo. [19:57:11] That doesnā€™t seem right to me, must disable. [19:57:21] it's perfect! [19:57:25] what color is the halo? [19:57:57] Itā€™s sort of a pagan flower crown maybe. [19:57:59] * awight squints [19:58:18] * awight turns to a pillar of salt [19:58:38] multiple colors? because that would be perfect [19:59:09] youā€™re such an optimist ;-) [19:59:44] šŸ¦ˆ [20:00:18] are sharks optimists? [20:00:22] itā€™s a dolphin? :) [20:00:27] nope, it's a shark [20:00:39] https://emojipedia.org/emoji/%F0%9F%A6%88/ [20:00:59] šŸ¤¼ [20:01:51] šŸ¬ [20:01:54] there's the dolphin [20:47:08] 10Scoring-platform-team, 10JADE, 10Design: Design conceptual prototype of JADE integration with MediaWiki - https://phabricator.wikimedia.org/T182829#3835906 (10awight) Playing with ContentHandler: https://github.com/adamwight/mw-ext-JADE [21:07:00] OMG we're failing tests all of a sudden because flake8 got an upgrade and catches more stuff [21:07:03] FML [21:09:01] hahaha [21:09:10] add exceptions :) [21:09:37] except Exception :) [21:09:52] I'll show you, flake [21:09:58] halfak: Want me to grab another repo? [21:10:05] * halfak shakes fist in a git-off-my-lawn manner [21:10:15] awight, yeah if you see issues like this elsewhere. [21:10:48] Iā€™ll see if I can re-run tests on the repo heads [21:12:33] hacktuallyā€¦ halfak: can you link me to a test failure, or have the exact flake8 version [21:12:34] ? [21:14:09] got it. https://travis-ci.org/wiki-ai/ores/builds/325203300 [21:16:11] WTF is this error that "l" is ambiguous [21:16:23] Let me use my judgement. Sometimes you're just turning a set into a list [21:16:34] "l" is better than "list value" [21:18:09] Oh well, I'll just get rid of the var all together [21:19:14] hehe [21:19:23] Iā€™m poking at the revscoring repo. [21:27:00] wiki-ai/ores#919 (revscoring_2.1 - 9f2bb2f : halfak): The build was fixed. https://travis-ci.org/wiki-ai/ores/builds/325208314 [21:31:59] halfak: ^ [21:32:09] oops ^ [21:33:42] Waiting for travis before I merge :) [21:33:58] +1 :) [21:36:21] Thanks awight! [21:38:30] halfak: Youā€™re staying on ores, right? [21:38:43] ORES is good to go [21:39:02] * halfak is signing up for the Wikimedia Hackathon now [21:39:10] But I'll be back to looking for other flakes soon [21:39:40] wiki-ai/revscoring#1408 (master - 322619b : Aaron Halfaker): The build was broken. https://travis-ci.org/wiki-ai/revscoring/builds/325212621 [21:39:50] lol [21:39:54] :p [21:39:58] what did I DO? [21:40:36] halfak: ^ [21:41:30] wiki-ai/wikilabels#259 (flake-3.5.0 - d07ec7e : Adam Roses Wight): The build passed. https://travis-ci.org/wiki-ai/wikilabels/builds/325213612 [21:43:18] halfak: random thing. Did you want jade.types to from .events import * ? [21:43:53] Probably never "import *" [21:44:01] But I'm not sure I understand the Q [21:45:09] nvmā€”theyā€™re unused imports, but since some of this stuff is skeletal, Iā€™ll just comment out so itā€™s available later. [21:54:55] a very random q, halfak (since I am reading the email update on the wikidev summit): any background reading for the analytics/research/ml session? [21:55:09] https://phabricator.wikimedia.org/T183320 I see placeholders yet [21:55:39] apergos, still haven't had a chance to meet with Leila and milimetric yet [21:56:06] ah gotcha [21:56:14] I'll likely recommend something social-sciency around practical ML [21:56:18] ok [21:56:27] Maybe the "What happens when ClueBot went down" paper [21:56:31] I'm one of those people who has to prep up before going into a discussion [21:56:40] can't do off the cuff and be at all useful [21:56:44] or the "How does enwiki form a distributed cognition to identify and ban vandals" paper [21:57:04] I'd rather talk about what we can do with ML than talk about ML itself. [21:57:15] you can always recommend more than one thing and ask people to pick (1, , whatever) from there, too ;-) [21:57:35] Fair point. Might try to find a summary paper on vandalism detection. [21:57:42] well I can't imagine we are all going to sit down and decide how many convolution layers we want in our commons image classification tool [21:58:07] so, yeah... enough knowledge that people understand the boundaries of the issue, should be good enough [22:01:12] thank you [22:01:29] (Just added the IRC hooks for wiki-ai/jade) [22:01:41] * awight drums fingers [22:02:59] halfak: no notification. but I made this for you, https://github.com/wiki-ai/jade/pull/7 [22:03:54] <3 [22:04:10] * awight never coats in chocolate [22:04:37] halfak: you know anything about the IRC notifier? I see thereā€™s a username ā€œoresā€, but is there a password? [22:05:37] I don't think there needs to be a password. [22:05:47] kk [22:27:25] halfak: ^ [22:28:25] awight, https://github.com/wiki-ai/ores/pull/245 [22:28:33] onit [22:28:37] That'll fix ORES lint and implement the 2.1 stuff [22:34:33] ok I'm out of here. [22:34:40] I'll get all of the Stretch stuff in line tomorrow. [22:34:45] nice. [22:34:47] So we should be able to do a test deploy on Monday or whenever alex has the cluster ready [22:34:52] Weā€™re good in mw-vagrant, btw. [22:34:56] nice :) [22:35:00] I added some minor patches [22:35:57] * halfak runs away [22:35:59] o/ [22:56:44] wiki-ai/wikiclass#27 (flake-3.5.0 - a019e59 : Adam Roses Wight): The build passed. https://travis-ci.org/wiki-ai/wikiclass/builds/325237232