[09:52:46] (03CR) 10Ladsgroup: "Well, in the discussion Daniel pointed out that "Database" class is also not a database but the connector for the code to it. I can go wit" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402477 (owner: 10Ladsgroup) [10:23:29] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "Typically a class *is* not what it says. It *represents* something. I like the example given: we don't name database classes "connectors"," (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402477 (owner: 10Ladsgroup) [10:25:22] (03PS1) 10Ladsgroup: Reorder attributes in ThresholdLookup [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402798 (https://phabricator.wikimedia.org/T181892) [10:27:05] (03CR) 10jerkins-bot: [V: 04-1] Reorder attributes in ThresholdLookup [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402798 (https://phabricator.wikimedia.org/T181892) (owner: 10Ladsgroup) [10:35:21] (03PS2) 10Ladsgroup: Reorder attributes in ThresholdLookup [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402798 (https://phabricator.wikimedia.org/T181892) [10:57:02] (03PS1) 10Ladsgroup: Rename scoring variables to scoreFetcher [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402804 (https://phabricator.wikimedia.org/T181892) [10:58:18] (03CR) 10jerkins-bot: [V: 04-1] Rename scoring variables to scoreFetcher [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402804 (https://phabricator.wikimedia.org/T181892) (owner: 10Ladsgroup) [11:00:22] (03PS2) 10Ladsgroup: Rename scoring variables to scoreFetcher [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402804 (https://phabricator.wikimedia.org/T181892) [11:44:38] 10Scoring-platform-team (Current), 10ORES, 10Operations, 10Graphite, and 2 others: Regularly purge old ores graphite metrics - https://phabricator.wikimedia.org/T169969#3882455 (10fgiunchedi) @Halfak see https://gerrit.wikimedia.org/r/401917 [13:42:50] 10Scoring-platform-team, 10Beta-Cluster-Infrastructure, 10ORES, 10Wikimedia-log-errors: Move beta cluster ORES to its own machine - https://phabricator.wikimedia.org/T184282#3882712 (10awight) It seems we have an ORES Redis node in deployment-prep, which is unnecessary. That role should be fulfilled by th... [14:03:58] 10Scoring-platform-team (Current), 10MediaWiki-extensions-ORES, 10MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), 10Patch-For-Review, 10User-Ladsgroup: Add models when initializing the table - https://phabricator.wikimedia.org/T184127#3882755 (10awight) Maybe, the hook should log a warning... [14:04:24] awight do you like https://phabricator.wikimedia.org/F12304482 ? [14:04:54] paladox: It’s very abstract :) [14:04:59] :) [14:05:13] awight i am updating gerrit's login ui for wmf (i found it from typo3) :) [14:05:15] O/ [14:05:24] https://gerrit.wikimedia.org/r/#/c/402665/ [14:05:32] very classy! [14:05:40] Yep :). [14:06:59] whew, I just reminded myself of the current login form. It’s as barebones as the Catacombs. [14:07:21] lol [14:07:43] I love that ui [14:07:45] I want it [14:07:52] I want it on everything [14:07:56] Lets add it to mw [14:08:38] lol yeh it's beautiful. [14:16:51] awight: hey, I have some small patches in the extension for you to review when you have some free time [14:17:13] Amir1: thanks for the ping—looking now [14:20:36] o/ [14:21:03] I won't be able to join meetings today since I'm conferencing. Please proceed without me [14:23:39] halfak: have fun! [14:24:27] Yessir. [14:24:48] :P [14:27:14] (03CR) 10Awight: [C: 032] Split Hooks::onChangesListSpecialPageStructuredFilters (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402488 (owner: 10Ladsgroup) [14:30:17] (03Merged) 10jenkins-bot: Split Hooks::onChangesListSpecialPageStructuredFilters [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402488 (owner: 10Ladsgroup) [14:30:49] (03CR) 10Awight: [C: 032] Rename Api class to ORESService [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402477 (owner: 10Ladsgroup) [14:32:35] (03Merged) 10jenkins-bot: Rename Api class to ORESService [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402477 (owner: 10Ladsgroup) [14:33:31] (03CR) 10jenkins-bot: Split Hooks::onChangesListSpecialPageStructuredFilters [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402488 (owner: 10Ladsgroup) [14:34:20] (03CR) 10Awight: [C: 032] Rename scoring variables to scoreFetcher [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402804 (https://phabricator.wikimedia.org/T181892) (owner: 10Ladsgroup) [14:36:06] (03Merged) 10jenkins-bot: Rename scoring variables to scoreFetcher [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402804 (https://phabricator.wikimedia.org/T181892) (owner: 10Ladsgroup) [14:38:17] 10Scoring-platform-team, 10Wikilabels: Redirect Wikilabels to HTTPS - https://phabricator.wikimedia.org/T184437#3882870 (10Tacsipacsi) [14:40:25] (03CR) 10jenkins-bot: Rename Api class to ORESService [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402477 (owner: 10Ladsgroup) [14:43:32] (03CR) 10jenkins-bot: Rename scoring variables to scoreFetcher [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402804 (https://phabricator.wikimedia.org/T181892) (owner: 10Ladsgroup) [14:49:05] awight i've addressed your feedback :) [14:49:37] awight https://gerrit.git.wmflabs.org/r/login/%23%2Fq%2Fstatus%3Aopen :) [15:31:06] 10Scoring-platform-team (Current), 10editquality-modeling, 10User-Ladsgroup, 10artificial-intelligence: Train/test reverted model for Catalan Wikipedia - https://phabricator.wikimedia.org/T182611#3882998 (10Ladsgroup) a:03Ladsgroup [15:32:28] 10Scoring-platform-team (Current), 10MediaWiki-extensions-ORES, 10MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), 10Patch-For-Review, 10User-Ladsgroup: Increase coverage of ORES extension - https://phabricator.wikimedia.org/T184140#3883007 (10awight) a:05Ladsgroup>03awight [15:34:32] (03CR) 10Awight: [C: 032] Reorder attributes in ThresholdLookup [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402798 (https://phabricator.wikimedia.org/T181892) (owner: 10Ladsgroup) [15:36:25] (03Merged) 10jenkins-bot: Reorder attributes in ThresholdLookup [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402798 (https://phabricator.wikimedia.org/T181892) (owner: 10Ladsgroup) [15:36:40] Amir1: When does the mw-ext coverage report get regenerated? i.e., how up-to-date is it? [15:37:07] I used to be twice a day but now I think it's after each merge (part of post-merge jobs) [15:37:09] I see a date. Just no tree-ish [15:37:11] niiice [15:40:07] (03CR) 10jenkins-bot: Reorder attributes in ThresholdLookup [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402798 (https://phabricator.wikimedia.org/T181892) (owner: 10Ladsgroup) [15:41:20] awight: no sync? or it ended early? [15:41:40] codezee: Sorry to have missed you! We ended a bit early. [15:41:54] There are some minutes in the etherpad, feel free to add stuff there, or discuss here. [15:42:31] ok, thanks...i just got late [15:42:56] codezee: You’re probably looking for halfak to sync about draft topic, maybe grab him via other means? [15:43:49] awight: yeah, no problem i'll do that [15:51:30] I'm leaving for one or two hours will be back soon [16:02:44] ✔ [16:03:26] ✖ [16:03:58] Amir1: FWIW, I think was wrong, and it’s good to annotate @group ORES in all of our tests. [16:04:02] (sorry, that emoji just is huge in my irc client for some reason) [16:05:16] apergos: 🐕<3 [16:07:30] 🐢🐢🐢🐢 all the way down... [16:35:32] 10Scoring-platform-team, 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-ORES, 10User-zeljkofilipin: Selenium tests for ORES - https://phabricator.wikimedia.org/T184451#3883283 (10Etonkovidova) [16:43:57] (03PS1) 10Etonkovidova: Create Selenium UI tests for ORES damaging and good faith filters. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402863 (https://phabricator.wikimedia.org/T184451) [16:45:35] (03CR) 10jerkins-bot: [V: 04-1] Create Selenium UI tests for ORES damaging and good faith filters. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402863 (https://phabricator.wikimedia.org/T184451) (owner: 10Etonkovidova) [16:58:16] (03PS2) 10Etonkovidova: Create Selenium UI tests for ORES damaging and good faith filters. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402863 (https://phabricator.wikimedia.org/T184451) [17:09:22] Amir1: I’m running into remedial trouble with phpunit... [17:09:49] Tests were working for me recently, but now setUp is failing with “Class 'ORES\Storage\HashModelLookup' not found” [17:10:10] Anything obvious I might have missed? [17:10:22] I’m doing, sudo -u www-data php5 tests/phpunit/phpunit.php --wiki wiki --debug extensions/ORES/tests/phpunit/includes/Hooks/ChangesListHooksHandlerTest.php [17:10:40] Did a composer update and install in both mediawiki/ and ORES/ [17:12:56] /facepalm [17:13:06] I disabled the vagrant ores role at some point. [17:17:19] That was all. [17:52:49] TIL that halfak|Network_d has his own Commons category [17:55:27] o.O [18:15:17] just got back [18:15:24] awight: sorry to miss your messages [18:15:41] Amir1: :) it probably saved me some real-time embarrassment. [18:17:16] :P I could save lot of time [18:18:22] This was a pretty obscure own-goal. [18:18:34] I had disabled the vagrant role. [18:18:52] You probably would have been too polite to ask ;-) [18:27:12] (03PS1) 10Awight: Mostly cover ChangesListHooksHandler [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402878 (https://phabricator.wikimedia.org/T184140) [18:28:32] (03CR) 10jerkins-bot: [V: 04-1] Mostly cover ChangesListHooksHandler [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402878 (https://phabricator.wikimedia.org/T184140) (owner: 10Awight) [18:30:16] (03PS2) 10Awight: Mostly cover ChangesListHooksHandler [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402878 (https://phabricator.wikimedia.org/T184140) [18:31:27] (03CR) 10jerkins-bot: [V: 04-1] Mostly cover ChangesListHooksHandler [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402878 (https://phabricator.wikimedia.org/T184140) (owner: 10Awight) [18:33:09] awight: I remember why I gave a dedicated node to ores redis [18:33:18] hmm [18:33:54] it was because we had lots of down times that we couldn't catch due to difference of beta and prod settings [18:34:13] (03PS3) 10Awight: Mostly cover ChangesListHooksHandler [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402878 (https://phabricator.wikimedia.org/T184140) [18:34:26] so we decided to make beta similar to prod as much as possible [18:34:27] Amir1: Ah, sounds like we don’t need it any more, then? [18:34:39] There are plenty of differences, but that’s probably a safe one [18:34:52] It may have been OOM even back then, so moving Redis makes sense [18:34:59] looking back, it was just being too safe [18:35:00] but with 8-16GB we shouldn’t hit that wall. [18:35:04] :D [18:36:13] Tests are ready for CR [18:36:23] I have to run for 1-2 hours, see you then. [18:36:37] see you [18:36:38] have fun [18:37:47] meh just an errand I have to do during daytime [18:37:59] Not like freaking Sanibel Island or anything :p [18:38:02] biab [18:41:52] I feel very tired, going to take nap [18:41:56] will be back soon [21:21:06] 10Scoring-platform-team, 10Beta-Cluster-Infrastructure, 10ORES, 10Puppet: Puppet broken on deployment-ores01 due to missing hieradata - https://phabricator.wikimedia.org/T184478#3884352 (10Krenair) p:05Triage>03Normal [21:21:28] 10Scoring-platform-team, 10Beta-Cluster-Infrastructure, 10ORES, 10Puppet: Puppet broken on deployment-ores01 due to missing hieradata - https://phabricator.wikimedia.org/T184478#3884365 (10Krenair) It actually looks like no one but me has logged onto this thing [21:31:26] 10Scoring-platform-team, 10Analytics, 10Analytics-Wikistats, 10ORES: Discuss Wikistats integration for ORES - https://phabricator.wikimedia.org/T184479#3884392 (10awight) [22:25:10] (03PS1) 10Awight: Cover some of Hooks [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403068 (https://phabricator.wikimedia.org/T184140) [22:26:21] (03CR) 10jerkins-bot: [V: 04-1] Cover some of Hooks [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403068 (https://phabricator.wikimedia.org/T184140) (owner: 10Awight) [22:34:38] (03PS2) 10Awight: Cover some of Hooks [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403068 (https://phabricator.wikimedia.org/T184140) [22:39:51] (03CR) 10jerkins-bot: [V: 04-1] Cover some of Hooks [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403068 (https://phabricator.wikimedia.org/T184140) (owner: 10Awight)