[04:47:06] 10Scoring-platform-team, 10MediaWiki-extensions-ORES, 10Need-volunteer: Cached thresholds should be invalidated for new model versions. - https://phabricator.wikimedia.org/T177421#3658047 (10Ladsgroup) This is done around one month ago, by adding model version to cache key. I did it. [04:50:12] 10Scoring-platform-team (Current), 10MediaWiki-extensions-ORES, 10Need-volunteer, 10User-Ladsgroup: Cached thresholds should be invalidated for new model versions. - https://phabricator.wikimedia.org/T177421#3888825 (10Ladsgroup) a:03Ladsgroup [04:59:43] (03CR) 10Ladsgroup: [C: 04-1] "The database issue is important, otherwise good to go." (032 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403227 (https://phabricator.wikimedia.org/T184140) (owner: 10Awight) [05:05:44] (03CR) 10Ladsgroup: [C: 032] Mostly cover ORES\Hooks [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403068 (https://phabricator.wikimedia.org/T184140) (owner: 10Awight) [05:08:22] (03CR) 10Ladsgroup: [C: 032] Mostly cover ChangesListHooksHandler [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402878 (https://phabricator.wikimedia.org/T184140) (owner: 10Awight) [05:10:42] (03Merged) 10jenkins-bot: Mostly cover ChangesListHooksHandler [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402878 (https://phabricator.wikimedia.org/T184140) (owner: 10Awight) [05:10:44] (03Merged) 10jenkins-bot: Mostly cover ORES\Hooks [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403068 (https://phabricator.wikimedia.org/T184140) (owner: 10Awight) [05:14:08] (03CR) 10jenkins-bot: Mostly cover ChangesListHooksHandler [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402878 (https://phabricator.wikimedia.org/T184140) (owner: 10Awight) [05:17:16] (03CR) 10jenkins-bot: Mostly cover ORES\Hooks [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403068 (https://phabricator.wikimedia.org/T184140) (owner: 10Awight) [06:03:53] 10Scoring-platform-team, 10Cleanup, 10Gerrit, 10Repository-Admins, 10Release-Engineering-Team (Kanban): Investigate and clean up deprecated ORES repos - https://phabricator.wikimedia.org/T179610#3888923 (10Ladsgroup) So the plan was to move mediawiki services/ores/deploy to research/ores/deploy give it p... [06:50:03] 10Scoring-platform-team (Current), 10MediaWiki-extensions-ORES, 10User-Ladsgroup: Deprecate Extension:ORES "beta" mode - https://phabricator.wikimedia.org/T184554#3888969 (10Ladsgroup) a:03Ladsgroup [06:50:27] 10Scoring-platform-team (Current), 10MediaWiki-extensions-ORES, 10User-Ladsgroup: Deprecate Extension:ORES "beta" mode - https://phabricator.wikimedia.org/T184554#3888972 (10Ladsgroup) Removing code always has high priority for me, less is more. [11:01:19] (03PS1) 10Ladsgroup: Turn ORESService to a service and turn originalRequest to attribute [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403384 (https://phabricator.wikimedia.org/T184142) [11:02:57] (03CR) 10jerkins-bot: [V: 04-1] Turn ORESService to a service and turn originalRequest to attribute [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403384 (https://phabricator.wikimedia.org/T184142) (owner: 10Ladsgroup) [12:15:24] (03PS2) 10Ladsgroup: Turn ORESService to a service and turn originalRequest to attribute [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403384 (https://phabricator.wikimedia.org/T184142) [12:17:01] (03CR) 10jerkins-bot: [V: 04-1] Turn ORESService to a service and turn originalRequest to attribute [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403384 (https://phabricator.wikimedia.org/T184142) (owner: 10Ladsgroup) [15:29:48] (03PS5) 10Awight: Tests for WatchedItemQueryServiceExtension [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403227 (https://phabricator.wikimedia.org/T184140) [15:29:50] (03PS2) 10Awight: [WIP] Add more WatchedItemQueryServiceExtension tests. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403234 (https://phabricator.wikimedia.org/T184140) [15:31:46] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add more WatchedItemQueryServiceExtension tests. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403234 (https://phabricator.wikimedia.org/T184140) (owner: 10Awight) [15:34:08] (03CR) 10Ladsgroup: [C: 032] Tests for WatchedItemQueryServiceExtension [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403227 (https://phabricator.wikimedia.org/T184140) (owner: 10Awight) [15:35:07] 10Scoring-platform-team, 10articlequality-modeling, 10Easy, 10Google-Code-in-2017, 10artificial-intelligence: Implement feature for detecting clumps of text that lack references - https://phabricator.wikimedia.org/T174384#3889998 (10Phantom42) a:03Phantom42 This seems to be really interesting. I will w... [15:36:02] (03Merged) 10jenkins-bot: Tests for WatchedItemQueryServiceExtension [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403227 (https://phabricator.wikimedia.org/T184140) (owner: 10Awight) [15:44:04] (03CR) 10jenkins-bot: Tests for WatchedItemQueryServiceExtension [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403227 (https://phabricator.wikimedia.org/T184140) (owner: 10Awight) [15:47:19] (03CR) 10Awight: Tests for WatchedItemQueryServiceExtension (032 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403227 (https://phabricator.wikimedia.org/T184140) (owner: 10Awight) [15:51:06] Amir1: :D https://scrutinizer-ci.com/g/wikimedia/mediawiki-extensions-ORES/?branch=master [15:51:11] Never mind the 6.66 score [15:52:12] https://scrutinizer-ci.com/g/wikimedia/mediawiki-extensions-ORES/code-structure/master/hot-spots [15:53:27] (03PS3) 10Awight: [WIP] Add more WatchedItemQueryServiceExtension tests. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403234 (https://phabricator.wikimedia.org/T184140) [15:53:31] Back in 30min [15:54:40] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add more WatchedItemQueryServiceExtension tests. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403234 (https://phabricator.wikimedia.org/T184140) (owner: 10Awight) [16:00:50] 10Scoring-platform-team, 10Education-Program-Dashboard, 10ORES, 10Outreach-Programs-Projects, and 5 others: Add automatic article feedback feature to Wiki Ed Dashboard / Programs & Events Dashboard - https://phabricator.wikimedia.org/T158679#3890104 (10Ragesoss) [16:01:20] 10Scoring-platform-team, 10Education-Program-Dashboard, 10ORES, 10Outreach-Programs-Projects, and 5 others: Add automatic article feedback feature to Wiki Ed Dashboard / Programs & Events Dashboard - https://phabricator.wikimedia.org/T158679#3043754 (10Ragesoss) 05Open>03Resolved a:03Ragesoss [16:29:32] (03PS3) 10Ladsgroup: Turn ORESService to a service and turn originalRequest to attribute [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403384 (https://phabricator.wikimedia.org/T184142) [16:29:46] awight: welcome back, that's soo cool [16:30:07] We need to fix false positives, after that, this will be crazy: https://scrutinizer-ci.com/g/wikimedia/mediawiki-extensions-ORES/issues/master/files/includes/ApiQueryORES.php?selectedLabels%5B0%5D=9&orderField=path&order=asc&honorSelectedPaths=0 [16:30:53] Amir1: :D right? bd808 recommended the service a while ago, it’s pretty darn accurate wrt. classes needing improvement. [16:31:12] (03CR) 10jerkins-bot: [V: 04-1] Turn ORESService to a service and turn originalRequest to attribute [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403384 (https://phabricator.wikimedia.org/T184142) (owner: 10Ladsgroup) [16:31:37] yup, already ChangesListHookHandler is marked as horrible [16:31:39] :D [16:34:02] I’m not sure how to pull in the MediaWiki dependencies... [16:34:08] Seems to work for other projects, though? [16:34:21] (03PS4) 10Ladsgroup: Turn ORESService to a service and turn originalRequest to attribute [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403384 (https://phabricator.wikimedia.org/T184142) [16:34:43] e.g. https://scrutinizer-ci.com/g/wikimedia/mediawiki-extensions-CentralNotice/code-structure/master/class/%2Bglobal%5CCentralNotice [16:34:52] IDK TBH [16:35:05] Maybe some file makes it understand that [16:35:09] SpecialPage [16:38:58] Do you know who set it up for the extension? they might have a clue [16:39:21] also btw. I moved ores beta to a dedicated node, it's done now [16:39:49] and the redis is dead and we use the prod puppet roles [16:39:57] I set up both the extension that works, and this one :) [16:40:01] it makes me ten times happier than the last week [16:40:14] Amir1: Nice one! Nice two!! [16:40:15] coolio [16:40:52] keep me posted about scrutinizer [16:41:20] if you decided to drop it (for any reason) I might be able to lend a hand but I will be way slow [16:43:42] 10Scoring-platform-team (Current), 10ORES, 10Operations, 10Graphite, and 2 others: Regularly purge old ores graphite metrics - https://phabricator.wikimedia.org/T169969#3890264 (10Halfak) OK great. I'll go +1 :) [16:47:10] K, some of the MW classes in Ext:ORES are found, so I’ll try to figure out what the difference is. [17:58:02] Amir1: ooh, I just parsed that bit about “we use the prod puppet roles”. Sick! [17:59:53] (03PS4) 10Awight: Add more WatchedItemQueryServiceExtension tests. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403234 (https://phabricator.wikimedia.org/T184140) [17:59:55] (03PS1) 10Awight: Move some sharable methods into a test helper [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403450 [18:08:19] (03CR) 10Awight: "Great work!" (032 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403384 (https://phabricator.wikimedia.org/T184142) (owner: 10Ladsgroup) [18:11:40] (03CR) 10Awight: "Thanks for kicking this off, exciting stuff!" (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/402863 (https://phabricator.wikimedia.org/T184451) (owner: 10Etonkovidova) [18:12:24] Amir1: You might want to add yourself as a review for E:ORES on https://www.mediawiki.org/wiki/Git/Reviewers [18:13:05] (03CR) 10Awight: [C: 032] Turn ORESService to a service and turn originalRequest to attribute [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403384 (https://phabricator.wikimedia.org/T184142) (owner: 10Ladsgroup) [18:16:09] (03Merged) 10jenkins-bot: Turn ORESService to a service and turn originalRequest to attribute [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403384 (https://phabricator.wikimedia.org/T184142) (owner: 10Ladsgroup) [18:23:46] (03CR) 10jenkins-bot: Turn ORESService to a service and turn originalRequest to attribute [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403384 (https://phabricator.wikimedia.org/T184142) (owner: 10Ladsgroup) [19:05:56] (03PS1) 10Awight: Cover a couple of conditions [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403458 [19:38:32] Amir1: Wanna merge some stuff? [19:39:12] I think the next patches eek us over the 60% mark, fwiw. [19:40:18] nah not quite. [19:41:03] awight: meeting atm, will do it soon :D [19:42:02] apergos: Do you have the criteria for dumps written somewhere? [19:42:40] I have this skeleton waiting for details… T183204 [19:42:40] T183204: Build consumable dumps of JADE - https://phabricator.wikimedia.org/T183204 [19:49:08] (03CR) 10Ladsgroup: [C: 032] Move some sharable methods into a test helper [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403450 (owner: 10Awight) [19:50:14] (03CR) 10Ladsgroup: [C: 04-1] Add more WatchedItemQueryServiceExtension tests. (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403234 (https://phabricator.wikimedia.org/T184140) (owner: 10Awight) [19:51:16] awight: uh, criteria for what exactly? [19:52:07] (03PS5) 10Awight: Add more WatchedItemQueryServiceExtension tests. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403234 (https://phabricator.wikimedia.org/T184140) [19:52:12] (03PS2) 10Awight: Cover a couple of conditions [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403458 [19:52:25] (03CR) 10Awight: Add more WatchedItemQueryServiceExtension tests. (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403234 (https://phabricator.wikimedia.org/T184140) (owner: 10Awight) [19:52:50] apergos: Is there anything special we should do WRT how dumps are produced, support to restore from dumps, etc? [19:53:06] criteria for us not making your life more difficult :) [19:54:32] where? I'm completely missing the context here [19:54:34] sorry... [19:54:36] (03Merged) 10jenkins-bot: Move some sharable methods into a test helper [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403450 (owner: 10Awight) [19:55:27] apergos: sorry, we’re adding a new service “JADE”, http://mediawiki.org/wiki/JADE . You’ve mentioned that anything on WMF production needs to support dumps, so I’m wondering what that looks like. [19:56:22] We’ll have a postgresql database that mostly duplicates data already in the MW DB, but in a different format. We could reconstruct this by replaying a Kafka event log, but I’m thinking we also want a .sql dump. [19:57:41] On that note, we also have a postgresql database for Wikilabels, see https://phabricator.wikimedia.org/T155116 . We now have backups of that database, but if there’s a checklist for dumps, I can make sure we’re playing nice. [19:57:53] (03CR) 10jenkins-bot: Move some sharable methods into a test helper [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403450 (owner: 10Awight) [19:58:38] awight: in this case you need to add @group database at the top of the file and add tablesUsed in setUp see the integration tests for the api [19:58:39] https://gerrit.wikimedia.org/r/#/c/403234/5/tests/phpunit/includes/WatchedItemQueryServiceExtensionTest.php [19:59:09] Amir1: OK good point about the @group. No point in being stingy about the tablesUsed, either. [19:59:46] awight: oh regarding the tablesUsed, you're right [19:59:48] my bad [19:59:51] I missed it [20:00:08] (03PS6) 10Awight: Add more WatchedItemQueryServiceExtension tests. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403234 (https://phabricator.wikimedia.org/T184140) [20:00:10] (03PS3) 10Awight: Cover a couple of conditions [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403458 [20:00:11] I catch them one in a while [20:02:20] *once hehe [20:03:58] (03CR) 10Ladsgroup: [C: 032] Add more WatchedItemQueryServiceExtension tests. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403234 (https://phabricator.wikimedia.org/T184140) (owner: 10Awight) [20:04:05] ah now I see [20:04:27] (03CR) 10Ladsgroup: [C: 032] Cover a couple of conditions [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403458 (owner: 10Awight) [20:04:32] let's say you want these once a week (?) [20:04:44] these are... per wiki? I guess? [20:05:02] we need to plan for capacity if the jobs are going to take awhile to run across all wikis [20:05:13] figure out how many revisions per wiki we might have in a year [20:05:18] in three years, etc [20:05:35] you could provide a script that does the dump on one wiki and we have infra to run on all [20:05:58] we do want: if you do full revision history in xml format then please let's don't ask the db for all those revisions every time, [20:06:03] use the previous dump and read those [20:06:22] some revisions will be hidden maybe so there's that, you can't just dump the table [20:06:27] these will be for public consumption [20:06:51] should we have a chat for 20 mins sometime and talk about these things? [20:07:19] (03Merged) 10jenkins-bot: Add more WatchedItemQueryServiceExtension tests. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403234 (https://phabricator.wikimedia.org/T184140) (owner: 10Awight) [20:07:21] (03Merged) 10jenkins-bot: Cover a couple of conditions [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403458 (owner: 10Awight) [20:10:16] apergos: Sounds good, thanks for the pointers. I’ll bother you for a meeting once we make more progress towards implementing... [20:10:30] (03CR) 10jenkins-bot: Add more WatchedItemQueryServiceExtension tests. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403234 (https://phabricator.wikimedia.org/T184140) (owner: 10Awight) [20:10:54] 10Scoring-platform-team, 10JADE: Build consumable dumps of JADE - https://phabricator.wikimedia.org/T183204#3891103 (10awight) [20:18:39] (03CR) 10jenkins-bot: Cover a couple of conditions [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403458 (owner: 10Awight) [20:19:29] I'm leaving for the day [20:19:31] o/ [20:19:35] see ya [20:37:13] ok, great! [20:42:41] https://google.qualtrics.com/jfe/form/SV_0JKI9MBgY4eY4x7 [20:42:49] gerrit's ui feedback ^^ [20:42:56] (they are actually listening) [20:44:51] I've gottenmore or less used to the gerrit one, there's only sometimes where it pretends I can merge, except I can't, or where I know a changeset has been merged in the meantime and it won't let me rebase [20:44:57] but that's not the ui per se, just a buglet [20:45:25] apergos that' [20:45:28] that's jgit [20:45:38] it's been updated + it now uses a git repo [20:45:52] no longer needs a db. (soon, most has been migrated anyways) [20:46:43] apergos did you see gerrit's new ui? [20:46:48] no [20:46:57] too busy yelling at phabricator, heh [20:47:08] apergos heh. [20:47:45] apergos https://gerrit.git.wmflabs.org/r/?polygerrit=1 (runs 2.14 and what production will run soon) and https://gerrit-new.wmflabs.org/r/?polygerrit=1 (runs master) [20:48:01] and this is what it will eventually look like https://docs.google.com/presentation/d/17q-ygGioZi_5DITLyELa8oaOr22e15AHy8cq6XTZ0nY/edit#slide=id.g27f16618ec_0_139 [20:48:07] which was based on the survey [20:49:26] apergos you will notice a big speed increase in your reviews if you use polygerrit. [20:54:50] sure is a lot cleaner and easier on the eyes [20:54:58] I'd have to click around a bunch to see about usability [20:55:57] apergos you can view all the diffs on one page [20:56:21] like differential, you can also write something in the reply dialog, refresh the page and wont lose the comment. [20:57:28] that's certainly handy [20:57:53] Yep, also handles large diffs better [20:57:58] has a show more button. [20:58:14] ah that's what I was going to ask [20:58:33] if you can have them all on one page, that could be unwieldy for large diffs [20:59:30] yeh, they improved large diffs recently, and testing on apergos https://gerrit-review.googlesource.com/?polygerrit=1#/c/gerrit/+/116790/ confirms it is faster [21:00:31] it is totally rewritten and based in javascript + polymer (html) [21:00:53] so this isen't java compiling polygerrit into java, so more users can contribute changes if they want :). [21:06:27] * Platonides was reading "testing on apergos" and wondering if they had a machine with the same name as one of our engineers xD [21:06:47] (03PS1) 10Sbisson: Tentatively re-enable ORES filters on RecentChangesLinked [extensions/ORES] - 10https://gerrit.wikimedia.org/r/403479 (https://phabricator.wikimedia.org/T179718) [21:07:11] no [21:07:31] they used to have one with my name and it was oh so annoying (not irc nick, actual name) [21:07:40] hehe [21:16:56] apergos: im going to name one of my servers your irc nick now just because you said that jk :D [21:18:14] you do what you want on your servers, long as I never have to touch em [21:19:17] apergos: you probably rather touch mine, its only 2 servers one running mw 1.30 and one running phab [21:23:58] it's all you [23:15:36] awight hi [23:16:24] I will let you know when I see awight and I will deliver that message to them [23:16:24] @notify awight hi, wondering if you could review https://gerrit.wikimedia.org/r/#/c/402665/ please (+1 or -1). We can re evauate using the library in gerrit 2.15 where the id is added. See https://groups.google.com/forum/#!topic/repo-discuss/UX1GXbGkbXk [23:16:25] 04Error: Command “notify” not recognized. Please review and correct what you’ve written.