[11:38:31] 10Scoring-platform-team, 10Collaboration-Community-Engagement, 10MediaWiki-extensions-ORES, 10Patch-For-Review, 10User-notice-collaboration: Deploy ORES filters to Simple Wikipedia - https://phabricator.wikimedia.org/T182012#3983023 (10Ladsgroup) It's completely unblocked on the scoring platform team sid... [11:39:13] ^ [11:39:45] :D almost done! [12:41:37] Good morning :) [12:43:09] https://gerrit.wikimedia.org/r/#/c/408935/ this is blocked on review :D [12:44:23] (03PS2) 10Ladsgroup: Add tests for PopulatedSqlModelLookup [extensions/ORES] - 10https://gerrit.wikimedia.org/r/408935 [14:18:19] (03PS1) 10Ladsgroup: Rewrite RecentChangeSaveHookHandler, part I [extensions/ORES] - 10https://gerrit.wikimedia.org/r/412708 (https://phabricator.wikimedia.org/T181335) [14:25:58] 10Scoring-platform-team (Current), 10editquality-modeling, 10User-Ladsgroup, 10User-Tgr, 10artificial-intelligence: Train/test damaging and goodfaith model for Hungarian Wikipedia - https://phabricator.wikimedia.org/T185903#3983604 (10Ladsgroup) Some comments >>! In T185903#3981268, @Tgr wrote: > * [[htt... [14:27:25] (03CR) 10Ladsgroup: "I want to emphasize it's a refactoring so I didn't touch tests. I will add way more tests in the next step." [extensions/ORES] - 10https://gerrit.wikimedia.org/r/412708 (https://phabricator.wikimedia.org/T181335) (owner: 10Ladsgroup) [15:08:53] 10Scoring-platform-team (Current), 10User-Ladsgroup: Train/test damaging/goodfaith model for Catalan Wikipedia - https://phabricator.wikimedia.org/T187732#3983664 (10Ladsgroup) [15:47:59] 10Scoring-platform-team (Current), 10editquality-modeling, 10User-Ladsgroup, 10artificial-intelligence: Train/test reverted model for Catalan Wikipedia - https://phabricator.wikimedia.org/T182611#3983813 (10Ladsgroup) That's so cool: http://labels.wmflabs.org/stats/cawiki/46 [15:56:26] 10Scoring-platform-team (Current), 10MediaWiki-extensions-ORES, 10ORES, 10MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), and 4 others: Special:RecentChanges broken on Jenkins slaves - https://phabricator.wikimedia.org/T184938#3983826 (10zeljkofilipin) @Ladsgroup this is resolved, right? Is... [16:13:48] 10Scoring-platform-team (Current), 10MediaWiki-extensions-ORES, 10ORES, 10MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), and 4 others: Special:RecentChanges broken on Jenkins slaves - https://phabricator.wikimedia.org/T184938#3983847 (10Ladsgroup) 05Open>03Resolved yup [16:19:11] Amir1: o/ Nice to have you back! [16:19:58] awight: o/ [16:20:03] Thanks [16:20:11] Amir1: I made something for you. [16:20:11] https://github.com/adamwight/mw-ext-JADE/pulls [16:20:13] :D [16:20:59] Cool :P Will take a look ASAP [16:22:36] lmk if I can look at anything for you, of course [16:30:25] awight: sure thing :P https://gerrit.wikimedia.org/r/#/c/408935/ and https://gerrit.wikimedia.org/r/#/c/412708/ [16:34:18] (03CR) 10Awight: [C: 032] Add tests for PopulatedSqlModelLookup (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/408935 (owner: 10Ladsgroup) [16:37:13] (03Merged) 10jenkins-bot: Add tests for PopulatedSqlModelLookup [extensions/ORES] - 10https://gerrit.wikimedia.org/r/408935 (owner: 10Ladsgroup) [16:38:10] (03CR) 10jenkins-bot: Add tests for PopulatedSqlModelLookup [extensions/ORES] - 10https://gerrit.wikimedia.org/r/408935 (owner: 10Ladsgroup) [16:48:06] Amir1: I don’t see how the RecentChangeSaveHookHandler patch is a recfactor, it seems to be adding new functionality? [16:49:07] $wgOresExcludeBots and $wgOresEnabledNamespaces can be overridden in $wgOresModels config, and it doesn’t look like this was the case previously? [16:49:19] Not a blocker, I just want to understand. [16:51:18] awight: yes, it is adding new functionality but at this stage it should not break any past bahviour [16:51:29] kk that works for me [16:52:05] the comment "$wgOresExcludeBots and $wgOresEnabledNamespaces can be overridden in $wgOresModels config, and it doesn’t look like this was the case previously" is completely accurate [16:52:41] I see that our tests demonstrate that the past behavior still works. [16:52:44] (03CR) 10Ladsgroup: Add tests for PopulatedSqlModelLookup (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/408935 (owner: 10Ladsgroup) [16:53:56] (03CR) 10Awight: [C: 032] Rewrite RecentChangeSaveHookHandler, part I [extensions/ORES] - 10https://gerrit.wikimedia.org/r/412708 (https://phabricator.wikimedia.org/T181335) (owner: 10Ladsgroup) [16:55:08] Thank you awight :) [17:01:36] awight: The PRs have lots of duplicate things :( [17:01:44] e.g. composer.json [17:02:07] Amir1: I don’t think so—the problem is how github stacks PRs on top of one another. [17:02:43] Each should have been a diff between the previous branch and new work, instead I think I made the PRs between master and the feature branch. [17:03:00] I see [17:03:22] I was concerned that if I make a PR to merge from new to previous feature branch, then they can only be merged in reverse order (newest to oldest). [17:03:44] AFAIK, as the first PRs get merged, the diffs will clear up... [17:03:51] Yeah [17:04:01] lemme respond to PR#1 to make that less messy [17:04:27] :) [17:12:20] awight: this thing allows me to deprecate draftquality ns config and things like that [17:12:31] I really hated that global variable [17:12:56] (03Merged) 10jenkins-bot: Rewrite RecentChangeSaveHookHandler, part I [extensions/ORES] - 10https://gerrit.wikimedia.org/r/412708 (https://phabricator.wikimedia.org/T181335) (owner: 10Ladsgroup) [17:13:13] It’s a great improvement, and nicely spliced! [17:13:47] btw, I donno your musical tastes but I just ran across this and it’s awesome. https://secretthirteen.org/s13-burning-the-existence/ [17:14:10] We need to start working on the offsite mix tape :) [17:15:37] (03CR) 10jenkins-bot: Rewrite RecentChangeSaveHookHandler, part I [extensions/ORES] - 10https://gerrit.wikimedia.org/r/412708 (https://phabricator.wikimedia.org/T181335) (owner: 10Ladsgroup) [17:23:37] awight: what were your thoughts regarding packaging word2vec as a debian package? where would we keep the package? [17:24:33] codezee: It still seems reasonable to me, especially because that data will change so slowly, if ever. [17:24:48] WMF keeps forked packaging here, https://gerrit.wikimedia.org/r/#/admin/projects/?filter=operations%252Fdebs [17:25:26] awight: so is that like debian packages for wmf local use, right? [17:26:07] exactly. [17:26:35] I’d love to make the package available publicly, but my limited experience in upstreaming things to Debian is that it’s a big /dev/null. [17:26:50] awight: so given we package it, i suppose when installing it, it would extract it to a predefined directory say ~/.word2vec like nltk, isn't it? [17:27:05] and the path should be configurable in the repo [17:27:17] I don’t think that can be done. I had a simpler plan [17:27:26] awight: like? [17:27:56] The word2vec glue module that we include in revscoring will have a built-in search path, probably /usr/lib/word2vec and ~/word2vec [17:28:05] but ultimately is configurable at runtime. [17:28:15] The .deb can only install to a predetermined location [17:28:27] I imagined that would be /usr/lib/word2vec [17:28:59] 10Scoring-platform-team (Current), 10MediaWiki-extensions-ORES, 10Regression: ORES extension highlights edits that are patrolled - https://phabricator.wikimedia.org/T187337#3983935 (10Ladsgroup) For example: https://fa.wikipedia.org/w/index.php?damaging=maybebad%3Bverylikelybad&hidebots=1&hidepatrolled=1&hid... [17:29:26] awight: yeah the glue module can be made to search these paths but i don't understand how it can have a runtime configurable path, the most that we could get is probably specifying paths in feature files like in wikiclass [17:29:50] awight: sth like - https://github.com/wiki-ai/revscoring/pull/391/files#diff-5dc86942f27ae21c6162ff5946558a1eR20 [17:30:01] It sounds like I’m missing what makes the configuration challenging [17:31:08] awight: from what i know of the pipeline, we cannot pass values to scripts in the pipeline, just some training parameters that tune accepts [17:31:27] We’ll be creating Dependency objects, right? [17:31:43] I’m pretty hazy on this part of our code. [17:31:45] awight: yeah, the above example shows a word_vectors dependency object [17:31:52] Cool [17:32:08] So, we also use mwapi in some dependencies. The configuration pattern would be the same [17:32:33] ok we can discuss in the backlog [17:33:03] awight: isn't today supposed to be a holiday? [17:33:05] sorry that I currently don’t understand well enough… but the existence of the mwapi dependencies makes me pretty confident that it’s possible. [17:33:09] :) [17:33:11] for sure [17:33:15] yeah i'll look [17:33:26] I’m just doing some other stuff at an Internet cafe for a bit. [17:33:43] ohh... [17:37:31] 10Scoring-platform-team (Current), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-ORES, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), and 4 others: Selenium tests for ORES - https://phabricator.wikimedia.org/T184451#3983940 (10zeljkofilipin) The first test is merged. Are there plans f... [17:45:14] o/! [18:59:16] 10Scoring-platform-team (Current), 10editquality-modeling, 10User-Ladsgroup, 10artificial-intelligence: I broke merge_labels utility so bad - https://phabricator.wikimedia.org/T187742#3984095 (10Ladsgroup) [19:07:14] 10Scoring-platform-team (Current), 10editquality-modeling, 10User-Ladsgroup, 10artificial-intelligence: Train/test reverted model for Catalan Wikipedia - https://phabricator.wikimedia.org/T182611#3984113 (10Ladsgroup) This is an "edit type" campaign and not an "edit quality" one so making damaging/goodfait... [19:28:14] 10Scoring-platform-team (Current), 10editquality-modeling, 10User-Ladsgroup, 10artificial-intelligence: I broke merge_labels utility so bad - https://phabricator.wikimedia.org/T187742#3984166 (10Ladsgroup) First fix: https://github.com/wiki-ai/editquality/pull/130 [19:32:24] wiki-ai/editquality#123 (fix_merge_labels_part_i - 4bfd054 : Amir Sarabadani): The build passed. https://travis-ci.org/wiki-ai/editquality/builds/343516166 [19:41:35] 10Scoring-platform-team (Current), 10editquality-modeling, 10User-Ladsgroup, 10artificial-intelligence: Train/test reverted model for Catalan Wikipedia - https://phabricator.wikimedia.org/T182611#3984197 (10Townie) Is there anything we can do with the edit type campaign, or should we start an edit quality... [20:11:51] 10Scoring-platform-team (Current), 10Wikilabels, 10User-Ladsgroup: Edit quality campaign for Serbian Wikipedia - https://phabricator.wikimedia.org/T178108#3984233 (10Zoranzoki21) When this will be enabled? [21:45:24] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/412784 (owner: 10L10n-bot) [22:32:51] 10Scoring-platform-team, 10Bad-Words-Detection-System, 10revscoring, 10artificial-intelligence: Update Hungarian language assets - https://phabricator.wikimedia.org/T187753#3984455 (10Tgr) [22:33:01] 10Scoring-platform-team, 10Bad-Words-Detection-System, 10revscoring, 10artificial-intelligence: Update Hungarian language assets - https://phabricator.wikimedia.org/T187753#3984466 (10Tgr) a:03Tgr