[08:07:13] 10Scoring-platform-team (Current), 10ORES-Support-Checklist, 10User-Ladsgroup: Build ORES support checklist - https://phabricator.wikimedia.org/T189954#4115841 (10Ladsgroup) [08:51:01] 10Scoring-platform-team, 10ORES-Support-Checklist: Support for languages in ores-support-checklist - https://phabricator.wikimedia.org/T191768#4115948 (10Ladsgroup) [08:54:40] 10Scoring-platform-team, 10ORES-Support-Checklist: Cleanup the code for ores-support-checklist - https://phabricator.wikimedia.org/T191769#4115961 (10Ladsgroup) [13:33:36] o/ [13:38:54] Hi halfak [13:39:25] Hey Vermont. Has winter released the east coast from its icy grip yet? [13:39:55] Not fully, and I hope it never does. [13:40:15] Oh really? I'm ready for some warmer weather :) [13:40:41] We got a fresh couple inches of snow yesterday. :( [13:41:04] :) [13:44:28] God bless winter [13:44:37] I hate hot weather [13:44:41] ^^ same [13:46:19] halfak: o/ [13:46:31] o/ codezee [13:46:54] Sorry I'm behind on writing for the draft topic paper. I plan to make that up today and tomorrow. [13:47:28] halfak: np [13:48:01] halfak: just let me know when you're done, I'll add it to the paper, and get it reviewed by you [13:49:07] halfak: I'm sort of forgetting the discussion from the last last meeting but in edittypes I saw datasources.diff being used but nowhere beingdefined [13:49:23] and no datasources repo exists on pypi [13:50:11] did you look at diyi's code? [13:50:16] diyi's code worked [13:50:21] the old edittypes repo did now [13:50:23] *not [13:50:55] halfak: yes I have that repo also and I did "grep -rn added_segments_context" all mentions were uses of it [13:51:09] Damn. [13:51:13] there were only 3 mentions for that matter [13:51:39] So diyi gave us non-functional code. I'll get you CC'd on a thread so you can ask her about it. [13:52:51] halfak: yeah, I can directly ask her about the issue, that should be fine :) [13:53:52] Just sent the email. You should have a CC'd email shortly. [13:54:51] I was writing a feature definition for each of the features, but seeing so many of them, I'll cook up a vim macro ^_^ [13:58:29] codezee, if worst comes to worst, we can re-implement added_segments_with_context. [13:58:39] I know roughly what that ought to look like. [14:23:37] ok, no problem [14:27:32] 10Scoring-platform-team (Current), 10ORES-Support-Checklist, 10User-Ladsgroup: Highlight wikis that has their campaign almost completed - https://phabricator.wikimedia.org/T191435#4116881 (10Ladsgroup) [14:29:49] AFK for a bit. See ya'll at the sync [14:35:28] 10Scoring-platform-team, 10ORES, 10articlequality-modeling, 10artificial-intelligence: Rename "wikiclass" to "articlequality" - https://phabricator.wikimedia.org/T181820#3803377 (10Ladsgroup) I moved the repo in github from wikiclass to https://github.com/wiki-ai/articlequality [14:37:35] 10Scoring-platform-team, 10ORES, 10Patch-For-Review, 10User-Ladsgroup: Issues with ORES model on plwiki - https://phabricator.wikimedia.org/T179621#4116925 (10Ladsgroup) 05Open>03Resolved a:03Ladsgroup It should be resolved by now, ores_classification doesn't store anything after one month, the versi... [14:40:28] 10Scoring-platform-team, 10ORES, 10Patch-For-Review: Specter of revscoring 1 haunting ORES - https://phabricator.wikimedia.org/T179874#3739027 (10Ladsgroup) Is this still relevant? All patches are merged here. [15:42:44] 10Scoring-platform-team (Current), 10ChangeProp, 10ORES, 10Patch-For-Review: Drop "non bot" condition from ORES changeprop rules - https://phabricator.wikimedia.org/T187927#4117284 (10Halfak) We discussed this in sync meeting and confirmed that we want to move forward with it -- given very careful monitori... [15:47:10] 10Scoring-platform-team (Current), 10Wikidata, 10User-Ladsgroup: Run analysis of revert time and number changes over time for wikidata - https://phabricator.wikimedia.org/T189962#4117311 (10Halfak) We discussed getting the plots cleaned up and adding English/Spanish Wikipedia at our sync meeting. [15:50:33] 10Scoring-platform-team (Current), 10editquality-modeling, 10User-Ladsgroup, 10User-Tgr, 10artificial-intelligence: Train/test damaging and goodfaith model for Hungarian Wikipedia - https://phabricator.wikimedia.org/T185903#4117322 (10awight) @Tgr Hi! We finally have a way forward, but I wanted to menti... [15:51:07] 10Scoring-platform-team (Current), 10articlequality-modeling, 10User-Ladsgroup, 10artificial-intelligence: Train and test wp10 model for fawiki - https://phabricator.wikimedia.org/T190050#4117323 (10Halfak) @Ladsgroup will be working on a merge_labels utility for wp10/wikilabels. [15:52:35] 10Scoring-platform-team (Current), 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10User-Ladsgroup: Fix the ORES-extension grafana dashboard - https://phabricator.wikimedia.org/T191808#4117324 (10Halfak) [16:03:12] halfak: no pressure [16:03:16] we’re socializing tho [16:18:59] awight: hi! can you clarify what I need to do for the huwiki patch? [16:19:25] tgr: yes! Sorry, gimme 10 minutes and I can help [16:19:27] just rebase? or do you want me to turn it into a branch in the main repo? [16:31:22] So, I rebased and built the models in order to validate that the new merge strategy doesn’t damage model health, https://github.com/wiki-ai/editquality/tree/awight-huwiki [16:31:48] Generally, it’s easiest to collaborate with a branch on the main repo, cos then other contributors can modify the patches [16:32:08] but in this case, either way is fine [16:33:20] If you want to finish this thing up, I guess the ideal would be: rebase huwiki work onto master, using #awight-huwiki as a reference, then rebuild the models on stat* or ores-misc-01 and push to a new branch in the shared wiki-ai repo [16:33:35] Then I think it’ll be a quick merge. [16:35:21] thanks, will do [16:59:44] 10Scoring-platform-team (Current), 10MediaWiki-extensions-ORES, 10User-Ladsgroup: Scream properly when threshold stats fetch is failing - https://phabricator.wikimedia.org/T180587#4117645 (10Ladsgroup) a:03Ladsgroup I added an alert to scream when unsuccessful service hits passes a threshold [17:13:52] halfak: I've updated the edittypes PR with full set of features and datasources.diff except word2vec similarity( which I'll address in a followup) [17:14:18] I noticed that tests are not passing for datasources.diff. I'll spend some time to debug those otherwise write to diyi [17:18:59] OK sounds good. Nice work! [17:38:55] 10Scoring-platform-team, 10Scap, 10Patch-For-Review: [Blocked] Support git-lfs - https://phabricator.wikimedia.org/T180627#4117789 (10awight) Here's the current scap error from beta cluster deployment: ``` cd /srv/deployment/ores/deploy git fetch # This branch has a git-lfs submodule, in "submodules/assets"... [17:39:49] 10Scoring-platform-team, 10Scap, 10Patch-For-Review: [Blocked] Support git-lfs - https://phabricator.wikimedia.org/T180627#4117797 (10awight) @mmodell I'm still stuck, see the previous comment. Maybe it has to do with URL rewriting? [17:40:40] 10Scoring-platform-team, 10Scap, 10Patch-For-Review: [Blocked] Support git-lfs - https://phabricator.wikimedia.org/T180627#4117799 (10mmodell) @awight: thanks, I haven't had much chance to work on this due to the train taking up most of my time these past two weeks. I'm not deploying the train this week so I... [17:42:57] srrodlund: Hi, I’m hoping to deploy some work today, but our window is at the same time as the docs meeting. Maybe we can reschedule? [17:43:48] awight: wfm [17:43:55] just let me know the tim [17:44:05] time (later this week is fine) [17:45:39] Thanks—I moved it to the same time tomorrow, if that’s okay? [17:46:21] It’d be nice to move the recurring time too, since this is a conflict pretty often. [17:51:48] Saw ^ on the calendar [17:51:49] +1 [17:52:02] I'm running away to shovel and get lunch [17:52:04] back soon [17:53:22] (03PS5) 10Awight: Try to switch to the dsh host manifest [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/423752 (https://phabricator.wikimedia.org/T191321) [17:53:31] (03CR) 10Awight: Try to switch to the dsh host manifest (031 comment) [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/423752 (https://phabricator.wikimedia.org/T191321) (owner: 10Awight) [18:12:57] (03PS1) 10Awight: Fewer deployed revisions cached on beta [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/425107 [18:34:37] 10Scoring-platform-team (Current), 10MediaWiki-extensions-ORES, 10MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), 10Patch-For-Review, 10User-Ladsgroup: Redesign onRecentChange_save hook handler for ORES - https://phabricator.wikimedia.org/T181335#3786633 (10awight) Looks like we can mark t... [18:49:06] 10Scoring-platform-team (Current), 10Operations, 10Patch-For-Review, 10Release-Engineering-Team (Watching / External), 10Wikimedia-Incident: Cache ORES virtualenv within versioned source - https://phabricator.wikimedia.org/T181071#4117967 (10awight) As mentioned in my [[ https://phabricator.wikimedia.org... [19:05:32] Woops [19:05:38] I always forget that part [19:12:03] 10Scoring-platform-team, 10ORES, 10articlequality-modeling, 10artificial-intelligence: Rename "wikiclass" to "articlequality" - https://phabricator.wikimedia.org/T181820#4118037 (10Halfak) Eek! It's gonna need a lot more changes too. I suppose this is a good start. We should do them all together. Want... [19:12:42] Amir1, ^ ? [19:13:01] 10Scoring-platform-team, 10Scap, 10Patch-For-Review: [Blocked] Support git-lfs - https://phabricator.wikimedia.org/T180627#4118039 (10mmodell) >>! In T180627#4117797, @awight wrote: > @mmodell I'm still stuck, see the previous comment. Maybe it has to do with URL rewriting? Indeed that seems like it might... [19:13:24] 10Scoring-platform-team, 10Scap, 10Patch-For-Review, 10Release-Engineering-Team (Kanban): [Blocked] Support git-lfs - https://phabricator.wikimedia.org/T180627#4118041 (10mmodell) a:03mmodell [19:13:36] <3 awight ^ [19:13:42] (03PS1) 10Awight: Build venv into deployed source dir (take 3) [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/425114 (https://phabricator.wikimedia.org/T181071) [19:13:46] hehe [19:14:42] Love seeing progress there. Feels like our blockers for draft topic have been festering. [19:14:56] (03PS1) 10Awight: [DNM] Remove transitional virtualenv copy [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/425115 (https://phabricator.wikimedia.org/T181071) [19:15:02] Also, I want to upvote the commons picture of the day today :) https://commons.wikimedia.org/wiki/File:Pepe_Lopez_Peugeot_208_T16_(3).jpg [19:15:13] !!! [19:16:37] The only flying car company delivering on promises [19:17:25] lol [19:17:27] https://www.mediawiki.org/wiki/ORES/Draft_topic [19:17:36] Just making that so I can write some essays on the talk page. [19:18:36] right on. I like the idea of per-model docs, hopefully we find time to flesh them out [19:21:19] I think it'll be important to document the "meaning", usage, and high-level process for developing them. For now, a couple sentences is better than nothing :) [19:27:01] http://openaccess.city.ac.uk/12412/1/aupair-camera-ready.pdf [19:27:53] tl;dr, users’ self-efficacy may increase if they (at least think they) understand how our models work… [19:28:28] :) [19:31:03] halfak: If you have a minute, https://gerrit.wikimedia.org/r/#/c/425114/1/scap/scripts/fetch_check.sh lines 19-23 were added to an already-reviewed patch [19:31:36] so if you could sanity check the new bits, we can merge and try the deployment again. [19:31:44] starting with beta… [19:32:12] What's the putpose of installing things in the old path? [19:32:53] * halfak is probably out of a loop [19:33:22] It’s cos there are two patches to deploy, and the other is in the puppet repo: [19:33:53] https://gerrit.wikimedia.org/r/#/c/392683/ [19:34:40] Sorry. Still confused. [19:35:07] Oh! [19:35:08] I see. [19:35:08] In order to deploy those two patches as a safe migration, we need to support both the old and new calling paradigms [19:35:12] :) [19:35:13] Gotcha. [19:35:26] it turned out to be harder than I thought. [19:35:32] I don't understand what is going on with "[ -f $deploy_dir/submodules/wheels/pip-*.whl ]" [19:35:51] Apparently, leaving the old virtualenv intact wasn’t safe enough, we need to rebuild it for the new code location on disk [19:36:04] The -f is to check whether a file exists [19:36:17] pip-* are upgrades to the pip module itself [19:36:24] But what is this weird bracket syntax? [19:37:02] It’s an alias to the “test” shell command [19:37:04] Oh! does it implement a conditional? [19:37:09] I see! [19:37:21] * awight is nervous about searching the Internet for “man test" [19:37:22] https://linux.die.net/man/1/test [19:37:32] lol [19:37:35] phew! [19:38:02] it’s a bunch of bullshit btw [19:38:12] I think we can drop it now that debian-stretch includes pip-9 [19:38:31] OK this LGTM [19:38:40] I'm looking at the rest of https://gerrit.wikimedia.org/r/#/c/425114/ now [19:39:01] there was a large version jump from jessie, I think pip-1.x, and for some reason I became convinced that pip had to be upgraded before our the rest of our new wheels would be usable [19:39:11] +1 ty [19:39:35] the new “type: script” shortcut in scap is the bee’s knees [19:40:30] https://doc.wikimedia.org/mw-tools-scap/scap3/checks.html?highlight=checks#script-checks [19:40:51] https://doc.wikimedia.org/mw-tools-scap/scap3/checks.html#script-checks [19:40:52] I was really sad when I learned that the bees knees has nothing to with insects. [19:40:53] https://en.wiktionary.org/wiki/the_bee%27s_knees [19:41:54] weird, my understanding of the denotation is missing from wiktionary [19:42:00] is it not also “the business”? [19:42:36] occam’s razor dictates that the most mundane ^ explanation must be the correct one [19:42:43] Also, and unrelated, someone wants to make a bot for helping out with assessments of Art-related articles. [19:42:45] "ArtAssBot" [19:42:49] Well then. [19:42:57] I'm too much like 13 yo me. [19:43:21] awight, I wanted the bees to have knees :( [19:43:48] They do and find their knees very useful, afaik! [19:44:02] hairy food traps [19:44:15] bees are all about the beard [19:45:14] awight, 425114 looks good. [19:45:26] (03CR) 10Halfak: [C: 032] "This LGTM." [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/425114 (https://phabricator.wikimedia.org/T181071) (owner: 10Awight) [19:45:34] :D [19:49:00] Thanks for reading through it. I’ll start with beta [19:52:45] (03CR) 10Halfak: [C: 032] Fewer deployed revisions cached on beta [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/425107 (owner: 10Awight) [19:53:58] lol AsimovBot is alive and well [20:03:51] (03CR) 10Awight: [V: 032] Fewer deployed revisions cached on beta [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/425107 (owner: 10Awight) [20:05:05] Beta checks out, so I’ll go ahead with production. [20:05:35] (03CR) 10Awight: [V: 032] Build venv into deployed source dir (take 3) [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/425114 (https://phabricator.wikimedia.org/T181071) (owner: 10Awight) [20:08:56] godspeed [20:08:59] (03PS6) 10Awight: Try to switch to the dsh host manifest [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/423752 (https://phabricator.wikimedia.org/T191321) [20:09:16] halfak: Shall we go ahead with https://gerrit.wikimedia.org/r/#/c/423752/ ? [20:09:19] it’s our call... [20:13:03] We need it, in fact. I’m self-merging for now. [20:13:44] kk [20:13:52] (03CR) 10Awight: [V: 032 C: 032] "Deploying this to test." [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/423752 (https://phabricator.wikimedia.org/T191321) (owner: 10Awight) [20:14:08] (03CR) 10Awight: [V: 032 C: 032] Try to switch to the dsh host manifest [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/423752 (https://phabricator.wikimedia.org/T191321) (owner: 10Awight) [20:14:47] Looks good so far. [20:19:00] 10Scoring-platform-team (Current), 10Operations, 10Patch-For-Review: Remove deprecated hosts from ORES scap config - https://phabricator.wikimedia.org/T191321#4118391 (10awight) This worked. [20:28:31] 10Scoring-platform-team, 10Operations, 10Release-Engineering-Team, 10Scap: Deployment git server can't supply ORES hosts in parallel - https://phabricator.wikimedia.org/T191842#4118429 (10awight) [20:41:59] I’m feeling 100% about my last-minute decision to do this deployment the safe way :) [20:42:17] Something’s wrong with the new virtualenvs, but the service isn’t impacted. [20:49:30] 10Scoring-platform-team (Current), 10Operations, 10Patch-For-Review, 10Release-Engineering-Team (Watching / External), 10Wikimedia-Incident: Cache ORES virtualenv within versioned source - https://phabricator.wikimedia.org/T181071#4118493 (10awight) Update: I deployed as a safe migration, and the new vir... [21:41:13] 10Scoring-platform-team (Current), 10MediaWiki-extensions-ORES, 10MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), 10Patch-For-Review, 10User-Ladsgroup: Redesign onRecentChange_save hook handler for ORES - https://phabricator.wikimedia.org/T181335#4118654 (10Ladsgroup) This has been deploye... [21:46:43] 10Scoring-platform-team (Current), 10Operations, 10Patch-For-Review, 10Release-Engineering-Team (Watching / External), 10Wikimedia-Incident: Cache ORES virtualenv within versioned source - https://phabricator.wikimedia.org/T181071#4118685 (10awight) I can't tell whether the fetch check script is failing,... [21:48:47] https://www.mediawiki.org/wiki/Topic:Uayybx6wk790yc3m [21:48:54] OK and with that, I'm calling it a day. [21:49:10] awight, anything I should look at before I go? [21:49:27] My stuff can wait. o/! [21:49:54] OK have a good evening :)( [21:49:57] *:) [21:49:58] looks fun btw [21:50:05] &-$ [21:50:11] heh. Somehow was very hard to write today :| [21:54:41] The parallel between normals edits and new article creation is a great way to make the argument! [21:55:29] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/425164 (owner: 10L10n-bot) [22:46:06] 10Scoring-platform-team (Current), 10ORES, 10Patch-For-Review: Specter of revscoring 1 haunting ORES - https://phabricator.wikimedia.org/T179874#4118879 (10awight) 05Open>03Resolved a:03awight [23:03:58] 10Scoring-platform-team (Current), 10Operations, 10Patch-For-Review, 10Release-Engineering-Team (Watching / External), 10Wikimedia-Incident: Cache ORES virtualenv within versioned source - https://phabricator.wikimedia.org/T181071#4118918 (10awight) Do we have to install the `python3-setuptools` package?... [23:15:18] Argh, I’m ready to drop virtualenv entirely [23:48:27] 10Scoring-platform-team, 10ORES: mwparserfromhell ParserError on Premier League - https://phabricator.wikimedia.org/T191861#4118999 (10Platonides)