[09:44:19] akosiaris: hey, I will send you lots of questions soon. I just woke up. [09:44:32] Let me get to the office [09:45:24] Amir1: sure thing, take your time, no rush [10:57:13] akosiaris: hey, just got to the office [10:57:19] first of all, happy Friday [10:57:46] second: I'm working on pool counter support [10:58:33] I already reached to a point that it works locally and slows down requests and sends time out after a while [10:58:50] joe said we should spin up a new pool counter node, do you think we should do it? [10:59:10] I think so too but is it VM, bare metal? [11:02:40] Amir1: it is going to be a VM (the mediawiki ones are already), but does this really matter to you ? [11:03:07] what's more important would be to have support for multiple instances (mediawiki does) [11:03:33] so that in case instance A goes down for whatever reason, ORES will keeping using instance B and not die horribly [11:03:44] akosiaris: basically because if it takes really long time or not [11:03:54] I guess real hardware is harder [11:04:21] yeah it's going to be VM and should be < 30 mins to create it [11:04:55] akosiaris: hmm, the code just ignores if it can't connect [11:05:13] I know it's not good but I wanted to start with this first [11:05:56] yeah from what I gather it's still a WIP, which is why I pointed that out now and not later on when it would be harder to change [11:06:34] okay noted, I will work on it [11:06:59] do you have like an idea of when you 'd want to deploy the support for poolcounter ? [11:07:13] so that I prioritize getting the VM and all ready [11:07:36] I guess next week I will start working on it labs setup and beta cluster [11:07:52] the week after next is the most likely case [11:08:07] or end of the next week [11:10:50] ok cool [11:12:57] akosiaris: the other thing is about moving to k8s [11:13:45] it's not dockerized, what is the plans about that. How I can push this to move forward? [11:15:04] no need to dockerize anything. The plan is for everything to be build via the CI/CD pipeline [11:15:30] the "dockerizing" part is done by blubber, which has moved along quite a bit and how has some python support [11:15:31] blubber? [11:15:35] lemme give you the link [11:15:51] https://wikitech.wikimedia.org/wiki/Blubber [11:16:34] it's in charge of build the dockerfile, and the pipeline does the actual building of the container [11:16:57] I see, the only thing that needs to happen is making the blubber yaml file [11:17:25] yup [11:17:34] there are some possible complications specific to ORES [11:17:52] things like maybe creating different images for the web and the worker [11:17:56] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/436523 [11:18:02] (03CR) 10Hashar: "check experimental" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/436523 (owner: 10Hashar) [11:18:14] but even with a shared one it would be fine for starting with it [11:18:33] unfortunately we haven't managed to really schedule any k8s work this quarter due to the switchover and all [11:18:52] the idea is to do a big push next quarter however and move multiple services [11:19:38] Nice, I keep this on the radar until the next Q [11:20:50] keep in mind blubber is in a beta-ish state right now, things might change [11:20:59] okay, noted [11:21:04] another thing: https://gerrit.wikimedia.org/r/c/operations/puppet/+/454546 [11:21:42] I'm trying to make wikilabels more puppetized so I can throw away nodes and use another one [11:21:42] zlib1g-dev ? [11:21:54] that's header files, isn't it ? [11:21:56] without it, pyllibmc can't be installed [11:22:09] ah [11:22:47] and what installs pylibmc ? [11:22:58] I have no clue TBH [11:23:02] hahahahaha [11:23:08] :D [11:23:28] anyway, this is labs specific, I am fine with that [11:23:30] lemme merge it [11:23:31] the python dependency graphs can be sometimes, complicated [11:23:39] yeah [11:23:45] the only thing here is the database and OAuth credentials [11:24:02] I wish we had a private repo in labs as well [11:24:45] you kind of do. It's the per project hiera. IIRC it's only visible to the people belonging to the project [11:24:54] you set it in the horizon interface [11:25:09] it's not great ofc [11:25:40] aha, it used to be in wikitech [11:25:44] that's good to know [11:26:15] yeah it's the same thing. albeit a tad more structured in the interface [11:28:29] Still it's better than a public place :D [11:29:46] one last thing is about the ores setup in labs. It has been unloved for a while now So the precaching is completely broken and I don't want to bring it back online as I don't see any real use for that [11:30:06] the only fun thing here is that the ores in labs is being hit 200K times a day [11:30:26] Tracking down who is hitting us is not easy though [11:31:28] https://phabricator.wikimedia.org/T202655 [11:32:04] I downsized the project a little [11:34:17] heh [11:34:37] yeah the emit an error code telling them to reach you will probably work [11:49:23] akosiaris: Just to make sure: the multi-instance option for pool counter is just to have the second one as fallback and that's all? [11:49:32] Also it probably needs to be set up per dc [11:54:23] Amir1: that's up to you. It can be a fallback or you can distribute the locks if you want (you will have to do some consistent hashing though based on some key). Both approaches are fine cause they are locks, losing them means nothing. mediawiki does the latter btw [11:55:01] yes we are going to create 4 instances, 2 per dc (same way as mediawiki) [11:55:31] fwiw we could reuse the mediawiki instances (thumbor already uses them too) but it's probably more prudent to split them [11:55:53] okay. Noted [12:09:42] 10Scoring-platform-team (Current), 10ORES, 10Operations: Spin up a new poolcounter node for ores - https://phabricator.wikimedia.org/T201824 (10akosiaris) Yes, it does make sense indeed to not share the infrastructure with mediawiki. I 'll file a task for creating 4 VMs (2 poolcounter instances per DC) for this [12:36:01] wikimedia/wikilabels#408 (fix_form - 133a75b : Amir Sarabadani): The build passed. https://travis-ci.org/wikimedia/wikilabels/builds/420097972 [13:01:36] akosiaris: one other thing: https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/455157 :D [13:12:37] Amir1: that's the metapackage that would also bring the postgresql database server and install it [13:12:45] I am thinking this is not what you want [13:12:52] you only need to psql binary, right ? [13:13:15] change it to postgresql-client [13:16:36] akosiaris: yeah, let's do that [15:12:02] 10Scoring-platform-team, 10articlequality-modeling, 10artificial-intelligence: Turn article quality javascript into a gadget - https://phabricator.wikimedia.org/T202744 (10Ladsgroup) [15:13:42] 10Scoring-platform-team, 10articlequality-modeling, 10artificial-intelligence: Build a gadget to give list of quality of articles in categories - https://phabricator.wikimedia.org/T202745 (10Ladsgroup) [15:54:56] I go eat something, will be back soon [17:02:17] awight, Amir1, is there a public endpoint for the staging wikilabels? I know there are two wikilabels repos 1) for testing 2) for deployment. Aaron merged my PR into the non-deploy repo, so where might that be viewable. Is that the serve you gave me access to awight? [17:07:29] notconfusing: I just got back [17:07:34] we actually have three [17:07:53] labels-staging.wmflabs.org, labels-experiment.wmflabs.org, labels.wmflabs.org [17:08:04] in any of them you need to deploy [17:08:22] and fun fact, I just deployed all changes of wikilabels to production [17:09:18] you should rename labels.wmflabs.org to labels-nolabel.wmflabs.org :P [17:12:33] :))) [17:12:38] Thanks but no :D [17:33:55] Amir1, cool. So how would I load a data for labels-experiment.wmflabs.org ? ssh into wikilabels-01.wikilabels.eqiad.wmflabs ? [17:34:54] notconfusing: well, 1- I'm phasing out wikilabels-01, the traffic for prod is actually on wikilabels-02 2- you should not use prod, use staging wikilabels-staging.eqiad.wmflabs [17:35:13] ok [17:35:29] I'm going to drop the whole wikilabels-01 after making sure no one uses it for whatever reason [17:35:40] notconfusing: https://wikitech.wikimedia.org/wiki/Wikilabels [17:35:45] This might be useful [17:36:23] ok, great info. [17:37:59] this guides says to make a new labelling campaign, use wikilabels-02, but i should try it on wikilabels-experiment first, right? [17:39:25] notconfusing: yeah, or staging, they both point to the same database [17:39:44] I was too lazy to make experiment and staging separate databases [17:39:56] cool, thanks, I'll try this out today and hope i don't mess anything up [19:30:47] I'm around in case you have any questions, or need help for anything [19:42:13] 10Scoring-platform-team (Current), 10ORES: Migrate gadgets that use ores labs instance to prod - https://phabricator.wikimedia.org/T202630 (10Ladsgroup) Thank you all very much! [20:05:04] 10Scoring-platform-team, 10Wikilabels: Migrate wikilabels action=compare to support MCR - https://phabricator.wikimedia.org/T202767 (10Ladsgroup)