[00:03:48] Congrats! [00:12:19] (03PS1) 10Awight: [WIP] messing around, render wikitext [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464737 [00:12:23] out. [00:13:52] (03CR) 10jerkins-bot: [V: 04-1] [WIP] messing around, render wikitext [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464737 (owner: 10Awight) [00:16:13] (03CR) 10jerkins-bot: [V: 04-1] [WIP] messing around, render wikitext [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464737 (owner: 10Awight) [13:17:23] o/ very limited connection [13:41:06] wikimedia/ores#1035 (logstash - 33feeee : Amir Sarabadani): The build was fixed. https://travis-ci.org/wikimedia/ores/builds/437628514 [14:06:22] o/ [14:49:43] halfak: o/ I'm about ot finish making some changes that fixes the look up issue in celery but there is one thing that seems fishy to me: https://github.com/wikimedia/ores/blob/master/ores/scoring_systems/celery_queue.py#L152 [14:50:09] inprogress_results actually sends a dictionary of rev_id->model-> job [14:50:20] Right. [14:50:27] it's not the results of the job (doesn't have the .get()) on it [14:51:08] Wait. The "result" does have get() [14:51:26] and that function actually is not being used in the celery_queue class, it's being used directly in Scoring system [14:51:37] Right. [14:51:55] ScoringSystem has abstract support for inprogress results [14:52:06] And celery implements inprogress results. [14:52:33] Same with _register_model_set_revs_to_process [14:55:03] I think I got it now [14:55:12] let me check if I'm right or not [14:58:05] :) [15:02:17] 10Scoring-platform-team (Current), 10ORES, 10User-Ladsgroup: Upgrade to celery 4 in ORES - https://phabricator.wikimedia.org/T206332 (10Ladsgroup) [15:03:57] 10Scoring-platform-team (Current), 10ORES, 10User-Ladsgroup: Upgrade to celery 4 in ORES - https://phabricator.wikimedia.org/T206332 (10Ladsgroup) [15:04:02] 10Scoring-platform-team, 10ORES, 10Patch-For-Review: Upgrade celery to 4.1.0 for ORES - https://phabricator.wikimedia.org/T178441 (10Ladsgroup) [15:04:29] 10Scoring-platform-team (Current), 10ORES, 10User-Ladsgroup: Upgrade celery to 4.1.0 for ORES - https://phabricator.wikimedia.org/T178441 (10Ladsgroup) p:05Triage>03High a:05Halfak>03Ladsgroup [15:05:04] 10Scoring-platform-team (Current), 10ORES, 10User-Ladsgroup: Upgrade celery to 4.1.0 for ORES - https://phabricator.wikimedia.org/T178441 (10Ladsgroup) [15:05:07] 10Scoring-platform-team, 10ORES: Silence or address E_WOULDBLOCK warning - https://phabricator.wikimedia.org/T152012 (10Ladsgroup) [15:08:03] 10Scoring-platform-team (Current), 10ORES, 10User-Ladsgroup: Change default serializer of celery from pickle to json - https://phabricator.wikimedia.org/T206333 (10Ladsgroup) p:05Triage>03High [15:09:06] 10Scoring-platform-team (Current), 10ORES, 10User-Ladsgroup: Make ScoreReqeust json seriablizable - https://phabricator.wikimedia.org/T206334 (10Ladsgroup) p:05Triage>03High [15:16:21] 10Scoring-platform-team (Current), 10ORES, 10User-Ladsgroup: Silence or address E_WOULDBLOCK warning - https://phabricator.wikimedia.org/T152012 (10Ladsgroup) a:03Ladsgroup [15:36:32] I leave for the day, will work a little tomorrow [16:04:31] o/ Amir1 [16:04:37] Have a good night/weekend! [16:13:21] 10Scoring-platform-team, 10Wikilabels, 10articlequality-modeling, 10artificial-intelligence: Build article quality model for Galician Wikipedia - https://phabricator.wikimedia.org/T201146 (10Halfak) @Elisardojm, I think this is the last thing we'll need to do before we announce the campaigns to the Galicia... [16:49:48] This got extremely awkward. I'm rendering wikitext in the notes and comment fields. [16:50:25] worst patch *EVAR https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/JADE/+/464737/ [17:01:29] awight, does comment wikitext rendering happen in a similar way? [17:04:01] https://en.wikipedia.org/wiki/Wikipedia_talk:WikiProject_Women_in_Red#Proposal_for_a_spreadsheet_of_women's_biographies_that_were_declined_as_non-notable_in_the_AfC_submissions_process [17:05:34] halfak: I'm not sure what I'm looking at ^ there, is that related to the rendering question? [17:06:02] halfak: The judgment.notes and endorsement.comment will be rendered in the same way, if that's the question... [17:06:11] Oh no. That's unrelated. Just working on the Strickland issue and using it as a spring-board for adoption of the topic model. [17:06:19] oh nice [17:06:31] awight, was wondering about revision comments/summary. [17:06:34] On the history page. [17:06:45] ah I don't think there's any rendering. checking now. [17:07:38] Oh yeah. They get links and maybe bold/italic? [17:07:51] I get echo pings when someone links to me in an edit comment. [17:08:39] kk thanks for the pointer; cos rendering snippets has been unpleasant so far, I'm hoping I can clean up this code. [17:08:43] E.g. I got a ping for this: https://en.wikipedia.org/w/index.php?title=User:MWang_(WMF)/common.js&oldid=859376366 [17:23:38] On my local wiki, a [[local]] link is supported, but no external links, templates, bold, or italics [17:26:19] fyi here's the raw text of Nettrom's comment: "adding [[User:EpochFail|EpochFail]]'s awesome article quality gadget" [17:27:45] I'm surprised you got a ping. This didn't work for me, "test {{ping|EpochFail}}" [17:30:36] I don't see any parser functions that would have done that... Nettrom can you let us know what your original text was, that caused the ping ^ ? [17:30:55] We're trying to understand how the limited wikitext in comments works. [17:31:37] I wonder if it just runs a link-parser over the comment that's it. [17:34:15] awight: you're wondering what I wrote to pink halfak in that comment? [17:34:24] right [17:34:31] * halfak runs away for lunch. [17:34:37] If I don't get it now, I never will [17:35:17] fwiw it doesn't show up in "links here", https://en.wikipedia.org/w/index.php?title=Special%3AWhatLinksHere&limit=500&target=User%3AEpochFail&namespace=2 [17:35:36] Nettrom: yes exactly. Sorry to bother you with something so mundane :) [17:35:54] the exact raw text that awight posted was what I wrote in the comment field on-wiki. I don't see anything in the diff that suggests the content of the edit would ping halfak|Lunch [17:36:12] how weird! k thanks [17:36:51] FYI we're trying to support wikitext in the freeform fields of JADE judgments e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Judgment:Diff/376901 [17:36:56] no problem, sorry if that wasn't particularly helpful [17:38:01] it was! I would have spend some non-zero amount of time trying to find a parser function that doesn't exist, otherwise. [17:41:26] 10Scoring-platform-team (Current), 10JADE: Support wikitext in judgment notes and endorsement comment fields - https://phabricator.wikimedia.org/T206346 (10awight) [17:43:22] 10Scoring-platform-team (Current), 10JADE, 10SpamBlacklist, 10Patch-For-Review: SpamBlacklist integration for JADE - https://phabricator.wikimedia.org/T206255 (10awight) [17:43:24] 10Scoring-platform-team (Current), 10JADE: Support wikitext in judgment notes and endorsement comment fields - https://phabricator.wikimedia.org/T206346 (10awight) [18:03:19] harej: Oops, I was about to ping you in #wikimedia-dev [18:04:04] I think Extension:CollaborationKit had links and externalLinks detection inside of JSON snippets working already... looking at how that works now. [18:10:00] CK takes each bit that is known to be wikitext and runs it through the parser [18:16:46] hey, cool. I was leaning towards that approach, nice to hear that I can copypasta. [18:18:21] 10Scoring-platform-team (Current), 10JADE: Support wikitext in judgment notes and endorsement comment fields - https://phabricator.wikimedia.org/T206346 (10awight) Edit summaries are rendered by [[ https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/Linker.php$1088-1101 | Linker::formatCo... [18:18:48] o/ [18:18:51] halfak: ^ fyi, this is how an edit summary is rendered. [18:19:15] I'm leaning towards full wikitext at the moment, but we could also leave it configurable if you think there's a reason to KISS. [18:19:59] Na. I think targeting full wikitext is a fine idea. That way pagelinks and categorylinks can work. [18:20:08] Those are super useful for sorting. [18:20:11] Cool. Part of my motivation is also that external links integration gives us the SpamBlacklist hooks for free. [18:24:06] Is that part of AbuseFilter? [18:24:19] Or unrelated. [18:25:34] no [18:25:49] the external links hooks are not part of AbuseFilter [18:26:05] Gotcha. [18:28:55] https://www.mediawiki.org/wiki/Extension:SpamBlacklist [18:30:22] oh halfak, I will also be missing the staff meeting this coming week because I'll be at an offsite. [18:30:52] OK. Did you look over the notes I left for you? [18:31:06] I looked over the Etherpad, is that what you mean? [18:31:09] Right. [18:31:18] I did look that over. [18:31:23] Cool :) [18:31:29] I see you added your OOO for Monday :) [18:31:56] 10Scoring-platform-team, 10Discovery-Search, 10Elasticsearch, 10JADE: Extract judgment data for search indexing - https://phabricator.wikimedia.org/T206352 (10awight) [18:32:13] harej: ^ fun [18:32:25] i'll be on the queen mary, docked in long beach california [18:32:45] Sounds pretty cool. [18:32:51] Monday is a holiday eh [18:33:00] yes, indigenous people's day [18:33:06] Queen Mary is creepy as hell, I loved my visit [18:33:21] Gah! I need to change locations. Back online in ~30 mins. [18:33:45] I got caught up looking into what it would take to make changes to the wikiProject directory. [18:33:59] which one ;) [18:34:23] haha [18:34:45] Any of them. :) I want a version that is easy to edit and maybe less easy to view. [18:35:04] So that we can make edits easily. And maybe have a bot make a nice-to-view version. [18:35:49] There's https://en.wikipedia.org/wiki/WP:WikiProject_Directory which is bot-updated [18:35:54] and includes ~metrics~ [18:41:10] 10Scoring-platform-team, 10Discovery-Search, 10Elasticsearch, 10JADE: Extract judgment data for search indexing - https://phabricator.wikimedia.org/T206352 (10EBernhardson) This will allow indexing the data, using that data for something depends on the use case. The most direct method is to implement a ful... [18:58:29] harej: ^ thanks for the link! [19:16:56] harej: -v this is getting fun, donno if you're tracking. [19:17:13] if it's IRC spam I don't see it [19:17:52] haha that's right. Actually it never posted. [19:18:02] T205921 [19:18:03] T205921: Content model version field to accompany content model - https://phabricator.wikimedia.org/T205921 [19:18:08] (has no scoring tags) [19:21:41] awight: I'm assuming that the migration timeline you set out is for worst case scenarios where we *have* to do a migration? [19:22:00] harej: I know you have these muted, but do you know of other project tags that might get added by "outsiders" who wouldn't know to add scoring-platform-team? https://gerrit.wikimedia.org/r/#/c/labs/tools/wikibugs2/+/464868 [19:22:14] harej: exactly. It's mostly inevitable though... [19:22:58] I imagine most of the schema changes we'll be making in the short-to-mid-term are additions of new things, where old clients would just ignore the new things they don't understand? [19:23:42] awight: not sure of the context, but what about Wikilabels? [19:24:01] and revscoring, and contentquality? [19:24:06] The individual models [19:24:12] which IIRC have phabricator tags [19:24:56] There are lots of schemas, which in particular do you mean? The API responses? [19:25:13] The context of that bug is wiki page content, fwiw. [19:29:37] I mean wiki page content. [19:29:52] API deprecation is a substantially less scary topic [19:35:27] :) [19:36:14] I'm still unclear on the schema migration you're referring to, is this like when drafttopic gets a new set of topics? [19:36:37] That's a good point and doesn't seem to be handled nicely by versioning, since there's may be no appropriate, lossless migration. [19:36:45] *there may [19:41:39] harej: I found some interesting code in CollaborationHubContent which parses and renders the content, but it's not clear to me whether that has a side-effect of populating the ParserOutput things, or if that's done elsewhere? [19:43:48] the ParserOutput is populated by the Parser object [19:55:22] Platonides: ooh funky! The code I'm looking at uses the $wgParser object though, so is this an invisible side-effect? [19:56:11] not invisible, I think a ParserOutput is returned by a Parser method (parse?) [19:56:43] I haven't looked at the code for a long time [19:58:15] Thanks for the note though, it's helpful! [19:59:23] yes, $wgParser->parse() returns a ParserOutput [20:00:46] do you have a link to the code you are looking at? [20:03:25] Platonides: Here's the initial parse, https://github.com/wikimedia/mediawiki-extensions-CollaborationKit/blob/master/includes/content/CollaborationHubContent.php#L262 [20:04:04] 10Scoring-platform-team, 10ORES, 10User-Ladsgroup: ores-misc-01 hasn't had a puppet run in a while - https://phabricator.wikimedia.org/T206361 (10Halfak) [20:04:21] However I *think* that later calls like https://github.com/wikimedia/mediawiki-extensions-CollaborationKit/blob/master/includes/content/CollaborationHubContent.php#L659 are affecting the ParserOutput [20:04:30] On second thought, I'm really not sure about that. [20:07:15] the parser uses a lot of black magic [20:08:00] it only uses three parameters to parse [20:08:06] so $clearState = true [20:08:27] which means clearState() is called [20:08:36] producing a new ParserOutput [20:09:08] OH MY [20:09:14] er.. no, actually none of those two calls uses eactly three parameters [20:09:30] but $clearState is true in them anyway [20:09:38] $clearState is an awesome find, ty [20:09:56] awight: Isarra is a good person to talk to about CollaborationKit's code. She wrote most of it. [20:10:09] parse → startParse → clearState [20:15:54] I'm trying to figure it out myself. >.> [20:16:10] xD [20:16:11] oh hai [20:16:33] Isarra: hahah thank you for that [20:16:45] 10Scoring-platform-team, 10ORES, 10User-Ladsgroup: ores-misc-01 hasn't had a puppet run in a while - https://phabricator.wikimedia.org/T206361 (10Halfak) I assigned this to @Ladsgroup because he is working on ores-misc-01 recently and might know what is up. [20:16:52] It's great code though! Just that it happens to interact with an evil monster from the depths of mw-core [20:17:04] Eeeeevil monster. [20:17:17] Actually for THAT part bawolff might know more... [20:17:35] parse this text pls. STAND BACK, the pwoer of Chthulu compels you! [20:18:27] gtg for a spell, unfortunately [20:18:50] Heh. [20:22:03] A spell. [20:34:55] harej, I see that "Women-related WikiProjects" is in your ontology. But also that North America is at the same level as "Americas" rather than being nested :P [20:35:20] halfak: this is the community's ontology. i just follow the category tree. [20:35:37] Ahh. Where would I edit this ontology? [20:35:44] By re-categorizing WikiProjects [20:36:15] I think nesting the North America WikiProjects category under Americas is uncontroversial [20:37:59] halfak: https://en.wikipedia.org/w/index.php?title=Category%3ANorth_America-related_WikiProjects&type=revision&diff=862659180&oldid=689859697&diffmode=source [20:38:12] Ahh! Categories. [20:38:14] * halfak runs away [20:52:22] Women is under history and society -- not Biography :| [20:52:38] Maybe women's issues or some more general term? [20:53:47] Depends on whether "Women" here is referring to women-related subjects or individual women [20:53:56] And it's most likely both [20:54:06] Right. Seems like "Women" is a useful category independent of "Women's issues" [20:54:33] Some "Women" have nothing direct to do with "Women's issues" [20:54:51] Or want anything to do with women's issues. [20:56:51] Right. OK that makes sense. [20:59:00] Maybe under politics. With LGBTQ or maybe gender studies? [21:00:00] History and society > Politics > Queer issues > Gender [21:00:05] Seems to make sense to me. [21:00:14] As an example [21:10:56] * awight dons ontology-proof shades [21:23:53] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464885 (owner: 10L10n-bot) [21:29:58] I think I'm on a roll now. But need to flee for another hour or so. [21:58:29] Welp, this is going to take a long time, but I think it's working OK. [21:58:30] https://en.wikipedia.org/wiki/User:EpochFail/WikiProject_Directory [21:58:54] I'm building the hierarchy and addressing bugs as I work through the WikiProjects. [21:59:19] But that's enough for today. Have a good weekend, folks! [21:59:24] Back on Tuesday! [22:37:15] 10Scoring-platform-team, 10Wikilabels, 10articlequality-modeling, 10artificial-intelligence: Build article quality model for Galician Wikipedia - https://phabricator.wikimedia.org/T201146 (10Elisardojm) "FA" is "AC" "GA" is "AB" "B" is "B" "C" is "C" "Start" is "En Progreso" "Stub" is "Bosquexo" "Assessmen... [23:22:08] harej: FYI, I'm stuck doing another errand, have a fun weekend!